nridge updated this revision to Diff 528189.
nridge marked 3 inline comments as done.
nridge added a comment.
Herald added a subscriber: mgrang.
Address review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151190/new/
https://reviews.llvm.
nridge updated this revision to Diff 528190.
nridge added a comment.
Add comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151190/new/
https://reviews.llvm.org/D151190
Files:
clang-tools-extra/clangd/ClangdServer.cpp
clang-tools-extra/clan
DanWillans added a comment.
Herald added a subscriber: MaskRay.
Herald added a project: All.
Hi all,
Has there been any progress on this? I want to run clang-tidy on some code
being compiled in debug with MSVC but I hit the clang-diagnostic-error note
'D.Diag(clang::diag::note_drv_address_sanit
hazohelet created this revision.
hazohelet added reviewers: aaron.ballman, tbaeder, erichkeane.
Herald added a reviewer: NoQ.
Herald added a project: All.
hazohelet requested review of this revision.
Herald added a project: clang.
This patch introduces a new warning flag `-Wtautological-negation-c
cor3ntin updated this revision to Diff 528205.
cor3ntin added a comment.
Remove missed and useless llvm:: specifier
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151094/new/
https://reviews.llvm.org/D151094
Files:
clang/docs/ReleaseNotes.rst
c
Author: Sergei Barannikov
Date: 2023-06-04T14:35:32+03:00
New Revision: e8bd2a57849e1c193341db99186abb903eb9579d
URL:
https://github.com/llvm/llvm-project/commit/e8bd2a57849e1c193341db99186abb903eb9579d
DIFF:
https://github.com/llvm/llvm-project/commit/e8bd2a57849e1c193341db99186abb903eb9579d.d
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe8bd2a57849e: [clang][CodeGen] Break up TargetInfo.cpp [6/8]
(authored by barannikov88).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST A
barannikov88 updated this revision to Diff 528208.
barannikov88 added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150215/new/
https://reviews.llvm.org/D150215
Files:
clang/lib/CodeGen/TargetInfo.cpp
clang/lib/CodeGen/Target
barannikov88 updated this revision to Diff 528209.
barannikov88 added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148094/new/
https://reviews.llvm.org/D148094
Files:
clang/docs/UsersManual.rst
clang/docs/tools/clang-formatt
zyounan added inline comments.
Comment at: clang-tools-extra/clangd/InlayHints.cpp:267
StructuredBindingPolicy = TypeHintPolicy;
StructuredBindingPolicy.PrintCanonicalTypes = true;
}
`PrintCanonicalTypes` turns on printing default template arguments,
cor3ntin created this revision.
Herald added a project: All.
cor3ntin requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
The C++ standard allows abstract parameters in deleted functions
and in function declarations
> The type of a parameter o
charmitro updated this revision to Diff 528219.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151833/new/
https://reviews.llvm.org/D151833
Files:
clang/lib/Frontend/TextDiagnostic.cpp
clang/test/Frontend/absolute-paths-import.h
clang/test/Frontend/absolute-paths.c
Index: clang/te
Author: Manna, Soumi
Date: 2023-06-04T09:09:59-07:00
New Revision: c7550310738b27aec440e5d20cec7f0209d45721
URL:
https://github.com/llvm/llvm-project/commit/c7550310738b27aec440e5d20cec7f0209d45721
DIFF:
https://github.com/llvm/llvm-project/commit/c7550310738b27aec440e5d20cec7f0209d45721.diff
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc7550310738b: [NFC][CLANG] Fix Static Code Analyzer Concerns
(authored by Manna).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151947/new/
https://reviews.
Author: Manna, Soumi
Date: 2023-06-04T09:35:44-07:00
New Revision: b0525f66988eac69138ba4ca30f5f07ff5218093
URL:
https://github.com/llvm/llvm-project/commit/b0525f66988eac69138ba4ca30f5f07ff5218093
DIFF:
https://github.com/llvm/llvm-project/commit/b0525f66988eac69138ba4ca30f5f07ff5218093.diff
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb0525f66988e: [NFC][CLANG] [NFC][CLANG] Fix nullptr
dereference issue in… (authored by Manna).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151928/new/
htt
Manna abandoned this revision.
Manna added a comment.
This is False Positive. Closing the PR.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151010/new/
https://reviews.llvm.org/D151010
___
cfe-commits ma
Manna created this revision.
Manna added a reviewer: erichkeane.
Herald added subscribers: ctetreau, tschuett.
Herald added a project: All.
Manna requested review of this revision.
Herald added a project: clang.
This patch uses castAs instead of getAs which will assert if the type doesn't
match i
Krishna-13-cyber created this revision.
Krishna-13-cyber added reviewers: v.g.vassilev, QuillPusher, davidlange6.
Herald added a project: All.
Krishna-13-cyber requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Update Clang-repl documentation
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151339/new/
https://reviews.llvm.org/D151339
_
Sinitax updated this revision to Diff 528256.
Sinitax added a comment.
Add new warning to its own group.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152083/new/
https://reviews.llvm.org/D152083
Files:
clang/include/clang/Basic/DiagnosticGroups.td
clang/include/clang/Basic/Diagnos
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4b27ad735c8d: [AIX] use system assembler for assembly files
(authored by shchenz).
Changed prior to commit:
https://reviews.llvm.org/D148490?vs=521233&id=528257#toc
Repository:
rG LLVM Github Monorep
Author: Chen Zheng
Date: 2023-06-04T21:37:48-04:00
New Revision: 4b27ad735c8da7cd21a7ea58614ebd4d3c940a89
URL:
https://github.com/llvm/llvm-project/commit/4b27ad735c8da7cd21a7ea58614ebd4d3c940a89
DIFF:
https://github.com/llvm/llvm-project/commit/4b27ad735c8da7cd21a7ea58614ebd4d3c940a89.diff
LO
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rG29663e2b8c4e: [clang][CodeGen] Account for VTT address space
(authored by AlexVlx).
Repository:
rG LLVM Github Monorepo
Author: Alex Voicu
Date: 2023-06-05T03:06:25+01:00
New Revision: 29663e2b8c4edcd850a4245b1f9509f974220906
URL:
https://github.com/llvm/llvm-project/commit/29663e2b8c4edcd850a4245b1f9509f974220906
DIFF:
https://github.com/llvm/llvm-project/commit/29663e2b8c4edcd850a4245b1f9509f974220906.diff
LO
akshaykhadse added a comment.
@craig.topper, @skan: Does this look good?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151863/new/
https://reviews.llvm.org/D151863
___
cfe-commits mailing list
cfe-commit
zixuan-wu added inline comments.
Comment at: clang/test/CodeGen/builtins-nondeterministic-value.c:26
+// CHECK-LABEL: entry
+// CHECK: [[A:%.*]] = alloca double, align 8
+// CHECK: store double [[X:%.*]], ptr [[A]], align 8
hi, @ManuelJBrito , because double is 4
ychen updated this revision to Diff 528268.
ychen marked 14 inline comments as done.
ychen added a comment.
- address existing comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139837/new/
https://reviews.llvm.org/D139837
Files:
clang/docs/
ychen added inline comments.
Comment at: clang/include/clang/AST/DeclBase.h:1689
+/// (used during overload resolution).
+uint64_t DeductionCandidateKind : 2;
aaron.ballman wrote:
> Best not to give this the same name as a type (I don't care which one c
skan added a comment.
Replace the url of the picture in the summary with the plain text?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151863/new/
https://reviews.llvm.org/D151863
___
cfe-commits mailing
skan added inline comments.
Comment at: llvm/test/MC/X86/x86-64-movdir64b-intel.s:1
+// RUN: llvm-mc -triple x86_64-unknown-unknown -x86-asm-syntax=intel
-output-asm-variant=1 --show-encoding %s | FileCheck %s
+// CHECK: movdir64b rax, zmmword ptr [rax - 4096]
T
cor3ntin added inline comments.
Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:1059-1062
+case CodeSynthesisContext::BuildingDeductionGuides:
+ assert(
+ false &&
+ "failed building deduction guides, add meaningful diagnostics here");
--
akshaykhadse added inline comments.
Comment at: llvm/test/MC/X86/x86-64-movdir64b-intel.s:1
+// RUN: llvm-mc -triple x86_64-unknown-unknown -x86-asm-syntax=intel
-output-asm-variant=1 --show-encoding %s | FileCheck %s
+// CHECK: movdir64b rax, zmmword ptr [rax - 4096]
--
bryanpkc updated this revision to Diff 528291.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134681/new/
https://reviews.llvm.org/D134681
Files:
clang/include/clang/Basic/arm_sme.td
clang/test/CodeGen/aarch64-sme-intrinsics/acle_sme_mopa-za32.c
bryanpkc updated this revision to Diff 528293.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142702/new/
https://reviews.llvm.org/D142702
Files:
clang/lib/Driver/ToolChains/Arch/AArch64.cpp
clang/test/Driver/aarch64-implied-sme-features.c
clan
bryanpkc added a comment.
@sdesmalen Could you review this and the rest of the patch stack?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128648/new/
https://reviews.llvm.org/D128648
___
cfe-commits mail
skan added inline comments.
Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:1780
// Otherwise, we set the base register to a non-zero value
- // if we don't know the actual value at this time. This is necessary to
+ // if we don't know the actual value at this ti
akshaykhadse added inline comments.
Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:1780
// Otherwise, we set the base register to a non-zero value
- // if we don't know the actual value at this time. This is necessary to
+ // if we don't know the actual value at
skan added inline comments.
Comment at: llvm/test/MC/X86/x86-64-movdir64b-intel.s:1
+// RUN: llvm-mc -triple x86_64-unknown-unknown -x86-asm-syntax=intel
-output-asm-variant=1 --show-encoding %s | FileCheck %s
+// CHECK: movdir64b rax, zmmword ptr [rax - 4096]
a
Author: esmeyi
Date: 2023-06-05T02:50:47-04:00
New Revision: 6f57d8df2d5f81fa8efe1020aaa5f6017fba10c6
URL:
https://github.com/llvm/llvm-project/commit/6f57d8df2d5f81fa8efe1020aaa5f6017fba10c6
DIFF:
https://github.com/llvm/llvm-project/commit/6f57d8df2d5f81fa8efe1020aaa5f6017fba10c6.diff
LOG: R
40 matches
Mail list logo