[PATCH] D151863: [x86][MC] Fix movdir64b addressing

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86Operand.h:386 return false; +if (getMemDisp()->getKind() == llvm::MCExpr::SymbolRef) + return true; Wouldn't this allow "symbol + %eax" to pick the 64-bit instruction

[PATCH] D148490: [AIX] use system assembler for assembly files

shchenz added inline comments. Comment at: clang/test/Driver/target-as.s:1 // Make sure the -march is passed down to cc1as. // RUN: %clang -target i386-unknown-freebsd -### -c -integrated-as %s \ MaskRay wrote: > shchenz wrote: > > MaskRay wrote: > > > aix-as.c

[PATCH] D151923: [APFloat] Add APFloat semantic support for TF32

jfurtek added a comment. In D151923#4389405 , @mehdi_amini wrote: > I think this LG, but David had to update clang/lib/AST/MicrosoftMangle.cpp > when some other float format was added, you don't need this here? I did update that file - it is part of th

[PATCH] D151625: [clang] Add `clang::equality_operator_compares_members_lexicographically`

philnik updated this revision to Diff 527704. philnik marked 2 inline comments as done. philnik added a comment. Herald added a subscriber: jdoerfert. - Address comments - Try to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151625/new/ http

[PATCH] D151923: [APFloat] Add APFloat semantic support for TF32

mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. Ok, sorry I missed the mangle update, seeing how I missed the MLIR mention as well: I need more sleep!! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse added inline comments. Comment at: clang/test/CodeGen/ms-inline-asm-64.c:79 + int arr[1000]; + __asm enqcmds rax, zmmword ptr [arr] + // CHECK: call void asm sideeffect inteldialect "enqcmds rax, zmmword ptr $0", "*m,~{flags},~{dirflag},~{fpsr},~{flags}"(ptr elem

[PATCH] D151963: [clang][NFC] Remove trailing whitespaces and enforce it in lib, include and docs

philnik created this revision. philnik added reviewers: erichkeane, aaron.ballman. Herald added subscribers: luke, steakhal, frasercrmck, martong, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD,

[PATCH] D151964: [NFC][CLANG] Fix Static Code Analyzer Concerns with dereference null return value in applyObjCTypeArgs()

Manna created this revision. Manna added a reviewer: erichkeane. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch uses castA

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

jacquesguan added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2219 + def vfwcvt_f_f_v : RVVConvBuiltin<"w", "wv", "f", "vfwcvt_f">; + let RequiredFeatures = ["ZvfhminOrZvfh"] in +def vfwcvt_f_f_v_fp16 : RVVConvBuiltin<"w", "wv", "x", "vfwcvt_f"> {

[PATCH] D151954: [clang-format] Fix overlapping whitespace replacements before PPDirective

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:1425 + const SmallVectorImpl &Lines, + const FormatToken &RootToken, + const FormatStyle &Style) {

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse updated this revision to Diff 527725. akshaykhadse added a comment. Update AsmParser Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151863/new/ https://reviews.llvm.org/D151863 Files: clang/test/CodeGen/ms-inline-asm-64.c clang/tes

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:1781 + // value at this time. + BaseReg = BaseReg ? BaseReg : 0; Operands.push_back(X86Operand::CreateMem( This sets BaseReg to 0 if its already 0? Repository:

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86Operand.h:386 return false; +if (getMemBaseReg() == X86::NoRegister) + return true; Now we're not checking the index register if there is no base register? Reposito

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:1781 + // value at this time. + BaseReg = BaseReg ? BaseReg : 0; Operands.push_back(X86Operand::CreateMem( craig.topper wrote: > This sets BaseReg to 0 if its alre

[PATCH] D151952: [clang] adds `__type_pack_index` so we can get a type's parameter pack index

dblaikie added inline comments. Comment at: clang/include/clang/AST/Stmt.h:796-802 +/// If this expression is not value-dependent, this stores the value. +unsigned Value : 8; /// The number of arguments to this type trait. According to [implimits] /// 8 bits w

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86Operand.h:386 return false; +if (getMemBaseReg() == X86::NoRegister) + return true; craig.topper wrote: > Now we're not checking the index register if there is no bas

[PATCH] D151662: [clang] [test] Fix test failures due to -Wbuiltin-macro-redefined in MinGW mode

mstorsjo abandoned this revision. mstorsjo added a comment. Superseded by D151741 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151662/new/ https://reviews.llvm.org/D151662 __

[PATCH] D151730: [RISCV] Support target attribute for function

BeMg updated this revision to Diff 527748. BeMg added a comment. 1. Update RTS's function name 2. Add backend testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https://reviews.llvm.org/D151730 Files: clang/include/clang/Basic/Ta

[PATCH] D151094: [clang] Implement P2564 "consteval must propagate up"

cor3ntin added a comment. @shafik @Fznamznon @erichkeane gentle ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151094/new/ https://reviews.llvm.org/D151094 ___ cfe-commits mailing list cfe-commits

[PATCH] D151215: [clang][Diagnostics] Split source ranges into line ranges before...

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. Looks good to me too! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151215/new/ https://reviews.llvm.org/D151215 __

[clang] f1a318b - [clang][Interp][NFC] Add FunctionPointer.h header comment

Author: Timm Bäder Date: 2023-06-02T08:38:13+02:00 New Revision: f1a318b3ddd2d224ab37fa397d63c767f516085d URL: https://github.com/llvm/llvm-project/commit/f1a318b3ddd2d224ab37fa397d63c767f516085d DIFF: https://github.com/llvm/llvm-project/commit/f1a318b3ddd2d224ab37fa397d63c767f516085d.diff LO

[clang] cc69bc4 - [clang][Interp][NFC] Print Function name in unreachable type failures

Author: Timm Bäder Date: 2023-06-02T08:38:13+02:00 New Revision: cc69bc4254ba9cb4316ca2b304fbb3230e38ed63 URL: https://github.com/llvm/llvm-project/commit/cc69bc4254ba9cb4316ca2b304fbb3230e38ed63 DIFF: https://github.com/llvm/llvm-project/commit/cc69bc4254ba9cb4316ca2b304fbb3230e38ed63.diff LO

[clang] fc1262b - [clang][Diagnostics] Split source ranges into line ranges before...

Author: Timm Bäder Date: 2023-06-02T08:52:03+02:00 New Revision: fc1262bd58ac54ad0a0bfa9750254b81c742bbb5 URL: https://github.com/llvm/llvm-project/commit/fc1262bd58ac54ad0a0bfa9750254b81c742bbb5 DIFF: https://github.com/llvm/llvm-project/commit/fc1262bd58ac54ad0a0bfa9750254b81c742bbb5.diff LO

[PATCH] D151215: [clang][Diagnostics] Split source ranges into line ranges before...

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfc1262bd58ac: [clang][Diagnostics] Split source ranges into line ranges before... (authored by tbaeder). Changed prior to commit: https://reviews.

[PATCH] D151315: [clangd] Add a switch to specify a default clangd configuration file

voertler added a reviewer: sammccall. voertler added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151315/new/ https://reviews.llvm.org/D151315 ___ cfe-commits mailing list cfe-commits@li

<    1   2   3