[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

fahadnayyar updated this revision to Diff 527241. fahadnayyar added a comment. Passing -L /bin/../lib/ unconditionally to the linker. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148266/new/ https://reviews.llvm.org/D148266 Files: clang/lib/Dri

[PATCH] D151595: [BOLT][CMake] Redo the build and install targets

phosek updated this revision to Diff 527243. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151595/new/ https://reviews.llvm.org/D151595 Files: bolt/CMakeLists.txt bolt/cmake/modules/AddBOLT.cmake bolt/test/CMakeLists.txt bolt/tools/CMakeList

[PATCH] D151595: [BOLT][CMake] Redo the build and install targets

phosek marked 2 inline comments as done. phosek added inline comments. Comment at: bolt/test/CMakeLists.txt:40 llvm-bolt - llvm-boltdiff llvm-bolt-heatmap Amir wrote: > We have a number of dependencies on llvm-boltdiff and perf2bolt, e.g. in > internal an

[PATCH] D151589: [lld] add context-sensitive PGO options for MachO

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85af42df5dbb: [lld] add context-sensitive PGO options for MachO (authored by ellis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang] 85af42d - [lld] add context-sensitive PGO options for MachO

Author: Ellis Hoag Date: 2023-05-31T17:53:46-07:00 New Revision: 85af42df5dbb964d767feb16a5551dddb36fd4f1 URL: https://github.com/llvm/llvm-project/commit/85af42df5dbb964d767feb16a5551dddb36fd4f1 DIFF: https://github.com/llvm/llvm-project/commit/85af42df5dbb964d767feb16a5551dddb36fd4f1.diff LO

[clang] bf8fe1c - Fix clang driver tests for cspgo in lld

Author: Ellis Hoag Date: 2023-05-31T18:21:41-07:00 New Revision: bf8fe1c38f1031c88c80e0e86ffea4375e7693ff URL: https://github.com/llvm/llvm-project/commit/bf8fe1c38f1031c88c80e0e86ffea4375e7693ff DIFF: https://github.com/llvm/llvm-project/commit/bf8fe1c38f1031c88c80e0e86ffea4375e7693ff.diff LO

[PATCH] D150988: [clang][Darwin] Error out when missing requested libarclite library

ravikandhadai added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:623 +def err_drv_darwin_sdk_missing_arclite : Error< + "SDK does not contain 'libarclite' at the path '%0'. This likely means you need to increase your minimum deployment target"

[PATCH] D151595: [BOLT][CMake] Redo the build and install targets

Amir accepted this revision. Amir added a comment. Thanks. Will update the dependencies, removing always-installed symlinks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151595/new/ https://reviews.llvm.org/D151595 ___

[PATCH] D150988: [clang][Darwin] Error out when missing requested libarclite library

keith updated this revision to Diff 527261. keith added a comment. Improve error message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150988/new/ https://reviews.llvm.org/D150988 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang

[PATCH] D146664: Apply the same fallbacks as runtimes search for stdlib search

glandium added a comment. In D146664#4352695 , @thakis wrote: > Is it possible to test this? I don't know how. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146664/new/ https://reviews.llvm.org/D146664 _

[PATCH] D151837: [Clang][Parser] Accept GNU attributes preceding C++ style attributes on templates

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Could you add a test case for the inverted order of attributes on a template as well? I don't think that there is a test case for that. CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D151720: [clang][ExprConstant] Fix display of syntactically-invalid note for member function calls

tbaeder added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:1925 if (This && IsMemberCall) { -APValue Val; -This->moveInto(Val); -Val.printPretty(Out, Info.Ctx, -This->Designator.MostDerivedType); -// FIXME: Add parens around V

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

tbaeder added a comment. Can you add a test case for the change? Looks like there's something similar already in `clang/test/Frontend/absolute-paths.c` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151833/new/ https://reviews.llvm.org/D151833 ___

[PATCH] D150221: Add option -fkeep-static-variables to emit all static variables

hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2201-2210 + if ((CodeGenOpts.KeepStaticConsts || CodeGenOpts.KeepStaticVariables) && D && + isa(D)) { const auto *VD = cast(D); -if (VD->getType().isConstQualified() && -

[PATCH] D150221: Add option -fkeep-static-variables to emit all static variables

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/keep-static-variables.cpp:1 +// RUN: %clang_cc1 -fkeep-static-variables -emit-llvm %s -o - -triple=x86_64-unknown-linux-gnu | FileCheck %s --check-prefixes=CHECK,CHECK-ELF +// RUN: %clang_cc1 -fkeep-sta

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops added a comment. Can someone please let me know the following changes that I did in my latest patch? 1. clang/test/OpenMP/generic_loop_ast_print.cpp is failing because of the mapped directives. It is because of –ast-print & -ast-dump. This is because when the Sema comes across "omp loop

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseLabels

galenelias added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:790 + +**AlignConsecutiveShortCaseLabels** (``AlignConsecutiveStyle``) :versionbadge:`clang-format 17` :ref:`¶ ` + Style of aligning consecutive short case labels. MyDeveloperD

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

marginstrawberries added a comment. Herald added a subscriber: pcwang-thead. In D128059#3640424 , @cor3ntin wrote: > @aaron.ballman Thanks for the review. I landed the changes and got a bunch of > bots screaming at me for changes that are completely unre

[PATCH] D148490: [AIX] use system assembler for assembly files

shchenz added inline comments. Comment at: clang/test/Driver/target-as.s:1 // Make sure the -march is passed down to cc1as. // RUN: %clang -target i386-unknown-freebsd -### -c -integrated-as %s \ MaskRay wrote: > aix-as.c will be more appropriate. Do you mean w

[PATCH] D149867: [M68k] Add Clang support for the new M68k_RTD CC

0x59616e accepted this revision. 0x59616e added a comment. This revision is now accepted and ready to land. Though creating our own calling convention is better, I think Min's path is correct at this moment given that m68k is still an experimental target. We can reignite this discussion once we'

[PATCH] D149867: [M68k] Add Clang support for the new M68k_RTD CC

jrtc27 requested changes to this revision. jrtc27 added a comment. This revision now requires changes to proceed. I disagree. Being experimental doesn't mean you should do the wrong thing. Reusing std call in the frontend is ugly, pollutes non-m68k code paths (doing your own thing _avoids_ that

[PATCH] D151595: [BOLT][CMake] Redo the build and install targets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf99a7d3e3809: [BOLT][CMake] Redo the build and install targets (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang] 2a9e636 - Revert "[Fuchsia] Pass through LLVM_ENABLE_HTTPLIB to stage 2"

Author: Petr Hosek Date: 2023-06-01T06:04:16Z New Revision: 2a9e6363ef0dc816a8862ab39d2782dfe96d0e7d URL: https://github.com/llvm/llvm-project/commit/2a9e6363ef0dc816a8862ab39d2782dfe96d0e7d DIFF: https://github.com/llvm/llvm-project/commit/2a9e6363ef0dc816a8862ab39d2782dfe96d0e7d.diff LOG: Re

[PATCH] D151325: [analyzer] Differentiate lifetime extended temporaries

tomasz-kaminski-sonarsource updated this revision to Diff 527291. tomasz-kaminski-sonarsource added a comment. Rebasing on main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151325/new/ https://reviews.llvm.org/D151325 Files: clang/include/clang

[PATCH] D151720: [clang][ExprConstant] Fix display of syntactically-invalid note for member function calls

hazohelet updated this revision to Diff 527294. hazohelet added a comment. Address comments from @tbaeder - Change `dyn_cast_or_null` to `dyn_cast_if_present` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151720/new/ https://reviews.llvm.org/D151720 Files: clang/docs/ReleaseNotes.rs

[PATCH] D151720: [clang][ExprConstant] Fix display of syntactically-invalid note for member function calls

hazohelet marked 2 inline comments as done. hazohelet added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:1933 +} else if (const auto *OCE = + dyn_cast_or_null(CallExpr)) { + OCE->getArg(0)->printPretty(Out, nullptr, Info.Ctx.getPrintingPo

<    1   2   3