[PATCH] D151349: [HIP] emit macro `__HIP_NO_IMAGE_SUPPORT`

tra added inline comments. Comment at: clang/lib/Basic/Targets/AMDGPU.cpp:248 + auto ISAVer = llvm::AMDGPU::getIsaVersion(Opts.CPU); + HasImage = ISAVer.Major != 9 || ISAVer.Minor != 4; } My usual nit about negations: `!(ISAVer.Major == 9 && ISAVer.Minor == 4)

[clang] d6e1909 - Mark header as textual

Author: Adrian Prantl Date: 2023-05-30T09:21:39-07:00 New Revision: d6e1909526fea196e20566d7d66c1b6ca04fa9e5 URL: https://github.com/llvm/llvm-project/commit/d6e1909526fea196e20566d7d66c1b6ca04fa9e5 DIFF: https://github.com/llvm/llvm-project/commit/d6e1909526fea196e20566d7d66c1b6ca04fa9e5.diff

[clang] 0989ce9 - [clang][analyzer][NFC] Move dyn_cast's into if statements for readability

Author: Dmitri Gribenko Date: 2023-05-30T18:22:43+02:00 New Revision: 0989ce947e3dd64f3e29e7c34f186c0a23c0323d URL: https://github.com/llvm/llvm-project/commit/0989ce947e3dd64f3e29e7c34f186c0a23c0323d DIFF: https://github.com/llvm/llvm-project/commit/0989ce947e3dd64f3e29e7c34f186c0a23c0323d.dif

[PATCH] D151725: [clang][analyzer][NFC] Move dyn_cast's into if statements for readability

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0989ce947e3d: [clang][analyzer][NFC] Move dyn_cast's into if statements for readability (authored by gribozavr). Repository: rG LLVM Github Monore

[clang] 8a40f89 - [clang][analyzer][NFC] Replace dyn_cast with cast in MemRegion::getMemorySpace

Author: Dmitri Gribenko Date: 2023-05-30T18:30:30+02:00 New Revision: 8a40f89e2e9357539db0f9a119db0fcfc77232ab URL: https://github.com/llvm/llvm-project/commit/8a40f89e2e9357539db0f9a119db0fcfc77232ab DIFF: https://github.com/llvm/llvm-project/commit/8a40f89e2e9357539db0f9a119db0fcfc77232ab.dif

[PATCH] D151727: [clang][analyzer][NFC] Replace dyn_cast with cast in MemRegion::getMemorySpace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a40f89e2e93: [clang][analyzer][NFC] Replace dyn_cast with cast in MemRegion::getMemorySpace (authored by gribozavr). Repository: rG LLVM Github M

[PATCH] D151730: [WIP][RISCV] Support target attribute for function

craig.topper added inline comments. Comment at: clang/test/CodeGen/RISCV/riscv-func-attr-target.c:1 +// REQUIRES: riscv-registered-target +// RUN: %clang -target riscv64 -march=rv64g -S %s -o - | FileCheck %s No test for tune=? Repository: rG LLVM Github Mono

[PATCH] D151590: [Driver] Add ClangFlags::TargetSpecific to simplify err_drv_unsupported_opt_for_target processing

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. Nice improvement! Some tests seem to be failing due to the changes, but once those are fixed, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D151606: [NFC][CLANG] Fix Static Code Analyzer Concerns with bad bit right shift operation in getNVPTXLaneID()

tra added a comment. In practice we're guaranteed by GPU architecture that the warp size will always be small enough to fit in 32 bits. Also `log2_32` will never return a value larger than 32. Does this assert help with anything else other than potential undefined behavior? CHANGES SINCE LAS

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

michaelmaitland accepted this revision. michaelmaitland added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150253/new/ https://reviews.llvm.org/D150253

[PATCH] D148723: [clang] Restrict Inline Builtin to non-static, non-odr linkage

serge-sans-paille added a comment. In D148723#4380165 , @mstorsjo wrote: > This causes failed asserts with `_FORTIFY_SOURCE` with the mingw-w64 headers. > Here's a reduced reproducer: > > $ cat reduced.c > typedef unsigned int size_t; > > void *

[PATCH] D151088: [flang][hlfir] Separate -emit-fir and -emit-hlfir for flang-new

tblah updated this revision to Diff 526681. tblah marked an inline comment as done. tblah added a comment. Thanks for review! Changes: - Fix assertion comment - Change the -emit-mlir flag to be an alias for -emit-fir (previously they were the other way around). This does not address review comm

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

craig.topper requested changes to this revision. craig.topper added a comment. This revision now requires changes to proceed. We need to support reinterpret intrinsics so that we can load/store bf16 values. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

aprantl added a comment. If we can come up with a counterexample where the heuristic in this patch is doing the wrong thin then I think emitting a DW_AT_LLVM_no_unique_address attribute sounds reasonable to me. But otherwise I don't see a problem with using a heuristic. Repository: rG LLVM

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaRISCVVectorLookup.cpp:200 + bool HasZvfhminOrZvfh = TI.hasFeature("experimental-zvfhmin") || + TI.hasFeature("experimental-zvfh"); You can reuse `HasZvfh` here Reposi

[clang] 93f8554 - [RISCV] Correct capitalization of SiFive in a comment. NFC

Author: Craig Topper Date: 2023-05-30T09:51:49-07:00 New Revision: 93f8554e65449903a4de4bae4b2f6a09b4129fb6 URL: https://github.com/llvm/llvm-project/commit/93f8554e65449903a4de4bae4b2f6a09b4129fb6 DIFF: https://github.com/llvm/llvm-project/commit/93f8554e65449903a4de4bae4b2f6a09b4129fb6.diff

[PATCH] D134680: [Clang][AArch64][SME] Add intrinsics for adding vector elements to ZA tile

bryanpkc updated this revision to Diff 526683. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134680/new/ https://reviews.llvm.org/D134680 Files: clang/include/clang/Basic/arm_sme.td clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/aarch64-sm

[PATCH] D151349: [HIP] emit macro `__HIP_NO_IMAGE_SUPPORT`

arsenm added a comment. In D151349#4377792 , @yaxunl wrote: > using ISA version to determine whether image is supported That’s backward. You can track the feature in clang separately and just not emit it. We do that for a few other features. You just st

[PATCH] D151732: [clang][docs] document __attribute__((cleanup())) GNU C extension

nickdesaulniers created this revision. nickdesaulniers added reviewers: erichkeane, aaron.ballman. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Provide an example of how to use this extension

[PATCH] D150212: [clang][Sema] Improve diagnostics for auto return type

yaxunl added inline comments. Comment at: clang/include/clang/Sema/TemplateDeduction.h:338 public: - TemplateSpecCandidateSet(SourceLocation Loc, bool ForTakingAddress = false) : Loc(Loc), ForTakingAddress(ForTakingAddress) {} rsmith wrote: > Do we need

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

AlexVlx updated this revision to Diff 526692. AlexVlx added a comment. Updated the test to capture suggested VTT use cases (hopefully all). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150746/new/ https://reviews.llvm.org/D150746 Files: clang/lib/CodeGen/ItaniumCXXABI.cpp clang/te

[PATCH] D150212: [clang][Sema] Improve diagnostics for auto return type

yaxunl updated this revision to Diff 526693. yaxunl added a comment. revised by Richard's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150212/new/ https://reviews.llvm.org/D150212 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaOverload.cpp clang/lib/Sema/Sema

[PATCH] D151732: [clang][docs] document __attribute__((cleanup())) GNU C extension

erichkeane accepted this revision. erichkeane added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/AttrDocs.td:7010 + +Will result in a call to ``bar`` then ``foo`` as ``y`` goes out of scope before +``x``.

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

AlexVlx added a comment. In D150746#4357837 , @rjmccall wrote: > I see. Yes, in that case I think you're right that we can't test this yet — > only base-subobject ctors and dtors get VTT parameters, we only emit calls to > those from other ctors and dt

[clang] 85670ac - [Format/ObjC] Support NS_ASSUME_NONNULL_BEGIN and FOUNDATION_EXPORT in ObjC language guesser

Author: Ben Hamilton Date: 2023-05-30T11:12:03-06:00 New Revision: 85670ac86813b170c9301aa477421c56a71a7e1e URL: https://github.com/llvm/llvm-project/commit/85670ac86813b170c9301aa477421c56a71a7e1e DIFF: https://github.com/llvm/llvm-project/commit/85670ac86813b170c9301aa477421c56a71a7e1e.diff

[PATCH] D151578: [Format/ObjC] Support NS_ASSUME_NONNULL_BEGIN and FOUNDATION_EXPORT in ObjC language guesser

This revision was automatically updated to reflect the committed changes. Closed by commit rG85670ac86813: [Format/ObjC] Support NS_ASSUME_NONNULL_BEGIN and FOUNDATION_EXPORT in ObjC… (authored by benhamilton). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

RitanyaB updated this revision to Diff 526694. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146418/new/ https://reviews.llvm.org/D146418 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaDecl.cpp clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/declare_target_messages.cpp

[PATCH] D151720: [clang][ExprConstant] Fix display of syntactically-invalid note for member function calls

hazohelet added a comment. Thanks for the feedback. Comment at: clang/test/SemaCXX/constant-expression-cxx11.cpp:994 +static_assert(sobj.f(), ""); // expected-error {{constant expression}} expected-note {{in call to 'sobj.f()'}} +static_assert(sptr->f(), ""); // expected-error

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

tra updated this revision to Diff 526697. tra added a comment. Updated according to comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151503/new/ https://reviews.llvm.org/D151503 Files: clang/lib/Headers/CMakeLists.txt Index: clang/lib/H

[PATCH] D150114: [Headers][doc] Add "add/sub/mul" intrinsic descriptions to avx2intrin.h

probinson marked an inline comment as done. probinson added inline comments. Comment at: clang/lib/Headers/avx2intrin.h:412 +///vectors of [16 x i16] and returns the lower 16 bits of each difference +///in an element of the [16 x i16] result (overflow is ignored). +///

[PATCH] D150114: [Headers][doc] Add "add/sub/mul" intrinsic descriptions to avx2intrin.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. probinson marked an inline comment as done. Closed by commit rGd8291908ef49: [Headers][doc] Add add/sub/mul intrinsic descriptions to avx2intrin.h (authored by probinso

[clang] d829190 - [Headers][doc] Add add/sub/mul intrinsic descriptions to avx2intrin.h

Author: Paul Robinson Date: 2023-05-30T10:15:18-07:00 New Revision: d8291908ef49e0d560276c19c552a67d9fb3ef1d URL: https://github.com/llvm/llvm-project/commit/d8291908ef49e0d560276c19c552a67d9fb3ef1d DIFF: https://github.com/llvm/llvm-project/commit/d8291908ef49e0d560276c19c552a67d9fb3ef1d.diff

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

tra added a comment. @qiongsiwu1 : I've updated the patch. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151503/new/ https://reviews.llvm.org/D151503 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:23127 + /// OMPDeclareTargetDeclAttr, and has global storage in the DeclVector. Pop + /// each Decl one at a time and use the inherited Visit functions to look for + /// DeclRefExpr. F

[PATCH] D151349: [HIP] emit macro `__HIP_NO_IMAGE_SUPPORT`

yaxunl added a comment. In D151349#4381471 , @arsenm wrote: > In D151349#4377792 , @yaxunl wrote: > >> using ISA version to determine whether image is supported > > That’s backward. You can track the feature in cl

[PATCH] D151732: [clang][docs] document __attribute__((cleanup())) GNU C extension

nickdesaulniers updated this revision to Diff 526703. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - fixup last sentence as per @erichkeane Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151732/new/ https://revi

[PATCH] D151732: [clang][docs] document __attribute__((cleanup())) GNU C extension

erichkeane accepted this revision. erichkeane added a comment. Still LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151732/new/ https://reviews.llvm.org/D151732 ___ cfe-commits mailing list cfe-comm

[PATCH] D151720: [clang][ExprConstant] Fix display of syntactically-invalid note for member function calls

erichkeane added inline comments. Comment at: clang/test/SemaCXX/constant-expression-cxx11.cpp:994 +static_assert(sobj.f(), ""); // expected-error {{constant expression}} expected-note {{in call to 'sobj.f()'}} +static_assert(sptr->f(), ""); // expected-error {{constant expressi

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

qiongsiwu1 accepted this revision. qiongsiwu1 added a comment. In D151503#4381548 , @tra wrote: > @qiongsiwu1 : I've updated the patch. PTAL. LGTM! Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang] 6cdc07a - [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

Author: Artem Belevich Date: 2023-05-30T10:44:33-07:00 New Revision: 6cdc07a701eec08da450be58d6e1b67428a983dd URL: https://github.com/llvm/llvm-project/commit/6cdc07a701eec08da450be58d6e1b67428a983dd DIFF: https://github.com/llvm/llvm-project/commit/6cdc07a701eec08da450be58d6e1b67428a983dd.diff

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6cdc07a701ee: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 6219b7c - [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines

Author: Deniz Evrenci Date: 2023-05-30T17:48:11Z New Revision: 6219b7c61a942fb8b6d931b4aac021d293cdde4d URL: https://github.com/llvm/llvm-project/commit/6219b7c61a942fb8b6d931b4aac021d293cdde4d DIFF: https://github.com/llvm/llvm-project/commit/6219b7c61a942fb8b6d931b4aac021d293cdde4d.diff LOG:

[PATCH] D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines

This revision was automatically updated to reflect the committed changes. Closed by commit rG6219b7c61a94: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines (authored by denizevrenci, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D150212: [clang][Sema] Improve diagnostics for auto return type

mizvekov accepted this revision. mizvekov added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150212/new/ https://reviews.llvm.org/D150212 ___ cfe-commits mailing list cfe-commi

[clang] bd9940a - [Driver][test] Properly test -mdefault-visibility-export-mapping=

Author: Fangrui Song Date: 2023-05-30T10:58:06-07:00 New Revision: bd9940a809e3e355a640a9ec45b0c666faec33be URL: https://github.com/llvm/llvm-project/commit/bd9940a809e3e355a640a9ec45b0c666faec33be DIFF: https://github.com/llvm/llvm-project/commit/bd9940a809e3e355a640a9ec45b0c666faec33be.diff

[PATCH] D151575: [clang][diagnostics] Always show include stacks on errors

cjdb added a comment. Thanks for working on this. Would you mind adding more context to the commit description please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151575/new/ https://reviews.llvm.org/D151575

[PATCH] D151575: [clang][diagnostics] Always show include stacks on errors

SlaterLatiao updated this revision to Diff 526717. SlaterLatiao added a comment. - Added release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151575/new/ https://reviews.llvm.org/D151575 Files: clang/docs/ReleaseNotes.rst clang/lib/Fron

[clang] 06ff977 - [clang][ExtractAPI] Refactor serializer to the CRTP

Author: Erick Velez Date: 2023-05-30T19:00:35+01:00 New Revision: 06ff9770477d8c7378047b0171db4b25eba5d8dd URL: https://github.com/llvm/llvm-project/commit/06ff9770477d8c7378047b0171db4b25eba5d8dd DIFF: https://github.com/llvm/llvm-project/commit/06ff9770477d8c7378047b0171db4b25eba5d8dd.diff L

[PATCH] D151477: [clang][ExtractAPI] Refactor serializer to the CRTP

This revision was automatically updated to reflect the committed changes. Closed by commit rG06ff9770477d: [clang][ExtractAPI] Refactor serializer to the CRTP (authored by evelez7, committed by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151

[PATCH] D151590: [Driver] Add ClangFlags::TargetSpecific to simplify err_drv_unsupported_opt_for_target processing

MaskRay updated this revision to Diff 526722. MaskRay added a comment. Rebase. Fix amdgpu. I suspect D145579 introduced latent -march= and -mcpu= interaction issues but I will leave the test coverage to amdgpu folks. Repository: rG LLVM Github Monorepo CHA

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

rjmccall added a comment. The process is pretty lightweight; I'd recommend just doing it if you expect to make more than one patch. But we don't have a policy against committing patches for other people as long as there's clear attribution in the commit. I do think you could successfully test

[clang] fbea5aa - [Driver] Add ClangFlags::TargetSpecific to simplify err_drv_unsupported_opt_for_target processing

Author: Fangrui Song Date: 2023-05-30T11:21:17-07:00 New Revision: fbea5aada14315da14c2e296831b1cb1cc1ddd61 URL: https://github.com/llvm/llvm-project/commit/fbea5aada14315da14c2e296831b1cb1cc1ddd61 DIFF: https://github.com/llvm/llvm-project/commit/fbea5aada14315da14c2e296831b1cb1cc1ddd61.diff

[PATCH] D151590: [Driver] Add ClangFlags::TargetSpecific to simplify err_drv_unsupported_opt_for_target processing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfbea5aada143: [Driver] Add ClangFlags::TargetSpecific to simplify… (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] 54d45dd - [clang-tidy][docs] Fix link to libc style guide

Author: Alex Brachet Date: 2023-05-30T18:22:26Z New Revision: 54d45ddc89f1e2d3250b4d5093bea28e6e475cb7 URL: https://github.com/llvm/llvm-project/commit/54d45ddc89f1e2d3250b4d5093bea28e6e475cb7 DIFF: https://github.com/llvm/llvm-project/commit/54d45ddc89f1e2d3250b4d5093bea28e6e475cb7.diff LOG:

[PATCH] D151502: [clang-tidy][docs] Fix link to libc style guide

This revision was automatically updated to reflect the committed changes. Closed by commit rG54d45ddc89f1: [clang-tidy][docs] Fix link to libc style guide (authored by abrachet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151502/new/ https://revi

[PATCH] D151741: [Lex] Only warn on defining or undefining language-defined builtins

john.brawn created this revision. john.brawn added reviewers: aaron.ballman, nathanchance, mstorsjo. Herald added a project: All. john.brawn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D144654 made it

[PATCH] D151743: [OMP] Fix compiler assert "DeclRefExpr for Decl not entered in LocalDeclMap?"

jyu2 created this revision. jyu2 added reviewers: ABataev, jdoerfert. jyu2 added projects: OpenMP, clang. Herald added a project: All. jyu2 requested review of this revision. Herald added subscribers: cfe-commits, jplehr, sstefan1. Currently compiler assert when passing variable "memspace" in omp_

[PATCH] D151743: [OMP] Fix compiler assert "DeclRefExpr for Decl not entered in LocalDeclMap?"

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151743/new/ https://reviews.llvm.org/D151743 ___

[PATCH] D151609: [Driver] Remove unused class ForceSuccessCommand

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. lgtm, thanks! (clicky: https://reviews.llvm.org/rG6625680a581c5e29c53d9f58d864cc6cd3cd05f6) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151609

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

nickdesaulniers added a comment. In D144654#4380488 , @john.brawn wrote: > gcc has the same warning so I wasn't expecting this cause to change problems, > but looking more closely at gcc's behaviour it looks like it only warns for > some builtin macros

[PATCH] D150212: [clang][Sema] Improve diagnostics for auto return type

rsmith accepted this revision. rsmith added a comment. LGTM too. Comment at: clang/test/SemaCXX/auto-type-from-cxx.cpp:31-43 +class Abstract{ + public: +void fun(); +virtual void vfun()=0; +void call(){getCaller()(*this);} // expected-note {{in instantiation of fu

[PATCH] D151741: [Lex] Only warn on defining or undefining language-defined builtins

nickdesaulniers added inline comments. Comment at: clang/test/Preprocessor/macro-reserved.c:19 #undef __STDC_HOSTED__ // expected-warning {{undefining builtin macro}} +#undef __INT32_TYPE__ Please add tests for the rest of https://reviews.llvm.org/D144654#4381

[PATCH] D145610: [clang][driver][AIX] accept maix32/maix64 gcc compat options

MaskRay added inline comments. Comment at: clang/lib/Driver/Driver.cpp:598 + // The `-maix[32|64]` flags are only valid for AIX targets. + if (Arg *A = Args.getLastArgNoClaim(options::OPT_maix32, options::OPT_maix64); + A && !Target.isOSAIX()) It'd be nic

[PATCH] D151741: [Lex] Only warn on defining or undefining language-defined builtins

nickdesaulniers added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:163-172 + // C defines macros starting with __STDC, and C++ defines macros starting with + // __STDCPP + if (MacroName.startswith("__STDC")) +return true; + // C++ defines the __cplusplus m

[PATCH] D151575: [clang][diagnostics] Always show include stacks on errors

denik accepted this revision. denik added a comment. This revision is now accepted and ready to land. As long as having `In file included from` on each error **without notes** from one include file is fine, I don't see any problem with this. LGTM. But let's check what others think about it. For

[PATCH] D150430: Implement BufferOverlap check for sprint/snprintf

ArnaudBienner updated this revision to Diff 526743. ArnaudBienner added a comment. - clang-format fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150430/new/ https://reviews.llvm.org/D150430 Files: clang/lib/StaticAnalyzer/Checkers/CStringChec

[PATCH] D151515: [Sema] add cast from IncompleteArrayType to ConstantArrayType in TryReferenceListInitialization

HerrCai0907 added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4433 +// where H is the initializer list. +Sequence.AddQualificationConversionStep(cv1T1, VK_XValue); + } erichkeane wrote: > Is `VK_XValue` correct here? The standar

[clang] d81ce04 - [Driver] Report error for unsupported -mlarge-endian/-mlittle-endian

Author: Fangrui Song Date: 2023-05-30T12:45:21-07:00 New Revision: d81ce04587c006b6731198956c522c93d0df1050 URL: https://github.com/llvm/llvm-project/commit/d81ce04587c006b6731198956c522c93d0df1050 DIFF: https://github.com/llvm/llvm-project/commit/d81ce04587c006b6731198956c522c93d0df1050.diff

[PATCH] D151589: [lld] add context-sensitive PGO options for MachO

ellis updated this revision to Diff 526751. ellis marked 3 inline comments as done. ellis added a comment. Add test to check that `PGOInstrumentationGen`(`Use`) are run Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151589/new/ https://reviews.llvm.

[PATCH] D148723: [clang] Restrict Inline Builtin to non-static, non-odr linkage

mstorsjo added a comment. In D148723#4381414 , @serge-sans-paille wrote: > In D148723#4380165 , @mstorsjo > wrote: > >> This causes failed asserts with `_FORTIFY_SOURCE` with the mingw-w64 >> headers. Here's a

[clang] 28b26b1 - [clang] [test] Narrow down an MSVC specific behaviour to only not covever MinGW

Author: Martin Storsjö Date: 2023-05-30T23:05:57+03:00 New Revision: 28b26b161c2f5f8aecf8fffa7220cacc990ba51c URL: https://github.com/llvm/llvm-project/commit/28b26b161c2f5f8aecf8fffa7220cacc990ba51c DIFF: https://github.com/llvm/llvm-project/commit/28b26b161c2f5f8aecf8fffa7220cacc990ba51c.diff

[PATCH] D151661: [clang] [test] Narrow down an MSVC specific behaviour to only not covever MinGW

This revision was automatically updated to reflect the committed changes. Closed by commit rG28b26b161c2f: [clang] [test] Narrow down an MSVC specific behaviour to only not covever MinGW (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D151523: [ASTStructuralEquivalence] Fix crash when ObjCCategoryDecl doesn't have corresponding ObjCInterfaceDecl.

shafik added inline comments. Comment at: clang/lib/AST/ASTStructuralEquivalence.cpp:2062 + *Intf2 = D2->getClassInterface(); + if ((Intf1 != nullptr) != (Intf2 != nullptr)) +return false; I think this would be easier to read if you

[clang] 692f305 - [Driver] Remove unused class ForceSuccessCommand

Author: Kazu Hirata Date: 2023-05-30T13:16:15-07:00 New Revision: 692f3059fb95fe191033d2f710c51babc08b9425 URL: https://github.com/llvm/llvm-project/commit/692f3059fb95fe191033d2f710c51babc08b9425 DIFF: https://github.com/llvm/llvm-project/commit/692f3059fb95fe191033d2f710c51babc08b9425.diff L

[PATCH] D151609: [Driver] Remove unused class ForceSuccessCommand

This revision was automatically updated to reflect the committed changes. Closed by commit rG692f3059fb95: [Driver] Remove unused class ForceSuccessCommand (authored by kazu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151609/new/ https://reviews

[PATCH] D151749: [Headers][doc] Add "shuffle-like" intrinsic descriptions to avx2intrin.h

probinson created this revision. probinson added reviewers: RKSimon, pengfei, goldstein.w.n, craig.topper. Herald added a project: All. probinson requested review of this revision. (Time to look for the next round of embarrassing mistakes...) https://reviews.llvm.org/D151749 Files: clang/lib/

[PATCH] D127647: [clang][lex] NFCI: Use FileEntryRef in ModuleMap::{load,lookup}ModuleMap()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG769d282d7292: [clang][lex] NFCI: Use FileEntryRef in ModuleMap::{load,lookup}ModuleMap() (authored by jansvoboda11). Repository: rG LLVM Github Mo

[clang] 769d282 - [clang][lex] NFCI: Use FileEntryRef in ModuleMap::{load,lookup}ModuleMap()

Author: Jan Svoboda Date: 2023-05-30T13:54:06-07:00 New Revision: 769d282d7292d14591a721ee967962736160095e URL: https://github.com/llvm/llvm-project/commit/769d282d7292d14591a721ee967962736160095e DIFF: https://github.com/llvm/llvm-project/commit/769d282d7292d14591a721ee967962736160095e.diff L

[clang] 95279d7 - [clang][lex] NFCI: Use DirectoryEntryRef in ModuleMap::inferFrameworkModule()

Author: Jan Svoboda Date: 2023-05-30T13:54:06-07:00 New Revision: 95279d7670cd54a50cf72d1fbc99701ef1faa72b URL: https://github.com/llvm/llvm-project/commit/95279d7670cd54a50cf72d1fbc99701ef1faa72b DIFF: https://github.com/llvm/llvm-project/commit/95279d7670cd54a50cf72d1fbc99701ef1faa72b.diff L

[clang-tools-extra] d574e91 - [clang][lex] NFCI: Use DirectoryEntryRef in ModuleMap::parseModuleMapFile()

Author: Jan Svoboda Date: 2023-05-30T13:54:06-07:00 New Revision: d574e918dba31e670a87c46e7de281819b3c0ea9 URL: https://github.com/llvm/llvm-project/commit/d574e918dba31e670a87c46e7de281819b3c0ea9 DIFF: https://github.com/llvm/llvm-project/commit/d574e918dba31e670a87c46e7de281819b3c0ea9.diff L

[clang] 32d6f3c - [clang] NFCI: Use DirectoryEntryRef in Module::Directory

Author: Jan Svoboda Date: 2023-05-30T13:54:06-07:00 New Revision: 32d6f3cfd90b90321e84477b2bd353afbf9876ea URL: https://github.com/llvm/llvm-project/commit/32d6f3cfd90b90321e84477b2bd353afbf9876ea DIFF: https://github.com/llvm/llvm-project/commit/32d6f3cfd90b90321e84477b2bd353afbf9876ea.diff L

[clang] b1e5b28 - [clang][lex] NFCI: Use FileEntryRef in Sema::CodeCompleteIncludedFile

Author: Jan Svoboda Date: 2023-05-30T13:54:06-07:00 New Revision: b1e5b28b8c4d8af294906ee27a62b28079d3f337 URL: https://github.com/llvm/llvm-project/commit/b1e5b28b8c4d8af294906ee27a62b28079d3f337 DIFF: https://github.com/llvm/llvm-project/commit/b1e5b28b8c4d8af294906ee27a62b28079d3f337.diff L

[PATCH] D127648: [clang][lex] NFCI: Use DirectoryEntryRef in ModuleMap::inferFrameworkModule()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG95279d7670cd: [clang][lex] NFCI: Use DirectoryEntryRef in ModuleMap::inferFrameworkModule() (authored by jansvoboda11). Herald added a subscriber: ri

[clang] e19f352 - [clang][lex] NFCI: Use DirectoryEntryRef in Preprocessor::MainFileDir

Author: Jan Svoboda Date: 2023-05-30T13:54:06-07:00 New Revision: e19f352beee72d8fc30d9a5366eadd2372719fa3 URL: https://github.com/llvm/llvm-project/commit/e19f352beee72d8fc30d9a5366eadd2372719fa3 DIFF: https://github.com/llvm/llvm-project/commit/e19f352beee72d8fc30d9a5366eadd2372719fa3.diff L

[PATCH] D127651: [clang][lex] NFCI: Use DirectoryEntryRef in ModuleMap::parseModuleMapFile()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd574e918dba3: [clang][lex] NFCI: Use DirectoryEntryRef in ModuleMap::parseModuleMapFile() (authored by jansvoboda11). Herald added a subscriber: ribu

[PATCH] D127654: [clang] NFCI: Use DirectoryEntryRef in Module::Directory

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jansvoboda11 marked 2 inline comments as done. Closed by commit rG32d6f3cfd90b: [clang] NFCI: Use DirectoryEntryRef in Module::Directory (authored by jansvoboda11). Ch

[PATCH] D127658: [clang][lex] NFCI: Use FileEntryRef in Sema::CodeCompleteIncludedFile

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1e5b28b8c4d: [clang][lex] NFCI: Use FileEntryRef in Sema::CodeCompleteIncludedFile (authored by jansvoboda11). Herald added a subscriber: ributzka.

[PATCH] D127660: [clang][lex] NFCI: Use DirectoryEntryRef in Preprocessor::MainFileDir

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jansvoboda11 marked an inline comment as done. Closed by commit rGe19f352beee7: [clang][lex] NFCI: Use DirectoryEntryRef in Preprocessor::MainFileDir (authored by jansv

[PATCH] D151749: [Headers][doc] Add "shuffle-like" intrinsic descriptions to avx2intrin.h

probinson updated this revision to Diff 526782. probinson added a comment. Update some SATURATEx to SATURATExU CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151749/new/ https://reviews.llvm.org/D151749 Files: clang/lib/Headers/avx2intrin.h Index: clang/lib/Headers/avx2intrin.h

[PATCH] D151277: [clang][modules] Mark fewer identifiers as out-of-date

jansvoboda11 added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151277/new/ https://reviews.llvm.org/D151277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D150318: [clang][deps] NFC: Pass around the whole scanning service

jansvoboda11 added a comment. Any other feedback? Comment at: clang/include/clang/Tooling/DependencyScanning/ModuleDepCollector.h:19 #include "clang/Serialization/ASTReader.h" +#include "clang/Tooling/DependencyScanning/DependencyScanningService.h" #include "llvm/ADT/DenseMa

[PATCH] D151625: [clang] Add `clang::equality_operator_compares_members_lexicographically`

philnik added a comment. In D151625#4380735 , @erichkeane wrote: > I'm a little dense today perhaps, but I don't get the use case for this? Can > you ELI-EWG? Is this an attribute we expect our users to use? The name is > horrifyingly long for users

[PATCH] D151753: [Clang][Sema] Do not try to analyze dependent alignment during -Wcast-align

serge-sans-paille created this revision. serge-sans-paille added reviewers: dim, Fznamznon. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix #63007 Repository: rG LLVM Github Monorepo h

[clang] e3fbede - [HIP] Add missing __hip_atomic_fetch_sub support

Author: Luke Drummond Date: 2023-05-30T22:22:43+01:00 New Revision: e3fbede7f3fd7693d5a15a8cfa0b62d9a4f84877 URL: https://github.com/llvm/llvm-project/commit/e3fbede7f3fd7693d5a15a8cfa0b62d9a4f84877 DIFF: https://github.com/llvm/llvm-project/commit/e3fbede7f3fd7693d5a15a8cfa0b62d9a4f84877.diff

[PATCH] D151701: [HIP] Add missing __hip_atomic_fetch_sub support

This revision was automatically updated to reflect the committed changes. Closed by commit rGe3fbede7f3fd: [HIP] Add missing __hip_atomic_fetch_sub support (authored by ldrumm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151701/new/ https://revie

[PATCH] D151589: [lld] add context-sensitive PGO options for MachO

int3 added inline comments. Comment at: lld/test/MachO/cspgo-gen.ll:13 + +define void @_start() { +entry: doesn't *really* matter since you are creating a dylib, but `lld-macho` doesn't actually treat `_start` as a special symbol (only `main`). maybe rename to

[PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

philnik added a comment. In D151683#4380877 , @erichkeane wrote: > What is the justification for this? What exactly are you asking for? Why I'd like to back port it? This would make quite a bit of code in libc++ simpler and avoids pit-falls where an at

[clang] 135ce2f - [clang][ExtractAPI] Modify declaration fragment methods to add a new fragment at an arbitrary offset.

Author: ruturaj4 Date: 2023-05-30T17:30:22-05:00 New Revision: 135ce2f820d881d5a7c5d90feab109174918a21f URL: https://github.com/llvm/llvm-project/commit/135ce2f820d881d5a7c5d90feab109174918a21f DIFF: https://github.com/llvm/llvm-project/commit/135ce2f820d881d5a7c5d90feab109174918a21f.diff LOG:

[clang] 92180da - [clang][ExtractAPI] Modify declaration fragment methods to add a new fragment at an arbitrary offset.

Author: ruturaj4 Date: 2023-05-30T17:30:22-05:00 New Revision: 92180dae775f66193069279ee7532735ea2fee06 URL: https://github.com/llvm/llvm-project/commit/92180dae775f66193069279ee7532735ea2fee06 DIFF: https://github.com/llvm/llvm-project/commit/92180dae775f66193069279ee7532735ea2fee06.diff LOG:

<    1   2   3   >