[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

jdenny added a comment. Thanks for working on this. I've been wanting something like it too. In downstream work, I've used a hack that seems to accomplish the same thing but probably shouldn't: `expected-error 0 {{}}`. Anyway, please add documentation for the new directive here: https://clan

[PATCH] D151461: [Clang][SVE2.1] Add builtins and intrinsics for SVBFMLSLB/T

CarolineConcatto created this revision. Herald added subscribers: hiraditya, kristof.beyls, tschuett. Herald added a project: All. CarolineConcatto requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. As described in: https://g

[PATCH] D151349: [HIP] emit macro `__HIP_NO_IMAGE_SUPPORT`

arsenm added a comment. You seem to be defining a new subtarget feature without actually defining the underlying feature. I thought the issue was specific missing image instructions, which is already covered by extended-image-insts Comment at: clang/lib/Basic/Targets/AMDGPU.h

[PATCH] D150528: [Clang][Attribute] Improve the AST/diagnoses fidelity of alignas and _Alignas

erichkeane added a comment. Still LGTM, thanks! Comment at: clang/lib/AST/AttrImpl.cpp:247 + + if (isAlignmentExpr()) { +return alignmentExpr yronglin wrote: > erichkeane wrote: > > Typically we don't do curleys on a single-statement... but I am on the >

[clang] 6f026ff - Discussion: Darwin Sanitizers Stable ABI

Author: Roy Sundahl Date: 2023-05-25T08:57:41-07:00 New Revision: 6f026ff029853431ee535e6a361edd059da3ab27 URL: https://github.com/llvm/llvm-project/commit/6f026ff029853431ee535e6a361edd059da3ab27 DIFF: https://github.com/llvm/llvm-project/commit/6f026ff029853431ee535e6a361edd059da3ab27.diff L

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6f026ff02985: Discussion: Darwin Sanitizers Stable ABI (authored by rsundahl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D151293: [clang][ExtractAPI] Refactor serializer to the CRTP

evelez7 updated this revision to Diff 525652. evelez7 added a comment. Really address review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151293/new/ https://reviews.llvm.org/D151293 Files: clang/include/clang/ExtractAPI/Serialization/

[PATCH] D151349: [HIP] emit macro `__HIP_NO_IMAGE_SUPPORT`

arsenm added inline comments. Comment at: clang/test/OpenMP/amdgcn-attributes.cpp:36 // DEFAULT: attributes #0 = { convergent noinline norecurse nounwind optnone "kernel" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "uniform-work-group-size"="true" } -// CPU: at

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

SlaterLatiao updated this revision to Diff 525653. SlaterLatiao added a comment. - Test behavior of `-Wpacked-non-pod` in `-Wall` and update test case name. - Update release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151162/new/ https://re

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

SlaterLatiao updated this revision to Diff 525654. SlaterLatiao added a comment. - Fix missing parenthesis. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151162/new/ https://reviews.llvm.org/D151162 Files: clang/docs/ReleaseNotes.rst clang/inc

[PATCH] D150446: [analyzer] Check ArraySubscriptExprs in ArrayBoundCheckerV2

steakhal added a comment. I'll come back one or two weeks later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150446/new/ https://reviews.llvm.org/D150446 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D151349: [HIP] emit macro `__HIP_NO_IMAGE_SUPPORT`

yaxunl added a comment. In D151349#4372695 , @arsenm wrote: > You seem to be defining a new subtarget feature without actually defining the > underlying feature. I thought the issue was specific missing image > instructions, which is already covered by

[PATCH] D150499: [AST] Initialized data after TypeSourceInfo

vitalybuka added reviewers: kstoimenov, thurston. vitalybuka added a comment. Oh, I rerun msan bot locally and it looked like issue dissipated, but I probably checked wrong logs. So I enabled -Oz on the bot, to catch more bugs, but the issue is still there https://lab.llvm.org/buildbot/#/builder

[PATCH] D145403: [Pipeline] Don't run EarlyFPM in LTO post link

This revision was automatically updated to reflect the committed changes. Closed by commit rG13e3d4aa5a4e: [Pipeline] Don't run EarlyFPM in LTO post link (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145403/new/ https://revie

[PATCH] D151431: [clang-tidy] Add check bugprone-unique-ptr-array-mismatch.

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM, But: - Align check description before committing. - Consider adding some test with std::unique_ptr behind typedef. - Consider adding test with unique_ptr depend on template argument b

[PATCH] D151349: [HIP] emit macro `__HIP_NO_IMAGE_SUPPORT`

yaxunl added inline comments. Comment at: clang/test/OpenMP/amdgcn-attributes.cpp:36 // DEFAULT: attributes #0 = { convergent noinline norecurse nounwind optnone "kernel" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "uniform-work-group-size"="true" } -// CPU: at

[PATCH] D151445: [Flang] Add main-file-name flag to flang -fc1

clementval added a comment. You should be able to get this information from the source location in MLIR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151445/new/ https://reviews.llvm.org/D151445 ___ cfe

[clang] 2a23de0 - [Clang] Switch from TransformExpr to TransformInitializer in places we need to revert initializer to it syntactic form for Sema

Author: Shafik Yaghmour Date: 2023-05-25T09:50:56-07:00 New Revision: 2a23de01e51545d01055229baea4d4a296b65058 URL: https://github.com/llvm/llvm-project/commit/2a23de01e51545d01055229baea4d4a296b65058 DIFF: https://github.com/llvm/llvm-project/commit/2a23de01e51545d01055229baea4d4a296b65058.dif

[PATCH] D151235: [Clang] Switch from TransformExpr to TransformInitializer in places we need to revert initializer to it syntactic form for Sema

This revision was automatically updated to reflect the committed changes. shafik marked an inline comment as done. Closed by commit rG2a23de01e515: [Clang] Switch from TransformExpr to TransformInitializer in places we need to… (authored by shafik). Herald added a project: clang. Repository: rG

[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:23121-23122 + void VisitExpr(const Expr *Ex) { +for (Expr::const_child_iterator it = Ex->child_begin(); + it != Ex->child_end(); ++it) { + Visit(*it); `for (const Expr *Chi

[clang] 4498663 - [AST] Initialized data after TypeSourceInfo

Author: Vitaly Buka Date: 2023-05-25T09:53:17-07:00 New Revision: 4498663f3de0857359502469bb93fb850b0a8c2e URL: https://github.com/llvm/llvm-project/commit/4498663f3de0857359502469bb93fb850b0a8c2e DIFF: https://github.com/llvm/llvm-project/commit/4498663f3de0857359502469bb93fb850b0a8c2e.diff L

[PATCH] D150499: [AST] Initialized data after TypeSourceInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rG4498663f3de0: [AST] Initialized data after TypeSourceInfo (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150499/new/ https://review

[PATCH] D151469: [NFC][CLANG] Fix issue with dereference null return value in EvaluateBuiltinClassifyType()

Manna created this revision. Manna added a reviewer: erichkeane. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch uses cast instead of dyn_cast which will assert if the type doesn't match. Repository: rG LLVM Github Monorepo http

[PATCH] D151469: [NFC][CLANG] Fix issue with dereference null return value in EvaluateBuiltinClassifyType()

erichkeane added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:11294 QualType CanTy = T.getCanonicalType(); - const BuiltinType *BT = dyn_cast(CanTy); + const BuiltinType *BT = cast(CanTy); I don't think this is right. BT is only dereference

[PATCH] D151398: [clang] Make `FileEntryRef::getDir()` return the as-requested `DirectoryEntryRef`

jansvoboda11 updated this revision to Diff 525691. jansvoboda11 added a comment. Make directory non-optional Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151398/new/ https://reviews.llvm.org/D151398 Files: clang/include/clang/Basic/FileEntry.h

[PATCH] D151398: [clang] Make `FileEntryRef::getDir()` return the as-requested `DirectoryEntryRef`

jansvoboda11 added inline comments. Comment at: clang/include/clang/Basic/FileEntry.h:124 +/// Directory the file was found in. OptionalDirectoryEntryRef Dir; rmaz wrote: > If this is always set now, should it be a non optional `DirectoryEntryRef`? Yes

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Do you need someone to commit on your behalf? If so, what name and email address would you like us to use for patch attribution? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D149867: [M68k] Add Clang support for the new M68k_RTD CC

myhsu added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149867/new/ https://reviews.llvm.org/D149867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D151393: [CodeGen] Make __clang_call_terminate have an unwind table entry

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Makes sense to me too, but wait for approval by @efriedma Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151393/new/ https://reviews.llvm.org/D151393

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

denik accepted this revision. denik added a comment. Thanks @SlaterLatiao! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151162/new/ https://reviews.llvm.org/D151162 ___ cfe-commits mailing list cfe-comm

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. > @benlangmuir, do you need any assistance from my side with it? @ivanmurashko thanks for your patience. I discussed this with some colleagues and we're in favour of making this fix.

[PATCH] D151469: [NFC][CLANG] Fix issue with dereference null return value in EvaluateBuiltinClassifyType()

Manna updated this revision to Diff 525697. Manna added a comment. Thank you @erichkeane for reviews! I have updated patch to avoid the regression. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151469/new/ https://reviews.llvm.org/D151469 Files: clang/lib/AST/ExprConstant.cpp Index

[PATCH] D151469: [NFC][CLANG] Fix issue with dereference null return value in EvaluateBuiltinClassifyType()

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. This looks right for me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151469/new/ https://reviews.llvm.org/D151469 ___ cfe-commit

[PATCH] D150926: [RISCV] Support LMUL!=1 for __attribute__((riscv_rvv_vector_bits(N)))

craig.topper added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150926/new/ https://reviews.llvm.org/D150926 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D151393: [CodeGen] Make __clang_call_terminate have an unwind table entry

efriedma accepted this revision. efriedma added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151393/new/ https://reviews.llvm.org/D151393 ___ cfe-commits mailing list cfe-commits@lists.l

[clang] 8f7b51e - [CodeGen] Make __clang_call_terminate have an unwind table entry

Author: Shoaib Meenai Date: 2023-05-25T10:56:23-07:00 New Revision: 8f7b51e4ec09f6f50ea6508a196ec607f0659179 URL: https://github.com/llvm/llvm-project/commit/8f7b51e4ec09f6f50ea6508a196ec607f0659179 DIFF: https://github.com/llvm/llvm-project/commit/8f7b51e4ec09f6f50ea6508a196ec607f0659179.diff

[PATCH] D151393: [CodeGen] Make __clang_call_terminate have an unwind table entry

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f7b51e4ec09: [CodeGen] Make __clang_call_terminate have an unwind table entry (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151393/ne

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

SlaterLatiao added a comment. In D151162#4373027 , @aaron.ballman wrote: > LGTM! Do you need someone to commit on your behalf? If so, what name and > email address would you like us to use for patch attribution? Thank you, Aaron! Please use Zenong Zhan

[PATCH] D145739: [-Wunsafe-buffer-usage] Group variables associated by pointer assignments

t-rasmud added a comment. Hi Douglas, No worries, I know the root cause for the issue. I will make the necessary changes and re-commit the patch. Thanks, Rashmi Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145739/new/ https://reviews.llvm.org/D

[PATCH] D151393: [CodeGen] Make __clang_call_terminate have an unwind table entry

MaskRay added a comment. LGTM. Is there an existing test that can merge in the `uwtable` test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151393/new/ https://reviews.llvm.org/D151393 ___ cfe-commits m

[PATCH] D150913: [Clang][BFloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

codemzs added inline comments. Comment at: clang/docs/LanguageExtensions.rst:852 ``double`` when passed to ``printf``, so the programmer must explicitly cast it to ``double`` before using it with an ``%f`` or similar specifier. pengfei wrote: > rjmccall wrot

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

rsmith added a comment. Sorry for the late comments. Comment at: clang/lib/Sema/SemaInit.cpp:167-177 } else if (ParenExpr *PE = dyn_cast(E)) { E = PE->getSubExpr(); } else if (UnaryOperator *UO = dyn_cast(E)) { assert(UO->getOpcode() == UO_Extension);

[PATCH] D151087: [Clang] Permit address space casts with 'reinterpret_cast' in C++

rjmccall added a comment. Right, that's been my thinking, too. The CVR qualifiers are all "view" qualifiers: both the underlying object and the reference to it are assumed to be the same independent of qualifiers, and the qualifiers just affect the rules around accesses. C++'s rules around qu

[clang] 9ed3d85 - [clang][diagnostics] Add -Wpacked-non-pod to -Wall

Author: Zenong Zhang Date: 2023-05-25T14:17:29-04:00 New Revision: 9ed3d85e26d8594440bca84fe868a62ac6560ac8 URL: https://github.com/llvm/llvm-project/commit/9ed3d85e26d8594440bca84fe868a62ac6560ac8 DIFF: https://github.com/llvm/llvm-project/commit/9ed3d85e26d8594440bca84fe868a62ac6560ac8.diff

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ed3d85e26d8: [clang][diagnostics] Add -Wpacked-non-pod to -Wall (authored by SlaterLatiao, committed by aaron.ballman). Changed prior to commit:

[PATCH] D151477: [clang][ExtractAPI] Refactor serializer to the CRTP

evelez7 created this revision. evelez7 added reviewers: dang, zixuw. Herald added a reviewer: ributzka. Herald added a project: All. evelez7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Refactor SerializerBase and SymbolGraphSerializer t

[PATCH] D151294: [clangd] Remove inline Specifier for DefineOutline Tweak

bgluzman updated this revision to Diff 525715. bgluzman added a comment. address diff comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151294/new/ https://reviews.llvm.org/D151294 Files: clang-tools-extra/clangd/refactor/tweaks/DefineOutli

[PATCH] D151294: [clangd] Remove inline Specifier for DefineOutline Tweak

bgluzman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:137 +llvm::Expected +getDelKeywordReplacements(const FunctionDecl *FD, + const syntax::TokenBuffer &TokBuf, kadircet wrote: > let's jus

[clang] 171dfc5 - [-Wunsafe-buffer-usage] Group variables associated by pointer assignments

Author: Rashmi Mudduluru Date: 2023-05-25T11:31:27-07:00 New Revision: 171dfc5462a23b7e8ace31f4d9206b972b38ffbc URL: https://github.com/llvm/llvm-project/commit/171dfc5462a23b7e8ace31f4d9206b972b38ffbc DIFF: https://github.com/llvm/llvm-project/commit/171dfc5462a23b7e8ace31f4d9206b972b38ffbc.di

[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

HerrCai0907 updated this revision to Diff 525718. HerrCai0907 added a comment. Herald added subscribers: pmatos, asb, aheejin, jgravelle-google, sbc100, dschuff. getLocallyUnqualifiedSingleStepDesugaredType to find the whole record name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D151479: [clang] Use IgnoreParensSingleStep in more places

aeubanks created this revision. aeubanks added a reviewer: rsmith. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Addresses a post-commit comment on D146764 . Reposi

[PATCH] D151480: [NFC][CLANG] Fix nullptr dereference issue in CodeGenModule::​GetConstantArrayFromStringLiteral()

Manna created this revision. Manna added a reviewer: erichkeane. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch adds an assert. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D151480 Files: clang/lib/CodeGen/Cod

[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

HerrCai0907 added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:969 << (int)DFK.asComparison() -<< Context.getTagDeclType( - cast(FD->getLexicalDeclContext())); +<< Context.getRecordType(RecordType->

[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:968 +.getNonReferenceType() +->getLocallyUnqualifiedSingleStepDesugaredType(); Diags.Report(Active->PointOfInstantiation, This doesn'

[PATCH] D151294: [clangd] Remove inline Specifier for DefineOutline Tweak

bgluzman updated this revision to Diff 525722. bgluzman added a comment. resubmit diff update with corrected commit range Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151294/new/ https://reviews.llvm.org/D151294 Files: clang-tools-extra/clangd/

[PATCH] D151480: [NFC][CLANG] Fix nullptr dereference issue in CodeGenModule::​GetConstantArrayFromStringLiteral()

Manna added a comment. Thank you @erichkeane for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151480/new/ https://reviews.llvm.org/D151480 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] 53333c8 - Revert "[clang][diagnostics] Add -Wpacked-non-pod to -Wall"

Author: Aaron Ballman Date: 2023-05-25T14:51:16-04:00 New Revision: 5c8d44d690f6e8fd6f31803aecb17329cdb5 URL: https://github.com/llvm/llvm-project/commit/5c8d44d690f6e8fd6f31803aecb17329cdb5 DIFF: https://github.com/llvm/llvm-project/commit/5c8d44d690f6e8fd6f31803aecb17329cdb5.diff

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

aaron.ballman reopened this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Unfortunately, I had to revert this in 5c8d44d690f6e8fd6f31803aecb17329cdb5 due to a bot breaking: https

[PATCH] D150221: Add option -fkeep-static-variables to emit all static variables

efriedma added a comment. I think I'm okay with the semantics as-is. Comment at: clang/include/clang/Driver/Options.td:1703 + PosFlag, NegFlag, + BothFlags<[NoXarchOption], " static variables if unused">>; defm fixed_point : BoolFOption<"fixed-point", Can yo

[clang] ffb635c - [CUDA] bump supported CUDA version to 12.1/11.8

Author: Artem Belevich Date: 2023-05-25T11:57:55-07:00 New Revision: ffb635cb2d4e374e52b12066893458a8b70889fa URL: https://github.com/llvm/llvm-project/commit/ffb635cb2d4e374e52b12066893458a8b70889fa DIFF: https://github.com/llvm/llvm-project/commit/ffb635cb2d4e374e52b12066893458a8b70889fa.diff

[clang] 0ad5d40 - [CUDA] Relax restrictions on variadics in host-side compilation.

Author: Artem Belevich Date: 2023-05-25T11:57:54-07:00 New Revision: 0ad5d40fa19f27db0e5f999d0e17b0c18b811019 URL: https://github.com/llvm/llvm-project/commit/0ad5d40fa19f27db0e5f999d0e17b0c18b811019 DIFF: https://github.com/llvm/llvm-project/commit/0ad5d40fa19f27db0e5f999d0e17b0c18b811019.diff

[PATCH] D151359: [CUDA] Relax restrictions on variadics in host-side compilation.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0ad5d40fa19f: [CUDA] Relax restrictions on variadics in host-side compilation. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151359/new/

[clang] 0a0bae1 - [CUDA] plumb through new sm_90-specific builtins.

Author: Artem Belevich Date: 2023-05-25T11:57:56-07:00 New Revision: 0a0bae1e9f94ec86ac17b0b4eb817741689f3739 URL: https://github.com/llvm/llvm-project/commit/0a0bae1e9f94ec86ac17b0b4eb817741689f3739 DIFF: https://github.com/llvm/llvm-project/commit/0a0bae1e9f94ec86ac17b0b4eb817741689f3739.diff

[clang] 25708b3 - [NVPTX, CUDA] barrier intrinsics and builtins for sm_90

Author: Artem Belevich Date: 2023-05-25T11:57:57-07:00 New Revision: 25708b3df6e359123d5bce137652af812e168cfc URL: https://github.com/llvm/llvm-project/commit/25708b3df6e359123d5bce137652af812e168cfc DIFF: https://github.com/llvm/llvm-project/commit/25708b3df6e359123d5bce137652af812e168cfc.diff

[PATCH] D151361: [CUDA] bump supported CUDA version to 12.1/11.8

This revision was automatically updated to reflect the committed changes. Closed by commit rGffb635cb2d4e: [CUDA] bump supported CUDA version to 12.1/11.8 (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151361/new/ https://reviews.l

[clang] 5c082e7 - [CUDA] Add CUDA wrappers over clang builtins for sm_90.

Author: Artem Belevich Date: 2023-05-25T11:57:58-07:00 New Revision: 5c082e7e15e38a2eea1f506725efe636a5b1bf8a URL: https://github.com/llvm/llvm-project/commit/5c082e7e15e38a2eea1f506725efe636a5b1bf8a DIFF: https://github.com/llvm/llvm-project/commit/5c082e7e15e38a2eea1f506725efe636a5b1bf8a.diff

[PATCH] D151168: [CUDA] plumb through new sm_90-specific builtins.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a0bae1e9f94: [CUDA] plumb through new sm_90-specific builtins. (authored by tra). Changed prior to commit: https://reviews.llvm.org/D151168?vs=52

[PATCH] D151363: [NVPTX, CUDA] barrier intrinsics and builtins for sm_90

This revision was automatically updated to reflect the committed changes. Closed by commit rG25708b3df6e3: [NVPTX, CUDA] barrier intrinsics and builtins for sm_90 (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151363/new/ https://r

[PATCH] D151362: [CUDA] Add CUDA wrappers over clang builtins for sm_90.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5c082e7e15e3: [CUDA] Add CUDA wrappers over clang builtins for sm_90. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151362/new/ https://r

[PATCH] D151294: [clangd] Remove inline Specifier for DefineOutline Tweak

bgluzman added a comment. Thank you for reviewing @kadircet! Per the MyFirstTypoFix page , I don’t have commit access. If everything looks good, could you land this patch for me and use “Brian Gluzman bgluz...@gmail.com” for the commit? Reposito

[PATCH] D151060: [Clang][Sema] Generate vector vs scalar builtin overloads

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9041-9044 + // (allowing splatting the scalar to a vector). + for (unsigned Candidate = 0; Candidate < 2; ++Candidate) { +for (QualType Vec1Ty : CandidateTypes[Candidate].vector_typ

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

SlaterLatiao added a comment. I shouldn't remove `-triple=x86_64-none-none` in the test case. I'll add it back. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151162/new/ https://reviews.llvm.org/D151162 ___

[PATCH] D150913: [Clang][BFloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

rjmccall added inline comments. Comment at: clang/docs/LanguageExtensions.rst:852 ``double`` when passed to ``printf``, so the programmer must explicitly cast it to ``double`` before using it with an ``%f`` or similar specifier. codemzs wrote: > pengfei wrot

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

SlaterLatiao updated this revision to Diff 525744. SlaterLatiao added a comment. Adding back the `-triple` flag - The padding size can be different on different architectures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151162/new/ https://revie

[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

HerrCai0907 updated this revision to Diff 525752. HerrCai0907 added a comment. avoid desurger Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151365/new/ https://reviews.llvm.org/D151365 Files: clang/docs/ReleaseNotes.rst clang/lib/Basic/Targets

[clang] bdc3ce9 - [clang] Make `FileEntryRef::getDir()` return the as-requested `DirectoryEntryRef`

Author: Jan Svoboda Date: 2023-05-25T12:36:57-07:00 New Revision: bdc3ce9e8f8dda42ed286f72094fbbdf0347cbfa URL: https://github.com/llvm/llvm-project/commit/bdc3ce9e8f8dda42ed286f72094fbbdf0347cbfa DIFF: https://github.com/llvm/llvm-project/commit/bdc3ce9e8f8dda42ed286f72094fbbdf0347cbfa.diff L

[PATCH] D151398: [clang] Make `FileEntryRef::getDir()` return the as-requested `DirectoryEntryRef`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbdc3ce9e8f8d: [clang] Make `FileEntryRef::getDir()` return the as-requested… (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

HerrCai0907 updated this revision to Diff 525754. HerrCai0907 added a comment. remove not related change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151365/new/ https://reviews.llvm.org/D151365 Files: clang/docs/ReleaseNotes.rst clang/lib/Se

[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151365/new/ https://reviews.llvm.org/D151365 __

[clang] df1b2be - [CUDA] Explicitly construct dim3() return values.

Author: Artem Belevich Date: 2023-05-25T12:41:25-07:00 New Revision: df1b2bef0c7cad11681a02e9e2f816b27fb480a6 URL: https://github.com/llvm/llvm-project/commit/df1b2bef0c7cad11681a02e9e2f816b27fb480a6 DIFF: https://github.com/llvm/llvm-project/commit/df1b2bef0c7cad11681a02e9e2f816b27fb480a6.diff

[PATCH] D145739: [-Wunsafe-buffer-usage] Group variables associated by pointer assignments

NoQ added a comment. Thank you Sergei for catching this! Thank you Rashmi for fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145739/new/ https://reviews.llvm.org/D145739 ___ cfe-commits maili

[PATCH] D151293: [clang][ExtractAPI] Refactor serializer to the CRTP

evelez7 abandoned this revision. evelez7 added inline comments. Comment at: clang/include/clang/ExtractAPI/Serialization/SerializerBase.h:28-31 +struct APISetVisitorOption { /// Do not include unnecessary whitespaces to save space. bool Compact; }; dang wr

[PATCH] D127647: [clang][lex] NFCI: Use FileEntryRef in ModuleMap::{load,lookup}ModuleMap()

jansvoboda11 updated this revision to Diff 525760. jansvoboda11 added a comment. Rebase on top of D151398 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127647/new/ https://reviews.llvm.org/D127647 Files: clang/

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

nikic added inline comments. Comment at: clang/test/utils/update_cc_test_checks/Inputs/annotations.c.expected:12 +// CHECK-NEXT:[[TMP1:%.*]] = load i32, ptr [[X]], align 4 +// CHECK-NEXT:ret i32 [[TMP1]] +// hnrklssn wrote: > nikic wrote: > > hnrklssn wr

[PATCH] D151429: print user provide value in tabstop diagnostic

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM, thanks! I see this is your first contribution. I'm happy to commit this patch for you if you don't have commit access

[clang] 9168974 - Reapply: [clang][diagnostics] Adding -Wpacked-non-pod to -Wall

Author: Zenong Zhang Date: 2023-05-25T13:02:00-07:00 New Revision: 91689744477843a588f701fdc598ccff3cbbc8fb URL: https://github.com/llvm/llvm-project/commit/91689744477843a588f701fdc598ccff3cbbc8fb DIFF: https://github.com/llvm/llvm-project/commit/91689744477843a588f701fdc598ccff3cbbc8fb.diff

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG916897444778: Reapply: [clang][diagnostics] Adding -Wpacked-non-pod to -Wall (authored by SlaterLatiao, committed by erichkeane). Changed prior to c

[PATCH] D150887: [clang] Convert a few tests to opaque pointers

nikic added a comment. I wanted to check whether you plan to do more opaque pointer test conversions in clang. Just to make sure we don't duplicate work... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150887/new/ https://reviews.llvm.org/D150887

[clang] 5df593a - [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

Author: Congcong Cai Date: 2023-05-25T22:07:50+02:00 New Revision: 5df593a354714e081ac441a74f89ad2a56334e28 URL: https://github.com/llvm/llvm-project/commit/5df593a354714e081ac441a74f89ad2a56334e28 DIFF: https://github.com/llvm/llvm-project/commit/5df593a354714e081ac441a74f89ad2a56334e28.diff

[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5df593a35471: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method (authored by HerrCai0907). Repository: rG LLVM Github M

[PATCH] D151145: Add disabled unittest reproducing TextProto formatting issue.

HazardyKnusperkeks added a comment. > In D151145#4365580 , > @HazardyKnusperkeks wrote: > >> As stated on Github I don't think we have a bug. > > Are you sure, I'm pretty sure this is a bug? Can you elaborate on the > discussion on github. I wouldn't wan

[PATCH] D150887: [clang] Convert a few tests to opaque pointers

barannikov88 added a comment. In D150887#4373695 , @nikic wrote: > I wanted to check whether you plan to do more opaque pointer test conversions > in clang. Just to make sure we don't duplicate work... I'm done for now Repository: rG LLVM Github Mon

[PATCH] D151445: [Flang] Add main-file-name flag to flang -fc1

domada added a comment. In D151445#4372892 , @clementval wrote: > You should be able to get this information from the source location in MLIR. Hi, thank you for your quick feedback. You are right, the source location is provided in MLIR. Unfortunately,

[PATCH] D151393: [CodeGen] Make __clang_call_terminate have an unwind table entry

smeenai added a comment. I searched for `__clang_call_terminate` in the Clang test directory when I was working on this diff. Most tests were testing calls to it, not definitions. There were a couple of tests checking the definition, but they seemed pretty targeted (e.g. https://github.com/llv

[PATCH] D149495: [RISCV] Add support for V extension in SiFive7

reames added a comment. Let's go ahead and land this as is, we can rework the stylistic pieces once the linked patches land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149495/new/ https://reviews.llvm.org/D149495 __

[PATCH] D151393: [CodeGen] Make __clang_call_terminate have an unwind table entry

MaskRay added a comment. In D151393#4373764 , @smeenai wrote: > I searched for `__clang_call_terminate` in the Clang test directory when I > was working on this diff. Most tests were testing calls to it, not > definitions. There were a couple of tests c

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

electriclilies created this revision. Herald added subscribers: bviyer, Moerafaat, zero9178, bzcheeseman, awarzynski, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauhe

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

ldionne added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:431 + // libc++.dylib in the toolchain. + if ((!Args.hasArg(options::OPT_nostdinc, options::OPT_nostdlibinc, +options::OPT_nostdincxx)) && arphaman wrote: > ld

[PATCH] D149495: [RISCV] Add support for V extension in SiFive7

michaelmaitland added a comment. In D149495#4373768 , @reames wrote: > Let's go ahead and land this as is, we can rework the stylistic pieces once > the linked patches land. This has landed in https://reviews.llvm.org/rG1a855819a87f426bdbd83c815fa47ca0

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

ftynse added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:367 // that can be valid on the real entry. - // This is what I want to do AttributeList NewAttrs = AttributeList::get(Ctx, AttributeList::FunctionIndex, This cleanup should go

<    1   2   3   >