[PATCH] D147612: [RISCV][MC] Add support for experimental Zvfbfwma extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa1455de74d95: [RISCV][MC] Add support for experimental Zvfbfwma extension (authored by asb). Changed prior to commit: https://reviews.llvm.org/D14

[PATCH] D150966: [clang] Don't define predefined macros multiple times

john.brawn created this revision. john.brawn added reviewers: aaron.ballman, thakis, arichardson, pratlucas. Herald added subscribers: luke, abrachet, frasercrmck, phosek, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,

[PATCH] D148665: Change -fsanitize=function to place two words before the function entry

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.h:205 getUBSanFunctionSignature(CodeGen::CodeGenModule &CGM) const { -return nullptr; +return llvm::ConstantInt::get(CGM.Int32Ty, 0xc105cafe); } ---

[PATCH] D150926: [RISCV] Support LMUL!=1 for __attribute__((riscv_rvv_vector_bits(N)))

asb added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:2347 -Only ``*m1_t`` (LMUL=1) types are supported at this time. +For types where LMUL!=1, ``__riscv_v_fixed_vlen`` needs to be scaled by the LMULo +of the type before passing to the attribute. ---

[PATCH] D150966: [clang] Don't define predefined macros multiple times

barannikov88 added a comment. Is it possible/worth to add an assertion to Builder.defineMacro to enforce this one definition rule? Comment at: clang/lib/Frontend/InitPreprocessor.cpp:1305 +Builder.defineMacro("__ELF__"); + } + Redundant braces. Reposit

[PATCH] D150968: [NFC][CLANG] Fix issue with dereference null return value found by Coverity static analyzer tool

Manna created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. Reported by Coverity: In clang::​FunctionDecl::​isRep

[clang] ad31a2d - Change -fsanitize=function to place two words before the function entry

Author: Fangrui Song Date: 2023-05-19T07:50:29-07:00 New Revision: ad31a2dcadfcd57a99bbd6d0050d2690fd84a883 URL: https://github.com/llvm/llvm-project/commit/ad31a2dcadfcd57a99bbd6d0050d2690fd84a883 DIFF: https://github.com/llvm/llvm-project/commit/ad31a2dcadfcd57a99bbd6d0050d2690fd84a883.diff

[PATCH] D148665: Change -fsanitize=function to place two words before the function entry

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. MaskRay marked an inline comment as done. Closed by commit rGad31a2dcadfc: Change -fsanitize=function to place two words before the function entry (authored by MaskRay)

[PATCH] D150913: [Clang][Bfloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

pengfei added a comment. Great work! Thanks for the patch! Comment at: clang/include/clang/AST/ASTContext.h:1102 CanQualType HalfTy; // [OpenCL 6.1.1.1], ARM NEON - CanQualType BFloat16Ty; + CanQualType BFloat16Ty; // ISO/IEC/IEEE 60559. CanQualType Float16Ty; // C11 ex

[PATCH] D150966: [clang] Don't define predefined macros multiple times

barannikov88 added a comment. Q: What is it the -Wsystem-header can warn about? I mean, no system header is included by the test, what can go wrong? Comment at: clang/test/Preprocessor/predefined-macros-no-warnings.c:2 +// Check that the predefined macros don't contain anythin

[PATCH] D148573: Allow -fsanitize=function on all targets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG67cbe1b85972: Allow -fsanitize=function on all targets (authored by MaskRay). Herald added subscribers: pcwang-thead, s.egerton, mstorsjo, simoncook,

[PATCH] D124244: [analyzer] add StoreToImmutable and ModelConstQualifiedReturn checkers

donat.nagy added a comment. Overall this seems to be a promising checker; I added a few minor remarks as inline comments. Unfortunately @steakhal's comment that > The `check::PostCall` handler wants to mark some memory region immutable. > Currently, the checker creates a new //symbolic// memreg

[PATCH] D150968: [NFC][CLANG] Fix issue with dereference null return value found by Coverity static analyzer tool

Manna added a comment. Thank you @erichkeane for review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150968/new/ https://reviews.llvm.org/D150968 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148088: [RFC][clangd] Move preamble index out of document open critical path

kuganv updated this revision to Diff 523784. kuganv added a comment. Revised Except for: 1. Explicitly destructing in AfterExecute 2. setStatCache to take refence Removing Both of which is causing crash. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D150966: [clang] Don't define predefined macros multiple times

john.brawn updated this revision to Diff 523785. john.brawn added a comment. Remove redundant braces, explain more in test comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150966/new/ https://reviews.llvm.org/D150966 Files: clang/lib/Basic/Targets/AArch64.cpp clang/lib/Basic/

[PATCH] D150948: [clang][RecoveryExpr] Fix a crash where a dependent type crahes on c-only code path.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but this should have a release note for the fix. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150948/new/ https://r

[PATCH] D150955: [clang][AST] Propagate the value-dependent bit for VAArgExpr.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM assuming CI is okay with it -- the patch did not apply so precommit CI never ran. I'm surprised no tests break as a result of this because it changes both C and C++ behavior

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

sdesmalen accepted this revision. sdesmalen added a comment. Thanks @bryanpkc this patch looks good to me now. I'll make some time to review the other patches in the series as well after you update them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[clang] ba1f31f - [CLANG][AArch64][SVE2.1] Add UCLAMP/SCLAMP/FCLAMP function prototypes

Author: Caroline Concatto Date: 2023-05-19T15:36:22Z New Revision: ba1f31fb066af2769634ebb2e23d683d8d409f37 URL: https://github.com/llvm/llvm-project/commit/ba1f31fb066af2769634ebb2e23d683d8d409f37 DIFF: https://github.com/llvm/llvm-project/commit/ba1f31fb066af2769634ebb2e23d683d8d409f37.diff

[PATCH] D150863: [CLANG][AArch64][SVE2.1] Add UCLAMP/SCLAMP/FCLAMP function prototypes

This revision was automatically updated to reflect the committed changes. Closed by commit rGba1f31fb066a: [CLANG][AArch64][SVE2.1] Add UCLAMP/SCLAMP/FCLAMP function prototypes (authored by CarolineConcatto). Changed prior to commit: https://reviews.llvm.org/D150863?vs=523343&id=523793#toc Rep

[PATCH] D148088: [RFC][clangd] Move preamble index out of document open critical path

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:90 +if (Tasks) { + std::unique_lock Lock(*Barrier, std::try_to_lock); + Tasks->runAsync("task:" + Path + Version, std::move(Task)); DmitryPolukhin wrote: > kadirce

[PATCH] D150966: [clang] Don't define predefined macros multiple times

john.brawn updated this revision to Diff 523803. john.brawn marked 2 inline comments as done. john.brawn added a comment. Send test output to /dev/null CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150966/new/ https://reviews.llvm.org/D150966 Files: clang/lib/Basic/Targets/AArch64.cp

[PATCH] D150966: [clang] Don't define predefined macros multiple times

john.brawn added a comment. In D150966#4356403 , @barannikov88 wrote: > Is it possible/worth to add an assertion to Builder.defineMacro to enforce > this one definition rule? It just appends a string to a raw_ostream, so it's not possible to check what

[PATCH] D150887: [clang] Convert a few tests to opaque pointers

barannikov88 added inline comments. Comment at: clang/test/CodeGenCXX/const-init-cxx11.cpp:353 }; - // CHECK: @_ZN14VirtualMembersL13sGlobalMemoryE = internal global { i8** } { i8** getelementptr inbounds ({ [3 x i8*] }, { [3 x i8*] }* @_ZTVN14VirtualMembers12nsMemoryImplE,

[PATCH] D124349: [analyzer] Get direct binding for specific punned case

isuckatcs added inline comments. Comment at: clang/test/Analysis/array-punned-region.c:23 + BITFIELD_CAST *pff = &ff; + int a = *((int *)pff + 2); // expected-warning{{Assigned value is garbage or undefined [core.uninitialized.Assign]}} + return a; @steakhal

[PATCH] D150930: [Driver] Accept and ignore -fno-lifetime-dse argument

jhuber6 added a comment. In D150930#4355240 , @MaskRay wrote: > Note: for options controlling individual optimization behaviors, there is a > large probability that they may not make sense for Clang since the two > compilers' internals are so different.

[clang] 78d8312 - [Clang][clang-cl] Implement `__builtin_FUNCSIG`

Author: Jakub Mazurkiewicz Date: 2023-05-19T12:02:44-04:00 New Revision: 78d8312acea96f58f13a876f98d241590c16d530 URL: https://github.com/llvm/llvm-project/commit/78d8312acea96f58f13a876f98d241590c16d530 DIFF: https://github.com/llvm/llvm-project/commit/78d8312acea96f58f13a876f98d241590c16d530.

[PATCH] D150183: [Clang][clang-cl] Implement `__builtin_FUNCSIG`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG78d8312acea9: [Clang][clang-cl] Implement `__builtin_FUNCSIG` (authored by JMazurkiewicz, committed by aaron.ballman). Repository: rG LLVM Github

[PATCH] D150978: [clang][Sema] Add CodeCompletionContext::CCC_ObjCClassForwardDecl

dgoldman created this revision. dgoldman added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added projects: clang, clang-tools-extra. - Use this new c

[PATCH] D150966: [clang] Don't define predefined macros multiple times

barannikov88 added a comment. In D150966#4356695 , @john.brawn wrote: >> Q: What is it the -Wsystem-header can warn about? I mean, no system header >> is included by the test, what can go wrong? > > The buffer is treated as a system header. I've expand

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante added a comment. In D144509#4356160 , @hans wrote: > In D144509#4350052 , @Mordante > wrote: > >> In D144509#4349921 , @thakis wrote: >> >>> Reverted this and fo

[PATCH] D150887: [clang] Convert a few tests to opaque pointers

barannikov88 added inline comments. Comment at: clang/test/CodeGenCXX/const-init-cxx11.cpp:353 }; - // CHECK: @_ZN14VirtualMembersL13sGlobalMemoryE = internal global { i8** } { i8** getelementptr inbounds ({ [3 x i8*] }, { [3 x i8*] }* @_ZTVN14VirtualMembers12nsMemoryImplE,

[PATCH] D150946: [clang][Interp] PointerToIntegral casts

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150946/new/ https://reviews.llvm.org/D150946 ___

[PATCH] D149677: [clang][TypePrinter] Add option to skip over elaborated types

aaron.ballman added reviewers: dblaikie, sammccall. aaron.ballman added subscribers: sammccall, dblaikie. aaron.ballman added a comment. In D149677#4350337 , @li.zhe.hua wrote: > In D149677#4349523 , @aaron.ballm

[clang] dae1754 - Reword diagnostic for style; NFC

Author: Aaron Ballman Date: 2023-05-19T12:38:33-04:00 New Revision: dae175423a07fbc63cf9d996751609361493f925 URL: https://github.com/llvm/llvm-project/commit/dae175423a07fbc63cf9d996751609361493f925 DIFF: https://github.com/llvm/llvm-project/commit/dae175423a07fbc63cf9d996751609361493f925.diff

[PATCH] D150948: [clang][RecoveryExpr] Fix a crash where a dependent type crahes on c-only code path.

shafik accepted this revision. shafik added a comment. Thank you for the fix, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150948/new/ https://reviews.llvm.org/D150948 ___ cfe-commits mailing list

[PATCH] D150913: [Clang][Bfloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

rjmccall added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:381 HasBFloat16 = SSELevel >= SSE2; pengfei wrote: > I'm not sure if I understand the meaning of `HasFullBFloat16`. If it is used > for target that supports arithmetic `__bf16`,

[PATCH] D148505: Allow `__attribute__((warn_unused))` on individual constructors

aaron.ballman added a comment. In D148505#4331647 , @sberg wrote: > In D148505#4302702 , @aaron.ballman > wrote: > >> Thank you for poking on this! FWIW, I don't know that there's a way to >> cross-post to Disco

[PATCH] D147808: [clangd] Support non-trivial defaulted special member functions in Define Outline tweak

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks a lot, and sorry for the delay! Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:333 +[](const syntax::Token &Tok) { return Tok.kind(

[PATCH] D148505: Allow `__attribute__((warn_unused))` on individual constructors

erichkeane added a comment. I'm still on the fence. I think properly documenting all of this entire attribute would make me more comfortable here, particularly since it will allow GCC to follow us easily some day. I think that would move the needle for me. Comment at: clang

[PATCH] D146873: [2/11][POC][Clang][RISCV] Define RVV tuple types

eopXD updated this revision to Diff 523834. eopXD added a comment. Rebase to latest main before landing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146873/new/ https://reviews.llvm.org/D146873 Files: clang/include/clang/Basic/RISCVVTypes

[PATCH] D150752: [bolt] Use correct output paths and passthrough necessary options

Amir added a comment. Please retitle as "[BOLT][CMake] ..." Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150752/new/ https://reviews.llvm.org/D150752 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang] be37e3e - [NFC][CLANG] Fix dereference issue before null check found by Coverity static analyzer tool

Author: Manna, Soumi Date: 2023-05-19T10:16:14-07:00 New Revision: be37e3e25982c9346df883fcc61e7b60311594a4 URL: https://github.com/llvm/llvm-project/commit/be37e3e25982c9346df883fcc61e7b60311594a4 DIFF: https://github.com/llvm/llvm-project/commit/be37e3e25982c9346df883fcc61e7b60311594a4.diff

[PATCH] D150895: [NFC][CLANG] Fix dereference issue before null check found by Coverity static analyzer tool

This revision was automatically updated to reflect the committed changes. Manna marked an inline comment as done. Closed by commit rGbe37e3e25982: [NFC][CLANG] Fix dereference issue before null check found by Coverity static… (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D150965: [HIP] Allow std::malloc in device function

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/test/Headers/Inputs/include/math.h:108-109 long lroundf(float __a); -int max(int __a, int __b); -int min(int __a, int __b); double modf(double __a, double

[PATCH] D148089: [clang][CodeGen] Break up TargetInfo.cpp [1/8]

barannikov88 updated this revision to Diff 523839. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148089/new/ https://reviews.llvm.org/D148089 Files: clang/lib/CodeGen/TargetInfo.cpp Index: clang/lib/CodeGen

[PATCH] D148090: [clang][CodeGen] Break up TargetInfo.cpp [2/8]

barannikov88 updated this revision to Diff 523840. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148090/new/ https://reviews.llvm.org/D148090 Files: clang/lib/CodeGen/TargetInfo.cpp Index: clang/lib/CodeGen/

[PATCH] D148091: [clang][CodeGen] Break up TargetInfo.cpp [3/8]

barannikov88 updated this revision to Diff 523841. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148091/new/ https://reviews.llvm.org/D148091 Files: clang/lib/CodeGen/TargetInfo.cpp Index: clang/lib/CodeGen

[PATCH] D148092: [clang][CodeGen] Break up TargetInfo.cpp [4/8]

barannikov88 updated this revision to Diff 523842. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148092/new/ https://reviews.llvm.org/D148092 Files: clang/lib/CodeGen/TargetInfo.cpp clang/lib/CodeGen/Target

[PATCH] D148093: [clang][CodeGen] Break up TargetInfo.cpp [5/8]

barannikov88 updated this revision to Diff 523843. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148093/new/ https://reviews.llvm.org/D148093 Files: clang/lib/CodeGen/ABIInfo.h clang/lib/CodeGen/TargetInfo.

[PATCH] D150178: [clang][CodeGen] Break up TargetInfo.cpp [6/8]

barannikov88 updated this revision to Diff 523844. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150178/new/ https://reviews.llvm.org/D150178 Files: clang/lib/CodeGen/TargetInfo.cpp clang/lib/CodeGen/Target

[PATCH] D150215: [clang][CodeGen] Break up TargetInfo.cpp [7/8]

barannikov88 updated this revision to Diff 523845. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150215/new/ https://reviews.llvm.org/D150215 Files: clang/lib/CodeGen/TargetInfo.cpp clang/lib/CodeGen/Target

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 updated this revision to Diff 523846. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/UsersManual.rst clang/docs/tools/clang-formatt

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D147731: [3/11][POC][Clang][RISCV] Add typedef of the tuple type and define tuple type variant of vlseg2e32

eopXD updated this revision to Diff 523847. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147731/new/ https://reviews.llvm.org/D147731 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/Basic/riscv_v

[PATCH] D147774: [4/11][POC][Clang][RISCV] Define tuple type variant of vsseg2e32

eopXD updated this revision to Diff 523848. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147774/new/ https://reviews.llvm.org/D147774 Files: clang/include/clang/Basic/riscv_vector.td clang/lib/CodeGen/CGBuiltin.

[PATCH] D147911: [5/11][POC][Clang][RISCV] Define tuple type variant of vlseg2e32ff

eopXD updated this revision to Diff 523849. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147911/new/ https://reviews.llvm.org/D147911 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/rv

[PATCH] D147912: [6/11][POC][Clang][RISCV] Define tuple type variant of vlsseg2e32

eopXD updated this revision to Diff 523850. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147912/new/ https://reviews.llvm.org/D147912 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/rv

[PATCH] D147913: [7/11][POC][Clang][RISCV] Define tuple type variant of vssseg2e32

eopXD updated this revision to Diff 523851. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147913/new/ https://reviews.llvm.org/D147913 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/rv

[PATCH] D147914: [8/11][POC][Clang][RISCV] Define tuple type variant of vloxseg2ei32 vluxseg2ei32

eopXD updated this revision to Diff 523852. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147914/new/ https://reviews.llvm.org/D147914 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/rv

[PATCH] D147915: [9/11][POC][Clang][RISCV] Define tuple type variant of vsoxseg2ei32 vsuxseg2ei32

eopXD updated this revision to Diff 523853. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147915/new/ https://reviews.llvm.org/D147915 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/rv

[PATCH] D148723: [clang] Fix comdat for InlineBuiltin declarations

efriedma added a comment. I spoke a little loosely when I said "C++ code". I meant "code using C++ 'inline' semantics", which includes C code on Windows. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148723/new/ https://reviews.llvm.org/D148723 ___

[clang] fe69bb6 - Fix tests failure on 75993812d5c1f269b781c34987748f2a792a579d

Author: Zequan Wu Date: 2023-05-19T13:34:40-04:00 New Revision: fe69bb64415ef6fe01ebbb1d1a801e85bd6bd879 URL: https://github.com/llvm/llvm-project/commit/fe69bb64415ef6fe01ebbb1d1a801e85bd6bd879 DIFF: https://github.com/llvm/llvm-project/commit/fe69bb64415ef6fe01ebbb1d1a801e85bd6bd879.diff LOG

[PATCH] D150817: Use windows baskslash on anonymous tag locations if using MSVCFormatting and it's not absolute path.

zequanwu added a comment. In D150817#4356305 , @TWeaver wrote: > Hello and good afternoon from the UK, > > I believe this patch has caused failures on the following buildbot: > > https://lab.llvm.org/buildbot/#/builders/216/builds/21493 > > are you able t

[PATCH] D150752: [BOLT][CMake] Use correct output paths and passthrough necessary options

phosek added inline comments. Comment at: bolt/CMakeLists.txt:88 + if(CMAKE_SYSROOT) +list(APPEND extra_args -DCMAKE_SYSROOT=${CMAKE_SYSROOT}) + endif() michaelplatings wrote: > phosek wrote: > > michaelplatings wrote: > > > michaelplatings wrote: > > > > T

[clang] 9e6e337 - [BOLT][CMake] Use correct output paths and passthrough necessary options

Author: Petr Hosek Date: 2023-05-19T17:43:27Z New Revision: 9e6e3375f12e5e61dd2e371d94c263e3862f58a1 URL: https://github.com/llvm/llvm-project/commit/9e6e3375f12e5e61dd2e371d94c263e3862f58a1 DIFF: https://github.com/llvm/llvm-project/commit/9e6e3375f12e5e61dd2e371d94c263e3862f58a1.diff LOG: [B

[PATCH] D150752: [BOLT][CMake] Use correct output paths and passthrough necessary options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9e6e3375f12e: [BOLT][CMake] Use correct output paths and passthrough necessary options (authored by phosek). Repository: rG LLVM Github Monorepo

[PATCH] D148505: Allow `__attribute__((warn_unused))` on individual constructors

aaron.ballman added a comment. In D148505#4356951 , @erichkeane wrote: > I'm still on the fence. I think properly documenting all of this entire > attribute would make me more comfortable here, particularly since it will > allow GCC to follow us easil

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

hazohelet added a comment. In D146358#4352792 , @erichkeane wrote: > In D146358#4351787 , @hazohelet > wrote: > >> In D146358#4350810 , @erichkeane >> wrote: >> >>> Our

[PATCH] D147916: [10/11][POC][Clang][RISCV] Define vget for tuple type

eopXD updated this revision to Diff 523861. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147916/new/ https://reviews.llvm.org/D147916 Files: clang/include/clang/Basic/riscv_vector.td clang/lib/Sema/SemaChecking.

[PATCH] D147917: [11/11][POC][Clang][RISCV] Define vset for tuple type

eopXD updated this revision to Diff 523862. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147917/new/ https://reviews.llvm.org/D147917 Files: clang/include/clang/Basic/riscv_vector.td clang/lib/Sema/SemaChecking.

[PATCH] D150820: [NVPTX, CUDA] added optional src_size argument to __nvvm_cp_async*

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6963c61f0f6e: [NVPTX/CUDA] added an optional src_size argument to __nvvm_cp_async* (authored by tra). Repository: rG LLVM Github Monorepo CHANGES

[clang] 6963c61 - [NVPTX/CUDA] added an optional src_size argument to __nvvm_cp_async*

Author: Artem Belevich Date: 2023-05-19T10:59:36-07:00 New Revision: 6963c61f0f6e4be2039cb45e824ea1e83a8f1526 URL: https://github.com/llvm/llvm-project/commit/6963c61f0f6e4be2039cb45e824ea1e83a8f1526 DIFF: https://github.com/llvm/llvm-project/commit/6963c61f0f6e4be2039cb45e824ea1e83a8f1526.diff

[PATCH] D150965: [HIP] Allow std::malloc in device function

yaxunl added inline comments. Comment at: clang/test/Headers/Inputs/include/math.h:108-109 long lroundf(float __a); -int max(int __a, int __b); -int min(int __a, int __b); double modf(double __a, double *__b); tra wrote: > Why were these functions removed? It d

[PATCH] D149677: [clang][TypePrinter] Add option to skip over elaborated types

dblaikie added a comment. In D149677#4356863 , @aaron.ballman wrote: > In D149677#4350337 , @li.zhe.hua > wrote: > >> In D149677#4349523 , >> @aaron.ballman wrote: >> >

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

rjmccall added inline comments. Comment at: clang/include/clang/Basic/IdentifierTable.h:316 + unsigned getInterestingIdentifierID() { +if (ObjCOrBuiltinID >= 1341 && ObjCOrBuiltinID < 1343) + return ObjCOrBuiltinID; This is closer to the right approach

[PATCH] D147916: [10/11][POC][Clang][RISCV] Define vget for tuple type

eopXD updated this revision to Diff 523865. eopXD added a comment. Add unsigned cast to eliminate compile warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147916/new/ https://reviews.llvm.org/D147916 Files: clang/include/clang/Basic/riscv_

[PATCH] D147917: [11/11][POC][Clang][RISCV] Define vset for tuple type

eopXD updated this revision to Diff 523867. eopXD added a comment. Add unsigned cast to eliminate compile warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147917/new/ https://reviews.llvm.org/D147917 Files: clang/include/clang/Basic/riscv_

[PATCH] D150985: [clang] Allow fp in atomic fetch max/min builtins

yaxunl created this revision. yaxunl added reviewers: rjmccall, tra. Herald added subscribers: kerbowa, jvesely. Herald added a project: All. yaxunl requested review of this revision. LLVM IR already allows floating point type in atomicrmw. Update clang atomic fetch max/min builtins to accept floa

[PATCH] D150948: [clang][RecoveryExpr] Fix a crash where a dependent type crahes on c-only code path.

hokein updated this revision to Diff 523868. hokein added a comment. add release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150948/new/ https://reviews.llvm.org/D150948 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaDecl.cpp

[PATCH] D150948: [clang][RecoveryExpr] Fix a crash where a dependent type crahes on c-only code path.

hokein added a comment. Thanks for the fast review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150948/new/ https://reviews.llvm.org/D150948 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D149612: [Sema] avoid merge error type

HerrCai0907 updated this revision to Diff 523870. HerrCai0907 added a comment. revert untill first version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149612/new/ https://reviews.llvm.org/D149612 Files: clang/docs/ReleaseNotes.rst clang/lib/

[PATCH] D150212: [clang][Sema] Improve diagnostics for auto return type

yaxunl added a comment. ping The pre-merge check failure seems not related to the patch. Other patches also fail the same way. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150212/new/ https://reviews.llvm.org/D150212 ___ cfe-commits mailin

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

HerrCai0907 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149516/new/ https://reviews.llvm.org/D149516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D149612: [Sema] avoid merge error type

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I think this is looking fine to me. Thanks for your patience on this, I know it was a tough review. Comment at: clang/lib/Sema/SemaDecl.cpp:4399

[clang] a62e205 - [clang][RecoveryExpr] Fix a crash where a dependent type crahes on c-only code path.

Author: Haojian Wu Date: 2023-05-19T20:24:54+02:00 New Revision: a62e205254c0f482ba38bacc1f7f6927e6bc6375 URL: https://github.com/llvm/llvm-project/commit/a62e205254c0f482ba38bacc1f7f6927e6bc6375 DIFF: https://github.com/llvm/llvm-project/commit/a62e205254c0f482ba38bacc1f7f6927e6bc6375.diff LO

[PATCH] D150948: [clang][RecoveryExpr] Fix a crash where a dependent type crahes on c-only code path.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa62e205254c0: [clang][RecoveryExpr] Fix a crash where a dependent type crahes on c-only code… (authored by hokein). Repository: rG LLVM Github Mon

[PATCH] D150985: [clang] Allow fp in atomic fetch max/min builtins

tra added a comment. The code changes look OK to me. Whether allowing FP for clang builtins is OK -- I have no idea, especially for the c11 ones. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150985/new/ https://reviews.llvm.org/D150985 ___

[PATCH] D148089: [clang][CodeGen] Break up TargetInfo.cpp [1/8]

rjmccall added a comment. Sergei, feel free to start landing patches like this one that were already approved. You don't need the entire sequence to be approved first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148089/new/ https://reviews.llvm

[PATCH] D150965: [HIP] Allow std::malloc in device function

tra added inline comments. Comment at: clang/test/Headers/Inputs/include/math.h:108-109 long lroundf(float __a); -int max(int __a, int __b); -int min(int __a, int __b); double modf(double __a, double *__b); yaxunl wrote: > tra wrote: > > Why were these function

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

ahatanak added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148851/new/ https://reviews.llvm.org/D148851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D150955: [clang][AST] Propagate the value-dependent bit for VAArgExpr.

hokein updated this revision to Diff 523875. hokein added a comment. add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150955/new/ https://reviews.llvm.org/D150955 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ComputeDependence

[PATCH] D150955: [clang][AST] Propagate the value-dependent bit for VAArgExpr.

hokein added a comment. Thanks for the review. In D150955#4356580 , @aaron.ballman wrote: > LGTM assuming CI is okay with it -- the patch did not apply so precommit CI > never ran. I'm surprised no tests break as a result of this because it > changes

[PATCH] D150894: [CUDA] provide wrapper functions for new NVCC builtins.

tra updated this revision to Diff 523879. tra added a comment. Added __nv_associate_access_property_impl() stub. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150894/new/ https://reviews.llvm.org/D150894 Files: clang/lib/Headers/__clang_cuda_int

[PATCH] D148089: [clang][CodeGen] Break up TargetInfo.cpp [1/8]

barannikov88 added a comment. In D148089#4357219 , @rjmccall wrote: > Sergei, feel free to start landing patches like this one that were already > approved. You don't need the entire sequence to be approved first. Ah, OK! I thought it is required. Re

[PATCH] D150894: [CUDA] provide wrapper functions for new NVCC builtins.

tra updated this revision to Diff 523881. tra added a comment. typo fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150894/new/ https://reviews.llvm.org/D150894 Files: clang/lib/Headers/__clang_cuda_intrinsics.h Index: clang/lib/Headers/__c

[PATCH] D137872: Implement lambdas with inalloca parameters by forwarding to function without inalloca calling convention.

efriedma added a comment. In D137872#4348314 , @akhuang wrote: > In D137872#4327615 , @efriedma > wrote: > >> I'm having a bit of trouble following how exactly the thunk creation is >> working here... do we gene

[clang] 4450285 - [CUDA] provide wrapper functions for new NVCC builtins.

Author: Artem Belevich Date: 2023-05-19T11:48:08-07:00 New Revision: 4450285bd74079bf87ba7b824a8dec8dcfb586ef URL: https://github.com/llvm/llvm-project/commit/4450285bd74079bf87ba7b824a8dec8dcfb586ef DIFF: https://github.com/llvm/llvm-project/commit/4450285bd74079bf87ba7b824a8dec8dcfb586ef.diff

[PATCH] D150894: [CUDA] provide wrapper functions for new NVCC builtins.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4450285bd740: [CUDA] provide wrapper functions for new NVCC builtins. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

erichkeane added a comment. In D146358#4357106 , @hazohelet wrote: > In D146358#4352792 , @erichkeane > wrote: > >> In D146358#4351787 , @hazohelet >> wrote: >> >>> In D

  1   2   3   >