[PATCH] D150582: [clangd] Fix test failure when it's built with compiler flags unknown by clang

xry111 added a comment. Hmm, I'd tested the change before creating this but it seems those tests are "UNSUPPORTED" on my system :(. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150582/new/ https://reviews.llvm.org/D150582 ___

[clang] 4054c68 - [XCOFF][DWARF] XCOFF64 should be able to select the dwarf format in intergrated-as mode.

Author: esmeyi Date: 2023-05-16T03:02:00-04:00 New Revision: 4054c68644dfebbb584bca698a25d18d1d312bae URL: https://github.com/llvm/llvm-project/commit/4054c68644dfebbb584bca698a25d18d1d312bae DIFF: https://github.com/llvm/llvm-project/commit/4054c68644dfebbb584bca698a25d18d1d312bae.diff LOG: [

[PATCH] D150181: [XCOFF][DWARF] XCOFF64 should be able to select the dwarf format in intergrated-as mode.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4054c68644df: [XCOFF][DWARF] XCOFF64 should be able to select the dwarf format in intergrated… (authored by Esme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] 258c9be - [clang][analyzer] Handle special value AT_FDCWD in affected standard functions

Author: Balázs Kéri Date: 2023-05-16T09:28:14+02:00 New Revision: 258c9bebbdfa793493b71db555f5deb5ade499b4 URL: https://github.com/llvm/llvm-project/commit/258c9bebbdfa793493b71db555f5deb5ade499b4 DIFF: https://github.com/llvm/llvm-project/commit/258c9bebbdfa793493b71db555f5deb5ade499b4.diff L

[PATCH] D149160: [clang][analyzer] Handle special value AT_FDCWD in affected standard functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG258c9bebbdfa: [clang][analyzer] Handle special value AT_FDCWD in affected standard functions (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang] c2b256a - Reapply [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl

Author: Martin Storsjö Date: 2023-05-16T10:41:30+03:00 New Revision: c2b256a990590dc8b69930259650cfeb085add03 URL: https://github.com/llvm/llvm-project/commit/c2b256a990590dc8b69930259650cfeb085add03 DIFF: https://github.com/llvm/llvm-project/commit/c2b256a990590dc8b69930259650cfeb085add03.diff

[PATCH] D149997: [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl

This revision was automatically updated to reflect the committed changes. Closed by commit rGc2b256a99059: Reapply [clang] [test] Narrow down MSVC specific behaviours from "any windows"… (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D148088: [RFC][clangd] Move preamble index out of document open critical path

kuganv updated this revision to Diff 522471. kuganv added a comment. As per review, moved Preamble indexing into ClangdServer's IndexTasks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148088/new/ https://reviews.llvm.org/D148088 Files: clang-t

[PATCH] D148088: [RFC][clangd] Move preamble index out of document open critical path

kuganv added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:694 Result->MainIsIncludeGuarded = CapturedInfo.isMainFileIncludeGuarded(); -return Result; +CapturedCtx.emplace(CapturedInfo.takeLife()); +return std::make_pair(Result, CapturedCtx);

[PATCH] D150645: [Driver] Support multi /guard: options

pengfei created this revision. pengfei added reviewers: rnk, arlosi, thakis, ajpaverd. Herald added a project: All. pengfei requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.

[PATCH] D150646: [clang][X86] Add __cpuidex function to cpuid.h

aidengrossman created this revision. Herald added a project: All. aidengrossman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. MSVC has a __cpuidex function implemented to call the underlying cpuid instruction which accepts a leaf, subleaf

[PATCH] D149551: [Interpreter] Filter out RISC-V +relax feature

Hahnfeld abandoned this revision. Hahnfeld added a comment. Linker relaxation and proper alignment handling for RISC-V is implemented in https://reviews.llvm.org/D149526, so this isn't needed anymore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D150647: [WIP][analyzer] Fix EnumCastOutOfRangeChecker C++17 handling

gamesh411 created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: All. gamesh411 requested review of this

[PATCH] D150647: [WIP][analyzer] Fix EnumCastOutOfRangeChecker C++17 handling

gamesh411 added a comment. Just the test cases are added so far. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150647/new/ https://reviews.llvm.org/D150647 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D148088: [RFC][clangd] Move preamble index out of document open critical path

DmitryPolukhin added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:694 Result->MainIsIncludeGuarded = CapturedInfo.isMainFileIncludeGuarded(); -return Result; +CapturedCtx.emplace(CapturedInfo.takeLife()); +return std::make_pair(Result, Captu

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

zyounan added a comment. Sorry for chiming in. Left a few nit comments and I hope you don't mind. :) Comment at: clang-tools-extra/clangd/InlayHints.cpp:772 + Label = printName(AST, D); +} else { + // We handle type and namespace decls together. Q

[PATCH] D150579: [*]: fix syntax errors in HTML files

VoltrexMaster updated this revision to Diff 522507. VoltrexMaster added a comment. Fix merge conflict Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150579/new/ https://reviews.llvm.org/D150579 Files: clang-tools-extra/docs/_templates/clangd_redi

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

sammccall added a comment. Thanks for doing this! Some high-level comments here, will review implementation next: **There seems to be a lot of "decoration" on the hint text.** If declaring a class "Foo" then we add ` /* class ` before and ` */ ` after Foo, for a total of 14 characters apart fr

[PATCH] D150652: [clang] Convert a few OpenMP tests to opaque pointers

barannikov88 added a comment. These tests were updated manually, but I verified that the script produces similar results (modulo the cases that it couldn't handle, mostly CHECK-DAG). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150652/new/ https:

[PATCH] D150652: [clang] Convert a few OpenMP tests to opaque pointers

barannikov88 added inline comments. Comment at: clang/test/OpenMP/target_update_codegen.cpp:171-173 -// CK1-DAG: [[BP]] = getelementptr inbounds [1 x i8*], [1 x i8*]* [[BPADDR:%[^,]+]], i[[sz]] 0, i[[sz]] 0 -// CK1-DAG: [[P]] = getelementptr inbounds [1 x i8*], [1 x i8*]* [[PAD

[PATCH] D150653: [clang][dataflow] Add `Strict` versions of `Value` and `StorageLocation` accessors.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is part of the gradual migration to strict

[PATCH] D150647: [WIP][analyzer] Fix EnumCastOutOfRangeChecker C++17 handling

steakhal added a comment. > In C++17 the initialization rules for enum classes are relaxed. In what way are they relaxed compared to regular enums? Anyway, IMO those are indeed FPs, see https://godbolt.org/z/7z984bz6v I'm looking forward to the fix. Thanks. Repository: rG LLVM Github Monore

[PATCH] D150654: [clang][Interp] ComplexFloatingToBoolean casts

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://revi

[PATCH] D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch handles the straightforward cases. Up

[PATCH] D150656: [clang][dataflow] Use `Strict` accessors in TypeErasedDataflowAnalysis.cpp.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is part of the ongoing migration to s

[PATCH] D150552: [analyzer] Fix QTimer::singleShot NewDeleteLeaks false positive

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Good job. Looks good to me. This is pretty much analogous to D27717 . The same reasoning applies. Thanks for the patch. Should I commit this on your behalf?

[PATCH] D150657: [clang][dataflow] Use `Strict` accessors in SignAnalysisTest.cpp.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is part of the ongoing migration to strict handling of value catego

[PATCH] D150608: [clang] Convert several OpenMP tests to opaque pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rGd522c2f39d51: [clang] Convert several OpenMP tests to opaque pointers (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150608/new/

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

sammccall added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:292 + + bool VisitRecordDecl(RecordDecl *D) { +if (Cfg.InlayHints.EndDefinitionComments && Not sure why if need to handle this + EnumDecl, can we just handle VisitTagDecl t

[PATCH] D148088: [RFC][clangd] Move preamble index out of document open critical path

kuganv updated this revision to Diff 522523. kuganv added a comment. Fixed missing merge that caused build error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148088/new/ https://reviews.llvm.org/D148088 Files: clang-tools-extra/clangd/ClangdSe

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 522527. junaire added a comment. Add comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Interpreter/Interpreter.h clang/include/c

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev added inline comments. Comment at: clang/include/clang/Interpreter/Value.h:23 +// +// NOTE: Since the REPL itself could also include this runtime, extreme caution +// should be taken when MAKING CHANGES to this file, especially when INCLUDE NEW I wo

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 522530. junaire added a comment. Address comment from Vassil, thx Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Interpreter/Interpreter

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. I believe we are at the stage of better is enemy of good now. This looks good to me. I'd recommend to wait for @aaron.ballman's final review. Repository: rG LLVM Github Monorepo

[PATCH] D150552: [analyzer] Fix QTimer::singleShot NewDeleteLeaks false positive

mkmvzlb added a comment. In D150552#4345391 , @steakhal wrote: > Thanks for the patch. Should I commit this on your behalf? Thanks for reviewing and - in advance - for commit: --author "Michael Klein " Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a teeny tiny whitespace nit. Comment at: clang/include/clang/Interpreter/Value.h:27 +// devices where the JIT infrastructure cannot fit. To support that we will need +// to split the memory st

[PATCH] D150430: Implement BufferOverlap check for sprint/snprintf

steakhal added a comment. I like it. How about an implementation like this: void CStringChecker::evalSprintfCommon(CheckerContext &C, const CallExpr *CE, bool IsBounded) const { ProgramStateRef State = C.getState(); DestinationArgExpr Dest = {CE

[PATCH] D150430: Implement BufferOverlap check for sprint/snprintf

steakhal added a comment. Here is the migrated version of the mentioned discussion: https://discourse.llvm.org/t/static-or-dynamic-code-analysis-for-undefined-behavior-in-sprintf/59624 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150430/new/ http

[PATCH] D150531: Fix start index for sprintf ovlerap check + tests

steakhal added a comment. I think you should squash this into D150430 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150531/new/ https://reviews.llvm.org/D150531 ___ cf

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

kadircet added a comment. hi! this seem to have regressed compilation for some valid C++ code: struct Bar { const char *name(); }; struct Baz { static Bar *method(); }; struct Foo { Foo(const char *); }; template void bar() { Foo _(T::method()->name()); } void foo

[PATCH] D150661: [clang][Interp] Allow evaluating standalone composite expressions

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We reach visitExpr() when evaluating standalone e

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 522545. junaire added a comment. remove whitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Interpreter/Interpreter.h clang/incl

[PATCH] D150446: [analyzer] Check ArraySubscriptExprs in ArrayBoundCheckerV2

donat.nagy updated this revision to Diff 522544. donat.nagy edited the summary of this revision. donat.nagy added a comment. I managed to debug the issue that plagued my commit (see `test_multidim_zero()` for details, I think I'll fix it in a followup change); and I have uploaded a new version o

[clang] d4a6e4c - Revert "[Clang] Fix parsing of `(auto(x))`."

Author: Corentin Jabot Date: 2023-05-16T13:56:33+02:00 New Revision: d4a6e4c1eec0f2634febd15725d921d4a25d47e7 URL: https://github.com/llvm/llvm-project/commit/d4a6e4c1eec0f2634febd15725d921d4a25d47e7 DIFF: https://github.com/llvm/llvm-project/commit/d4a6e4c1eec0f2634febd15725d921d4a25d47e7.diff

[PATCH] D150657: [clang][dataflow] Use `Strict` accessors in SignAnalysisTest.cpp.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Analysis/FlowSensitive/SignAnalysisTest.cpp:240 +// Returns the `Value` associated with `E` (which may be either a prvalue or +// glva

[PATCH] D150553: [SVE ACLE] Change the lowering of SVE integer mla_u/mls_u builtins

paulwalker-arm accepted this revision. paulwalker-arm added a comment. This revision is now accepted and ready to land. The commit message is incorrect because the SVE Clang builtins are not named `mla_u` and so should read `SVE integer mla_x/mls_x builtins` Other than that the patch looks good

[PATCH] D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp.

sammccall added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:138 +static void forwardValue(const Expr &From, const Expr &To, Environment &Env) { + if (auto *Val = Env.getValueStrict(From)) the name "forward" isn't clear to me - if

[clang] 247fa04 - [clang] Add a new annotation token: annot_repl_input_end

Author: Jun Zhang Date: 2023-05-16T20:10:43+08:00 New Revision: 247fa04116a6cabf8378c6c72d90b2f705e969de URL: https://github.com/llvm/llvm-project/commit/247fa04116a6cabf8378c6c72d90b2f705e969de DIFF: https://github.com/llvm/llvm-project/commit/247fa04116a6cabf8378c6c72d90b2f705e969de.diff LOG

[clang] a423b7f - [clang-repl] Introduce Value to capture expression results

Author: Jun Zhang Date: 2023-05-16T20:10:49+08:00 New Revision: a423b7f1d7ca8b263af85944f57a69aa08fc942c URL: https://github.com/llvm/llvm-project/commit/a423b7f1d7ca8b263af85944f57a69aa08fc942c DIFF: https://github.com/llvm/llvm-project/commit/a423b7f1d7ca8b263af85944f57a69aa08fc942c.diff LOG

[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

This revision was automatically updated to reflect the committed changes. Closed by commit rG247fa04116a6: [clang] Add a new annotation token: annot_repl_input_end (authored by junaire). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148997/new/ http

[PATCH] D150657: [clang][dataflow] Use `Strict` accessors in SignAnalysisTest.cpp.

mboehme updated this revision to Diff 522554. mboehme added a comment. Added a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150657/new/ https://reviews.llvm.org/D150657 Files: clang/unittests/Analysis/FlowSensitive/SignAnalysisTest.cpp

[PATCH] D150657: [clang][dataflow] Use `Strict` accessors in SignAnalysisTest.cpp.

mboehme added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/SignAnalysisTest.cpp:240 +// Returns the `Value` associated with `E` (which may be either a prvalue or +// glvalue). Creates a `Value` or `StorageLocation` as needed if `E` does not --

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

hazohelet added a comment. In D146358#4343281 , @aaron.ballman wrote: > LGTM! Did you end up requesting commit access? If not, now is probably a good > time: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access Thanks, I have commit acces

[PATCH] D150446: [analyzer] Check ArraySubscriptExprs in ArrayBoundCheckerV2

donat.nagy added a comment. By the way, I'm fed up with the hack that ElementRegion is used for three separate things ("real" array indexing, casts and pointer arithmetic) and I'm thinking about introducing a subclass hierarchy where a base class `ElementLikeRegion` has three subclasses called

[PATCH] D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp.

mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:138 +static void forwardValue(const Expr &From, const Expr &To, Environment &Env) { + if (auto *Val = Env.getValueStrict(From)) sammccall wrote: > the name "forward" isn't

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire added a comment. Because I have edited the commit messages several times so I forgot to include the revision link. Sorry. I have landed it as https://reviews.llvm.org/rGa423b7f1d7ca8b263af85944f57a69aa08fc942c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D150653: [clang][dataflow] Add `Strict` versions of `Value` and `StorageLocation` accessors.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:644 +StorageLocation *Environment::getStorageLocationStrict(const Expr &E) const { + assert(E.

[PATCH] D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp.

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:138 +static void forwardValue(const Expr &From, const Expr &To, Environment &Env) { + if (auto *Val = Env.g

[PATCH] D150656: [clang][dataflow] Use `Strict` accessors in TypeErasedDataflowAnalysis.cpp.

ymandel accepted this revision. ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:310-317 } else { +auto *InitStmtVal = Env.getValueStrict(*InitStmt); +if (InitStmtVal == nullptr) + return; + auto &Mem

[PATCH] D150653: [clang][dataflow] Add `Strict` versions of `Value` and `StorageLocation` accessors.

ymandel added a comment. I'm a little confused by one of the points in the description: > `setValueStrict()`: The RFC proposes that this should always create the same > StorageLocation for a given Value, but, in fact, the transfer functions that > exist today don't guarantee this; almost all tr

[PATCH] D150652: [clang] Convert a few OpenMP tests to opaque pointers

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150652/new/ https://reviews.llvm.org/D150652

[PATCH] D150661: [clang][Interp] Allow evaluating standalone composite expressions

tbaeder updated this revision to Diff 522563. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150661/new/ https://reviews.llvm.org/D150661 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/complex.cpp Index: clang/test/AST/Interp/complex.cpp ==

[PATCH] D150661: [clang][Interp] Allow evaluating standalone composite expressions

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:2287 +return true; } case UO_Imag: { // __imag x I added these changes to make the test work, but they are thematically different from the purpose of this patch. Howev

[PATCH] D150446: [analyzer] Check ArraySubscriptExprs in ArrayBoundCheckerV2

steakhal added a comment. In D150446#4345723 , @donat.nagy wrote: > By the way, I'm fed up with the hack that ElementRegion is used for three > separate things ("real" array indexing, casts and pointer arithmetic). To fix > this I'm thinking about intr

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e167fc0a214: [clang][AST] Print name instead of type when diagnosing uninitialized subobject… (authored by hazohelet). Repository: rG LLVM Github

[clang] 0e167fc - [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

Author: Takuya Shimizu Date: 2023-05-16T21:49:57+09:00 New Revision: 0e167fc0a2147c9b673b8afd5fea001b0d127781 URL: https://github.com/llvm/llvm-project/commit/0e167fc0a2147c9b673b8afd5fea001b0d127781 DIFF: https://github.com/llvm/llvm-project/commit/0e167fc0a2147c9b673b8afd5fea001b0d127781.diff

[clang-tools-extra] 8f84797 - [clangd] downgrade missing-includes diagnostic to Information level

Author: Sam McCall Date: 2023-05-16T15:03:50+02:00 New Revision: 8f8479789a08a7ec68008b20d3889ccf7fbcda1c URL: https://github.com/llvm/llvm-project/commit/8f8479789a08a7ec68008b20d3889ccf7fbcda1c DIFF: https://github.com/llvm/llvm-project/commit/8f8479789a08a7ec68008b20d3889ccf7fbcda1c.diff LO

[PATCH] D149912: [clangd] downgrade missing-includes diagnostic to Information level

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f8479789a08: [clangd] downgrade missing-includes diagnostic to Information level (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1499

[PATCH] D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp.

mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:138 +static void forwardValue(const Expr &From, const Expr &To, Environment &Env) { + if (auto *Val = Env.getValueStrict(From)) ymandel wrote: > mboehme wrote: > > sammcca

[clang] ddb27b1 - [Clang][LoongArch] Pass the -mabi and -target-abi options to as and cc1as respectively

Author: Weining Lu Date: 2023-05-16T21:10:15+08:00 New Revision: ddb27b1870691595173608ce0c4a0c70ad16513d URL: https://github.com/llvm/llvm-project/commit/ddb27b1870691595173608ce0c4a0c70ad16513d DIFF: https://github.com/llvm/llvm-project/commit/ddb27b1870691595173608ce0c4a0c70ad16513d.diff LO

[PATCH] D150537: [Clang][LoongArch] Pass the -mabi and -target-abi options to as and cc1as respectively

This revision was automatically updated to reflect the committed changes. Closed by commit rGddb27b187069: [Clang][LoongArch] Pass the -mabi and -target-abi options to as and cc1as… (authored by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D128612: RISC-V big-endian support implementation

asb added a comment. Thanks for this patch Guy. As just discussed in the RISC-V sync-up call, it would be helpful from a review perspective to write down at least a simple plain-text description of the changes to the psABI doc needed to reflect the BE ABI implemented by GCC (and soon LLVM), per

[PATCH] D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp.

sammccall added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:138 +static void forwardValue(const Expr &From, const Expr &To, Environment &Env) { + if (auto *Val = Env.getValueStrict(From)) mboehme wrote: > ymandel wrote: > > mboeh

[PATCH] D149612: [Sema] avoid merge error type

aaron.ballman added subscribers: sammccall, hokein. aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:2582 } else if (ArraySize->isTypeDependent() || ArraySize->isValueDependent()) { -T = Context.getDependentSizedArrayType(T, ArraySize, ASM, Qual

[PATCH] D150446: [analyzer] Check ArraySubscriptExprs in ArrayBoundCheckerV2

donat.nagy added a comment. I'll move this class hierarchy modification question into a discourse thread after collecting the relevant facts. (By the way, thanks for suggesting discourse, I was not aware of it!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[clang] 7158fd3 - Revert "[clang-repl] Introduce Value to capture expression results"

Author: Jun Zhang Date: 2023-05-16T21:21:52+08:00 New Revision: 7158fd381a0bc0222195d6a07ebb42ea57957bda URL: https://github.com/llvm/llvm-project/commit/7158fd381a0bc0222195d6a07ebb42ea57957bda DIFF: https://github.com/llvm/llvm-project/commit/7158fd381a0bc0222195d6a07ebb42ea57957bda.diff LOG

[PATCH] D147875: [clang][Diagnostics] Show line numbers when printing code snippets

tbaeder updated this revision to Diff 522580. tbaeder marked 7 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147875/new/ https://reviews.llvm.org/D147875 Files: clang-tools-extra/test/clang-tidy/checkers/cert/uppercase-literal-suffix-integer.cpp clang-tools

[PATCH] D150657: [clang][dataflow] Use `Strict` accessors in SignAnalysisTest.cpp.

sammccall added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/SignAnalysisTest.cpp:240 +// Returns the `Value` associated with `E` (which may be either a prvalue or +// glvalue). Creates a `Value` or `StorageLocation` as needed if `E` does not

[PATCH] D150111: [clang][Interp] Implement lambda static invokers

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:100-103 + bool IsEligibleForCompilation = + FuncDecl->isConstexpr() || + (isa(FuncDecl) && + cast(FuncDecl)->isLambdaStaticInvoker()); aaron.ballman wrote: > I do

[PATCH] D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp.

mboehme updated this revision to Diff 522583. mboehme added a comment. Simplified `else { if {} }` to `else if {}`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150655/new/ https://reviews.llvm.org/D150655 Files: clang/lib/Analysis/FlowSensitiv

[PATCH] D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp.

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:751-752 +Env.setValue(Loc, *Val); +} else { + if (Value *Val = Env.createValue(S->getType())) +Env.setValueStrict(*S, *Val);

[PATCH] D147875: [clang][Diagnostics] Show line numbers when printing code snippets

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147875/new/ https://reviews.llvm.org/D147875 ___ cfe-commits mailing lis

[PATCH] D150111: [clang][Interp] Implement lambda static invokers

tbaeder updated this revision to Diff 522587. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150111/new/ https://reviews.llvm.org/D150111 Files: clang/lib/AST/Interp/ByteCodeEmitter.cpp clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST/Interp/ByteCodeStmtGen.h clang/lib/AST/I

[PATCH] D150579: [*]: fix syntax errors in HTML files

VoltrexMaster updated this revision to Diff 522588. VoltrexMaster added a comment. Update utils/tools to generate HTML with correct syntax Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150579/new/ https://reviews.llvm.org/D150579 Files: clang-to

[clang] 2dc435a - [clang][NFC] Use llvm::count_if instead of manual loop

Author: Timm Bäder Date: 2023-05-16T15:35:05+02:00 New Revision: 2dc435a59d565849ef62ae3c63dd4fc79a3e16f3 URL: https://github.com/llvm/llvm-project/commit/2dc435a59d565849ef62ae3c63dd4fc79a3e16f3 DIFF: https://github.com/llvm/llvm-project/commit/2dc435a59d565849ef62ae3c63dd4fc79a3e16f3.diff LO

[PATCH] D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp.

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:138 +static void forwardValue(const Expr &From, const Expr &To, Environment &Env) { + if (auto *Val = Env.getValueStrict(From)) s

[clang] 3b6a368 - [analyzer] Fix QTimer::singleShot NewDeleteLeaks false positive

Author: Michael Klein Date: 2023-05-16T15:38:55+02:00 New Revision: 3b6a368d763e812024ca6ba4024855603f693291 URL: https://github.com/llvm/llvm-project/commit/3b6a368d763e812024ca6ba4024855603f693291 DIFF: https://github.com/llvm/llvm-project/commit/3b6a368d763e812024ca6ba4024855603f693291.diff

[PATCH] D150654: [clang][Interp] ComplexFloatingToBoolean casts

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LG Comment at: clang/test/AST/Interp/complex.cpp:70-74 + constexpr _Complex float F7 = {0, 1}; + static_assert(F7, ""); + constexpr _Complex float F8 = {1, 0

[PATCH] D150552: [analyzer] Fix QTimer::singleShot NewDeleteLeaks false positive

steakhal closed this revision. steakhal added a comment. And I managed to make a typo in the commit message :D Closed by 3b6a368d763e812024ca6ba4024855603f693291 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D150597: [clang][AIX] Adding Revised xcoff-roptr CodeGen Test Case

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b1f1b9079e2: [clang][AIX] Adding Revised xcoff-roptr CodeGen Test Case (authored by qiongsiwu1). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150597/new/

[clang] 1b1f1b9 - [clang][AIX] Adding Revised xcoff-roptr CodeGen Test Case

Author: Qiongsi Wu Date: 2023-05-16T09:41:24-04:00 New Revision: 1b1f1b9079e2f01f963c6c7cd766d67029ba87cb URL: https://github.com/llvm/llvm-project/commit/1b1f1b9079e2f01f963c6c7cd766d67029ba87cb DIFF: https://github.com/llvm/llvm-project/commit/1b1f1b9079e2f01f963c6c7cd766d67029ba87cb.diff LO

[PATCH] D150653: [clang][dataflow] Add `Strict` versions of `Value` and `StorageLocation` accessors.

mboehme updated this revision to Diff 522591. mboehme added a comment. Tweaked preconditions (in comments and code) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150653/new/ https://reviews.llvm.org/D150653 Files: clang/include/clang/Analysis/Fl

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

rsundahl updated this revision to Diff 522592. rsundahl added a comment. Renamed darwin_exclude_symbols.inc asan_abi_tbd.txt. This file contains the entrypoints that aren't strictly in the interface between the instrumentation and the runtime but may still be part of a public API that needs to ha

[PATCH] D150653: [clang][dataflow] Add `Strict` versions of `Value` and `StorageLocation` accessors.

mboehme marked 3 inline comments as done. mboehme added a comment. In D150653#4345771 , @ymandel wrote: > I'm a little confused by one of the points in the description: > >> `setValueStrict()`: The RFC proposes that this should always create the same >>

[PATCH] D149612: [Sema] avoid merge error type

sammccall added a comment. Unless I'm wildly misremembering (@hokein knows better), the type should also be dependent in C. The intuition is that the code has some meaning that depends on how the error is resolved (by the programmer changing the code!), and that "dependent" is a good first-app

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

jsjodin added a comment. @jdoerfert do you have any feedback? Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:1882 + auto EntryInfo = OMPBuilder.getTargetEntryUniqueInfo( + PLoc.getFilename(), PLoc.getLine(), VD->getName()); SmallString<128> Buffer, Out;

[PATCH] D150668: Add doc link to missing include diagnostics.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D1

[PATCH] D148700: [clang] Add support for “regular” keyword attributes

rsandifo-arm added a comment. Hi @aaron.ballman and @erichkeane . Do you have any more thoughts on this? In principle, I'm happy to convert an existing attribute over to the new scheme, but in practice, I can't find one that seems to be suitable. If we're going to do that, I think I'll need

[PATCH] D150411: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Manna updated this revision to Diff 522608. Manna added a comment. Thank you @aaronpuchert for reviews and the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150411/new/ https://reviews.llvm.org/D150411 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/Analys

[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

pmatos created this revision. pmatos added reviewers: dschuff, tlively. Herald added subscribers: asb, wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. Herald added a project: All. pmatos requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, aheejin

  1   2   3   >