[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

MaskRay added inline comments. Comment at: clang/test/Driver/ftime-trace.cpp:54 +// RUN: %clang -### -ftime-trace=e -ftime-trace-granularity=0 d/a.cpp d/b.c -o f/x -dumpdir f/ 2>&1 | FileCheck %s --check-prefix=LINK3 +// LINK3: -cc1{{.*}} "-ftime-trace=e/a-{{[^.]*}}.json" "-fti

[PATCH] D150430: Implement BufferOverlap check for sprint/snprintf

ArnaudBienner added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:2385 + // sprintf(char *buffer, const char* format, ... /* format arguments */); + unsigned int format_arguments_start_idx = 3; + // snprintf case: one extra extra arguments f

[PATCH] D150403: [clang-format] Adjust braced list detection (try 2)

HazardyKnusperkeks added a comment. Shouldn't it have token annotator tests? Comment at: clang/lib/Format/UnwrappedLineParser.cpp:495-496 SmallVector LBraceStack; + // Track the previous token type corresponding to our lbraces // to help + // detect brace types + SmallVec

[PATCH] D150452: [clang-format] Recognize nested blocks

HazardyKnusperkeks added a comment. On this change I like the token annotator tests, and reusing the same stack instead of adding a second one which always has the same size. But the code changes in D150403 seem to be better, at least I couldn't think directly

[PATCH] D149562: [clang-format] Stop comment disrupting indentation of Verilog ports

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. In D149562#4337955 , @sstwcw wrote: >> I'll go along with other reviewers on this one. > > So what do the other reviewers think

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

manojgupta added a comment. In D150226#4338738 , @manojgupta wrote: >> I was under the impression from https://github.com/boostorg/mpl/issues/69 >> that this was fixed but there are a number of issues off of the main one and >> maybe I am confused. > >

[PATCH] D149997: [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl

mstorsjo added a comment. In D149997#4338304 , @rnk wrote: > I think `_MSC_EXTENSIONS` will work, but it's kind of gross. `_MSC_VER` is > controlled by `-fms-compatibility-verson=`, which I think is off by default > or unset at the cc1 level: > https://

[PATCH] D149997: [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl

mstorsjo updated this revision to Diff 521781. mstorsjo added a comment. Updated to check for `defined(_WIN32) && !defined(__MINGW32__)`. It's a kinda ugly way of checking for an MSVC-like environment specifically (when the MSVC mode is the exception compared with the rest), but neither `_MSC_VE

[PATCH] D150478: [clang][modules][deps] Parse "FW_Private" module map even after loading "FW" PCM

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When Clang loads a PCM

[PATCH] D150479: [clang][modules][deps] Allow skipping submodule definitions

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There are situations wh

[PATCH] D150478: [clang][modules][deps] Parse "FW_Private" module map even after loading "FW" PCM

jansvoboda11 added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:1787 case LMM_NoDirectory: return nullptr; We should probably `break` for `LMM_AlreadyLoaded` instead of returning null. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

v.g.vassilev added inline comments. Comment at: clang/lib/CodeGen/ModuleBuilder.cpp:39 const PreprocessorOptions &PreprocessorOpts; // Only used for debug info. -const CodeGenOptions CodeGenOpts; // Intentionally copied in. +CodeGenOptions CodeGenOpts; // Intention

[PATCH] D148654: Modify BoundsSan to improve debuggability

nlopes added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/BoundsChecking.cpp:189 auto GetTrapBB = [&TrapBB](BuilderTy &IRB) { -if (TrapBB && SingleTrapBB) - return TrapBB; - -Function *Fn = IRB.GetInsertBlock()->getParent(); -// FIXME: This

[clang] 7a0900f - [-Wunsafe-buffer-usage] Remove an unnecessary const-qualifier

Author: ziqingluo-90 Date: 2023-05-12T14:46:56-07:00 New Revision: 7a0900fd3e2d34bc1d513a97cf8fbdc1754252d7 URL: https://github.com/llvm/llvm-project/commit/7a0900fd3e2d34bc1d513a97cf8fbdc1754252d7 DIFF: https://github.com/llvm/llvm-project/commit/7a0900fd3e2d34bc1d513a97cf8fbdc1754252d7.diff

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

hiraditya created this revision. hiraditya added reviewers: enh, danalbert, pirama, srhines. Herald added subscribers: VincentWu, danielkiss, vkmr, sameer.abuasal, s.egerton, Jim, benna, psnobl, rogfer01, shiva0217, kito-cheng, simoncook, asb, arichardson. Herald added a project: All. hiraditya r

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

enh added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:423 + if (Triple.isAndroid() && Triple.getArch() == llvm::Triple::riscv64) +return true; should this... Comment at: clang/lib/Driver/ToolChains/Clang.cpp:439

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

stephenpeckham added a comment. Do the -U and -D flags have any effect on the behavior of llvm-ranlib? Comment at: llvm/test/tools/llvm-ranlib/aix-X-option.test:16 + +## Test OBJECT_MODE environment variable when adding symbol table +# RUN: env OBJECT_MODE=32 llvm-ranlib t_X32.

[PATCH] D150492: [AST] Initialized local counter

vitalybuka created this revision. Herald added a project: All. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I assume it's optional and ReadAST does not have to set the counter on success. Repository: rG LLVM Github Monorep

[PATCH] D148654: Modify BoundsSan to improve debuggability

oskarwirga added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/BoundsChecking.cpp:189 auto GetTrapBB = [&TrapBB](BuilderTy &IRB) { -if (TrapBB && SingleTrapBB) - return TrapBB; - -Function *Fn = IRB.GetInsertBlock()->getParent(); -// FIXME:

[PATCH] D148654: Modify BoundsSan to improve debuggability

smeenai added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/BoundsChecking.cpp:189 auto GetTrapBB = [&TrapBB](BuilderTy &IRB) { -if (TrapBB && SingleTrapBB) - return TrapBB; - -Function *Fn = IRB.GetInsertBlock()->getParent(); -// FIXME: Thi

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

hiraditya updated this revision to Diff 521826. hiraditya added a comment. Addressed comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150490/new/ https://reviews.llvm.org/D150490 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/frame-pointer-elim.c clang/test

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

enh added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:424 + if (Triple.isAndroid()) { +// AArch64 has frame pointers enabled for non-leaf functions. +switch (Triple.getArch()) { (where? is it simpler to just add arm64 to the switch

[clang] 6adb9a0 - [AMDGPU] Emit predefined macro `__AMDGCN_CUMODE__`

Author: Yaxun (Sam) Liu Date: 2023-05-12T18:50:52-04:00 New Revision: 6adb9a0602bcd75acd383e13c253e471edc9b189 URL: https://github.com/llvm/llvm-project/commit/6adb9a0602bcd75acd383e13c253e471edc9b189 DIFF: https://github.com/llvm/llvm-project/commit/6adb9a0602bcd75acd383e13c253e471edc9b189.dif

[PATCH] D145343: [AMDGPU] Emit predefined macro `__AMDGCN_CUMODE__`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6adb9a0602bc: [AMDGPU] Emit predefined macro `__AMDGCN_CUMODE__` (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github M

[PATCH] D150403: [clang-format] Adjust braced list detection (try 2)

galenelias updated this revision to Diff 521828. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150403/new/ https://reviews.llvm.org/D150403 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.cpp clang/unittests/Format/TokenAnnotatorTest.cpp Index: cl

[PATCH] D150403: [clang-format] Adjust braced list detection (try 2)

galenelias added a comment. @HazardyKnusperkeks, thanks for the feedback. I added the TokenAnnotatorTests from @sstwcw's review. I also updated the design to use a single stack instead of the two parallel stacks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150403/new/ https://revi

[PATCH] D150494: [clang][modules] NFC: Only sort interesting identifiers

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In 9c254184 `ASTWriter`

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

hiraditya added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:424 + if (Triple.isAndroid()) { +// AArch64 has frame pointers enabled for non-leaf functions. +switch (Triple.getArch()) { enh wrote: > (where? is it simpler to just add

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

hiraditya updated this revision to Diff 521833. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150490/new/ https://reviews.llvm.org/D150490 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/frame-pointer-elim.c clang/test/Driver/frame-pointer.c Index: clang/test/Drive

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

hiraditya added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:424 + if (Triple.isAndroid()) { +// AArch64 has frame pointers enabled for non-leaf functions. +switch (Triple.getArch()) { hiraditya wrote: > enh wrote: > > (where? is it

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

hiraditya updated this revision to Diff 521834. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150490/new/ https://reviews.llvm.org/D150490 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/frame-pointer-elim.c clang/test/Driver/frame-pointer.c Index: clang/test/Drive

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

hiraditya updated this revision to Diff 521835. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150490/new/ https://reviews.llvm.org/D150490 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/frame-pointer-elim.c clang/test/Driver/frame-pointer.c Index: clang/test/Drive

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

craig.topper added a comment. Is there more context on why Android enables the frame pointer? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150490/new/ https://reviews.llvm.org/D150490 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

craig.topper added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:530 + Triple.isAArch64() || Triple.isPS() || Triple.isVE() || + (Triple.isAndroid() && (Triple.getArch() == llvm::Triple::riscv64))); if (NoOmitFP || must

[PATCH] D150499: [AST] Initialized data after TypeSourceInfo

vitalybuka created this revision. Herald added a project: All. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There is no initialization of the data between allocation and first getBeginLoc call. llvm-project/clang/lib/AST/ASTC

[PATCH] D150499: [AST] Initialized data after TypeSourceInfo

vitalybuka updated this revision to Diff 521847. vitalybuka added a comment. use 0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150499/new/ https://reviews.llvm.org/D150499 Files: clang/include/clang/AST/Type.h clang/include/clang/AST/TypeLoc

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

enh accepted this revision. enh added a comment. This revision is now accepted and ready to land. (lgtm with craig.topper's suggested simplification.) Comment at: clang/lib/Driver/ToolChains/Clang.cpp:530 + Triple.isAArch64() || Triple.isPS() || Triple.isVE()

[PATCH] D150452: [clang-format] Recognize nested blocks

sstwcw abandoned this revision. sstwcw added a comment. I like D150403 better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150452/new/ https://reviews.llvm.org/D150452 __

[PATCH] D150450: Add C++26 compile flags.

h-vetinari added inline comments. Comment at: clang/include/clang/Basic/LangStandard.h:128 + + // hasDigraphs - Language supports digraphs. bool hasDigraphs() const { return Flags & Digraphs; } Spuriously removed slash Comment at: clang/www

[PATCH] D150403: [clang-format] Adjust braced list detection (try 2)

sstwcw added a comment. I would suggest adding a link to the revision on the issue thread for your future bug fixes. This people like me don't try to fix what others have fixed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150403/new/ https://reviews.llvm.org/D150403 ___

[clang-tools-extra] 81e149a - Replace None with std::nullopt in comments (NFC)

Author: Kazu Hirata Date: 2023-05-12T18:33:26-07:00 New Revision: 81e149aab9b3676b16728e883e2f21ee938cff93 URL: https://github.com/llvm/llvm-project/commit/81e149aab9b3676b16728e883e2f21ee938cff93 DIFF: https://github.com/llvm/llvm-project/commit/81e149aab9b3676b16728e883e2f21ee938cff93.diff L

[PATCH] D150403: [clang-format] Adjust braced list detection (try 2)

sstwcw added a comment. > To this end, I am tracking the previous token type in a stack parallel > to LBraceStack to help scope this particular case. Maybe keep the description up to date with the code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150403/new/ https://reviews.llvm.org/

[PATCH] D150504: [AST] Construct Capture objects before use

vitalybuka created this revision. Herald added a project: All. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Msan reports https://reviews.llvm.org/P8308 So the reason is if PointerIntPair is not properly constructed, setPointer

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

awson added a comment. Now, this #include #include auto drop1(const std::vector& s){ return s | std::views::drop(1); } when compiled against gcc's-13.1 libstdc++ spits: boro.cpp:5:11: error: invalid operands to binary expression ('const std::vector' and '_Partial<_Drop,

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:530 + Triple.isAArch64() || Triple.isPS() || Triple.isVE() || + (Triple.isAndroid() && (Triple.getArch() == llvm::Triple::riscv64))); if (NoOmitFP || mustUseNo

[PATCH] D150450: Add C++26 compile flags.

shafik added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6649 .Case("c++20", "-std=c++20") // TODO add c++23 when MSVC supports it. + .Case("c++latest", "-std=c++26") --

[clang] 0bbf3dd - [Clang][LoongArch] Add GPR alias handling without `$` prefix

Author: Weining Lu Date: 2023-05-13T12:08:59+08:00 New Revision: 0bbf3ddf5fea86e0eb0726142827e175aadaf53b URL: https://github.com/llvm/llvm-project/commit/0bbf3ddf5fea86e0eb0726142827e175aadaf53b DIFF: https://github.com/llvm/llvm-project/commit/0bbf3ddf5fea86e0eb0726142827e175aadaf53b.diff LO

[PATCH] D136436: [Clang][LoongArch] Add GPR alias handling without `$` prefix

This revision was automatically updated to reflect the committed changes. Closed by commit rG0bbf3ddf5fea: [Clang][LoongArch] Add GPR alias handling without `$` prefix (authored by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136436/new

[clang] 2db0812 - [clang] Fix typos in documentation

Author: Kazu Hirata Date: 2023-05-12T23:19:17-07:00 New Revision: 2db081288292f555dd556e066be0c1c7b9548da8 URL: https://github.com/llvm/llvm-project/commit/2db081288292f555dd556e066be0c1c7b9548da8 DIFF: https://github.com/llvm/llvm-project/commit/2db081288292f555dd556e066be0c1c7b9548da8.diff L

[clang-tools-extra] 7f28137 - [clang-tidy] Modernize RangeDescriptor (NFC)

Author: Kazu Hirata Date: 2023-05-12T23:19:19-07:00 New Revision: 7f28137b5d2cb0deda4c6171665ef15accfab6ab URL: https://github.com/llvm/llvm-project/commit/7f28137b5d2cb0deda4c6171665ef15accfab6ab DIFF: https://github.com/llvm/llvm-project/commit/7f28137b5d2cb0deda4c6171665ef15accfab6ab.diff L

[PATCH] D150506: Migrate {starts,ends}with_insensitive to {starts,ends}_with_insensitive (NFC)

kazu created this revision. Herald added subscribers: cfe-commits, PiotrZSL, luke, steakhal, carlosgalvezp, frasercrmck, martong, luismarques, apazos, sameer.abuasal, s.egerton, Jim, kadircet, jocewei, PkmX, arphaman, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, nios

<    1   2