[PATCH] D149119: [CMake] Use LLVM own tools in extract_symbols.py

jhenderson added a comment. In D149119#4331207 , @ikudrin wrote: > In D149119#4329274 , @tmatheson > wrote: > >> LGTM, thank you for doing this. Please give it a couple of days in case >> others have comments. >

[clang] 99f933b - [test] Clean up Driver/check-time-trace*

Author: Fangrui Song Date: 2023-05-10T00:19:46-07:00 New Revision: 99f933b6346b0afcafa3c1ea0972136d7b441a86 URL: https://github.com/llvm/llvm-project/commit/99f933b6346b0afcafa3c1ea0972136d7b441a86 DIFF: https://github.com/llvm/llvm-project/commit/99f933b6346b0afcafa3c1ea0972136d7b441a86.diff

[PATCH] D150253: [RISCV] Add Zvfhmin extension.

jacquesguan created this revision. jacquesguan added reviewers: craig.topper, asb, luismarques, frasercrmck. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edwa

[PATCH] D150254: [tidy] Fix possible use-after-free in IdentifierNamingCheck

kadircet created this revision. kadircet added reviewers: hokein, PiotrZSL. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe

[PATCH] D150254: [tidy] Fix possible use-after-free in IdentifierNamingCheck

kadircet added a comment. see https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clang-tidy/ClangTidy.cpp#L638 for such a pattern, clangd also initializes checks with a similar approach. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D149986: AMDGPU: Force sc0 and sc1 on stores for gfx940 and gfx941

jmmartinez added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIMemoryLegalizer.cpp:524 + SIAtomicAddrSpace::NONE) + return enableSC0Bit(MI) | enableSC1Bit(MI); +return false; NIT: Is the use of the bitwise or " | " intended? I'd use the l

[PATCH] D148505: Allow `__attribute__((warn_unused))` on individual constructors

sberg added a comment. In D148505#4302702 , @aaron.ballman wrote: > Thank you for poking on this! FWIW, I don't know that there's a way to > cross-post to Discourse (but if I'm wrong and there is, I'd love to know > how!). Ping, any further input from

[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

tupos added a comment. Hi, could you please provide a code review again? Thanks. With best regards, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140275/new/ https://reviews.llvm.org/D140275 ___ cfe-c

[clang] f109b10 - [NFC] [C++20] [Modules] Refactor Sema::isModuleUnitOfCurrentTU into

Author: Chuanqi Xu Date: 2023-05-10T16:01:27+08:00 New Revision: f109b1016801e2b0dbee278f3c517057c0b1d441 URL: https://github.com/llvm/llvm-project/commit/f109b1016801e2b0dbee278f3c517057c0b1d441 DIFF: https://github.com/llvm/llvm-project/commit/f109b1016801e2b0dbee278f3c517057c0b1d441.diff LO

[PATCH] D150253: [RISCV] Add Zvfhmin extension.

craig.topper added a comment. Don’t you need to make f16 vectors legal types in the backend? And you need to disable intrinsics for instructions that aren’t supported by Zfhmin. Like f16 vector fadd And you also need to make the backend only allow f16 vector operations that are supported with

[PATCH] D149495: [RISCV] Add support for V extension in SiFive7

pcwang-thead accepted this revision. pcwang-thead added a comment. LGTM. Though I don't like the way that we need to loop `MxList` again when defining scheduling model, I think this can be a good practice to define RVV scheduling model in current TableGen's grammar. Comment a

[PATCH] D148700: [clang] Add support for “regular” keyword attributes

rsandifo-arm added a subscriber: sdesmalen. rsandifo-arm added a comment. Thanks for the review. Comment at: clang/include/clang/Basic/Attr.td:2427-2430 +def ArmStreaming : TypeAttr, TargetSpecificAttr { + let Spellings = [RegularKeyword<"__arm_streaming">]; + let Documentati

[PATCH] D150254: [tidy] Fix possible use-after-free in IdentifierNamingCheck

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. The fix looks good. We also have a `CheckName` field in the base class `ClangTidyCheck`, however that's field is private, we can't not access, we could consider make it protected (I think tha

[PATCH] D150254: [tidy] Fix possible use-after-free in IdentifierNamingCheck

njames93 added a comment. In D150254#4331640 , @kadircet wrote: > see > https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clang-tidy/ClangTidy.cpp#L638 > for such a pattern, clangd also initializes checks with a similar approach. In this

[PATCH] D150254: [tidy] Fix possible use-after-free in IdentifierNamingCheck

njames93 added a comment. In D150254#4331734 , @hokein wrote: > The fix looks good. > > We also have a `CheckName` field in the base class `ClangTidyCheck`, however > that's field is private, we can't not access, we could consider make it > protected (I

[PATCH] D150257: [clangd] Initialize clang-tidy modules only once

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: carlosgalvezp, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D150126: [clang-tidy][WIP] Set traversal scope to prevent analysis in headers

njames93 created this revision. njames93 added reviewers: carlosgalvezp, PiotrZSL. Herald added a subscriber: xazax.hun. Herald added a project: All. njames93 updated this revision to Diff 520620. njames93 added a comment. njames93 updated this revision to Diff 520918. njames93 retitled this revisi

[PATCH] D150257: [clangd] Initialize clang-tidy modules only once

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:478 trace::Span Tracer("ClangTidyInit"); -tidy::ClangTidyCheckFactories CTFactories; -for (const aut

[PATCH] D150254: [tidy] Fix possible use-after-free in IdentifierNamingCheck

kadircet updated this revision to Diff 520936. kadircet added a comment. - Expose getID to tidy-checks and use it instead of storing checkname Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150254/new/ https://reviews.llvm.org/D150254 Files: clan

[PATCH] D150258: [clang][parser] Fix namespace dropping after malformed declarations

alejandro-alvarez-sonarsource created this revision. alejandro-alvarez-sonarsource added a reviewer: aaron.ballman. alejandro-alvarez-sonarsource added a project: clang. Herald added a subscriber: kadircet. Herald added a project: All. alejandro-alvarez-sonarsource requested review of this revision

[clang] b6c7177 - [C++20] [Modules] Don't generate unused variables in other module units

Author: Chuanqi Xu Date: 2023-05-10T17:41:58+08:00 New Revision: b6c7177145bc439c712208bfbe041db212c5262d URL: https://github.com/llvm/llvm-project/commit/b6c7177145bc439c712208bfbe041db212c5262d DIFF: https://github.com/llvm/llvm-project/commit/b6c7177145bc439c712208bfbe041db212c5262d.diff LO

[clang] 48bbc64 - [NFC] [C++20] [Modules] Code cleanups when checking modules in ADL

Author: Chuanqi Xu Date: 2023-05-10T17:53:47+08:00 New Revision: 48bbc64a8ff5e3777a76a02cffd94b3786b93203 URL: https://github.com/llvm/llvm-project/commit/48bbc64a8ff5e3777a76a02cffd94b3786b93203 DIFF: https://github.com/llvm/llvm-project/commit/48bbc64a8ff5e3777a76a02cffd94b3786b93203.diff LO

[PATCH] D150257: [clangd] Initialize clang-tidy modules only once

kadircet updated this revision to Diff 520948. kadircet marked 4 inline comments as done. kadircet added a comment. - Move ReplayPreambleTests to its own file and move registry to global scope. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150257/ne

[PATCH] D150254: [tidy] Fix possible use-after-free in IdentifierNamingCheck

kadircet added a comment. In D150254#4331738 , @njames93 wrote: > In D150254#4331640 , @kadircet > wrote: > >> see >> https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clang-tidy/ClangTidy.cpp#L63

[clang-tools-extra] 62a090f - [clangd] Initialize clang-tidy modules only once

Author: Kadir Cetinkaya Date: 2023-05-10T12:32:33+02:00 New Revision: 62a090f958ce02a8035e3c9424a05dbfe25859e1 URL: https://github.com/llvm/llvm-project/commit/62a090f958ce02a8035e3c9424a05dbfe25859e1 DIFF: https://github.com/llvm/llvm-project/commit/62a090f958ce02a8035e3c9424a05dbfe25859e1.dif

[PATCH] D150257: [clangd] Initialize clang-tidy modules only once

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG62a090f958ce: [clangd] Initialize clang-tidy modules only once (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D150192: Allow clang to emit inrange metadata when generating code for array subscripts

shiva0217 added a comment. In D150192#4330199 , @efriedma wrote: > From what I recall, "inrange" is actually more restrictive than the normal > C/C++ array indexing rules. Specifically, the bits regarding comparisons. > "inrange" was designed to allow

[clang-tools-extra] 2b240cc - [tidy] Expose getID to tidy checks

Author: Kadir Cetinkaya Date: 2023-05-10T12:50:25+02:00 New Revision: 2b240cc377b5e4f41c05d68c9a513f7d08ab69c8 URL: https://github.com/llvm/llvm-project/commit/2b240cc377b5e4f41c05d68c9a513f7d08ab69c8 DIFF: https://github.com/llvm/llvm-project/commit/2b240cc377b5e4f41c05d68c9a513f7d08ab69c8.dif

[PATCH] D150254: [tidy] Fix possible use-after-free in IdentifierNamingCheck

This revision was automatically updated to reflect the committed changes. Closed by commit rG2b240cc377b5: [tidy] Expose getID to tidy checks (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150254/new/ https://reviews.llvm.org/

[PATCH] D150209: [clang][Interp] Add more shift error checking

tbaeder updated this revision to Diff 520954. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150209/new/ https://reviews.llvm.org/D150209 Files: clang/lib/AST/Interp/Integral.h clang/lib/AST/Interp/Interp.h clang/test/AST/Interp/shifts.cpp Index: clang/test/AST/Interp/shifts.cpp =

[clang] d526e2e - Add -no-canonical-prefixes to test that matches the binary name

Author: Benjamin Kramer Date: 2023-05-10T13:17:35+02:00 New Revision: d526e2ec957fc7bc31d7be3670cd1673c2b4389b URL: https://github.com/llvm/llvm-project/commit/d526e2ec957fc7bc31d7be3670cd1673c2b4389b DIFF: https://github.com/llvm/llvm-project/commit/d526e2ec957fc7bc31d7be3670cd1673c2b4389b.dif

[PATCH] D149997: [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl

thakis added a comment. This broke check-clang on windows: http://45.33.8.238/win/78359/step_7.txt (The Driver/split-debug.c failure is something else and since fixed, but the other two tests are due to this change.) Please take a look and revert for now if it takes a while to fix. Repository

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

erichkeane added a comment. One of the buildbot failures is the test you modified (\dr1xx.c), so I suspect it is related. I THINK this needs a notice on the 'breaking changes' mailing list as well. For release notes, I'd put it in the 'Potentially Breaking Changes' section. CHANGES SINCE LAST

[clang] 34b422b - clang-format: [JS] support import/export type

Author: Jan Kuhle Date: 2023-05-10T15:27:03+02:00 New Revision: 34b422bafbd934ee3c644fd7a8f0b6803976c818 URL: https://github.com/llvm/llvm-project/commit/34b422bafbd934ee3c644fd7a8f0b6803976c818 DIFF: https://github.com/llvm/llvm-project/commit/34b422bafbd934ee3c644fd7a8f0b6803976c818.diff LOG

[PATCH] D150116: clang-format: [JS] support import/export type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG34b422bafbd9: clang-format: [JS] support import/export type (authored by jankuehle, committed by krasimir). Repository: rG LLVM Github Monorepo C

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

erichkeane added a comment. In D150226#4332024 , @erichkeane wrote: > One of the buildbot failures is the test you modified (\dr1xx.c), so I > suspect it is related. > > I THINK this needs a notice on the 'breaking changes' mailing list as well. > > For

[PATCH] D150221: Add option -fkeep-static-variables to emit all static variables

erichkeane added a subscriber: aaron.ballman. erichkeane added a comment. In D150221#4330534 , @hubert.reinterpretcast wrote: > In D150221#4330504 , @MaskRay wrote: > >> Can you give a more compelling reason that

[PATCH] D149612: [Sema] avoid merge error type

erichkeane added a comment. @aaron.ballman : Can you comment, particularly on the 'x2' and 'x3' examples here? I think our hackery here to get the AST back in a reasonable position here is unfortunate, and leads to some pretty awkward errors. I'm not sure what else we could do? We can't make

[PATCH] D149562: [clang-format] Stop comment disrupting indentation of Verilog ports

sstwcw added a comment. > IMO a trailing comment (empty or not) belongs to the code before it. There is only a parenthesis before it. It doesn't usually need a comment. It is like in 5a61139. One doesn't tend to comment a single brace. > A comment about the code below it should start on a ne

[clang] ddfb974 - Add support of the next Ubuntu (Ubuntu 23.10 - Mantic Minotaur)

Author: Sylvestre Ledru Date: 2023-05-10T16:31:53+02:00 New Revision: ddfb974d0fca62e3eaeb98b79b5e29738c9082d2 URL: https://github.com/llvm/llvm-project/commit/ddfb974d0fca62e3eaeb98b79b5e29738c9082d2 DIFF: https://github.com/llvm/llvm-project/commit/ddfb974d0fca62e3eaeb98b79b5e29738c9082d2.dif

[clang] 56bac6c - Revert "[clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl"

Author: Nico Weber Date: 2023-05-10T16:49:18+02:00 New Revision: 56bac6c87a2d9046dbac36aae4910b4b90edf643 URL: https://github.com/llvm/llvm-project/commit/56bac6c87a2d9046dbac36aae4910b4b90edf643 DIFF: https://github.com/llvm/llvm-project/commit/56bac6c87a2d9046dbac36aae4910b4b90edf643.diff LO

[PATCH] D149997: [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl

thakis added a comment. Fails with cmake too: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8781510258907322449/+/u/package_clang/stdout?format=raw Reverted in 56bac6c87a2d9046dbac36aae4910b4b90edf643 for

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

sdesmalen added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:726 -if (Feature == "+sme") { - HasSME = true; Why did you remove this? Comment at: clang/test/CodeGen/aarch64-sme-intrinsics/acle_sme_ld1.c:16 +// +__a

[PATCH] D150221: Add option -fkeep-static-variables to emit all static variables

hubert.reinterpretcast added a comment. In D150221#4332142 , @erichkeane wrote: >> This is intended to prevent "excessive transformation" to enable migration >> of existing applications (using a non-Clang compiler) where users further >> manipulate the

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 520998. junaire added a comment. Export symbols in Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h c

[PATCH] D149158: [clang][analyzer] Cleanup tests of StdCLibraryFunctionsChecker (NFC)

balazske added inline comments. Comment at: clang/test/Analysis/Inputs/std-c-library-functions.h:1-2 +typedef typeof(sizeof(int)) size_t; +typedef signed long ssize_t; +typedef struct { steakhal wrote: > balazske wrote: > > steakhal wrote: > > > `ssize_t`'s size

[clang] 1fc7021 - AMDGPU: Add basic gfx941 target

Author: Konstantin Zhuravlyov Date: 2023-05-10T11:51:06-04:00 New Revision: 1fc70210a6a585bad941f64bd3fca7909eeafdda URL: https://github.com/llvm/llvm-project/commit/1fc70210a6a585bad941f64bd3fca7909eeafdda DIFF: https://github.com/llvm/llvm-project/commit/1fc70210a6a585bad941f64bd3fca7909eeafd

[clang] 9d05727 - AMDGPU: Add basic gfx942 target

Author: Konstantin Zhuravlyov Date: 2023-05-10T11:51:06-04:00 New Revision: 9d0572797233857397f3fdc35fffcfb490354f56 URL: https://github.com/llvm/llvm-project/commit/9d0572797233857397f3fdc35fffcfb490354f56 DIFF: https://github.com/llvm/llvm-project/commit/9d0572797233857397f3fdc35fffcfb490354f

[PATCH] D149982: AMDGPU: Add basic gfx941 target

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1fc70210a6a5: AMDGPU: Add basic gfx941 target (authored by kzhuravl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D149983: AMDGPU: Add basic gfx942 target

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9d0572797233: AMDGPU: Add basic gfx942 target (authored by kzhuravl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

RitanyaB updated this revision to Diff 521014. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146418/new/ https://reviews.llvm.org/D146418 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaDecl.cpp clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/declare_target_messages.cpp

[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

RitanyaB added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:23094-23095 +public: + SmallVector DeclVector; + Decl *TargetDecl; + void VisitDeclRefExpr(const DeclRefExpr *Node) { ABataev wrote: > Why public? As the data members are accessed from o

[PATCH] D149986: AMDGPU: Force sc0 and sc1 on stores for gfx940 and gfx941

kzhuravl marked an inline comment as done. kzhuravl added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIMemoryLegalizer.cpp:524 + SIAtomicAddrSpace::NONE) + return enableSC0Bit(MI) | enableSC1Bit(MI); +return false; jmmartinez wrote: > NI

[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:23106-23107 + it != Ex->child_end(); ++it) { + if (isa(*it)) +VisitExpr(dyn_cast(*it)); + if (isa(*it)) Why just a regular Visit does not work here? Plus, isa + dyn

[PATCH] D149997: [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl

mstorsjo added a comment. In D149997#4331937 , @thakis wrote: > This broke check-clang on windows: http://45.33.8.238/win/78359/step_7.txt > > (The Driver/split-debug.c failure is something else and since fixed, but the > other two tests are due to this

[PATCH] D150192: Allow clang to emit inrange metadata when generating code for array subscripts

efriedma added a comment. See D115274 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150192/new/ https://reviews.llvm.org/D150192 ___ cfe-commits mailing list cfe-commit

[clang] ce5ad23 - libclang: declare blocks interfaces always

Author: Saleem Abdulrasool Date: 2023-05-10T10:00:25-07:00 New Revision: ce5ad23ac29bb70427dd22d9ee480d22e0aa6cf1 URL: https://github.com/llvm/llvm-project/commit/ce5ad23ac29bb70427dd22d9ee480d22e0aa6cf1 DIFF: https://github.com/llvm/llvm-project/commit/ce5ad23ac29bb70427dd22d9ee480d22e0aa6cf1.

[PATCH] D149495: [RISCV] Add support for V extension in SiFive7

michaelmaitland updated this revision to Diff 521024. michaelmaitland marked 2 inline comments as done. michaelmaitland added a comment. Use defvar in subroutines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149495/new/ https://reviews.llvm.org/D

[PATCH] D149495: [RISCV] Add support for V extension in SiFive7

michaelmaitland added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVScheduleV.td:41 +// Helper function to get the largest LMUL from MxList +// Precondition: MxList is sorted in ascending LMUL order. pcwang-thead wrote: > So, are we going to discard `

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names and introduce Bfloat16 arithmetic type.

tahonermann requested changes to this revision. tahonermann added a comment. This revision now requires changes to proceed. I reviewed about a third of this, but then stopped due to the `__bf16` vs `std::bfloat16_t` naming issues. I think the existing names that use "bfloat16" to support the `__

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

iana added inline comments. Comment at: clang/test/Modules/implicit-module-header-maps.cpp:52 +//header and trip a `#error`, or +// 2) header maps aren't usesd, as the header name doesn't exist and relies on +//the header map to remap it to the real header. --

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

iana added a comment. I wonder if clang should have better module interaction with the header maps produced by Xcode, or if Xcode should produce better header maps to work with clang. Or are you having problems with header maps outside of Xcode? Repository: rG LLVM Github Monorepo CHANGES S

[clang] d747f82 - libclang: add missing `struct` in the declaration

Author: Saleem Abdulrasool Date: 2023-05-10T10:31:53-07:00 New Revision: d747f8277b386059a74dee062295aa8d864398fc URL: https://github.com/llvm/llvm-project/commit/d747f8277b386059a74dee062295aa8d864398fc DIFF: https://github.com/llvm/llvm-project/commit/d747f8277b386059a74dee062295aa8d864398fc.

[PATCH] D149495: [RISCV] Add support for V extension in SiFive7

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a855819a87f: [RISCV] Add support for V extenstion in SiFive7 (authored by michaelmaitland). Changed prior to commit: https://reviews.llvm.org/D14

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names and introduce Bfloat16 arithmetic type.

codemzs marked an inline comment as done. codemzs added a comment. In D149573#4332549 , @tahonermann wrote: > I reviewed about a third of this, but then stopped due to the `__bf16` vs > `std::bfloat16_t` naming issues. I think the existing names that us

[PATCH] D150278: [Headers][doc] Add "shift" intrinsic descriptions to avx2intrin.h

probinson created this revision. probinson added reviewers: pengfei, RKSimon, goldstein.w.n, craig.topper. Herald added a project: All. probinson requested review of this revision. https://reviews.llvm.org/D150278 Files: clang/lib/Headers/avx2intrin.h Index: clang/lib/Headers/avx2intrin.h

[clang] 63eb04a - [clang][modules] Avoid unnecessary writes of .timestamp files

Author: Jan Svoboda Date: 2023-05-10T10:41:33-07:00 New Revision: 63eb04a3683996db26dbf1534682c5696d93b080 URL: https://github.com/llvm/llvm-project/commit/63eb04a3683996db26dbf1534682c5696d93b080 DIFF: https://github.com/llvm/llvm-project/commit/63eb04a3683996db26dbf1534682c5696d93b080.diff L

[PATCH] D149802: [clang][modules] Avoid unnecessary writes of .timestamp files

This revision was automatically updated to reflect the committed changes. Closed by commit rG63eb04a36839: [clang][modules] Avoid unnecessary writes of .timestamp files (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149802/

[PATCH] D150278: [Headers][doc] Add "shift" intrinsic descriptions to avx2intrin.h

goldstein.w.n accepted this revision. goldstein.w.n added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150278/new/ https://reviews.llvm.org/D150278 ___ cfe-commits mailing lis

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

rsundahl added a comment. In D143675#4310903 , @eugenis wrote: > I'm fine with it in general. Is asan_abi.cpp meant as a temporary stub? It's > not even link anywhere in the current version. Right, we should be using it... We will add a test that compil

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

rsundahl added a comment. In D143675#4330599 , @thetruestblue wrote: > Small insignificant note from me: When this lands, please be sure to add me > as co-author. > https://github.blog/2018-01-29-commit-together-with-co-authors/ I've not seen this befo

[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

dgoldman added a comment. In D140275#4203456 , @tupos wrote: > Could you please also advice me what else need to be done for the ObjC, since > there were many years since I wrote ObjC last time I'm not sure what else > need to be done there. > > Thanks.

[clang] 878e590 - Reland [clang] Make predefined expressions string literals under -fms-extensions

Author: Arthur Eubanks Date: 2023-05-10T10:54:58-07:00 New Revision: 878e590503dff0d9097e91c2bec4409f14503b82 URL: https://github.com/llvm/llvm-project/commit/878e590503dff0d9097e91c2bec4409f14503b82 DIFF: https://github.com/llvm/llvm-project/commit/878e590503dff0d9097e91c2bec4409f14503b82.diff

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

This revision was automatically updated to reflect the committed changes. Closed by commit rG878e590503df: Reland [clang] Make predefined expressions string literals under -fms-extensions (authored by aeubanks). Changed prior to commit: https://reviews.llvm.org/D146764?vs=520204&id=521039#toc

[PATCH] D147266: [AArch64] Add IR intrinsics for vbsl* C intrinsics

pranavk updated this revision to Diff 521040. pranavk edited the summary of this revision. pranavk added a comment. Change shouldSinkOperand to allow backend to generate bitselect instructions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147266/new

[PATCH] D147266: [AArch64] Add IR intrinsics for vbsl* C intrinsics

pranavk planned changes to this revision. pranavk added a comment. I agree. I changed the implementation to not introduce the intrinsic. I will need another change in InstCombine to handle case #1 mentioned on github bug report. I will have separate patch for it changing InstCombine. Thanks Re

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

MaskRay created this revision. MaskRay added reviewers: clang, jamieschmeiser, Whitney, Maetveis, dblaikie, scott.linder. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Inspired by D133662

[PATCH] D150285: Fix CRTP partial specialization instantiation crash.

erichkeane created this revision. erichkeane added reviewers: alexander-shaposhnikov, clang-language-wg. Herald added a project: All. erichkeane requested review of this revision. Fixes #60778. When instantiating the body of a class template specialization that was instantiated from a partial spe

[PATCH] D150285: Fix CRTP partial specialization instantiation crash.

alexander-shaposhnikov accepted this revision. alexander-shaposhnikov added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150285/new/ https://reviews.llvm.org/D150285 ___ cfe-comm

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo added a comment. @int3 @thakis, et al - friendly 🔔 :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144999/new/ https://reviews.llvm.org/D144999 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

Manna updated this revision to Diff 521073. Manna marked 2 inline comments as done. Manna added a comment. I have updated patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149718/new/ https://reviews.llvm.org/D149718 Files: clang/include/clang/Analysis/BodyFarm.h clang/include/cl

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

kiwixz added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146520/new/ https://reviews.llvm.org/D146520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

Manna added inline comments. Comment at: clang/include/clang/Sema/Sema.h:1786 SemaDiagnosticBuilder(SemaDiagnosticBuilder &&D); +SemaDiagnosticBuilder &operator=(SemaDiagnosticBuilder &&D); SemaDiagnosticBuilder(const SemaDiagnosticBuilder &) = default;

[PATCH] D150291: [Clang] Rename internal type identifier(s) for `__bf16` to `BF16Ty`

codemzs created this revision. codemzs added reviewers: tahonermann, erichkeane, stuij. Herald added subscribers: mattd, gchakrabarti, asavonic, ctetreau, kerbowa, arphaman, kristof.beyls, jvesely. Herald added a project: All. codemzs requested review of this revision. Herald added subscribers: ll

[PATCH] D150292: [clang][modules] Serialize `Module::DefinitionLoc`

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a prep patch fo

[PATCH] D150209: [clang][Interp] Add more shift error checking

tbaeder updated this revision to Diff 521078. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150209/new/ https://reviews.llvm.org/D150209 Files: clang/lib/AST/Interp/Integral.h clang/lib/AST/Interp/Interp.h clang/test/AST/Interp/shifts.cpp Index: clang/test/AST/Interp/shifts.cpp =

[PATCH] D150209: [clang][Interp] Add more shift error checking

tbaeder updated this revision to Diff 521082. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150209/new/ https://reviews.llvm.org/D150209 Files: clang/lib/AST/Interp/Integral.h clang/lib/AST/Interp/Interp.h clang/test/AST/Interp/shifts.cpp Index: clang/test/AST/Interp/shifts.cpp =

[PATCH] D150278: [Headers][doc] Add "shift" intrinsic descriptions to avx2intrin.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG642bd1123d05: [Headers][doc] Add "shift" intrinsic descriptions to avx2intrin.h (authored by probinson). Herald added a project: clang. Repository:

[clang] 642bd11 - [Headers][doc] Add "shift" intrinsic descriptions to avx2intrin.h

Author: Paul Robinson Date: 2023-05-10T13:14:41-07:00 New Revision: 642bd1123d05e594cd0ef1527516f421ac07c5a6 URL: https://github.com/llvm/llvm-project/commit/642bd1123d05e594cd0ef1527516f421ac07c5a6 DIFF: https://github.com/llvm/llvm-project/commit/642bd1123d05e594cd0ef1527516f421ac07c5a6.diff

[PATCH] D150295: [MemProf] Update hot/cold information after importing

tejohnson created this revision. tejohnson added a reviewer: davidxl. Herald added subscribers: ormris, steven_wu, hiraditya. Herald added a project: All. tejohnson requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. The support added by D

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

Manna updated this revision to Diff 521089. Manna added a comment. Fix Coverity complain about shift overflow issue CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150140/new/ https://reviews.llvm.org/D150140 Files: clang/utils/TableGen/SveEmitter.cpp Index: clang/utils/TableGen/SveE

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

Manna marked an inline comment as done. Manna added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:302 unsigned Shift = llvm::countr_zero(Mask); + assert(Shift >= 64 && "Shift is out of encodable range"); return (V << Shift) & Mask; --

[PATCH] D150209: [clang][Interp] Add more shift error checking

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/AST/Interp/Interp.h:141-142 + + // C++2a [expr.shift]p2: E1 << E2 is the unique value congruent to + // E1 x 2^E2 module 2^N. +

[PATCH] D150295: [MemProf] Update hot/cold information after importing

davidxl accepted this revision. davidxl added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150295/new/ https://reviews.llvm.org/D150295 _

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam added a comment. In D146148#4330971 , @rjmccall wrote: > In D146148#4330611 , @zahiraam > wrote: > >> In D146148#4221651 , @rjmccall >> wrote: >> >>> In D146148

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

rjmccall added a comment. > Okay, so I did add that in TokenKinds.h. Isn't that the right place for it? > The same way it's done for the other builtins? And in TokenKinds.def I added > the lines for the interesting identifiers? What you're doing in `TokenKinds.{def,h}` seems fine. What I'm obj

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

ldionne accepted this revision as: libc++abi. ldionne added a comment. This revision is now accepted and ready to land. Code changes in libc++ and libc++abi LGTM. I am neutral on whether the diagnostic is worth adding, but don't consider libc++ and libc++abi as blockers for this patch. ==

[clang] 9e280c4 - [MemProf] Update hot/cold information after importing

Author: Teresa Johnson Date: 2023-05-10T14:58:35-07:00 New Revision: 9e280c47588bfaf008a5fb091cd47df92b9c4264 URL: https://github.com/llvm/llvm-project/commit/9e280c47588bfaf008a5fb091cd47df92b9c4264 DIFF: https://github.com/llvm/llvm-project/commit/9e280c47588bfaf008a5fb091cd47df92b9c4264.diff

[PATCH] D150295: [MemProf] Update hot/cold information after importing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9e280c47588b: [MemProf] Update hot/cold information after importing (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D147266: [AArch64] Add IR intrinsics for vbsl* C intrinsics

pranavk updated this revision to Diff 521114. pranavk added a comment. [AArch64][InstCombine] Bail out for bitselect instructions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147266/new/ https://reviews.llvm.org/D147266 Files: llvm/lib/Transfor

  1   2   >