[PATCH] D149437: [clangd] Emit ChangeAnnotation label and description for include-cleaner diagnostics.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:445 -Fix removeAllUnusedIncludes(llvm::ArrayRef UnusedIncludes) { +Fix removeAllUnusedIncludes(llvm::ArrayRef UnusedIncludes, +llvm::StringRef Code) { ---

[PATCH] D148944: [clang][Driver] Fix crash with unsupported architectures in MinGW and CrossWindows.

mstorsjo added inline comments. Comment at: clang/test/Driver/unsupported-target-arch.c:33 +// RUN: FileCheck --input-file=%t.err --check-prefix=CHECK-NOARCH-CROSSWINDOWS %s +// CHECK-NOARCH-CROSSWINDOWS: error: unknown target triple 'noarch-unknown-windows-itanium', please use

[PATCH] D142967: [clangd] Introduce source.organizeImports code action.

hokein added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1035 } + if (KindAllowed(CodeAction::SOURCE_ORGANIZE_IMPORT)) { +std::lock_guard Lock(FixItsMutex); kadircet wrote: > instead of doing this in here, what about introduc

[PATCH] D148822: [clang][BFloat] Avoid redefining bfloat16_t in arm_neon.h

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. I agree it makes sense to remove the typedef if they are also defined in `arm_bf16.h`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14882

[PATCH] D149637: [Clang] Correctly expand pack in binary subscript expression.

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When constructing an array expression where the index expression was a pack expansion, we would construct an ArraySubscrip

[PATCH] D148680: [RISCV] Split out part of riscv_vector.td to riscv_vector_common.td

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148680/new/ https://reviews.llvm.org/D148680 ___

[PATCH] D133863: [RISCV] Add MC support of RISCV zcmt Extension

VincentWu updated this revision to Diff 518653. VincentWu marked an inline comment as done. VincentWu added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133863/new/ https://reviews.llvm.org/D133863 Files: clang/test/

[clang-tools-extra] 1aa36da - [clang-tidy] Add check bugprone-multiple-new-in-one-expression.

Author: Balázs Kéri Date: 2023-05-02T10:59:07+02:00 New Revision: 1aa36da15369678d94add0f64809b11f95795efd URL: https://github.com/llvm/llvm-project/commit/1aa36da15369678d94add0f64809b11f95795efd DIFF: https://github.com/llvm/llvm-project/commit/1aa36da15369678d94add0f64809b11f95795efd.diff L

[PATCH] D138777: [clang-tidy] Add check bugprone-multiple-new-in-one-expression.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. balazske marked an inline comment as done. Closed by commit rG1aa36da15369: [clang-tidy] Add check bugprone-multiple-new-in-one-expression. (authored by balazske). Cha

[clang-tools-extra] 7b7a6b6 - Revert "[clang-tidy] Add check bugprone-multiple-new-in-one-expression."

Author: Balázs Kéri Date: 2023-05-02T11:23:31+02:00 New Revision: 7b7a6b641afdb9cae4ca1bb033ad65ee8177c9cb URL: https://github.com/llvm/llvm-project/commit/7b7a6b641afdb9cae4ca1bb033ad65ee8177c9cb DIFF: https://github.com/llvm/llvm-project/commit/7b7a6b641afdb9cae4ca1bb033ad65ee8177c9cb.diff L

[clang] 87ae746 - [clang-repl] Add a test coverage for nested out-of-line dtor disambiguation.

Author: Vassil Vassilev Date: 2023-05-02T09:39:48Z New Revision: 87ae74692456f5ef72dadff508af99371ddc1135 URL: https://github.com/llvm/llvm-project/commit/87ae74692456f5ef72dadff508af99371ddc1135 DIFF: https://github.com/llvm/llvm-project/commit/87ae74692456f5ef72dadff508af99371ddc1135.diff LO

[PATCH] D148425: [clang-repl] Correctly disambiguate dtor declarations from statements

v.g.vassilev marked an inline comment as done. v.g.vassilev added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:91 return true; - case tok::annot_cxxscope: // Check if this is a dtor. -if (NextToken().is(tok::tilde)) aaron.

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 518662. VincentWu marked 12 inline comments as done. VincentWu added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.org/D132819 Files: clang/test/

[PATCH] D149640: [clang][dataflow] Change PruneTriviallyFalseEdges for building CFG

kinu created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. kinu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It looks like keeping this false could end up with ext

[PATCH] D149640: [clang][dataflow] Change PruneTriviallyFalseEdges for building CFG

gribozavr2 added a comment. Is it testable? For example, can we show that we don't compute the program state for the program point "p" here: void f() { while (true) { } /*p*/ } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149640/n

[PATCH] D149641: [docs] Hide collaboration and include graphs in doxygen docs

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, shafik. Herald added a reviewer: bollu. Herald added subscribers: bviyer, Moerafaat, zero9178, bzcheeseman, ayermolo, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, J

[PATCH] D149643: Correctly limit formatted ranges when specifying qualifier alignment

cogilvie created this revision. cogilvie added reviewers: MyDeveloperDay, rymiel, HazardyKnusperkeks, owenpan. cogilvie added a project: clang-format. Herald added projects: All, clang. cogilvie requested review of this revision. The qualifier alignment fixer appeared to ignore any ranges specifie

[clang-tools-extra] 852bf52 - [clang-tidy] Add check bugprone-multiple-new-in-one-expression.

Author: Balázs Kéri Date: 2023-05-02T12:29:17+02:00 New Revision: 852bf52cc957dc9a14c425e9f22969338d84b178 URL: https://github.com/llvm/llvm-project/commit/852bf52cc957dc9a14c425e9f22969338d84b178 DIFF: https://github.com/llvm/llvm-project/commit/852bf52cc957dc9a14c425e9f22969338d84b178.diff L

[PATCH] D149640: [clang][dataflow] Change PruneTriviallyFalseEdges for building CFG

kinu updated this revision to Diff 518676. kinu added a comment. Add a while-true test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149640/new/ https://reviews.llvm.org/D149640 Files: clang/lib/Analysis/FlowSensitive/ControlFlowContext.cpp cl

[PATCH] D149640: [clang][dataflow] Change PruneTriviallyFalseEdges for building CFG

kinu added a comment. In D149640#4311889 , @gribozavr2 wrote: > Is it testable? For example, can we show that we don't compute the program > state for the program point "p" here: I added a simple test, how does it look? Repository: rG LLVM Github M

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak updated this revision to Diff 518677. skatrak edited the summary of this revision. skatrak added a comment. Herald added subscribers: bviyer, Moerafaat, zero9178, awarzynski, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo

[PATCH] D148822: [clang][BFloat] Avoid redefining bfloat16_t in arm_neon.h

simonbutcher accepted this revision. simonbutcher added a comment. > we definitely use -Wsystem-headers. Fair enough, that hadn't occurred to me. The change LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148822/new/ https://reviews.llvm.org/D

[PATCH] D149640: [clang][dataflow] Change PruneTriviallyFalseEdges for building CFG

mboehme added a comment. In D149640#4311963 , @kinu wrote: > In D149640#4311889 , @gribozavr2 > wrote: > >> Is it testable? For example, can we show that we don't compute the program >> state for the program poi

[clang] 2cdb6b8 - [clang][dataflow] Expose DataflowAnalysisContext from DataflowEnvironment.

Author: Samira Bazuzi Date: 2023-05-02T11:32:19Z New Revision: 2cdb6b84c157b5fe9c1e3540e7362beef2a7d8e6 URL: https://github.com/llvm/llvm-project/commit/2cdb6b84c157b5fe9c1e3540e7362beef2a7d8e6 DIFF: https://github.com/llvm/llvm-project/commit/2cdb6b84c157b5fe9c1e3540e7362beef2a7d8e6.diff LOG:

[PATCH] D149464: [clang][dataflow] Expose DataflowAnalysisContext from DataflowEnvironment.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2cdb6b84c157: [clang][dataflow] Expose DataflowAnalysisContext from DataflowEnvironment. (authored by bazuzi, committed by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D149645: [clang][Interp] Optionally cast comparison result to non-bool

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Our comparison opcodes always produce a Boolean v

[PATCH] D149640: [clang][dataflow] Change PruneTriviallyFalseEdges for building CFG

ymandel accepted this revision. ymandel added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149640/new/ https://reviews.llvm.org/D149640 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D148425: [clang-repl] Correctly disambiguate dtor declarations from statements

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:91 return true; - case tok::annot_cxxscope: // Check if this is a dtor. -if (NextToken().is(tok::tilde)) v.g.vassilev wrote: > aaron.ballman wrote: > > Are y

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

Fznamznon added a comment. In D147717#4275410 , @cjdb wrote: > I'm gonna get started on this today! @cjdb , how is this going? I've seen https://github.com/llvm/llvm-project/issues/62224, but no more issues with consteval label. Repository: rG LLVM

[clang] 7133283 - [clang] Do not attempt to zero-extend _BitInt(1) when not required

Author: Mariya Podchishchaeva Date: 2023-05-02T08:23:22-04:00 New Revision: 7133283835fbc260465e899ff86c07202486558a URL: https://github.com/llvm/llvm-project/commit/7133283835fbc260465e899ff86c07202486558a DIFF: https://github.com/llvm/llvm-project/commit/7133283835fbc260465e899ff86c0720248655

[PATCH] D149436: [clang] Do not attempt to zero-extend _BitInt(1) when not required

This revision was automatically updated to reflect the committed changes. Closed by commit rG7133283835fb: [clang] Do not attempt to zero-extend _BitInt(1) when not required (authored by Fznamznon). Changed prior to commit: https://reviews.llvm.org/D149436?vs=517863&id=518688#toc Repository:

[PATCH] D148223: [SiFive][RISCV][clang] Support C intrinsics for xsfvcp extension.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8ed9cf06e900: [SiFive][RISCV][clang] Support C intrinsics for xsfvcp extension. (authored by Nelson1225, committed by 4vtomat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[clang] 4bf846b - [RISCV] Split out part of riscv_vector.td to riscv_vector_common.td

Author: 4vtomat Date: 2023-05-02T05:40:13-07:00 New Revision: 4bf846ba40f1867889e13596cdcd06ed6f036c7f URL: https://github.com/llvm/llvm-project/commit/4bf846ba40f1867889e13596cdcd06ed6f036c7f DIFF: https://github.com/llvm/llvm-project/commit/4bf846ba40f1867889e13596cdcd06ed6f036c7f.diff LOG:

[PATCH] D148680: [RISCV] Split out part of riscv_vector.td to riscv_vector_common.td

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4bf846ba40f1: [RISCV] Split out part of riscv_vector.td to riscv_vector_common.td (authored by 4vtomat). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by value

Manna created this revision. Manna added a reviewer: tahonermann. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added projects: All, clang, clang-format. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperD

[clang] fa43608 - [RISCV][RISCV][clang] Split out SiFive Vector C intrinsics from riscv_vector.td

Author: 4vtomat Date: 2023-05-02T05:51:51-07:00 New Revision: fa43608d1649553814a179cd76d67ea7bdc068d3 URL: https://github.com/llvm/llvm-project/commit/fa43608d1649553814a179cd76d67ea7bdc068d3 DIFF: https://github.com/llvm/llvm-project/commit/fa43608d1649553814a179cd76d67ea7bdc068d3.diff LOG:

[PATCH] D148308: [RISCV][RISCV][clang] Split out SiFive VCIX C intrinsics from riscv_vector.td

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa43608d1649: [RISCV][RISCV][clang] Split out SiFive Vector C intrinsics from riscv_vector.td (authored by 4vtomat). Changed prior to commit: http

[PATCH] D147626: [clang] Reject flexible array member in a union in C++

Fznamznon updated this revision to Diff 518695. Fznamznon added a comment. Rebase, add a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147626/new/ https://reviews.llvm.org/D147626 Files: clang/docs/ReleaseNotes.rst clang/include/clang/

[PATCH] D147626: [clang] Reject flexible array member in a union in C++

Fznamznon added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6241-6244 def ext_flexible_array_empty_aggregate_ms : Extension< "flexible array member %0 in otherwise empty " "%select{struct|interface|union|class|enum}1 is a Microsoft extensi

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

ABataev added a comment. In D144634#4308872 , @koops wrote: > 1. Taken care of some of the comments by Alexey. > 2. Added extra tests of loop_bind_messages.cpp > > However, generic_loop_messages.cpp & generic_loop_ast_print.cpp are present > and provide

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak updated this revision to Diff 518698. skatrak added a comment. Rebase. Disable some known failing 'declare target' tests temporarily until they are fixed by parent patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://re

[PATCH] D149645: [clang][Interp] Optionally cast comparison result to non-bool

erichkeane added a comment. For C, should we instead be teaching our boolean operations to understand it might be int? I fear this will end up causing conversion problems later, such as with: `int F = 1 > 2;`. We won't end up having a conversion operation there, since the RHS is already `int

[PATCH] D149634: [clang][Interp] Implement inc/dec operators for floats

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. This looks right to me. Comment at: clang/lib/AST/Interp/Floating.h:132 +*R = Floating(A.F); + +return R->F.add(One, RM); Extra new line vs t

[PATCH] D147626: [clang] Reject flexible array member in a union in C++

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147626/new/ https://reviews.llvm.org/D147626

[PATCH] D149649: Update comment.

massberg created this revision. massberg added a reviewer: ilya-biryukov. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [class.rel] has been renamed to [class.compare.secondary]. Repository: rG LL

[PATCH] D149640: [clang][dataflow] Change PruneTriviallyFalseEdges for building CFG

kinu updated this revision to Diff 518702. kinu added a comment. Changing the existing test to reflect the flag change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149640/new/ https://reviews.llvm.org/D149640 Files: clang/lib/Analysis/FlowSensi

[PATCH] D149645: [clang][Interp] Optionally cast comparison result to non-bool

tbaeder added a comment. In D149645#4312162 , @erichkeane wrote: > For C, should we instead be teaching our boolean operations to understand it > might be int? I fear this will end up causing conversion problems later, > such as with: > > `int F = 1 >

[PATCH] D149645: [clang][Interp] Optionally cast comparison result to non-bool

erichkeane added a comment. In D149645#4312190 , @tbaeder wrote: > In D149645#4312162 , @erichkeane > wrote: > >> For C, should we instead be teaching our boolean operations to understand it >> might be int? I

[PATCH] D149640: [clang][dataflow] Change PruneTriviallyFalseEdges for building CFG

gribozavr2 added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:2641 TEST(TransferTest, VarDeclInDoWhile) { std::string Code = R"( Could you update the test name to reflect what the test is checking now? (the comment t

[PATCH] D149640: [clang][dataflow] Change PruneTriviallyFalseEdges for building CFG

mboehme added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:2673 - -EXPECT_EQ(BarVal, FooPointeeVal); }); It's unfortuante that all of these checks have gone away. I think the test was actually trying to test

[PATCH] D149182: Remove -Wpacked false positive for non-pod types where the layout isn't directly changed

aaron.ballman added a comment. Precommit CI found a valid issue (at least on Debian, the Windows failure appears to be unrelated but it's really hard to tell from that output). Also, this should have a release note, right? Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:220

[PATCH] D149641: [docs] Hide collaboration and include graphs in doxygen docs

aaron.ballman added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: jplehr, sstefan1, JDevlieghere. I think this is a reasonable change -- I don't see a whole lot of value out from the include or collaboration graphs, so unless someone has strong opinions otherwise, I th

[PATCH] D149645: [clang][Interp] Optionally cast comparison result to non-bool

tbaeder updated this revision to Diff 518707. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149645/new/ https://reviews.llvm.org/D149645 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/c.c Index: clang/test/AST/Interp/c.c ==

[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

simonwallis2 added inline comments. Comment at: llvm/lib/Target/ARM/ARMSubtarget.cpp:434 // range otherwise. - return !NoMovt && hasV8MBaselineOps() && + return !NoMovt && hasV6MOps() && (isTargetWindows() || !OptMinSize || genExecuteOnly()); V6M d

[PATCH] D149645: [clang][Interp] Optionally cast comparison result to non-bool

tbaeder added a comment. In D149645#4312193 , @erichkeane wrote: > In D149645#4312190 , @tbaeder wrote: > >> In D149645#4312162 , @erichkeane >> wrote: >> >>> For C, sho

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names and introduce Bfloat16 arithmetic type.

erichkeane added a subscriber: rjmccall. erichkeane added a comment. I Comment at: clang/include/clang/AST/ASTContext.h:28 #include "clang/AST/TemplateName.h" +#include "clang/AST/Type.h" #include "clang/Basic/IdentifierTable.h" What is this needed for? =

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

yronglin added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:7979-7986 { ExprResult FirstArgResult = DefaultFunctionArrayLvalueConversion(FirstArg); -if (FirstArgResult.isInvalid()) +if (checkBuiltinArgument(*this, TheCall, 0)) retur

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

aaron.ballman added a comment. In D141451#4311199 , @dblaikie wrote: >> probably too much, but then I wonder "how do we make Fortify work?". > > (I'm still sort of on the side of "if the compile-time costs to get more > verbose diagnostics is high, we co

[PATCH] D149144: [clang][dataflow] Eliminate intermediate `ReferenceValue`s from `Environment::DeclToLoc`.

mboehme updated this revision to Diff 518709. mboehme marked an inline comment as done. mboehme added a comment. Changes in response to review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149144/new/ https://reviews.llvm.org/D149144 File

[PATCH] D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo updated this revision to Diff 518710. oontvoo added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. updated clang test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144999/new/ https://reviews.llvm.org/D144

[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

simonwallis2 added inline comments. Comment at: llvm/lib/Target/ARM/ARMSubtarget.cpp:434 // range otherwise. - return !NoMovt && hasV8MBaselineOps() && + return !NoMovt && hasV6MOps() && (isTargetWindows() || !OptMinSize || genExecuteOnly()); simon

[PATCH] D148767: Restore CodeGen/LowLevelType from `Support`

chapuni updated this revision to Diff 518713. chapuni retitled this revision from "Restore CodeGen/LowLevelType" to "Restore CodeGen/LowLevelType from `Support`". chapuni edited the summary of this revision. chapuni added a comment. - Rebase and update the desc Repository: rG LLVM Github Mono

[PATCH] D147626: [clang] Reject flexible array member in a union in C++

aaron.ballman added inline comments. Comment at: clang/test/SemaObjCXX/flexible-array.mm:7 int s; - char c[]; + char c[]; //expected-error {{flexible array member 'c' in a union is not allowed}} }; CC @rjmccall -- this is changing Objective-C++ behavior, w

[PATCH] D148223: [SiFive][RISCV][clang] Support C intrinsics for xsfvcp extension.

TWeaver added a comment. Hello and Good Afternoon from the UK, I believe this revision has started the following build bot to start failing on these 5 tests: https://lab.llvm.org/buildbot/#/builders/216/builds/20627 xsfvcp-x-rv64.c xsfvcp-x.c xsfvcp-xv.c xsfvcp-xvv.c xsfvcp-xvw.c Is anyone ab

[PATCH] D149144: [clang][dataflow] Eliminate intermediate `ReferenceValue`s from `Environment::DeclToLoc`.

mboehme marked 5 inline comments as done. mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:307-311 + auto &ParamLoc = + createStorageLocation(ParamDecl->getType().getNonReferenceType()); setStorageLocation(*P

[PATCH] D149380: [clang] Add -Wunused-result-always warning

aaron.ballman added a comment. In D149380#4311237 , @dblaikie wrote: > Seems more stylistic/unlikely to meet the diagnostic bar (certtainly couldn't > be on-by-default for instance) for clang to me (but could go into something > like clang-tidy), at lea

[PATCH] D149650: Give NullabilityKind a printing operator<

sammccall created this revision. sammccall added a reviewer: mboehme. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is more useful for debug/test than getNullabilitySpelling: - default form has

[PATCH] D149650: Give NullabilityKind a printing operator<

sammccall added inline comments. Comment at: clang/lib/Basic/IdentifierTable.cpp:852 +llvm::raw_ostream &operator<<(llvm::raw_ostream &OS, NullabilityKind NK) { + switch (NK) { IdentifierTable.cpp is a weird place to implement this function (I put it next to

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aaron.ballman added a comment. In D146764#4310655 , @aeubanks wrote: > In D146764#4310398 , @aaron.ballman > wrote: > >> I think you're missing changes in ASTReaderStmt.cpp and ASTWriterStmt.cpp, >> so serializa

[PATCH] D149215: [MemProf] Control availability of hot/cold operator new from LTO link

tejohnson updated this revision to Diff 518721. tejohnson added a comment. Address comment (add TODO about automatically detecting support) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149215/new/ https://reviews.llvm.org/D149215 Files: clang/t

[PATCH] D148223: [SiFive][RISCV][clang] Support C intrinsics for xsfvcp extension.

4vtomat added a comment. In D148223#4312296 , @TWeaver wrote: > Hello and Good Afternoon from the UK, > > I believe this revision has started the following build bot to start failing > on these 5 tests: > > https://lab.llvm.org/buildbot/#/builders/216/bu

[PATCH] D148769: Split out `CodeGenTypes` from `CodeGen` for LLT/MVT

chapuni updated this revision to Diff 518722. chapuni edited the summary of this revision. chapuni added a comment. - Updat the desc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148769/new/ https://reviews.llvm.org/D148769 Files: clang/lib/Code

[PATCH] D149650: Give NullabilityKind a printing operator<

aaron.ballman added a comment. I guess I'm not seeing much motivation for this change. We already have `clang::getNullabilitySpelling()` and `const StreamingDiagnostic &clang::operator<<(const StreamingDiagnostic &DB, DiagNullabilityKind nullability)` and now we're adding a third way to get thi

[PATCH] D149641: [docs] Hide collaboration and include graphs in doxygen docs

tianshilei1992 added a comment. Looks good on the OpenMP side as we don’t generally have a good API doc anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149641/new/ https://reviews.llvm.org/D149641

[PATCH] D149492: [clang] makes built-in traits match their stdlib counterparts' names

aaron.ballman added a comment. In D149492#4311026 , @cjdb wrote: > Looks like I need to special-case `__is_null_pointer` as a function for > libstdc++. Yeah, precommit CI found an issue with that. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D148223: [SiFive][RISCV][clang] Support C intrinsics for xsfvcp extension.

TWeaver added a comment. In D148223#4312352 , @4vtomat wrote: > I'll take a look, thanks! Much obliged and thanks for the speedy reply! 👍 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148223/new/ https://

[PATCH] D148223: [SiFive][RISCV][clang] Support C intrinsics for xsfvcp extension.

4vtomat added a comment. Hi @craig.topper and @kito-cheng , the build error message was: 'z:\test\build\lib\clang\17\include\sifive_vector.h:12:10: fatal error: 'riscv_vector.h' file not found'. Have you ever met this before? I'm not sure if I forgot to add something or not.. Repository: rG

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

davidtgoldblatt added a comment. This breaks ~the world in the versions of libstdc++ I can easily check -- see e.g. https://gcc.godbolt.org/z/ETeGzc3ve (crashes at this commit, changes to an error at ce861ec782ae3f41807b61e855512aaccf3c2149

[PATCH] D148654: Modify BoundsSan to improve debuggability

smeenai added a comment. Thinking about this a bit more, should the trap not have an associated stack trace that can be symbolicated to tell you which line of code was crashing? If the issue is that multiple traps can get folded together, the `nomerge` attribute (D78659

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added a comment. In D146178#4312473 , @davidtgoldblatt wrote: > This breaks ~the world in the versions of libstdc++ I can easily check -- see > e.g. https://gcc.godbolt.org/z/ETeGzc3ve (crashes at this commit, changes to > an error at ce861e

[PATCH] D149637: [Clang] Correctly expand pack in binary subscript expression.

shafik accepted this revision. shafik added a comment. LGTM, other than my comment on the diagnostic wording Comment at: clang/test/SemaCXX/cxx2b-overloaded-operator.cpp:101 + int arr[] = {1, 2, 3}; + return arr[Is...]; // expected-error 2{{type 'int[3]' does not provide a s

[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

junaire updated this revision to Diff 518738. junaire marked 3 inline comments as done. junaire added a comment. Address comments, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148997/new/ https://reviews.llvm.org/D148997 Files: clang/in

[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

junaire added inline comments. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:162 + if (P->getCurToken().is(tok::annot_repl_input_end)) { +P->ConsumeAnyToken(); // FIXME: Clang does not call ExitScope on finalizing the regular TU, we rsmith wro

[PATCH] D149144: [clang][dataflow] Eliminate intermediate `ReferenceValue`s from `Environment::DeclToLoc`.

ymandel accepted this revision. ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:329 + // against this above. + ProcessVarDecl(*VD); + auto *VDLoc = Env.getStorageLocation(*VD); mboehme wrote: > y

[clang] 3e850a6 - Revert "[Clang][Sema] Fix comparison of constraint expressions"

Author: Erich Keane Date: 2023-05-02T08:09:35-07:00 New Revision: 3e850a6eea5277082a0b7b701754c86530d25c40 URL: https://github.com/llvm/llvm-project/commit/3e850a6eea5277082a0b7b701754c86530d25c40 DIFF: https://github.com/llvm/llvm-project/commit/3e850a6eea5277082a0b7b701754c86530d25c40.diff L

[clang] ad71114 - Revert "[Clang][Sema] Add a temporary workaround in SemaConcept.cpp"

Author: Erich Keane Date: 2023-05-02T08:09:01-07:00 New Revision: ad7111495f43fe8f837007b9e21afb9e515df4d1 URL: https://github.com/llvm/llvm-project/commit/ad7111495f43fe8f837007b9e21afb9e515df4d1 DIFF: https://github.com/llvm/llvm-project/commit/ad7111495f43fe8f837007b9e21afb9e515df4d1.diff L

[PATCH] D149637: [Clang] Correctly expand pack in binary subscript expression.

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/cxx2b-overloaded-operator.cpp:101 + int arr[] = {1, 2, 3}; + return arr[Is...]; // expected-error 2{{type 'int[3]' does not provide a subscript operator}} +} shafik wrote: > The diagnostic is not g

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added a comment. I reverted due to the workaround (which I'd objected to before, I don't think it is acceptable) and the breakage David mentioned. I'll make sure to review the commit message when you put it back up for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D148223: [SiFive][RISCV][clang] Support C intrinsics for xsfvcp extension.

dyung added a comment. In D148223#4312460 , @4vtomat wrote: > Hi @craig.topper and @kito-cheng , the build error message was: > 'Z:\test\llvm-project\clang\test\CodeGen\RISCV\rvv-intrinsics-autogenerated\non-policy\non-overloaded\xsfvcp-x-rv64.c:4:10: >

[PATCH] D149119: [CMake] Use llvm-nm to extract symbols for staged LTO builds on Windows

simon_tatham added a comment. Do LLVM's current portability goals include the constraint that you can only build LLVM for a platform it can also target? If not, then there surely still needs to be //some// kind of escape hatch so that you can avoid needing `llvm-nm` to already support the objec

[PATCH] D148223: [SiFive][RISCV][clang] Support C intrinsics for xsfvcp extension.

4vtomat added a comment. In D148223#4312460 , @4vtomat wrote: > Hi @craig.topper and @kito-cheng , the build error message was: > 'Z:\test\llvm-project\clang\test\CodeGen\RISCV\rvv-intrinsics-autogenerated\non-policy\non-overloaded\xsfvcp-x-rv64.c:4:10:

[PATCH] D148767: Restore CodeGen/LowLevelType from `Support`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9cfeba5b12b6: Restore CodeGen/LowLevelType from `Support` (authored by chapuni). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148769: Split out `CodeGenTypes` from `CodeGen` for LLT/MVT

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d71ec6e448f: Split out `CodeGenTypes` from `CodeGen` for LLT/MVT (authored by chapuni). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D147840: [clang][Interp] Handle DiscardResult for DeclRef- and ParenExprs

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147840/new/ https://reviews.llvm.org/D147840 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D146090: [Clang] Updating handling of defaulted comparison operators to reflect changes from P2448R2

shafik added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146090/new/ https://reviews.llvm.org/D146090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148474: [Clang] Fix ResolveConstructorOverload to not select a conversion function if we are going use copy elision

shafik added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148474/new/ https://reviews.llvm.org/D148474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148223: [SiFive][RISCV][clang] Support C intrinsics for xsfvcp extension.

4vtomat added a comment. In D148223#4312515 , @dyung wrote: > In D148223#4312460 , @4vtomat wrote: > >> Hi @craig.topper and @kito-cheng , the build error message was: >> 'Z:\test\llvm-project\clang\test\CodeGen\

[PATCH] D149655: [tests] Add missing REQUIRES: riscv-registered-target to clang test

4vtomat created this revision. Herald added subscribers: luke, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuas

[PATCH] D149633: [clang][codegen] Add F128 vsnprintf_chk builtin

tuliom requested changes to this revision. tuliom added a comment. This revision now requires changes to proceed. @tbaeder Keep in mind that I don't think this will completely fix issue 61913 because there are other 2 functions affected. Otherwise, I believe this patch is in the right direction.

[PATCH] D149562: [clang-format] Stop comment disrupting indentation of Verilog ports

sstwcw added a comment. In D149562#4310396 , @HazardyKnusperkeks wrote: > I don't see the problem, could you elaborate a bit more? (Keep in mind, I > have no idea about Verilog.) The current way the port list gets formatted is like this: module x

  1   2   3   >