[clang] 2cc0c0d - [MemProf] Recognize hot/cold operator new as replaceable allocations

Author: Teresa Johnson Date: 2023-05-01T13:37:40-07:00 New Revision: 2cc0c0de802178dc7e5408497e2ec53b6c9728fa URL: https://github.com/llvm/llvm-project/commit/2cc0c0de802178dc7e5408497e2ec53b6c9728fa DIFF: https://github.com/llvm/llvm-project/commit/2cc0c0de802178dc7e5408497e2ec53b6c9728fa.diff

[PATCH] D149600: [MemProf] Recognize hot/cold operator new as replaceable allocations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2cc0c0de8021: [MemProf] Recognize hot/cold operator new as replaceable allocations (authored by tejohnson). Repository: rG LLVM Github Monorepo C

[PATCH] D149451: [NVPTX] Add NVPTXCtorDtorLoweringPass to handle global ctors / dtors

tra added inline comments. Comment at: llvm/lib/Target/NVPTX/NVPTXCtorDtorLowering.cpp:58 +((IsCtor ? "__init_array_object_" : "__fini_array_object_") + + F->getName() + "_" + getHash(M.getName()) + "_" + + std::to_string(Priority)) jhuber

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

rsundahl updated this revision to Diff 518552. rsundahl added a comment. Rename asabi->asan_abi Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143675/new/ https://reviews.llvm.org/D143675 Files: clang/include/clang/Driver/Options.td clang/inclu

[PATCH] D149451: [NVPTX] Add NVPTXCtorDtorLoweringPass to handle global ctors / dtors

jhuber6 updated this revision to Diff 518553. jhuber6 added a comment. Changing to use source filename. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149451/new/ https://reviews.llvm.org/D149451 Files: clang/lib/Driver/ToolChains/Cuda.cpp clan

[PATCH] D148654: Modify BoundsSan to improve debuggability

smeenai added a comment. You should upload this with full context and add some test cases :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148654/new/ https://reviews.llvm.org/D148654 ___ cfe-commits mai

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

rsundahl marked an inline comment as done. rsundahl added a comment. @kcc @eugenis @MaskRay @vitalybuka Ok to go with this? All new functionality is under the added flag so not expecting any surprises. Rename asabi->asan_abi as suggested. Comment at: compiler-rt/lib/asabi/CMa

[PATCH] D149144: [clang][dataflow] Eliminate intermediate `ReferenceValue`s from `Environment::DeclToLoc`.

xazax.hun added a subscriber: dcoughlin. xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:616 + bool erased = DeclToLoc.erase(&D); + if (!erased) +D.dump(); Would we dump this in release builds? Do we wan

[clang] 771ad16 - [Clang] Fix a crash when recursively callig a default member initializer.

Author: Corentin Jabot Date: 2023-05-01T23:21:14+02:00 New Revision: 771ad1691ac3057df2220dd327d7cdc73ef6c6f5 URL: https://github.com/llvm/llvm-project/commit/771ad1691ac3057df2220dd327d7cdc73ef6c6f5 DIFF: https://github.com/llvm/llvm-project/commit/771ad1691ac3057df2220dd327d7cdc73ef6c6f5.diff

[PATCH] D142401: [Clang] Fix a crash when recursively callig a default member initializer.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG771ad1691ac3: [Clang] Fix a crash when recursively callig a default member initializer. (authored by cor3ntin). Changed prior to commit: https://r

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

rsmith added a comment. There's some corresponding code in `lib/CodeGen` that can be deleted too: case Builtin::BI__builtin_assume_aligned: { const Expr *Ptr = E->getArg(0); Value *PtrValue = EmitScalarExpr(Ptr); - if (PtrValue->getType() != VoidPtrTy) - PtrValue

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

eugenis added a comment. I'm fine with it in general. Is asan_abi.cpp meant as a temporary stub? It's not even link anywhere in the current version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143675/new/ https://reviews.llvm.org/D143675 __

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

vitalybuka accepted this revision. vitalybuka added 2 blocking reviewer(s): eugenis, MaskRay. vitalybuka added a comment. In D143675#4310734 , @rsundahl wrote: > @kcc @eugenis @MaskRay @vitalybuka Ok to go with this? All new functionality > is under the

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. @erichkeane - thanks! I'll send a diff for the release notes ~soon (~this week). (P.S. just in case - I'll be out of office for ~2 weeks) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://r

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

dexonsmith added subscribers: iana, ributzka. dexonsmith added a comment. In D103930#4310061 , @ivanmurashko wrote: > Friendly ping > > @arphaman, @jansvoboda11, I have made the patch buildable on all platforms > and have all tests passed. There was als

[PATCH] D149618: [clang][NFC] documents recent type trait primitives

cjdb created this revision. cjdb added reviewers: aaron.ballman, erichkeane, shafik. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends on D149492 . Repository: rG

[PATCH] D142569: [OpenMP] Introduce kernel environment

tianshilei1992 added inline comments. Comment at: llvm/test/Transforms/OpenMP/always_inline_device.ll:11 -; Function Attrs: norecurse nounwind +@kernel_environment = local_unnamed_addr constant %struct.KernelEnvironmentTy { %struct.ConfigurationEnvironmentTy { i8 1, i8 0, i8 1

[PATCH] D149492: [clang] makes built-in traits match their stdlib counterparts' names

cjdb added a comment. Looks like I need to special-case `__is_null_pointer` as a function for libstdc++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149492/new/ https://reviews.llvm.org/D149492 ___ cf

[PATCH] D149451: [NVPTX] Add NVPTXCtorDtorLoweringPass to handle global ctors / dtors

tra added inline comments. Comment at: llvm/lib/Target/NVPTX/NVPTXCtorDtorLowering.cpp:58 +((IsCtor ? "__init_array_object_" : "__fini_array_object_") + + F->getName() + "_" + getHash(M.getName()) + "_" + + std::to_string(Priority)) tra wr

[PATCH] D149451: [NVPTX] Add NVPTXCtorDtorLoweringPass to handle global ctors / dtors

jhuber6 added inline comments. Comment at: llvm/lib/Target/NVPTX/NVPTXCtorDtorLowering.cpp:58 +((IsCtor ? "__init_array_object_" : "__fini_array_object_") + + F->getName() + "_" + getHash(M.getName()) + "_" + + std::to_string(Priority)) tr

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names and introduce Bfloat16 arithmetic type.

codemzs added a comment. In D149573#4310601 , @philnik wrote: > In D149573#4310009 , @codemzs wrote: > >> My change to libcxxabi/test/test_demangle.pass.cpp (last file in the change) >> is only one line i.e {"_ZN

[clang] a50e54f - [CUDA] Temporarily undefine __noinline__ when including bits/shared_ptr_base.h

Author: Artem Belevich Date: 2023-05-01T16:27:13-07:00 New Revision: a50e54fbeb48fb8a218a2914d827e1087bae2f8d URL: https://github.com/llvm/llvm-project/commit/a50e54fbeb48fb8a218a2914d827e1087bae2f8d DIFF: https://github.com/llvm/llvm-project/commit/a50e54fbeb48fb8a218a2914d827e1087bae2f8d.diff

[PATCH] D149364: [CUDA] Temporarily undefine __noinline__ when including bits/shared_ptr_base.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa50e54fbeb48: [CUDA] Temporarily undefine __noinline__ when including bits/shared_ptr_base.h (authored by tra). Repository: rG LLVM Github Monorep

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

dblaikie added a comment. > probably too much, but then I wonder "how do we make Fortify work?". (I'm still sort of on the side of "if the compile-time costs to get more verbose diagnostics is high, we could have a low-quality default-on diagnostic and it could mention/recommend a different/hig

[PATCH] D147266: [AArch64] Add IR intrinsics for vbsl* C intrinsics

efriedma added a reviewer: dmgreen. efriedma added subscribers: bsmith, paulwalker-arm, lenary. efriedma added a comment. The primary tradeoff here is that existing optimizations won't understand the intrinsic... for example, we can't constant-fold, or automatically invert the mask. But making

[PATCH] D148769: Split out `CodeGenTypes` from `CodeGen` for LLT/MVT

dblaikie accepted this revision. dblaikie added a comment. I wouldn't mind a follow-up commit that creates a new/separate directory (llvm/{lib,include/llvm}/CodeGenTypes) but that's probably a lot of unnecessary churn too, so I can appreciate the argument against it - if folks reckon it's bette

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names and introduce Bfloat16 arithmetic type.

philnik removed a reviewer: libc++abi. philnik added a comment. In D149573#433 , @codemzs wrote: > In D149573#4310601 , @philnik wrote: > >> In D149573#4310009 , @code

[PATCH] D149380: [clang] Add -Wunused-result-always warning

dblaikie added a comment. Seems more stylistic/unlikely to meet the diagnostic bar (certtainly couldn't be on-by-default for instance) for clang to me (but could go into something like clang-tidy), at least. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D149182: Remove -Wpacked false positive for non-pod types where the layout isn't directly changed

dblaikie added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149182/new/ https://reviews.llvm.org/D149182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D147266: [AArch64] Add IR intrinsics for vbsl* C intrinsics

efriedma added a comment. I guess I should note both the examples in https://github.com/llvm/llvm-project/issues/49305 could probably be fixed in other ways... we have heuristics to, for example, sink logic ops into loops when it's profitable. But that requires someone to notice the specific i

[PATCH] D149451: [NVPTX] Add NVPTXCtorDtorLoweringPass to handle global ctors / dtors

jhuber6 updated this revision to Diff 518604. jhuber6 added a comment. Add option to allow overriding the global hash. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149451/new/ https://reviews.llvm.org/D149451 Files: clang/lib/Driver/ToolChains/

[PATCH] D146342: [-Wunsafe-buffer-usage] Move the whole analysis to the end of a translation unit

ziqingluo-90 updated this revision to Diff 518608. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146342/new/ https://reviews.llvm.org/D146342 Files: clang/include/clang/Sema/AnalysisBasedWarnings.h clang/lib/Sema/AnalysisBasedWarnings.cpp clang/lib/Sema/Sema.cpp clang/test/SemaCX

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aemerson added a comment. Herald added a subscriber: jplehr. @dmgreen I've been looking at this test again trying to see what's missing. The problem now is that only a VF of 4 is chosen. In the good case, instcombine/simplifyCFG runs so that it simplifies down to an `smin` intrinsic. After this

[PATCH] D145343: [AMDGPU] Emit predefined macro `__AMDGCN_CUMODE`

yaxunl added inline comments. Comment at: clang/lib/Basic/Targets/AMDGPU.cpp:318 Builder.defineMacro("__AMDGCN_WAVEFRONT_SIZE", Twine(WavefrontSize)); + Builder.defineMacro("__AMDGCN_CUMODE", Twine(CUMode)); } arsenm wrote: > Why do we sometimes use __ on bo

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

ahatanak updated this revision to Diff 518610. ahatanak added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Disable llvm-symbolizer when running lit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148851/new/

[clang] ea7e69f - [Driver] Drop incorrect hint from err_target_unknown_triple

Author: Fangrui Song Date: 2023-05-01T18:22:49-07:00 New Revision: ea7e69f392b29201502cdcb8cfa83f0f3704da34 URL: https://github.com/llvm/llvm-project/commit/ea7e69f392b29201502cdcb8cfa83f0f3704da34 DIFF: https://github.com/llvm/llvm-project/commit/ea7e69f392b29201502cdcb8cfa83f0f3704da34.diff

[PATCH] D148944: [clang][Driver] Fix crash with unsupported architectures in MinGW and CrossWindows.

MaskRay accepted this revision. MaskRay added a comment. Looks great! Comment at: clang/test/Driver/unsupported-target-arch.c:33 +// RUN: FileCheck --input-file=%t.err --check-prefix=CHECK-NOARCH-CROSSWINDOWS %s +// CHECK-NOARCH-CROSSWINDOWS: error: unknown target triple 'noa

[PATCH] D149187: [clang] Canonicalize system headers in dependency file when -canonical-prefixes

chapuni added a comment. I am afraid this would be incompatible to bazel due to deep symlinks for sandbox. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149187/new/ https://reviews.llvm.org/D149187 ___

[clang] ecad121 - [clang][Driver] Fix crash with unsupported architectures in MinGW and CrossWindows

Author: KOMATA Manabu Date: 2023-05-01T18:34:09-07:00 New Revision: ecad1210092764592ca9ee0670dd15831e54b770 URL: https://github.com/llvm/llvm-project/commit/ecad1210092764592ca9ee0670dd15831e54b770 DIFF: https://github.com/llvm/llvm-project/commit/ecad1210092764592ca9ee0670dd15831e54b770.diff

[PATCH] D148944: [clang][Driver] Fix crash with unsupported architectures in MinGW and CrossWindows.

This revision was automatically updated to reflect the committed changes. Closed by commit rGecad12100927: [clang][Driver] Fix crash with unsupported architectures in MinGW and… (authored by k-mana, committed by MaskRay). Changed prior to commit: https://reviews.llvm.org/D148944?vs=515809&id=51

cfe-commits@lists.llvm.org

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! Comment at: llvm/docs/ReleaseNotes.rst:289 +* ``llvm::demangle`` now takes a ``std::string_view`` rather than a + ``const std::string&``. Be careful passing

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

MaskRay added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:863 + InliningDecisions.push_back(D.getCaller().str()); + for (size_t i = 0, e = InliningDecisions.size(); i != e; ++i) { +std::string S = llvm::demangle(InliningDecisions[i]); a

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter added a comment. bump? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146921/new/ https://reviews.llvm.org/D146921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D149631: [NFC][CLANG] Fix static analyzer codes concerns about large copies by value

Manna created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a reviewer: aaron.ballman. Herald added projects: All, clang, clang-format. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDevelop

[PATCH] D149187: [clang] Canonicalize system headers in dependency file when -canonical-prefixes

aeubanks added a comment. In D149187#4311354 , @chapuni wrote: > I am afraid this would be incompatible to bazel due to deep symlinks for > sandbox. I assume bazel would use `-no-canonical-prefixes`? Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

MaskRay added a comment. I have read prior discussions and https://discourse.llvm.org/t/rfc-improving-clangs-middle-and-back-end-diagnostics/69261 . The current approach seems reasonable. The summary should incorporate more information. `inlined.from` isn't mentioned at all. ==

[PATCH] D148767: Restore CodeGen/LowLevelType

MaskRay added a comment. > This is rework of; > > D30046 (LLT) Add some information why this is restored? Assume that people may not read the depended patches (`Depends on D145937, D146352, and D148768.`). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] 7d0938b - [clang][Interp][NFC] Make OptionScope final

Author: Timm Bäder Date: 2023-05-02T06:16:49+02:00 New Revision: 7d0938bf2c2a35d4eb4b8c4c728aaa85d1dd428e URL: https://github.com/llvm/llvm-project/commit/7d0938bf2c2a35d4eb4b8c4c728aaa85d1dd428e DIFF: https://github.com/llvm/llvm-project/commit/7d0938bf2c2a35d4eb4b8c4c728aaa85d1dd428e.diff LO

[clang] 9ec5423 - [clang][Interp][NFC] Add documentation for SetLocal

Author: Timm Bäder Date: 2023-05-02T06:16:49+02:00 New Revision: 9ec5423b90c888d9ec4206c18b728946be5f1368 URL: https://github.com/llvm/llvm-project/commit/9ec5423b90c888d9ec4206c18b728946be5f1368 DIFF: https://github.com/llvm/llvm-project/commit/9ec5423b90c888d9ec4206c18b728946be5f1368.diff LO

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

ahatanak updated this revision to Diff 518630. ahatanak added a comment. Enable llvm-symbolizer when running disable-crash-reports.test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148851/new/ https://reviews.llvm.org/D148851 Files: llvm/test/

[PATCH] D149334: [RISCV] Enable strict fp for RISC-V in clang.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149334/new/ https://reviews.llvm.org/D149334 ___

[PATCH] D149495: [RISCV] Add sifive-x280 processor and support V extension in SiFive7

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVProcessors.td:169 +def SIFIVE_X280 : RISCVProcessorModel<"sifive-x280", SiFive7Model, + [Feature64Bit, I would prefer that we add sifive-x280 in a si

[PATCH] D149495: [RISCV] Add sifive-x280 processor and support V extension in SiFive7

craig.topper added a comment. All CPU name additions should be mentioned in the RISC-V section of llvm/docs/ReleaseNotes.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149495/new/ https://reviews.llvm.org/D149495 __

[PATCH] D148767: Restore CodeGen/LowLevelType

barannikov88 added a comment. Adding CodeGen dependency to MCTargetDesc layer does not seem right. Why is it necessary? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148767/new/ https://reviews.llvm.org/D148767 ___

[clang] 74c1fa6 - [RISCV] Add Smaia and Ssaia extensions support

Author: 4vtomat Date: 2023-05-01T22:30:08-07:00 New Revision: 74c1fa60b5f5c1d079e08a2e409a649a26da41d1 URL: https://github.com/llvm/llvm-project/commit/74c1fa60b5f5c1d079e08a2e409a649a26da41d1 DIFF: https://github.com/llvm/llvm-project/commit/74c1fa60b5f5c1d079e08a2e409a649a26da41d1.diff LOG:

[PATCH] D148066: [RISCV] Add Smaia and Ssaia extensions support

This revision was automatically updated to reflect the committed changes. Closed by commit rG74c1fa60b5f5: [RISCV] Add Smaia and Ssaia extensions support (authored by 4vtomat). Changed prior to commit: https://reviews.llvm.org/D148066?vs=516137&id=518634#toc Repository: rG LLVM Github Monore

[PATCH] D148767: Restore CodeGen/LowLevelType

chapuni added a comment. In D148767#4311529 , @MaskRay wrote: > Add some information why this is restored? Assume that people may not read > the depended patches (`Depends on D145937, D146352, and D148768.`). Yes sure. This was just an isolated diff wit

[PATCH] D149633: [clang][codegen] Add F128 svnprintf_chk builtin

tbaeder created this revision. tbaeder added reviewers: ecnelises, tstellar, tuliom, efriedma. Herald added subscribers: kbarton, nemanjai. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://g

[PATCH] D148284: [clangd] Add "readonly" token to const member expressions

t-troebst updated this revision to Diff 518641. t-troebst added a comment. Add best effort attempt to get const-ness for dependent member expressions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148284/new/ https://reviews.llvm.org/D148284 Files

[PATCH] D148284: [clangd] Add "readonly" token to const member expressions

t-troebst added a comment. I've added some logic to get const-ness for dependent expressions. I think you're right that its probably reasonable to do this since mutable is almost always used in member functions where the type isn't dependent anyways. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D149634: [clang][Interp] Implement inc/dec operators for floats

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik, sepavloff. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Looks like I forgot these. Repository

<    1   2