[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

owenpan added a comment. @jp4a50 There's a mismatch between Format.h and and the resulting rst file. I'll rerun dump_format_style.py to fix it before merging. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146101/new/ https://reviews.llvm.org/D1461

[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc12aa69a0be9: [clang-format] Add BracedInitializerIndentWidth option (authored by jp4a50, committed by owenpan). Changed prior to commit: https://reviews.llvm.org/D146101?vs=517868&id=518140#toc Reposi

[clang] c12aa69 - [clang-format] Add BracedInitializerIndentWidth option

Author: Jon Phillips Date: 2023-04-29T00:36:19-07:00 New Revision: c12aa69a0be9acd0c751bf92318050d2b3730f9b URL: https://github.com/llvm/llvm-project/commit/c12aa69a0be9acd0c751bf92318050d2b3730f9b DIFF: https://github.com/llvm/llvm-project/commit/c12aa69a0be9acd0c751bf92318050d2b3730f9b.diff

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan updated this revision to Diff 518144. zyounan added a comment. Refactor tests. Obtain type from VarDecl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148457/new/ https://reviews.llvm.org/D148457 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

Ris-Bali created this revision. Ris-Bali added a reviewer: tbaeder. Ris-Bali added a project: clang. Herald added a project: All. Ris-Bali requested review of this revision. Herald added a subscriber: cfe-commits. Currently clang doesn't verify if the first argument in _builtin_assume_aligned_ is

[PATCH] D148769: Split out `CodeGenTypes` from `CodeGen` for LLT/MVT

chapuni added a reviewer: dblaikie. chapuni added a subscriber: dblaikie. chapuni added a comment. I am certain this works, though, I would like to ask the 2nd opinion to @dblaikie . In D148769#4297552 , @arsenm wrote: > I feel like this should have doc

[PATCH] D148769: Split out `CodeGenTypes` from `CodeGen` for LLT/MVT

chapuni updated this revision to Diff 518146. chapuni added a comment. - Add comment lines to LLVMCodeGenTypes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148769/new/ https://reviews.llvm.org/D148769 Files: clang/lib/CodeGen/CMakeLists.txt l

[PATCH] D148457: [clangd] Support macro evaluation on hover

sammccall added a comment. > Obviously we're expecting evaluation on such macro (which is just what the > original issue addresses). That wasn't (and isn't) obvious to me - the issue didn't mention the macro in question, i assumed it was `#define alignof(x) __alignof(x)` or similar. Looks like

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

Ris-Bali updated this revision to Diff 518153. Ris-Bali added a comment. Clang-format fix CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149514/new/ https://reviews.llvm.org/D149514 Files: clang/lib/Sema/SemaChecking.cpp Index: clang/lib/Sema/SemaChecking.cpp ===

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

HerrCai0907 created this revision. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixed: https://github.com/llvm/llvm-project/issues/62408 `setInvalidDecl` for invalid `CXXDeductionGuideDecl` to avo

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

HerrCai0907 updated this revision to Diff 518155. HerrCai0907 added a comment. add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149516/new/ https://reviews.llvm.org/D149516 Files: clang/docs/ReleaseNotes.rst clang/include/clang/S

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

Ris-Bali updated this revision to Diff 518156. Ris-Bali added a comment. QualType error fix CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149514/new/ https://reviews.llvm.org/D149514 Files: clang/lib/Sema/SemaChecking.cpp Index: clang/lib/Sema/SemaChecking.cpp =

[clang-tools-extra] cb133a4 - [clangd] Hover: Add CalleeArgInfo for constructor expressions

Author: Tom Praschan Date: 2023-04-29T14:37:16+02:00 New Revision: cb133a4629a56f8c8a67fb7549356839917b52f9 URL: https://github.com/llvm/llvm-project/commit/cb133a4629a56f8c8a67fb7549356839917b52f9 DIFF: https://github.com/llvm/llvm-project/commit/cb133a4629a56f8c8a67fb7549356839917b52f9.diff

[PATCH] D147847: [clangd] Hover: Add CalleeArgInfo for constructor expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb133a4629a5: [clangd] Hover: Add CalleeArgInfo for constructor expressions (authored by tom-anders). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147847/ne

[PATCH] D141757: [clangd] allow extracting to variable for complete lambda expressions

5chmidti updated this revision to Diff 518159. 5chmidti added a comment. I took a little break, but here are the changes/fixes: - moved the logic for variables referenced in captures into the visitor - short circuiting the `TraverseLambdaExpression` and using `TraverseLambdaCapture` to handle

[PATCH] D142401: [Clang] Fix a crash when recursively callig a default member initializer.

cor3ntin updated this revision to Diff 518161. cor3ntin added a comment. I don't think this is actually testable, ultimately we may run out of stack any way, the warning (when emitted) even say so. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14240

[clang] bc37be1 - LangRef: Add "dynamic" option to "denormal-fp-math"

Author: Matt Arsenault Date: 2023-04-29T08:44:59-04:00 New Revision: bc37be1855773c1dcf8c6bf577a096a81fd58652 URL: https://github.com/llvm/llvm-project/commit/bc37be1855773c1dcf8c6bf577a096a81fd58652 DIFF: https://github.com/llvm/llvm-project/commit/bc37be1855773c1dcf8c6bf577a096a81fd58652.diff

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

arsenm closed this revision. arsenm added a comment. bc37be1855773c1dcf8c6bf577a096a81fd58652 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142907/new/ https://reviews.llvm.org/D142907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D149518: [clang] Optimize clang::ASTNodeKind::isBaseOf

PiotrZSL created this revision. Herald added subscribers: luismarques, s.egerton, PkmX, simoncook, arichardson. Herald added a project: All. PiotrZSL requested review of this revision. Herald added subscribers: cfe-commits, pcwang-thead. Herald added a project: clang. Create dedicated isBaseOf met

[PATCH] D149518: [clang] Optimize clang::ASTNodeKind::isBaseOf

PiotrZSL added a comment. Lookup matrix gives best result (~-80%), bu it consume lot of memory due to big amount of enumerators (~950). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149518/new/ https://reviews.llvm.org/D149518 ___

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 518166. junaire marked 4 inline comments as done. junaire added a comment. Partially address some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: cl

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire added inline comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:96 + + size_t getEffectivePTUSize() const; + aaron.ballman wrote: > It looks like this can be private? > > Also, just a note (not something you have to deal with in this re

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

mikecrowe marked 12 inline comments as done. mikecrowe added a comment. Thank you for all the review comments. Comment at: clang-tools-extra/clang-tidy/utils/FormatStringConverter.cpp:322 + if (!isRealCharType(Pointee)) +ArgFixes.emplace_back(Arg, "reinterp

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/modernize/printf-to-std-print.rst:73 + printf-style format string and the arguments to be formatted follow + immediately afterwards. + mikecrowe wrote: > Eugene.Zelenk

[PATCH] D148093: [clang][CodeGen] Break up TargetInfo.cpp [5/6]

barannikov88 updated this revision to Diff 518187. barannikov88 added a comment. Upload the correct diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148093/new/ https://reviews.llvm.org/D148093 Files: clang/lib/CodeGen/ABIInfo.h clang/lib/Co

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

shafik added a comment. Thank you for the fix, you need to add a test that exercises the diagnostic you added, I think `clang/test/Sema/builtin-assume-aligned.c` would be the right place to add it. Also please add a release note in `clang/docs/ReleaseNotes.rst` CHANGES SINCE LAST ACTION ht

[PATCH] D148092: [clang][CodeGen] Break up TargetInfo.cpp [4/6]

barannikov88 added a comment. In D148092#4302861 , @efriedma wrote: > Is this supposed to be different from D148093 > ? Yes indeed. I've updated D148093 . Repository: rG LLVM Github

[PATCH] D148089: [clang][CodeGen] Break up TargetInfo.cpp [1/6]

barannikov88 updated this revision to Diff 518188. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148089/new/ https://reviews.llvm.org/D148089 Files: clang/lib/CodeGen/TargetInfo.cpp Index: clang/lib/CodeGen

[PATCH] D148090: [clang][CodeGen] Break up TargetInfo.cpp [2/6]

barannikov88 updated this revision to Diff 518189. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148090/new/ https://reviews.llvm.org/D148090 Files: clang/lib/CodeGen/TargetInfo.cpp Index: clang/lib/CodeGen/

[PATCH] D148091: [clang][CodeGen] Break up TargetInfo.cpp [3/6]

barannikov88 updated this revision to Diff 518190. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148091/new/ https://reviews.llvm.org/D148091 Files: clang/lib/CodeGen/TargetInfo.cpp Index: clang/lib/CodeGen

[PATCH] D148092: [clang][CodeGen] Break up TargetInfo.cpp [4/6]

barannikov88 updated this revision to Diff 518191. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148092/new/ https://reviews.llvm.org/D148092 Files: clang/lib/CodeGen/TargetInfo.cpp Index: clang/lib/CodeGen

[PATCH] D148094: [DRAFT][clang][CodeGen] Break up TargetInfo.cpp [6/6]

barannikov88 updated this revision to Diff 518199. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/lib/CodeGen/ABIInfo.cpp clang/lib/CodeGen/ABIInfoIm

[PATCH] D148094: [DRAFT][clang][CodeGen] Break up TargetInfo.cpp [6/6]

barannikov88 added a comment. Thank you all for taking a look! In D148094#4296346 , @aaron.ballman wrote: > I did not verify that the refactoring didn't change functionality, but > spot-checking did not find any differences. In D148094#4302879

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

akyrtzi added a comment. Hi @craig.topper , this patch is causing a build failure: In file included from /llvm-project/clang/lib/Sema/SemaType.cpp:43: /llvm-project/llvm/include/llvm/TargetParser/RISCVTargetParser.h:32:10: fatal error: 'llvm/TargetParser/RISCVTargetParserDef.inc' file not fo

[PATCH] D147888: Update declaration message of extern linkage

Krishna-13-cyber added a comment. In D147888#4288149 , @Krishna-13-cyber wrote: > I have tried a little modification from my side thinking on a beneficial > note. I will make the changes to all the other test files as well if this > diagnostic represen

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

bolshakov-a updated this revision to Diff 518226. bolshakov-a added a comment. `SmallVector` instead of `std::stack`; fixing formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146386/new/ https://reviews.llvm.org/D146386 Files: clang/lib/AST/MicrosoftMangle.cpp clang/test/Co

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

Ris-Bali updated this revision to Diff 518228. Ris-Bali added a comment. Added test and made changes in ReleaseNotes.rst CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149514/new/ https://reviews.llvm.org/D149514 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaChecking.cpp c

[clang] a479786 - [RISCV][Sema] Add a build dependency on RISCVTargetParserTableGen after D145088.

Author: Craig Topper Date: 2023-04-29T13:33:54-07:00 New Revision: a4797869e73355209206a5175c11bedb14013211 URL: https://github.com/llvm/llvm-project/commit/a4797869e73355209206a5175c11bedb14013211 DIFF: https://github.com/llvm/llvm-project/commit/a4797869e73355209206a5175c11bedb14013211.diff

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

craig.topper added a comment. In D145088#4307772 , @akyrtzi wrote: > Hi @craig.topper , this patch is causing a build failure: > > In file included from /llvm-project/clang/lib/Sema/SemaType.cpp:43: > /llvm-project/llvm/include/llvm/TargetParser/RISCV

[PATCH] D147197: [llvm-docs] Added documentation for the 'neg' operation

oyalesalami abandoned this revision. oyalesalami added a comment. These instructions do not exist anymore, so there is no need for documentation on them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147197/new/ https://reviews.llvm.org/D147197 _

[PATCH] D146490: [Support] On Windows, ensure that UniqueID is really stable

mstorsjo added a comment. In D146490#4307269 , @falhumai96 wrote: > I would like to follow up on this issue whether or not there has been an > update on it. There's no update currently; I think there's some amount of consensus that this approach, whil

[clang] ee9cbe3 - [RISCV] Move RISCV::RVVBitsPerBlock from TargetParser to Support/RISCVISAInfo.h.

Author: Craig Topper Date: 2023-04-29T15:04:55-07:00 New Revision: ee9cbe3548cded885c6409d6dd8a616b515a06d3 URL: https://github.com/llvm/llvm-project/commit/ee9cbe3548cded885c6409d6dd8a616b515a06d3 DIFF: https://github.com/llvm/llvm-project/commit/ee9cbe3548cded885c6409d6dd8a616b515a06d3.diff

[PATCH] D141757: [clangd] allow extracting to variable for lambda expressions

5chmidti added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:178 + // Allow all expressions except partial LambdaExpr selections since we + // don't want to extract from the captures/default arguments of a lambda + if (is

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

shafik added a comment. Thank you for the fix. I have some questions, why don't we always call `CheckDeductionGuideDeclarator` when calling `CXXDeductionGuideDecl::Create`, I felt like perhaps `CheckDeductionGuideDeclarator` should be rolled into `CXXDeductionGuideDecl::Create` but then I noti

[PATCH] D149451: [NVPTX] Add NVPTXCtorDtorLoweringPass to handle global ctors / dtors

jhuber6 updated this revision to Diff 518262. jhuber6 added a comment. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Update to only enable this when in "freestanding" mode. Also add a hash based on the module name to the global. Repository: rG LLVM Github Mono

[clang] 9b1aaaf - Revert "[RISCV] Move RISCV::RVVBitsPerBlock from TargetParser to Support/RISCVISAInfo.h."

Author: Craig Topper Date: 2023-04-29T18:05:56-07:00 New Revision: 9b1aaaf933cfbd1f3061cf9954d50672600b0c8b URL: https://github.com/llvm/llvm-project/commit/9b1aaaf933cfbd1f3061cf9954d50672600b0c8b DIFF: https://github.com/llvm/llvm-project/commit/9b1aaaf933cfbd1f3061cf9954d50672600b0c8b.diff

[PATCH] D148094: [DRAFT][clang][CodeGen] Break up TargetInfo.cpp [6/6]

barannikov88 updated this revision to Diff 518264. barannikov88 added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. - Update references to modified files in non-code files - Add LLVM_LIBRARY_VISIBILITY to classes in header files Repository: rG LLVM Github Mo

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 518265. junaire added a comment. Add unittests for void & member pointers types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Interpret

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 518266. junaire added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h clang/include/clang/Interp

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

Ris-Bali updated this revision to Diff 518274. Ris-Bali added a comment. Herald added subscribers: carlosgalvezp, kbarton, nemanjai. Herald added a project: clang-tools-extra. Removed __builtin_assume_aligned from ignoredbuiltinstest() in clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelin

[PATCH] D149456: Basic documentation of -mrecip=... option

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149456/new/ https://reviews.llvm.org/D149456 ___