[PATCH] D149464: [clang][dataflow] Expose DataflowAnalysisContext from DataflowEnvironment.

ymandel added a comment. In D149464#4306226 , @bazuzi wrote: > Thanks! Seems like you have commit access, Yitzie; could you commit this for > me as "Samira Bazuzi "? Sure. Let's wait til Gabor approves, but then I'll go ahead. Repository: rG LLVM Gi

[PATCH] D149464: [clang][dataflow] Expose DataflowAnalysisContext from DataflowEnvironment.

xazax.hun accepted this revision. xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:189 + /// Deprecated. Use *getDataflowAnalysisContext().getOptions().Log instead. Logger &logger() const { return *DACtx->getOptio

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void marked an inline comment as done. void added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4170 +private: + mutable SmallVector CountFieldRanges; +public: nickdesaulniers wrote: > `mutable`...my least favorite keyword in C++. I

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void updated this revision to Diff 518013. void marked an inline comment as done. void added a comment. Fix the way the source ranges are imported via the ASTImporter. Do other minor fixes according to feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[clang] 4faf3fc - [NFC][CLANG] Fix coverity remarks about large copy by values

Author: Manna, Soumi Date: 2023-04-28T12:17:10-07:00 New Revision: 4faf3fcf3fb253cb3e68d6ae7b124e7a39f9ccff URL: https://github.com/llvm/llvm-project/commit/4faf3fcf3fb253cb3e68d6ae7b124e7a39f9ccff DIFF: https://github.com/llvm/llvm-project/commit/4faf3fcf3fb253cb3e68d6ae7b124e7a39f9ccff.diff

[PATCH] D149163: [NFC][CLANG] Fix coverity remarks about large copy by values

This revision was automatically updated to reflect the committed changes. Manna marked 3 inline comments as done. Closed by commit rG4faf3fcf3fb2: [NFC][CLANG] Fix coverity remarks about large copy by values (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D149380: [clang] Add -Wunused-result-always warning

gpanders updated this revision to Diff 518024. gpanders added a comment. Remove cast to (void) in unused-expr.c This cast is not necessary for this test, because foo does not have a "warn_unused_result" attribute and is not marked const or pure. Removing the cast improves the usefuless of the tes

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

bolshakov-a added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:1250 + for (unsigned I = 1, IE = ID->getChainingSize(); I < IE; ++I) +mangleSourceName(""); + efriedma wrote: > Weird indentation I agree. Don't know why clang-format do

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

efriedma added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:1250 + for (unsigned I = 1, IE = ID->getChainingSize(); I < IE; ++I) +mangleSourceName(""); + bolshakov-a wrote: > efriedma wrote: > > Weird indentation > I agree. Don't kn

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

bolshakov-a added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:1250 + for (unsigned I = 1, IE = ID->getChainingSize(); I < IE; ++I) +mangleSourceName(""); + efriedma wrote: > bolshakov-a wrote: > > efriedma wrote: > > > Weird indent

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

rjmccall added a comment. Thanks, a couple very minor fixes / requests, but feel free to commit afterwards. Comment at: clang/include/clang/Basic/AttrDocs.td:2323 + let Content = [{ +The ``riscv_rvv_vector_bits(N)`` attribute is used to define fixed-length +variants of sizele

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

efriedma added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:1250 + for (unsigned I = 1, IE = ID->getChainingSize(); I < IE; ++I) +mangleSourceName(""); + bolshakov-a wrote: > efriedma wrote: > > bolshakov-a wrote: > > > efriedma wro

[PATCH] D149436: [clang] Do not attempt to zero-extend _BitInt(1) when not required

shafik accepted this revision. shafik added a comment. LGTM Comment at: clang/test/CodeGen/ext-int.c:8 +unsigned _BitInt(1) GlobSize1 = 0; +// CHECK: @GlobSize1 = {{.*}}global i1 false + Interesting, it looks like `true` and `false` are valid for `i1` all the t

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

ayzhao updated this revision to Diff 518044. ayzhao added a comment. add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148274/new/ https://reviews.llvm.org/D148274 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Diagn

[PATCH] D149272: [clang] Call printName to get name of Decl

dankm updated this revision to Diff 518050. dankm added a comment. Rebase & add add release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149272/new/ https://reviews.llvm.org/D149272 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/Decl.

[PATCH] D149272: [clang] Call printName to get name of Decl

dankm added a comment. In D149272#4306103 , @aaron.ballman wrote: > LGTM, but please add a release note when landing. Thanks, I do not have permission to land, are you able to? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

bolshakov-a added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:1250 + for (unsigned I = 1, IE = ID->getChainingSize(); I < IE; ++I) +mangleSourceName(""); + efriedma wrote: > bolshakov-a wrote: > > efriedma wrote: > > > bolshakov-a

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

bolshakov-a added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:1250 + for (unsigned I = 1, IE = ID->getChainingSize(); I < IE; ++I) +mangleSourceName(""); + bolshakov-a wrote: > efriedma wrote: > > bolshakov-a wrote: > > > efriedma

[PATCH] D149389: [clang] Fix default initializers being ignored when initializing templated aggregate types

ayzhao updated this revision to Diff 518054. ayzhao added a comment. rebase + add release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149389/new/ https://reviews.llvm.org/D149389 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaIn

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

efriedma added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:1250 + for (unsigned I = 1, IE = ID->getChainingSize(); I < IE; ++I) +mangleSourceName(""); + bolshakov-a wrote: > bolshakov-a wrote: > > efriedma wrote: > > > bolshakov-a

[PATCH] D149389: [clang] Fix default initializers being ignored when initializing templated aggregate types

ayzhao added a comment. In D149389#4303966 , @shafik wrote: > So the change makes sense but the original issue: > https://github.com/llvm/llvm-project/issues/62266 it worked for the first > once but not the second, it also worked for the non-paren aggre

[PATCH] D149492: [clang] makes built-in traits match their stdlib counterparts' names

cjdb created this revision. cjdb added reviewers: rsmith, aaron.ballman. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The original names apparently broke convention by not making them the same as the C++

[PATCH] D148601: [Clang] Handle Error message to output proper Prefix

Unique_Usman added a comment. In D148601#4301977 , @aaron.ballman wrote: > Thank you for working on this! These changes should come with test coverage > (we have a handful of verifier tests in `clang/test/Frontend` -- you can add > a new test file ther

[PATCH] D149495: Add sifive-x280 processor and support V extenstion in SiFive7

michaelmaitland created this revision. michaelmaitland added reviewers: craig.topper, kito-cheng, reames, pcwang-thead. Herald added subscribers: luke, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng

[PATCH] D149497: [RISCV] Add scheduling information for Zba and Zbb to RISCVSchedSiFive7.td

michaelmaitland created this revision. michaelmaitland added reviewers: craig.topper, kito-cheng, reames. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, Martin

[PATCH] D149495: [RISCV] Add sifive-x280 processor and support V extenstion in SiFive7

michaelmaitland updated this revision to Diff 518086. michaelmaitland added a comment. Remove zfh from x280 check in `clang/test/Driver/riscv-cpus.c` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149495/new/ https://reviews.llvm.org/D149495 Files:

[PATCH] D149498: [RISCV] Add Scheduling information for Zfh to SiFive7 model

michaelmaitland updated this revision to Diff 518089. michaelmaitland added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add zfh to `clang/test/Driver/riscv-cpus.c` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D147847: [clangd] Hover: Add CalleeArgInfo for constructor expressions

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147847/new/ https://reviews.llvm.org/D147847 ___

[PATCH] D149498: [RISCV] Add Scheduling information for Zfh to SiFive7 model

craig.topper added inline comments. Comment at: clang/test/Driver/riscv-cpus.c:176 // MCPU-SIFIVE-X280-SAME: "-target-feature" "+zicsr" "-target-feature" "+zifencei" +// MCPU-SIFIVE-X280-SAME: "-target-feature" "+zfh" // MCPU-SIFIVE-X280-SAME: "-target-feature" "+zba" "-target

[PATCH] D149497: [RISCV] Add scheduling information for Zba and Zbb to RISCVSchedSiFive7.td

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVProcessors.td:181 + FeatureStdExtZvfh, + FeatureStdExtZba, + FeatureStdExtZbb], ---

[PATCH] D149497: [RISCV] Add scheduling information for Zba and Zbb to RISCVSchedSiFive7.td

michaelmaitland marked an inline comment as done. michaelmaitland added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVProcessors.td:181 + FeatureStdExtZvfh, + FeatureStdExtZba, +

[PATCH] D149498: [RISCV] Add Scheduling information for Zfh to SiFive7 model

michaelmaitland added inline comments. Comment at: clang/test/Driver/riscv-cpus.c:176 // MCPU-SIFIVE-X280-SAME: "-target-feature" "+zicsr" "-target-feature" "+zifencei" +// MCPU-SIFIVE-X280-SAME: "-target-feature" "+zfh" // MCPU-SIFIVE-X280-SAME: "-target-feature" "+zba" "-tar

[PATCH] D149497: [RISCV] Add scheduling information for Zba and Zbb to RISCVSchedSiFive7.td

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149497/new/ https://reviews.llvm.org/D149497 ___

[PATCH] D149498: [RISCV] Add Scheduling information for Zfh to SiFive7 model

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149498/new/ https://reviews.llvm.org/D149498 ___

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void updated this revision to Diff 518106. void added a comment. Change sanitizer scope because instructions may be created. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files: clang/include/clang/Ba

[PATCH] D149504: [clang][CodeGenPGO] Don't use an invalid index when region counts disagree

lanza created this revision. lanza added a reviewer: bruno. Herald added subscribers: wlei, wenlei, arphaman. Herald added a project: All. lanza requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If we're using an old instrprof profile and the

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148274/new/ https://reviews.llvm.org/D148274 ___

[PATCH] D149504: [clang][CodeGenPGO] Don't use an invalid index when region counts disagree

lanza added a comment. Actually, this still is consumed even without that flag being passed. Anybody know the rational for not having at least an llvm major version check here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149504/new/ https://revi

[PATCH] D149389: [clang] Fix default initializers being ignored when initializing templated aggregate types

shafik added a comment. In D149389#4306605 , @ayzhao wrote: > In D149389#4303966 , @shafik wrote: > >> So the change makes sense but the original issue: >> https://github.com/llvm/llvm-project/issues/62266 it wor

[clang] e52a8b8 - [NFC][clang] Fix static analyzer concerns about AUTO_CAUSES_COPY

Author: Manna, Soumi Date: 2023-04-28T18:58:55-07:00 New Revision: e52a8b89addaec496fd726a3a90bcf82d42065c9 URL: https://github.com/llvm/llvm-project/commit/e52a8b89addaec496fd726a3a90bcf82d42065c9 DIFF: https://github.com/llvm/llvm-project/commit/e52a8b89addaec496fd726a3a90bcf82d42065c9.diff

[PATCH] D148639: [NFC][clang] Fix static analyzer concerns about AUTO_CAUSES_COPY

This revision was automatically updated to reflect the committed changes. Closed by commit rGe52a8b89adda: [NFC][clang] Fix static analyzer concerns about AUTO_CAUSES_COPY (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148639/new/

[PATCH] D149389: [clang] Fix default initializers being ignored when initializing templated aggregate types

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149389/new/ https://reviews.llvm.org/D149389 ___

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 518118. chaitanyav added a comment. Rebase with upstream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/Sema

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan added a comment. Haha. My bad for misunderstanding. > I think rather if the common ancestor isn't completely selected, evaluation > shouldn't happen. I don't think it is a feasible approach to simply opt out of partial selection. Please consider this snippet: #define SizeOf sizeof

[PATCH] D146490: [Support] On Windows, ensure that UniqueID is really stable

falhumai96 added a comment. Hello devs, I would like to follow up on this issue whether or not there has been an update on it. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146490/new/ https://reviews.llvm.org/D146490 __

<    1   2