[PATCH] D148276: [clang] trigger -Wcast-qual on functional casts

2023-04-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D148276#4287900 , @thurston wrote: > I think this change is triggering an error on a buildbot > (https://lab.llvm.org/buildbot/#/builders/37/builds/21631/steps/20/logs/stdio): > > > /b/sanitizer-x86_64-linux/build/llv

[PATCH] D148276: [clang] trigger -Wcast-qual on functional casts

2023-04-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D148276#4287931 , @aaron.ballman wrote: > In D148276#4287900 , @thurston > wrote: > >> I think this change is triggering an error on a buildbot >> (https://lab.llvm.org/buildbo

[clang] 7f00ecd - Revert "[clang] trigger -Wcast-qual on functional casts"

2023-04-21 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2023-04-21T13:33:39-04:00 New Revision: 7f00ecd029213aee9baf297554b0cb25a5ffbd0f URL: https://github.com/llvm/llvm-project/commit/7f00ecd029213aee9baf297554b0cb25a5ffbd0f DIFF: https://github.com/llvm/llvm-project/commit/7f00ecd029213aee9baf297554b0cb25a5ffbd0f.diff

[PATCH] D148276: [clang] trigger -Wcast-qual on functional casts

2023-04-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman reopened this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Reverted in 7f00ecd029213aee9baf297554b0cb25a5ffbd0f Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D137258: [clang] Optimize storage and lookup of analyzer options

2023-04-21 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 added a comment. Sorting at compile-time would be nicer, but I don't have the bandwidth to implement something like that. I'll leave a FIXME in case someone wants to pick it up. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[clang] 53a4a2b - [clang] NFCI: Optimize storage and lookup of analyzer options

2023-04-21 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-04-21T10:39:55-07:00 New Revision: 53a4a2b45bb2407f3249dea54f1a8b3e230b188a URL: https://github.com/llvm/llvm-project/commit/53a4a2b45bb2407f3249dea54f1a8b3e230b188a DIFF: https://github.com/llvm/llvm-project/commit/53a4a2b45bb2407f3249dea54f1a8b3e230b188a.diff L

[PATCH] D137258: [clang] Optimize storage and lookup of analyzer options

2023-04-21 Thread Jan Svoboda via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG53a4a2b45bb2: [clang] NFCI: Optimize storage and lookup of analyzer options (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D137258?vs=515455&id=515828#toc Repository: r

[PATCH] D148945: [clang] Remove workaround for old LLVM_ENABLE_PROJECTS=libcxx build

2023-04-21 Thread Louis Dionne via Phabricator via cfe-commits
ldionne created this revision. Herald added a project: All. ldionne requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. We don't support the LLVM_ENABLE_PROJECTS=libcxx build anymore (and have not for over a year), so it should be fine

[PATCH] D148945: [clang] Remove workaround for old LLVM_ENABLE_PROJECTS=libcxx build

2023-04-21 Thread Louis Dionne via Phabricator via cfe-commits
ldionne added subscribers: phosek, Ericson2314, aaron.ballman. ldionne added a comment. CCing some folks that were watching D132324 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148945/new/ https://reviews.llvm.o

[PATCH] D146987: [Assignment Tracking] Enable by default

2023-04-21 Thread Steven Johnson via Phabricator via cfe-commits
srj added a comment. In D146987#4287847 , @srj wrote: > In D146987#4287819 , @jmorse wrote: > >> Should have been reverted in rG0ba922f60046 >>

[clang] ea0dae0 - [RISCV] Add Tag_RISCV_arch attribute by default when using clang as an assembler.

2023-04-21 Thread Craig Topper via cfe-commits
Author: Craig Topper Date: 2023-04-21T10:54:24-07:00 New Revision: ea0dae0961897da69b960caf68063db86312674d URL: https://github.com/llvm/llvm-project/commit/ea0dae0961897da69b960caf68063db86312674d DIFF: https://github.com/llvm/llvm-project/commit/ea0dae0961897da69b960caf68063db86312674d.diff

[PATCH] D148817: [RISCV] Add Tag_RISCV_arch attribute by default when using clang as an assembler.

2023-04-21 Thread Craig Topper via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGea0dae096189: [RISCV] Add Tag_RISCV_arch attribute by default when using clang as an… (authored by craig.topper). Changed prior to commit: https:/

[clang] 6b80f00 - [clang][deps] NFC: Refactor and comment ModuleDeps sorting

2023-04-21 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-04-21T10:56:42-07:00 New Revision: 6b80f00bac6a4832af4f8ebde96564690a35f7e1 URL: https://github.com/llvm/llvm-project/commit/6b80f00bac6a4832af4f8ebde96564690a35f7e1 DIFF: https://github.com/llvm/llvm-project/commit/6b80f00bac6a4832af4f8ebde96564690a35f7e1.diff L

[PATCH] D145197: [clang][deps] NFC: Refactor and comment ModuleDeps sorting

2023-04-21 Thread Jan Svoboda via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b80f00bac6a: [clang][deps] NFC: Refactor and comment ModuleDeps sorting (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D148945: [clang] Remove workaround for old LLVM_ENABLE_PROJECTS=libcxx build

2023-04-21 Thread Petr Hosek via Phabricator via cfe-commits
phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148945/new/ https://reviews.llvm.org/D148945 ___

[PATCH] D148945: [clang] Remove workaround for old LLVM_ENABLE_PROJECTS=libcxx build

2023-04-21 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Related: D122444 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148945/new/ https://reviews.llvm.org/D148945 ___ cfe-commits mailing list cfe-co

[PATCH] D148757: [clang] Follow user-provided order for prefix map

2023-04-21 Thread Petr Hosek via Phabricator via cfe-commits
phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148757/new/ https://reviews.llvm.org/D148757 ___

[PATCH] D148276: [clang] trigger -Wcast-qual on functional casts

2023-04-21 Thread Jorge Pinto Sousa via Phabricator via cfe-commits
sousajo added a comment. hey :( I will try to investigate it a bit sometime next week ^^ thanks for pointing it out Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148276/new/ https://reviews.llvm.org/D148276 ___

[PATCH] D148835: [clang] removes trailing whitespace

2023-04-21 Thread Christopher Di Bella via Phabricator via cfe-commits
cjdb added a comment. In D148835#4286924 , @aaron.ballman wrote: > In D148835#4286905 , @erichkeane > wrote: > >> In D148835#4284871 , @cjdb wrote: >> >>> I've had some

[PATCH] D147888: Update declaration message of extern linkage

2023-04-21 Thread Krishna Narayanan via Phabricator via cfe-commits
Krishna-13-cyber updated this revision to Diff 515843. Krishna-13-cyber added a comment. I have tried a little modification from my side thinking on a beneficial note. I will make the changes to all the other test files as well if this diagnostic representation goes well after mentor review. Fo

[PATCH] D148835: [clang] removes trailing whitespace

2023-04-21 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In D148835#4288148 , @cjdb wrote: > In D148835#4286924 , @aaron.ballman > wrote: > >> In D148835#4286905 , @erichkeane >> wrote: >> >>> In D1

cfe-commits@lists.llvm.org

2023-04-21 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added inline comments. Comment at: clang/test/CXX/class/class.compare/class.compare.default/p1.cpp:18 bool operator<=(const A&) const = default; - bool operator==(const A&) const volatile && = default; // surprisingly, OK + bool operator==(const A&) const && = default

[PATCH] D142569: [OpenMP] Introduce kernel environment

2023-04-21 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 515854. tianshilei1992 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/ https://reviews.llvm.org/D142569 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/test/H

[PATCH] D148276: [clang] trigger -Wcast-qual on functional casts

2023-04-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D148276#4288145 , @sousajo wrote: > hey :( I will try to investigate it a bit sometime next week ^^ thanks for > pointing it out Thank you for looking into it! I didn't think about `remove_const`, `remove_cv`, etc. whe

[PATCH] D129835: [clang] adds a discardable attribute

2023-04-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. In D129835#4287866 , @cjdb wrote: >>> With [[discardable]] one just needs to push/pop at the extremes of a file >>> (and if a future version of module maps supports global pragmas

[PATCH] D148944: [clang][Driver] Fix crash with unsupported architectures in MinGW and CrossWindows.

2023-04-21 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. Thank you for this fix. Can you please add a summary in the details explaining the motivation for this fix and a link to the github bug report as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148944/new/ https://revie

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

2023-04-21 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. I'm having trouble understanding the changes on the clang side. If I'm following correctly; the "denormal-fp-math" setting is a promise from the user to the compiler: if the setting is not "dynamic", the user promises that the definition will only execute in the specif

[PATCH] D148835: [clang] removes trailing whitespace

2023-04-21 Thread Sam Clegg via Phabricator via cfe-commits
sbc100 added a comment. In D148835#4288151 , @erichkeane wrote: > In D148835#4288148 , @cjdb wrote: > >> In D148835#4286924 , >> @aaron.ballman wrote: >> >>> In D148835#

[PATCH] D129835: [clang] adds a discardable attribute

2023-04-21 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In D129835#4288240 , @aaron.ballman wrote: > In D129835#4287866 , @cjdb wrote: > With [[discardable]] one just needs to push/pop at the extremes of a file (and if a future v

[PATCH] D148276: [clang] trigger -Wcast-qual on functional casts

2023-04-21 Thread Jorge Pinto Sousa via Phabricator via cfe-commits
sousajo added a comment. In D148276#4288236 , @aaron.ballman wrote: > In D148276#4288145 , @sousajo wrote: > >> hey :( I will try to investigate it a bit sometime next week ^^ thanks for >> pointing it out > > T

[PATCH] D148949: [dataflow] HTMLLogger - show the value of the current expr

2023-04-21 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https

[clang] fa2a8c2 - [dataflow] Don't crash in Environment::dump when decls have weird names

2023-04-21 Thread Sam McCall via cfe-commits
Author: Sam McCall Date: 2023-04-21T21:08:26+02:00 New Revision: fa2a8c2e1cdf188ce985d69fca6f78866390b715 URL: https://github.com/llvm/llvm-project/commit/fa2a8c2e1cdf188ce985d69fca6f78866390b715 DIFF: https://github.com/llvm/llvm-project/commit/fa2a8c2e1cdf188ce985d69fca6f78866390b715.diff LO

[PATCH] D148276: [clang] trigger -Wcast-qual on functional casts

2023-04-21 Thread Thurston Dang via Phabricator via cfe-commits
thurston added a comment. Thanks Aaron and Jorge for the quick revert and replies! :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148276/new/ https://reviews.llvm.org/D148276 ___ cfe-commits mailing l

[PATCH] D148951: [dataflow] HTMLLogger: fix off-by-one in the BB listing

2023-04-21 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: mboehme. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The ind

[PATCH] D148951: [dataflow] HTMLLogger: fix off-by-one in the BB listing

2023-04-21 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Before: F27217511: image.png After: F27217508: image.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148951/new/ https://reviews.llvm.org/D148951

cfe-commits@lists.llvm.org

2023-04-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Precommit CI found a relevant failure that should be addressed. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:8593 +const FunctionProtoType *FnType = FD->getType()->castAs(); +if (FnType->isVolatile()) { ilya-biryukov wrot

[PATCH] D142569: [OpenMP] Introduce kernel environment

2023-04-21 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 515876. tianshilei1992 added a comment. update more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/ https://reviews.llvm.org/D142569 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp c

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

2023-04-21 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. In D142907#4288247 , @efriedma wrote: > Given that, I don't follow the whole "merging" thing... we should just be > setting whatever mode is active. The attribute setting should not depend on > whether the function is interposab

[PATCH] D129835: [clang] adds a discardable attribute

2023-04-21 Thread Christopher Di Bella via Phabricator via cfe-commits
cjdb added a comment. Yeah, in retrospect, I agree (and may need to clean up a few iterator types now, grr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129835/new/ https://reviews.llvm.org/D129835 __

[PATCH] D146777: [clang] Preliminary fat-lto-object support

2023-04-21 Thread Paul Kirth via Phabricator via cfe-commits
paulkirth updated this revision to Diff 515880. paulkirth added a comment. Add relese note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic

[PATCH] D148835: [clang] removes trailing whitespace

2023-04-21 Thread Christopher Di Bella via Phabricator via cfe-commits
cjdb added a comment. In D148835#4288151 , @erichkeane wrote: > In D148835#4288148 , @cjdb wrote: > >> In D148835#4286924 , >> @aaron.ballman wrote: >> >>> In D148835#42

[PATCH] D148954: [clang] Make access to submodules via `iterator_range`

2023-04-21 Thread Sviatoslav Osipov via Phabricator via cfe-commits
Stoorx created this revision. Herald added a project: All. Stoorx requested review of this revision. Herald added projects: clang, clang-tools-extra. In file `clang/lib/Basic/Module.cpp` the `Module` class had `submodule_begin()` and `submodule_end()` functions to retrieve corresponding iterators

[PATCH] D148954: [clang] Make access to submodules via `iterator_range`

2023-04-21 Thread Sviatoslav Osipov via Phabricator via cfe-commits
Stoorx updated this revision to Diff 515892. Stoorx added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148954/new/ https://reviews.llvm.org/D148954 Files: clang-tools-extra/modularize/CoverageChecker.cpp clang-tools-extra/modularize/ModularizeUtilities.cpp clan

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

2023-04-21 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. If you have a library function that's built with "denormal-fp-math"="dynamic,dynamic", you can link it into code built in any mode, and LTO should be able to propagate that mode from the caller to the callee. That doesn't require clang to do anything special; you can

[PATCH] D148954: [clang] Make access to submodules via `iterator_range`

2023-04-21 Thread Petr Hosek via Phabricator via cfe-commits
phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148954/new/ https://reviews.llvm.org/D148954 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D148958: Size and element numbers are often swapped when calling calloc

2023-04-21 Thread Alf via Phabricator via cfe-commits
gAlfonso-bit created this revision. gAlfonso-bit added a reviewer: MaskRay. Herald added a subscriber: Enna1. Herald added projects: Flang, All. gAlfonso-bit requested review of this revision. Herald added subscribers: Sanitizers, cfe-commits, jdoerfert. Herald added projects: clang, Sanitizers. T

[PATCH] D146777: [clang] Preliminary fat-lto-object support

2023-04-21 Thread Paul Kirth via Phabricator via cfe-commits
paulkirth updated this revision to Diff 515910. paulkirth added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/CodeGenOp

[PATCH] D148960: [Clang][AIX] Add back error for -fprofile-sample-generate/use on AIX

2023-04-21 Thread Zarko Todorovski via Phabricator via cfe-commits
ZarkoCA created this revision. ZarkoCA added reviewers: qiongsiwu1, w2yehia. Herald added a project: All. ZarkoCA requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. D148177 also removed the error for

[PATCH] D148961: [clang] Remove unnecessary virtual inheritance in `TargetInfo`

2023-04-21 Thread Sviatoslav Osipov via Phabricator via cfe-commits
Stoorx created this revision. Herald added a project: All. Stoorx requested review of this revision. Herald added a project: clang. Since the `TargetInfo` has no diamond-like inheritance diagram, the `virtual` keyword is not necessary. Repository: rG LLVM Github Monorepo https://reviews.llvm.

[PATCH] D148954: [clang] Make access to submodules via `iterator_range`

2023-04-21 Thread Sviatoslav Osipov via Phabricator via cfe-commits
Stoorx added a comment. Can you commit it? I have no commit access. Stoorx me[at]stoorx.one CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148954/new/ https://reviews.llvm.org/D148954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D148962: [RISCV] Make Zicntr and Zihpm imply Zicsr.

2023-04-21 Thread Craig Topper via Phabricator via cfe-commits
craig.topper created this revision. craig.topper added reviewers: asb, reames, kito-cheng, jrtc27. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, Ma

[PATCH] D148960: [Clang][AIX] Add back error for -fprofile-sample-generate/use on AIX

2023-04-21 Thread Qiongsi Wu via Phabricator via cfe-commits
qiongsiwu1 accepted this revision. qiongsiwu1 added a comment. This revision is now accepted and ready to land. Thanks for the fix Zarko! LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148960/new/ https://reviews.llvm.org/D148960

[PATCH] D148958: Size and element numbers are often swapped when calling calloc

2023-04-21 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. This is an unnecessary change. In musl, there are at least 2 places where the parameters could be swapped, but I not unsure this warrants a commit. Repository: rG LLVM Github Mo

[PATCH] D134475: [Clang] Add support for [[msvc::constexpr]] C++11 attribute

2023-04-21 Thread Richard Dzenis via Phabricator via cfe-commits
RIscRIpt planned changes to this revision. RIscRIpt marked 2 inline comments as done. RIscRIpt added a comment. > Does it prohibit the inverse? I think this documentation overall needs a > much better description of what the semantics are here, particularly anything > that you found in experime

[PATCH] D148958: Size and element numbers are often swapped when calling calloc

2023-04-21 Thread Slava Zakharin via Phabricator via cfe-commits
vzakhari added a comment. In D148958#4288728 , @MaskRay wrote: > This is an unnecessary change. The arguments are interchangeable. > In musl, there are at least 2 places where the parameters could be swapped, > but I not unsure this warrants a commit. I

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

2023-04-21 Thread Han Zhu via Phabricator via cfe-commits
zhuhan0 added a comment. Hi, I have just got the time to come back to https://reviews.llvm.org/D147823, but I wanna check here first if you guys have any fix in flight? In addition to the linking issue, we also encountered the "cstdio" not found issue as mentioned above. Repository: rG LLVM

[PATCH] D131618: [clang][llvm][lld] FatLTO Prototype

2023-04-21 Thread Paul Kirth via Phabricator via cfe-commits
paulkirth abandoned this revision. paulkirth added a comment. This can be abandoned in favor of https://reviews.llvm.org/D146776, https://reviews.llvm.org/D146777, and https://reviews.llvm.org/D146778 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D148961: [clang] Remove unnecessary virtual inheritance in `TargetInfo`

2023-04-21 Thread Petr Hosek via Phabricator via cfe-commits
phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148961/new/ https://reviews.llvm.org/D148961 ___

[PATCH] D148967: WIP: Disable atexit()-based lowering when LTO'ing kernel/kext code

2023-04-21 Thread Julian Lettner via Phabricator via cfe-commits
yln created this revision. Herald added subscribers: llvm-commits, cfe-commits, ormris, steven_wu, hiraditya, inglorion. Herald added projects: clang, LLVM, All. yln requested review of this revision. Herald added a subscriber: MaskRay. rdar://93536111 Repository: rG LLVM Github Monorepo htt

[PATCH] D148958: Size and element numbers are often swapped when calling calloc

2023-04-21 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D148958#4288782 , @vzakhari wrote: > In D148958#4288728 , @MaskRay wrote: > >> This is an unnecessary change. The arguments are interchangeable. >> In musl, there are at least 2 places

[PATCH] D148757: [clang] Follow user-provided order for prefix map

2023-04-21 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D148757#4285735 , @gulfem wrote: > I compared Clang and GCC behavior. > **1) Following user-specified prefix mapping order** > GCC uses a linked list to store the prefix mappings, so it applies the prefix > mappings based on t

[PATCH] D148444: [clang-tidy] Prevent `llvmlibc-inline-function-decl` triggering on lambdas

2023-04-21 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. > Additionally, lambdas are always going to have internal linkage so they will > not differ accross TUs. This isn't true - if a lambda appears in a header in any way, it probably has linkage the same as an inline function, not internal. (eg: a lambda inside an inline

[PATCH] D148757: [clang] Follow user-provided order for prefix map

2023-04-21 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Created https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109591 to discuss GCC's behavior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148757/new/ https://reviews.llvm.org/D148757 ___

[PATCH] D148757: [clang] Follow user-provided order for prefix map

2023-04-21 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. I wasn't aware that `debug-prefix-map` prefers longest prefix. I agree that ideally `coverage-prefix-map`, `debug-prefix-map` and `macro-prefix-map` should be consistent across all LLVM tools and ideally also across compilers. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D148757: [clang] Follow user-provided order for prefix map

2023-04-21 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. I'm creating a patch to change DebugPrefixMap to respect the command line option order... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148757/new/ https://reviews.llvm.org/D148757

[PATCH] D148975: -fdebug-prefix-map=: make the last win when multiple prefixes match

2023-04-21 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay created this revision. MaskRay added reviewers: debug-info, dankm, gulfem, phosek. Herald added subscribers: hiraditya, emaste. Herald added a project: All. MaskRay requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, jp

[PATCH] D148757: [clang] Follow user-provided order for prefix map

2023-04-21 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D148757#4289076 , @MaskRay wrote: > I'm creating a patch to change DebugPrefixMap to respect the command line > option order... Created D148975 to follow GCC's behavior (the last applicable

[PATCH] D148975: -fdebug-prefix-map=: make the last win when multiple prefixes match

2023-04-21 Thread Joerg Sonnenberger via Phabricator via cfe-commits
joerg added a comment. For me long matching prefix makes more sense, but if the same prefix is used multiple times, the last option should win. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148975/new/ https://reviews.llvm.org/D148975 ___

[PATCH] D147844: Emit warning when implicit cast from int to bool happens in an conditional operator expression

2023-04-21 Thread NagaChaitanya Vellanki via Phabricator via cfe-commits
chaitanyav updated this revision to Diff 515974. chaitanyav marked an inline comment as done. chaitanyav added a comment. Modify the commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files:

[PATCH] D147844: [clang][Sema]Print diagnostic warning when implicit cast from int to bool happens in an conditional operator expression

2023-04-21 Thread NagaChaitanya Vellanki via Phabricator via cfe-commits
chaitanyav updated this revision to Diff 515978. chaitanyav added a comment. Revise commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/Sem

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

2023-04-21 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added inline comments. Herald added a subscriber: bviyer. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1533 +ompLoc, builder.saveIP(), mapTypeFlags, mapNames, mapperAllocas, +mapperFunc, deviceID, ifCond, processMapO

[PATCH] D148981: [clang][Interp] PointerToBoolean casts

2023-04-21 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Just emit `p != nullptr` for this. Repository:

[clang] 57304bb - [clang][Sema][NFC] Add const where appropriate

2023-04-21 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-04-22T08:28:27+02:00 New Revision: 57304bbda20014b23d5c706f99fefec7b5f6a31c URL: https://github.com/llvm/llvm-project/commit/57304bbda20014b23d5c706f99fefec7b5f6a31c DIFF: https://github.com/llvm/llvm-project/commit/57304bbda20014b23d5c706f99fefec7b5f6a31c.diff LO

[PATCH] D147989: [clang] Fix Attribute Placement

2023-04-21 Thread Priyanshi Agarwal via Phabricator via cfe-commits
ipriyanshi1708 updated this revision to Diff 516036. ipriyanshi1708 added a comment. Added case for enum struct Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/ https://reviews.llvm.org/D147989 Files: clang/docs/ReleaseNotes.rst clang

<    1   2