[PATCH] D147989: Fix Attribute Placememt

ipriyanshi1708 updated this revision to Diff 512343. ipriyanshi1708 added a comment. Removed extra lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/ https://reviews.llvm.org/D147989 Files: clang/include/clang/Basic/DiagnosticSemaKi

[PATCH] D147876: [clang-tidy] Support specifying checks as a list in the config file

njames93 added a comment. In D147876#4257197 , @carlosgalvezp wrote: > In D147876#4256182 , @njames93 > wrote: > >> with checked in configuration files > > I'm not sure I understand what you mean by "checked in"

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 updated this revision to Diff 512344. ipriyanshi1708 retitled this revision from "Fix Attribute Placememt" to "[clang] Fix Attribute Placement". ipriyanshi1708 added a comment. Updated the title Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D147779: [clang-tidy] Fix hungarian notation failed to indicate the number of asterisks in check-clang-extra-clang-tidy-checkers-readability

PiotrZSL added a comment. arc land should work, I usually use arc patch --nobranch to check things before committing and then git push. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147779/new/ https://reviews.llvm.org/D147779 ___

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

PiotrZSL added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/forwarding-reference-param-not-forwarded.cpp:138 + +} // namespace negative_cases ccotter wrote: > ccotter wrote: > > PiotrZSL wrote: > > > what about when s

[clang-tools-extra] cebdf20 - [clang-tidy] Use StringRef::contains (NFC)

Author: Kazu Hirata Date: 2023-04-10T23:33:47-07:00 New Revision: cebdf206caad921ab4b1d231d90e42ed60d5998e URL: https://github.com/llvm/llvm-project/commit/cebdf206caad921ab4b1d231d90e42ed60d5998e DIFF: https://github.com/llvm/llvm-project/commit/cebdf206caad921ab4b1d231d90e42ed60d5998e.diff L

[PATCH] D147894: [clang-format] SortIncludes documentation: remove contradiction in its description

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Yes I didn’t see them repeated below CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147894/new/ https://reviews.llvm.org/D147894 __

[clang-tools-extra] 65d20e3 - [clang-tidy] Fix hungarian notation failed to indicate the number of asterisks in check-clang-extra-clang-tidy-checkers-readability

Author: Douglas Chen Date: 2023-04-11T06:43:07Z New Revision: 65d20e3296909169405f9286d2a2177a42789e06 URL: https://github.com/llvm/llvm-project/commit/65d20e3296909169405f9286d2a2177a42789e06 DIFF: https://github.com/llvm/llvm-project/commit/65d20e3296909169405f9286d2a2177a42789e06.diff LOG:

[PATCH] D147779: [clang-tidy] Fix hungarian notation failed to indicate the number of asterisks in check-clang-extra-clang-tidy-checkers-readability

This revision was automatically updated to reflect the committed changes. Closed by commit rG65d20e329690: [clang-tidy] Fix hungarian notation failed to indicate the number of asterisks… (authored by dougpuob, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 updated this revision to Diff 512349. ipriyanshi1708 edited the summary of this revision. ipriyanshi1708 added a comment. Updated the summary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/ https://reviews.llvm.org/D147989

[PATCH] D147946: [clang-tidy] support nested inline namespace in c++20 for modernize-concat-nested-namespaces

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM, just some style comments. Comment at: clang-tools-extra/clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp:84-86 + Str.append(ND->getName()); +} else +

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

PiotrZSL accepted this revision. PiotrZSL added a comment. Any plans in delivering this ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146922/new/ https://reviews.llvm.org/D146922 ___ cfe-commits mailin

<    1   2   3