[clang] 3c8ead2 - [clang][dataflow] Eliminate code duplication in Environment::createValueUnlessSelfReferential().

Author: Martin Braenne Date: 2023-04-06T07:01:44Z New Revision: 3c8ead2662ac4a223467007c340c9f9a4b2b38af URL: https://github.com/llvm/llvm-project/commit/3c8ead2662ac4a223467007c340c9f9a4b2b38af DIFF: https://github.com/llvm/llvm-project/commit/3c8ead2662ac4a223467007c340c9f9a4b2b38af.diff LOG

[PATCH] D147601: [clang][dataflow] Eliminate code duplication in Environment::createValueUnlessSelfReferential().

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3c8ead2662ac: [clang][dataflow] Eliminate code duplication in Environment… (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SIN

[clang] 616c806 - [C++20] [Coroutines] Handle function-try-block in SemaCoroutine

Author: Chuanqi Xu Date: 2023-04-06T15:11:34+08:00 New Revision: 616c8067071316a9e17524b14b3ab0e04a511e71 URL: https://github.com/llvm/llvm-project/commit/616c8067071316a9e17524b14b3ab0e04a511e71 DIFF: https://github.com/llvm/llvm-project/commit/616c8067071316a9e17524b14b3ab0e04a511e71.diff LO

[PATCH] D147684: [clangd] Add batch fixes for include-cleaner diagnostics

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: arphaman, mgrang. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. For each unused-include/m

[PATCH] D147684: [clangd] Add batch fixes for include-cleaner diagnostics

hokein added a comment. The UI in VSCode looks like - unused-include: F27034770: image.png - missing-include: F27034749: image.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

zhuhan0 added subscribers: ayermolo, zhuhan0. zhuhan0 added a comment. Hi @argentite, we build llvm in a custom distro which is missing some C startup code, and this fails with errors like: /abc/bin/ld: cannot find crti.o: No such file or directory /abc/bin/ld: cannot find crtbeginS.o: No su

[PATCH] D147603: [clang][dataflow] Use `isRecordType()` where appropriate.

mboehme added a comment. Failing CodeGen test in premerge check appears to be a pre-existing failure. (I'm not touching anything related to CodeGen here.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147603/new/ https://reviews.llvm.org/D147603

[clang] effdfa7 - [clang][dataflow] Use `isRecordType()` where appropriate.

Author: Martin Braenne Date: 2023-04-06T07:26:24Z New Revision: effdfa7d5f49b00b4c0d36f7c6835b519b0f46bb URL: https://github.com/llvm/llvm-project/commit/effdfa7d5f49b00b4c0d36f7c6835b519b0f46bb DIFF: https://github.com/llvm/llvm-project/commit/effdfa7d5f49b00b4c0d36f7c6835b519b0f46bb.diff LOG

[PATCH] D147603: [clang][dataflow] Use `isRecordType()` where appropriate.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeffdfa7d5f49: [clang][dataflow] Use `isRecordType()` where appropriate. (authored by mboehme). Changed prior to commit: https://reviews.llvm.org/D

[clang] 92417f2 - [clang][Interp] Record initialization via conditional operator

Author: Timm Bäder Date: 2023-04-06T09:44:02+02:00 New Revision: 92417f2d4b1706326717cc5e782f3aa77a7157bb URL: https://github.com/llvm/llvm-project/commit/92417f2d4b1706326717cc5e782f3aa77a7157bb DIFF: https://github.com/llvm/llvm-project/commit/92417f2d4b1706326717cc5e782f3aa77a7157bb.diff LO

[PATCH] D141497: [clang][Interp] Record initialization via conditional operator

This revision was automatically updated to reflect the committed changes. Closed by commit rG92417f2d4b17: [clang][Interp] Record initialization via conditional operator (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141497/new/

[libunwind] a017aef - [libunwind] Fix a typo in a debug log message. NFC.

Author: Martin Storsjö Date: 2023-04-06T11:07:41+03:00 New Revision: a017aefeac9c7128b5fd702098381abc09508e45 URL: https://github.com/llvm/llvm-project/commit/a017aefeac9c7128b5fd702098381abc09508e45 DIFF: https://github.com/llvm/llvm-project/commit/a017aefeac9c7128b5fd702098381abc09508e45.diff

[libunwind] 16857c4 - [libcxxabi, libunwind] [test] Quote the python path properly for LIB*_EXECUTOR

Author: Martin Storsjö Date: 2023-04-06T11:07:41+03:00 New Revision: 16857c4a30da502297ad3ac731ae3fb1a9e5d611 URL: https://github.com/llvm/llvm-project/commit/16857c4a30da502297ad3ac731ae3fb1a9e5d611 DIFF: https://github.com/llvm/llvm-project/commit/16857c4a30da502297ad3ac731ae3fb1a9e5d611.diff

[libunwind] a33d5a9 - [libunwind] Fflush stderr after each log message

Author: Martin Storsjö Date: 2023-04-06T11:07:41+03:00 New Revision: a33d5a9939aa3c0bcdb0f951c0bc4b96071bda2c URL: https://github.com/llvm/llvm-project/commit/a33d5a9939aa3c0bcdb0f951c0bc4b96071bda2c DIFF: https://github.com/llvm/llvm-project/commit/a33d5a9939aa3c0bcdb0f951c0bc4b96071bda2c.diff

[libunwind] b25e989 - [libunwind] [test] Add a mingw specific test config file

Author: Martin Storsjö Date: 2023-04-06T11:07:41+03:00 New Revision: b25e989e68372ab604e6da1934e51344880db87c URL: https://github.com/llvm/llvm-project/commit/b25e989e68372ab604e6da1934e51344880db87c DIFF: https://github.com/llvm/llvm-project/commit/b25e989e68372ab604e6da1934e51344880db87c.diff

[PATCH] D147686: [clangd] Fix a nullptr-dereference crash in computeIncludeCleanerFindings.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Be more robust, we shuold not cr

[PATCH] D147686: [clangd] Fix a nullptr-dereference crash in computeIncludeCleanerFindings.

hokein updated this revision to Diff 511319. hokein added a comment. add a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147686/new/ https://reviews.llvm.org/D147686 Files: clang-tools-extra/clangd/IncludeCleaner.cpp clang-tools-extra

[clang] 4016e5d - [clang][Interp][NFC] Call emit*Ptr directly

Author: Timm Bäder Date: 2023-04-06T10:25:57+02:00 New Revision: 4016e5d9499e3cbcde32dbfe1d0a5085a9b16c96 URL: https://github.com/llvm/llvm-project/commit/4016e5d9499e3cbcde32dbfe1d0a5085a9b16c96 DIFF: https://github.com/llvm/llvm-project/commit/4016e5d9499e3cbcde32dbfe1d0a5085a9b16c96.diff LO

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

qiucf added inline comments. Comment at: clang/test/CodeGen/PowerPC/builtins-ppc-xlcompat-test.c:47 -int test_test_data_class_f() { -// CHECK-LABEL: @test_test_data_class_f -// CHECK: [[TMP:%.*]] = call i32 @llvm.ppc.test.data.class.f32(float %0, i32 127) -//

[clang] 47ee851 - [clang][Interp][NFC] Context: Add getFloatSemantics()

Author: Timm Bäder Date: 2023-04-06T10:39:49+02:00 New Revision: 47ee8519ec2620ffe376d9b28cba8a2a0a73214a URL: https://github.com/llvm/llvm-project/commit/47ee8519ec2620ffe376d9b28cba8a2a0a73214a DIFF: https://github.com/llvm/llvm-project/commit/47ee8519ec2620ffe376d9b28cba8a2a0a73214a.diff LO

[PATCH] D137782: [clang-tidy]bugprone-fold-init-type

courbet added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137782/new/ https://reviews.llvm.org/D137782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] 70e5a2a - [clang][Interp] Fix zero-initializing of floating types

Author: Timm Bäder Date: 2023-04-06T10:52:01+02:00 New Revision: 70e5a2a94354fd7cec577d3e0c3892cc5e7ef07a URL: https://github.com/llvm/llvm-project/commit/70e5a2a94354fd7cec577d3e0c3892cc5e7ef07a DIFF: https://github.com/llvm/llvm-project/commit/70e5a2a94354fd7cec577d3e0c3892cc5e7ef07a.diff LO

[PATCH] D146788: [clang][Interp] Fix zero-initializing of floating types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG70e5a2a94354: [clang][Interp] Fix zero-initializing of floating types (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

iains updated this revision to Diff 511327. iains added a comment. rebased, addressed review comments (patch still needs refactoring) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145965/new/ https://reviews.llvm.org/D145965 Files: clang/include

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

iains added a comment. in the end, we have to deal with the following cases: 1. decls in the same TU (including GMF and PMF) 2. decls in the current named module (excluding GMF) 3. decls on an instantiation path (which can include internal-linkage entities) 4. decls that are needed by an exported

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

iains marked 2 inline comments as done. iains added inline comments. Comment at: clang/include/clang/Sema/Sema.h:2356 + /// Determine whether the module M is part of the current named module. + bool isPartOfCurrentNamedModule(const Module *M) const { +if (!M || M->isGlobalM

[clang] 03a9a1e - [Sema] Fix reporting of invalid shader attribute on HLSL entry function

Author: Richard Sandiford Date: 2023-04-06T10:56:01+01:00 New Revision: 03a9a1e664de58fb52ce93e9fb73f61e75a5359a URL: https://github.com/llvm/llvm-project/commit/03a9a1e664de58fb52ce93e9fb73f61e75a5359a DIFF: https://github.com/llvm/llvm-project/commit/03a9a1e664de58fb52ce93e9fb73f61e75a5359a.d

[PATCH] D147657: [Sema] Fix reporting of invalid shader attribute on HLSL entry function

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG03a9a1e664de: [Sema] Fix reporting of invalid shader attribute on HLSL entry function (authored by rsandifo-arm). Repository: rG LLVM Github Monor

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added a comment. I'll submit later today then if nobody has any other objections Will add a release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145803/new/ https://reviews.llvm.org/D145803 ___

[clang] 7d9511b - [clang][Interp] Add missing static_assert messages

Author: Timm Bäder Date: 2023-04-06T12:03:45+02:00 New Revision: 7d9511b2e33f1981cd846dd2493c6d96ece2c77e URL: https://github.com/llvm/llvm-project/commit/7d9511b2e33f1981cd846dd2493c6d96ece2c77e DIFF: https://github.com/llvm/llvm-project/commit/7d9511b2e33f1981cd846dd2493c6d96ece2c77e.diff LO

[PATCH] D137782: [clang-tidy]bugprone-fold-init-type

PiotrZSL added a comment. Missing ReleaseNotes, Comment at: clang-tools-extra/clang-tidy/bugprone/FoldInitTypeCheck.cpp:41 +returns(hasCanonicalType( +referenceType(pointee(BuiltinTypeWithId(ID), +// `value_typ

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

ilya-biryukov added a comment. This breaks the following innocent looking out-of-line definition with two levels of constrained template parameters: template concept Result = true; template class CoFuture final { template explicit CoFuture(); }; template template CoF

[clang] 55bbcbf - [clang] Reset track of immediate function context when entering new function

Author: Mariya Podchishchaeva Date: 2023-04-06T06:35:26-04:00 New Revision: 55bbcbf511b4df0dfe524b2d06fc561a939c6b16 URL: https://github.com/llvm/llvm-project/commit/55bbcbf511b4df0dfe524b2d06fc561a939c6b16 DIFF: https://github.com/llvm/llvm-project/commit/55bbcbf511b4df0dfe524b2d06fc561a939c6b

[PATCH] D147531: [clang] Reset track of immediate function context when entering new function

This revision was automatically updated to reflect the committed changes. Closed by commit rG55bbcbf511b4: [clang] Reset track of immediate function context when entering new function (authored by Fznamznon). Changed prior to commit: https://reviews.llvm.org/D147531?vs=510843&id=511357#toc Rep

[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando added a comment. In D146987#4237124 , @haowei wrote: > This patch (which enables assignment tracking) and D147312 > breaks llvm runtime build for > `runtimes-armv7-unknown-linux-gnueabihf` > > ... > > Example o

[PATCH] D147626: [clang] Do not crash when initializing union with flexible array member

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:808 unsigned NumElems = numStructUnionElements(ILE->getType()); - if (RDecl->hasFlexibleArrayMember()) + if (!RDecl->isUnion() && RDecl->hasFlexibleArrayMember()) ++NumElems; --

[PATCH] D147686: [clangd] Fix a nullptr-dereference crash in computeIncludeCleanerFindings.

kadircet added a comment. could you give some more details about the crash, so that we actually now where to fix it? e.g. is it token buffers missing the spelled token at that offset somehow ? or is it AST reporting a weird source locations for user-defined literals and we need to do some sort

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 updated this revision to Diff 511362. kpdev42 added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143347/new/ https://reviews.llvm.org/D143347 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserC

[PATCH] D147698: [clang][dataflow] Add support for new and delete expressions.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. To model the fact that values get deleted by a d

[clang] ef1b22a - [clang][ClangScanDeps][test] Remove the file before overwriting it

Author: Dmitri Gribenko Date: 2023-04-06T13:51:57+02:00 New Revision: ef1b22a20fd4d8c0cfea64089d4e732dd95dc265 URL: https://github.com/llvm/llvm-project/commit/ef1b22a20fd4d8c0cfea64089d4e732dd95dc265 DIFF: https://github.com/llvm/llvm-project/commit/ef1b22a20fd4d8c0cfea64089d4e732dd95dc265.dif

[PATCH] D147686: [clangd] Fix a nullptr-dereference crash in computeIncludeCleanerFindings.

hokein added a comment. In D147686#4248330 , @kadircet wrote: > could you give some more details about the crash, so that we actually now > where to fix it? e.g. is it token buffers missing the spelled token at that > offset somehow ? or is it AST repor

[PATCH] D144943: [clang][Interp] Implement bitcasts (WIP)

tbaeder updated this revision to Diff 511386. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144943/new/ https://reviews.llvm.org/D144943 Files: clang/lib/AST/Interp/Boolean.h clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/Desc

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

erichkeane accepted this revision. erichkeane added inline comments. Comment at: clang/include/clang/AST/ExprConcepts.h:502 ArrayRef LocalParameters, + SourceLocation RParenLoc, ArrayRef Requirements, rsmith wrote: >

[PATCH] D147661: [Sema] Tweak merging of availability attributes

erichkeane added a comment. I think the change is probably fine, but can you add an AST-dump test for this one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147661/new/ https://reviews.llvm.org/D147661 ___

[PATCH] D147572: [Clang][OpenMP] Fix failure with team-wide allocated variable

doru1004 added inline comments. Comment at: clang/test/OpenMP/target_team_variable_codegen.cpp:33 +//. +// CHECK-NVIDIA: @local_a = internal addrspace(3) global [10 x i32] zeroinitializer, align 4 +//. jhuber6 wrote: > Shouldn't the Nvidia version also be undefi

[PATCH] D147708: [NFC][clang] Fix static analyzer tool remarks about large copies by values

Manna created this revision. Manna added reviewers: erichkeane, aaron.ballman. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, arphaman, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang

[PATCH] D98416: [clang-tidy] Fix cppcoreguidelines-narrowing-conversions false positive

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. Herald added a subscriber: PiotrZSL. Herald added a project: All. LGTM, is there anything that should be fixed before merging? Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D147615: [clang][Sema][NFC] Save token name instead of the full token

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! There shouldn't be any lifetime issues from this, as @shafik pointed out, the pointer originates in a static array defined in `TokenKinds.cpp`. Repository: rG LLVM Githu

[clang] 91a0740 - Reapply "[Assignment Tracking] Enable by default"

Author: OCHyams Date: 2023-04-06T15:29:18+01:00 New Revision: 91a0740474e3c4fe0bde8ff5699115bf808ca23f URL: https://github.com/llvm/llvm-project/commit/91a0740474e3c4fe0bde8ff5699115bf808ca23f DIFF: https://github.com/llvm/llvm-project/commit/91a0740474e3c4fe0bde8ff5699115bf808ca23f.diff LOG:

[PATCH] D147708: [NFC][clang] Fix static analyzer tool remarks about large copies by values

erichkeane added a comment. Build failures seem relevant. Comment at: clang/lib/CodeGen/CGGPUBuiltin.cpp:128 -bool containsNonScalarVarargs(CodeGenFunction *CGF, CallArgList Args) { +bool containsNonScalarVarargs(CodeGenFunction *CGF, CallArgList &Args) { return llvm::any_

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

royjacobson added a comment. I agree it doesn't affect too much code, but people do instantiate templates manually sometimes. IIUC, linking against shared libraries would break if that library does explicit instantiations of constrained functions. That concerns me a bit. Also, do you know if G

[PATCH] D147626: [clang] Do not crash when initializing union with flexible array member

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:808 unsigned NumElems = numStructUnionElements(ILE->getType()); - if (RDecl->hasFlexibleArrayMember()) + if (!RDecl->isUnion() && RDecl->hasFlexibleArrayMember()) ++NumElems; --

[PATCH] D141307: Add -f[no-]loop-versioning option

Leporacanthicus updated this revision to Diff 511416. Leporacanthicus added a comment. Rebase only Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141307/new/ https://reviews.llvm.org/D141307 Files: clang/include/clang/Driver/Options.td clang/li

[PATCH] D147666: [OPENMP] Adds /lib to rpath to avoid need to set LD_LIBRARY_PATH to find plugins.

JonChesterfield added a comment. Sorry Greg, we can't have this back in trunk. It's now value add for the ROCm toolchain, and some llvm releases had this feature, but no longer. The consensus in the OpenMP weekly meeting was to require users to hack around with linker flags or environment varia

[clang] 090b2e2 - [AttrDocs] Enhance musttail attribute documentation

Author: Dávid Bolvanský Date: 2023-04-06T16:51:33+02:00 New Revision: 090b2e27efb2bd2859913f0e9c15effe2a88982b URL: https://github.com/llvm/llvm-project/commit/090b2e27efb2bd2859913f0e9c15effe2a88982b DIFF: https://github.com/llvm/llvm-project/commit/090b2e27efb2bd2859913f0e9c15effe2a88982b.dif

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

tiagoma added a comment. Applying this patch seems to fix issues with C++20 as well. See https://github.com/llvm/llvm-project/issues/61969 Can we get it in? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146520/new/ https://reviews.llvm.org/D146520

[PATCH] D147714: [Attr] Introduce [[clang::nonportable_musttail]] as less strict version of [[clang::musttail]]

xbolva00 created this revision. xbolva00 added reviewers: aaron.ballman, efriedma, haberman. Herald added a project: All. xbolva00 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As noted in https://github.com/llvm/llvm-project/issues/54964

[PATCH] D137782: [clang-tidy]bugprone-fold-init-type

courbet updated this revision to Diff 511424. courbet marked 2 inline comments as done. courbet added a comment. - Address review comments - Add release notes. Thanks ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137782/new/ https://reviews.llvm

[PATCH] D147661: [Sema] Tweak merging of availability attributes

rsandifo-arm updated this revision to Diff 511425. rsandifo-arm added a comment. Add AST dump test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147661/new/ https://reviews.llvm.org/D147661 Files: clang/lib/Sema/SemaDeclAttr.cpp clang/test/Sem

[PATCH] D147661: [Sema] Tweak merging of availability attributes

rsandifo-arm added a comment. In D147661#4248574 , @erichkeane wrote: > I think the change is probably fine, Thanks! > but can you add an AST-dump test for this one? Sure. How does this look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

cor3ntin added a comment. @ychen Hey! Are you still working on this? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 ___ cfe-commits mailing list cfe-co

[PATCH] D147714: [Attr] Introduce [[clang::nonportable_musttail]] as less strict version of [[clang::musttail]]

xbolva00 updated this revision to Diff 511427. xbolva00 added a comment. Mention it in attribute documentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147714/new/ https://reviews.llvm.org/D147714 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td

[clang] 64fba20 - Revert (2) "[Assignment Tracking] Enable by default"

Author: OCHyams Date: 2023-04-06T16:32:58+01:00 New Revision: 64fba207a683a355d9059cd57adb8a139c2f5dda URL: https://github.com/llvm/llvm-project/commit/64fba207a683a355d9059cd57adb8a139c2f5dda DIFF: https://github.com/llvm/llvm-project/commit/64fba207a683a355d9059cd57adb8a139c2f5dda.diff LOG:

[PATCH] D147554: [clang] Mark CWG562 as N/A

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147554/new/ https://reviews.llvm.org/D147554 ___

[PATCH] D147549: [clang] Add test for CWG255

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147549/new/ https://reviews.llvm.org/D147549 ___

[PATCH] D144651: [Serialization] Place command line defines in the correct file

fdeazeve added a comment. I did some local testing, and this no longer seems to crash for me. Hopefully the bots will be fine too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144651/new/ https://reviews.llvm.org/D144651 _

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

francii updated this revision to Diff 511431. francii added a comment. Add unsupported target test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146399/new/ https://reviews.llvm.org/D146399 Files: clang/include/clang/Driver/Options.td cla

[PATCH] D146897: [clang:diagnostics] Turning off warn_self_assignment_overloaded for user-defined compound assignments

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:14134 return; - + Sema.Diag(Loc, diag::warn_identity_field_assign) << 0; Spurious whitespace change. Comment at: clang/test/SemaCXX/warn-self-assign-

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

asb added a comment. Ok, looks like the consensus I thought we had isn't quite there on the psABI thread - Andrew Waterman has some concerns. We should let that discussion play out some more. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/ne

[PATCH] D147572: [Clang][OpenMP] Fix failure with team-wide allocated variable

jdoerfert added inline comments. Comment at: clang/test/OpenMP/target_team_variable_codegen.cpp:33 +//. +// CHECK-NVIDIA: @local_a = internal addrspace(3) global [10 x i32] zeroinitializer, align 4 +//. doru1004 wrote: > jhuber6 wrote: > > Shouldn't the Nvidia v

[PATCH] D147572: [Clang][OpenMP] Fix failure with team-wide allocated variable

jhuber6 added inline comments. Comment at: clang/test/OpenMP/target_team_variable_codegen.cpp:33 +//. +// CHECK-NVIDIA: @local_a = internal addrspace(3) global [10 x i32] zeroinitializer, align 4 +//. jdoerfert wrote: > doru1004 wrote: > > jhuber6 wrote: > > > S

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After resolving several outstanding issues now is the time to mark it as fully supported. Fixes https://github.com/llvm

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

cor3ntin added a comment. LGTM. Thanks for completing this :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147717/new/ https://reviews.llvm.org/D147717 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

erichkeane added a subscriber: cjdb. erichkeane added a comment. @cjdb has been running some GDB test suites against our compiler: I am wondering if we could ask him to try the consteval ones too before we set this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D146376: Update static_assert message for redundant cases

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a small nit with the release notes. Do you need someone to land this on your behalf? If so, please rebase the patch so it applies cleanly to trunk and upload it a

[PATCH] D147572: [Clang][OpenMP] Fix failure with team-wide allocated variable

doru1004 added inline comments. Comment at: clang/test/OpenMP/target_team_variable_codegen.cpp:33 +//. +// CHECK-NVIDIA: @local_a = internal addrspace(3) global [10 x i32] zeroinitializer, align 4 +//. jhuber6 wrote: > jdoerfert wrote: > > doru1004 wrote: > > >

[PATCH] D147661: [Sema] Tweak merging of availability attributes

erichkeane added a comment. This test doesn't show a change in behavior. See: https://godbolt.org/z/vrWM1bTPE |-FunctionDecl 0xdbfa5a20 <:3:1, col:60> col:6 foo 'void (void)' | |-AvailabilityAttr 0xdbfa5ac8 ios 2.0 0 0 "" "" 0 | `-AvailabilityAttr 0xdbfa5b80 Implicit maccata

[PATCH] D147572: [Clang][OpenMP] Fix failure with team-wide allocated variable

doru1004 updated this revision to Diff 511436. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147572/new/ https://reviews.llvm.org/D147572 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/test/OpenMP/target_team_variable_codegen.cpp Index: clang/test/OpenMP/target_team_variable

[PATCH] D147572: [Clang][OpenMP] Fix failure with team-wide allocated variable

doru1004 updated this revision to Diff 511444. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147572/new/ https://reviews.llvm.org/D147572 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/test/OpenMP/target_team_variable_codegen.cpp Index: clang/test/OpenMP/target_team_variable

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1481 +// To fix this we scan base classes in reverse order to determine +// overlapping offsets. Wnen found we consider such class as empty +// base with all fie

[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

erichkeane created this revision. erichkeane added reviewers: clang-language-wg, alexander-shaposhnikov. Herald added a project: All. erichkeane requested review of this revision. As reported in GH61959, the patch for https://reviews.llvm.org/D146178 regressed some comparisons of non-out-of-line

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

shafik added a comment. In D147717#4248989 , @erichkeane wrote: > @cjdb has been running some GDB test suites against our compiler: I am > wondering if we could ask him to try the consteval ones too before we set > this? This is probably a good idea.

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1483 +// base with all fields having [[no_unique_address]] attribute. +for (auto it = base_classes.rbegin(); it != base_classes.rend(); ++it) { + clang::CXXReco

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added inline comments. Comment at: lldb/test/API/types/TestEmptyBase.py:25-42 +def test(self): +"""Test that recursive structs are displayed correctly.""" +self.build(dictionary=self.sources) +self.setTearDownCleanup(dictionary=self.sources)

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth updated this revision to Diff 511458. paulkirth added a comment. Fix formatting and update documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463 Files: clang/docs/ShadowCallStack.rst

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

philnik updated this revision to Diff 511460. philnik marked 4 inline comments as done. philnik added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147175/new/ https://reviews.llvm.org/D147175 Files: clang/docs/Langua

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

philnik added a comment. In D147175#4246513 , @aaron.ballman wrote: > Ah, I like this approach -- it keeps things roughly in sync with checking for > unique object representations, which is great. I spotted a few questions, but > in general this is hea

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added a comment. FYI, this bugfix was attempted back in 2021 here: https://reviews.llvm.org/D101237 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143347/new/ https://reviews.llvm.org/D143347

[PATCH] D146971: [Sema] Populate declarations inside TypeLocs for some invalid types

ilya-biryukov updated this revision to Diff 511462. ilya-biryukov added a comment. - Add assertions for removed null checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146971/new/ https://reviews.llvm.org/D146971 Files: clang/lib/Sema/SemaChec

[PATCH] D146971: [Sema] Populate declarations inside TypeLocs for some invalid types

ilya-biryukov updated this revision to Diff 511463. ilya-biryukov added a comment. - Another forgotten non-null assertion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146971/new/ https://reviews.llvm.org/D146971 Files: clang/lib/Sema/SemaChecki

[PATCH] D147661: [Sema] Tweak merging of availability attributes

rsandifo-arm added a comment. In D147661#4249004 , @erichkeane wrote: > This test doesn't show a change in behavior. Yeah. Is there a way to force the syntax and spelling fields to be dumped, even for implicit attributes? I was struggling to find one

[PATCH] D146971: [Sema] Populate declarations inside TypeLocs for some invalid types

ilya-biryukov added a comment. Sorry for taking so long to land this, it fell off my radar. In D146971#4227482 , @aaron.ballman wrote: > LGTM, though the change should come with a release note. Suggestion you can > take or leave as you see fit: should

[clang] f27b77e - [Sema] Populate declarations inside TypeLocs for some invalid types

Author: Ilya Biryukov Date: 2023-04-06T19:02:41+02:00 New Revision: f27b77e5c59a1a907fa45eeb5f2e279a5c8bd17d URL: https://github.com/llvm/llvm-project/commit/f27b77e5c59a1a907fa45eeb5f2e279a5c8bd17d DIFF: https://github.com/llvm/llvm-project/commit/f27b77e5c59a1a907fa45eeb5f2e279a5c8bd17d.diff

[PATCH] D146971: [Sema] Populate declarations inside TypeLocs for some invalid types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf27b77e5c59a: [Sema] Populate declarations inside TypeLocs for some invalid types (authored by ilya-biryukov). Repository: rG LLVM Github Monorepo

[PATCH] D147661: [Sema] Tweak merging of availability attributes

erichkeane added a comment. In D147661#4249244 , @rsandifo-arm wrote: > In D147661#4249004 , @erichkeane > wrote: > >> This test doesn't show a change in behavior. > > Yeah. Is there a way to force the syntax a

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth updated this revision to Diff 511466. paulkirth marked 2 inline comments as done. paulkirth added a comment. Remove extra line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463 Files: clang/doc

[PATCH] D147714: [Attr] Introduce [[clang::nonportable_musttail]] as less strict version of [[clang::musttail]]

efriedma added a subscriber: nickdesaulniers. efriedma added a comment. Any thoughts on diagnostics here? If I'm not mistaken, with this patch, if you request an impossible tail call, you get a crash with very little useful information. (Although, see https://discourse.llvm.org/t/rfc-improvin

[PATCH] D146897: [clang:diagnostics] Turning off warn_self_assignment_overloaded for user-defined compound assignments

rjmccall added a comment. Yeah, I feel there are three ideas here: - Clang should warn about self simple assignment in all cases, because it's probably a mistake. We can assume it's a mistake because it's reasonable to assume that the simple assignment operator behaves like a value assignment,

[PATCH] D147714: [Attr] Introduce [[clang::nonportable_musttail]] as less strict version of [[clang::musttail]]

xbolva00 added a comment. In D147714#4249274 , @efriedma wrote: > Any thoughts on diagnostics here? If I'm not mistaken, with this patch, if > you request an impossible tail call, you get a crash with very little useful > information. (Although, see

[PATCH] D147481: [M68k] Add basic Clang supports for M68881/2

myhsu updated this revision to Diff 511477. myhsu marked 2 inline comments as done. myhsu added a comment. - Explicit add `isa-68882` even for newer (>=68040) CPUs. Such that's it's a lot easier to conditionally add related macro definitions with TargetOptions::FeatureMap - Add cases to test the

  1   2   >