[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

rsmith added a comment. Can you also change www/cxx_status.html to list P2103R0 as supported in the most recent version of Clang rather than in some previous version? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.o

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

rsmith added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:775-776 +static bool IsInsideImplicitFullTemplateSpecialization(const DeclContext *DC) { + auto *CTSDecl = dyn_cast_or_null( + DC->getOuterLexicalRecordContext()); + return CTSDecl && !isa(CTSDecl) &&

[clang] fa95f20 - Update Clang 16 statuses

Author: Aaron Ballman Date: 2023-04-03T15:31:20-04:00 New Revision: fa95f20f98c8dfd4d35590a724eb0eb7df64146a URL: https://github.com/llvm/llvm-project/commit/fa95f20f98c8dfd4d35590a724eb0eb7df64146a DIFF: https://github.com/llvm/llvm-project/commit/fa95f20f98c8dfd4d35590a724eb0eb7df64146a.diff

[PATCH] D147068: Fix merging of member-like constrained friends across modules.

rsmith closed this revision. rsmith added a comment. Refactoring and test landed in rGa07abe27b4d1d39ebb940a7f4e6235302444cbf0 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1470

[PATCH] D87338: [Driver][PGO] Driver support for de-Optimizing cold functions (PATCH 2/2)

myhsu abandoned this revision. myhsu added a comment. Herald added subscribers: wlei, ormris, MaskRay. Herald added a project: All. just realized I haven't updated this patch for years. I'll come up with an up-to-date version when I have time. CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D143527: [OpenMP][5.1] Fix parallel masked is ignored #59939

This revision was automatically updated to reflect the committed changes. Closed by commit rG64549f0903e2: [OpenMP][5.1] Fix parallel masked is ignored #59939 (authored by randreshg, committed by josemonsalve2). Herald added projects: clang, OpenMP. Herald added subscribers: openmp-commits, cfe-co

[clang] 64549f0 - [OpenMP][5.1] Fix parallel masked is ignored #59939

Author: Rafael A. Herrera Guaitero Date: 2023-04-03T20:33:55Z New Revision: 64549f0903e244fbe2e7f0131698334b6e45dc10 URL: https://github.com/llvm/llvm-project/commit/64549f0903e244fbe2e7f0131698334b6e45dc10 DIFF: https://github.com/llvm/llvm-project/commit/64549f0903e244fbe2e7f0131698334b6e45dc

[PATCH] D146595: [clang] Add "transparent_stepping" attribute

dblaikie added a comment. Is there some place (bug, discourse thread, etc) where the broader direction is discussed? I want to checkin on the design decisions/alternatives without fragmenting this across multiple reviews/losing context/etc? (specifically - this started out with the trampoline a

[clang] d78ceeb - [Clang] Fix failing test on windows and add TODO for gpu headers

Author: Joseph Huber Date: 2023-04-03T16:54:22-05:00 New Revision: d78ceeba986b5ebe83f935175e584c346a52b8a3 URL: https://github.com/llvm/llvm-project/commit/d78ceeba986b5ebe83f935175e584c346a52b8a3 DIFF: https://github.com/llvm/llvm-project/commit/d78ceeba986b5ebe83f935175e584c346a52b8a3.diff

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

kamaub added a comment. Can you add a PowerPC codegen test case for `__attribute__((target(`? All of the updated test cases seem to only test `-target-feature`. The only test case we have for `__attribute((target(` is a sema test `./clang/test/Sema/ppc-attr-target-inline.c`. Converting the dele

[PATCH] D147477: [clang][modules] Handle explicit modules when checking for .Private -> _Private

benlangmuir created this revision. benlangmuir added reviewers: akyrtzi, jansvoboda11. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. While we eventually want to remove the mapping from .Private to

[PATCH] D147477: [clang][modules] Handle explicit modules when checking for .Private -> _Private

benlangmuir updated this revision to Diff 510623. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147477/new/ https://reviews.llvm.org/D147477 Files: clang/lib/Frontend/CompilerInstance.cpp clang/test/Modules/implicit-private-with-submodule-explicit.m Index: clang/test/Modules/implic

[PATCH] D147477: [clang][modules] Handle explicit modules when checking for .Private -> _Private

jansvoboda11 added inline comments. Comment at: clang/test/Modules/implicit-private-with-submodule-explicit.m:9 +// RUN: %clang_cc1 -x objective-c -fmodules -fno-implicit-modules -emit-module -fmodule-name=A_Private %t/module.modulemap -o %t/A_Private.pcm +// RUN: %clang_cc1 -x

[PATCH] D147477: [clang][modules] Handle explicit modules when checking for .Private -> _Private

benlangmuir updated this revision to Diff 510628. benlangmuir added a comment. Also test eagerly-loaded pcm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147477/new/ https://reviews.llvm.org/D147477 Files: clang/lib/Frontend/CompilerInstance.cpp clang/test/Modules/implicit-private-

[PATCH] D147477: [clang][modules] Handle explicit modules when checking for .Private -> _Private

benlangmuir updated this revision to Diff 510629. benlangmuir added a comment. Upload correct diff this time CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147477/new/ https://reviews.llvm.org/D147477 Files: clang/lib/Frontend/CompilerInstance.cpp clang/test/Modules/implicit-private

[PATCH] D147481: [M68k] Add basic Clang supports for M68881/2

myhsu created this revision. myhsu added reviewers: 0x59616e, RKSimon. Herald added a project: All. myhsu requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. - Add the `-m68881` flag - Add floating point feature detection - Macro defini

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov updated this revision to Diff 510634. alexander-shaposhnikov added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 Files: clang/lib/Sema/SemaConcept.cp

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Does my horrible lambda example work now? If so, that seems like a useful testcase. Comment at: clang/lib/Sema/SemaConcept.cpp:781 + /*ForConstraintInstantiation=*/true

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov updated this revision to Diff 510637. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 Files: clang/lib/Sema/SemaConcept.cpp clang/lib/Sema/SemaOverload.cpp clang/lib/Sema/SemaTe

[PATCH] D146595: [clang] Add "transparent_stepping" attribute

aprantl added a comment. > Is there some place (bug, discourse thread, etc) where the broader direction > is discussed? I want to checkin on the design decisions/alternatives without > fragmenting this across multiple reviews/losing context/etc? No, I believe that all the relevant discussion ha

[PATCH] D147477: [clang][modules] Handle explicit modules when checking for .Private -> _Private

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147477/new/ https://reviews.llvm.org/D147477 ___ cfe-commits mailing list

[PATCH] D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines

denizevrenci added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/exception-escape-coro.cpp:75-79 + // CHECK-MESSAGES-NOT: :[[@LINE-1]]:11: warning: an exception may be thrown in function 'b_ShouldNotDiag' which should not throw exceptions +

[PATCH] D147194: [clang-tidy] fix concat-nest-namespace fix hint remove the macro

HerrCai0907 updated this revision to Diff 510658. HerrCai0907 edited the summary of this revision. HerrCai0907 added a comment. add feature update close comment in fixhint update acc. comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147194/new/

[clang] 038b7e6 - [X86] Support AMX Complex instructions

Author: Xiang1 Zhang Date: 2023-04-04T09:54:46+08:00 New Revision: 038b7e6b761c2bebb30440cdd39252a0fa74ac3f URL: https://github.com/llvm/llvm-project/commit/038b7e6b761c2bebb30440cdd39252a0fa74ac3f DIFF: https://github.com/llvm/llvm-project/commit/038b7e6b761c2bebb30440cdd39252a0fa74ac3f.diff

[PATCH] D147420: [X86] Support AMX Complex instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG038b7e6b761c: [X86] Support AMX Complex instructions (authored by xiangzhangllvm). Herald added a project: clang. Herald added a subscriber: cfe-comm

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 510661. VincentWu added a comment. rename FeatureExtZcmp -> FeatureStdExtZcmp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.org/D132819 Files: clang/test/Preprocessor/riscv

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov updated this revision to Diff 510662. alexander-shaposhnikov added a comment. Add test & minor optimization CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 Files: clang/lib/Sema/SemaConcept.cpp clang/lib/Sema/SemaOve

[PATCH] D133863: [RISCV] Add MC support of RISCV zcmt Extension

VincentWu updated this revision to Diff 510664. VincentWu marked an inline comment as done. VincentWu added a comment. Herald added a subscriber: jobnoorman. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133863/new/ https://reviews.llvm.org/

[PATCH] D147422: [clang-format] NFC Document the other space before colon option

sstwcw added a comment. In D147422#4240024 , @MyDeveloperDay wrote: > In D147422#4240021 , @owenpan wrote: > >> Should we extend `SpacesInContainerLiterals` so that it controls JSON colons >> too? If yes, then w

[PATCH] D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines

ChuanqiXu added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/exception-escape-coro.cpp:75-79 + // CHECK-MESSAGES-NOT: :[[@LINE-1]]:11: warning: an exception may be thrown in function 'b_ShouldNotDiag' which should not throw exceptions + if

[clang] 60bee9f - [Clang][Sema] Fix comparison of constraint expressions

Author: Alexander Shaposhnikov Date: 2023-04-04T02:31:13Z New Revision: 60bee9ff544541e83ffbd4be31923d0e8b644690 URL: https://github.com/llvm/llvm-project/commit/60bee9ff544541e83ffbd4be31923d0e8b644690 DIFF: https://github.com/llvm/llvm-project/commit/60bee9ff544541e83ffbd4be31923d0e8b644690.d

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG60bee9ff5445: [Clang][Sema] Fix comparison of constraint expressions (authored by alexander-shaposhnikov). Repository: rG LLVM Github Monorepo CH

[PATCH] D133863: [RISCV] Add MC support of RISCV zcmt Extension

VincentWu updated this revision to Diff 510667. VincentWu added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133863/new/ https://reviews.llvm.org/D133863 Files: clang/test/Preprocessor/riscv-target-features.c lld/E

[PATCH] D146329: [Clang] Fix defaulted equality operator so that it does not attempt to compare unnamed bit-fields

shafik added a comment. In D146329#4207522 , @royjacobson wrote: > In D146329#4203174 , @shafik wrote: > >> I would have loved to test the case from >> https://github.com/llvm/llvm-project/issues/61335 directly

[PATCH] D147495: [Clang][Attributes] Add MeaningfulToClassTemplateDefinition to unavailable attribute

shafik created this revision. shafik added reviewers: rsmith, aaron.ballman, erichkeane. Herald added a subscriber: inglorion. Herald added a project: All. shafik requested review of this revision. There may be cases in which we want to diagnose a type as unavailable but it may not be complete at

[PATCH] D147497: [AArch64] Use fneg instead of fsub -0.0, X Cin IR expansion of __builtin_neon_vfmsh_f16.

craig.topper created this revision. craig.topper added reviewers: efriedma, dmgreen, SjoerdMeijer, john.brawn. Herald added a subscriber: kristof.beyls. Herald added a project: All. craig.topper requested review of this revision. Herald added a project: clang. Addresses the FIXME and removes the o

[clang] e9c9db3 - PR58819: Correct linkage and mangling of lambdas in inline static member initializers

Author: David Blaikie Date: 2023-04-04T04:45:32Z New Revision: e9c9db34a9b04706937e9dd764d1d97ca84337b6 URL: https://github.com/llvm/llvm-project/commit/e9c9db34a9b04706937e9dd764d1d97ca84337b6 DIFF: https://github.com/llvm/llvm-project/commit/e9c9db34a9b04706937e9dd764d1d97ca84337b6.diff LOG:

[PATCH] D138247: PR58819: Correct linkage and mangling of lambdas in inline static member initializers

This revision was automatically updated to reflect the committed changes. Closed by commit rGe9c9db34a9b0: PR58819: Correct linkage and mangling of lambdas in inline static member… (authored by dblaikie). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D147411: [clang-tidy] Fix readability-static-accessed-through-instance check for anonymous structs

AMS21 added a comment. In D147411#4241016 , @PiotrZSL wrote: > LGTM, will you commit this or want someone else to commit this ? As I don't have access to the repository. I need someone else to commit it. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D147376: [clang-tidy] Small refactor for ExceptionAnalyzer

AMS21 added a comment. In D147376#4239421 , @PiotrZSL wrote: > LGTM. I would kindly ask for someone to commit this on my behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147376/new/ https://reviews.l

[PATCH] D147383: [clang-tidy] Allow bugprone-unchecked-optional-access to handle calls to `std::forward`

AMS21 updated this revision to Diff 510698. AMS21 marked an inline comment as done. AMS21 added a comment. Remove unneccesary braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147383/new/ https://reviews.llvm.org/D147383 Files: clang-tools-ex

[PATCH] D147383: [clang-tidy] Allow bugprone-unchecked-optional-access to handle calls to `std::forward`

AMS21 added a comment. Now I would kindly as for someone to commit this on my behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147383/new/ https://reviews.llvm.org/D147383 ___ cfe-commits mailing li

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak updated this revision to Diff 510706. dhruvachak added a comment. Herald added subscribers: jplehr, sunshaoce, kerbowa. Rebased and updated tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107

<    1   2