[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

dkrupp updated this revision to Diff 510108. dkrupp added a comment. This is a totally rewritten version of the patch which solely relies on the existing "interestingness" utility to track back the taint propagation. (And does not introduce a new FlowID in the ProgramState as requested in the

[PATCH] D147288: [clang][NFC] updates cxx_status for P2113R0

cjdb abandoned this revision. cjdb added a comment. In D147288#4237413 , @royjacobson wrote: > There was some discussion of this last year in this review: > https://reviews.llvm.org/D128750 > > It's such an edge case that I don't think we should lose sl

[PATCH] D147357: [clang-tidy] Add bugprone-optional-value-conversion check

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Detects potentially uni

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

ccotter accepted this revision. ccotter added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/readability/ForwardUsageCheck.cpp:98 + callExpr( + unless(isExpansionInSystemHeader()), argumentCountIs(1

[PATCH] D147357: [clang-tidy] Add bugprone-optional-value-conversion check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/optional-value-conversion.rst:46 +expressions that match the methods. +Default value is `"::value$;::get$`. Unintended quote in value. Repository: rG

[PATCH] D147357: [clang-tidy] Add bugprone-optional-value-conversion check

PiotrZSL added a comment. There are 37 findings in llvm repository: 1. clang-tools-extra/clang-tidy/ClangTidyCheck.cpp:96:12: warning: conversion from 'std::optional' into 'bool' and back into 'std::optional', remove potentially error-prone optional dereference [bugprone-optional-value-convers

[PATCH] D147357: [clang-tidy] Add bugprone-optional-value-conversion check

PiotrZSL updated this revision to Diff 510132. PiotrZSL added a comment. Fix doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147357/new/ https://reviews.llvm.org/D147357 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp cla

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan_custom.cpp:221 + if (flags().strict_data_dependencies) { +*ret_label = res ? dfsan_read_label(base, sizeof(base)) : 0; + } else { browneee wrote: > `base, sizeof(base)` does not make sen

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

PiotrZSL marked an inline comment as done. PiotrZSL added a comment. I will leave this review open for 1 more week, in case someone have some comments, and by someone I mean you @carlosgalvezp. Comment at: clang-tools-extra/clang-tidy/readability/ForwardUsageCheck.cpp:98 +

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

jplehr added a comment. In D140722#4219182 , @nextsilicon-itay-bookstein wrote: > Minor fix to the clang/CodeGen/ppc64le-varargs-f128.c test. > > @jdoerfert Does the PR CI run these, or are there build bots that cover the > different target-offloading v

[PATCH] D147315: [clang-tidy] support unscoped enumerations in readability-static-accessed-through-instance

HerrCai0907 added a comment. In D147315#4236403 , @PiotrZSL wrote: > Add test with scoped enums, to validate that it works correctly. > In theory this change should suport them also. scoped enum not support to visit by member. `EnumName::` is needed for

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142907/new/ https://reviews.llvm.org/D142907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D147315: [clang-tidy] support unscoped enumerations in readability-static-accessed-through-instance

PiotrZSL requested changes to this revision. PiotrZSL added a comment. This revision now requires changes to proceed. Ok, you right. Fix all open issues, and update commit message to be more detailed. Except that, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D139653: [clang] Set ShowInSystemHeader for module-build and module-import remarks

kastiglione updated this revision to Diff 510138. kastiglione added a comment. Add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139653/new/ https://reviews.llvm.org/D139653 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td cl

[PATCH] D147360: [AArch64] Add IR intrinsic for vbsl*

pranavk created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. pranavk requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D139653: [clang] Set ShowInSystemHeader for module-build and module-import remarks

kastiglione updated this revision to Diff 510141. kastiglione added a comment. minor cleanup of test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139653/new/ https://reviews.llvm.org/D139653 Files: clang/include/clang/Basic/DiagnosticFrontendKi

[clang] ba6e747 - [clang] Set ShowInSystemHeader for module-build and module-import remarks

Author: Dave Lee Date: 2023-03-31T15:56:09-07:00 New Revision: ba6e747f9b05e541e88822e1dbd6bd5424cfe2fb URL: https://github.com/llvm/llvm-project/commit/ba6e747f9b05e541e88822e1dbd6bd5424cfe2fb DIFF: https://github.com/llvm/llvm-project/commit/ba6e747f9b05e541e88822e1dbd6bd5424cfe2fb.diff LOG:

[PATCH] D139653: [clang] Set ShowInSystemHeader for module-build and module-import remarks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGba6e747f9b05: [clang] Set ShowInSystemHeader for module-build and module-import remarks (authored by kastiglione). Repository: rG LLVM Github Mono

[PATCH] D147295: [clang-format] Don't misannotate left squares as lambda introducers

owenpan added a comment. In D147295#4235648 , @rymiel wrote: > This is great! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147295/new/ https://reviews.llvm.org/D147295 __

[clang] 2a42a7b - [clang-format] Don't misannotate left squares as lambda introducers

Author: Owen Pan Date: 2023-03-31T16:13:03-07:00 New Revision: 2a42a7b4e87395ae2a4321292f0fd9dce401b4e1 URL: https://github.com/llvm/llvm-project/commit/2a42a7b4e87395ae2a4321292f0fd9dce401b4e1 DIFF: https://github.com/llvm/llvm-project/commit/2a42a7b4e87395ae2a4321292f0fd9dce401b4e1.diff LOG:

[PATCH] D147295: [clang-format] Don't misannotate left squares as lambda introducers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2a42a7b4e873: [clang-format] Don't misannotate left squares as lambda introducers (authored by owenpan). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

browneee added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan_custom.cpp:221 + if (flags().strict_data_dependencies) { +*ret_label = res ? dfsan_read_label(base, sizeof(base)) : 0; + } else { tkuchta wrote: > browneee wrote: > > `base, sizeof(base

[PATCH] D147121: [hwasan] remove requirment for PIE

vitalybuka removed a reviewer: alekseyshl. vitalybuka added 1 blocking reviewer(s): eugenis. vitalybuka accepted this revision. vitalybuka added a comment. This revision now requires review to proceed. I don't know why HWASAN may required pie, but @eugenis seems confident on D44745

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. @rsmith - thanks a lot for the review, is there anything you'd like me to do on this diff or we are good to go ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 __

[clang] 253985d - [clang-format] Add MinDigits suboptions to IntegerLiteralSeparator

Author: Owen Pan Date: 2023-03-31T17:14:33-07:00 New Revision: 253985d58caf95db8a84632d5a761b96fb7cd7d6 URL: https://github.com/llvm/llvm-project/commit/253985d58caf95db8a84632d5a761b96fb7cd7d6 DIFF: https://github.com/llvm/llvm-project/commit/253985d58caf95db8a84632d5a761b96fb7cd7d6.diff LOG:

[PATCH] D147111: [clang-format] Add MinDigits suboptions to IntegerLiteralSeparator

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG253985d58caf: [clang-format] Add MinDigits suboptions to IntegerLi

[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

owenpan added inline comments. Comment at: clang/include/clang/Format/Format.h:949 + /// If unset, ``ContinuationIndentWidth`` is used. + /// \code + /// AlignAfterOpenBracket: AlwaysBreak HazardyKnusperkeks wrote: > jp4a50 wrote: > > MyDeveloperDay wrote: >

[clang] 4d7e516 - [OHOS] Remove redundant IsIntegratedAssemblerDefault. NFC

Author: Brad Smith Date: 2023-03-31T20:27:29-04:00 New Revision: 4d7e5163d96758516c4838f05bfaa481d63179e1 URL: https://github.com/llvm/llvm-project/commit/4d7e5163d96758516c4838f05bfaa481d63179e1 DIFF: https://github.com/llvm/llvm-project/commit/4d7e5163d96758516c4838f05bfaa481d63179e1.diff LO

[PATCH] D147328: [clang-format] Handle enum in Verilog

owenpan accepted this revision. owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1712 break; - // This only applies for C++. - if (!Style.isCpp()) { + // This only applies for C++ and Verilog. + if (!Style.isCpp() &&

[PATCH] D147365: [HIPSPV] Remove useIntegratedAs. NFC

brad created this revision. brad added reviewers: jhuber6, ronlieb. brad added a project: clang. Herald added a subscriber: yaxunl. Herald added a project: All. brad requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. useIntegratedAs() is enabled if IsIntegratedAssem

[PATCH] D147365: [HIPSPV] Remove useIntegratedAs. NFC

jhuber6 added a comment. I don't know the toolchain, does `HIPSPV` perform as expected if you pass `-fno-integrated-as`? The difference is that `useIntegratedAs` forces it to always be enabled so the user can't change it AFAIK. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ForwardUsageCheck.cpp:99 + unless(isExpansionInSystemHeader()), argumentCountIs(1U), + IgnoreDependentExpresions + ? expr(unless(isInstantiationDependent

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 510167. junaire added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Basic/TokenKinds.def clang/include/clang/Inter

[PATCH] D146809: [WIP][clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 510168. junaire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h clang/lib/Headers/CMa

[PATCH] D146376: Update static_assert message for redundant cases

tbaeder added a comment. Does `git clang-format HEAD~1` not work on your system? It should only format the changed parts, not everything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146376/new/ https://reviews.llvm.org/D146376 _

[PATCH] D141497: [clang][Interp] Record initialization via conditional operator

tbaeder updated this revision to Diff 510180. tbaeder added a comment. Screw it, just use a `llvm::function_ref`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141497/new/ https://reviews.llvm.org/D141497 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCode

[PATCH] D147369: [clang][Interp] Support empty initlist initializers for complex types

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://revi

[PATCH] D146376: Update static_assert message for redundant cases

Krishna-13-cyber updated this revision to Diff 510186. Krishna-13-cyber added a comment. - Updated diff with `git clang-format HEAD~1` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146376/new/ https://reviews.llvm.org/D146376 Files: clang/lib/Se

[clang] 0cc66f3 - [Windows SEH] Fix catch+return crash for Windows -EHa

Author: Phoebe Wang Date: 2023-04-01T14:53:33+08:00 New Revision: 0cc66f3c779b80a199d692fa84f7ed8d29373d1c URL: https://github.com/llvm/llvm-project/commit/0cc66f3c779b80a199d692fa84f7ed8d29373d1c DIFF: https://github.com/llvm/llvm-project/commit/0cc66f3c779b80a199d692fa84f7ed8d29373d1c.diff L

[PATCH] D147165: [Windows SEH] Fix catch+return crash for Windows -EHa

This revision was automatically updated to reflect the committed changes. Closed by commit rG0cc66f3c779b: [Windows SEH] Fix catch+return crash for Windows -EHa (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147165/new/ https:/

<    1   2