[PATCH] D146465: [clang] Fix 2 bugs with parenthesized aggregate initialization

ayzhao updated this revision to Diff 509158. ayzhao added a comment. use ParenListExpr and fix getSubExprAsWritten(...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146465/new/ https://reviews.llvm.org/D146465 Files: clang/lib/AST/Expr.cpp cl

[PATCH] D146465: [clang] Fix 2 bugs with parenthesized aggregate initialization

ayzhao marked 2 inline comments as done. ayzhao added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:1582-1596 + MultiExprArg ExprsToPass; + if (Exprs.size() == 1 && isa(Exprs[0])) { +// C++20 [expr.static.cast]p4: +// An expression E can be explicitly co

[PATCH] D146465: [clang] Fix 2 bugs with parenthesized aggregate initialization

ayzhao updated this revision to Diff 509160. ayzhao marked an inline comment as done. ayzhao added a comment. fix stray whitespace change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146465/new/ https://reviews.llvm.org/D146465 Files: clang/lib

[PATCH] D147070: Improve requirement clause limitation on non templated function

shafik added inline comments. Comment at: clang/test/CXX/dcl.decl/dcl.decl.general/p4-20.cpp:27 + +namespace GH61748 { +template Maybe a union case just for completeness: ``` template union U { void f() requires true; }; ``` CHANGES SINCE LAST ACTION ht

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

hubert.reinterpretcast added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:647 +def err_roptr_requires_data_sections: Error<"-mxcoff-roptr is supported only with -fdata-sections">; +def err_roptr_cannot_build_shared: Error<"-mxcoff-roptr is not

[PATCH] D146758: Fix codegen for coroutine with function-try-block

MatzeB updated this revision to Diff 509173. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146758/new/ https://reviews.llvm.org/D146758 Files: clang/include/clang/AST/StmtCXX.h clang/lib/AST/ASTImporter.cpp clang/lib/AST/StmtCXX.cpp clang/li

[PATCH] D146758: Fix codegen for coroutine with function-try-block

MatzeB added inline comments. Comment at: clang/lib/CodeGen/CGCoroutine.cpp:724-730 + Stmt *BodyStmt = S.getBody(); + CompoundStmt *Body = dyn_cast(BodyStmt); + if (Body == nullptr) { +Body = +CompoundStmt::Create(getContext(), {BodyStmt}, FPOpt

[PATCH] D146678: Summary: Fix ArgsAsWritten being null for ConceptSpecializationExpr in certain circumstances when parsing ASTs

yeswalrus updated this revision to Diff 509175. yeswalrus retitled this revision from "Fix unexpected nullptr in ConceptSpecializationExpr's ArgsAsWritten field" to "Summary: Fix ArgsAsWritten being null for ConceptSpecializationExpr in certain circumstances when parsing ASTs". yeswalrus added a

[PATCH] D146678: Summary: Fix ArgsAsWritten being null for ConceptSpecializationExpr in certain circumstances when parsing ASTs

yeswalrus added a comment. In D146678#4220408 , @erichkeane wrote: > In D146678#4220360 , @yeswalrus > wrote: > >> -I can handle it. - >> Edit: I cannot handle it, I don't have commit access. If you could commit

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

hubert.reinterpretcast added inline comments. Comment at: clang/docs/ReleaseNotes.rst:317 + ``-fno-data-sections``. When ``-mxcoff-roptr`` is in effect at link time, + read-only data sections with relocatable address values that resolve to + imported symbols are made writable

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:125 + // The `-mroptr` option places constants in RO sections as much as possible. + // Then `-bforceimprw` changes such sections to RW if they contain imported Old

[PATCH] D147097: [SYCL] Always set NoUnwind attribute for SYCL.

hvdijk created this revision. hvdijk added a reviewer: bader. hvdijk added a project: clang. Herald added subscribers: Naghasan, Anastasia, ebevhan, yaxunl. Herald added a project: All. hvdijk requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commi

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

hazohelet added a comment. In D146358#4227938 , @cjdb wrote: > In D146358#4204412 , @tbaeder wrote: > >> "subobject named 'foo'" sounds a bit weird to me, I'd expect just "subobject >> 'foo'", but that's just a s

[PATCH] D147097: [SYCL] Always set NoUnwind attribute for SYCL.

hvdijk added a comment. Is the rationale I gave in the description correct, or would it be better for SYCL device code to unconditionally build without `-fexceptions` and get the `nounwind` attribute added that way? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

cjdb added a comment. In D146358#4229120 , @hazohelet wrote: > In D146358#4227938 , @cjdb wrote: > >> In D146358#4204412 , @tbaeder >> wrote: >> >>> "subobject named 'foo

[PATCH] D147097: [SYCL] Always set NoUnwind attribute for SYCL.

bader added a comment. @hvdijk, thanks a lot for fixing this. In D147097#4229121 , @hvdijk wrote: > Is the rationale I gave in the description correct, or would it be better for > SYCL device code to unconditionally build without `-fexceptions` and get

[PATCH] D147097: [SYCL] Always set NoUnwind attribute for SYCL.

hvdijk added a comment. > That's a good question. I haven't looked into this issue deep enough, but I > think using -fexceptions requires using delayed diagnostics to avoid false > diagnostics during host code analysis. I am assuming you mean `-fno-exceptions` (or, in `clang -cc1`, the absence

[PATCH] D146758: Fix codegen for coroutine with function-try-block

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. Since the patch itself is good and not large. Let me handle the trivial refactoring later. Comment at: clang/lib/CodeGen/CGCoroutine.cpp:724-730 + Stmt *BodyStmt

[PATCH] D126959: [C++20][Modules] Introduce an implementation module.

ChuanqiXu accepted this revision. ChuanqiXu added inline comments. Comment at: clang/lib/Lex/ModuleMap.cpp:935 + // with any legal user-defined module name). + StringRef IName = ".ImplementationUnit"; + assert(!Modules[IName] && "multiple implementation units?"); -

[PATCH] D145852: [Clang][AST] Fix __has_unique_object_representations computation for unnamed bitfields.

shafik added inline comments. Comment at: clang/test/SemaCXX/type-traits.cpp:2886-2889 +struct UnnamedEmptyBitfield { + int named; + int : 0; +}; royjacobson wrote: > royjacobson wrote: > > shafik wrote: > > > aaron.ballman wrote: > > > > I think there's one mo

[clang] d44371c - [Clang][Driver] Default Generic_GCC::IsIntegratedAssemblerDefault to true

Author: Brad Smith Date: 2023-03-28T22:26:18-04:00 New Revision: d44371c00d87f73aba4ba0feafb4a18151d6f831 URL: https://github.com/llvm/llvm-project/commit/d44371c00d87f73aba4ba0feafb4a18151d6f831 DIFF: https://github.com/llvm/llvm-project/commit/d44371c00d87f73aba4ba0feafb4a18151d6f831.diff LO

[PATCH] D147030: [Clang][Driver] Default Generic_GCC::IsIntegratedAssemblerDefault to true

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd44371c00d87: [Clang][Driver] Default Generic_GCC::IsIntegratedAssemblerDefault to true (authored by brad). Repository: rG LLVM Github Monorepo C

[clang] d978730 - [clang-repl] Add a command to load dynamic libraries

Author: Anubhab Ghosh Date: 2023-03-29T08:04:50+05:30 New Revision: d978730d8e2c10c76867b83bec2f1143d895ee7d URL: https://github.com/llvm/llvm-project/commit/d978730d8e2c10c76867b83bec2f1143d895ee7d DIFF: https://github.com/llvm/llvm-project/commit/d978730d8e2c10c76867b83bec2f1143d895ee7d.diff

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

This revision was automatically updated to reflect the committed changes. Closed by commit rGd978730d8e2c: [clang-repl] Add a command to load dynamic libraries (authored by argentite). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141824/new/ https:

[clang] 766d048 - [clang-repl] Use std::move when converting Error to Expected

Author: Anubhab Ghosh Date: 2023-03-29T08:18:36+05:30 New Revision: 766d048d819a78443da73f67afa04e0a108412b6 URL: https://github.com/llvm/llvm-project/commit/766d048d819a78443da73f67afa04e0a108412b6 DIFF: https://github.com/llvm/llvm-project/commit/766d048d819a78443da73f67afa04e0a108412b6.diff

[PATCH] D146926: [clang-format] Add option to decorate reflowed block comments

apwadkar added inline comments. Comment at: clang/lib/Format/BreakableToken.cpp:406 Decoration = "* "; - if (Lines.size() == 1 && !FirstInLine) { + if ((Lines.size() == 1 && !FirstInLine) || !Style.DecorateReflowedComments) { // Comments for which FirstInLine is false c

[clang] 279c7a2 - Revert "[C++20] [Modules] Don't load declaration eagerly for named modules"

Author: Chuanqi Xu Date: 2023-03-29T11:15:38+08:00 New Revision: 279c7a2f17937836ed13e359c3fb381bef7defaf URL: https://github.com/llvm/llvm-project/commit/279c7a2f17937836ed13e359c3fb381bef7defaf DIFF: https://github.com/llvm/llvm-project/commit/279c7a2f17937836ed13e359c3fb381bef7defaf.diff LO

[clang] 6e4f870 - re-land [C++20][Modules] Introduce an implementation module.

Author: Iain Sandoe Date: 2023-03-29T08:52:28+05:30 New Revision: 6e4f870a21e344fdcd61fe613b0aeeafb8a84ed2 URL: https://github.com/llvm/llvm-project/commit/6e4f870a21e344fdcd61fe613b0aeeafb8a84ed2 DIFF: https://github.com/llvm/llvm-project/commit/6e4f870a21e344fdcd61fe613b0aeeafb8a84ed2.diff L

[PATCH] D126959: [C++20][Modules] Introduce an implementation module.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e4f870a21e3: re-land [C++20][Modules] Introduce an implementation module. (authored by iains). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126959/new/ ht

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

garvitgupta08 added a comment. In D145726#4228406 , @MaskRay wrote: > Please update the commit message and comment about what binutils versions > reject the construct. I already added this - "Due to this we started seeing below assembler error with GNU

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

garvitgupta08 added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:980-981 +StringRef BaseInput = StringRef(II.getBaseInput()); +types::ID InputType = types::lookupTypeForExtension( +llvm::sys::path::extension(BaseInput).drop_front()); +if (I

[PATCH] D126959: [C++20][Modules] Introduce an implementation module.

iains marked an inline comment as done. iains added inline comments. Comment at: clang/lib/Lex/ModuleMap.cpp:935 + // with any legal user-defined module name). + StringRef IName = ".ImplementationUnit"; + assert(!Modules[IName] && "multiple implementation units?"); ---

[PATCH] D126959: [C++20][Modules] Introduce an implementation module.

ChuanqiXu added inline comments. Comment at: clang/lib/Lex/ModuleMap.cpp:935 + // with any legal user-defined module name). + StringRef IName = ".ImplementationUnit"; + assert(!Modules[IName] && "multiple implementation units?"); iains wrote: > ChuanqiXu wrote

[PATCH] D147111: [clang-format] Add MinDigits suboptions to IntegerLiteralSeparator

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, rymiel. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Closes https://g

[PATCH] D146408: [clang][Interp] Start supporting complex types

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/PrimType.h:108 +switch (Expr) { \ + TYPE_SWITCH_CASE(PT_Sint8, B) \ + TYPE_SWITCH_CASE(PT_Uint8, B

[PATCH] D146887: [clang-tidy] Fix if-constexpr false-positive in readability-misleading-indentation

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. Looks great, thanks for fixing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146887/new/ https://reviews.llvm.org/D146887 __

[PATCH] D146875: [clang-tidy] Fix example provided by add_new_check.py

carlosgalvezp added a comment. Thanks for digging into this! It looks a bit strange to me: > Usually developers have to preview a code diff (before vs after apply the > fix) to understand what the fix does before applying a fix. This is not quite true - clang-tidy displays the fix it hint when

[PATCH] D146408: [clang][Interp] Start supporting complex types

tbaeder updated this revision to Diff 509223. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146408/new/ https://reviews.llvm.org/D146408 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/Context.cpp clang/lib/AST/Interp/Ev

<    1   2   3