[PATCH] D146727: [clangd] Use expansion location for missing include diagnostics.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146727/new/ https://reviews.llvm.org/D146727

[PATCH] D145581: [clang-tidy] In C++17, callee is guaranteed to be sequenced before arguments.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:222 -- Improved :doc:`bugprone-use-after-move - ` to understand that there is a - sequence point between designated initializers. +- In :doc:`bugprone-use-after-move + `: --

[clang-tools-extra] 481f888 - [clangd] Use expansion location for missing include diagnostics.

Author: Viktoriia Bakalova Date: 2023-03-27T14:26:12Z New Revision: 481f88853685bcf604c79059e890553831588e8b URL: https://github.com/llvm/llvm-project/commit/481f88853685bcf604c79059e890553831588e8b DIFF: https://github.com/llvm/llvm-project/commit/481f88853685bcf604c79059e890553831588e8b.diff

[PATCH] D146727: [clangd] Use expansion location for missing include diagnostics.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG481f88853685: [clangd] Use expansion location for missing include diagnostics. (authored by VitaNuo). Changed prior to commit: https://reviews.llv

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

firewave added a comment. Some additional thoughts I had a while ago about something I have raised before: I think the warnings which can only be fixed with c++14 should either only be issued if that standard was specified or be behind an option. We have lots of lambda captures which could be mo

[PATCH] D146924: [clang] Add support for dollar sign in ud_suffix of numeric constants

tahonermann added a comment. > It's not in the range of any of the universal-character-names. I assume you mean that it isn't included in the range of UCNs that are allowed in identifiers. If so, that is correct; it is neither in XID_Start

[PATCH] D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

yaxunl added a comment. In D145579#4224157 , @tschuett wrote: > Do you want to move the AMDGPU changes into AMDGPU.cpp next to AMD.cpp? From > the conversation, there seems to be more target specific behaviours. I prefer to defer further refactoring to

[PATCH] D146947: [docs][clang] Added extra information inside the flag -fsanitize=unsigned-shift-base for UndefinedBehaviorSanitizer Fix : #60712

aabhinavg updated this revision to Diff 508655. aabhinavg added a comment. Done minor fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146947/new/ https://reviews.llvm.org/D146947 Files: clang/docs/UndefinedBehaviorSanitizer.rst Index: clang

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

aaron.ballman added a comment. In D146520#4221314 , @carlosgalvezp wrote: > Reading through Github I found the associated ticket (it would be good if you > could mention it in the commit message): > https://github.com/llvm/llvm-project/issues/61520 > >

[PATCH] D146814: [Flang] Add debug flag to enable current debug information pass

SBallantyne updated this revision to Diff 508658. SBallantyne marked 5 inline comments as done. SBallantyne added a comment. Add test for invalid debug-info-kind and address other review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146814/

[PATCH] D146814: [Flang] Add debug flag to enable current debug information pass

SBallantyne added a comment. In D146814#4223967 , @awarzynski wrote: > What's the overall design goal here? 100% consistency with Clang? Could this > be documented? The goal of this patch is just to enable the current debug pass with an appropriate fl

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

VitaNuo updated this revision to Diff 508661. VitaNuo marked 10 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146244/new/ https://reviews.llvm.org/D146244 Files: clang-to

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clangd/Hover.cpp:1175 + +for (const include_cleaner::Header &H : Providers) { + if (!ConvertedIncludes.match(H).empty()) { kadircet wrote: > note that this will att

[PATCH] D126959: [C++20][Modules] Introduce an implementation module.

iains reopened this revision. iains added a comment. This revision is now accepted and ready to land. I had a hunch that the issue was the non-ownership of the implementation module. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126959/new/ https:/

[PATCH] D126959: [C++20][Modules] Introduce an implementation module.

iains updated this revision to Diff 508662. iains added a comment. rebased, reworked to have the module owned. The implementation module needs to be owned by the mpodul map so that it is released when done. Reworked the comments and assert to check the main file presence. Repository: rG LLVM

[PATCH] D126959: [C++20][Modules] Introduce an implementation module.

iains added a comment. It took me a while to get my local macOS based devt. environment to reproduce the problem - but it was as expected; the implementation module was unowned and nothing was deleting it. unless CI throws up anything untoward, I plan to re-land this tomorrow (since there is

[PATCH] D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

domada updated this revision to Diff 508660. domada added a comment. Patch rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145579/new/ https://reviews.llvm.org/D145579 Files: clang/lib/Basic/Targets/AMDGPU.cpp clang/lib/Driver/ToolChains/CommonArgs.cpp clang/lib/Driver/Tool

[PATCH] D146971: [Sema] Populate declarations inside TypeLocs for some invalid types

ilya-biryukov created this revision. ilya-biryukov added reviewers: aaron.ballman, erichkeane. Herald added a subscriber: arphaman. Herald added a project: All. ilya-biryukov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This also reverts

[PATCH] D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

awarzynski added a comment. Thanks for the updates, mostly looks good. Just a couple of extra questions about the test coverage. Comment at: flang/lib/Frontend/FrontendActions.cpp:139-142 + // Clang does not append all target features to the clang -cc1 invocation. + // Some

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

jhuber6 created this revision. jhuber6 added reviewers: tra, yaxunl, JonChesterfield, sivachandra, MaskRay, jdoerfert, tianshilei1992. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald added a project: clang. Th

[PATCH] D146426: [Sema] Fix crash on __fp16 parameters in template instantiations

ilya-biryukov added a comment. In D146426#4209620 , @aaron.ballman wrote: > Thank you for offering to do that in a follow-up, but please, next time wait > for there to be agreement on the patch before landing it. Multiple reviewers > expressed concerns

[PATCH] D146634: [clang][USR] Prevent crashes when parameter lists have nulls

ilya-biryukov added a comment. Hopefully this should be addressed by D146971 , but it would be great to get a reproducer for this issue to be ceratin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146634/new/ htt

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

jhuber6 added a comment. I'm not sure if there's a better way to provide these headers. Like if we let the `libc` project output to the Clang resource directory or some other neatly nested directory. Right now this just picks up `bin/clang/../include/llvm-libc`. Repository: rG LLVM Github Mo

[PATCH] D146971: [Sema] Populate declarations inside TypeLocs for some invalid types

erichkeane added a comment. One other thing we probably should do is have an assert when creating a function type that none of its params are null. WDYT? Comment at: clang/lib/Sema/SemaType.cpp:5949 assert(!T.isNull() && "T must not be null at the end of this function"); -

[PATCH] D146975: [NVPTX] Add __CUDA_ARCH__ macro to standalone NVPTX compilations

jhuber6 created this revision. jhuber6 added reviewers: tra, tianshilei1992, ye-luo, jdoerfert. Herald added subscribers: mattd, gchakrabarti, asavonic, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, jplehr, sstefan1, jholewins

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

PiotrZSL added a comment. In D146520#4224281 , @aaron.ballman wrote: > Ideally, users should be able to disable the core checks from running at all > (the reason users want to disable checks is both because of the diagnostics > they produce and because

[PATCH] D146847: [NFC] Fix uninitialized member variable use in RVVEmitter::createRVVIntrinsics()

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but you should fix up the commit message when you land since the patch has changed away from what's described in the summary. CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

aaron.ballman added a subscriber: NoQ. aaron.ballman added a comment. In D146520#4224483 , @PiotrZSL wrote: > In D146520#4224281 , @aaron.ballman > wrote: > >> Ideally, users should be able to disable the core ch

[PATCH] D146971: [Sema] Populate declarations inside TypeLocs for some invalid types

ilya-biryukov added a comment. In D146971#4224465 , @erichkeane wrote: > One other thing we probably should do is have an assert when creating a > function type that none of its params are null. WDYT? This would definitely be great, however I don't th

[PATCH] D146604: [NFC] Fix uninitalized member variable use in ASTReader::ParseTargetOptions()

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/TargetOptions.h:91 /// \brief Code object version for AMDGPU. - CodeObjectVersionKind CodeObjectVersion; + CodeObjectVersionKind CodeObjectVersion = CodeObjectVersionKind::COV_4; ta

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

VitaNuo updated this revision to Diff 508675. VitaNuo added a comment. Add a couple more macro test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146244/new/ https://reviews.llvm.org/D146244 Files: clang-tools-extra/clangd/Hover.cpp cla

[PATCH] D146971: [Sema] Populate declarations inside TypeLocs for some invalid types

erichkeane added a comment. In D146971#4224519 , @ilya-biryukov wrote: > In D146971#4224465 , @erichkeane > wrote: > >> One other thing we probably should do is have an assert when creating a >> function type t

[PATCH] D146431: [AIX][Driver] Implement -mxcoff-build-id option.

This revision was automatically updated to reflect the committed changes. Closed by commit rGda92f2fb33c4: [AIX][Driver] Implement -mxcoff-build-id option (authored by w2yehia). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES S

[clang] da92f2f - [AIX][Driver] Implement -mxcoff-build-id option

Author: Wael Yehia Date: 2023-03-27T15:36:41Z New Revision: da92f2fb33c4e5fc570a51b0615e3d30a5b0bf8f URL: https://github.com/llvm/llvm-project/commit/da92f2fb33c4e5fc570a51b0615e3d30a5b0bf8f DIFF: https://github.com/llvm/llvm-project/commit/da92f2fb33c4e5fc570a51b0615e3d30a5b0bf8f.diff LOG: [A

[PATCH] D146867: [Diagnostic] printing name of uninitialized subobject instead of its type

simideveloper added a comment. but I think this patch https://reviews.llvm.org/D146358 has not been accepted yet so you should give me a chance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146867/new/ https://reviews.llvm.org/D146867 __

[PATCH] D145737: PR60985: Fix merging of lambda closure types across modules.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. The changes here LGTM, but I'd appreciate it if a second set of eyes double-checked whether I missed anything, given the complexity of the changes. (So wait a day or so before la

[PATCH] D146867: [Diagnostic] printing name of uninitialized subobject instead of its type

aaron.ballman added a comment. In D146867#4224567 , @simideveloper wrote: > but I think this patch https://reviews.llvm.org/D146358 has not been accepted > yet so you should give me a chance. What we want to avoid is having reviewers review multiple pa

[clang] 1a35893 - [clang][ASTImporter] Import typedefs to distinct records as distinct nodes.

Author: Balázs Kéri Date: 2023-03-27T17:58:32+02:00 New Revision: 1a35893d2a58fdead33ec7daa9f1fe53f4787614 URL: https://github.com/llvm/llvm-project/commit/1a35893d2a58fdead33ec7daa9f1fe53f4787614 DIFF: https://github.com/llvm/llvm-project/commit/1a35893d2a58fdead33ec7daa9f1fe53f4787614.diff L

[PATCH] D145479: [clang][ASTImporter] Import typedefs to distinct records as distinct nodes.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1a35893d2a58: [clang][ASTImporter] Import typedefs to distinct records as distinct nodes. (authored by balazske). Changed prior to commit: https://reviews.llvm.org/D145479?vs=502947&id=508685#toc Repos

[PATCH] D146867: [Diagnostic] printing name of uninitialized subobject instead of its type

simideveloper added a comment. okk thankyou sir Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146867/new/ https://reviews.llvm.org/D146867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

gribozavr2 added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/HTMLLogger.cpp:34 +// the data into tags embedded in the HTML. (see inflate() in JS). +// +// SELECTION Comment at: clang/lib/Analysis/FlowSensitive/HTMLLogger.cp

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

gribozavr2 added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/HTMLLogger.html:19 +Function + + sammccall wrote: > gribozavr2 wrote: > > Could you add the file name and line number of the start location of the > > function? > > > > It might be h

[clang] ea35740 - [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible

Author: Daniel Grumberg Date: 2023-03-27T17:24:10+01:00 New Revision: ea35740e7e189cdcdd88344ac60a53a5b8a8318d URL: https://github.com/llvm/llvm-project/commit/ea35740e7e189cdcdd88344ac60a53a5b8a8318d DIFF: https://github.com/llvm/llvm-project/commit/ea35740e7e189cdcdd88344ac60a53a5b8a8318d.dif

[clang] 21750a1 - [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible

Author: Daniel Grumberg Date: 2023-03-27T17:24:10+01:00 New Revision: 21750a1ae8c86ffefc72f115116c80a98a0792dc URL: https://github.com/llvm/llvm-project/commit/21750a1ae8c86ffefc72f115116c80a98a0792dc DIFF: https://github.com/llvm/llvm-project/commit/21750a1ae8c86ffefc72f115116c80a98a0792dc.dif

[PATCH] D146656: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG21750a1ae8c8: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible (authored by dang). Changed prior to commit: https://revie

[clang] d0dd151 - Address code review feedback

Author: Daniel Grumberg Date: 2023-03-27T17:24:10+01:00 New Revision: d0dd151eed4bb9a6ea209790e2727c0a007f699a URL: https://github.com/llvm/llvm-project/commit/d0dd151eed4bb9a6ea209790e2727c0a007f699a DIFF: https://github.com/llvm/llvm-project/commit/d0dd151eed4bb9a6ea209790e2727c0a007f699a.dif

[PATCH] D146946: [RISCV][MC] Add support for experimental zicond extension

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146946/new/ https://reviews.llvm.org/D146946 ___

[clang] b530e1a - [LinkerWrapper] Do not extract globals with no offloading language

Author: Joseph Huber Date: 2023-03-27T11:38:27-05:00 New Revision: b530e1af62be16ffb06285ddca27a413f5089b7e URL: https://github.com/llvm/llvm-project/commit/b530e1af62be16ffb06285ddca27a413f5089b7e DIFF: https://github.com/llvm/llvm-project/commit/b530e1af62be16ffb06285ddca27a413f5089b7e.diff

[PATCH] D146326: [LinkerWrapper] Do not extract globals with no offloading language

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb530e1af62be: [LinkerWrapper] Do not extract globals with no offloading language (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANG

[clang] 9ea912f - [diagtool] explain that yellow is used to denote disabled-by-default warnings

Author: Nick Desaulniers Date: 2023-03-27T09:41:30-07:00 New Revision: 9ea912fe978df3057a74542d9e22d871e2b899dd URL: https://github.com/llvm/llvm-project/commit/9ea912fe978df3057a74542d9e22d871e2b899dd DIFF: https://github.com/llvm/llvm-project/commit/9ea912fe978df3057a74542d9e22d871e2b899dd.di

[PATCH] D146827: [diagtool] explain that yellow is used to denote disabled-by-default warnings

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ea912fe978d: [diagtool] explain that yellow is used to denote disabled-by-default warnings (authored by nickdesaulniers). Repository: rG LLVM Git

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

VitaNuo updated this revision to Diff 508708. VitaNuo added a comment. Remove extra check (already done in walkUsed). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146244/new/ https://reviews.llvm.org/D146244 Files: clang-tools-extra/clangd/Hove

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

francii updated this revision to Diff 508709. francii added a comment. Remove `NoArgumentUnused`, claim -K when checking target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146399/new/ https://reviews.llvm.org/D146399 Files: clang/include/clan

[clang] 0f4c9c0 - [RISCV] Replace RISCV->RISC-V in strings.

Author: Craig Topper Date: 2023-03-27T09:50:17-07:00 New Revision: 0f4c9c016caf52dc45934e0cbf82b1daabcf1d96 URL: https://github.com/llvm/llvm-project/commit/0f4c9c016caf52dc45934e0cbf82b1daabcf1d96 DIFF: https://github.com/llvm/llvm-project/commit/0f4c9c016caf52dc45934e0cbf82b1daabcf1d96.diff

[clang] 2946361 - [RISCV] Replace RISCV -> RISC-V in comments. NFC

Author: Craig Topper Date: 2023-03-27T09:50:17-07:00 New Revision: 29463612d21b7d630476fcecdc8301ddf5634bf7 URL: https://github.com/llvm/llvm-project/commit/29463612d21b7d630476fcecdc8301ddf5634bf7 DIFF: https://github.com/llvm/llvm-project/commit/29463612d21b7d630476fcecdc8301ddf5634bf7.diff

[PATCH] D146451: [RISCV] Replace RISCV->RISC-V in strings.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0f4c9c016caf: [RISCV] Replace RISCV->RISC-V in strings. (authored by craig.topper). Changed prior to commit: https://reviews.llvm.org/D146451?vs=5

[PATCH] D146449: [RISCV] Replace RISCV -> RISC-V in comments. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG29463612d21b: [RISCV] Replace RISCV -> RISC-V in comments. NFC (authored by craig.topper). Changed prior to commit: https://reviews.llvm.org/D146449?vs=506670&id=508710#toc Repository: rG LLVM Github

[PATCH] D146986: Downgrade reserved module identifier error into a warning

aaron.ballman created this revision. aaron.ballman added reviewers: ChuanqiXu, dblaikie, Mordante, iains. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. Any project that wants to `import std;` potentially needs to be able to build a mo

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

rjmccall added a comment. In D146148#4224094 , @aaron.ballman wrote: > In D146148#4222306 , @zahiraam > wrote: > >> In D146148#4221651 , @rjmccall >> wrote: >> >>> Zahi

[PATCH] D146975: [NVPTX] Add __CUDA_ARCH__ macro to standalone NVPTX compilations

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146975/new/ https://reviews.llvm.org/D146975 ___

[PATCH] D146188: [Clang][DOC] Add documentation in for __builtin_flt_rounds and __builtin_set_flt_rounds

rjmccall added a comment. In D146188#4223249 , @xiongji90 wrote: > Hi, @rjmccall and @sepavloff > In UserManual, we include a section `Controlling Floating Point Behavior`: > https://github.com/llvm/llvm-project/blob/main/clang/docs/UsersManual.rst#cont

[PATCH] D146975: [NVPTX] Add __CUDA_ARCH__ macro to standalone NVPTX compilations

tra accepted this revision. tra added inline comments. Comment at: clang/lib/Basic/Targets/NVPTX.cpp:171 Builder.defineMacro("__NVPTX__"); - if (Opts.CUDAIsDevice || Opts.OpenMPIsDevice) { + if (Opts.CUDAIsDevice || Opts.OpenMPIsDevice || !HostTarget) { // Set __CUDA_AR

[PATCH] D146975: [NVPTX] Add __CUDA_ARCH__ macro to standalone NVPTX compilations

jhuber6 marked an inline comment as done. jhuber6 added inline comments. Comment at: clang/lib/Basic/Targets/NVPTX.cpp:171 Builder.defineMacro("__NVPTX__"); - if (Opts.CUDAIsDevice || Opts.OpenMPIsDevice) { + if (Opts.CUDAIsDevice || Opts.OpenMPIsDevice || !HostTarget) {

[PATCH] D146892: [documentation]Fixed Random Typo

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146892/new/ https://reviews.llvm.org/D146892

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1230 + llvm::sys::path::append(P, "llvm-libc"); + CmdArgs.push_back("-c-isystem"); + CmdArgs.push_back(Args.MakeArgString(P)); Ensuring the right include order will be tri

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Febbe added a comment. In D137205#4222920 , @ccotter wrote: > @Febbe - checking in. is this still on your radar? I would love to see this > merged! Yes, this is still on my radar, but currently, I am not satisfied with my solution. There are too many i

[PATCH] D137379: [-Wunsafe-buffer-usage] Add warnings for unsafe buffer accesses by array subscript operations

manojgupta added a comment. This is firing even in checked length codes, is that expected? example: https://godbolt.org/z/Todje76ao std::optional result; bool ReadDevice(uint8_t* data, size_t len) { if (!result) return false; memset(data, 0, len); if (len > 0) data[0] =

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Febbe added a comment. In D137205#4224236 , @firewave wrote: > Some additional thoughts I had a while ago about something I have raised > before: > I think the warnings which can only be fixed with c++14 should either only be > issued if that standard w

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:3586-3591 + // MSVC treats all predefined expressions as string literals rather than char + // arrays. + if (LangOpts.MicrosoftExt) +return SL; + return PredefinedExpr::Create(Context, Loc, Res

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:976-985 + bool IsInputTyAsm = false; + for (const auto &II : Inputs) { +CmdArgs.push_back(II.getFilename()); +StringRef BaseInput = StringRef(II.getBaseInput()); +types::ID InputT

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1230 + llvm::sys::path::append(P, "llvm-libc"); + CmdArgs.push_back("-c-isystem"); + CmdArgs.push_back(Args.MakeArgString(P)); tra wrote: > Ensuring the right include

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

garvitgupta08 added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:976-985 + bool IsInputTyAsm = false; + for (const auto &II : Inputs) { +CmdArgs.push_back(II.getFilename()); +StringRef BaseInput = StringRef(II.getBaseInput()); +types::ID InputTyp

[PATCH] D146595: [clang] Add clang trampoline_mangled_target attribute

dblaikie added a comment. I know this is a bit of a redirection/scope creep/etc - but I'd quite like to see a solution that is likely to be usable for the "std::function" problem (stepping into std::function should allow you to reach the underlying function - but lldb currently skips any call t

[PATCH] D146686: [Driver] Fix rpath for compiler-rt

MaskRay added a comment. The new test can be placed in `arch-specific-libdir-rpath.c`. One or two additional RUN lines seem sufficient, no need to duplicate too many. Also, use `--target=` for new tests and avoid `^//$`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146686/new/ https:

[PATCH] D146686: [Driver] Fix rpath for compiler-rt

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/OHOS.cpp:140 getFilePaths().clear(); - std::string CandidateLibPath = getArchSpecificLibPath(); - if (getVFS().exists(CandidateLibPath)) -getFilePaths().push_back(CandidateLibPath); + for (const auto

[PATCH] D146234: [clang] Fix crash when handling nested immediate invocations

aaron.ballman added a comment. I think this LGTM, but I'm holding off on signing off until @shafik is satisfied with the part he was asking about. You should add a release note for the fix, too. Comment at: clang/lib/Sema/SemaExpr.cpp:17891-17894 + // It is possible that

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

garvitgupta08 added a comment. I do not have the commit access, can you commit on my behalf @nickdesaulniers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145726/new/ https://reviews.llvm.org/D145726 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D146801: [clang] Fix consteval initializers of temporaries

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Precommit CI is still falling over because of the libcxx bot. That issue is being actively investigated, but we don't have an ETA on it being resolved. I think these changes are sufficiently safe to land and watch for pos

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

firewave added a comment. In D137205#4225006 , @Febbe wrote: > Yes, I agree, while I can't understand, why someone still wants to use only > c++11 I can totally understand, that a single Software Engineer can't do > anything about this, when the corpora

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

jp4a50 updated this revision to Diff 508740. jp4a50 added a comment. Address minor review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146101/new/ https://reviews.llvm.org/D146101 Files: clang/docs/ClangFormatStyleOptions.rst clang/

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

tra added a subscriber: echristo. tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1230 + llvm::sys::path::append(P, "llvm-libc"); + CmdArgs.push_back("-c-isystem"); + CmdArgs.push_back(Args.MakeArgString(P)); jhuber6 wr

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

jp4a50 marked an inline comment as done. jp4a50 added a comment. All actionable comments have been addressed. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1665-1669 + const auto DesignatedInitializerIndentWidth = + Style.DesignatedInitializerIndentWidth <

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1230 + llvm::sys::path::append(P, "llvm-libc"); + CmdArgs.push_back("-c-isystem"); + CmdArgs.push_back(Args.MakeArgString(P)); tra wrote: > jhuber6 wrote: > > tra wrot

[PATCH] D146986: Downgrade reserved module identifier error into a warning

dblaikie added a comment. From the discussion on the issue: > Do we want this loosening of the restriction to apply to *only* `std` and the > same followed by a number, or to any reserved identifier used in a module? > e.g., > > module std; // error today, but will become a warning > module

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

dblaikie added inline comments. Comment at: clang/test/CodeGen/preferred_name.cpp:49 + +Foo> varFooInt; + Michael137 wrote: > probinson wrote: > > This doesn't become `Foo` ? > The name stays as `Foo>` but the type of the template parameter > becomes `BarInt

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

sivachandra added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1230 + llvm::sys::path::append(P, "llvm-libc"); + CmdArgs.push_back("-c-isystem"); + CmdArgs.push_back(Args.MakeArgString(P)); jhuber6 wrote: > tra wrote: > > jhub

[PATCH] D146595: [clang] Add clang trampoline_mangled_target attribute

aprantl added a comment. In D146595#4225048 , @dblaikie wrote: > I know this is a bit of a redirection/scope creep/etc - but I'd quite like to > see a solution that is likely to be usable for the "std::function" problem > (stepping into std::function sh

[PATCH] D146924: [clang] Add support for dollar sign in ud_suffix of numeric constants

annara added a comment. Thanks for all the input! I'll work on @cor3ntin points and take a look at the crash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146924/new/ https://reviews.llvm.org/D146924 __

[clang] dedd7b6 - Added checking for completeness of lvalue in conditional operator

Author: Aditya Singh Date: 2023-03-27T14:47:08-04:00 New Revision: dedd7b6548f4a37f4f691aa0cd3a709756b7e794 URL: https://github.com/llvm/llvm-project/commit/dedd7b6548f4a37f4f691aa0cd3a709756b7e794 DIFF: https://github.com/llvm/llvm-project/commit/dedd7b6548f4a37f4f691aa0cd3a709756b7e794.diff

[PATCH] D144358: [clang][github] Added checking for completeness of lvalue in conditional operator [#59718]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdedd7b6548f4: Added checking for completeness of lvalue in conditional operator (authored by Aditya-pixel, committed by aaron.ballman). Herald added

[PATCH] D144358: [clang][github] Added checking for completeness of lvalue in conditional operator [#59718]

aaron.ballman added a comment. In D144358#4225139 , @Aditya-pixel wrote: > Oh, okay, Ill change the patch now. Also, it seems my local directory is out > of sync. Should I always update it before submitting a patch, or is it > alright without updating

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 marked an inline comment as not done. Michael137 added inline comments. Comment at: clang/test/CodeGen/preferred_name.cpp:49 + +Foo> varFooInt; + dblaikie wrote: > Michael137 wrote: > > probinson wrote: > > > This doesn't become `Foo` ? > > The nam

[PATCH] D146595: [clang] Add clang trampoline_mangled_target attribute

aaron.ballman added a comment. In D146595#4225132 , @aprantl wrote: > In D146595#4225048 , @dblaikie > wrote: > >> I know this is a bit of a redirection/scope creep/etc - but I'd quite like >> to see a solution

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:4343 + WhitespaceSensitiveMacros == R.WhitespaceSensitiveMacros && + Macros == R.Macros; } I put a lot of effort into bringing the stuff sorted. And n

[PATCH] D146840: [AMDGPU] Replace target feature for global fadd32

rampitec requested changes to this revision. rampitec added a comment. This revision now requires changes to proceed. You cannot just enable it on gfx908 which does not have return version of it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146840/

[PATCH] D146595: [clang] Add clang trampoline_mangled_target attribute

dblaikie added a comment. In D146595#4225132 , @aprantl wrote: > In D146595#4225048 , @dblaikie > wrote: > >> I know this is a bit of a redirection/scope creep/etc - but I'd quite like >> to see a solution that

[PATCH] D146986: Downgrade reserved module identifier error into a warning

aaron.ballman added a comment. In D146986#4225121 , @dblaikie wrote: > From the discussion on the issue: > >> Do we want this loosening of the restriction to apply to *only* `std` and >> the same followed by a number, or to any reserved identifier used i

[PATCH] D137379: [-Wunsafe-buffer-usage] Add warnings for unsafe buffer accesses by array subscript operations

ziqingluo-90 added a comment. In D137379#4225000 , @manojgupta wrote: > This is firing even in checked length codes, is that expected? Yes, it is expected. The unsafe buffer analysis is syntax-based. The analysis warns operations that do not follow t

[PATCH] D146338: [MSVC compatibility][dllimport/dllexport][PS] Allow dllexport/dllimport for classes with UniqueExternalLinkage

wolfgangp updated this revision to Diff 508747. wolfgangp marked an inline comment as done. wolfgangp added a comment. Added 2 test cases that check that dll{ex,im}ported classes that are instantiated with classes with internal linkage as template arguments are not exported or imported. Had to

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1230 + llvm::sys::path::append(P, "llvm-libc"); + CmdArgs.push_back("-c-isystem"); + CmdArgs.push_back(Args.MakeArgString(P)); sivachandra wrote: > jhuber6 wrote: > > tra

<    1   2   3   >