[PATCH] D146490: [Support] On Windows, ensure that UniqueID is really stable

2023-03-20 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea created this revision. aganea added reviewers: mstorsjo, hans, kbobyrev, dexonsmith, zero9178. Herald added subscribers: kadircet, arphaman, hiraditya. Herald added a project: All. aganea requested review of this revision. Herald added projects: clang, LLVM, clang-tools-extra. Herald added s

[PATCH] D146187: [docs] Update the status for coroutines

2023-03-20 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added a comment. > Okay, that pretty much paints us into a corner, I guess. If we don't define > it any longer, we break existing (working) uses of the feature on Windows, > but we defined it prematurely. In this case, let's leave the macro defined so > we don't break existing uses --

[PATCH] D146490: [Support] On Windows, ensure that UniqueID is really stable

2023-03-20 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea updated this revision to Diff 506820. Herald added a subscriber: ormris. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146490/new/ https://reviews.llvm.org/D146490 Files: clang-tools-extra/clangd/unittests/FSTests.cpp clang/include/clang/

[clang] 8894fe7 - [docs] Update the status for coroutines

2023-03-20 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2023-03-21T10:34:33+08:00 New Revision: 8894fe7a6f3efad371d64a1825ba3f4a6704d604 URL: https://github.com/llvm/llvm-project/commit/8894fe7a6f3efad371d64a1825ba3f4a6704d604 DIFF: https://github.com/llvm/llvm-project/commit/8894fe7a6f3efad371d64a1825ba3f4a6704d604.diff LO

[PATCH] D146187: [docs] Update the status for coroutines

2023-03-20 Thread Chuanqi Xu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8894fe7a6f3e: [docs] Update the status for coroutines (authored by ChuanqiXu). Changed prior to commit: https://reviews.llvm.org/D146187?vs=505979&id=506821#toc Repository: rG LLVM Github Monorepo C

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

2023-03-20 Thread Slava Zakharin via Phabricator via cfe-commits
vzakhari added a comment. LGTM Please address @awarzynski's comment about the test. Comment at: flang/include/flang/Tools/CLOptions.inc:235 +/// passes pipeline +inline void createHLFIRToFIRPassPipeline(mlir::PassManager &pm, +llvm::OptimizationLevel optLevel = defaultOpt

[PATCH] D146497: libclang: Pass Clang install directory to driver via argv[0].

2023-03-20 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc created this revision. pcc added reviewers: bkramer, aaron.ballman. Herald added subscribers: mikhail.ramalho, arphaman. Herald added a project: All. pcc requested review of this revision. Herald added a project: clang. Various driver features, such as the sysroot path detection for Android ta

[PATCH] D146434: [clang-format] Fix support for ObjC blocks with pointer return types

2023-03-20 Thread Jared Grubb via Phabricator via cfe-commits
jaredgrubb added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:22178 "});"); - verifyFormat("Block b = ^int *(A *a, B *b) {}"); + verifyFormat("Block b = ^int *(A *a, B *b) {\n" + "};"); MyDeveloperDay wrote: >

[PATCH] D146269: MIPS: allow o32 abi with 64bit CPU and 64 abi with 32bit triple

2023-03-20 Thread YunQiang Su via Phabricator via cfe-commits
wzssyqa updated this revision to Diff 506838. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146269/new/ https://reviews.llvm.org/D146269 Files: clang/lib/Basic/Targets/Mips.cpp clang/test/Driver/mips-abi.c clang/test/Driver/mips-cpu64abi32.c llvm/lib/Target/Mips/MipsSubtarget.cpp

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

2023-03-20 Thread Paul Kirth via Phabricator via cfe-commits
paulkirth added inline comments. Comment at: llvm/test/CodeGen/RISCV/shadowcallstack.ll:184 + +; RUN: llc -mtriple=riscv32 -mattr=+reserve-x27 < %s | FileCheck %s -check-prefix=RV32I +; RUN: llc -mtriple=riscv64 -mattr=+reserve-x27 < %s | FileCheck %s -check-prefix=RV64I --

[clang-tools-extra] 35c2aac - Revert "Revert "[clangd] Fix AddUsing in the face of typo-correction""

2023-03-20 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2023-03-21T07:27:21+01:00 New Revision: 35c2aac6e3957c2e82bf92269039fa02bab0e1d9 URL: https://github.com/llvm/llvm-project/commit/35c2aac6e3957c2e82bf92269039fa02bab0e1d9 DIFF: https://github.com/llvm/llvm-project/commit/35c2aac6e3957c2e82bf92269039fa02bab0e1d9.dif

[PATCH] D146188: [Clang][DOC] Add documentation in for __builtin_flt_rounds and __builtin_set_flt_rounds

2023-03-20 Thread xiongji90 via Phabricator via cfe-commits
xiongji90 added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3288 +This builtin is restrcted to work on x86 and arm targets currently. When support +for the builtin is added for new targets, the manual should be updated accordingly. + rjmccall

[clang-tools-extra] 029ec03 - [clangd][NFC] Format & include cleanup for AddUsingTests.cpp

2023-03-20 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2023-03-21T07:53:08+01:00 New Revision: 029ec03a096901a83d650ac08375b78f9161ab51 URL: https://github.com/llvm/llvm-project/commit/029ec03a096901a83d650ac08375b78f9161ab51 DIFF: https://github.com/llvm/llvm-project/commit/029ec03a096901a83d650ac08375b78f9161ab51.dif

<    1   2   3