[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

2023-03-17 Thread Slava Zakharin via Phabricator via cfe-commits
vzakhari added a comment. Thank you for working on this! Comment at: flang/include/flang/Tools/CLOptions.inc:235 +/// passes pipeline +inline void createHLFIRToFIRPassPipeline(mlir::PassManager &pm, +llvm::OptimizationLevel optLevel = defaultOptLevel) { W

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

2023-03-17 Thread Viktoriia Bakalova via Phabricator via cfe-commits
VitaNuo updated this revision to Diff 506141. VitaNuo added a comment. Finish the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146244/new/ https://reviews.llvm.org/D146244 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clan

[PATCH] D145639: [Coroutines] Fix premature conversion of return object

2023-03-17 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno added a comment. > @bruno, @ChuanqiXu please let us know if you have any objections, otherwise > we will land the revert in ~2 hours. No sweat, I didn't see this in time. Thanks for the reduced testcase. > What's the resolution here? Can we revert this and continue the discussions > inde

[PATCH] D146247: [clang-format] Support TypeScript satisfies operator

2023-03-17 Thread Taymon A. Beal via Phabricator via cfe-commits
taymonbeal updated this revision to Diff 506153. taymonbeal added a comment. Add release notes and unit test in TokenAnnotatorTest.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146247/new/ https://reviews.llvm.org/D146247 Files: clang/docs/R

[PATCH] D146247: [clang-format] Support TypeScript satisfies operator

2023-03-17 Thread Taymon A. Beal via Phabricator via cfe-commits
taymonbeal added a comment. I don't have commit access; can someone who does commit this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146247/new/ https://reviews.llvm.org/D146247 ___ cfe-commits mailin

[PATCH] D145737: PR60985: Fix merging of lambda closure types across modules.

2023-03-17 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. In D145737#4202351 , @aaron.ballman wrote: > Checking: are the libc++ precommit CI failures related to these changes? It's > a modules-specific build config, so I figured it's worth double-checking. I took a quick glance when I

[PATCH] D146163: Experimental new python bindings for clang/llvm based on Cython

2023-03-17 Thread Rick Mark via Phabricator via cfe-commits
rickmark added a comment. Began discussion in Discord to see interest for other collaborators on this type of binding: https://discord.com/channels/636084430946959380/700158649129238591/1086362007684513844 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D146163: Experimental new python bindings for clang/llvm based on Cython

2023-03-17 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. In D146163#4202969 , @rickmark wrote: > Began discussion in Discord to see interest for other collaborators on this > type of binding: > https://discord.com/channels/636084430946959380/700158649129238591/1086362007684513844 Yo

[PATCH] D146323: inline stmt attribute diagnosing in templates

2023-03-17 Thread Erich Keane via Phabricator via cfe-commits
erichkeane created this revision. erichkeane added a reviewer: clang-language-wg. Herald added a project: All. erichkeane requested review of this revision. D146089 's author discovered that our diagnostics for always/no inline would null-dereference when used in

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

2023-03-17 Thread Douglas Yung via Phabricator via cfe-commits
dyung added a comment. @DmitryPolukhin your change seems to be causing a crash in 2 ORC tests on a bot (trivial-cxa-atexit.S and trivial-atexit.S), can you take a look or revert if you need time to investigate? https://lab.llvm.org/buildbot/#/builders/247/builds/2639 TES

[PATCH] D146187: [docs] Update the status for coroutines

2023-03-17 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno added a comment. > ... I think in general we want feature testing macros to be treated as our > signal to the user that we think something is complete, not that we think > something is in progress but pretty usable. +1 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146187/new/ h

[PATCH] D146041: Fix weirdly apologetic diagnostic messages

2023-03-17 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. I have no strong opinions on the merits of this patch in either direction; I think the "sorry"s in the Sema diagnostics for regrettable non-conformance make Clang marginally friendlier, but they do nothing to actually help people who encounter the diagnostic. FWIW, the

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

2023-03-17 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin added a comment. In D143436#4203008 , @dyung wrote: > @DmitryPolukhin your change seems to be causing a crash in 2 ORC tests on a > bot (trivial-cxa-atexit.S and trivial-atexit.S), can you take a look or > revert if you need time to inves

[PATCH] D146326: [LinkerWrapper] Do not extract globals with no offloading language

2023-03-17 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, tra, yaxunl, tianshilei1992. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald added a project: clang. The linker wrapper needs

[PATCH] D146328: [clang][deps] Only cache files with specific extension

2023-03-17 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, benlangmuir. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In the scanner's VFS, w

[clang] 6acdf58 - [clang] Properly parse variable template requires clause in lambda

2023-03-17 Thread Emilia Dreamer via cfe-commits
Author: Emilia Dreamer Date: 2023-03-17T22:29:48+02:00 New Revision: 6acdf58919d5e66809555acf5809b12c54ba79dd URL: https://github.com/llvm/llvm-project/commit/6acdf58919d5e66809555acf5809b12c54ba79dd DIFF: https://github.com/llvm/llvm-project/commit/6acdf58919d5e66809555acf5809b12c54ba79dd.diff

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

2023-03-17 Thread Emilia Dreamer via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6acdf58919d5: [clang] Properly parse variable template requires clause in lambda (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D146328: [clang][deps] Only cache files with specific extension

2023-03-17 Thread Juergen Ributzka via Phabricator via cfe-commits
ributzka added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:161 -/// Whitelist file extensions that should be minimized, treating no extension as -/// a source file that should be minimized. +/// Whitelist file extensions

[PATCH] D146326: [LinkerWrapper] Do not extract globals with no offloading language

2023-03-17 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 updated this revision to Diff 506190. jhuber6 added a comment. Remove whitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146326/new/ https://reviews.llvm.org/D146326 Files: clang/test/Driver/linker-wrapper-libs.c clang/tools/clan

[PATCH] D145820: [Clang][OpenMP] Insert alloca for kernel args at function entry block instead of the launch point.

2023-03-17 Thread Dhruva Chakrabarti via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1c9ec74e3f2a: [Clang][OpenMP] Insert alloca for kernel args at function entry block instead… (authored by dhruvachak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D146329: [Clang] Fix defaulted equality operator so that it does not attempt to compare unnamed bit-fields

2023-03-17 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik created this revision. shafik added reviewers: aaron.ballman, erichkeane, rsmith. Herald added a project: All. shafik requested review of this revision. If we look at class.bit p2 it tells us that that unnamed bit-fields are not members and

[PATCH] D146329: [Clang] Fix defaulted equality operator so that it does not attempt to compare unnamed bit-fields

2023-03-17 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. I would have loved to test the case from https://github.com/llvm/llvm-project/issues/61335 directly but I think in order to do it nicely I need `__builtin_memset` to be usable in a constant expression context. I will add this to my todo list. I am open to other alternati

[PATCH] D146328: [clang][deps] Only cache files with specific extension

2023-03-17 Thread Michael Spencer via Phabricator via cfe-commits
Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. This doesn't appear to behave as expected for `PP_CacheFailure` or `PP_ScanFile` without `PP_CacheSuccess`. Looks like that will still cache. Should probably just assert that's not the c

[PATCH] D146328: [clang][deps] Only cache files with specific extension

2023-03-17 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 updated this revision to Diff 506205. jansvoboda11 added a comment. Remove configurable `CacheSuccess`, rename `CacheFailure` to `CacheStatFailure`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146328/new/ https://reviews.llvm.org/D14

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

2023-03-17 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin added a comment. @dyung I cannot reproduce this issue on two different machines in both cases tests work fine. For clang and llvm-jitlink binaries (the only binaries used in the tests) my changes are non-functional and I didn't change anything in compiler-rt or ORC. Are you able

[PATCH] D146328: [clang][deps] Only cache files with specific extension

2023-03-17 Thread Michael Spencer via Phabricator via cfe-commits
Bigcheese added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningFilesystem.h:272-291 +enum class Enable { Yes, No }; +enum class ScanFile { Yes, No }; +enum class CacheStatFailure { Yes, No }; + +struct PathPolicy { + unsigned Enabl

[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

2023-03-17 Thread Oleg Skoromnik via Phabricator via cfe-commits
tupos updated this revision to Diff 506220. tupos marked 11 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140275/new/ https://reviews.llvm.org/D140275 Files: clang-tools-extra/clangd/refactor/tweaks/AddDoxygenComment.cpp

[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

2023-03-17 Thread Oleg Skoromnik via Phabricator via cfe-commits
tupos added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/AddDoxygenComment.cpp:24 +namespace clang { +namespace clangd { +namespace { tschuett wrote: > You can merge this into `namespace clang::clangd`. I prefer not to do it, because all

[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

2023-03-17 Thread Oleg Skoromnik via Phabricator via cfe-commits
tupos added a comment. Could you please also advice me what else need to be done for the ObjC, since there were many years since I wrote ObjC last time I'm not sure what else need to be done there. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D146338: [MSVC compatibility][dllimport/dllexport][PS] Allow dllexport/dllimport for classes with UniqueExternalLinkage

2023-03-17 Thread Wolfgang Pieb via Phabricator via cfe-commits
wolfgangp created this revision. wolfgangp added reviewers: hans, probinson, mstorsjo. Herald added a project: All. wolfgangp requested review of this revision. This replaces D145271 . Rather than coercing classes with UniqueExternalLInkage to ExternalLinkage as

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

2023-03-17 Thread Douglas Yung via Phabricator via cfe-commits
dyung added a comment. In D143436#4203394 , @DmitryPolukhin wrote: > @dyung I cannot reproduce this issue on two different machines in both cases > tests work fine. For clang and llvm-jitlink binaries (the only binaries used > in the tests) my changes

[PATCH] D146328: [clang][deps] Only cache files with specific extension

2023-03-17 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 updated this revision to Diff 506237. jansvoboda11 added a comment. Herald added a subscriber: ormris. Use named constructors instead of an argument to `PathPolicy`, add unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146328/n

[PATCH] D146342: [WIP][-Wunsafe-buffer-usage] Move the whole analysis to the end of a translation unit

2023-03-17 Thread Ziqing Luo via Phabricator via cfe-commits
ziqingluo-90 created this revision. ziqingluo-90 added reviewers: NoQ, jkorous, t-rasmud, malavikasamak. Herald added a subscriber: ChuanqiXu. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Our ana

[PATCH] D146328: [clang][deps] Only cache files with specific extension

2023-03-17 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 updated this revision to Diff 506240. jansvoboda11 added a comment. Use brace initialization in named constructors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146328/new/ https://reviews.llvm.org/D146328 Files: clang/include/clang

[PATCH] D146328: [clang][deps] Only cache files with specific extension

2023-03-17 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 updated this revision to Diff 506241. jansvoboda11 added a comment. Disable brace initialization Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146328/new/ https://reviews.llvm.org/D146328 Files: clang/include/clang/Tooling/Dependenc

[PATCH] D146328: [clang][deps] Only cache files with specific extension

2023-03-17 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 updated this revision to Diff 506242. jansvoboda11 added a comment. Improve member documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146328/new/ https://reviews.llvm.org/D146328 Files: clang/include/clang/Tooling/Dependenc

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

2023-03-17 Thread Slava Zakharin via Phabricator via cfe-commits
vzakhari added inline comments. Comment at: flang/include/flang/Tools/CLOptions.inc:238 + pm.addPass(mlir::createCanonicalizerPass()); + pm.addPass(hlfir::createLowerHLFIRIntrinsicsPass()); + pm.addPass(hlfir::createBufferizeHLFIRPass()); I would imagine we ma

[PATCH] D140663: CUDA/HIP: Use kernel name to map to symbol

2023-03-17 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. It appears that this patch may be causing a use-after free when we attempt to generate kernel registration code. The root cause is that the value we insert into `KernelHandles` by name is later on replaced by a different instance of the global value with the same name. AFA

[PATCH] D146328: [clang][deps] Only cache files with specific extension

2023-03-17 Thread Michael Spencer via Phabricator via cfe-commits
Bigcheese accepted this revision. Bigcheese added a comment. lgtm, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146328/new/ https://reviews.llvm.org/D146328 ___ cfe-commits mailing list cfe-comm

[PATCH] D140663: CUDA/HIP: Use kernel name to map to symbol

2023-03-17 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D140663#4203604 , @tra wrote: > It appears that this patch may be causing a use-after free when we attempt to > generate kernel registration code. > The root cause is that the value we insert into `KernelHandles` by name is >

[PATCH] D145721: [HIP] clang should pass `-mno-amdgpu-ieee` to -cc1

2023-03-17 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D145721#4182834 , @tra wrote: >> clang should pass `-mno-amdgpu-ieee` to -cc1 > > It would be useful to have some details on why we should pass that option. `-mamdgpu-ieee` was introduced by https://reviews.llvm.org/D77013 but

[clang] 864a2b2 - [AMDGPU] Reserve extra SGPR blocks wth XNACK "any" TID Setting

2023-03-17 Thread Austin Kerbow via cfe-commits
Author: Austin Kerbow Date: 2023-03-17T20:26:23-07:00 New Revision: 864a2b25beac507cc76b50030757283aae434c0c URL: https://github.com/llvm/llvm-project/commit/864a2b25beac507cc76b50030757283aae434c0c DIFF: https://github.com/llvm/llvm-project/commit/864a2b25beac507cc76b50030757283aae434c0c.diff

[PATCH] D145401: [AMDGPU] Reserve extra SGPR blocks wth XNACK "any" TID Setting

2023-03-17 Thread Austin Kerbow via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG864a2b25beac: [AMDGPU] Reserve extra SGPR blocks wth XNACK "any" TID Setting (authored by kerbowa). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145401/new/

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

2023-03-17 Thread Douglas Yung via Phabricator via cfe-commits
dyung added a comment. In D143436#4203525 , @dyung wrote: > In D143436#4203394 , > @DmitryPolukhin wrote: > >> @dyung I cannot reproduce this issue on two different machines in both cases >> tests work fine. For

[PATCH] D145843: [clangd] Add option to always insert headers with <> instead of ""

2023-03-17 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. Thanks for the patch! May I suggest the flag name `IncludeDelimiter`, with values `Auto` and `AlwaysBrackets` (with the default being `Auto`)? This leaves room for other styles in the future if desired. It would mean a slight implementation change since the YAML represe

<    1   2