[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

erichkeane added a comment. In D145892#4191220 , @HerrCai0907 wrote: > I cannot find an example that throw `error: expression contains unexpanded > parameter pack 'T'` in fold expression because code like ` (foo(10 + > (static_cast(1))) + ...);` can be

[PATCH] D145906: [clang-tidy] Correctly handle evaluation order of designated initializers.

mboehme added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/ExprSequence.cpp:67 +llvm::SmallVector +allInitListExprForms(const InitListExpr *InitList) { + llvm::SmallVector result = {InitList}; PiotrZSL wrote: > maybe some other name instead of

[PATCH] D145868: [clang][ASTImporter] Fix import of anonymous structures

balazske added a comment. The problem is somewhat bigger and not fast to fix. This test shows what is problematic: TEST_P(ASTImporterOptionSpecificTestBase, ImportExistingTypedefToUnnamedRecordPtr) { const char *Code = R"( typedef const struct { int fff; } * const

[PATCH] D145545: [clang][Interp] Fix local variable (destructor) management in loop bodies

tbaeder updated this revision to Diff 505084. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145545/new/ https://reviews.llvm.org/D145545 Files: clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST/Interp/ByteCodeStmtGen.h Index: clang/lib/A

[PATCH] D145391: [HIP] Supports env var HIP_PATH

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:442 + llvm::sys::Process::GetEnv("HIP_PATH")) { +if (!HIPPathEnv->empty()) { + HIPSearchDirs.emplace_back(std::move(*HIPPathEnv));

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some small nits that you can fix when landing. Thank you for your patience on this review! Comment at: clang/lib/AST/DeclBase.cpp:1056 + else

[PATCH] D143479: [Clang] Emit error when caller cannot meet target feature requirement from always-inlining callee

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Thanks for your patience, I was buried trying to get the 16.0 release done. This LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[PATCH] D145408: Fix false positive with unreachable C++ catch handlers

aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145408/new/ https://reviews.llvm.org/D145408 ___ cfe-commits mailing list

[PATCH] D146026: [clangd] Patch PragmaMarks in preamble section of the file

kadircet updated this revision to Diff 505091. kadircet marked an inline comment as done. kadircet added a comment. - Use collectPragmaMarksCallback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146026/new/ https://reviews.llvm.org/D146026 Files:

[PATCH] D145906: [clang-tidy] Correctly handle evaluation order of designated initializers.

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Looks good to me, consider adding info to Release notes, that this check has been improved/fixed support for designated initializers. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D146026: [clangd] Patch PragmaMarks in preamble section of the file

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:576 + +std::vector getPragmaMarks(const ScannedPreamble &Modified) { + std::vector Marks; hokein wrote: > any reason not calling `collectPragmaMarksCallback` just like the > https

[PATCH] D145861: [clang][Interp] Ignore more non-VarDecl declarations

tbaeder updated this revision to Diff 505092. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145861/new/ https://reviews.llvm.org/D145861 Files: clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/test/AST/Interp/literals.cpp Index: clang/test/AST/Interp/literals.cpp

[PATCH] D146028: [clangd] Patch main file macros in preamble

kadircet updated this revision to Diff 505093. kadircet marked an inline comment as done. kadircet added a comment. - Rebase - Prevent unnecessary copies Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146028/new/ https://reviews.llvm.org/D146028 Fi

[PATCH] D146041: Fix weirdly apologetic diagnostic messages

DavidSpickett added a comment. Is there some standard for writing warning messages? For llvm that is, it would be worth looking through the getting started guides to see. I think the majority of warnings are "formal" in that sense so this seems fine. Personally I agree with making the warnings

[PATCH] D146041: Fix weirdly apologetic diagnostic messages

DavidSpickett added a comment. Ah, here it is: https://llvm.org/docs/CodingStandards.html#error-and-warning-messages Seems to back you up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146041/new/ https://reviews.llvm.org/D146041 ___

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

HerrCai0907 updated this revision to Diff 505096. HerrCai0907 added a comment. add more testcase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145892/new/ https://reviews.llvm.org/D145892 Files: clang/lib/Sema/SemaTemplateVariadic.cpp clang/test/SemaCXX/fold_expr_typo.cpp Index:

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

HerrCai0907 added a comment. Should I add release note in `clang/docs/ReleaseNotes.rst` or any other way? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145892/new/ https://reviews.llvm.org/D145892 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D145974: [libclang] Add index option to store preambles in memory

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145974/new/ https://reviews.llvm.org/D145974

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

erichkeane added a comment. In D145892#4193085 , @HerrCai0907 wrote: > Should I add release note in `clang/docs/ReleaseNotes.rst` or any other way? Yes, that is the correct place. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145892/new/ http

[clang] 0950332 - Fix false positive with unreachable C++ catch handlers

Author: Aaron Ballman Date: 2023-03-14T11:08:39-04:00 New Revision: 0950332e91df0281c386874c45d7ce33b7da495b URL: https://github.com/llvm/llvm-project/commit/0950332e91df0281c386874c45d7ce33b7da495b DIFF: https://github.com/llvm/llvm-project/commit/0950332e91df0281c386874c45d7ce33b7da495b.diff

[PATCH] D145408: Fix false positive with unreachable C++ catch handlers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0950332e91df: Fix false positive with unreachable C++ catch handlers (authored by aaron.ballman). Changed prior to commit: https://reviews.llvm.or

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

HerrCai0907 updated this revision to Diff 505105. HerrCai0907 added a comment. add release note CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145892/new/ https://reviews.llvm.org/D145892 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaTemplateVariadic.cpp clang/test/SemaCXX

[PATCH] D146041: Fix weirdly apologetic diagnostic messages

junaire added a comment. I'm not certain if it's bad to say 'sorry', IMHO it's fine? Anyway, you can't just simply delete those words (in diagnostic messages and regression tests), that doesn't work. To verify the patch is good, you can run `ninja check-all` to make sure the testsuite passes.

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

erichkeane added inline comments. Comment at: clang/docs/ReleaseNotes.rst:173 by prioritizing ``-Wunreachable-code-fallthrough``. +- Clang won't crash when fold expression contains a delayed typos correction. This should go in the `Bug Fixes In This Version`

[PATCH] D145408: Fix false positive with unreachable C++ catch handlers

shafik added a comment. Apologies for late review. Comment at: clang/lib/Sema/SemaStmt.cpp:4405 ASTContext &Ctx; - const llvm::DenseMap &TypesToCheck; - const bool CheckAgainstPointer; + const llvm::DenseMap &TypesToCheck; Can we just make `llvm::DenseM

[PATCH] D146054: [RISCV] Add -print-supported-marchs and -march=help support

4vtomat created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, ni

[PATCH] D145861: [clang][Interp] Ignore more non-VarDecl declarations

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145861/new/ https://reviews.llvm.org/D145861 ___ cfe-commits mailing lis

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

HerrCai0907 updated this revision to Diff 505111. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145892/new/ https://reviews.llvm.org/D145892 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaTemplateVariadic.cpp clang/test/SemaCXX/fold_expr_typo.cpp Index: clang/test/SemaCXX/

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

4vtomat updated this revision to Diff 505112. 4vtomat added a comment. Resolved Craig's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141672/new/ https://reviews.llvm.org/D141672 Files: clang/test/Preprocessor/riscv-target-features.c

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. LGTM with 2 nits. Comment at: clang/docs/ReleaseNotes.rst:196 (`#60936 `_) +- Fix crash when parsing fold expres

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 505116. TIFitis added a comment. Herald added a project: Flang. Added TODO for unsupported map operand types in Flang frontend Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis marked an inline comment as done. TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1357 +/// Process MapOperands for Target Data directives. +static LogicalResult processMapOperand( +llvm::IRBuilderBase &b

[PATCH] D145970: [MSVC][PS][dllexport/dllimport] Propagate a dllexport/dllimport attribute to template baseclasses

wolfgangp added a comment. In D145970#4192679 , @hans wrote: > LGTM > > I've always found this to be an interesting behavior, and I'm guessing you > found some code where it does matter :) Well, one of our customers did, anyway. The code in the descript

[clang] f2a6fe6 - Remove an unused private data member; NFC

Author: Aaron Ballman Date: 2023-03-14T11:32:11-04:00 New Revision: f2a6fe601a862b4520266cd660ae4a130886ef33 URL: https://github.com/llvm/llvm-project/commit/f2a6fe601a862b4520266cd660ae4a130886ef33 DIFF: https://github.com/llvm/llvm-project/commit/f2a6fe601a862b4520266cd660ae4a130886ef33.diff

[clang] 9afcebb - [AIX] change "llvm-ar" to "env OBJECT_MODE=any llvm-ar" in clang/test for AIX OS

Author: zhijian Date: 2023-03-14T11:50:20-04:00 New Revision: 9afcebb2202eb705da1ddbf6b36c1f5629042f6e URL: https://github.com/llvm/llvm-project/commit/9afcebb2202eb705da1ddbf6b36c1f5629042f6e DIFF: https://github.com/llvm/llvm-project/commit/9afcebb2202eb705da1ddbf6b36c1f5629042f6e.diff LOG:

[PATCH] D145600: [AIX] change "llvm-ar" to "env OBJECT_MODE=any llvm-ar" in clang/test for AIX OS

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9afcebb2202e: [AIX] change "llvm-ar" to "env OBJECT_MODE=any llvm-ar" in clang/test for AIX OS (authored by zhijian ). Reposito

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

HerrCai0907 updated this revision to Diff 505122. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145892/new/ https://reviews.llvm.org/D145892 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaTemplateVariadic.cpp clang/test/SemaCXX/fold_expr_typo.cpp Index: clang/test/SemaCXX/

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

HerrCai0907 updated this revision to Diff 505126. HerrCai0907 marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145892/new/ https://reviews.llvm.org/D145892 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaTemplateVariadic.cpp clang/test/SemaCXX/f

[PATCH] D146054: [RISCV] Add -print-supported-marchs and -march=help support

craig.topper added inline comments. Comment at: clang/lib/Driver/Driver.cpp:110 +extern void RISCVMarchHelp(); + Can we declare this in RISCVISAInfo.h and include that here? Comment at: llvm/lib/Support/RISCVISAInfo.cpp:143 +void RISCVMarch

[PATCH] D145369: Emit const globals with constexpr destructor as constant LLVM values

hans updated this revision to Diff 505127. hans added a comment. Thanks for the review! Added tests to cover other calls that change behavior due to this. Please take another look. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145369/new/ https://reviews.llvm.org/D145369 Files: cla

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

HerrCai0907 updated this revision to Diff 505129. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145892/new/ https://reviews.llvm.org/D145892 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaTemplateVariadic.cpp clang/test/SemaCXX/fold_expr_typo.cpp Index: clang/test/SemaCXX/

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

erichkeane added a comment. Looks good! Thanks! Commit when you're ready. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145892/new/ https://reviews.llvm.org/D145892 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D145391: [HIP] Supports env var HIP_PATH

yaxunl updated this revision to Diff 505133. yaxunl marked 2 inline comments as done. yaxunl added a comment. fix tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145391/new/ https://reviews.llvm.org/D145391 Files: clang/lib/Driver/ToolChains/AMDGPU.cpp clang/test/Driver/rocm-de

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

HerrCai0907 updated this revision to Diff 505134. HerrCai0907 added a comment. rebase to main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145892/new/ https://reviews.llvm.org/D145892 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaTemplateVariadic.cpp clang/test/SemaCXX/f

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

HerrCai0907 added a comment. I don't have write access now. Could you kindly help me to commit it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145892/new/ https://reviews.llvm.org/D145892 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

stephenpeckham added inline comments. Comment at: clang/docs/ReleaseNotes.rst:230 +- Introduced the ``-mroptr`` option to place constant objects with relocatable + address values in the read-only data section. This option is intended to + be used with the ``-fdata-sections`` op

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

erichkeane added a comment. In D145892#4193428 , @HerrCai0907 wrote: > I don't have write access now. Could you kindly help me to commit it? Sure, just give me the name and email address you'd like it committed as. CHANGES SINCE LAST ACTION https://

[clang] 3d9880e - [OpenMP]Skip generating this[:1] map info for non-member variable.

Author: Jennifer Yu Date: 2023-03-14T09:09:20-07:00 New Revision: 3d9880ebbcb7d458753ac73a65b401af94c7b762 URL: https://github.com/llvm/llvm-project/commit/3d9880ebbcb7d458753ac73a65b401af94c7b762 DIFF: https://github.com/llvm/llvm-project/commit/3d9880ebbcb7d458753ac73a65b401af94c7b762.diff L

[PATCH] D146000: [OpenMP]Skip generating this[:1] map info for non-member variable.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3d9880ebbcb7: [OpenMP]Skip generating this[:1] map info for non-member variable. (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146000/new

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

HerrCai0907 added a comment. HerrCai0907 and congcongcai0...@163.com Thanks a lot! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145892/new/ https://reviews.llvm.org/D145892 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

sunshaoce added a comment. Any other opinions? If not, I will land it later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145883/new/ https://reviews.llvm.org/D145883 ___ cfe-commits mailing list cfe-co

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

HerrCai0907 added a comment. Hello Erichkeane, I have the access now, maybe I can push it by myself. Thanks again! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145892/new/ https://reviews.llvm.org/D145892 ___ cfe-commits mailing list cfe-co

[PATCH] D142327: [clang][RISCV] Fix ABI handling of empty structs with hard FP calling conventions in C++

luismarques added inline comments. Comment at: clang/test/CodeGen/RISCV/abi-empty-structs.c:21-22 // Fields containing empty structs or unions are ignored when flattening // structs for the hard FP ABIs, even in C++. -// FIXME: This isn't currently respected.

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

erichkeane added a comment. In D145892#4193522 , @HerrCai0907 wrote: > Hello Erichkeane, I have the access now, maybe I can push it by myself. > Thanks again! Alright, let me know if you need any help! -Erich CHANGES SINCE LAST ACTION https://revie

[PATCH] D144976: [clangd] Add provider info on symbol hover.

VitaNuo updated this revision to Diff 505147. VitaNuo added a comment. Herald added a subscriber: ChuanqiXu. Re-work the patch to use include_cleaner::headersForSymbol. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144976/new/ https://reviews.llvm.

[PATCH] D144844: [C++20] [Modules] Offer -fno-import-inter-module-function-defs to avoid duplicated compilation in modules

dblaikie added a comment. Seem to recall @iains and others were concerned about the number of modules flags - this one I'd be inclined to suggest we shouldn't add if possible. If one way or the other is generally better - we should, at least initially, dictate that behavior entirely until someo

[PATCH] D145238: [NVPTX] Expose LDU builtins

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM with a test nit. Comment at: llvm/test/CodeGen/NVPTX/ldu-ldg.ll:30 +; CHECK: test_ldu_i16 +define i16 @test_ldu_i16(ptr addrspace(1) %ptr) { Nit. Function n

[PATCH] D144976: [clangd] Add provider info on symbol hover.

VitaNuo marked an inline comment as done. VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clangd/Hover.cpp:1099 + trace::Span Tracer("Hover::maybeAddSymbolProviders"); + include_cleaner::walkUsed( + AST.getLocalTopLevelDecls(), MacroRefere

[PATCH] D144870: [Clang][DebugInfo] Emit zero size bitfields in the debug info to delimit bitfields in different allocation units.

jmmartinez updated this revision to Diff 505148. jmmartinez added a comment. Update: - Took into account remarks and got my ideas straight. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144870/new/ https://reviews.llvm.org/D144870 Files: clang/

[PATCH] D144709: [clang-format] Improve QualifierAlignment

MyDeveloperDay added a comment. In D144709#4188921 , @AlexanderHederstaf wrote: > What is the next step in the process? Anything I should do? If you have commit access you can go ahead and commit, if not and you want one of us to do it, we need your na

[clang] e417f02 - [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

Author: Congcong Cai Date: 2023-03-15T01:08:41+08:00 New Revision: e417f02b5159c13f011335636faaf8c6847b627f URL: https://github.com/llvm/llvm-project/commit/e417f02b5159c13f011335636faaf8c6847b627f DIFF: https://github.com/llvm/llvm-project/commit/e417f02b5159c13f011335636faaf8c6847b627f.diff

[PATCH] D145888: [clang-format] Fix non-case colons in Verilog case lines

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:4424 -if (Line.First->isOneOf(tok::kw_default, tok::kw_case)) - return Style.SpaceBeforeCaseColon; const FormatToken *Next = Right.getNextNonComment(); Hmm.. this

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe417f02b5159: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag (authored by HerrCai0907). Repository: rG LLVM Github Mono

[PATCH] D144878: __builtin_FILE_NAME()

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:113-114 nondeterministic value of the same type as the provided argument. +- Clang now supports ``__builtin_FILE_NAME`` that returns a + ``__FILE_NAME__`` value at the "invocation point". -

[PATCH] D144569: [Clang][OpenMP] Fix accessing of aligned arrays in offloaded target regions

doru1004 updated this revision to Diff 505157. Herald added a subscriber: sunshaoce. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144569/new/ https://reviews.llvm.org/D144569 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/amdgpu_target_

[PATCH] D146069: [StandardInstrumentations] Rename -verify-cfg-preserved -> -verify-preserved-analyses

aeubanks created this revision. aeubanks added a reviewer: yrouban. Herald added subscribers: ormris, wenlei, steven_wu, hiraditya. Herald added a project: All. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. In p

[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

mysterymath added a comment. This is also causing a breakage on the Linux and Mac Fuchsia toolchain builds: https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8786633328903858561/overview Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D144844: [C++20] [Modules] Offer -fno-import-inter-module-function-defs to avoid duplicated compilation in modules

iains added a comment. In D144844#4193568 , @dblaikie wrote: > Seem to recall @iains and others were concerned about the number of modules > flags - this one I'd be inclined to suggest we shouldn't add if possible. If > one way or the other is generally

[PATCH] D144870: [Clang][DebugInfo] Emit zero size bitfields in the debug info to delimit bitfields in different allocation units.

probinson added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1558 + EmitSeparator = FieldIt->isBitField(); + } + I might not be following this correctly, but it feels like EmitSeparator will end up true if the last field is a bitfield, ev

[PATCH] D145941: [Clang] Always use -zdefs when linking AMDGPU images

jhuber6 updated this revision to Diff 505166. jhuber6 added a comment. Adding release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145941/new/ https://reviews.llvm.org/D145941 Files: clang/docs/ReleaseNotes.rst clang/lib/Driver/ToolChai

[PATCH] D146003: [StandardInstrumentations] Verify function doesn't change if analyses are preserved

aeubanks updated this revision to Diff 505169. aeubanks retitled this revision from "[StandardInstrumentations] Check that the number of instructions doesn't change if analyses are preserved" to "[StandardInstrumentations] Verify function doesn't change if analyses are preserved". aeubanks edite

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

garvitgupta08 updated this revision to Diff 505171. garvitgupta08 added a comment. Addressed the comments. Using gcc_forward.c for checking c extension. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145726/new/ https://reviews.llvm.org/D145726 Fil

[PATCH] D145859: [Clang][CodeGen] Fix linkage and visibility of template parameter objects

alexander-shaposhnikov updated this revision to Diff 505175. alexander-shaposhnikov retitled this revision from "[Clang][CodeGen] Fix linkage of template parameter objects" to "[Clang][CodeGen] Fix linkage and visibility of template parameter objects". alexander-shaposhnikov edited the summary of

[PATCH] D146073: Revert "Revert "[Clang][AIX][p] Manually Claim -p in front end""

francii created this revision. Herald added a project: All. francii requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This reverts commit 7488dd25e1613894d79d69f153469545b9bf660a

[PATCH] D146073: Revert "Revert "[Clang][AIX][p] Manually Claim -p in front end""

francii updated this revision to Diff 505179. francii added a comment. Update message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146073/new/ https://reviews.llvm.org/D146073 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Tool

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 505181. qiongsiwu1 added a comment. Thanks for the comments @stephenpeckham ! This update addresses all of them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Fi

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

garvitgupta08 added a comment. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:978-986 + if (Arg *A = Args.getLastArg(options::OPT_g_Flag, options::OPT_gN_Group, + options::OPT_gdwarf_2, options::OPT_gdwarf_3, +

[clang] 55f3849 - [Clang] Always use --no-undefined when linking AMDGPU images

Author: Joseph Huber Date: 2023-03-14T13:11:33-05:00 New Revision: 55f38495e38e2a3aeb4f2dac852644eb4937bd74 URL: https://github.com/llvm/llvm-project/commit/55f38495e38e2a3aeb4f2dac852644eb4937bd74 DIFF: https://github.com/llvm/llvm-project/commit/55f38495e38e2a3aeb4f2dac852644eb4937bd74.diff

[PATCH] D145941: [Clang] Always use --no-undefined when linking AMDGPU images

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG55f38495e38e: [Clang] Always use --no-undefined when linking AMDGPU images (authored by jhuber6). Changed prior to commit: https://reviews.llvm.or

[PATCH] D145999: [RISCV] Reserve X18 by default for Android

asb added inline comments. Comment at: clang/test/Driver/riscv-fixed-x-register.c:343 + +// Check that x18 is reserved on Android by default +// RUN: %clang --target=riscv64-linux-android -### %s 2> %t samitolvanen wrote: > This seems redundant. Isn't the LLVM co

[PATCH] D145021: [Clang][AIX][p] Manually claim -p in front end

daltenty added a comment. Reopen since this was reverted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D145021: [Clang][AIX][p] Manually claim -p in front end

francii updated this revision to Diff 505186. francii added a comment. Make `-p` a CC1 option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/include/clang/Driver/Options.td clang/lib/Dr

[PATCH] D145190: [memprof] Record BuildIDs in the raw profile.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa1bbf5ac3cbd: [memprof] Record BuildIDs in the raw profile. (authored by snehasish). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145190/new/ https://revie

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin added a comment. @kadircet could you please take another look? I had to update diff to make it work when LLVM is configured without X86 targets so they are not valid and thus not injected into the command line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[clang] 8403ccd - [Clang][CodeGen] Fix linkage and visibility of template parameter objects

Author: Alexander Shaposhnikov Date: 2023-03-14T18:23:06Z New Revision: 8403ccdcd28c2ff30c1e980ce4a8c851fae01a9d URL: https://github.com/llvm/llvm-project/commit/8403ccdcd28c2ff30c1e980ce4a8c851fae01a9d DIFF: https://github.com/llvm/llvm-project/commit/8403ccdcd28c2ff30c1e980ce4a8c851fae01a9d.d

[PATCH] D145859: [Clang][CodeGen] Fix linkage and visibility of template parameter objects

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8403ccdcd28c: [Clang][CodeGen] Fix linkage and visibility of template parameter objects (authored by alexander-shaposhnikov). Repository: rG LLVM

[PATCH] D146075: [flang][driver][openmp] Write MLIR for -save-temps

skatrak created this revision. skatrak added reviewers: gregrodgers, dpalermo, domada, jsjodin, agozillon, kiranchandramohan, awarzynski. Herald added subscribers: sunshaoce, bzcheeseman, rriddle, guansong, yaxunl. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. skatrak requ

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin added a comment. In D125171#4167866 , @owenpan wrote: > Please see > https://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options. I am doing this for my team, which writes the security endpoint for Elastic Defend. T

[PATCH] D145369: Emit const globals with constexpr destructor as constant LLVM values

efriedma added inline comments. Comment at: clang/test/CodeGenCXX/static-init.cpp:181 +#if __cplusplus >= 202002L +// A const object with constexpr destructor can be emitted as a constant. +namespace test5 { I don't see how this works. For a static local variabl

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin marked 4 inline comments as done. jrmolin added inline comments. Comment at: clang/include/clang/Format/Format.h:827 + /// \code + /// someFunction( + /// int argument1, HazardyKnusperkeks wrote: > That's not a valid declaration (missing return

[PATCH] D145369: Emit const globals with constexpr destructor as constant LLVM values

efriedma added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4344 + (Record->hasTrivialDestructor() || + Record->hasConstexprDestructor()); } For the purposes of CodeGen, checking `Record->hasConstexprDestructor()` i

[PATCH] D129689: [limits.h] USHRT_MAX fix for 16 bit architectures

SebastianPerta added a comment. @cor3ntin can I close it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129689/new/ https://reviews.llvm.org/D129689 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[PATCH] D145999: [RISCV] Reserve X18 by default for Android

asb accepted this revision. asb added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145999/new/ https://reviews.llvm.org/D145999 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

nickdesaulniers requested changes to this revision. nickdesaulniers added a comment. This revision now requires changes to proceed. The description needs to be rewritten to elucidate that this is purely to support old versions of the GNU assembler still in use by various Linux LTS distros. This

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin updated this revision to Diff 505215. jrmolin marked 3 inline comments as done. jrmolin added a comment. respond to code review requests/comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125171/new/ https://reviews.llvm.org/D125171 Fi

[PATCH] D145564: [clang][docs] Clarify the semantics of -fexceptions

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145564/new/ https://reviews.llvm.org/D145564 ___ cfe-commits mailing list cfe-commi

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:978-986 + if (Arg *A = Args.getLastArg(options::OPT_g_Flag, options::OPT_gN_Group, + options::OPT_gdwarf_2, options::OPT_gdwarf_3, +

[PATCH] D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions

royjacobson updated this revision to Diff 505216. royjacobson added a comment. Fix the codegen test, add a standard ref to the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145851/new/ https://reviews.llvm.org/D145851 Files: clang/docs/

[PATCH] D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions

royjacobson added a comment. Oops, sorry for the bad codegen test and thanks for the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145851/new/ https://reviews.llvm.org/D145851 ___ cfe-commits m

[PATCH] D146041: Fix weirdly apologetic diagnostic messages

AryanGodara added a comment. In D146041#4192816 , @mehdi_amini wrote: > You should look into the title and description of the commit: > https://cbea.ms/git-commit/ Is the title and description appropriate now? I can add more details to the description,

  1   2   3   >