[PATCH] D145849: [Driver][xray] Allow XRay on Apple Silicon

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/XRay/xray-instrument-macos.c:1 +// RUN: %clang -o /dev/null -v -fxray-instrument -target aarch64-apple-darwin20 -c %s // RUN: %clang -o

[clang] df405db - [Driver] Make -X default for baremetal riscv

Author: Alex Brachet Date: 2023-03-14T05:17:54Z New Revision: df405dbfd316a598474b73f8c57f0d1051b4b51e URL: https://github.com/llvm/llvm-project/commit/df405dbfd316a598474b73f8c57f0d1051b4b51e DIFF: https://github.com/llvm/llvm-project/commit/df405dbfd316a598474b73f8c57f0d1051b4b51e.diff LOG:

[PATCH] D145725: [Driver] Make -X default for baremetal riscv

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. abrachet marked 2 inline comments as done. Closed by commit rGdf405dbfd316: [Driver] Make -X default for baremetal riscv (authored by abrachet). Herald added a project:

[PATCH] D145725: [Driver] Make -X default for baremetal riscv

abrachet added a comment. Both comments addressed in commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145725/new/ https://reviews.llvm.org/D145725 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D145725: [Driver] Make -X default for baremetal riscv

MaskRay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145725/new/ https://reviews.llvm.org/D145725 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D146003: [StandardInstrumentations] Check that the number of instructions doesn't change if analyses are preserved

yrouban added a comment. Looks good in general, but it would be better to have this patch split into several smaller patches: renaming NFC, InstructionCounter intro, one for each particular pass fix. Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:1057 + struct Inst

[PATCH] D145820: [Clang][OpenMP] Insert alloca for kernel args at function entry block instead of the launch point.

dhruvachak updated this revision to Diff 504945. dhruvachak added a comment. Fixed LIT test failure, added new clang test OpenMP/bug60602.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145820/new/ https://reviews.llvm.org/D145820 Files: clan

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

qiucf added a comment. In D143467#4182457 , @nemanjai wrote: > Another note regarding the motivating test case: > Use of `vector double` should require VSX. We don't really seem to have the > ability to turn this off early enough to catch this though. It

[PATCH] D143479: [Clang] Emit error when caller cannot meet target feature requirement from always-inlining callee

qiucf added a comment. Gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143479/new/ https://reviews.llvm.org/D143479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

zyounan updated this revision to Diff 504947. zyounan marked 3 inline comments as done. zyounan added a comment. Address the comments. Revise parameters of `getSignature` to avoid passing CCR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145319/new/

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

zyounan added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:441 getSignature(*SemaCCS, &S.Signature, &S.SnippetSuffix, - &Completion.RequiredQualifier, IsPattern); + &Completion.RequiredQualifier, IsPattern, C.Se

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

zyounan updated this revision to Diff 504950. zyounan added a comment. Update doxygen comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145319/new/ https://reviews.llvm.org/D145319 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-to

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

zyounan added inline comments. Comment at: clang-tools-extra/clangd/CodeCompletionStrings.h:45 /// /// When \p CompletingPattern is true, the last placeholder will be of the form /// ${0:…}, indicating the cursor should stay there. Sorry, I forget to revise th

[PATCH] D145767: [Verifier][NFC] Refactor check for associated metadata to allow multiple operands on AIX

tingwang updated this revision to Diff 504952. tingwang added a reviewer: PowerPC. tingwang added a comment. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. Address comments: (1) Add test case to show how associated metadata will be used on AIX (currently not supp

[clang] 3e78fa8 - [C++20] [Modules] Profile TemplateName by canonical decl

Author: Chuanqi Xu Date: 2023-03-14T14:34:44+08:00 New Revision: 3e78fa860235431323aaf08c8fa922d75a7cfffa URL: https://github.com/llvm/llvm-project/commit/3e78fa860235431323aaf08c8fa922d75a7cfffa DIFF: https://github.com/llvm/llvm-project/commit/3e78fa860235431323aaf08c8fa922d75a7cfffa.diff LO

[PATCH] D145057: [clang][ASTImport] Add support for import of empty records

kpdev42 updated this revision to Diff 504956. kpdev42 marked an inline comment as done. kpdev42 added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145057/new/ https://reviews.llvm.org/D145057 Files: clang/incl

[PATCH] D145765: Add __builtin_set_flt_rounds

xiongji90 updated this revision to Diff 504957. xiongji90 marked an inline comment as done. xiongji90 added a comment. Simplify test and update release doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145765/new/ https://reviews.llvm.org/D145765

[PATCH] D145057: [clang][ASTImport] Add support for import of empty records

kpdev42 marked an inline comment as done. kpdev42 added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:1171 + /// attribute + void markEmpty() { data().Empty = true; } balazske wrote: > This change looks not related. The `markEmpty` is still n

[PATCH] D130303: Fix include order in CXType.cpp

vedgy added inline comments. Comment at: clang/tools/libclang/CXType.cpp:374 +unsigned clang_isBitFieldDecl(CXCursor C) { + using namespace cxcursor; I just noticed the `clang_Cursor_isBitField()` function implemented [[ https://github.com/llvm/llvm-project/c

[PATCH] D145765: Add __builtin_set_flt_rounds

xiongji90 added a comment. In D145765#4189153 , @aaron.ballman wrote: > Thanks for the additional tests! Can you also add a release note to > `clang/docs/ReleaseNotes.rst` and document the new builtin in > `clang\docs\LanguageExtensions.rst`? Hi, @aar

<    1   2   3   4