[PATCH] D145727: [HWASAN][LSAN] Disable tests which don't pass in HWASAN+LSAN mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG011b4d4706ee: [HWASAN][LSAN] Disable tests which don't pass in HWASAN+LSAN mode (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHA

[clang] 25ba9dc - [HWASAN][LSAN] Fix buildbot failure.

Author: Kirill Stoimenov Date: 2023-03-10T01:07:43Z New Revision: 25ba9dcf1807e9eadade24833da60133beadfe3f URL: https://github.com/llvm/llvm-project/commit/25ba9dcf1807e9eadade24833da60133beadfe3f DIFF: https://github.com/llvm/llvm-project/commit/25ba9dcf1807e9eadade24833da60133beadfe3f.diff L

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

hoy added a comment. In D83906#4182904 , @dexonsmith wrote: > In D83906#4182847 , @hoy wrote: > >> As far as I know, the optimizer IPO pass that infers function attributes >> (i..e `InferFunctionAttrsPass`) is plac

[PATCH] D145435: Choose style (file) from within code for use in IDEs

owenpan added a comment. In D145435#4181215 , @HazardyKnusperkeks wrote: > Although I don't think I will use that feature, I still think it might be > useful and doesn't really hurt anyone. It would add extra runtime (especially for large files). We wo

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

zyounan added a comment. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145319/new/ https://reviews.llvm.org/D145319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang added a comment. Currently this patch does not work due to limit set on associated metadata operand count (forced to be single operand). commit 87f2e9448e82bbed4ac59bb61bea03256aa5f4de Author: Matt Arsenault Date: Mon Jan 9 12:17:38 2023 -0500 Verifier: Add checks for

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

owenpan added a comment. Would this patch make the end result look worse without "making the requires clause formatting of lambdas match the formatting for functions"? If yes, then we should not land it just yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D137514: [clang-tidy] add check for capturing lambda coroutines

ChuanqiXu accepted this revision. ChuanqiXu added a comment. LGTM. Thanks! BTW, in such cases, you can commandeer the revision generally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137514/new/ https://reviews.llvm.org/D137514 __

[PATCH] D145720: [clang-tidy] Finish cppcoreguidelines-avoid-capturing-lambda-coroutines check

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145720/new/ https://reviews.llvm.org/D145720

[clang] 1f8a3ce - [HIP] Fix temporary files

Author: Yaxun (Sam) Liu Date: 2023-03-09T21:41:58-05:00 New Revision: 1f8a3ce325be51a1004657b08a607825447fee1b URL: https://github.com/llvm/llvm-project/commit/1f8a3ce325be51a1004657b08a607825447fee1b DIFF: https://github.com/llvm/llvm-project/commit/1f8a3ce325be51a1004657b08a607825447fee1b.dif

[PATCH] D145509: [HIP] Fix temporary files

This revision was automatically updated to reflect the committed changes. Closed by commit rG1f8a3ce325be: [HIP] Fix temporary files (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145509/new/ https:

[PATCH] D145146: [Driver][NFC] Remove some redundant code in Driver.cpp.

Jimerlife added a comment. ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145146/new/ https://reviews.llvm.org/D145146 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

yaxunl added a comment. HIP toolchain does not pass -fopenmp-targets=amdgcn-amd-amdhsa to clang -cc1 in host compilation. It does not pass -fopenmp-is-device to clang -cc1 in device compilation. Without these options clang will not generate OpenMP offloading code for amdgpu in device and host c

[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

tstellar added a comment. We're holding -rc4 until this is merged, so it would be great if we could merge it on Friday. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145704/new/ https://reviews.llvm.org/D145704 ___ cfe-commits mailing list c

[PATCH] D145765: Add __builtin_set_flt_rounds

xiongji90 created this revision. xiongji90 added reviewers: andrew.w.kaylor, rjmccall, sepavloff, aaron.ballman. Herald added subscribers: pengfei, kristof.beyls. Herald added a project: All. xiongji90 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-

[PATCH] D143480: [clang][Interp] Fix derived-to-base casts for >1 levels

tbaeder updated this revision to Diff 504022. tbaeder marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143480/new/ https://reviews.llvm.org/D143480 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/I

[PATCH] D143480: [clang][Interp] Fix derived-to-base casts for >1 levels

tbaeder added inline comments. Comment at: clang/test/AST/Interp/records.cpp:266 }; #endif aaron.ballman wrote: > I think it'd be good to add test coverage for cases like: > https://godbolt.org/z/GnPnP4z76 That even worked :) CHANGES SINCE LAST ACTION ht

[PATCH] D145765: Add __builtin_set_flt_rounds

xiongji90 added a comment. Hi, @andrew.w.kaylor @rjmccall @sepavloff @aaron.ballman This patch re-lands previous patch to add __builtin_set_flt_rounds, previous patch broke PPC64 buildbot due to test case bug. Previously, tests for __builtin_set_flt_rounds was located in CodeGen/builtin.c which

[PATCH] D142174: [OpenMP] Don't set rpath for system paths

tstellar abandoned this revision. tstellar added a comment. -fopenmp-add-rpath has been removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142174/new/ https://reviews.llvm.org/D142174 ___ cfe-commits

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

tstellar added a comment. Should we apply this patch to the release/16.x branch to create a more smooth transition since the option has been removed in main? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143306/new/ https://reviews.llvm.org/D14330

[PATCH] D145034: [Clang][Sema] Start fixing handling of out-of-line definitions of constrained templates

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaCXXScopeSpec.cpp:141 + ClassTemplate->getInjectedClassNameSpecialization(); + if (Context.hasSameType(Injected, ContextType)) +return ClassTemplate->getTemplatedDecl();

[PATCH] D145034: [Clang][Sema] Start fixing handling of out-of-line definitions of constrained templates

alexander-shaposhnikov updated this revision to Diff 504025. alexander-shaposhnikov added a comment. Release notes. P.S. To the best of my knowledge the current status is the following: with this patch the examples reported in the comments on https://github.com/llvm/llvm-project/issues/49620 st

[clang] af86957 - [C++20] [Modules] Don't load declaration eagerly for named modules

Author: Chuanqi Xu Date: 2023-03-10T14:57:21+08:00 New Revision: af86957cbbffd3dfff3c6750ebddf118aebd0069 URL: https://github.com/llvm/llvm-project/commit/af86957cbbffd3dfff3c6750ebddf118aebd0069 DIFF: https://github.com/llvm/llvm-project/commit/af86957cbbffd3dfff3c6750ebddf118aebd0069.diff LO

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang updated this revision to Diff 504031. tingwang added a comment. Herald added a subscriber: hiraditya. Rebase and update patch (1) Update verifier check on associated metadata to allow multiple operands for AIX. (2) Update test cases to use opaque pointer. Repository: rG LLVM Github M

[clang] 87ba95a - [NFC] Don't recompute Linkage for Decl in Release Modes

Author: Chuanqi Xu Date: 2023-03-10T15:23:38+08:00 New Revision: 87ba95aa212a4fd363a4dd52677e9eea5224a4e7 URL: https://github.com/llvm/llvm-project/commit/87ba95aa212a4fd363a4dd52677e9eea5224a4e7 DIFF: https://github.com/llvm/llvm-project/commit/87ba95aa212a4fd363a4dd52677e9eea5224a4e7.diff LO

[clang] 8592b3e - Revert "[NFC] Don't recompute Linkage for Decl in Release Modes"

Author: Chuanqi Xu Date: 2023-03-10T15:25:26+08:00 New Revision: 8592b3e1d2080d9f6b3102dfb5895ca390da44a0 URL: https://github.com/llvm/llvm-project/commit/8592b3e1d2080d9f6b3102dfb5895ca390da44a0 DIFF: https://github.com/llvm/llvm-project/commit/8592b3e1d2080d9f6b3102dfb5895ca390da44a0.diff LO

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

4vtomat updated this revision to Diff 504034. 4vtomat added a comment. Resolved Craig's comments and rename *zvkns* files to *zvkned*. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141672/new/ https://reviews.llvm.org/D141672 Files: clang/test/P

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

MaskRay added a comment. In D143306#4183759 , @tstellar wrote: > Should we apply this patch to the release/16.x branch to create a more smooth > transition since the option has been removed in main? Yes, it will be a good idea to apply this to `release/

[PATCH] D144878: __builtin_FILE_NAME()

karapsinie marked an inline comment as done. karapsinie added a comment. In D144878#4172639 , @aaron.ballman wrote: > In D144878#4171234 , @karapsinie > wrote: > >> PTAL. > > Have you seen the comments on the GC

[PATCH] D141215: [clang-repl] Introduce Value and implement pretty printing

junaire updated this revision to Diff 504038. junaire added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Basic/TokenKinds.def clang/include/clang/Inter

<    1   2   3