[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

zahiraam added a comment. In D145704#4182268 , @aaron.ballman wrote: > Thank you for working on this! Because this is fixing an ABI break, if we can > land this in time for the release candidate I think we should try to add this > to 16.0 to limit dama

[PATCH] D145093: [OpenMP] Add map info for dereference pointer.

jyu2 added a comment. In D145093#4179927 , @ronlieb wrote: > seems to fail amdgpu buildbot > https://lab.llvm.org/buildbot/#/builders/193/builds/27692 I turn off the test run to amdgpu. And rechecked in with c5b060900e98

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

tra added a comment. In D145591#4182168 , @yaxunl wrote: > -x hip and -fopenmp has been a valid combination. -fopenmp with -x hip allows > non-offloading OpenMP directives in host code in HIP. It just ignores the > offloading directives. That brings me

[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

zahiraam updated this revision to Diff 503865. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145704/new/ https://reviews.llvm.org/D145704 Files: clang/include/clang/Lex/Preprocessor.h clang/lib/Lex/PPMacroExpansion.cpp clang/lib/Lex/Preprocessor.cpp clang/lib/Sema/SemaAttr.cpp

[PATCH] D145644: [memprof] Add scripts to automate testdata regeneration.

snehasish marked an inline comment as done. snehasish added a comment. In D145644#4182239 , @tejohnson wrote: > Generally lgtm, but why did the raw profiles change size from what is > currently committed? The reduction in size of the raw profiles is due

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

jhuber6 added a comment. I'm not a fan of the same warning being copied in 24 places. Why do we set `LangOpts.IsOpenMP` on the GPU compilation side, couldn't we just filter out the `-fopenmp` or whatever it is for the HIP job? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

aaron.ballman added a comment. In D145704#4182341 , @zahiraam wrote: > In D145704#4182268 , @aaron.ballman > wrote: > >> Thank you for working on this! Because this is fixing an ABI break, if we >> can land this

[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

aaron.ballman added a comment. In D145704#4182364 , @aaron.ballman wrote: > This variant comes with a .patch file added to the PR; that should be deleted > in the next round. Aside from that, the changes LGTM, but I'd like to give > precommit CI a chan

[PATCH] D145644: [memprof] Add scripts to automate testdata regeneration.

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145644/new/ https://reviews.llvm.org/D145644 _

[PATCH] D145644: [memprof] Add scripts to automate testdata regeneration.

snehasish added a comment. I'll go ahead and push this. @dblaikie Let me know if you have any comments and I'll follow up separately. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145644/new/ https://reviews.llvm.org/D145644 _

[clang] e99b5ad - [memprof] Add scripts to automate testdata regeneration.

Author: Snehasish Kumar Date: 2023-03-09T19:54:23Z New Revision: e99b5ad38381ab263820b23a184d217a4112519c URL: https://github.com/llvm/llvm-project/commit/e99b5ad38381ab263820b23a184d217a4112519c DIFF: https://github.com/llvm/llvm-project/commit/e99b5ad38381ab263820b23a184d217a4112519c.diff LO

[PATCH] D145644: [memprof] Add scripts to automate testdata regeneration.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe99b5ad38381: [memprof] Add scripts to automate testdata regeneration. (authored by snehasish). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

hoy added a comment. In D83906#4182287 , @dexonsmith wrote: > In C++, you get linkonce_odr all over the place. It's basically all functions > that are defined in C++ headers that are available for inlining. > On the other hand, the frontend knows the t

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

nemanjai added inline comments. Comment at: clang/include/clang/Basic/BuiltinsPPC.def:491 +TARGET_BUILTIN(__builtin_altivec_vabsduh, "V8UsV8UsV8Us", "", "altivec") +TARGET_BUILTIN(__builtin_altivec_vabsduw, "V4UiV4UiV4Ui", "", "altivec") qiucf wrote: > shchenz

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

nemanjai added a comment. Another note regarding the motivating test case: Use of `vector double` should require VSX. We don't really seem to have the ability to turn this off early enough to catch this though. It would seem that in the front end, the target features depend on the compilation op

[clang] 4c82050 - Add codegen for llvm exp/exp2 elementwise builtins

Author: Joshua Batista Date: 2023-03-09T12:14:59-08:00 New Revision: 4c82050c56926d840e4ccf253ad10e6ae3ee6cc7 URL: https://github.com/llvm/llvm-project/commit/4c82050c56926d840e4ccf253ad10e6ae3ee6cc7 DIFF: https://github.com/llvm/llvm-project/commit/4c82050c56926d840e4ccf253ad10e6ae3ee6cc7.diff

[PATCH] D145270: Add codegen for llvm exp/exp2 elementwise builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c82050c5692: Add codegen for llvm exp/exp2 elementwise builtins (authored by bob80905). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145270/new/ https://r

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

dexonsmith added a comment. In D83906#4182428 , @hoy wrote: > In D83906#4182287 , @dexonsmith > wrote: > >> In C++, you get linkonce_odr all over the place. It's basically all >> functions that are defined in C++

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

jcranmer-intel added a comment. I'm studiously ignoring the Clang and LLVM codegen changes here, but otherwise, I think the direction of this change is generally good. Comment at: llvm/lib/Analysis/ConstantFolding.cpp:1377-1378 llvm_unreachable("unknown denormal mode"); -

[PATCH] D144903: [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

efriedma added a comment. I think the point of the hasOneUse check is to avoid a possible miscompile; if a FREEZE has more than one use, all users need to see the same value. So not sure dropping the check is correct in general. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145719: [clang-tidy] Make readability-container-data-pointer use header

mikecrowe created this revision. Herald added subscribers: PiotrZSL, xazax.hun. Herald added a project: All. mikecrowe requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This requires operator[] to be added to the std::basic_string

[PATCH] D145715: Remove -lower-global-dtors-via-cxa-atexit flag

rsundahl added inline comments. Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1205 unsigned Priority, const MCSymbol *KeySym) const { - // TODO(yln): Remove -lower-global-dtors-via-cxa-atexit fallback flag - // (LowerGlobalDtorsViaCxaAtExit) and always issu

[PATCH] D145719: [clang-tidy] Make readability-container-data-pointer use header

mikecrowe abandoned this revision. mikecrowe added a comment. Whoops. I accidentally uploaded https://reviews.llvm.org/D145719 as a new change. :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145719/new/ https://reviews.llvm.org/D145719

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

MaskRay abandoned this revision. MaskRay added a comment. Abandoned by a revert of D118493 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143306/new/ https://reviews.llvm.org/D143306 __

[PATCH] D145310: [clang-tidy] Make readability-container-data-pointer use header

mikecrowe updated this revision to Diff 503882. mikecrowe added a comment. Herald added a subscriber: PiotrZSL. Rebase on top of fb7ef637a84652dbd3d973a1ba7db9470181b5aa (which is a descendent of ae25e2f19decb94198301f0726ee61

[PATCH] D145720: [clang-tidy] Finish cppcoreguidelines-avoid-capturing-lambda-coroutines check

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, ChuanqiXu, shchenz, kbarton, xazax.hun, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscribe

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

jdoerfert added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8634 +def warn_hip_omp_target_directives : Warning< + "HIP does not support OpenMP target directives; directive has been ignored">, + InGroup; I doubt the ignored part

[PATCH] D145311: [clang-tidy] Make abseil-redundant-strcat-calls checker use header

mikecrowe updated this revision to Diff 503884. mikecrowe added a comment. Herald added a subscriber: PiotrZSL. Re-upload using arc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145311/new/ https://reviews.llvm.org/D145311 Files: clang-tools-ex

[PATCH] D145721: [HIP] clang should pass `-mno-amdgpu-ieee` to -cc1

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: kosarev, tpr, dstuttard, kzhuravl. Herald added a project: All. yaxunl requested review of this revision. Herald added subscribers: MaskRay, wdng. https://reviews.llvm.org/D145721 Files: clang/lib/Driver/ToolC

[PATCH] D137514: [clang-tidy] add check for capturing lambda coroutines

PiotrZSL updated this revision to Diff 503888. PiotrZSL added a comment. Rebase + Move files to other locations due to structure change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137514/new/ https://reviews.llvm.org/D137514 Files: clang-tool

[PATCH] D145720: [clang-tidy] Finish cppcoreguidelines-avoid-capturing-lambda-coroutines check

PiotrZSL updated this revision to Diff 503889. PiotrZSL added a comment. Change base-line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145720/new/ https://reviews.llvm.org/D145720 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidCapt

[PATCH] D118493: Set rpath on openmp executables

JonChesterfield added a comment. Duplicating a comment from the commit thread so it's easier for me to find later. You've applied this to the release branches going back as far as 14. It's a user facing breaking change. As in people who have a working openmp toolchain and update to the point r

[PATCH] D145724: [clang-tidy] Provide default template arguments in

mikecrowe created this revision. mikecrowe added a reviewer: carlosgalvezp. Herald added subscribers: PiotrZSL, xazax.hun. Herald added a project: All. mikecrowe requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Simplify the use o

[PATCH] D118493: Set rpath on openmp executables

tstellar added a comment. In D118493#4182583 , @JonChesterfield wrote: > Duplicating a comment from the commit thread so it's easier for me to find > later. > > You've applied this to the release branches going back as far as 14. It's a > user facing b

[PATCH] D145312: [clang-tidy] Make readability-string-compare check use header

mikecrowe marked an inline comment as done. mikecrowe added inline comments. Herald added a subscriber: PiotrZSL. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability/string-compare.cpp:4-8 -template -class allocator {}; -template -class char_traits {}; -template

[PATCH] D145509: [HIP] Fix temporary files

yaxunl updated this revision to Diff 503892. yaxunl added a comment. fix tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145509/new/ https://reviews.llvm.org/D145509 Files: clang/include/clang/Driver/Driver.h clang/lib/Driver/Driver.cpp clang/test/Driver/hip-link-bc-to-bc.hip

[PATCH] D145150: clang: Emit nofpclass(nan inf) for -ffinite-math-only

jcranmer-intel added a comment. I'm generally okay with the approach of this patch. I'm not sufficiently well-versed in the clang codegen side of things to know if this covers all of the bases, and I'd appreciate someone who is familiar with that side of things to approve this patch. CHANGES

[PATCH] D145313: [clang-tidy] Make readability-container-size-empty check using header

mikecrowe updated this revision to Diff 503896. mikecrowe added a comment. Herald added a subscriber: PiotrZSL. Upload using arc diff so more context is available. Now a descendent of D145724 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145313: [clang-tidy] Make readability-container-size-empty check using header

mikecrowe added a comment. In D145313#4182637 , @mikecrowe wrote: > Now a descendent of D145724 . Oh. The commit message update didn't make it through. :( Never mind, this doesn't really depend on D145724

[PATCH] D145567: [Driver] Rename multilib flags to tags

michaelplatings updated this revision to Diff 503899. michaelplatings added a comment. Rebase on top of D142905 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145567/new/ https://reviews.llvm.org/D145567 Files:

[PATCH] D142932: Multilib YAML parsing

michaelplatings updated this revision to Diff 503900. michaelplatings added a comment. flags -> tags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.org/D142932 Files: clang/include/clang/Driver/Multilib.h clang/

[PATCH] D145720: [clang-tidy] Finish cppcoreguidelines-avoid-capturing-lambda-coroutines check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:126 - Adds check for cpp core guideline: "CP.51: Do not use capturing lambdas that - are coroutines." - + Check flags C++20 coroutine lambdas with non-empty capture lists that may + ca

[PATCH] D142933: Add -print-multi-selection-flags-experimental option

michaelplatings updated this revision to Diff 503902. michaelplatings added a comment. flags -> tags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/ https://reviews.llvm.org/D142933 Files: clang/include/clang/Driver/Options.td clang/

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 503903. michaelplatings added a comment. flags -> tags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp clang/lib/Dri

[PATCH] D143059: [Driver] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 503904. michaelplatings added a comment. flags -> tags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h clang/

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings updated this revision to Diff 503905. michaelplatings added a comment. flags -> tags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files: clang/lib/Driver/ToolChains/BareMetal.cpp cl

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 503906. michaelplatings added a comment. flags -> tags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://reviews.llvm.org/D143587 Files: clang/docs/Multilib.rst clang/docs/index.rst

[PATCH] D145720: [clang-tidy] Finish cppcoreguidelines-avoid-capturing-lambda-coroutines check

PiotrZSL updated this revision to Diff 503907. PiotrZSL added a comment. Improve documentation (review comments) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145720/new/ https://reviews.llvm.org/D145720 Files: clang-tools-extra/clang-tidy/cppc

[PATCH] D145393: [HIP] Make `--offload-add-rpath` alias of `-frtlib-add-rpath`

yaxunl added a comment. In D145393#4172429 , @MaskRay wrote: > Seems fine. Should we eventually remove `--offload-add-rpath` and > `-fopenmp-implicit-rpath`? I agree we should eventually remove them and keep -frtlib-add-rpath only. C

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

garvitgupta08 created this revision. garvitgupta08 added reviewers: apazos, efriedma, MaskRay, nickdesaulniers. Herald added a project: All. garvitgupta08 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D136309

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

yaxunl added a comment. In D145591#4182351 , @tra wrote: > In D145591#4182168 , @yaxunl wrote: > >> -x hip and -fopenmp has been a valid combination. -fopenmp with -x hip >> allows non-offloading OpenMP directive

[PATCH] D145727: [HWASAN][LSAN] Disable tests which don't pass in HWASAN+LSAN mode

kstoimenov created this revision. Herald added subscribers: arphaman, emaste. Herald added a project: All. kstoimenov requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo https://

[PATCH] D145567: [Driver] Rename multilib flags to tags

michaelplatings updated this revision to Diff 503913. michaelplatings added a comment. Tiny tweak: undo an unnecessary change to a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145567/new/ https://reviews.llvm.org/D145567 Files: clang/inclu

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

yaxunl added a comment. In D145591#4182360 , @jhuber6 wrote: > I'm not a fan of the same warning being copied in 24 places. Why do we set > `LangOpts.IsOpenMP` on the GPU compilation side, couldn't we just filter out > the `-fopenmp` or whatever it is f

[PATCH] D145727: [HWASAN][LSAN] Disable tests which don't pass in HWASAN+LSAN mode

kstoimenov updated this revision to Diff 503915. kstoimenov added a comment. Removed debug print. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145727/new/ https://reviews.llvm.org/D145727 Files: clang/test/Driver/crash-diagnostics-dir-3.c cla

[PATCH] D144730: [FlowSensitive][WIP] log analysis progress for debugging purposes

gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Logger.h:22 + +// A logger is notified as the analysis progresses. +// It can produce a report of the analysis's findings and how it came to them. Elsewhere under Analysis/F

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

rjmccall added a comment. In D83906#4182287 , @dexonsmith wrote: > - At IRGen time, you know the LLVM attributes have not been adjusted after > the optimized refined the function's behaviour. It should be safe to have IPA > peepholes, as long as IRGen's

[clang] 0fdfb65 - [Flang] Add support to use LTO specific pipelines

Author: Nadeem, Usman Date: 2023-03-09T13:27:43-08:00 New Revision: 0fdfb65e2624aa151cb07a9c842331f7af9a21ca URL: https://github.com/llvm/llvm-project/commit/0fdfb65e2624aa151cb07a9c842331f7af9a21ca DIFF: https://github.com/llvm/llvm-project/commit/0fdfb65e2624aa151cb07a9c842331f7af9a21ca.diff

[PATCH] D142420: [Flang] Add support to use LTO specific pipelines

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0fdfb65e2624: [Flang] Add support to use LTO specific pipelines (authored by mnadeem). Herald added a project: clang. Herald added a subscriber: cfe-

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

jhuber6 added a comment. In D145591#4182748 , @yaxunl wrote: > In D145591#4182360 , @jhuber6 wrote: > >> I'm not a fan of the same warning being copied in 24 places. Why do we set >> `LangOpts.IsOpenMP` on the GP

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

yaxunl added a comment. In D145591#4182788 , @jhuber6 wrote: > In D145591#4182748 , @yaxunl wrote: > >> In D145591#4182360 , @jhuber6 >> wrote: >> >>> I'm not a fan of th

[PATCH] D145730: [clang-tidy] readability-redundant-string-cstr for smart pointer #576705

mikecrowe created this revision. mikecrowe added a reviewer: njames93. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a project: All. mikecrowe requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The read

[PATCH] D118493: Set rpath on openmp executables

MaskRay added a comment. In D118493#4182583 , @JonChesterfield wrote: > Duplicating a comment from the commit thread so it's easier for me to find > later. > > You've applied this to the release branches going back as far as 14. It's a > user facing br

[PATCH] D145715: Remove -lower-global-dtors-via-cxa-atexit flag

yln added inline comments. Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1205 unsigned Priority, const MCSymbol *KeySym) const { - // TODO(yln): Remove -lower-global-dtors-via-cxa-atexit fallback flag - // (LowerGlobalDtorsViaCxaAtExit) and always issue a f

[PATCH] D145721: [HIP] clang should pass `-mno-amdgpu-ieee` to -cc1

tra added a comment. > clang should pass `-mno-amdgpu-ieee` to -cc1 It would be useful to have some details on why we should pass that option. Comment at: clang/test/Driver/hip-options.hip:133 +// IEEE-ON-NOT: clang{{.*}} "-triple" "amdgcn-amd-amdhsa" {{.*}} "-mamdgpu-ieee" +

[PATCH] D118493: Set rpath on openmp executables

JonChesterfield added a comment. That is great news, phabricator's list of branches has mislead me. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118493/new/ https://reviews.llvm.org/D118493 ___

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

MaskRay added a comment. > Due to this we started seeing assembler errors with certain .c and .cpp files > - > "Error: file number 1 already allocated" What are the certain `.c` and `.cpp` files? The behavior is correct for the following two commands. clang --target=arm-linux-gnueabihf -fno-

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

hoy added a comment. In D83906#4182476 , @dexonsmith wrote: > In D83906#4182428 , @hoy wrote: > >> In D83906#4182287 , @dexonsmith >> wrote: >> >>> In C++, you get linkonce_

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

tra added a comment. In D145591#4182737 , @yaxunl wrote: > OpenMP offloading directives (e.g. "omp target") create implicit GPU kernels > which require OpenMP toolchain to create offloading actions to support them. > For C/C++ programs, OpenMP toolchain

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

dexonsmith added a comment. In D83906#4182777 , @rjmccall wrote: > In D83906#4182287 , @dexonsmith > wrote: > >> - At IRGen time, you know the LLVM attributes have not been adjusted after >> the optimized refined

[PATCH] D144304: [-Wunsafe-buffer-usage] Add a Fixable for pointer pre-increment

ziqingluo-90 updated this revision to Diff 503928. ziqingluo-90 added a comment. Rebased and addressed comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144304/new/ https://reviews.llvm.org/D144304 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsageGadgets.def clan

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

rjmccall added a comment. So your argument is that it would not be possible to recognize that we're doing such an optimization and mark the function as having had a possible semantics change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83906/new

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

dexonsmith added a comment. In D83906#4182847 , @hoy wrote: > As far as I know, the optimizer IPO pass that infers function attributes > (i..e `InferFunctionAttrsPass`) is placed at the very beginning of the > optimization pipeline. Does this sound to y

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 503934. qiongsiwu1 added a comment. Adding logic to pass `mroptr` to the backend during LTO codegen. Error check is not ideal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.

[PATCH] D145639: [Coroutines] Fix premature conversion of return object

bruno added a comment. Test failures are unrelated, thanks for the review @ChuanqiXu Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145639/new/ https://reviews.llvm.org/D145639 ___ cfe-commits mailing lis

[clang] 54225c4 - [Coroutines] Fix premature conversion of return object

Author: Bruno Cardoso Lopes Date: 2023-03-09T14:18:26-08:00 New Revision: 54225c457a336b1609c6d064b2b606a9238a28b9 URL: https://github.com/llvm/llvm-project/commit/54225c457a336b1609c6d064b2b606a9238a28b9 DIFF: https://github.com/llvm/llvm-project/commit/54225c457a336b1609c6d064b2b606a9238a28b9

[PATCH] D145639: [Coroutines] Fix premature conversion of return object

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG54225c457a33: [Coroutines] Fix premature conversion of return object (authored by bruno). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D145190: [memprof] Record BuildIDs in the raw profile.

snehasish updated this revision to Diff 503938. snehasish added a comment. Herald added subscribers: cfe-commits, wenlei. Herald added a project: clang. Update raw profiles, add another test for buildids only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

jdoerfert added a comment. I would emit an error. A warning only if we can ensure the code does something sensible. Right now, I doubt that is the case, similarly I doubt we actually ignore things. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145

[PATCH] D145190: [memprof] Record BuildIDs in the raw profile.

snehasish added a comment. In D145190#4181789 , @snehasish wrote: > In D145190#4181608 , @tejohnson > wrote: > >> lgtm - but does this depend on D145644 >> and require some add

[PATCH] D145730: [clang-tidy] readability-redundant-string-cstr for smart pointer #576705

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Also consider reducing commit message, instead just copying issue description. Simple description about issue would be sufficient. No functional issues, so LGTM. Comment

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

dexonsmith added a subscriber: sanjoy. dexonsmith added a comment. In D83906#4182902 , @rjmccall wrote: > So your argument is that it would not be possible to recognize that we're > doing such an optimization and mark the function as having had a possible

[PATCH] D137514: [clang-tidy] add check for capturing lambda coroutines

PiotrZSL updated this revision to Diff 503939. PiotrZSL added a comment. Making tests passing on this diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137514/new/ https://reviews.llvm.org/D137514 Files: clang-tools-extra/clang-tidy/cppcoregui

[PATCH] D145720: [clang-tidy] Finish cppcoreguidelines-avoid-capturing-lambda-coroutines check

PiotrZSL updated this revision to Diff 503940. PiotrZSL added a comment. Change baseline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145720/new/ https://reviews.llvm.org/D145720 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidCaptu

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 503941. qiongsiwu1 added a comment. Fixing release note. Adding pure linking tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Files: clang/docs/ReleaseNote

[PATCH] D145034: [Clang][Sema] Start fixing handling of out-of-line definitions of constrained templates

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good to me. This is fixing an important bug, and while there's more cleanup I'd like for us to do, it seems important to get this fix landed first. My understanding is that the release n

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 503944. qiongsiwu1 added a comment. Adding tests to check that the default behaviour is identical with `-mno-roptr`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190

[PATCH] D145190: [memprof] Record BuildIDs in the raw profile.

snehasish updated this revision to Diff 503945. snehasish added a comment. Update test regex. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145190/new/ https://reviews.llvm.org/D145190 Files: clang/test/CodeGen/Inputs/memprof.exe clang/test/Co

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

efriedma added a comment. Following reproduces for me (clang from main, Ubuntu 16.04). $ cat test.cpp int foo() { int i=6; do --i; while (!(i%3)); do {} while (!(i%5)); return 0; } $ clang++ test.cpp -c -fno-integrated-as -gdwarf-4 -O2 -fno-finite

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 503946. qiongsiwu1 added a comment. Adding LTO error check tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Files: clang/docs/ReleaseNotes.rst clang/incl

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

sanjoy added a comment. > I just assume there are more devices out there that we don't know about or > understand. I don't totally understand the broader discussion, but `malloc(4) == nullptr` is another gadget. This is optimized to `false` by LLVM even though at runtime it can be false or tr

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

collinbaker updated this revision to Diff 503950. collinbaker marked 3 inline comments as done. collinbaker edited the summary of this revision. collinbaker added a comment. Cleanups and split header order change to separate commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145727: [HWASAN][LSAN] Disable tests which don't pass in HWASAN+LSAN mode

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. non-crash ones are probable worth of investigating later Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145727/new/ https://reviews.llvm.

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

collinbaker updated this revision to Diff 503952. collinbaker added a comment. Missed commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130303/new/ https://reviews.llvm.org/D130303 Files: clang/docs/ReleaseNotes.rst clang/include/clang-c/In

[PATCH] D130303: Fix include order in CXType.cpp

collinbaker updated this revision to Diff 503953. collinbaker retitled this revision from "Handle template parameter-dependent bit field widths in libclang" to "Fix include order in CXType.cpp". collinbaker edited the summary of this revision. collinbaker added a comment. Re-add "Fixes" commit me

[PATCH] D130303: Fix include order in CXType.cpp

collinbaker marked 5 inline comments as done. collinbaker added a comment. I am very bad at using differential Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130303/new/ https://reviews.llvm.org/D130303 _

[PATCH] D130303: Fix include order in CXType.cpp

collinbaker updated this revision to Diff 503954. collinbaker added a comment. Rebase w/ conflict in libclang.map Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130303/new/ https://reviews.llvm.org/D130303 Files: clang/docs/ReleaseNotes.rst cla

[PATCH] D130303: Fix include order in CXType.cpp

collinbaker added a comment. All done. Again, I don't have commit access so someone else will need to land this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130303/new/ https://reviews.llvm.org/D130303 __

[PATCH] D145737: PR60985: Fix merging of lambda closure types across modules.

rsmith created this revision. Herald added a subscriber: martong. Herald added a reviewer: shafik. Herald added a project: All. rsmith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, distinct lambdas would get merged, and multip

[clang] 011b4d4 - [HWASAN][LSAN] Disable tests which don't pass in HWASAN+LSAN mode

Author: Kirill Stoimenov Date: 2023-03-10T00:51:55Z New Revision: 011b4d4706eea722d63438892afefdb8152b7b62 URL: https://github.com/llvm/llvm-project/commit/011b4d4706eea722d63438892afefdb8152b7b62 DIFF: https://github.com/llvm/llvm-project/commit/011b4d4706eea722d63438892afefdb8152b7b62.diff L

<    1   2   3   >