[PATCH] D145509: [HIP] Fix temporary files

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Driver/Driver.h:630 // Creates a temp file with $Prefix-%%.$Suffix const char *CreateTempFile(Compilation &C, StringRef Prefix, Stri

[PATCH] D144064: [-Wunsafe-buffer-usage] Match unsafe pointers being casted to bool or participating in pointer subtractions

malavikasamak added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:156 + // 2. the operand of a cast-to-(Integer or Boolean) operation; or + // 3. the operand of a pointer subtraction operation; or + // 4. the operand of a pointer comparison operation; o

[PATCH] D145435: Choose style (file) from within code for use in IDEs

bersbersbers added a comment. All, thanks for considering my patch! I'll answer all messages here, and will work on the patch over the weekend most probably. In D145435#4173875 , @owenpan wrote: > Please refer to D125171#4167866

[PATCH] D145270: Add codegen for llvm exp/exp2 elementwise builtins

bob80905 updated this revision to Diff 503511. bob80905 added a comment. - remove or to eliminate any ambiguity Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145270/new/ https://reviews.llvm.org/D145270 Files: clang/docs/LanguageExtensions.rst

[PATCH] D145615: [LSAN] Disable leaks in test using environment variables instead of not running them with ASAN.

kstoimenov created this revision. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini

[PATCH] D143287: [Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value

ManuelJBrito added a comment. In D143287#4179020 , @aqjune wrote: > H, is D104790 superseded by this patch? I don't think so we still need to fix the undefined intrinsics, right? Maybe I'm not understanding the questio

[PATCH] D143287: [Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value

aqjune added a comment. In D143287#4179344 , @ManuelJBrito wrote: > In D143287#4179020 , @aqjune wrote: > >> H, is D104790 superseded by this patch? > > I don't think so we stil

[PATCH] D144064: [-Wunsafe-buffer-usage] Match unsafe pointers being casted to bool or participating in pointer subtractions

NoQ added a comment. Looks great overall! Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:156 + // 2. the operand of a cast-to-(Integer or Boolean) operation; or + // 3. the operand of a pointer subtraction operation; or + // 4. the operand of a pointer comparison opera

[PATCH] D145617: [clang-tidy] Add readability-avoid-unconditional-preprocessor-if check

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Check flags always enab

[PATCH] D145617: [clang-tidy] Add readability-avoid-unconditional-preprocessor-if check

PiotrZSL updated this revision to Diff 503529. PiotrZSL added a comment. Micro fixes in documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145617/new/ https://reviews.llvm.org/D145617 Files: clang-tools-extra/clang-tidy/readability/Avo

[PATCH] D144903: [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

aqjune added inline comments. Comment at: clang/test/CodeGen/X86/avx-cast-builtins.c:1 // RUN: %clang_cc1 %s -O3 -flax-vector-conversions=none -ffreestanding %s -triple=x86_64-unknown-unknown -target-feature +avx -target-feature +avx512f -target-feature +avx512fp16 -S -o - |

[PATCH] D144903: [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

aqjune added inline comments. Comment at: clang/test/CodeGen/X86/avx-cast-builtins.c:1 // RUN: %clang_cc1 %s -O3 -flax-vector-conversions=none -ffreestanding %s -triple=x86_64-unknown-unknown -target-feature +avx -target-feature +avx512f -target-feature +avx512fp16 -S -o - |

[PATCH] D129951: adds `__disable_adl` attribute

cjdb added a comment. In D129951#4178949 , @philnik wrote: > In D129951#4178844 , @cjdb wrote: > >> In D129951#4178154 , @philnik >> wrote: >> >>> I don't think libc++ ca

[PATCH] D129951: adds `__disable_adl` attribute

ldionne added a comment. This is a really neat attribute! FWIW, I think we would most likely have used it in `` if it were available back then. Assuming that GCC implemented it, I think we could consider changing to use this attribute. However: 1. This would technically be an ABI break, but thi

[PATCH] D129951: adds `__disable_adl` attribute

ldionne added a comment. In D129951#4179467 , @cjdb wrote: > I'm deeply disappointed that libc++ moved away from using `__function_like`: > that was an important part of preventing niebloid misuse. It isn't conforming > to treat niebloids as function ob

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

cor3ntin added a subscriber: ChuanqiXu. cor3ntin added a comment. In D124351#4178334 , @sammccall wrote: > Sorry for the delay, extracting the repro from the build system seems about > as much work as minimizing it :-) > F26749550: modrepo2.zip

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

wlei added subscribers: modimo, hoy, wlei. wlei added a comment. Hi @ahatanak We recently hit an issue of inconsistent codegen related with this optimization. In one build, Clang frontend generates different llvm IRs for the same function that is originally from one header file. It turned out t

[clang] 50cd2c2 - [LSAN] Disable leaks in test using environment variables instead of not running them with ASAN.

Author: Kirill Stoimenov Date: 2023-03-08T23:20:40Z New Revision: 50cd2c257cb4e5fc822e0fa5fc12d1838070fcf0 URL: https://github.com/llvm/llvm-project/commit/50cd2c257cb4e5fc822e0fa5fc12d1838070fcf0 DIFF: https://github.com/llvm/llvm-project/commit/50cd2c257cb4e5fc822e0fa5fc12d1838070fcf0.diff L

[PATCH] D145615: [LSAN] Disable leaks in test using environment variables instead of not running them with ASAN.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG50cd2c257cb4: [LSAN] Disable leaks in test using environment variables instead of not running… (authored by kstoimenov). Repository: rG LLVM Githu

[clang] 124b46a - [NFC][AArch64] Document and improve FMV code.

Author: Pavel Iliin Date: 2023-03-08T23:22:46Z New Revision: 124b46a897a7044be3cb49b9e0097d8cca47ba6b URL: https://github.com/llvm/llvm-project/commit/124b46a897a7044be3cb49b9e0097d8cca47ba6b DIFF: https://github.com/llvm/llvm-project/commit/124b46a897a7044be3cb49b9e0097d8cca47ba6b.diff LOG: [

[PATCH] D145538: [NFC][AArch64] Document and improve FMV code.

This revision was automatically updated to reflect the committed changes. Closed by commit rG124b46a897a7: [NFC][AArch64] Document and improve FMV code. (authored by ilinpv). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145538/new/ https://reviews.

[PATCH] D129951: adds `__disable_adl` attribute

cjdb added a comment. In D129951#4179481 , @ldionne wrote: > In D129951#4179467 , @cjdb wrote: > >> I'm deeply disappointed that libc++ moved away from using `__function_like`: >> that was an important part of pr

[PATCH] D145435: Choose style (file) from within code for use in IDEs

owenpan added a comment. In D145435#4179308 , @bersbersbers wrote: > In D145435#4173875 , @owenpan wrote: > >> Please refer to D125171#4167866 >> to make the case that

[PATCH] D145567: [Driver] Rename multilib flags to tags

MaskRay added a comment. Since the touched code is still in review, you need to merge the changes into the prior patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145567/new/ https://reviews.llvm.org/D145567 _

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

nickdesaulniers added a comment. In D141451#4100432 , @dblaikie wrote: > I guess my only other question (worth mentioning in the RFC, > perhaps)/direction would be that any of these "things that are expensive but > make backend diagnostics better" could

[PATCH] D131618: [clang][llvm][lld] FatLTO Prototype

paulkirth updated this revision to Diff 503568. paulkirth added a comment. Herald added a reviewer: alexander-shaposhnikov. Minor update to tests. - drop yaml2obj in favor of using llc + objcopy - remove c files Note one tests now fails, though. For some reason w/ FatLTO the linker rewrites `x

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

collinbaker updated this revision to Diff 503570. collinbaker edited the summary of this revision. collinbaker added a comment. Requested changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130303/new/ https://reviews.llvm.org/D130303 Files: c

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

collinbaker marked 5 inline comments as done. collinbaker added a comment. Changed as requested. Again leaving it up to a committer to commit this Comment at: clang/include/clang-c/Index.h:3552 + * If the cursor does not reference a bit field declaration or if the bit + * field

[PATCH] D145451: Disable tests which don't pass in HWASAN+LSAN mode

kstoimenov abandoned this revision. kstoimenov added a comment. I will send a different patch with LSAN_OPTIONS instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145451/new/ https://reviews.llvm.org/D145451 ___

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

dexonsmith added a comment. In D83906#4179512 , @wlei wrote: > Hi @ahatanak > > We recently hit an issue of inconsistent codegen related with this > optimization. In one build, Clang frontend generates different llvm IRs for > the same function that is o

[clang] 0f2f378 - Add map info for dereference pointer.

Author: Jennifer Yu Date: 2023-03-08T17:43:43-08:00 New Revision: 0f2f378425821de77e50a0dcb67c4504389a56e8 URL: https://github.com/llvm/llvm-project/commit/0f2f378425821de77e50a0dcb67c4504389a56e8 DIFF: https://github.com/llvm/llvm-project/commit/0f2f378425821de77e50a0dcb67c4504389a56e8.diff L

[PATCH] D145093: [OpenMP] Add map info for dereference pointer.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0f2f37842582: Add map info for dereference pointer. (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D145093: [OpenMP] Add map info for dereference pointer.

ronlieb added a comment. seems to fail amdgpu buildbot https://lab.llvm.org/buildbot/#/builders/193/builds/27692 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145093/new/ https://reviews.llvm.org/D145093 __

[PATCH] D145617: [clang-tidy] Add readability-avoid-unconditional-preprocessor-if check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/AvoidUnconditionalPreprocessorIfCheck.cpp:29 + return; +auto &SM = PP.getSourceManager(); +if (!isStatic(SM, PP.getLangOpts(), ConditionRange)) Please don't u

[PATCH] D145639: [Coroutines] Fix premature conversion of return object

bruno created this revision. bruno added a reviewer: ChuanqiXu. Herald added subscribers: hoy, modimo, wenlei. Herald added a project: All. bruno requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix https://github.com/llvm/llvm-project/issue

[PATCH] D145641: [Coroutines] Implement fix for cwg2563 issue and enable RVO under certain conditions

bruno created this revision. bruno added reviewers: ChuanqiXu, clang-language-wg. Herald added subscribers: hoy, modimo, wenlei. Herald added a project: All. bruno requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - The cwg2563 issue is fixed

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

rymiel created this revision. rymiel added a project: clang-format. rymiel added reviewers: HazardyKnusperkeks, MyDeveloperDay, owenpan. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The C++ grammar all

[PATCH] D145643: [clang][driver] Add option to manually control -disable-free in cc1

Chenbing.Zheng created this revision. Chenbing.Zheng added reviewers: aaron.ballman, lebedev.ri, benshi001. Chenbing.Zheng added a project: clang. Herald added subscribers: StephenFan, Anastasia. Herald added a project: All. Chenbing.Zheng requested review of this revision. Herald added subscribers

[clang] 24b8235 - Add __builtin_set_flt_rounds

Author: jinge90 Date: 2023-03-09T11:52:52+08:00 New Revision: 24b823554acd25009731b2519880aa18c7263550 URL: https://github.com/llvm/llvm-project/commit/24b823554acd25009731b2519880aa18c7263550 DIFF: https://github.com/llvm/llvm-project/commit/24b823554acd25009731b2519880aa18c7263550.diff LOG:

[PATCH] D144454: Add builtin for llvm set rounding

This revision was automatically updated to reflect the committed changes. Closed by commit rG24b823554acd: Add __builtin_set_flt_rounds (authored by xiongji90). Changed prior to commit: https://reviews.llvm.org/D144454?vs=502507&id=503602#toc Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

hubert.reinterpretcast added inline comments. Comment at: clang/test/Driver/ppc-roptr.c:10 +// ROPTR-NOT: "-mroptr" +// ROPTR-NOT: "-bforceimprw" + w2yehia wrote: > hubert.reinterpretcast wrote: > > Do we pass the option through to the LTO codegen when `-fprofile

[clang] 556a811 - [clang][nfc] Update some documentation referring to old clang flags

Author: Nathan Lanza Date: 2023-03-08T23:01:52-05:00 New Revision: 556a811d686ea5242d8c21b95a97b90aa1be7c56 URL: https://github.com/llvm/llvm-project/commit/556a811d686ea5242d8c21b95a97b90aa1be7c56 DIFF: https://github.com/llvm/llvm-project/commit/556a811d686ea5242d8c21b95a97b90aa1be7c56.diff

[PATCH] D145644: [memprof] Add scripts to automate testdata regeneration.

snehasish created this revision. snehasish added reviewers: tejohnson, dblaikie. Herald added a subscriber: wenlei. Herald added a project: All. snehasish requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. The memprof profile

[clang] 8cf85a0 - Revert "Add map info for dereference pointer."

Author: Ron Lieberman Date: 2023-03-08T22:05:31-06:00 New Revision: 8cf85a0cadb033fed3d96aa5283deb4bfbbaf2c8 URL: https://github.com/llvm/llvm-project/commit/8cf85a0cadb033fed3d96aa5283deb4bfbbaf2c8 DIFF: https://github.com/llvm/llvm-project/commit/8cf85a0cadb033fed3d96aa5283deb4bfbbaf2c8.diff

[PATCH] D145093: [OpenMP] Add map info for dereference pointer.

ronlieb added a comment. had not heard back , so reverted it for now commit 8cf85a0cadb033fed3d96aa5283deb4bfbbaf2c8 (HEAD -> main, origin/main, origin/HEAD) Author: Ron Lieberman Date: Wed Mar 8 22:01:22 2023 -0600 Rev

[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

benshi001 created this revision. benshi001 added reviewers: MaskRay, aykevl. Herald added subscribers: Jim, inglorion, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Fixes http

[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

benshi001 updated this revision to Diff 503607. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145646/new/ https://reviews.llvm.org/D145646 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/avr-ld.c

[clang] d4fcc69 - Disable test for __builtin_set_flt_rounds to avoid breaking PPC buildbot

Author: jinge90 Date: 2023-03-09T13:14:36+08:00 New Revision: d4fcc692ee15b2c6d249daabe31208d6a5afa025 URL: https://github.com/llvm/llvm-project/commit/d4fcc692ee15b2c6d249daabe31208d6a5afa025 DIFF: https://github.com/llvm/llvm-project/commit/d4fcc692ee15b2c6d249daabe31208d6a5afa025.diff LOG:

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

hoy added a comment. > (Also, can the backend safely optimize an `invoke` to a `linkonce_odr` > function that's `nounwind` to a `call`? I thought it couldn't, in case the > function is de-refined to a version that's not `nounwind`. But the frontend > can do it since it has access to the sourc

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

hubert.reinterpretcast added inline comments. Comment at: clang/docs/ReleaseNotes.rst:231 + address values in the read-only data section. This option is intended to + be used with the ``-fdata-sections`` option. When ``-mroptr`` is in effect, + read-only data sections with rel

[PATCH] D145648: [clang][Driver] recognize `-ffp-contract=fast-honor-pragmas`

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: MaskRay. `-ffp-contract=fast-honor-pragmas` is a valid option recognized by clang -cc1 but it is missed by clang driver. https://reviews.l

[PATCH] D145617: [clang-tidy] Add readability-avoid-unconditional-preprocessor-if check

PiotrZSL updated this revision to Diff 503616. PiotrZSL edited the summary of this revision. PiotrZSL added a comment. Review comments fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145617/new/ https://reviews.llvm.org/D145617 Files: clan

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

wenlei added a comment. > I wonder if this is just a single example, where there could be various other > (header-related) peepholes that cause similar problems for stable output. > IIRC, the usual Clang approach is to make as-close-to-optimal IR up front, > but maybe in some situations it's de

[PATCH] D145617: [clang-tidy] Add readability-avoid-unconditional-preprocessor-if check

PiotrZSL added a comment. There are 186 findings from this check in llvm repository, no false-positives. Example: llvm/lib/CodeGen/SelectionDAG/ScheduleDAGRRList.cpp:2071:2: warning: preprocessor condition is always 'true', consider removing condition but leaving its contents [readability-av

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5250 + if (Args.hasArg(options::OPT_mroptr) || Args.hasArg(options::OPT_mno_roptr)) { +bool HasRoptr = This only checks for `-m[no-]roptr` when the front-end i

[PATCH] D145581: [clang-tidy] In C++17, callee is guaranteed to be sequenced before arguments.

PiotrZSL requested changes to this revision. PiotrZSL added a comment. This revision now requires changes to proceed. Add more tests (those missing one), to make sure that this wont break proper cases. Refer to inline comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

hubert.reinterpretcast added inline comments. Comment at: clang/test/Driver/ppc-roptr.c:10 +// ROPTR-NOT: "-mroptr" +// ROPTR-NOT: "-bforceimprw" + hubert.reinterpretcast wrote: > w2yehia wrote: > > hubert.reinterpretcast wrote: > > > Do we pass the option throug

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

dexonsmith added a comment. Oh, de-refining is pretty nifty / evil. This patch has background: https://reviews.llvm.org/D18634 Since 2016, the optimizer is not allowed to do IPA on functions that can be de-refined (such as `linkonce_odr` functions). Here's a hypothetical problematic scenario fo

[PATCH] D145656: [clang-format] Treat &/&& as reference when followed by requires clause

rymiel created this revision. rymiel added a project: clang-format. rymiel added reviewers: HazardyKnusperkeks, MyDeveloperDay, owenpan. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, the tok

[PATCH] D137514: [clang-tidy] add check for capturing lambda coroutines

ChuanqiXu added a comment. Herald added a subscriber: PiotrZSL. Is there any new progress on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137514/new/ https://reviews.llvm.org/D137514 ___ cfe-commi

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

qiucf added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143467/new/ https://reviews.llvm.org/D143467 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

<    1   2