[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko created this revision. ivanmurashko added reviewers: sammccall, kadircet, ilya-biryukov. Herald added a subscriber: arphaman. Herald added a project: All. ivanmurashko requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang-tools

[PATCH] D145303: clang-tidy altera-id-dependent-backward-branch: print notes after warning

yeputons-gh created this revision. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. yeputons-gh requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. In Clang notes are typicall

[PATCH] D145304: clang-tidy altera-id-dependent-backward-branch: refactor test

yeputons-gh created this revision. Herald added a project: All. yeputons-gh requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. - Put all "Inferred Assignments" testing at the end - Group together ID-dependent variable/member testin

[PATCH] D145305: clang-tidy altera-id-dependent-backward-branch: fix #52790

yeputons-gh created this revision. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. yeputons-gh requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Mark variables/fields as ID

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG44c6b905f852: [CMake] Bumps minimum version to 3.20.0. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D129507: [OffloadPackager] Add option to extract files from images

jhuber6 added inline comments. Comment at: clang/test/Driver/offload-packager.c:2-3 +// REQUIRES: x86-registered-target +// REQUIRES: nvptx-registered-target +// REQUIRES: amdgpu-registered-target +// UNSUPPORTED: system-windows bader wrote: > Are nvptx and amdgp

[PATCH] D145305: clang-tidy altera-id-dependent-backward-branch: fix #52790

yeputons-gh updated this revision to Diff 502372. yeputons-gh added a comment. Applied clang-format to the header as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145305/new/ https://reviews.llvm.org/D145305 Files: clang-tools-extra/clang-t

[clang] 2708869 - Re-land "[clang][Interp] Implement C++ Range-for loops"

Author: Timm Bäder Date: 2023-03-04T15:17:44+01:00 New Revision: 2708869801ae00f4681f6b2d9d69b25b3fce26b6 URL: https://github.com/llvm/llvm-project/commit/2708869801ae00f4681f6b2d9d69b25b3fce26b6 DIFF: https://github.com/llvm/llvm-project/commit/2708869801ae00f4681f6b2d9d69b25b3fce26b6.diff LO

[PATCH] D144709: [clang-format] Improve QualifierAlignment

rymiel added a comment. This patch also fixes: https://github.com/llvm/llvm-project/issues/56111, https://github.com/llvm/llvm-project/issues/58696, and https://github.com/llvm/llvm-project/issues/54730 (some of those could probably be made duplicates but it seems they're all going down in one

[PATCH] D145098: [clang][deps] Preserve input ordering in the full output

Jake-Egan added a comment. Thanks for addressing this. Unfortunately the test is still failing after the fix and a clean build https://lab.llvm.org/buildbot/#/builders/214/builds/6170/steps/6/logs/FAIL__Clang__modules-full-output-tu-order_c Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D144709: [clang-format] Improve QualifierAlignment

rymiel added inline comments. Comment at: clang/unittests/Format/QualifierFixerTest.cpp:523 + // TODO: Something strange is going on with this formating. + verifyFormat("Bar < Foo, Foo const >> ;", "Bar < Foo, const Foo >> ;", Style); + (see below) =

[PATCH] D144709: [clang-format] Improve QualifierAlignment

MyDeveloperDay added a comment. In D144709#4169219 , @rymiel wrote: > This patch also fixes: https://github.com/llvm/llvm-project/issues/56111, > https://github.com/llvm/llvm-project/issues/58696, and > https://github.com/llvm/llvm-project/issues/54730

[PATCH] D144709: [clang-format] Improve QualifierAlignment

AlexanderHederstaf added inline comments. Comment at: clang/unittests/Format/QualifierFixerTest.cpp:733 + // TODO: Something strange is going on with this formating. + verifyFormat("Bar < Foo, const Foo >> ;", "Bar < Foo, Foo const >> ;", Style); + rymiel wrot

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

tejohnson added a comment. Sorry for the slow response. Looks pretty good, just a few minor suggestions and questions. Comment at: llvm/include/llvm/IR/MDBuilder.h:61 /// Return metadata containing two branch weights. + MDNode *createBranchWeights(uint32_t TrueWeight, ui

[PATCH] D144709: [clang-format] Improve QualifierAlignment

rymiel added inline comments. Comment at: clang/unittests/Format/QualifierFixerTest.cpp:733 + // TODO: Something strange is going on with this formating. + verifyFormat("Bar < Foo, const Foo >> ;", "Bar < Foo, Foo const >> ;", Style); + AlexanderHederstaf wrot

[PATCH] D143418: [libclang] Add API to override preamble storage path

vedgy updated this revision to Diff 502376. vedgy added a comment. Replace `clang_getDefaultGlobalOptions()` with `CXChoice` as discussed. A few unrelated small improvements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143418/new/ https://reviews

[PATCH] D145305: clang-tidy altera-id-dependent-backward-branch: fix #52790

yeputons-gh added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/altera/id-dependent-backward-branch.cpp:128 + + for (int i = 0; i < NotThreadID2; i++) { +accumulator++; This line previously yielded a false positive. Now it does not

[PATCH] D144216: [clang-tidy] Extract string header from redundant-string-cstr checker

mikecrowe updated this revision to Diff 502385. mikecrowe edited the summary of this revision. mikecrowe added a comment. This new version uses size_t and size_type rather than the annoyingly-named "size" type that the old implementation in redundant-string-cstr.cpp used and is the basis for usi

[PATCH] D145310: [clang-tidy] Make readability-container-data-pointer use header

mikecrowe created this revision. Herald added a subscriber: xazax.hun. Herald added a project: All. mikecrowe requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This requires operator[] to be added to the std::basic_string implemen

[PATCH] D145311: Make abseil-redundant-strcat-calls checker use header

mikecrowe created this revision. mikecrowe added a reviewer: carlosgalvezp. Herald added a project: All. mikecrowe requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. It's unclear where the "string" in no namespace comes from in thi

[PATCH] D145312: [clang-tidy] Make readability-string-compare check use header

mikecrowe created this revision. mikecrowe added a reviewer: carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. mikecrowe requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Improve the generic header

[PATCH] D145313: [clang-tidy] Make readability-container-size-empty check using header

mikecrowe created this revision. mikecrowe added a reviewer: carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. mikecrowe requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Improve the generic header

[PATCH] D144216: [clang-tidy] Extract string header from redundant-string-cstr checker

mikecrowe added a comment. The changes that extend the header further and use it in a few more checks are: - https://reviews.llvm.org/D145310 - https://reviews.llvm.org/D145311 - https://reviews.llvm.org/D145312 - https://reviews.llvm.org/D145313 and of course my original change: - https://re

[PATCH] D145262: [clang-format] Treat AttributeMacros more like attribute macros

jaredgrubb updated this revision to Diff 502390. jaredgrubb added a comment. Create unit-tests for the patch (and remove the proposed non-unit test "test"). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145262/new/ https://reviews.llvm.org/D145262 Files: clang/lib/Format/Continuation

[clang] fc10715 - Fix broken link on Clang documentation page

Author: Tulio Leao Date: 2023-03-05T00:58:48+02:00 New Revision: fc10715f9bb39741fcfd5373134767481235aa14 URL: https://github.com/llvm/llvm-project/commit/fc10715f9bb39741fcfd5373134767481235aa14 DIFF: https://github.com/llvm/llvm-project/commit/fc10715f9bb39741fcfd5373134767481235aa14.diff LO

[PATCH] D145047: Fix broken link on Clang documentation page

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc10715f9bb3: Fix broken link on Clang documentation page (authored by tupaschoal, committed by royjacobson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D144823: [Driver][FreeBSD] Simplify ARM handling

brad added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144823/new/ https://reviews.llvm.org/D144823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D144823: [Driver][FreeBSD] Simplify ARM handling

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. I think this is fine. @emaste can you think of any objections? 8 and 9 are long gone. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144823/new/ https

[PATCH] D145214: [TSAN] add support for riscv64

alexfanqi updated this revision to Diff 502397. alexfanqi added a comment. remove libatomic link Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145214/new/ https://reviews.llvm.org/D145214 Files: clang/lib/Driver/ToolChains/Linux.cpp compiler-r

[PATCH] D145214: [TSAN] add support for riscv64

alexfanqi added inline comments. Comment at: compiler-rt/lib/tsan/rtl/tsan_platform.h:971 }; -const uptr indicator = 0x0e00ull; +const uptr indicator = 0x0f00ull; const uptr ind_lsb = 1ull << LeastSignificantSetBitIndex(indicator); --

[PATCH] D145316: [Clang][Lex] Generate an annotation token for clang-repl

junaire created this revision. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patches adds a new annotation token called annot_input_end, which can be used to capture expression in value printing.

[PATCH] D141215: [clang-repl] Introduce Value and implement pretty printing

junaire updated this revision to Diff 502402. junaire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Interpreter/Interpreter.h clang/include/clang/I

[PATCH] D141215: [clang-repl] Introduce Value and implement pretty printing

junaire updated this revision to Diff 502405. junaire added a comment. Prefer one patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Basic/TokenKinds.def clang/include/cl

[PATCH] D145316: [Clang][Lex] Generate an annotation token for clang-repl

junaire abandoned this revision. junaire added a comment. Merged changes into the child revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145316/new/ https://reviews.llvm.org/D145316 ___ cfe-commit

[PATCH] D141215: [clang-repl] Introduce Value and implement pretty printing

junaire updated this revision to Diff 502406. junaire added a comment. Fix patch application failed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Basic/TokenKinds.def clan

[PATCH] D141215: [clang-repl] Introduce Value and implement pretty printing

junaire updated this revision to Diff 502407. junaire added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Basic/TokenKinds.def clang/include/clang/Interp