[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

HazardyKnusperkeks added a comment. And please add an entry to the `ReleaseNotes.rst`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125171/new/ https://reviews.llvm.org/D125171 ___ cfe-commits mailing l

[PATCH] D145264: [OpenMP][MLIR] Lower and apply RTLModuleFlagsAttr

agozillon added a comment. This builds on the following phabricator patches that are in review at the moment, so there are components that are used here that are added from these: https://reviews.llvm.org/D144864 : add fopenmp-is-device and an mlir is-device attribute for the OpenMP dialect htt

[PATCH] D145262: [clang-format] Treat AttributeMacros more like attribute macros

jaredgrubb added a comment. For background, the current clang-format results in the following (`-style="{BasedOnStyle: LLVM, ColumnLimit: 0, AttributeMacros: [MACRO]}`): MACRO MACRO(A) @interface Foo @end MACRO(A) MACRO @interface Foo @end This patch improves it (remove

[PATCH] D145262: [clang-format] Treat AttributeMacros more like attribute macros

jaredgrubb added a comment. I wasn't sure about testing (this is my first patch!) and the test-case I did was in `clang/test/Format` .. I can look at `clang/unittests/Format` and see how to model something like it. If I do that, would that be in-addition-to or instead-of the test-case I includ

[PATCH] D145269: Dump functions attribute right before their return type

giulianobelinassi created this revision. Herald added a project: All. giulianobelinassi requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. GCC rejects the following kind of dumps: int f(void) __att

[clang] 5e03565 - [clang/Diagnostic] Use `optional` to disambiguate between a `StoredDiagMessage` that is not set vs set as empty string

Author: Argyrios Kyrtzidis Date: 2023-03-03T12:48:48-08:00 New Revision: 5e035651fd3acbb2645abbe80cae332d90eac78a URL: https://github.com/llvm/llvm-project/commit/5e035651fd3acbb2645abbe80cae332d90eac78a DIFF: https://github.com/llvm/llvm-project/commit/5e035651fd3acbb2645abbe80cae332d90eac78a.

[PATCH] D145256: [clang/Diagnostic] Use `optional` to disambiguate between a `StoredDiagMessage` that is not set vs set as empty string

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e035651fd3a: [clang/Diagnostic] Use `optional` to disambiguate between a `StoredDiagMessage`… (authored by akyrtzi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D145270: Add codegen for llvm exp/exp2 elementwise builtins

bob80905 created this revision. bob80905 added reviewers: python3kgae, beanz, fhahn. Herald added subscribers: luke, Anastasia, StephenFan, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, ni

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

dblaikie added a comment. In D145077#4162110 , @aprantl wrote: > I originally was hoping we wouldn't have to introduce a new attribute for > this, but it looks like there are legitimate concerns about the alternatives, > so in that sense this looks good

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

dblaikie added a comment. In D145077#4168209 , @dblaikie wrote: > In D145077#4162110 , @aprantl wrote: > >> I originally was hoping we wouldn't have to introduce a new attribute for >> this, but it looks like the

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added a comment. Would be nice to have feedback on this! So much work was put into it! @rnk, @efriedma CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 ___ cfe-commits mailing list cfe-commi

[PATCH] D145271: [MSVC compatibility][DLLEXPORT/DLLIMPORT] Allow dllexport/dllimport for local classes

probinson added a subscriber: cfe-commits. probinson added a project: clang. probinson added a comment. I've looked at this but I'd like someone more in tune with MSVC behavior to review as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145271/new/ https://reviews.llvm.org/D145271

[PATCH] D145262: [clang-format] Treat AttributeMacros more like attribute macros

owenpan added a comment. In D145262#4168058 , @jaredgrubb wrote: > I wasn't sure about testing (this is my first patch!) and the test-case I did > was in `clang/test/Format` .. I can look at `clang/unittests/Format` and see > how to model something lik

[PATCH] D143745: Make section attribute and -ffunction-sections play nicely

probinson added a comment. See D145173 for a different tactic to solve this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143745/new/ https://reviews.llvm.org/D143745 ___ cfe-commits mailing list cfe-commi

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

awarzynski added inline comments. Comment at: clang/test/Driver/flang/flang-omp.f90:1 +! Check that flang -fc1 is invoked when in --driver-mode=flang +! and the relevant openmp and openmp offload flags are utilised agozillon wrote: > agozillon wrote: > > awarzyn

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

yln accepted this revision. yln added inline comments. Comment at: compiler-rt/test/asan/TestCases/replaceable_new_delete_static.cpp:10-11 + +// darwin only supports shared-libsan, so this should fail. +// XFAIL: darwin + usama54321 wrote: > yln wrote: > > usam

[PATCH] D145238: [NVPTX] Expose LDU builtins

tra added a comment. Nice. Thank you! Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18104 CodeGenFunction::EmitNVPTXBuiltinExpr(unsigned BuiltinID, const CallExpr *E) { - auto MakeLdg = [&](unsigned IntrinsicID) { + auto HasHalfSupport = [&](unsigned BuiltinID) { +auto &Co

[PATCH] D145173: Make section attribute and -ffunction-sections play nicely

MaskRay added a comment. > the programmer is indicating the function has some special purpose, and is > not expected to be garbage collected. There are use cases that GC semantics are desired. They may place the address function in a variable. I don't think changing the behavior by default is f

[PATCH] D145093: Add map info for dereference pointer.

jyu2 marked an inline comment as done. jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7489-7493 + if (UO && UO->getOpcode() == UO_Deref) +if (isa(Last->getAssociatedExpression()) || +isa(Last->getAssociatedExpression()) || +

[PATCH] D145093: Add map info for dereference pointer.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7489-7493 + if (UO && UO->getOpcode() == UO_Deref) +if (isa(Last->getAssociatedExpression()) || +isa(Last->getAssociatedExpression()) || +isa(Last->getAssociatedE

[PATCH] D145284: WIP [clang] adds capabilities for SARIF to be written to file

cjdb created this revision. cjdb added reviewers: aaron.ballman, erichkeane, shafik, dblaikie. Herald added a project: All. cjdb requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The original `-fdiagnostics-format=sarif` wrote directl

[PATCH] D145284: WIP [clang] adds capabilities for SARIF to be written to file

cjdb updated this revision to Diff 502305. cjdb edited the summary of this revision. cjdb added a comment. adds dependency Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145284/new/ https://reviews.llvm.org/D145284 Files: clang/include/clang/Basi

[PATCH] D145284: WIP [clang] adds capabilities for SARIF to be written to file

cjdb updated this revision to Diff 502308. cjdb added a comment. tidies up some stuff that I overlooked Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145284/new/ https://reviews.llvm.org/D145284 Files: clang/include/clang/Basic/DiagnosticOptions

[clang] d65379c - [analyzer] Remove the loop from the exploded graph caused by missing information in program points

Author: isuckatcs Date: 2023-03-04T02:01:45+01:00 New Revision: d65379c8d4768ddae143672f5d4827acafe22553 URL: https://github.com/llvm/llvm-project/commit/d65379c8d4768ddae143672f5d4827acafe22553 DIFF: https://github.com/llvm/llvm-project/commit/d65379c8d4768ddae143672f5d4827acafe22553.diff LOG

[PATCH] D143328: [analyzer] Remove the loop from the exploded graph caused by missing information in program points

This revision was automatically updated to reflect the committed changes. Closed by commit rGd65379c8d476: [analyzer] Remove the loop from the exploded graph caused by missing… (authored by isuckatcs). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Gi

[PATCH] D129507: [OffloadPackager] Add option to extract files from images

bader added inline comments. Comment at: clang/test/Driver/offload-packager.c:2-3 +// REQUIRES: x86-registered-target +// REQUIRES: nvptx-registered-target +// REQUIRES: amdgpu-registered-target +// UNSUPPORTED: system-windows Are nvptx and amdgpu target required

[PATCH] D145214: [TSAN] add support for riscv64

alexfanqi created this revision. Herald added subscribers: luke, Enna1, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosH

[PATCH] D145214: [TSAN] add support for riscv64

jrtc27 added inline comments. Comment at: compiler-rt/CMakeLists.txt:529 # natively, but supports --as-needed/--no-as-needed for GNU ld compatibility. -if("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "sparc") +if("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "sparc|riscv") lis

<    1   2