[clang] bce8b3c - [clang][Interp] Implement C++ Range-for loops

Author: Timm Bäder Date: 2023-03-02T08:59:07+01:00 New Revision: bce8b3c1830434c10b8a30380db522d7c6a8658d URL: https://github.com/llvm/llvm-project/commit/bce8b3c1830434c10b8a30380db522d7c6a8658d DIFF: https://github.com/llvm/llvm-project/commit/bce8b3c1830434c10b8a30380db522d7c6a8658d.diff LO

[PATCH] D140803: [clang][Interp] Implement C++ Range-for loops

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbce8b3c18304: [clang][Interp] Implement C++ Range-for loops (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 569222e - [clang][Interp] Only check constructors for global variables

Author: Timm Bäder Date: 2023-03-02T09:13:47+01:00 New Revision: 569222e172e5d28d66e9607325475b107cee20cb URL: https://github.com/llvm/llvm-project/commit/569222e172e5d28d66e9607325475b107cee20cb DIFF: https://github.com/llvm/llvm-project/commit/569222e172e5d28d66e9607325475b107cee20cb.diff LO

[PATCH] D140723: [clang][Interp] Only check constructors for global variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG569222e172e5: [clang][Interp] Only check constructors for global variables (authored by tbaeder). Changed prior to commit: https://reviews.llvm.or

[PATCH] D143418: [libclang] Add API to override preamble storage path

vedgy added inline comments. Comment at: clang/include/clang-c/Index.h:329 + * CXIndexOptions Opts = { sizeof(CXIndexOptions), + * clang_getDefaultGlobalOptions() }; + * \endcode aaron.ballman wrote: > vedgy wrote: > > When I almost finish

[PATCH] D144454: Add builtin for llvm set rounding

xiongji90 added a comment. In D144454#4163688 , @rjmccall wrote: > I see. If we're going to take the target-independent values specified by > `FLT_ROUNDS`, then the original builtin name is more appropriate. Of course, > this has the disadvantage of n

[PATCH] D140805: [clang][Interp] Add ArrayElemPtr{,Pop} opcode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b5afda61c4a: [clang][Interp] Add ArrayElemPtr{,Pop} opcode (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 6b5afda - [clang][Interp] Add ArrayElemPtr{,Pop} opcode

Author: Timm Bäder Date: 2023-03-02T09:45:18+01:00 New Revision: 6b5afda61c4ad6890e62cb8572a13a538316d31c URL: https://github.com/llvm/llvm-project/commit/6b5afda61c4ad6890e62cb8572a13a538316d31c DIFF: https://github.com/llvm/llvm-project/commit/6b5afda61c4ad6890e62cb8572a13a538316d31c.diff LO

[clang] f7ca013 - [llvm-c] Remove bindings for creating legacy passes

Author: Nikita Popov Date: 2023-03-02T09:53:50+01:00 New Revision: f7ca01333214f934c580c162afdee933e7430b6c URL: https://github.com/llvm/llvm-project/commit/f7ca01333214f934c580c162afdee933e7430b6c DIFF: https://github.com/llvm/llvm-project/commit/f7ca01333214f934c580c162afdee933e7430b6c.diff

[PATCH] D144970: [llvm-c] Remove bindings for creating legacy passes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf7ca01333214: [llvm-c] Remove bindings for creating legacy passes (authored by nikic). Herald added a project: clang. Herald added a subscriber: cfe-

[PATCH] D145146: [Driver][NFC] Remove some redundant code in Driver.cpp.

Jimerlife created this revision. Jimerlife added reviewers: phosek, kazu, abrachet. Jimerlife added a project: LLVM. Herald added a project: All. Jimerlife requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan, MaskRay. Herald added a project: clang. `options::OPT_t

[PATCH] D138713: Fix assertion failure "PathDiagnosticSpotPiece's must have a valid location." in ReturnPtrRange checker on builtin functions

steakhal added a comment. I think we should backport this to `release/16.x`. Here is the ticket for it: https://github.com/llvm/llvm-project/issues/61115 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138713/new/ https://reviews.llvm.org/D138713 __

[PATCH] D144963: [UTC] Include return type/attributes under --version 2

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa26d3031cf89: [UTC] Include return type/attributes under --version 2 (authored by nikic). Herald added a project: clang. Herald added a subscriber: c

[clang] a26d303 - [UTC] Include return type/attributes under --version 2

Author: Nikita Popov Date: 2023-03-02T09:59:22+01:00 New Revision: a26d3031cf89954d030e494d47ca6653d531dc82 URL: https://github.com/llvm/llvm-project/commit/a26d3031cf89954d030e494d47ca6653d531dc82 DIFF: https://github.com/llvm/llvm-project/commit/a26d3031cf89954d030e494d47ca6653d531dc82.diff

[clang] 93d7002 - [Clang] Implement Change scope of lambda trailing-return-type

Author: Corentin Jabot Date: 2023-03-02T10:04:16+01:00 New Revision: 93d7002dc4644b0a6f15a998dff0d55c72012e87 URL: https://github.com/llvm/llvm-project/commit/93d7002dc4644b0a6f15a998dff0d55c72012e87 DIFF: https://github.com/llvm/llvm-project/commit/93d7002dc4644b0a6f15a998dff0d55c72012e87.diff

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

This revision was automatically updated to reflect the committed changes. Closed by commit rG93d7002dc464: [Clang] Implement Change scope of lambda trailing-return-type (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124351/new/

[clang] 90d921f - [clang][Interp] Handle record initialization via CastExpr

Author: Timm Bäder Date: 2023-03-02T10:08:41+01:00 New Revision: 90d921fa1f71ff219cb42682d123a4c3922af71e URL: https://github.com/llvm/llvm-project/commit/90d921fa1f71ff219cb42682d123a4c3922af71e DIFF: https://github.com/llvm/llvm-project/commit/90d921fa1f71ff219cb42682d123a4c3922af71e.diff LO

[PATCH] D140808: [clang][Interp] Handle record initialization via CastExpr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG90d921fa1f71: [clang][Interp] Handle record initialization via CastExpr (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D

[clang] 94dd476 - [Coverage] Fix an issue: a statement after calling 'assert()' function is wrongly

Author: Ying Yi Date: 2023-03-02T09:14:44Z New Revision: 94dd4766a61bb18b263415e17e745dc2fa609162 URL: https://github.com/llvm/llvm-project/commit/94dd4766a61bb18b263415e17e745dc2fa609162 DIFF: https://github.com/llvm/llvm-project/commit/94dd4766a61bb18b263415e17e745dc2fa609162.diff LOG: [Cove

[PATCH] D144371: [LLVM-COV] Fix an issue: a statement after calling 'assert()' function is wrongly marked as 'not executed'

This revision was automatically updated to reflect the committed changes. MaggieYi marked an inline comment as done. Closed by commit rG94dd4766a61b: [Coverage] Fix an issue: a statement after calling 'assert()' function is… (authored by MaggieYi). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D145047: Fix broken link on Clang documentation page

brenoguim accepted this revision. brenoguim added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145047/new/ https://reviews.llvm.org/D145047 _

[PATCH] D144976: [clangd] Add provider info on symbol hover.

hokein added a comment. Thanks, left a few comments on the implementation. Comment at: clang-tools-extra/clangd/Hover.cpp:1091 +// FIXME(bakalova): Remove after merging https://reviews.llvm.org/D143496 +std::vector I'm not sure how we can do it. https://revie

[PATCH] D145148: [Clang][CodeGen] Fix this argument type for certain destructors

jacobly created this revision. jacobly added reviewers: efriedma, aaron.ballman. Herald added a project: All. jacobly requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With the Microsoft ABI, some destructors need to offset a parameter to get

[PATCH] D143233: [Clang][CodeGen] Fix this argument type for certain destructors

jacobly added a comment. In D143233#4161909 , @aaron.ballman wrote: > In D143233#4160206 , @efriedma > wrote: > >> Maybe worth cherry-picking to 16 branch? I think someone will need to >> rebase onto the branc

[PATCH] D145148: [Clang][CodeGen] Fix this argument type for certain destructors

jacobly added a comment. cherry-picked to release/16.x Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145148/new/ https://reviews.llvm.org/D145148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D145148: [Clang][CodeGen] Fix this argument type for certain destructors

jacobly updated this revision to Diff 501811. jacobly added a comment. Fix discrepency with original patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145148/new/ https://reviews.llvm.org/D145148 Files: clang/docs/ReleaseNotes.rst clang/lib

[clang] 43e6770 - Revert "[clang][Interp] Implement C++ Range-for loops"

Author: Timm Bäder Date: 2023-03-02T11:04:09+01:00 New Revision: 43e67707f9ab14deafc57006aad69a263c700450 URL: https://github.com/llvm/llvm-project/commit/43e67707f9ab14deafc57006aad69a263c700450 DIFF: https://github.com/llvm/llvm-project/commit/43e67707f9ab14deafc57006aad69a263c700450.diff LO

[PATCH] D145150: clang: Emit nofpclass(nan inf) for -ffinite-math-only

arsenm created this revision. arsenm added reviewers: efriedma, nikic, jcranmer-intel, kpn, andrew.w.kaylor, cameron.mcinally, sepavloff. Herald added subscribers: StephenFan, jdoerfert, hiraditya. Herald added a project: All. arsenm requested review of this revision. Herald added subscribers: llv

[PATCH] D145151: clang: Handle MatrixType in hasFloatingRepresentation

arsenm created this revision. arsenm added a reviewer: fhahn. Herald added a subscriber: StephenFan. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. Allows applying nofpclass to matrix arguments. https://reviews.llvm.org/D145151 Files: c

[PATCH] D144480: [C++20][ClangTidy] Update the ClangTidy tests to also test in C++20 mode

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/pro-type-member-init-cxx98.cpp:2 // RUN: %check_clang_tidy -std=c++98 %s cppcoreguideli

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

awarzynski added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:121-125 + if (IsOpenMPDevice) { +// -fopenmp-is-device is passed along to tell the frontend that it is +// generating code for a device, so that only the relevant declarations are +//

[PATCH] D143418: [libclang] Add API to override preamble storage path

vedgy marked an inline comment as not done. vedgy added inline comments. Comment at: clang/include/clang-c/Index.h:329 + * CXIndexOptions Opts = { sizeof(CXIndexOptions), + * clang_getDefaultGlobalOptions() }; + * \endcode vedgy wrote: > a

[PATCH] D144480: [C++20][ClangTidy] Update the ClangTidy tests to also test in C++20 mode

usaxena95 updated this revision to Diff 501822. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144480/new/ https://reviews.llvm.org/D144480 Files: clang-to

[clang-tools-extra] b4d9ac8 - [C++20][ClangTidy] Update the ClangTidy tests to also test in C++20 mode

Author: Utkarsh Saxena Date: 2023-03-02T13:02:51+01:00 New Revision: b4d9ac8b453e20e4223b5935c700698608a6425c URL: https://github.com/llvm/llvm-project/commit/b4d9ac8b453e20e4223b5935c700698608a6425c DIFF: https://github.com/llvm/llvm-project/commit/b4d9ac8b453e20e4223b5935c700698608a6425c.diff

[PATCH] D144480: [C++20][ClangTidy] Update the ClangTidy tests to also test in C++20 mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4d9ac8b453e: [C++20][ClangTidy] Update the ClangTidy tests to also test in C++20 mode (authored by usaxena95). Repository: rG LLVM Github Monorep

[PATCH] D145154: Change ClangTidy unit tests to run in C++20 mode instead of C++11.

usaxena95 created this revision. usaxena95 added a reviewer: gribozavr2. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D145

[PATCH] D144903: [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

RKSimon added a comment. @ManuelJBrito Any luck with getting this committed? Your first attempt was reverted but was it just because of the bad Differential Revision tag? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144903/new/ https://reviews.ll

[PATCH] D138539: Use std::nullopt_t instead of NoneType (NFC)

steakhal added a comment. Herald added a subscriber: thopre. This patch breaks `llvm::StringSet` equality. The following code would no longer compile: llvm::StringSet LHS; llvm::StringSet RHS; bool equal = LHS == RHS; Such code might be used as gtest assertions like `EXPECT_EQ(LHS, RHS)`.

[PATCH] D138539: Use std::nullopt_t instead of NoneType (NFC)

steakhal added a comment. Oh, I forgot to mention why this change breaks the equality operator of `llvm::StringSet`. It's because the `StringMap::operator==` will try to compare the `value` as well, which is of type `std::nullopt_t` and that has no equality comparison operator. Previously, the

[clang-tools-extra] 5e6428b - [clangd] Use the normalized file path to do the filtering.

Author: Haojian Wu Date: 2023-03-02T13:36:24+01:00 New Revision: 5e6428b00393d0483f5fede641bbb519632e9585 URL: https://github.com/llvm/llvm-project/commit/5e6428b00393d0483f5fede641bbb519632e9585 DIFF: https://github.com/llvm/llvm-project/commit/5e6428b00393d0483f5fede641bbb519632e9585.diff LO

[PATCH] D138539: Use std::nullopt_t instead of NoneType (NFC)

steakhal added a comment. Hm, it would be easier to use `llvm::StringMap` instead of `std::nullopt_t`, or some adhoc empty struct. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138539/new/ https://reviews.llvm.org/D138539

[clang-tools-extra] c396073 - Change ClangTidy unit tests to run in C++20 mode instead of C++11.

Author: Utkarsh Saxena Date: 2023-03-02T14:06:41+01:00 New Revision: c396073a0de6bc156514c34c0ffbdd227178c11b URL: https://github.com/llvm/llvm-project/commit/c396073a0de6bc156514c34c0ffbdd227178c11b DIFF: https://github.com/llvm/llvm-project/commit/c396073a0de6bc156514c34c0ffbdd227178c11b.diff

[PATCH] D145154: Change ClangTidy unit tests to run in C++20 mode instead of C++11.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc396073a0de6: Change ClangTidy unit tests to run in C++20 mode instead of C++11. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14515

[PATCH] D141714: Fix ast print of variables with attributes

giulianobelinassi updated this revision to Diff 501835. giulianobelinassi edited the summary of this revision. giulianobelinassi added a comment. Update to dump attributes right after the type specification, also fixing the __declspec case. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin updated this revision to Diff 501836. jrmolin added a comment. Updated the version string in the docs and pulled in main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125171/new/ https://reviews.llvm.org/D125171 Files: clang/docs/ClangF

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin added reviewers: MyDeveloperDay, owenpan. jrmolin added a comment. I finally found the correct CodeOwners.rst file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125171/new/ https://reviews.llvm.org/D125171

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

lenary updated this revision to Diff 501838. lenary marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144638/new/ https://reviews.llvm.org/D144638 Files: clang/test/Modules/prune.m lld/test/COFF/lto-cache.ll lld/t

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

lenary added inline comments. Comment at: llvm/utils/lit/lit/llvm/config.py:190 +return False +if "1995" not in touch_res_out: +return False michaelplatings wrote: > This could end up matching the wrong part of the stri

[PATCH] D145148: [Clang][CodeGen] Fix this argument type for certain destructors

aaron.ballman added a comment. Ah, this is for the cherry-pick to the 16.x branch -- we actually have a different process for that from usual patch submission. https://llvm.org/docs/GitHub.html#backporting-fixes-to-the-release-branches is the documentation for it, but basically, you should file

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 501842. TIFitis added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D142914 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp llvm/include/llvm/Frontend/O

[PATCH] D145158: Make clang/test/C/C2x/n2934.c compatible with targets that do not support thread_local storage.

fanbo-meng created this revision. Herald added a project: All. fanbo-meng requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D145158 Files: clang/test/C/C2x/n2934.c Index: cl

[PATCH] D145123: Call MarkVirtualMembersReferenced on an actual class definition

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thanks! LGTM, though please add a release note about the fix. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:17940 LoadExternalVTableUses(); Class = Class->ge

[PATCH] D145158: Make clang/test/C/C2x/n2934.c compatible with targets that do not support thread_local storage.

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145158/new/ https://reviews.llvm.org/D145158 _

[clang] 6420daa - Revert "[Sanitizers] Error out for -static-libsan on darwin"

Author: usama hameed Date: 2023-03-02T19:48:38+05:00 New Revision: 6420daab19e8c95f2481090564508eea1996c4de URL: https://github.com/llvm/llvm-project/commit/6420daab19e8c95f2481090564508eea1996c4de DIFF: https://github.com/llvm/llvm-project/commit/6420daab19e8c95f2481090564508eea1996c4de.diff

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

usama54321 added a comment. I have reverted the commit for now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144672/new/ https://reviews.llvm.org/D144672 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang] d812488 - Call MarkVirtualMembersReferenced on an actual class definition

Author: Stephan Bergmann Date: 2023-03-02T15:50:12+01:00 New Revision: d812488d3c54c07f24d4bef79e329f17e7f19c3b URL: https://github.com/llvm/llvm-project/commit/d812488d3c54c07f24d4bef79e329f17e7f19c3b DIFF: https://github.com/llvm/llvm-project/commit/d812488d3c54c07f24d4bef79e329f17e7f19c3b.di

[PATCH] D145123: Call MarkVirtualMembersReferenced on an actual class definition

This revision was automatically updated to reflect the committed changes. Closed by commit rGd812488d3c54: Call MarkVirtualMembersReferenced on an actual class definition (authored by sberg). Changed prior to commit: https://reviews.llvm.org/D145123?vs=501669&id=501852#toc Repository: rG LLV

[PATCH] D143751: [clang][analyzer][NFC] Refactor code of StdLibraryFunctionsChecker.

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:271 + + private: +using RangeApplyFunction = Szelethus wrote: > balazske wrote: > > This new private section is the new added code. > While generaliz

[PATCH] D145093: Add map info for dereference pointer.

ABataev added a comment. What result produces `map(a[0][:3]`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145093/new/ https://reviews.llvm.org/D145093 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

seanptmaher added a comment. Hey, Sure. The name is Sean Maher and the email is s...@chromium.org Thanks for your help. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141230/new/ https://reviews.llvm.org/D141230 __

[PATCH] D143375: clang-tidy: Count template constructors in modernize-use-default-member-init

MarcoFalke updated this revision to Diff 501858. MarcoFalke added a comment. mv release note, rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143375/new/ https://reviews.llvm.org/D143375 Files: clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp clang-tools-ex

[PATCH] D140584: [Clang] Refactor "Designators" into a unified implementation [NFC]

shafik added a comment. I think these two bug reports: https://github.com/llvm/llvm-project/issues/46132 and https://github.com/llvm/llvm-project/issues/61118 may be related to this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140584/new/

[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/AvoidCArraysCheck.cpp:94 + + auto StartOfFile = SM.getLocForStartOfFile(SM.getFileID(Location)); + while (Location != StartOfFile) { Please do not use `auto` unless type is

[PATCH] D144622: [clang][ASTImporter] Import TemplateName correctly

vabridgers accepted this revision. vabridgers added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144622/new/ https://reviews.llvm.org/D144622 ___

[PATCH] D144273: [clang][ASTImporter] Add VaList declaration to lookup table.

vabridgers accepted this revision. vabridgers added a comment. This revision is now accepted and ready to land. LGTM. Let's accept, merge and then watch to make sure we can keep the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144273/new/

[PATCH] D145164: [clang][RISCV] Enable -fasynchronous-unwind-tables by default on Linux

kito-cheng created this revision. kito-cheng added reviewers: asb, luismarques, jrtc27, MaskRay, craig.topper, reames. Herald added subscribers: luke, VincentWu, vkmr, frasercrmck, evandro, apazos, sameer.abuasal, pengfei, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMo

[PATCH] D144977: [analyzer] Fix of the initialization list parsing.

isuckatcs added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1787 + if (V && + (!targetType->isStructureOrClassType() && !targetType->isUnionType())) return *V; I assume `targetType` is the type we want to interpret the re

[PATCH] D145158: Make clang/test/C/C2x/n2934.c compatible with targets that do not support thread_local storage.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145158/new/ https://reviews.llvm.org/D145158 ___ cfe-commits mailing list cfe-comm

[PATCH] D145057: [clang][ASTImport] Add support for import of empty records

balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3897 + if (Err) +return std::move(Err); ToField->setAccess(D->getAccess()); I am not familiar with this use case, is there a path where the attributes are read from a `FieldDecl` b

[PATCH] D145150: clang: Emit nofpclass(nan inf) for -ffinite-math-only

jcranmer-intel added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2212 +static llvm::FPClassTest getNoFPClassTestMask(const LangOptions &LangOpts) { + // TODO: Handle -fno-signaling-nans + llvm::FPClassTest Mask = llvm::fcNone; Clang doesn't have s

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 501871. qiongsiwu1 added a comment. Updating `-fdata-sections` related comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Files: clang/docs/ReleaseNotes.rs

[clang] 65f7a84 - [clang][ExtractAPI] Handle platform specific unavailability correctly

Author: Ankur Date: 2023-03-02T15:49:46Z New Revision: 65f7a84cf38b9839de0f29877d5ba4895848ea73 URL: https://github.com/llvm/llvm-project/commit/65f7a84cf38b9839de0f29877d5ba4895848ea73 DIFF: https://github.com/llvm/llvm-project/commit/65f7a84cf38b9839de0f29877d5ba4895848ea73.diff LOG: [clang]

[PATCH] D144940: [clang][ExtractAPI] Handle platform specific unavailability correctly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG65f7a84cf38b: [clang][ExtractAPI] Handle platform specific unavailability correctly (authored by Arsenic, committed by dang). Repository: rG LLVM

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

krisb added a comment. Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143984/new/ https://reviews.llvm.org/D143984 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D145164: [clang][RISCV] Enable -fasynchronous-unwind-tables by default on Linux

luismarques added a comment. From Kito's comment in D144174 : https://github.com/gcc-mirror/gcc/commit/3cd08f7168c196d7a481b9ed9f4289fd1f14eea8 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145164/new/ https://rev

[clang] be646ef - Make clang/test/C/C2x/n2934.c compatible with targets that do not support thread_local storage.

Author: Fanbo Meng Date: 2023-03-02T11:18:19-05:00 New Revision: be646ef39298503592407fd7eac9ce7fc2ee5f7c URL: https://github.com/llvm/llvm-project/commit/be646ef39298503592407fd7eac9ce7fc2ee5f7c DIFF: https://github.com/llvm/llvm-project/commit/be646ef39298503592407fd7eac9ce7fc2ee5f7c.diff LO

[PATCH] D145158: Make clang/test/C/C2x/n2934.c compatible with targets that do not support thread_local storage.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe646ef39298: Make clang/test/C/C2x/n2934.c compatible with targets that do not support… (authored by fanbo-meng). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D141307: [WIP] Add -f[no-]loop-versioning option

Leporacanthicus updated this revision to Diff 501881. Leporacanthicus added a comment. Update for rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141307/new/ https://reviews.llvm.org/D141307 Files: clang/include/clang/Driver/Options.td c

[PATCH] D145093: Add map info for dereference pointer.

jyu2 added a comment. In D145093#4164528 , @ABataev wrote: > What result produces `map(a[0][:3]`? Yes, that would be another way to fix the runtime problem. However the difficulty is when process array section, section base is different. with a[0][:3]

[PATCH] D144967: [PowerPC] Recognize long CPU name for -mtune in Clang

nathanchance added a comment. Could this be merged into `main` and backported to `release/16.x`? If this makes 16.0.0 final, I think the kernel can avoid working around this issue altogether, as `-mtune` was only wired up to do something on PowerPC in during the 16 development cycle; in prior v

[PATCH] D145093: Add map info for dereference pointer.

ABataev added a comment. In D145093#4164854 , @jyu2 wrote: > In D145093#4164528 , @ABataev wrote: > >> What result produces `map(a[0][:3]`? > > Yes, that would be another way to fix the runtime problem. However t

[clang] 3711403 - [AMDGPU] Mark mbcnt as convergent

Author: Yaxun (Sam) Liu Date: 2023-03-02T11:56:32-05:00 New Revision: 37114036aa57e53217a57afacd7f47b36114edfb URL: https://github.com/llvm/llvm-project/commit/37114036aa57e53217a57afacd7f47b36114edfb DIFF: https://github.com/llvm/llvm-project/commit/37114036aa57e53217a57afacd7f47b36114edfb.dif

[PATCH] D145093: Add map info for dereference pointer.

jyu2 added a comment. > I mean we shall emit the same mapping for `(*a)[:3]` and for `a[0][:3]` Yes I mean emit (*a)[:3] as a[0][:3] The difficulty is during the process array section of OMPArraySectionExpr 0x12aa37e0 '' lvalue | -ImplicitCastExpr 0x12a8a918 'int *' | | `-ArraySubscriptExpr 0

[PATCH] D145072: [AMDGPU] Mark mbcnt as convergent

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG37114036aa57: [AMDGPU] Mark mbcnt as convergent (authored by yaxunl). Herald added a project: clang. Herald added a subscriber: cfe-commits. Reposit

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

michaelplatings accepted this revision. michaelplatings added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144638/new/ https://reviews.llvm.org/D144638 _

[PATCH] D145093: Add map info for dereference pointer.

ABataev added a comment. In D145093#4164877 , @jyu2 wrote: >> I mean we shall emit the same mapping for `(*a)[:3]` and for `a[0][:3]` > > Yes I mean emit (*a)[:3] as a[0][:3] > > The difficulty is during the process array section of > OMPArraySectionExpr

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

browneee added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan_custom.cpp:221 + if (flags().strict_data_dependencies) { +*ret_label = res ? s_label : 0; + } else { tkuchta wrote: > browneee wrote: > > When `res != NULL`, then `res` is derived from

[PATCH] D136864: [Clang] Create opaque type for AArch64 SVE2p1/SME2 svcount_t.

paulwalker-arm added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:730 ASTContext::BuiltinVectorTypeInfo Info = - CGM.getContext().getBuiltinVectorTypeInfo(BT); - unsigned NumElemsPerVG = (Info.EC.getKnownMinValue() * Info.NumVectors) / 2; +

[PATCH] D145047: Fix broken link on Clang documentation page

royjacobson accepted this revision. royjacobson added a comment. Thanks! Do you need me to land this for you? If so, could you please provide name + email to sign the commit with? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145047/new/ https://r

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

dmaclach updated this revision to Diff 501899. dmaclach added a comment. Herald added subscribers: Sanitizers, Enna1. Updated with fixed tests for `replaceable_new_delete.cpp`. Split `replaceable_new_delete.cpp` into `replaceable_new_delete_shared.cpp` and `replaceable_new_delete_static.cpp`. St

[PATCH] D145148: [Clang][CodeGen] Fix this argument type for certain destructors

jacobly abandoned this revision. jacobly added a comment. Following release cherry-pick workflow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145148/new/ https://reviews.llvm.org/D145148 ___ cfe-commit

[PATCH] D144273: [clang][ASTImporter] Add VaList declaration to lookup table.

donat.nagy added a comment. @balazske > I tried to find out how to add a correct test but could not check if this > fails or not on AArch64 platform. [...] I want to touch ASTContext only if a > test failure is found on AArch64 that makes it necessary. It's possible to "simulate" the AArch64 b

[PATCH] D144622: [clang][ASTImporter] Import TemplateName correctly

donat.nagy accepted this revision. donat.nagy added a comment. LGTM as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144622/new/ https://reviews.llvm.org/D144622 ___ cfe-commits mailing list cfe-co

[PATCH] D144903: [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

ManuelJBrito added a comment. I originally reverted it because of the wrong tag, but there were also some buildbot failures (see https://lab.llvm.org/buildbot/#/builders/139/builds/36736). It appears to be failing an assert in DiagnosticsEngine::DiagStateMap::append, but i'm not very familiar w

[PATCH] D142800: [Clang][Diagnostic] Add `-Wcomparison-op-parentheses` to warn on chained comparisons

aaron.ballman added a comment. In D142800#4104241 , @hazohelet wrote: >> Also, why are these diagnostics off by default? Do we have some idea as to >> the false positive rate? > > As for the false positive rate, I have checked for instances of this warni

[PATCH] D143704: [Flang] Part one of Feature List action

elmcdonough updated this revision to Diff 501919. elmcdonough added a comment. Clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704 Files: flang/examples/CMakeLists.txt flang/examples/FeatureL

[PATCH] D144884: [clang-format] Only add pragma continuation indentation for 'omp' clauses

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1280 +FormatToken *PragmaType = State.Line->First->Next->Next; +if (PragmaType && PragmaType->TokenText.equals("omp")) + return CurrentState.Indent + Style.ContinuationIndentW

[PATCH] D144884: [clang-format] Only add pragma continuation indentation for 'omp' clauses

jhuber6 added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1280 +FormatToken *PragmaType = State.Line->First->Next->Next; +if (PragmaType && PragmaType->TokenText.equals("omp")) + return CurrentState.Indent + Style.ContinuationIndentWidth; -

[PATCH] D145093: Add map info for dereference pointer.

jyu2 updated this revision to Diff 501921. jyu2 added a comment. Thanks Alexey for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145093/new/ https://reviews.llvm.org/D145093 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/Se

[PATCH] D145093: Add map info for dereference pointer.

jyu2 added a comment. > Yes, I understand. And did not ask for it. I just mean that a[0][:3] emits > different mapping data - TARGET_PAPARM|TO|FROM, PTR_AND_OBJ|TO|FROM Oh I see. I was think alloc for adding pointer. But I now think I should just orignal maptype. Changed thanks. Repository

  1   2   >