[PATCH] D143524: Make the -Wunused-template default.

v.g.vassilev added a comment. In D143524#4150286 , @aaron.ballman wrote: > In D143524#4148024 , @v.g.vassilev > wrote: > >> Indeed the warning is noisy but it will potentially fix broken code which >> were unab

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

dkrupp added a comment. > TaintBugReport is brilliant and we already have a precedent for subclassing > BugReport in another checker. However I'm somewhat worried that once we start > doing more of this, we'll eventually end up with multiple inheritance > situations when the report needs multip

[PATCH] D144115: [clang] Extend pragma dump to support expressions

aaron.ballman added a comment. In D144115#4148026 , @Endill wrote: > Despite having a dozen of `#pragma __debug` directives, none of them are > tested neither mentioned in any kind of documentation, including release > notes. Are you sure about this? If

[PATCH] D144730: [FlowSensitive][WIP] log analysis progress for debugging purposes

sammccall created this revision. Herald added a subscriber: wenlei. Herald added a reviewer: NoQ. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is just a draft and a starting point, and needs mo

[PATCH] D143524: Make the -Wunused-template default.

aaron.ballman added a comment. In D143524#4150289 , @v.g.vassilev wrote: > In D143524#4150286 , @aaron.ballman > wrote: > >> In D143524#4148024 , @v.g.vassilev >> wrote

[PATCH] D144730: [FlowSensitive][WIP] log analysis progress for debugging purposes

sammccall updated this revision to Diff 500166. sammccall added a comment. A little more docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144730/new/ https://reviews.llvm.org/D144730 Files: clang/examples/CMakeLists.txt clang/examples/FlowSe

[PATCH] D144730: [FlowSensitive][WIP] log analysis progress for debugging purposes

sammccall added a comment. Example textual log (though better with colors): === Beginning data flow analysis === int target(int x) { while (x > 0) { --x; } return x + 1; } FunctionDecl 0x2a9a300 line:1:5 target 'int (int)' |-ParmVarDecl

[PATCH] D144730: [FlowSensitive][WIP] log analysis progress for debugging purposes

sammccall updated this revision to Diff 500172. sammccall added a comment. Fix colors, log source Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144730/new/ https://reviews.llvm.org/D144730 Files: clang/examples/CMakeLists.txt clang/examples/Fl

[PATCH] D143418: [libclang] Add API to set preferred temp dir path

aaron.ballman added a comment. In D143418#4148003 , @vedgy wrote: > In D143418#4147578 , @aaron.ballman > wrote: > >> In D143418#4131156 , @vedgy wrote: >> >>> On second

[PATCH] D144626: [C++20] [Modules] Trying to compare the trailing require clause of the primary template when performing ODR checking

erichkeane added a comment. That looks reasonable to me, though I fear all the libcxx failures are going to be related to this, please make sure to check them out! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144626/new/ https://reviews.llvm.org/D144626 __

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

klimek updated this revision to Diff 500181. klimek marked 5 inline comments as done. klimek added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144170/new/ https://reviews.llvm.org/D144170 Files: clang/includ

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

klimek added inline comments. Comment at: clang/lib/Format/MacroExpander.cpp:172 assert(defined(ID->TokenText)); + assert( + (!OptionalArgs && ObjectLike.find(ID->TokenText) != ObjectLike.end()) || sammccall wrote: > this assertion failure isn't going to

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. Adding Erich as he's more familiar with ifunc and friends. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:345 + const llvm::GlobalValue *&GV, +

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

aaron.ballman added a comment. Btw, these changes should come with a release note as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143803/new/ https://reviews.llvm.org/D143803 ___ cfe-commits maili

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

erichkeane added a comment. >> which confuses me because an extern "C" block is not supposed to mangle any >> names, right? Appreciate any inputs on this. That IS strange, that has internal linkage, but so the 'extern "C"' doesn't do anything to it, so we choose to just mangle it. I guess ther

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

aaron.ballman edited reviewers, added: erichkeane, royjacobson, clang-language-wg; removed: mizvekov. aaron.ballman added a subscriber: rjmccall. aaron.ballman added a comment. In D140996#4125177 , @bolshakov-a wrote: > @aaron.ballman, @rsmith, @mizveko

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

sammccall added a comment. Still LG Comment at: clang/lib/Format/MacroExpander.cpp:172 assert(defined(ID->TokenText)); + assert( + (!OptionalArgs && ObjectLike.find(ID->TokenText) != ObjectLike.end()) || klimek wrote: > sammccall wrote: > > this assert

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

erichkeane added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:3036 if (!std::is_trivially_destructible::value) { - auto DestroyPtr = [](void *V) { static_cast(V)->~T(); }; - AddDeallocation(DestroyPtr, Ptr); + auto DestroyPtr = [](void *V)

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

klimek updated this revision to Diff 500191. klimek added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144170/new/ https://reviews.llvm.org/D144170 Files: clang/include/clang/Format/Format.h clang/lib/Forma

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

klimek added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:4592 + !Macros.hasArity(ID->TokenText, Args->size())) { +// The macro is overloaded to be both object-like and function-like, +// but none of the function-like arities matc

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

aaron.ballman added a comment. Generally LGTM with a few comments sprinkled around. Comment at: clang/include/clang/Basic/Attr.td:4129 + let Documentation = [WebAssemblyExportNameDocs]; + let Subjects = SubjectList<[TypedefName], ErrorDiag>; +} pmatos wrote:

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

aaron.ballman added a reviewer: erichkeane. aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Stmt.h:456 - class ArrayOrMatrixSubscriptExprBitfields { + class AMTSubscriptExprBitfields { friend class ArraySubscriptExpr; I am not ce

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG01402831aaae: [clang-format] Add simple macro replacements in formatting. (authored by klimek). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 0140283 - [clang-format] Add simple macro replacements in formatting.

Author: Manuel Klimek Date: 2023-02-24T15:44:24Z New Revision: 01402831aaae76e9c61595f9aa81a506b0d926eb URL: https://github.com/llvm/llvm-project/commit/01402831aaae76e9c61595f9aa81a506b0d926eb DIFF: https://github.com/llvm/llvm-project/commit/01402831aaae76e9c61595f9aa81a506b0d926eb.diff LOG:

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

0xdc03 added a comment. I will try to come up with a better diagnostic for this issue and will try and update the patch as soon as I can. In D143803#4150423 , @aaron.ballman wrote: > Btw, these changes should come with a release note as well. Are all

[PATCH] D144709: [clang-format] Improve west to east const

AlexanderHederstaf updated this revision to Diff 500215. AlexanderHederstaf added a comment. Fixed the const/volatile placement. Added a few tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144709/new/ https://reviews.llvm.org/D144709 Files:

[PATCH] D143704: [Flang] Part one of Feature List action

jdoerfert added a comment. can we have a test? Comment at: flang/examples/FeatureList/FeatureList.cpp:605 + template bool Pre(const std::variant &) { return true; } + template void Post(const std::variant &) {} +}; Can you record the features we missed so

[PATCH] D139028: [RFC][clang] Add attribute-like keywords

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. Roping in Erich as the attributes code owner. In general, I think this is going in roughly the right direction. One concern I have is that the distinction between a keyword spelling for an attribute is now a bit harder. W

[PATCH] D143418: [libclang] Add API to set preferred temp dir path

vedgy added a comment. In D143418#4150360 , @aaron.ballman wrote: > So my intuition is that the current behavior works well enough and I doubt > anyone's going to propose changes to it in the future. So adding the `GlobalOptions` member to `CXIndexOpti

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

aaron.ballman added a comment. In D143803#4150624 , @0xdc03 wrote: > In D143803#4150423 , @aaron.ballman > wrote: > >> Btw, these changes should come with a release note as well. > > Are all functional changes lo

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:359-360 +if (ND->getName() == GV->getName()) { + Diags.Report(Location, diag::note_alias_requires_mangled_name) + << GV->getName() << Name; +} ---

[PATCH] D144730: [FlowSensitive][WIP] log analysis progress for debugging purposes

sammccall added a comment. I wanted to share this to get some initial thoughts as we'd discussed debuggability a while ago. As mentioned I'd at least want to get a reasonable HTML report before moving forward with it though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D143418: [libclang] Add API to set preferred temp dir path

aaron.ballman added a comment. In D143418#4150724 , @vedgy wrote: > In D143418#4150360 , @aaron.ballman > wrote: > >> So my intuition is that the current behavior works well enough and I doubt >> anyone's going

[PATCH] D144686: [CodeGen] Remove the template specialization of `Address` that stores alignment information into pointers

ahatanak updated this revision to Diff 500222. ahatanak added a comment. Remove AddressImpl altogether. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144686/new/ https://reviews.llvm.org/D144686 Files: clang/lib/CodeGen/Address.h Index: clang/l

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:359-360 +if (ND->getName() == GV->getName()) { + Diags.Report(Location, diag::note_alias_requires_mangled_name) + << GV->getName() << Name; +}

[PATCH] D144709: [clang-format] Improve west to east const

AlexanderHederstaf updated this revision to Diff 500225. AlexanderHederstaf added a comment. Add test with advanced type that would not work before. Add pointer to member. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144709/new/ https://reviews.ll

[PATCH] D139028: [RFC][clang] Add attribute-like keywords

aaron.ballman added a comment. One thing that might also help is to split this into a few stages. 1) Add the new general functionality, 2) Replacing the existing implementation of keyword attributes with the new functionality where possible, 3) Add new attributes using the new functionality. It

[clang-tools-extra] 8ae5e9e - Revert "[clang-tidy] handle exceptions properly in `ExceptionAnalyzer`"

Author: David Spickett Date: 2023-02-24T16:37:14Z New Revision: 8ae5e9edcdb394794d8c4d1ee286f1b500aaf826 URL: https://github.com/llvm/llvm-project/commit/8ae5e9edcdb394794d8c4d1ee286f1b500aaf826 DIFF: https://github.com/llvm/llvm-project/commit/8ae5e9edcdb394794d8c4d1ee286f1b500aaf826.diff LOG

[PATCH] D139028: [RFC][clang] Add attribute-like keywords

erichkeane added a comment. In D139028#4150761 , @aaron.ballman wrote: > One thing that might also help is to split this into a few stages. 1) Add the > new general functionality, 2) Replacing the existing implementation of > keyword attributes with th

[PATCH] D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

DavidSpickett added a comment. The test was timing out on Arm/AArch64 bots so I have reverted this change. I think because there were other test failures on the initial run, that obscured the time out. This is one of the first builds to include this change: https://lab.llvm.org/buildbot/#/build

[PATCH] D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

DavidSpickett added a comment. If it helps, the bot I linked is pretty vanilla. You can find all the details in the buildbot UI but just in case: cmake -G Ninja ../llvm/llvm -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=True '-DLLVM_LIT_ARGS='"'"'-v'"'"'' -DCMAKE_INSTALL_PREFIX=../stag

[PATCH] D129689: [limits.h] USHRT_MAX fix for 16 bit architectures

cor3ntin added a comment. @aaron.ballman I think we should close this change as it's superseeded by https://reviews.llvm.org/D144218 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129689/new/ https://reviews.llvm.org/D129689 ___ cfe-commits m

[PATCH] D144217: [clang-tidy] Fix false-positive in readability-container-size-empty

PiotrZSL updated this revision to Diff 500232. PiotrZSL added a comment. Rebase + Used existing matcher instead of creating new one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144217/new/ https://reviews.llvm.org/D144217 Files: clang-tools-ext

[PATCH] D144196: [C2x] Remove the ATOMIC_VAR_INIT macro from stdatomic.h

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. Sorry it took me a while to reply to you. I think you convinced me this is fine as-is! Thanks Comment at: clang/lib/Headers/stdatomic.h:50 + in C2x mode; switch to the

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a added a subscriber: mizvekov. bolshakov-a added a comment. Thanks for the review! I definitely can try to answer questions and fix issues, but I just want to note that I'm not the original author, and these changes already were upstream. (Maybe, @rsmith will find some time for taking

[PATCH] D132398: Allow constant static members to be used with 'this'

cor3ntin added a comment. Herald added a subscriber: ChuanqiXu. Given this has not made progress in a while, I think we should try to implement https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p2280r4.html instead of this approach, as I'm not sure if that's strictly conforming, and a mor

[PATCH] D142490: [Clang] Fix ClassifyImplicitMemberAccess to handle cases where the access in an unevaluated context is not within a CXXRecordDecl or CXXMethodDecl

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though you should add a release note as well. Comment at: clang/lib/Sema/SemaExprMember.cpp:164-167 if (CXXMethodDecl *MD = dyn_cast(DC)) contextC

[clang] dc07867 - [clang][Driver] Pass /INFERASANLIBS:NO to link.exe under -fsanitize=address

Author: Arthur Eubanks Date: 2023-02-24T09:28:10-08:00 New Revision: dc07867dc9991c982bd3441da19d6fcc16ea54d6 URL: https://github.com/llvm/llvm-project/commit/dc07867dc9991c982bd3441da19d6fcc16ea54d6 DIFF: https://github.com/llvm/llvm-project/commit/dc07867dc9991c982bd3441da19d6fcc16ea54d6.diff

[PATCH] D144684: [clang][Driver] Pass /INFERASANLIBS:NO to link.exe under -fsanitize=address

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdc07867dc999: [clang][Driver] Pass /INFERASANLIBS:NO to link.exe under -fsanitize=address (authored by aeubanks). Repository: rG LLVM Github Monor

[PATCH] D131618: [clang][llvm][lld] FatLTO Prototype

paulkirth added a comment. Seems like the `EmbedBitcodePass` comes straight from D130777 . It may make more sense to drop that part of the patch here, and rebase on top of it. On the downside, from what I can see this patch and D130777

[PATCH] D144569: [Clang][OpenMP] Fix accessing of aligned arrays in offloaded target regions

jhuber6 added inline comments. Comment at: clang/test/OpenMP/amdgpu_target_with_aligned_attribute.c:1 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --function-signature --include-generated-funcs --replace-value-regex "__omp_offloading_

[PATCH] D144748: [clang-tidy] Add bugprone-empty-catch check

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Detects and suggests ad

[PATCH] D144569: [Clang][OpenMP] Fix accessing of aligned arrays in offloaded target regions

jhuber6 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:2274 + if (!IsByRef) { +if ((Ctx.getTargetInfo().getTriple().isAMDGCN()) || +(Ctx.getTargetInfo().getTriple().isNVPTX())) { Why does this handling need to be different between C

[clang] e419e22 - [CodeGen] Stop storing alignment information into pointers in Address

Author: Akira Hatanaka Date: 2023-02-24T10:33:10-08:00 New Revision: e419e22ff6fdff97191d132555ded7811c3f5b05 URL: https://github.com/llvm/llvm-project/commit/e419e22ff6fdff97191d132555ded7811c3f5b05 DIFF: https://github.com/llvm/llvm-project/commit/e419e22ff6fdff97191d132555ded7811c3f5b05.diff

[PATCH] D144686: [CodeGen] Remove the template specialization of `Address` that stores alignment information into pointers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe419e22ff6fd: [CodeGen] Stop storing alignment information into pointers in Address (authored by ahatanak). Repository: rG LLVM Github Monorepo C

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

aaron.ballman added a comment. In D140996#4150848 , @bolshakov-a wrote: >> Should this also update the status in clang/www/cxx_status.html? > > I'm not sure. There still remains an issue with template parameters of > reference type, which was tried to b

[PATCH] D132398: Allow constant static members to be used with 'this'

aaron.ballman added a comment. In D132398#4150851 , @cor3ntin wrote: > Given this has not made progress in a while, I think we should try to > implement > https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p2280r4.html instead > of this approach,

[PATCH] D143142: [clang][lex] Enable Lexer to grow its buffer

tahonermann added a comment. The changes made (from what I've seen, I haven't reviewed every line) make sense to me. The amount of change does make me a bit nervous though. In D143142#4142212 , @aaron.ballman wrote: > In terms of whether to use `unsign

[PATCH] D144510: [clang-tidy] improve readability-identifier-naming hungarian options test

amurzeau updated this revision to Diff 500256. amurzeau added a comment. Rebase on main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144510/new/ https://reviews.llvm.org/D144510 Files: clang-tools-extra/test/clang-tidy/checkers/readability/Inp

[clang] 898c673 - [C2x] Remove the ATOMIC_VAR_INIT macro from stdatomic.h

Author: Aaron Ballman Date: 2023-02-24T13:52:41-05:00 New Revision: 898c673e0835a2df395dd2476ac8ee8972d6380b URL: https://github.com/llvm/llvm-project/commit/898c673e0835a2df395dd2476ac8ee8972d6380b DIFF: https://github.com/llvm/llvm-project/commit/898c673e0835a2df395dd2476ac8ee8972d6380b.diff

[PATCH] D144196: [C2x] Remove the ATOMIC_VAR_INIT macro from stdatomic.h

This revision was automatically updated to reflect the committed changes. Closed by commit rG898c673e0835: [C2x] Remove the ATOMIC_VAR_INIT macro from stdatomic.h (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144196/new/

[clang-tools-extra] 3f6a8d5 - [clang-tidy] improve readability-identifier-naming hungarian options test

Author: Alexis Murzeau Date: 2023-02-24T19:17:56Z New Revision: 3f6a8d52d64553239aade3a425a5f56ebe88bc9e URL: https://github.com/llvm/llvm-project/commit/3f6a8d52d64553239aade3a425a5f56ebe88bc9e DIFF: https://github.com/llvm/llvm-project/commit/3f6a8d52d64553239aade3a425a5f56ebe88bc9e.diff LOG

<    1   2