[PATCH] D144341: [Driver][FreeBSD] Correct driver behavior if a triple is provided without a version

arichardson added a comment. LGTM, but I'll let @dim and @emaste decide if FreeBSD 8 code is still needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144341/new/ https://reviews.llvm.org/D144341 ___ c

[PATCH] D144453: [clangd] Fix a bug in TweakTest::decorate()

nridge created this revision. nridge added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. The second argument

[PATCH] D144341: [Driver][FreeBSD] Correct driver behavior if a triple is provided without a version

brad updated this revision to Diff 499055. brad edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144341/new/ https://reviews.llvm.org/D144341 Files: clang/lib/CodeGen/TargetInfo.cpp clang/lib/Driver/ToolChains/F

[PATCH] D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations

labath added a comment. In D144181#4139446 , @Michael137 wrote: >> Hmm, I'd sort of still be inclined to look further at the linkage name >> option - but maybe the existence of a situation where the usage is built >> with debug info, but the out of lin

[PATCH] D144454: Add builtin for llvm set rounding

xiongji90 created this revision. Herald added a project: All. xiongji90 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. llvm.get.rounding and llvm.set.rounding have been added to llvm and for llvm.get.rounding, a corresponding builtin "__b

[PATCH] D144456: [clangd] Publish diagnostics with stale preambles

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: arphaman, javed.absar. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D141757: [clangd] allow extracting to variable for complete lambda expressions

nridge added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:84 + // Local variables declared inside of the selected lambda cannot go out of + // scope. The DeclRefExprs that are important are the lambda captures and + // capture var i

[PATCH] D144457: [clang][Interp] Handle global composite temporaries

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We only did this for primitive temporaries.

[PATCH] D141757: [clangd] allow extracting to variable for complete lambda expressions

nridge added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:86 + // capture var intitializers. + if (const auto *const LExpr = llvm::dyn_cast(Expr)) { +FindDeclRefsVisitor Visitor; On the other hand, the exclusion

[PATCH] D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations

Michael137 added a comment. > The construction of the mangled name does not require getting just the abi > tags of the constructor itself right. Rather, it requires knowing the abi tag > annotations of all arguments (template and regular) of the constructor, and > template arguments of all encl

[PATCH] D144341: [Driver][FreeBSD] Correct driver behavior if a triple is provided without a version

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. In D144341#4140652 , @arichardson wrote: > LGTM, but I'll let @dim and @emaste decide if FreeBSD 8 code is still needed. No, these versions are ancient now

[PATCH] D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations

Michael137 added a comment. Although I don't know of a scenario where we ever explicitly need to call the base object constructor from the expression evaluator. So maybe we can get away with only linking the complete object constructor DIE to the subprogram. Via a `DW_AT_LLVM_complete_ctor` or

[PATCH] D144317: [clang-format] Fix handling of TypeScript tuples with optional last member

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. Thank you for this LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144317/new/ https://reviews.llvm.org/D144317 ___ cfe-commits m

[clang] 801bd32 - [clalng-format] Fix handling of TypeScript tuples with optional last member

Author: Taymon A. Beal Date: 2023-02-21T02:51:56-08:00 New Revision: 801bd3265362389a7125051128fdd3e6e85cc37b URL: https://github.com/llvm/llvm-project/commit/801bd3265362389a7125051128fdd3e6e85cc37b DIFF: https://github.com/llvm/llvm-project/commit/801bd3265362389a7125051128fdd3e6e85cc37b.diff

[PATCH] D144317: [clang-format] Fix handling of TypeScript tuples with optional last member

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG801bd3265362: [clalng-format] Fix handling of TypeScript tuples with optional last member (authored by taymonbeal, committed by owenpan). Repository

[clang] 0ef289e - [clang-format][NFC] Clean up nullptr comparison style

Author: Owen Pan Date: 2023-02-21T02:56:27-08:00 New Revision: 0ef289e5b24b531d920894f909fe31b009f1 URL: https://github.com/llvm/llvm-project/commit/0ef289e5b24b531d920894f909fe31b009f1 DIFF: https://github.com/llvm/llvm-project/commit/0ef289e5b24b531d920894f909fe31b009f1.diff LOG:

[PATCH] D144355: [clang-format][NFC] Clean up nullptr comparison style

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0ef289e5b24b: [clang-format][NFC] Clean up nullptr comparison style (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

jolanta.jensen updated this revision to Diff 499101. jolanta.jensen added a comment. Adjusted the test for Windows OS. Once again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144179/new/ https://reviews.llvm.org/D144179 Files: clang/include/cl

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

kmclaughlin added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:8874 case SVETypeFlags::EltTyBool64: + case SVETypeFlags::EltTyBool128: return Builder.getInt1Ty(); Is it necessary to add an `EltTypeBool128`? I think the EmitSVEPredicateCas

[PATCH] D144299: [NFC] Added a lit test for the arithmetic fence builtin.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144299/new/ https://reviews.llvm.org/D144299

[PATCH] D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations

labath added a comment. In D144181#4140831 , @Michael137 wrote: >> The construction of the mangled name does not require getting just the abi >> tags of the constructor itself right. Rather, it requires knowing the abi >> tag annotations of all argumen

[PATCH] D101479: [Driver] Support libc++ in MSVC

hofst added a comment. I was looking forward to this change in clang 16 but just noticed that you had to revert the change again at August 18 2022. @phosek Do you still plan to work on this change? Is there any way I could help? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations

Michael137 added a comment. > This is what I meant by the "extension for the asm annotation for > constructors" part. In principle, we could extend clang so that one can write > something like this: Ah thanks for elaborating. That's an interesting approach. So this would require adding the asm

[clang] a790d77 - [NFC] Added a lit test for the arithmetic fence builtin.

Author: Ammarguellat Date: 2023-02-21T08:33:03-05:00 New Revision: a790d777465c64204a5437816beca3ff3f3326d6 URL: https://github.com/llvm/llvm-project/commit/a790d777465c64204a5437816beca3ff3f3326d6 DIFF: https://github.com/llvm/llvm-project/commit/a790d777465c64204a5437816beca3ff3f3326d6.diff

[PATCH] D144196: [C2x] Remove the ATOMIC_VAR_INIT macro from stdatomic.h

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:80 +- Removed the ``ATOMIC_VAR_INIT`` macro in C2x and later standards modes, which + implements `WG14 N2886 `_ cor3ntin w

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:222 + tooling::addExpandedResponseFiles(Cmd, Command.Directory, Tokenizer, *FS); + tooling::addTargetAndModeForProgramName(Cmd, Cmd.front()); auto &OptTable = clang::driver::getDri

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/RvalueReferenceParamNotMovedCheck.cpp:22-24 + parmVarDecl(hasType(type(rValueReferenceType(.bind("param"), + parmVarDecl( + equalsBoundNode("param"), ---

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/RvalueReferenceParamNotMovedCheck.cpp:21 + Finder->addMatcher( + parmVarDecl(allOf( + parmVarDecl(hasType(type(rValueReferenceType(.bind("param"), and y

[PATCH] D144480: [C++20][ClangTidy] Update the ClangTidy tests to also test in C++20 mode

usaxena95 created this revision. Herald added subscribers: kbarton, nemanjai. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/RvalueReferenceParamNotMovedCheck.cpp:26-29 + unless(hasType(qualType(references(templateTypeParmType( + hasDeclaration(templateTypeParmDecl())), +

[PATCH] D141950: Use find_last_of when seraching for code in getRawCommentForDeclNoCacheImpl

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! You should probably put "NFC" into the patch title when landing the changes though, so it's more clear as to why there's no test coverage. Do you think this warrants adding

[PATCH] D144482: [clang][docs] Document ThinLTO options for ld64.lld

int3 created this revision. int3 added reviewers: lld-macho, tejohnson, lgrey. Herald added subscribers: ormris, steven_wu, hiraditya, inglorion. Herald added a project: All. int3 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The LTO-cach

[PATCH] D143496: [clangd] Add support for missing includes analysis.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:359 +TransformedInc.Angled = WrittenRef.starts_with("<"); +auto FE = SM.getFileManager().getFile(Inc.Resolved); +if (!FE) unfortunately `getFile` returns an `llvm:

[PATCH] D144444: [PowerPC] Use member function to determine PowerPC Secure PLT

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. Yes, this is quite a bit nicer. Maybe run the isPPCSecurePlt() function through clang-format, just to be sure of the style? (I think you can ignore the weird libFuzzer Unit Test errors, they don't s

[PATCH] D144484: [Tooling/Inclusion] Handle std::get symbol.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added projects: clang, clang-tools-extra. Currently, we handle it as a symbol without a header. In general, for the in

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

yaxunl added inline comments. Comment at: clang/include/clang/Driver/Options.td:4218-4223 defm openmp_implicit_rpath: BoolFOption<"openmp-implicit-rpath", LangOpts<"OpenMP">, - DefaultTrue, + DefaultFalse, PosFlag, NegFlag, BothFlags<[NoArgumentUnused]>>; -

[PATCH] D144456: [clangd] Publish diagnostics with stale preambles

sammccall added a comment. Looks pretty good. I think we can build the main file & preamble in parallel. Otherwise nits. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:946 +// gurantee eventual consistency. +if (LatestPreamble && Config::current().Diagnostics.All

[PATCH] D144047: [CUDA][SPIRV] Match builtin types and __GCC_ATOMIC_XXX_LOCK_FREE macros on host/device

shangwuyao added a comment. Friendly ping :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144047/new/ https://reviews.llvm.org/D144047 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D144447: [Clang] Teach buildFMulAdd to peek through fneg to find fmul.

kpn added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3738 - assert(!(negMul && negAdd) && "Only one of negMul and negAdd should be set."); - Value *MulOp0 = MulOp->getOperand(0); If I'm reading this right it looks like the assert() wasn'

[PATCH] D144285: [Clang] Implement CWG2518 - static_assert(false)

cor3ntin added inline comments. Comment at: clang/docs/ReleaseNotes.rst:62 directly rather than instantiating the definition from the standard library. +- Implemented `CWG2518 `_ which allows ``static_assert(false)`` + not to be ill-formed when its

[clang] 440f45a - [NFC][clang][Modules] Refine test checks by adding `:`

Author: Mariya Podchishchaeva Date: 2023-02-21T10:16:05-05:00 New Revision: 440f45acff1c3df482cdfc8029a9d2eff3edd9f8 URL: https://github.com/llvm/llvm-project/commit/440f45acff1c3df482cdfc8029a9d2eff3edd9f8 DIFF: https://github.com/llvm/llvm-project/commit/440f45acff1c3df482cdfc8029a9d2eff3edd9

[PATCH] D143734: [NFC][clang][Modules] Refine test checks by adding `:`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG440f45acff1c: [NFC][clang][Modules] Refine test checks by adding `:` (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D144334: [Clang] Add C++2b attribute [[assume(expression)]]

erichkeane added a comment. So one thing to note here: I'm on the fence as to whether we want to implement this feature at all. As was discussed extensively during the EWG meetings on this: multiple implementers are against this attribute for a variety of reasons, and at least 1 other implemen

[PATCH] D144482: [clang][docs] Document ThinLTO options for ld64.lld

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm with one additional stale comment fix needed. Comment at: clang/docs/ThinLTO.rst:157 pruning. Cache pruning is supported with gold, ld64 and ELF and COFF lld, but

[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I don't have a great idea of this section of code, but as code-owner I guess I'm stuck approving/disapproving of this :) Barring additional information, I think I have to accept this

[PATCH] D143233: [Clang][CodeGen] Fix this argument type for certain destructors

jacobly added a comment. I was hoping @rnk was available for review, but otherwise this is ready to land and I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143233/new/ https://reviews.llvm.org/D143233 __

[PATCH] D141950: [NFC] Use find_last_of when seraching for code in getRawCommentForDeclNoCacheImpl

kuganv added a comment. In D141950#4141455 , @aaron.ballman wrote: > LGTM! You should probably put "NFC" into the patch title when landing the > changes though, so it's more clear as to why there's no test coverage. > > Do you think this warrants adding

[PATCH] D144495: [NFC][clang] Refine tests by adding `:` to checks

Fznamznon created this revision. Herald added a subscriber: arphaman. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The tests can fail if wokring directory where the tests were launched has a `error`

[PATCH] D144047: [CUDA][SPIRV] Match builtin types and __GCC_ATOMIC_XXX_LOCK_FREE macros on host/device

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144047/new/ https://reviews.llvm.org/D144047 ___

[PATCH] D134831: [Clang][Sema] Add -Wcast-function-type-strict

samitolvanen added a comment. In D134831#4137408 , @inglorion wrote: > Is this intended to warn on code that casts a function taking a pointer to > some non-void type to a function that takes a void*? Yes, this is intended to warn if the function types

[PATCH] D143891: [Clang] Adjust triviality computation in QualType::isTrivialType to C++20 cases.

cor3ntin added a comment. This makes sense to me as is. The check `ClassDecl->hasTrivialDefaultConstructor() && !ClassDecl->hasNonTrivialDefaultConstructor()` can only be different from status quo in C++20. Changing `isTrivial` would be a lot more involved change that should not be in scope of

[clang] d604c57 - [NFC] Use find_last_of when seraching for code in getRawCommentForDeclNoCacheImpl

Author: Kugan Vivekanandarajah Date: 2023-02-21T16:25:46Z New Revision: d604c57164ecdb3084c8d00f9575158fddc30f81 URL: https://github.com/llvm/llvm-project/commit/d604c57164ecdb3084c8d00f9575158fddc30f81 DIFF: https://github.com/llvm/llvm-project/commit/d604c57164ecdb3084c8d00f9575158fddc30f81.d

[PATCH] D141950: [NFC] Use find_last_of when seraching for code in getRawCommentForDeclNoCacheImpl

This revision was automatically updated to reflect the committed changes. Closed by commit rGd604c57164ec: [NFC] Use find_last_of when seraching for code in… (authored by kuganv, committed by ivanmurashko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D144497: [clang][doc] Removes obsolete comment.

Mordante created this revision. Mordante added a reviewer: ChuanqiXu. Herald added a project: All. Mordante requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After reading about the documentation improvements on LLVM weekly this part seems ob

[PATCH] D135495: [clang-tidy] handle exceptions properly `ExceptionAnalyzer`

isuckatcs marked an inline comment as done. isuckatcs added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:84 + +QualType getPointeeOrArrayElementQualType(QualType T) { + if (T->isAnyPointerType()) xazax.hun wrote: > What a

[PATCH] D144497: [clang][doc] Removes obsolete comment.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. Sorry. My bad for forgetting this. Thank you very much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144497/new/ https://reviews.llvm.org

[PATCH] D144495: [NFC][clang] Refine tests by adding `:` to checks

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. LGTM. The vfsroot-include.c is a -cc1 invocation, so it could probably be switched to use `-verify` instead of FileCheck'ing the output, unless there's something I'm missing. But th

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

tstellar added a comment. FWIW, I'm in favor of this patch. System directory rpaths (e.g. /usr/lib64) are not allowed in Fedora Linux. The current default makes building packages with clang+openmp more difficult. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[clang] b0bf3e6 - [clang][docs] Document ThinLTO options for ld64.lld

Author: Jez Ng Date: 2023-02-21T12:09:27-05:00 New Revision: b0bf3e66d0878099ceebd916645c4cee320116cb URL: https://github.com/llvm/llvm-project/commit/b0bf3e66d0878099ceebd916645c4cee320116cb DIFF: https://github.com/llvm/llvm-project/commit/b0bf3e66d0878099ceebd916645c4cee320116cb.diff LOG: [

[PATCH] D144482: [clang][docs] Document ThinLTO options for ld64.lld

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. int3 marked an inline comment as done. Closed by commit rGb0bf3e66d087: [clang][docs] Document ThinLTO options for ld64.lld (authored by int3). Changed prior to commit

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

JonChesterfield added a comment. I don't mind hugely what mechanism is used but would really like clang++ -fopenmp foo.cpp to build a program that runs. How can we preserve that 'works' feature without setting rpath on the binary? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D143301: [flang] Handle unsupported warning flags

awarzynski added inline comments. Comment at: clang/include/clang/Driver/Options.td:5045 +// Unsupported flang W options +defm : FlangIgnoredDiagOpt<"extra">; The name of the sub-project is "Flang", the sub-dir is "flang" and the driver name is "flang-new". Wh

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

steakhal added a comment. I haven't checked the implementation, but fundamentally patching the TaintBugVisitor is not how we should improve the diagnostic for taint issues. I saw that this patch is not about NoteTags, so I didn't go any further that point. What we should do instead, to add a fa

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

tstellar added a comment. In D143306#4142023 , @JonChesterfield wrote: > I don't mind hugely what mechanism is used but would really like clang++ > -fopenmp foo.cpp to build a program that runs. How can we preserve that > 'works' feature without settin

[PATCH] D144334: [Clang] Add C++2b attribute [[assume(expression)]]

tahonermann added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1448 +def Assume : StmtAttr { + let Spellings = [CXX11<"", "assume", 202302>]; + let Documentation = [AssumeDocs]; philnik wrote: > Izaron wrote: > > Honestly I don't have a clue w

[clang] 8cda128 - [clang]Fix warning for signed conversion on LP64

Author: Yaxun (Sam) Liu Date: 2023-02-21T12:43:42-05:00 New Revision: 8cda128c1eff8556505ff27117a68ad8cecaa228 URL: https://github.com/llvm/llvm-project/commit/8cda128c1eff8556505ff27117a68ad8cecaa228 DIFF: https://github.com/llvm/llvm-project/commit/8cda128c1eff8556505ff27117a68ad8cecaa228.dif

[PATCH] D144011: [clang]Fix warning for signed conversion on LP64

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG8cda128c1eff: [clang]Fix warning for signed conversion on LP64 (authored by yaxunl). Herald added a project:

[PATCH] D144334: [Clang] Add C++2b attribute [[assume(expression)]]

philnik added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1448 +def Assume : StmtAttr { + let Spellings = [CXX11<"", "assume", 202302>]; + let Documentation = [AssumeDocs]; tahonermann wrote: > philnik wrote: > > Izaron wrote: > > > Honestly

[PATCH] D134831: [Clang][Sema] Add -Wcast-function-type-strict

inglorion added a comment. Thanks for the reply! FWIW, this warning is triggered by code which uses glib, which contains a number of function(some_type*) to function(void*) casts, for example here: https://github.com/GNOME/glib/blob/339aaa3719757614af61f427b66a46893e6dc760/glib/glib-autocleanup

[PATCH] D144505: [Clang] Add options in LTO mode when cross compiling for AMDGPU

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, arsenm, yaxunl, JonChesterfield, tianshilei1992. Herald added subscribers: kosarev, kerbowa, inglorion, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscr

[PATCH] D144444: [PowerPC] Use member function to determine PowerPC Secure PLT

MaskRay accepted this revision. MaskRay added a comment. `isPPC32SecurePlt` is probably more accurate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14/new/ https://reviews.llvm.org/D14 ___ cfe-c

[PATCH] D134831: [Clang][Sema] Add -Wcast-function-type-strict

aaron.ballman added a comment. In D134831#4141842 , @samitolvanen wrote: > In D134831#4137408 , @inglorion > wrote: > >> Is this intended to warn on code that casts a function taking a pointer to >> some non-vo

[PATCH] D144444: [PowerPC] Use member function to determine PowerPC Secure PLT

dim added a comment. In D14#4142146 , @MaskRay wrote: > `isPPC32SecurePlt` is probably more accurate. I agree, good catch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14/new/ https://reviews.llv

[PATCH] D143233: [Clang][CodeGen] Fix this argument type for certain destructors

efriedma added a comment. How do you want to be listed as author in the git commit (Name )? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143233/new/ https://reviews.llvm.org/D143233 ___ cfe-commits mail

[PATCH] D144444: [PowerPC] Use member function to determine PowerPC Secure PLT

brad updated this revision to Diff 499222. brad added a comment. rename function and clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14/new/ https://reviews.llvm.org/D14 Files: clang/lib/Driver/ToolChains/Arch/PPC.cpp llvm/

[PATCH] D144454: Add builtin for llvm set rounding

andrew.w.kaylor accepted this revision. andrew.w.kaylor added a comment. This revision is now accepted and ready to land. This looks good to me. I'm adding @rjmccall as a reviewer to make sure someone with front end expertise sees this. There seems to be a potential type mismatch between the int

[PATCH] D143142: [clang][lex] Enable Lexer to grow its buffer

aaron.ballman added a comment. In general, I think this makes sense. However: > This change solves this issue nicely. Since we will be only adding code at > the back of the buffer, the offsets are always constant even if we grow the > buffer many times and all the access to new buffer will be v

[PATCH] D144456: [clangd] Publish diagnostics with stale preambles

kadircet updated this revision to Diff 499224. kadircet marked 7 inline comments as done. kadircet added a comment. - Notify preamble peer before building an AST, to concurrently build fresh preamble & AST. - Refactoring for tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144444: [PowerPC] Use member function to determine PowerPC Secure PLT

dim accepted this revision. dim added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14/new/ https://reviews.llvm.org/D14 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D144454: Add builtin for llvm set rounding

rjmccall added a comment. New builtins should be documented in the user manual. There are standard pragmas for changing the rounding mode, right? What's the interaction between the ability to set this dynamically with a builtin call and those pragmas? Comment at: clang/test

[PATCH] D135495: [clang-tidy] handle exceptions properly `ExceptionAnalyzer`

isuckatcs updated this revision to Diff 499234. isuckatcs marked an inline comment as done. isuckatcs added a comment. Addressed comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/new/ https://reviews.llvm.org/D135495 Files: clang-tools-extra/clang-tidy/utils/ExceptionAnal

[PATCH] D135495: [clang-tidy] handle exceptions properly `ExceptionAnalyzer`

isuckatcs added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:66 + CXXBasePath &) { +if (BS->getType()->getAsCXXRecordDecl() == BaseClass && +BS->getAccessSpecifier() == AS_public) {

[PATCH] D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations

Michael137 added a comment. We thought a bit about what it would take to link a constructor declaration DIE to the various definitions (e.g., via a `DW_AT_LLVM_complete_ctor_linkage_name` or `DW_AT_LLVM_complete_ctor_ref`). The issue with this is that it would mess with type uniquing. E.g., wha

[PATCH] D144431: [clang-tidy] Fix readability-identifer-naming Hungarian CString options

amurzeau updated this revision to Diff 499235. amurzeau edited the summary of this revision. amurzeau added a comment. Remove test changes, I will make a different patch for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144431/new/ https://re

[PATCH] D141757: [clangd] allow extracting to variable for complete lambda expressions

5chmidti added a comment. You're right, I'll incorporate the logic for lambdas into `FindDeclRefsVisitor` and change the docs/comments/commit message to reflect this. I will try to think of more edge cases to test as well. Though I'll be busy until mid march with uni, so there will be no new re

[PATCH] D143233: [Clang][CodeGen] Fix this argument type for certain destructors

jacobly added a comment. Jacob Young Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143233/new/ https://reviews.llvm.org/D143233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Headers.cpp:303 + llvm::SmallVector Includes; + auto It = MainFileIncludesBySpelling.find(Spelling); + if (It == MainFileIncludesBySpelling.end()) nit: ``` llvm::SmallVector Includes; for (au

[PATCH] D144431: [clang-tidy] Fix readability-identifer-naming Hungarian CString options

amurzeau updated this revision to Diff 499239. amurzeau added a comment. Add a release note for this fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144431/new/ https://reviews.llvm.org/D144431 Files: clang-tools-extra/clang-tidy/readability/

[PATCH] D142569: [OpenMP] Introduce kernel environment

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:3917 + + Twine DynamicEnvironmenttName = KernelName + "_dynamic_environment"; + Constant *DynamicEnvironmentI

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:4218-4223 defm openmp_implicit_rpath: BoolFOption<"openmp-implicit-rpath", LangOpts<"OpenMP">, - DefaultTrue, + DefaultFalse, PosFlag, NegFlag, BothFlags<[NoArgumentUnused]>>;

[PATCH] D143670: Stop claiming we support [[carries_dependency]]

aaron.ballman marked an inline comment as done. aaron.ballman added a comment. In D143670#4133677 , @rsmith wrote: > Until or unless a C++ DR permits us to define > `__has_cpp_attribute(carries_dependency)` to any value other than `200809L`, > we have a

[PATCH] D144320: [Clang][OpenMP] Update tests using update_cc_test_checks.py

tianshilei1992 updated this revision to Diff 499241. tianshilei1992 added a comment. remove hash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144320/new/ https://reviews.llvm.org/D144320 Files: clang/test/OpenMP/amdgcn_target_codegen.cpp clan

[clang] 2a2c0fd - [Driver][FreeBSD] Correct driver behavior if a triple is provided without a version

Author: Brad Smith Date: 2023-02-21T14:08:26-05:00 New Revision: 2a2c0fd96757871f4e8052624000c208cc574fdf URL: https://github.com/llvm/llvm-project/commit/2a2c0fd96757871f4e8052624000c208cc574fdf DIFF: https://github.com/llvm/llvm-project/commit/2a2c0fd96757871f4e8052624000c208cc574fdf.diff LO

[PATCH] D143670: Stop claiming we support [[carries_dependency]]

erichkeane added a comment. In D143670#4142351 , @aaron.ballman wrote: > In D143670#4133677 , @rsmith wrote: > >> Until or unless a C++ DR permits us to define >> `__has_cpp_attribute(carries_dependency)` to any

[PATCH] D144444: [PowerPC] Use member function to determine PowerPC Secure PLT

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d585c9dd07d: [PowerPC] Use member function to determine PowerPC Secure PLT (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D144341: [Driver][FreeBSD] Correct driver behavior if a triple is provided without a version

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2a2c0fd96757: [Driver][FreeBSD] Correct driver behavior if a triple is provided without a… (authored by brad). Repository: rG LLVM Github Monorepo

[clang] 5d585c9 - [PowerPC] Use member function to determine PowerPC Secure PLT

Author: Brad Smith Date: 2023-02-21T14:08:25-05:00 New Revision: 5d585c9dd07d0df4d450e2b1ba61fb17a5153aac URL: https://github.com/llvm/llvm-project/commit/5d585c9dd07d0df4d450e2b1ba61fb17a5153aac DIFF: https://github.com/llvm/llvm-project/commit/5d585c9dd07d0df4d450e2b1ba61fb17a5153aac.diff LO

[PATCH] D144320: [Clang][OpenMP] Update tests using update_cc_test_checks.py

jdoerfert added a comment. LG, assuming the bots are happy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144320/new/ https://reviews.llvm.org/D144320 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D144510: [clang-tidy] improve readability-identifier-naming hungarian options test

amurzeau created this revision. Herald added a subscriber: xazax.hun. Herald added a project: All. amurzeau requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang-tools-extra. Adjust identifier-naming-hungarian-notation-cfgfile test with ch

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante created this revision. Mordante added reviewers: bollu, tstellar, mehdi_amini, MaskRay, ChuanqiXu, to268, kparzysz, thieta, tschuett, mgorny, stellaraccident, mizvekov, ldionne, jdoerfert, phosek. Herald added subscribers: libc-commits, libcxx-commits, Moerafaat, zero9178, Enna1, bzchee

  1   2   >