[PATCH] D144232: [PowerPC] Correctly use ELFv2 ABI on FreeBSD/powerpc64

pkubaj updated this revision to Diff 498185. pkubaj added a comment. Fix indenting according to clang-format suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144232/new/ https://reviews.llvm.org/D144232 Files: clang/lib/Basic/Targets/P

[PATCH] D143680: [WIP][-Wunsafe-buffer-usage] Improve fix-its for local variable declarations with null pointer initializers

ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1034-1035 +assert(!InitFixIts.empty() && + "Expected at least one fix-it for an initializer of an unsafe " + "variable declaration."); // The loc right before the

[PATCH] D142822: [clang] ASTImporter: Fix importing of va_list types and declarations

vabridgers added a comment. @donat.nagy , regarding the namespace leaking, there was a change -> https://reviews.llvm.org/D116774 that modified the behavior for aarch64 and arm. While not incorrect, it may offer some historical view or examples of how to address the current cases. @whisperity

[PATCH] D144216: [clang-tidy] Extract string header from redundant-string-cstr checker

Eugene.Zelenko added a comment. May be you could use heard in other test in same patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144216/new/ https://reviews.llvm.org/D144216 ___ cfe-commits mailing

[PATCH] D143670: Stop claiming we support [[carries_dependency]]

rsmith added a comment. Until or unless a C++ DR permits us to define `__has_cpp_attribute(carries_dependency)` to any value other than `200809L`, we have a conformance requirement to macro-expand this to that value. CWG2695 only adds a note, so it changes nothing in this regard. Similarly, we

[PATCH] D142822: [clang] ASTImporter: Fix importing of va_list types and declarations

jrtc27 added inline comments. Comment at: clang/test/AST/ast-dump-overloaded-operators.cpp:27 // CHECK-NEXT: | `-ParmVarDecl {{.*}} col:19{{( imported)?}} 'E' -// CHECK-NEXT: `-FunctionDecl {{.*}} line:14:6{{( imported)?}} test 'void ()' +// CHECK-NEXT: -FunctionDecl {{.*}}

[PATCH] D144003: [clang][analyzer] Improve bug reports of StdLibraryFunctionsChecker.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks like a massive improvement. Yes, the warning text traditionally focuses on what exactly is wrong. Describing why it's wrong is important as well, but usually less important. We're making an ex

[PATCH] D143704: [Flang] Part one of Feature List action

elmcdonough added a comment. Thank you all for your feedback. We're putting the second part off for now and I'm going to retool this as a plugin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704

[clang] e073de8 - [WebAssembly] Update wasm.c with update_cc_test_checks.py. NFC

Author: Jun Ma Date: 2023-02-17T09:17:47+08:00 New Revision: e073de833671159f89d72a1018d335cc042d URL: https://github.com/llvm/llvm-project/commit/e073de833671159f89d72a1018d335cc042d DIFF: https://github.com/llvm/llvm-project/commit/e073de833671159f89d72a1018d335cc042d.diff LOG: [

[clang] f253bb6 - [WebAssembly] Fix simd bit shift intrinsics codegen

Author: Jun Ma Date: 2023-02-17T09:17:47+08:00 New Revision: f253bb640d97756d2808bb7c7b2bb31b1090a654 URL: https://github.com/llvm/llvm-project/commit/f253bb640d97756d2808bb7c7b2bb31b1090a654 DIFF: https://github.com/llvm/llvm-project/commit/f253bb640d97756d2808bb7c7b2bb31b1090a654.diff LOG: [

[PATCH] D144169: [WebAssembly] Fix simd bit shift intrinsics codegen

This revision was automatically updated to reflect the committed changes. Closed by commit rGf253bb640d97: [WebAssembly] Fix simd bit shift intrinsics codegen (authored by junparser). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144169/new/ https:/

[PATCH] D137113: [Clang] refactor CodeGenFunction::EmitAsmStmt NFC

nickdesaulniers updated this revision to Diff 498209. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - fix bugprone-argument-comment as per @shafik Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137113/new/ https:

[PATCH] D144188: Tighten up a modules test

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144188/new/ https://reviews.llvm.org/D144188 ___ cfe-commits mailing lis

[PATCH] D143919: [Clang] Copy strictfp attribute from pattern to instantiation

efriedma added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:824 + continue; +} + sepavloff wrote: > efriedma wrote: > > Is this necessary? The non-delayed-parsed case seems to work correctly on > > trunk without any chang

[clang] b1bc723 - [Clang] refactor CodeGenFunction::EmitAsmStmt NFC

Author: Nick Desaulniers Date: 2023-02-16T17:58:34-08:00 New Revision: b1bc723dfe9734a8b3157dbf50328b5d62436bd6 URL: https://github.com/llvm/llvm-project/commit/b1bc723dfe9734a8b3157dbf50328b5d62436bd6 DIFF: https://github.com/llvm/llvm-project/commit/b1bc723dfe9734a8b3157dbf50328b5d62436bd6.di

[clang] 329ef60 - [Clang] support for outputs along indirect edges of asm goto

Author: Nick Desaulniers Date: 2023-02-16T17:58:34-08:00 New Revision: 329ef60f3e21fd6845e8e8b0da405cae7eb27267 URL: https://github.com/llvm/llvm-project/commit/329ef60f3e21fd6845e8e8b0da405cae7eb27267 DIFF: https://github.com/llvm/llvm-project/commit/329ef60f3e21fd6845e8e8b0da405cae7eb27267.di

[clang] 54186d3 - [clang] add __has_extension(gnu_asm_goto_with_outputs_full)

Author: Nick Desaulniers Date: 2023-02-16T17:58:35-08:00 New Revision: 54186d33c3a0d4834d2e5f95640b63677f5b5142 URL: https://github.com/llvm/llvm-project/commit/54186d33c3a0d4834d2e5f95640b63677f5b5142 DIFF: https://github.com/llvm/llvm-project/commit/54186d33c3a0d4834d2e5f95640b63677f5b5142.di

[clang] af66563 - [clang] fix -Wuninitialized for asm goto outputs on indirect edges.

Author: Nick Desaulniers Date: 2023-02-16T17:58:35-08:00 New Revision: af6656338db365fde6c0b0e53db8f98aa8ed59d4 URL: https://github.com/llvm/llvm-project/commit/af6656338db365fde6c0b0e53db8f98aa8ed59d4 DIFF: https://github.com/llvm/llvm-project/commit/af6656338db365fde6c0b0e53db8f98aa8ed59d4.di

[PATCH] D137113: [Clang] refactor CodeGenFunction::EmitAsmStmt NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1bc723dfe97: [Clang] refactor CodeGenFunction::EmitAsmStmt NFC (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

This revision was automatically updated to reflect the committed changes. Closed by commit rG329ef60f3e21: [Clang] support for outputs along indirect edges of asm goto (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13649

[PATCH] D143205: [clang] add __has_extension(gnu_asm_goto_with_outputs_full)

This revision was automatically updated to reflect the committed changes. Closed by commit rG54186d33c3a0: [clang] add __has_extension(gnu_asm_goto_with_outputs_full) (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143205

[PATCH] D140508: [clang] fix -Wuninitialized for asm goto outputs on indirect edges.

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf6656338db3: [clang] fix -Wuninitialized for asm goto outputs on indirect edges. (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

efriedma accepted this revision. efriedma added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139741/new/ https://reviews.llvm.org/D139741 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

ahatanak added a subscriber: aeubanks. ahatanak added inline comments. Comment at: clang/lib/CodeGen/Address.h:67 return; -// Currently the max supported alignment is much less than 1 << 63 and is +// Currently the max supported alignment is much less than 1 << 32

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

ahatanak added inline comments. Comment at: clang/lib/CodeGen/Address.h:67 return; -// Currently the max supported alignment is much less than 1 << 63 and is +// Currently the max supported alignment is much less than 1 << 32 and is // guaranteed to be a power

[PATCH] D141194: [clang][Interp] Implement bitcasts

shafik added a comment. I think `VisitCastExpr` is the right place to start looking for what to do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141194/new/ https://reviews.llvm.org/D141194 ___ cfe-comm

[PATCH] D144016: [Sema] Relax a failing assertion in TransformBlockExpr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcda4a0e918b5: [Sema] Relax a failing assertion in TransformBlockExpr (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D14

[clang] cda4a0e - [Sema] Relax a failing assertion in TransformBlockExpr

Author: Akira Hatanaka Date: 2023-02-16T18:40:26-08:00 New Revision: cda4a0e918b591be9ae0732f7df07678efb75047 URL: https://github.com/llvm/llvm-project/commit/cda4a0e918b591be9ae0732f7df07678efb75047 DIFF: https://github.com/llvm/llvm-project/commit/cda4a0e918b591be9ae0732f7df07678efb75047.diff

[PATCH] D141591: [clang][Interp] Properly identify not-yet-defined functions

shafik added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1486 bool IsBeingCompiled = Func && !Func->isFullyCompiled(); - bool WasNotDefined = Func && !Func->hasBody(); + bool WasNotDefined = Func && !Func->isConstexpr() && !Func->hasBody(); --

[PATCH] D144232: [PowerPC] Correctly use ELFv2 ABI on FreeBSD/powerpc64

adalava added a comment. Nice catch! I'm not a LLVM maintainer but from FreeBSD PowerPC side I agree with the changes, only added two suggestions that could improve code readability Comment at: clang/lib/Basic/Targets/PPC.h:428 ABI = "elfv2"; +} else if (Triple.isO

[PATCH] D136751: [clang][Interp] This pointers are writable in constructors

shafik added inline comments. Comment at: clang/lib/AST/Interp/Interp.cpp:264-270 + const Function *Func = S.Current->getFunction(); + if (Func && Func->isConstructor()) { +// The This pointer is writable in constructors, even if +// isConst() returns true. +if (Ptr

[PATCH] D136751: [clang][Interp] This pointers are writable in constructors

shafik added inline comments. Comment at: clang/lib/AST/Interp/Interp.cpp:264-270 + const Function *Func = S.Current->getFunction(); + if (Func && Func->isConstructor()) { +// The This pointer is writable in constructors, even if +// isConst() returns true. +if (Ptr

[clang] b05dc1b - [clang-format] Add a space between an overloaded operator and '>'

Author: Owen Pan Date: 2023-02-16T20:25:39-08:00 New Revision: b05dc1b8766a47482cae432011fd2faa04c83a3e URL: https://github.com/llvm/llvm-project/commit/b05dc1b8766a47482cae432011fd2faa04c83a3e DIFF: https://github.com/llvm/llvm-project/commit/b05dc1b8766a47482cae432011fd2faa04c83a3e.diff LOG:

[PATCH] D143755: [clang-format] Add a space between an overloaded operator and '>'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb05dc1b8766a: [clang-format] Add a space between an overloaded operator and '>' (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter added a comment. poke - anyone mind reviewing this? I used this tool to fix two small cases of missing move in the llvm project: https://reviews.llvm.org/D142824 https://reviews.llvm.org/D142825 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D143919: [Clang] Copy strictfp attribute from pattern to instantiation

sepavloff updated this revision to Diff 498248. sepavloff added a comment. Remove copying StrictFPAttr from InstantiateAttrs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143919/new/ https://reviews.llvm.org/D143919 Files: clang/include/clang/Se

[PATCH] D143919: [Clang] Copy strictfp attribute from pattern to instantiation

sepavloff added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:824 + continue; +} + efriedma wrote: > sepavloff wrote: > > efriedma wrote: > > > Is this necessary? The non-delayed-parsed case seems to work correctly > > > o

[PATCH] D144157: Add 128-bit integer support to enum element

MaskRay added a comment. We also need a codegen test. `clang/test/CodeGen/enum2.c` may be a good one. It tests that debug information is correct as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144157/new/ https://reviews.llvm.org/D144157

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

pengfei added inline comments. Comment at: llvm/docs/LangRef.rst:2166 + +If the mode is ``"dynamic"``, the behavior is derived from the +dynamic state of the floating-point environment. Transformations 1. Does it mean users must specify `dynamic` when the

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

4vtomat updated this revision to Diff 498253. 4vtomat marked 2 inline comments as done. 4vtomat added a comment. Update to v20230206 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141672/new/ https://reviews.llvm.org/D141672 Files: clang/test/Pre

[PATCH] D136751: [clang][Interp] This pointers are writable in constructors

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.cpp:264-270 + const Function *Func = S.Current->getFunction(); + if (Func && Func->isConstructor()) { +// The This pointer is writable in constructors, even if +// isConst() returns true. +if (Pt

<    1   2