[PATCH] D143301: Emit warning for unsupported gfortran flags

jdoerfert added a comment. In D143301#4126712 , @awarzynski wrote: >> I think the -W stuff can go in, it has tests and is reasonable. > > I'd like for us to rely on a flag from Options.td for this instead. Something > similar to clang_ignored_f_Group >

[PATCH] D142507: [AMDGPU] Split dot7 feature

aaronmondal added a comment. > It shall be complimented by the device-lib change in the corresponding > release, so it is not that simple. @rampitec I'm not sure I understand. Does this mean that this is breaking in a way that Clang 17 won't be able to build ROCm 5.4? I thought it was like "we

[PATCH] D143665: [Clang][RISCV] Guard vector int64, float32, float64 with semantic analysis

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143665/new/ https://reviews.llvm.org/D143665 ___

[PATCH] D143691: Fix clang-formats IncludeCategory to match the documentation

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:1379 LLVMStyle.IncludeStyle.IncludeCategories = { - {"^\"(llvm|llvm-c|clang|clang-c)/", 2, 0, false}, - {"^(<|\"(gtest|gmock|isl|json)/)", 3, 0, false}, - {".*", 1, 0, false}}; +

[PATCH] D143870: [clang-format] Remove all include duplicates not only those in the same block

HazardyKnusperkeks added a comment. In D143870#4124057 , @Febbe wrote: > @HazardyKnusperkeks thank you for the review, I would add another option, but > I don't know a good name. I would propose a > > `boolean` `IncludeDeduplicateInAllBlocks` which defau

[PATCH] D143301: Emit warning for unsupported gfortran flags

elmcdonough added a comment. Thanks for the feedback everyone. This is my current understanding on what I should do: I am to rename gfortran_unsupported_Group to flang_ignored_w_Group and move the non W group gfortran options into another patch. I have these changes locally and am currently b

[PATCH] D143301: Emit warning for unsupported gfortran flags

awarzynski added a comment. In D143301#4126855 , @jdoerfert wrote: > In D143301#4126712 , @awarzynski > wrote: > >>> I think the -W stuff can go in, it has tests and is reasonable. >> >> I'd like for us to rely o

[PATCH] D143301: Emit warning for unsupported gfortran flags

awarzynski added a comment. In D143301#4126884 , @elmcdonough wrote: > Thanks for the feedback everyone. This is my current understanding on what I > should do: I am to rename gfortran_unsupported_Group to flang_ignored_w_Group > and move the non W gr

[PATCH] D144027: [NFC][IR] Make Module::getGlobalList() private

vporpo updated this revision to Diff 497403. vporpo added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144027/new/ https://reviews.llvm.org/D144027 Files: clang/lib/CodeGen/CGHLSLRuntime.cpp clang/lib/CodeGen/CGObjCMac.cpp

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

asb added a comment. I've posted RFC: Resolving issues related to extension versioning in RISC-V which discusses some related issues (I think it complements this patch, rather than anything being

[PATCH] D143301: [flang] Handle unsupported warning flags

elmcdonough updated this revision to Diff 497405. elmcdonough retitled this revision from "Emit warning for unsupported gfortran flags" to "[flang] Handle unsupported warning flags". elmcdonough edited the summary of this revision. Herald added a subscriber: sunshaoce. Repository: rG LLVM Githu

[PATCH] D144037: [clang-tidy] allow tests to use -config-file instead of -config

amurzeau created this revision. amurzeau added reviewers: njames93, alexfh, kazu, dougpuob. Herald added a subscriber: xazax.hun. Herald added a project: All. amurzeau requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The previous

Re: [clang] d05e1e9 - [clang][test][RISCV] Check for __riscv_i in riscv-target-features.c

How does this interact with the CHECK-NOTs above it. Does it check that they don't appear before the __riscv_i but would be allowed after it? ~Craig On Tue, Feb 14, 2023 at 9:03 AM Alex Bradbury via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Alex Bradbury > Date: 2023-02-14T17

[PATCH] D142604: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM but please add a release note for the fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142604/new/ https://reviews.llvm.org/D142604 ___ cfe-commits mailing list cfe-c

[PATCH] D142604: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

aaron.ballman added subscribers: Mordante, ldionne. aaron.ballman added a comment. I don't think the libc++ precommit CI failures are related to this change and so I don't think they block anything, but it'd be nice if a libc++ person could verify (CC @ldionne @Mordante ) CHANGES SINCE LAST AC

[PATCH] D143301: [flang] Handle unsupported warning flags

awarzynski added a comment. Thanks for the update! One thing that's not clear to me - how come "-Wextra" **is not** treated as an error and "-Wblah" **is**? That's not clear from the code. I'm also realising that I incorrectly assumed that `-Wextra` was defined in Options.td. Instead, it's def

[PATCH] D142507: [AMDGPU] Split dot7 feature

rampitec added a comment. In D142507#4126864 , @aaronmondal wrote: >> It shall be complimented by the device-lib change in the corresponding >> release, so it is not that simple. > > @rampitec I'm not sure I understand. Does this mean that this is break

Re: [clang] d05e1e9 - [clang][test][RISCV] Check for __riscv_i in riscv-target-features.c

On 2023-02-14 19:56, Craig Topper wrote: > How does this interact with the CHECK-NOTs above it. Does it check > that they don't appear before the __riscv_i but would be allowed after > it? Thanks for the post-commit review. I think you're right. It looks like the easiest fix is probably move the

[PATCH] D143070: [clang-format] Enable FormatTokenSource to insert tokens.

klimek updated this revision to Diff 497415. klimek marked 3 inline comments as done. klimek added a comment. Address reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143070/new/ https://reviews.llvm.org/D143070 Files: clang/lib/

[PATCH] D143070: [clang-format] Enable FormatTokenSource to insert tokens.

klimek added inline comments. Comment at: clang/lib/Format/FormatTokenSource.h:74 public: - IndexedTokenSource(ArrayRef Tokens) + IndexedTokenSource(SmallVectorImpl &Tokens) : Tokens(Tokens), Position(-1) {} sammccall wrote: > As I understand it, this p

Re: [clang] d05e1e9 - [clang][test][RISCV] Check for __riscv_i in riscv-target-features.c

I don't have a better idea. ~Craig On Tue, Feb 14, 2023 at 12:32 PM Alex Bradbury wrote: > On 2023-02-14 19:56, Craig Topper wrote: > > How does this interact with the CHECK-NOTs above it. Does it check > > that they don't appear before the __riscv_i but would be allowed after > > it? > > Than

[PATCH] D143070: [clang-format] Enable FormatTokenSource to insert tokens.

klimek updated this revision to Diff 497416. klimek added a comment. Undo changes to ownership of initial set of FormatTokens. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143070/new/ https://reviews.llvm.org/D143070 Files: clang/lib/Format/For

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/CodeGen/Address.h:67 return; -// Currently the max supported alignment is much less than 1 << 63 and is +// Currently the max su

[clang] ddb7042 - [clang][test][RISCV] Introduce separate RUN lines for __risv_i test in riscv-target-features.c

Author: Alex Bradbury Date: 2023-02-14T21:06:44Z New Revision: ddb704247b16002d916bba67e3aa9f54fd4bbace URL: https://github.com/llvm/llvm-project/commit/ddb704247b16002d916bba67e3aa9f54fd4bbace DIFF: https://github.com/llvm/llvm-project/commit/ddb704247b16002d916bba67e3aa9f54fd4bbace.diff LOG:

[PATCH] D141808: [Driver] Add --vfsoverlay flag

haowei added a comment. I am seeing test failures on pre submit Windows builder after this change was landed: See https://buildkite.com/llvm-project/premerge-checks/builds/135752#01864d34-9024-4c13-9137-88b6f41ec695 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D144041: [clang-tidy] add primitive types for hungarian identifier-naming (unsigned char and void)

amurzeau created this revision. amurzeau added reviewers: njames93, alexfh, kazu, dougpuob. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. amurzeau requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang-tool

[clang] ac835ec - [Fuchsia] Set /winsysroot in Windows runtimes linker flags

Author: Haowei Wu Date: 2023-02-14T13:31:48-08:00 New Revision: ac835ecb5feacdbf3fd9fcfc72fd2972067c26b4 URL: https://github.com/llvm/llvm-project/commit/ac835ecb5feacdbf3fd9fcfc72fd2972067c26b4 DIFF: https://github.com/llvm/llvm-project/commit/ac835ecb5feacdbf3fd9fcfc72fd2972067c26b4.diff LOG

[PATCH] D143960: [Fuchsia] Set /winsysroot in windows runtimes linker flags

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGac835ecb5fea: [Fuchsia] Set /winsysroot in Windows runtimes linker flags (authored by haowei). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D142507: [AMDGPU] Split dot7 feature

aaronmondal added a comment. Well, I can already feel the pain that distro maintainers having to build the next ROCm releases 😅 I wonder what the better course of action is here: 1. Port this patch to Clang 16 so that users with new hardware will be able to build ROCm 5.5, but make it impossib

[PATCH] D144037: [clang-tidy] allow tests to use -config-file instead of -config

ClockMan added inline comments. Comment at: clang-tools-extra/test/clang-tidy/check_clang_tidy.py:111 if not any( -[arg.startswith('-config=') for arg in self.clang_tidy_extra_args]): +[arg.startswith('-config=') or arg.startswith('-config-file=') for arg in

[PATCH] D142507: [AMDGPU] Split dot7 feature

rampitec added a comment. In D142507#4127167 , @aaronmondal wrote: > Well, I can already feel the pain that distro maintainers having to build the > next ROCm releases 😅 > > I wonder what the better course of action is here: > > 1. Port this patch to Cl

[PATCH] D144047: [CUDA][SPIRV] Match builtin types and __GCC_ATOMIC_XXX_LOCK_FREE macros on host/device

shangwuyao created this revision. shangwuyao added reviewers: jlebar, tra, yaxunl. Herald added subscribers: mattd, carlosgalvezp, ThomasRaoux. Herald added a project: All. shangwuyao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This cha

[PATCH] D142507: [AMDGPU] Split dot7 feature

aaronmondal added a comment. > I cannot say there was much choice. The only real choice was to postpone the > split and magnify the problem in the future. As for the ifdefs, this might be > possible in the device-libs but I do not see how to do it the Builtins.def. Hmm maybe ifdefs in the devic

[libunwind] 33d0d1e - [runtimes] Rename newconfig.py to config.py -- it's not new anymore

Author: Louis Dionne Date: 2023-02-14T17:21:34-05:00 New Revision: 33d0d1e36ffac3ff7fb29e5f8e34a6b6957ad8e9 URL: https://github.com/llvm/llvm-project/commit/33d0d1e36ffac3ff7fb29e5f8e34a6b6957ad8e9 DIFF: https://github.com/llvm/llvm-project/commit/33d0d1e36ffac3ff7fb29e5f8e34a6b6957ad8e9.diff

[PATCH] D142507: [AMDGPU] Split dot7 feature

rampitec added a comment. In D142507#4127275 , @aaronmondal wrote: >> I cannot say there was much choice. The only real choice was to postpone the >> split and magnify the problem in the future. As for the ifdefs, this might >> be possible in the devic

[clang] ed3e3ee - [NFC][IR] Make Module::getGlobalList() private

Author: Vasileios Porpodas Date: 2023-02-14T14:25:10-08:00 New Revision: ed3e3ee9e30dfbffd2170a770a49b36a7f444916 URL: https://github.com/llvm/llvm-project/commit/ed3e3ee9e30dfbffd2170a770a49b36a7f444916 DIFF: https://github.com/llvm/llvm-project/commit/ed3e3ee9e30dfbffd2170a770a49b36a7f444916.

[PATCH] D144027: [NFC][IR] Make Module::getGlobalList() private

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed3e3ee9e30d: [NFC][IR] Make Module::getGlobalList() private (authored by vporpo). Changed prior to commit: https://reviews.llvm.org/D144027?vs=49

[clang] b4243bb - [clang-format] Don't rewrite the input file if already formatted

Author: Owen Pan Date: 2023-02-14T14:27:53-08:00 New Revision: b4243bb611a30137f3f1a7f0e531f91d331ab4be URL: https://github.com/llvm/llvm-project/commit/b4243bb611a30137f3f1a7f0e531f91d331ab4be DIFF: https://github.com/llvm/llvm-project/commit/b4243bb611a30137f3f1a7f0e531f91d331ab4be.diff LOG:

[PATCH] D143831: [clang-format] Don't rewrite the input file if already formatted

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4243bb611a3: [clang-format] Don't rewrite the input file if already formatted (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES

[libunwind] cafb1c1 - [runtimes] Remove duplicate imports of libcxx.test.config

Author: Louis Dionne Date: 2023-02-14T17:28:22-05:00 New Revision: cafb1c1cb24179bdf4361bf510590b4ea4e52135 URL: https://github.com/llvm/llvm-project/commit/cafb1c1cb24179bdf4361bf510590b4ea4e52135 DIFF: https://github.com/llvm/llvm-project/commit/cafb1c1cb24179bdf4361bf510590b4ea4e52135.diff

[clang] cb5f239 - Revert "[NFC][IR] Make Module::getGlobalList() private"

Author: Vasileios Porpodas Date: 2023-02-14T14:29:42-08:00 New Revision: cb5f239363a3c94db5425c105fcd45e77d2a16a9 URL: https://github.com/llvm/llvm-project/commit/cb5f239363a3c94db5425c105fcd45e77d2a16a9 DIFF: https://github.com/llvm/llvm-project/commit/cb5f239363a3c94db5425c105fcd45e77d2a16a9.

[PATCH] D142507: [AMDGPU] Split dot7 feature

aaronmondal added a comment. I think unless conflicts arise creating an issue similar to this https://github.com/llvm/llvm-project/issues/60600 with the `cherry-pick` line set to this commit should be enough. (See also https://llvm.org/docs/GitHub.html). Repository: rG LLVM Github Monorepo

[PATCH] D142507: [AMDGPU] Split dot7 feature

rampitec added a comment. In D142507#4127374 , @aaronmondal wrote: > I think unless conflicts arise creating an issue similar to this > https://github.com/llvm/llvm-project/issues/60600 with the `cherry-pick` line > set to this commit should be enough.

[clang] 823186b - Recommit: [NFC][IR] Make Module::getGlobalList() private

Author: Vasileios Porpodas Date: 2023-02-14T15:12:51-08:00 New Revision: 823186b14dc97c950a808f6f4b434d399da9a220 URL: https://github.com/llvm/llvm-project/commit/823186b14dc97c950a808f6f4b434d399da9a220 DIFF: https://github.com/llvm/llvm-project/commit/823186b14dc97c950a808f6f4b434d399da9a220.

[PATCH] D142507: [AMDGPU] Split dot7 feature

b-sumner added a comment. In D142507#4127382 , @rampitec wrote: > In D142507#4127374 , @aaronmondal > wrote: > >> I think unless conflicts arise creating an issue similar to this >> https://github.com/llvm/llvm-

[PATCH] D142507: [AMDGPU] Split dot7 feature

rampitec added a comment. In D142507#4127421 , @b-sumner wrote: > I have no objection to backporting this, but it may need to be accompanied > with a device-libs patch, and I don't know where that patch would be checked > in. The ROCm-Device-Libs in gi

[PATCH] D144027: [NFC][IR] Make Module::getGlobalList() private

fmayer added a comment. This seems to have broken our buildbot: https://lab.llvm.org/buildbot/#/builders/169/builds/16797/steps/8/logs/stdio CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /b/sanitizer-x86_64-linux-qemu/build/llvm_build0/bin/clang++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_

[PATCH] D144027: [NFC][IR] Make Module::getGlobalList() private

vporpo added a comment. Yeah sorry about that, I reverted it here: b5f239363a3 Revert "[NFC][IR] Make Module::getGlobalList() private" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144027/new/ https://reviews.llvm.org/D144027

[PATCH] D144054: [Lex] Fix a crash in updateConsecutiveMacroArgTokens.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. Fixes https://github.com/llvm/llvm-project/issues/60722. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D144054

[PATCH] D142507: [AMDGPU] Split dot7 feature

b-sumner added a comment. > My current understanding is the c-p will go into already forked clang-16, but > not to rocm 5.4. So rocm device-libs will be accompanied by the older > clang-16 w/o this and stay compatible. Someone building from scratch will use > latest clang-16 and staging devic

[PATCH] D144054: [Lex] Fix a crash in updateConsecutiveMacroArgTokens.

hokein added inline comments. Comment at: clang/test/Lexer/update_consecutive_macro_crash.cpp:8 +void foo() { + X(int{,}); // expected-error {{too many arguments provided to function-like macro invocation}} \ + expected-error {{expected expression}} \ --

[clang] 8704674 - [Driver] Allow test to use lld-link.exe not just lld-link

Author: Alex Brachet Date: 2023-02-14T23:54:25Z New Revision: 87046744e6a8f7b78dffb61c29cbac1e0abd6921 URL: https://github.com/llvm/llvm-project/commit/87046744e6a8f7b78dffb61c29cbac1e0abd6921 DIFF: https://github.com/llvm/llvm-project/commit/87046744e6a8f7b78dffb61c29cbac1e0abd6921.diff LOG:

[PATCH] D144054: [Lex] Fix a crash in updateConsecutiveMacroArgTokens.

shafik added inline comments. Comment at: clang/lib/Lex/TokenLexer.cpp:1023 Partition = All.take_while([&](const Token &T) { - return T.getLocation() >= BeginLoc && T.getLocation() < Limit && - NearLast(T.getLocation()); + // NOTE: the Limit is included

[PATCH] D144058: [clang][deps] Split lookupModuleOutput out of DependencyConsumer NFC

benlangmuir created this revision. benlangmuir added reviewers: jansvoboda11, akyrtzi, steven_wu. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The idea is to split the callbacks that are used to c

[PATCH] D144058: [clang][deps] Split lookupModuleOutput out of DependencyConsumer NFC

jansvoboda11 added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningWorker.h:64-66 +/// Dependency scanner callbacks that are used during scanning to influence the +/// behaviour of the scan - for example, to customize the scanned inv

[PATCH] D144058: [clang][deps] Split lookupModuleOutput out of DependencyConsumer NFC

benlangmuir added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningWorker.h:64-66 +/// Dependency scanner callbacks that are used during scanning to influence the +/// behaviour of the scan - for example, to customize the scanned invo

[clang] 82c6e90 - [Clang][Test] Add llvm-lto, llvm-lto2 and llvm-profdata to the tool substitutions list

Author: Weining Lu Date: 2023-02-15T09:16:14+08:00 New Revision: 82c6e90d6a3d6773372b845a246adfed1682cb65 URL: https://github.com/llvm/llvm-project/commit/82c6e90d6a3d6773372b845a246adfed1682cb65 DIFF: https://github.com/llvm/llvm-project/commit/82c6e90d6a3d6773372b845a246adfed1682cb65.diff LO

[PATCH] D143806: [Clang][Test] Add llvm-lto, llvm-lto2 and llvm-profdata to the tool substitutions list

This revision was automatically updated to reflect the committed changes. Closed by commit rG82c6e90d6a3d: [Clang][Test] Add llvm-lto, llvm-lto2 and llvm-profdata to the tool… (authored by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[clang] 6e794ba - [Clang][RISCV] Guard vector int64, float32, float64 with semantic analysis

Author: eopXD Date: 2023-02-14T17:38:25-08:00 New Revision: 6e794ba0b238832611e649c826b204e680a81e98 URL: https://github.com/llvm/llvm-project/commit/6e794ba0b238832611e649c826b204e680a81e98 DIFF: https://github.com/llvm/llvm-project/commit/6e794ba0b238832611e649c826b204e680a81e98.diff LOG: [C

[PATCH] D143665: [Clang][RISCV] Guard vector int64, float32, float64 with semantic analysis

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e794ba0b238: [Clang][RISCV] Guard vector int64, float32, float64 with semantic analysis (authored by eopXD). Repository: rG LLVM Github Monorepo

[PATCH] D143680: [WIP][-Wunsafe-buffer-usage] Improve fix-its for local variable declarations with null pointer initializers

NoQ added a comment. Looks great! Nitpicks. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:872 + assert(Loc.isValid() && "Expected the source location of the last" + "character of an AST Node is alwasy valid"); + return Loc;

[PATCH] D137526: [C++20] [Modules] [NFC] Add Preprocessor methods for named modules - for ClangScanDeps (1/4)

ChuanqiXu added a comment. In D137526#4125578 , @nikic wrote: > It looks like this causes a minor compile-time regression (about 0.2% on `O0` > builds): > http://llvm-compile-time-tracker.com/compare.php?from=ad81d019a62d33e5d1f232844b83d3e164e4b160&to=

[PATCH] D144064: [WIP][-Wunsafe-buffer-usage] Match unsafe pointers being casted to bool or participating in pointer subtractions

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: jkorous, NoQ, malavikasamak, t-rasmud. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. To add two new unique cases to the Unspecifie

[clang] aef76fe - [clang-format][NFC] Reformat clang/tools/clang-format/fuzzer/

Author: Owen Pan Date: 2023-02-14T18:58:01-08:00 New Revision: aef76fe554ee9426b8915e67ae50cecb8dba2e0e URL: https://github.com/llvm/llvm-project/commit/aef76fe554ee9426b8915e67ae50cecb8dba2e0e DIFF: https://github.com/llvm/llvm-project/commit/aef76fe554ee9426b8915e67ae50cecb8dba2e0e.diff LOG:

[clang] 8d995b2 - [C++20] [Modules] [ClangScanDeps] Ensure that we can mix the use of and clang modules

Author: Chuanqi Xu Date: 2023-02-15T11:00:03+08:00 New Revision: 8d995b26c7559f273809d0d29e5042850e47165a URL: https://github.com/llvm/llvm-project/commit/8d995b26c7559f273809d0d29e5042850e47165a DIFF: https://github.com/llvm/llvm-project/commit/8d995b26c7559f273809d0d29e5042850e47165a.diff LO

[PATCH] D144016: [Sema] Relax a failing assertion in TransformBlockExpr

ahatanak updated this revision to Diff 497530. ahatanak added a comment. Add comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144016/new/ https://reviews.llvm.org/D144016 Files: clang/lib/Sema/TreeTransform.h clang/test/CodeGenCXX/cxx1z-

[PATCH] D141215: [clang-repl][WIP] Implement pretty printing

junaire updated this revision to Diff 497531. junaire added a comment. Herald added a subscriber: mstorsjo. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Interpreter/

[PATCH] D143725: [llvm-objdump][ARM] support --symbolize-operands for ARM/ELF

Esme added a comment. Please include as much context as possible with your diff. https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1145 + // So far only supports ARM/Thumb, PowerPC and X86. +

[clang] 54cf24d - [NFC] Refactor ModuleDeclStateTest to make it not dependent on Frontend

Author: Chuanqi Xu Date: 2023-02-15T11:30:18+08:00 New Revision: 54cf24dc6e6317f7a77f8a320f1fbccc31ea7291 URL: https://github.com/llvm/llvm-project/commit/54cf24dc6e6317f7a77f8a320f1fbccc31ea7291 DIFF: https://github.com/llvm/llvm-project/commit/54cf24dc6e6317f7a77f8a320f1fbccc31ea7291.diff LO

[PATCH] D137526: [C++20] [Modules] [NFC] Add Preprocessor methods for named modules - for ClangScanDeps (1/4)

ChuanqiXu added inline comments. Comment at: clang/unittests/Lex/CMakeLists.txt:21 clangBasic + clangFrontend clangLex ChuanqiXu wrote: > thakis wrote: > > It seems strange layering-wise that the Lex unit tests would depend on > > Frontend. Is there any w

[PATCH] D142569: [OpenMP] Introduce kernel environment

jdoerfert added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:3888 + + Function *Kernel = Builder.GetInsertBlock()->getParent(); Function *Fn = getOrCreateRuntimeFunctionPtr( That is not the kernel, at least not when clang emits a deb

[PATCH] D133863: [RISCV] Add MC support of RISCV zcmt Extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZc.td:135 +def CM_JT : RVInst16CJ<0b101, 0b10, (outs), (ins uimm5:$index), + "cm.jt", "$index">{ + bits<5> index; Indent 1 more space Repository: rG LLVM

[PATCH] D143142: [clang][lex] Enable Lexer to grow its buffer

v.g.vassilev added a comment. We should probably add some tests here. Alternatively we can add the tests from https://reviews.llvm.org/D143148 but that'd make this patch bulkier and probably harder to review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

<    1   2