[PATCH] D143665: [Clang][RISCV] Guard vector int64, float32, float64 with semantic analysis

eopXD updated this revision to Diff 497223. eopXD added a comment. Update code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143665/new/ https://reviews.llvm.org/D143665 Files: clang/include/clang/Basic/RISCVVTypes.def clang/lib/Sema/Sema.cpp

[PATCH] D143665: [Clang][RISCV] Guard vector int64, float32, float64 with semantic analysis

eopXD updated this revision to Diff 497224. eopXD added a comment. Update code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143665/new/ https://reviews.llvm.org/D143665 Files: clang/lib/Sema/Sema.cpp clang/lib/Sema/SemaRISCVVectorLookup.cpp

[PATCH] D143960: [Fuchsia] Set /winsysroot in windows runtimes linker flags

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:91 set(WINDOWS_LINK_FLAGS -/vfsoverlay:${LLVM_VFSOVERLAY} -# TODO: On Windows, linker is invoked

[PATCH] D143906: [include-cleaner] Better support ambiguous std symbols

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/include-cleaner/lib/FindHeaders.cpp:85 +Hints isPublicHeader(const FileEntry *FE, const PragmaIncludes *PI) { + return (PI->isPri

[clang] 46cdf7f - [Tooling][Stdlib][NFC] Reflow comments and strip clang-format pragmas

Author: Kadir Cetinkaya Date: 2023-02-14T09:46:41+01:00 New Revision: 46cdf7f0991280a3601a777a80fbc460196fb033 URL: https://github.com/llvm/llvm-project/commit/46cdf7f0991280a3601a777a80fbc460196fb033 DIFF: https://github.com/llvm/llvm-project/commit/46cdf7f0991280a3601a777a80fbc460196fb033.dif

[PATCH] D143906: [include-cleaner] Better support ambiguous std symbols

hokein updated this revision to Diff 497233. hokein marked 2 inline comments as done. hokein added a comment. handle the case where PI is null. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143906/new/ https://reviews.llvm.org/D143906 Files: cla

[PATCH] D143906: [include-cleaner] Better support ambiguous std symbols

hokein marked an inline comment as done. hokein added a comment. Thanks for the review! Comment at: clang-tools-extra/include-cleaner/lib/FindHeaders.cpp:85 +Hints isPublicHeader(const FileEntry *FE, const PragmaIncludes *PI) { + return (PI->isPrivate(FE) || !PI->isSelfConta

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

sdesmalen added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:332 + # Generate arm_sme.h + clang_generate_header(-gen-arm-sme-header arm_sme.td arm_sme.h) # Generate arm_bf16.h bryanpkc wrote: > bryanpkc wrote: > > sdesmalen wrote: > > > The

[PATCH] D143917: [clang-tidy] Clarify bugprone-branch-clone diagnostic message

carlosgalvezp added a comment. @donat.nagy Are you available to push the commit yourself? Otherwise I can help you with that, please let me know your name and email (must match those on your Github account) for attribution. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[clang] 1ba93c3 - [Modules] Don't re-generate template specialization in the importer

Author: Chuanqi Xu Date: 2023-02-14T17:15:33+08:00 New Revision: 1ba93c3c30dcdf2659e3020ba462e0025187d8e1 URL: https://github.com/llvm/llvm-project/commit/1ba93c3c30dcdf2659e3020ba462e0025187d8e1 DIFF: https://github.com/llvm/llvm-project/commit/1ba93c3c30dcdf2659e3020ba462e0025187d8e1.diff LO

[PATCH] D142893: [NFC] Class for building MultilibSet

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/Driver/MultilibBuilder.h:117 + /// Add an optional Multilib segment + MultilibSetBuilder &Maybe(const MultilibBuilder &M); + --

[clang-tools-extra] 504aa8a - [include-cleaner] Better support ambiguous std symbols

Author: Haojian Wu Date: 2023-02-14T10:18:38+01:00 New Revision: 504aa8ae941ea8e09b89a91cfbbbeb8a7b8fdc24 URL: https://github.com/llvm/llvm-project/commit/504aa8ae941ea8e09b89a91cfbbbeb8a7b8fdc24 DIFF: https://github.com/llvm/llvm-project/commit/504aa8ae941ea8e09b89a91cfbbbeb8a7b8fdc24.diff LO

[PATCH] D143906: [include-cleaner] Better support ambiguous std symbols

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG504aa8ae941e: [include-cleaner] Better support ambiguous std symbols (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] 64dad4b - Use llvm::bit_cast (NFC)

Author: Kazu Hirata Date: 2023-02-14T01:22:12-08:00 New Revision: 64dad4ba9af603330458a7673e39a873afdf3d4d URL: https://github.com/llvm/llvm-project/commit/64dad4ba9af603330458a7673e39a873afdf3d4d DIFF: https://github.com/llvm/llvm-project/commit/64dad4ba9af603330458a7673e39a873afdf3d4d.diff L

[PATCH] D143989: [AArch64][NFC] Rename AEK_SMEF64 and AEK_SMEI64 feature flags

CarolineConcatto created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. CarolineConcatto requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update clang feature flag names for: AEK_SMEF6 to AEK_SMEF64F64

[PATCH] D142932: [NFC] Multilib YAML parsing

phosek added a comment. For the existing YAML files within LLVM, we most commonly used the `PascalCase` for field names and less commonly `lisp-case`. This change uses `camelCase` which is unusual and unless there's a particular reason for using this scheme such as compatibility with an existin

[clang] 6240627 - [docs] Fix bullet list formatting

Author: KAWASHIMA Takahiro Date: 2023-02-14T19:14:03+09:00 New Revision: 6240627cfda444550975ccaea20a3b6d68c9ad15 URL: https://github.com/llvm/llvm-project/commit/6240627cfda444550975ccaea20a3b6d68c9ad15 DIFF: https://github.com/llvm/llvm-project/commit/6240627cfda444550975ccaea20a3b6d68c9ad15.

[clang] e8d4484 - [docs] Update the ACLE URL

Author: KAWASHIMA Takahiro Date: 2023-02-14T19:14:04+09:00 New Revision: e8d44841c5d5f1e7ca2013ab2ae23bb4cec45d1e URL: https://github.com/llvm/llvm-project/commit/e8d44841c5d5f1e7ca2013ab2ae23bb4cec45d1e DIFF: https://github.com/llvm/llvm-project/commit/e8d44841c5d5f1e7ca2013ab2ae23bb4cec45d1e.

[PATCH] D142473: [UTC] Add --version argument

nikic added a comment. Sorry, I did not interpret those comments as blocking concerns. Happy to revert this if they were intended as such -- this is effectively an NFC patch until DEFAULT_VERSION gets bumped, so we can still backtrack to a different approach (though I'm not aware of any that wo

[PATCH] D137526: [C++20] [Modules] [NFC] Add Preprocessor methods for named modules - for ClangScanDeps (1/4)

nikic added a comment. It looks like this causes a minor compile-time regression (about 0.2% on `O0` builds): http://llvm-compile-time-tracker.com/compare.php?from=ad81d019a62d33e5d1f232844b83d3e164e4b160&to=6470706bc0ed2425704bc8c9e121a72e2d272616&stat=instructions:u I wanted to check whether

[PATCH] D143825: [clang-format] Put ports on separate lines in Verilog module headers

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2836 + Tok = Tok->getNextNonComment(); + } else if (Tok->is(tok::hashhash)) { +// Concatenation. Skip. are we covering these cases in the unit tests

[PATCH] D143755: [clang-format] Add a space between an overloaded operator and '>'

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143755/new/ https://reviews.llvm.org/D143755 ___ cfe-commits mailing li

[PATCH] D143630: [clang] update test case

tbaeder added a comment. Added Nikita as reviewer, since this is about opaque pointers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143630/new/ https://reviews.llvm.org/D143630 ___ cfe-commits mailing

[PATCH] D143996: [clang-tidy][doc] Remove unused variable

bjosv created this revision. Herald added subscribers: kbarton, xazax.hun, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. bjosv requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Remove mention of a varia

[PATCH] D143630: [clang] update test case

nikic added a comment. Hm, I don't think the clang/test/CodeGen/X86/x86-builtins-intrinsic.cl file exists on current main? Is this based on top of some other patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143630/new/ https://reviews.llvm.org

[PATCH] D122573: [TBAA] Emit distinct TBAA tags for pointers with different depths,types.

bipmis added a comment. Herald added a subscriber: StephenFan. @fhahn We are also observing scenarios where this maybe necessary. A couple of points on where it may be missing 1. createScalarTypeNode(OutName, AnyPtr, Size) -> This will generate different Base type. However the accessTy being "a

[PATCH] D143917: [clang-tidy] Clarify bugprone-branch-clone diagnostic message

donat.nagy added a comment. Thanks for the feedback! I can push the commit and I'll do so after a few days (if no changes are suggested). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143917/new/ https://reviews.llvm.org/D143917 _

[PATCH] D142630: [clang][Interp] Implement virtual function calls

tbaeder updated this revision to Diff 497276. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142630/new/ https://reviews.llvm.org/D142630 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Context.cpp clang/lib/AST/Interp/Context.h clang/lib/AST/Interp/Descriptor

[PATCH] D142630: [clang][Interp] Implement virtual function calls

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1560 + // is the furthest we might go up in the hierarchy. + ThisPtr = ThisPtr.getDeclPtr(); +} I think this test case was from the function pointer review, but this fixes: ```

[PATCH] D143418: [libclang] Add API to set preferred temp dir path

aaron.ballman added a comment. In D143418#4125098 , @vedgy wrote: >> `uint32_t Size; // = sizeof(struct CIndexOptions), used for option >> versioning` > > 1. `uint32_t` was introduced in C99. Can/should it be used in //Index.h//? > Only built-in `[unsig

[clang] 463fa25 - [clang][NFC] Adjust tests to not un/define predefined macros

Author: John Brawn Date: 2023-02-14T13:55:03Z New Revision: 463fa25c34d6e569862a9b74b24db3aa5522d84b URL: https://github.com/llvm/llvm-project/commit/463fa25c34d6e569862a9b74b24db3aa5522d84b DIFF: https://github.com/llvm/llvm-project/commit/463fa25c34d6e569862a9b74b24db3aa5522d84b.diff LOG: [c

[PATCH] D133863: [RISCV] Add MC support of RISCV zcmt Extension

VincentWu updated this revision to Diff 497293. VincentWu added a comment. Herald added subscribers: luke, emaste. update to v1.0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133863/new/ https://reviews.llvm.org/D133863 Files: clang/test/Prepro

[PATCH] D144003: [clang][analyzer] Improve bug reports of StdLibraryFunctionsChecker.

balazske created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a reviewer: NoQ. Herald added a project:

[PATCH] D138777: [clang-tidy] Add check bugprone-multiple-new-in-one-expression.

donat.nagy added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/MultipleNewInOneExpressionCheck.cpp:44-45 +return BinOp->getOpcode() == BO_Assign && + BinOp->getRHS()->IgnoreParenCasts() == E; + + return isa(ParentE); In genera

[PATCH] D143533: [clang] Allow gnu::aligned attribute to work with templated type alias declarations

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. Adding Erich as attributes code owner. Comment at: clang/lib/AST/ASTContext.cpp:2154 + if (uint64_t Result = SubstTypeVisitor(Ctx, SubType->getReplacementType()) +.TryEval(At

[PATCH] D142507: [AMDGPU] Split dot7 feature

aaronmondal added subscribers: jhuber6, aaronmondal. aaronmondal added a comment. Would it be possible to backport this to Clang 16? If https://github.com/RadeonOpenCompute/ROCm-Device-Libs/commit/8dc779e19cbf2ccfd3307b60f7db57cf4203a5be makes it into ROCm 5.5 no distro would be able to build i

[PATCH] D143891: [Clang] Adjust triviality computation in QualType::isTrivialType to C++20 cases.

erichkeane added a comment. In D143891#4122731 , @aaron.ballman wrote: > In D143891#4122668 , @royjacobson > wrote: > >> In D143891#4122660 , >> @aaron.ballman wrote: >

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

eklepilkina added a comment. @reames Thank you for fixing documentation, missed this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141666/new/ https://reviews.llvm.org/D141666 ___ cfe-commits mailing lis

[PATCH] D143891: [Clang] Adjust triviality computation in QualType::isTrivialType to C++20 cases.

erichkeane added a comment. In D143891#4125954 , @erichkeane wrote: > In D143891#4122731 , @aaron.ballman > wrote: > >> In D143891#4122668 , @royjacobson >> wrote: >> >

[PATCH] D143414: [clang] refactor FileManager::GetUniqueIDMapping

rmaz updated this revision to Diff 497309. rmaz added a comment. remove `header_file_size()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143414/new/ https://reviews.llvm.org/D143414 Files: clang/include/clang/Basic/FileManager.h clang/includ

[PATCH] D143745: Make section attribute and -ffunction-sections play nicely

probinson abandoned this revision. probinson added a comment. Discussion on the GCC bug has persuaded me this is not a good idea. I'll solve my user's problem a different way. @MaskRay you can close the GCC bug, it looks like I can't do it myself. CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

asb added a comment. Thanks Philip. I started looking at this too, and agree that something like this is a good next step. I've been looking more closely at the GCC behaviour and noticed a couple of things that might be of interest: - `-march=rv64gc` results in`rv64i2p1_m2p0_a2p1_f2p2_d2p2_c2p

[PATCH] D144011: [clang]Fix warning for signed conversion

yaxunl created this revision. yaxunl added reviewers: tra, rsmith, MaskRay, rtrieu. Herald added a project: All. yaxunl requested review of this revision. Currently clang emits warning with -Wconversion for the following code: long foo(long x) { return 1LL

[PATCH] D143849: [Clang][OpenCL] Allow pointers in structs as kernel arguments from 2.0

Ayal updated this revision to Diff 497317. Ayal added a comment. Use `-verify=expected,ocl12` instead of #ifdef'ing the test to check diagnostics emitted for 1.2 but not emitted for 2.0. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143849/new/ https://reviews.llvm.org/D143849 Files:

[PATCH] D143849: [Clang][OpenCL] Allow pointers in structs as kernel arguments from 2.0

Ayal added inline comments. Comment at: clang/test/SemaOpenCL/invalid-kernel-parameters.cl:90 +#if __OPENCL_C_VERSION__ <= CL_VERSION_1_2 typedef struct FooImage2D // expected-note{{within field of type 'FooImage2D' declared here}} yaxunl wrote: > Ayal wrote:

[PATCH] D143533: [clang] Allow gnu::aligned attribute to work with templated type alias declarations

erichkeane added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:2154 + if (uint64_t Result = SubstTypeVisitor(Ctx, SubType->getReplacementType()) +.TryEval(Attr->getAlignmentExpr())) { +TI.Align = Result; aaron.ballman

[PATCH] D143996: [clang-tidy][doc] Remove unused variable

Eugene.Zelenko requested changes to this revision. Eugene.Zelenko added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.rst:35 -Variables: ``a``, ``c``, ``c_

[PATCH] D143921: [debug-info][codegen] Prevent creation of self-referential SP node

fdeazeve updated this revision to Diff 497321. fdeazeve added a comment. Added verifier test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143921/new/ https://reviews.llvm.org/D143921 Files: clang/lib/CodeGen/CGDebugInfo.cpp llvm/docs/LangRef.

[PATCH] D143921: [debug-info][codegen] Prevent creation of self-referential SP node

fdeazeve added a comment. In D143921#4124533 , @aprantl wrote: > In D143921#4123218 , @fdeazeve > wrote: > >> Any testing suggestions here? I can use what we have on GH (cpp -> codegen >> test), but I'm not sure

[PATCH] D143430: [C2x] Implement the `unreachable` macro for WG14 N2826

erichkeane added inline comments. Comment at: clang/lib/Headers/stddef.h:108 +__STDC_VERSION__ >= 202000L +#define unreachable() __builtin_unreachable() +#endif /* defined(__need_STDDEF_H_misc) && >= C23 */ Is this REALLY required to be a macro by standard?

[PATCH] D143495: [AMDGPU ASAN] Remove reference to asan bitcode library

yaxunl added a comment. In D143495#4123119 , @pvellien wrote: > @yaxunl Could you please commit this change on my behalf? I don't have a > write access to the trunk. > Thank you sure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary`

erichkeane added a comment. On the fence about the diagnostic at all, but definitely should not be doing string magic to make it quoted. Otherwise this is a LGTM. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5620 +std::string Spelling = "'" + std::string(getTraitSpelling(BT

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos marked 2 inline comments as done. pmatos added a comment. @aaron.ballman I have finished addressing all the concerns on this patch. Do you have any further comments? Comment at: clang/lib/Sema/SemaType.cpp:7289-7290 + QualType Pointee = Type->getPointeeType(); + Point

[PATCH] D143194: [clang][analyzer] Make messages of StdCLibraryFunctionsChecker user-friendly

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:95 +QualType ArgT, BasicValueFactory &BVF, +

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

reames updated this revision to Diff 497328. reames edited the summary of this revision. reames added a comment. Add docs, and rework description. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143953/new/ https://reviews.llvm.org/D143953 Files: clang/test/Preprocessor/riscv-target-fe

[PATCH] D144015: [OpenMP]Fix PR55970: Miscompile of collapse(3) with non-rectangular loop nest.

ABataev created this revision. ABataev added a reviewer: mikerice. Herald added subscribers: guansong, yaxunl. Herald added a project: All. ABataev requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: openmp-commits, sstefan1. Herald added projects: clang

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

reames updated this revision to Diff 497336. reames added a comment. Address @jrtc27's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143953/new/ https://reviews.llvm.org/D143953 Files: clang/test/Preprocessor/riscv-target-features.c llvm/docs/RISCVUsage.rst llvm/lib/Sup

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to control trailing underscore added to external names

clementval added a comment. You still have clang-format issues in your patch. Can you update that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140795/new/ https://reviews.llvm.org/D140795 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

reames added a comment. We seem to have rough consensus here, but I'm going to wait roughly 24 hours before landing to give others time to comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143953/new/ https://reviews.llvm.org/D143953 __

[PATCH] D144016: [Sema] Relax a failing assertion in TransformBlockExpr

ahatanak created this revision. ahatanak added reviewers: arphaman, fahad, aaron.ballman. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. The assertion fails when the expression causing the this pointer to be captured is part of a constexp

[PATCH] D143996: [clang-tidy][doc] Remove unused variable

bjosv updated this revision to Diff 497344. bjosv added a comment. Updated to fill 80 char as proposed, and changed some wordings. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143996/new/ https://reviews.llvm.org/D143996 Files: clang-tools-extra/docs/clang-tidy/checks/cppcoreguidel

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin added a comment. In D143436#4122594 , @kadircet wrote: > That's actually because we model compile commands pushed via LSP as a "fixed > compilation database" rather than a json compilation database (you can check > the code in `parseFixed

[PATCH] D143418: [libclang] Add API to set preferred temp dir path

vedgy added a comment. In D143418#4125756 , @aaron.ballman wrote: > In D143418#4125098 , @vedgy wrote: > >>> `uint32_t Size; // = sizeof(struct CIndexOptions), used for option >>> versioning` >> >> 1. `uint32_t`

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 497349. VitaNuo marked 9 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496 Files: clang-too

[PATCH] D143921: [debug-info][codegen] Prevent creation of self-referential SP node

aprantl accepted this revision. aprantl added a comment. Test looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143921/new/ https://reviews.llvm.org/D143921 ___ cfe-commits mailing list cfe-commi

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo added a comment. Thank you for the comments! I've addressed (almost) all of them. In some places, I'm not so happy about how the code has become very nested, but I don't have ideas on how to make it better atm. Comment at: clang-tools-extra/clangd/Config.h:91 + enu

[clang] f4d8b87 - [AMDGPU ASAN] Remove reference to asan bitcode library

Author: Yaxun (Sam) Liu Date: 2023-02-14T11:52:41-05:00 New Revision: f4d8b8781de9b0efbaf79621ff66c16964bb1df2 URL: https://github.com/llvm/llvm-project/commit/f4d8b8781de9b0efbaf79621ff66c16964bb1df2 DIFF: https://github.com/llvm/llvm-project/commit/f4d8b8781de9b0efbaf79621ff66c16964bb1df2.dif

[PATCH] D143495: [AMDGPU ASAN] Remove reference to asan bitcode library

This revision was automatically updated to reflect the committed changes. Closed by commit rGf4d8b8781de9: [AMDGPU ASAN] Remove reference to asan bitcode library (authored by yaxunl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143495/new/ https:/

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson closed this revision. royjacobson added a comment. Landed in https://github.com/llvm/llvm-project/commit/be701ab08f12daf9437c2db6d08a1731cf1df34c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142578/new/ https://reviews.llvm.org/D14257

[clang] 574d0c2 - [clang][test][RISCV] Fix precision of CHECK-NOT lines in riscv-target-features.c

Author: Alex Bradbury Date: 2023-02-14T16:55:03Z New Revision: 574d0c2ec107cd3bfb753424150624276fe43813 URL: https://github.com/llvm/llvm-project/commit/574d0c2ec107cd3bfb753424150624276fe43813 DIFF: https://github.com/llvm/llvm-project/commit/574d0c2ec107cd3bfb753424150624276fe43813.diff LOG:

[clang] d05e1e9 - [clang][test][RISCV] Check for __riscv_i in riscv-target-features.c

Author: Alex Bradbury Date: 2023-02-14T17:02:32Z New Revision: d05e1e99b1d62cf1f8ab37f83dd2f377328dd9c5 URL: https://github.com/llvm/llvm-project/commit/d05e1e99b1d62cf1f8ab37f83dd2f377328dd9c5 DIFF: https://github.com/llvm/llvm-project/commit/d05e1e99b1d62cf1f8ab37f83dd2f377328dd9c5.diff LOG:

[PATCH] D143522: [AMDGPU] Set a data layout entry for buffer descriptors (addrspace 7)

krzysz00 added a reviewer: piotr. krzysz00 added a comment. Discussion related to this is also happening over at https://reviews.llvm.org/D143945 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143522/new/ https://reviews.llvm.org/D143522 ___

[PATCH] D143501: [clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

aprantl added a comment. > Alternatively, I suppose, the DWARF emission could just look at the preferred > name and use that as the DW_AT_type in all cases anyway? Avoids needing a new > attribute, etc, though would be a bit quirky in its own way. Am I understanding you correctly that you sugge

[PATCH] D142604: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

shafik added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142604/new/ https://reviews.llvm.org/D142604 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D143851: [clang-tidy] Tweak 'rule of 3/5' checks to allow defaulting a destructor outside the class.

ClockMan added a comment. Thing is that same issue may happen with all other members, what about copy/move constructors defaulted in .cpp (just to speed up compilation for classes with many members). Best thing would simply to check if all definitions are available. In that case issues would be

[PATCH] D142604: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

erichkeane added subscribers: cor3ntin, tahonermann. erichkeane added a comment. Pretty sure @cor3ntin and @tahonermann are our Lexer code owners? Or at least were in the initial proposal. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142604/new/ https://reviews.llvm.org/D142604

[PATCH] D144027: [NFC][IR] Make Module::getGlobalList() private

vporpo created this revision. vporpo added a reviewer: aeubanks. Herald added subscribers: mattd, gchakrabarti, asavonic, snehasish, ormris, hiraditya. Herald added a project: All. vporpo requested review of this revision. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, jholewin

[PATCH] D144027: [NFC][IR] Make Module::getGlobalList() private

aeubanks accepted this revision. aeubanks added inline comments. This revision is now accepted and ready to land. Comment at: llvm/unittests/IR/ModuleTest.cpp:49 EXPECT_FALSE(std::is_sorted(M.global_begin(), M.global_end(), compare)); -M.getGlobalList().sort(compare); -

[PATCH] D144015: [OpenMP]Fix PR55970: Miscompile of collapse(3) with non-rectangular loop nest.

mikerice accepted this revision. mikerice added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144015/new/ https://reviews.llvm.org/D144015 __

[PATCH] D143851: [clang-tidy] Tweak 'rule of 3/5' checks to allow defaulting a destructor outside the class.

royjacobson added a comment. In D143851#4126453 , @ClockMan wrote: > Thing is that same issue may happen with all other members, what about > copy/move constructors defaulted in .cpp (just to speed up compilation for > classes with many members). > Best

[PATCH] D144027: [NFC][IR] Make Module::getGlobalList() private

vporpo updated this revision to Diff 497367. vporpo marked an inline comment as done. vporpo added a comment. Removed commented out lines from ModuleTest.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144027/new/ https://reviews.llvm.org/D144027

[PATCH] D144027: [NFC][IR] Make Module::getGlobalList() private

vporpo added inline comments. Comment at: llvm/unittests/IR/ModuleTest.cpp:47-49 // Sort the globals by name. EXPECT_FALSE(std::is_sorted(M.global_begin(), M.global_end(), compare)); -M.getGlobalList().sort(compare); I removed this because it is tes

[PATCH] D144011: [clang]Fix warning for signed conversion

shafik added a comment. If I look at the clang docs for Wconversion I see it includes `-Wshorten-64-to-32` which I believe this is a case of. I think maybe the warning needs a better warning for this case? CHANGES SINCE LAST

[PATCH] D144011: [clang]Fix warning for signed conversion

yaxunl added a comment. In D144011#4126553 , @shafik wrote: > If I look at the clang docs for Wconversion > I see it > includes `-Wshorten-64-to-32` which I believe this is a case of. I

[PATCH] D142507: [AMDGPU] Split dot7 feature

rampitec added a comment. In D142507#4125940 , @aaronmondal wrote: > Would it be possible to backport this to Clang 16? > > If > https://github.com/RadeonOpenCompute/ROCm-Device-Libs/commit/8dc779e19cbf2ccfd3307b60f7db57cf4203a5be > makes it into ROCm

[PATCH] D143851: [clang-tidy] Tweak 'rule of 3/5' checks to allow defaulting a destructor outside the class.

carlosgalvezp added a comment. > This is why this option was only available for destructors in the first > place, I imagine. The `cppcoreguidelines` are a bit tricky to work with. Some of the rules are too strict to reasonably apply them in practice. We have brought this up with the authors of

[libclc] f6cd46e - libclc: add more generic implementations to clspv SOURCES

Author: Kévin Petit Date: 2023-02-14T18:11:01Z New Revision: f6cd46e07fcca123620afff96675171f8fe96124 URL: https://github.com/llvm/llvm-project/commit/f6cd46e07fcca123620afff96675171f8fe96124 DIFF: https://github.com/llvm/llvm-project/commit/f6cd46e07fcca123620afff96675171f8fe96124.diff LOG: l

[PATCH] D143301: Emit warning for unsupported gfortran flags

jdoerfert added a comment. Split this into two patches/reviews. I think the -W stuff can go in, it has tests and is reasonable. The other stuff needs tests too. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:607 if (args.hasArg(clang::driver::options::OPT_W_Joined))

[libclc] 290308a - libclc: add generated convert.cl to clspv/clspv64 targets

Author: Kévin Petit Date: 2023-02-14T18:23:35Z New Revision: 290308a99e6b9e6f808a9824c8e5a58a65749585 URL: https://github.com/llvm/llvm-project/commit/290308a99e6b9e6f808a9824c8e5a58a65749585 DIFF: https://github.com/llvm/llvm-project/commit/290308a99e6b9e6f808a9824c8e5a58a65749585.diff LOG: l

[libclc] 1da2085 - libclc: add clspv to targets exempt from alwaysinline

Author: Kévin Petit Date: 2023-02-14T18:26:42Z New Revision: 1da2085a513341f0e8d7578415dcf77d614708e5 URL: https://github.com/llvm/llvm-project/commit/1da2085a513341f0e8d7578415dcf77d614708e5 DIFF: https://github.com/llvm/llvm-project/commit/1da2085a513341f0e8d7578415dcf77d614708e5.diff LOG: l

[PATCH] D143301: Emit warning for unsupported gfortran flags

awarzynski added a comment. In D143301#4126682 , @jdoerfert wrote: > Split this into two patches/reviews. +1 > I think the -W stuff can go in, it has tests and is reasonable. I'd like for us to rely on a flag from Options.td for this instead. Something

[clang] ddde069 - [OpenMP]Fix PR55970: Miscompile of collapse(3) with non-rectangular loop nest.

Author: Alexey Bataev Date: 2023-02-14T10:39:04-08:00 New Revision: ddde06906be11ea540870d5c0e1b3336a4460612 URL: https://github.com/llvm/llvm-project/commit/ddde06906be11ea540870d5c0e1b3336a4460612 DIFF: https://github.com/llvm/llvm-project/commit/ddde06906be11ea540870d5c0e1b3336a4460612.diff

[PATCH] D144015: [OpenMP]Fix PR55970: Miscompile of collapse(3) with non-rectangular loop nest.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGddde06906be1: [OpenMP]Fix PR55970: Miscompile of collapse(3) with non-rectangular loop nest. (authored by ABataev). Repository: rG LLVM Github Mon

[PATCH] D143996: [clang-tidy][doc] Remove unused variable

carlosgalvezp accepted this revision. carlosgalvezp added a comment. LGTM, thanks for the fix! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143996/new/ https://reviews.llvm.org/D143996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D143851: [clang-tidy] Tweak 'rule of 3/5' checks to allow defaulting a destructor outside the class.

ClockMan added a comment. In D143851#4126615 , @carlosgalvezp wrote: > Yes, clang-tidy will not issue warnings in system headers, so checks should > not need to explicitly handle that. That's not so simple. At work we use clang-tidy for few big project

[PATCH] D144035: [hwasan] Ensure hwasan aliases do not have ODR linkage

leonardchan created this revision. leonardchan added reviewers: pcc, eugenis, vitalybuka. leonardchan added a project: Sanitizers. Herald added subscribers: Enna1, jeroen.dobbelaere, hiraditya. Herald added a project: All. leonardchan requested review of this revision. Herald added projects: clang,

[PATCH] D144035: [hwasan] Ensure hwasan aliases do not have ODR linkage

leonardchan added a comment. Lemme know if the clang regression test isn't necessary or should be in its own commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144035/new/ https://reviews.llvm.org/D144035 __

[PATCH] D142507: [AMDGPU] Split dot7 feature

arsenm added inline comments. Comment at: clang/include/clang/Basic/BuiltinsAMDGPU.def:239 -TARGET_BUILTIN(__builtin_amdgcn_fdot2, "fV2hV2hfIb", "nc", "dot7-insts") +TARGET_BUILTIN(__builtin_amdgcn_fdot2, "fV2hV2hfIb", "nc", "dot10-insts") TARGET_BUILTIN(__builtin_amdgcn_fdot2

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to control trailing underscore added to external names

madanial updated this revision to Diff 497392. madanial added a comment. clang-format issue in ExternalNameConversion.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140795/new/ https://reviews.llvm.org/D140795 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/To

[PATCH] D144011: [clang]Fix warning for signed conversion

MaskRay added a comment. I think it makes sense for `-Wsign-conversion` to not warn for this case. I do not know whether we need another diagnostic like `-Wshorten-64-to-32` for this case, but am inclined to no. `-m32` doesn't emit a warning. I wonder whether the newly added condition can be m

  1   2   >