[PATCH] D142939: Fix handling of -> calls for modernize-use-emplace

carlosgalvezp added a comment. Pushed, thanks for the contribution! I took the liberty of fixing the `std::vector` thing before pushing :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142939/new/ https://reviews.llvm.org/D142939

[PATCH] D143692: [clang][driver] Emit error when enabling emulated tls on unsupported architectures

paulkirth updated this revision to Diff 496553. paulkirth added a comment. Address comments. - improve FileCheck directive in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143692/new/ https://reviews.llvm.org/D143692 Files: clang/lib/Drive

[PATCH] D143768: [Clang] Add options to disable direct linking of arch tools

aaronmondal added a comment. Ah yeah my bad 😅 Hmm somehow I keep getting confused by this. I'll check how other deps handle this, maybe there is a better way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143768/new/ https://reviews.llvm.org/D143

[PATCH] D143375: clang-tidy: Count template constructors in modernize-use-default-member-init

oleg.smolsky added a comment. Nice! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143375/new/ https://reviews.llvm.org/D143375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

asb added a comment. In D122215#4119038 , @vitalybuka wrote: > In D122215#4118516 , @asb wrote: > >> @pmatos and I have tried and failed to reproduce the assert in the stage3 >> msan build locally (both of us on

[clang] 70acb3a - A slightly more concise AST dump :)

Author: Dani Ferreira Franco Moura Date: 2023-02-10T19:11:31Z New Revision: 70acb3aab3a10eea802781f69c8336c21dce6d59 URL: https://github.com/llvm/llvm-project/commit/70acb3aab3a10eea802781f69c8336c21dce6d59 DIFF: https://github.com/llvm/llvm-project/commit/70acb3aab3a10eea802781f69c8336c21dce6d

[PATCH] D142637: A slightly more concise AST dump :)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG70acb3aab3a1: A slightly more concise AST dump :) (authored by merrymeerkat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D143745: Make section attribute and -ffunction-sections play nicely

probinson added a comment. I'm not sure I understand the linker's mechanics here. Let me say some things and you can describe my misunderstanding. - If the linker was going to discard all of section foo (in the current scheme), that means it had no reason to retain either f() or g(). In the new

[PATCH] D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

vvereschaka added a comment. @ChuanqiXu, would you provide a complete rollback for the changes and fix the `C1689.cppm` test failures on the builders - https://lab.llvm.org/buildbot/#/builders/119/builds/11935/steps/9/logs/FAIL__Clang__P1689_cppm - https://lab.llvm.org/buildbot/#/builders/60/

[PATCH] D137799: [llvm-driver] Pass extra arguments to tools

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f173a0653e7: [llvm-driver] Pass extra arguments to tools (authored by abrachet). Herald added a project: clang. Herald added a subscriber: cfe-commi

[clang] 1f173a0 - [llvm-driver] Pass extra arguments to tools

Author: Alex Brachet Date: 2023-02-10T19:42:32Z New Revision: 1f173a0653e7f0c3800033edfa16ffe4c35cde85 URL: https://github.com/llvm/llvm-project/commit/1f173a0653e7f0c3800033edfa16ffe4c35cde85 DIFF: https://github.com/llvm/llvm-project/commit/1f173a0653e7f0c3800033edfa16ffe4c35cde85.diff LOG:

[PATCH] D137800: [llvm-driver] Reinvoke clang as described by llvm driver extra args

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. abrachet marked 2 inline comments as done. Closed by commit rG3e57aa304f15: [llvm-driver] Reinvoke clang as described by llvm driver extra args (authored by abrachet).

[clang] 3e57aa3 - [llvm-driver] Reinvoke clang as described by llvm driver extra args

Author: Alex Brachet Date: 2023-02-10T19:42:32Z New Revision: 3e57aa304f15a0821e5bcc90bd346529fed6658d URL: https://github.com/llvm/llvm-project/commit/3e57aa304f15a0821e5bcc90bd346529fed6658d DIFF: https://github.com/llvm/llvm-project/commit/3e57aa304f15a0821e5bcc90bd346529fed6658d.diff LOG:

[PATCH] D143768: [Clang] Add options to disable direct linking of arch tools

aaronmondal added a comment. Fun fact I now know that libxml2 also struggles with this 😆 The following would roughly be how zlib and others handle it: if (CLANG_ENABLE_HSA) if (CLANG_ENABLE_HSA STREQUAL FORCE_ON) find_package(hsa-runtime... REQUIRED) else() find_package

[PATCH] D143768: [Clang] Add options to disable direct linking of arch tools

aaronmondal added a comment. This would also allow e.g. the ROCm packages to `FORCE_ON` hsa and enjoy the benefits of the LLVM configuration 😊 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143768/new/ https://reviews.llvm.org/D143768

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

andrew.w.kaylor added a comment. In general, it seems like the denormal mode should be considered part of the floating point environment (though as far as I know the C standard, at least, doesn't document it as such). If it were considered part of the floating point environment, the LLVM rules

[PATCH] D143664: [SanitizerBinaryMetadata] Support ignore list

chapuni added a comment. The test `sanitize-metadata-ignorelist.c` fails in -Asserts. Comment at: clang/test/CodeGen/sanitize-metadata-ignorelist.c:11 +// ALLOW-SAME: () local_unnamed_addr #[[ATTR0:[0-9]+]] !pcsections !5 { +// ALLOW-NEXT: entry: +// ALLOW-NEXT:[[TMP0:%.*]

[PATCH] D143768: [Clang] Add options to disable direct linking of arch tools

jhuber6 added a comment. Like I said, the difference between these dependencies and something like `libxml2` or `libz` is that the presence of the libraries doesn't guard any features. We can build the application both ways, the only difference is runtime cost if we don't link the library direc

[PATCH] D142939: Fix handling of -> calls for modernize-use-emplace

BigPeet added a comment. Thank you very much. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142939/new/ https://reviews.llvm.org/D142939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[libunwind] 0751fc6 - [libunwind] On Darwin, add a callback-based lookup scheme for JIT'd unwind info.

Author: Lang Hames Date: 2023-02-10T14:36:25-08:00 New Revision: 0751fc68b976d25dd3041217dad16622cf151cd6 URL: https://github.com/llvm/llvm-project/commit/0751fc68b976d25dd3041217dad16622cf151cd6 DIFF: https://github.com/llvm/llvm-project/commit/0751fc68b976d25dd3041217dad16622cf151cd6.diff LO

[clang] 043550e - [Driver] Stop stack use after free

Author: Alex Brachet Date: 2023-02-10T22:42:12Z New Revision: 043550e33509fb3179cfcd6516e8d93240553582 URL: https://github.com/llvm/llvm-project/commit/043550e33509fb3179cfcd6516e8d93240553582 DIFF: https://github.com/llvm/llvm-project/commit/043550e33509fb3179cfcd6516e8d93240553582.diff LOG:

[PATCH] D143781: [Clang][LLVM] Enable __arithmetic_fence and fprotect-parens on AArch64

alexander-shaposhnikov created this revision. alexander-shaposhnikov added reviewers: efriedma, aaron.ballman, mibintc. alexander-shaposhnikov created this object with visibility "All Users". Herald added a subscriber: kristof.beyls. Herald added a project: All. alexander-shaposhnikov requested rev

[clang] dac423b - [SanitizerBinaryMetadata] Fix ignorelist test with -Assert

Author: Marco Elver Date: 2023-02-11T00:33:13+01:00 New Revision: dac423bd571858a85f3b388904392f0e55421d7d URL: https://github.com/llvm/llvm-project/commit/dac423bd571858a85f3b388904392f0e55421d7d DIFF: https://github.com/llvm/llvm-project/commit/dac423bd571858a85f3b388904392f0e55421d7d.diff L

[PATCH] D143664: [SanitizerBinaryMetadata] Support ignore list

melver marked an inline comment as done. melver added inline comments. Comment at: clang/test/CodeGen/sanitize-metadata-ignorelist.c:11 +// ALLOW-SAME: () local_unnamed_addr #[[ATTR0:[0-9]+]] !pcsections !5 { +// ALLOW-NEXT: entry: +// ALLOW-NEXT:[[TMP0:%.*]] = atomicrmw add

[PATCH] D143501: [clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

dblaikie added a subscriber: probinson. dblaikie added a comment. In D143501#4116200 , @Michael137 wrote: >> I'd recommend a possible long-term solution would be simplified template >> names (so we don't have to worry about encoding this in the `DW_AT_n

[PATCH] D143794: [Fuchsia] Add FUCHSIA_ENABLE_LLDB option.

mysterymath created this revision. mysterymath added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. mysterymath requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This CMake option builds/installs LLDB as

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

arsenm added a comment. In D142907#4119339 , @andrew.w.kaylor wrote: > In general, it seems like the denormal mode should be considered part of the > floating point environment (though as far as I know the C standard, at least, > doesn't document it as

[PATCH] D137458: [clang] Add __decay as a builtin template

cjdb added subscribers: aaron.ballman, cjdb. cjdb added a comment. In D137458#3909343 , @troyj wrote: >> Also, it would be nice to have some numbers for the 'measurably faster' >> claim :) > > Sure. Here's an example of a library change that started usin

[PATCH] D143691: Fix clang-formats IncludeCategory to match the documentation

Febbe updated this revision to Diff 496647. Febbe added a comment. Fixed the Unit Tests - rewritten one test, which made the assumption, that there can be only one main header. - it now asserts, that all matching headers are considered as main header. - replaced initialisations of `IncludeCate

[PATCH] D139798: [clang-repl] Support compound statement as a top-level statement.

v.g.vassilev added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139798/new/ https://reviews.llvm.org/D139798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[PATCH] D143691: Fix clang-formats IncludeCategory to match the documentation

Febbe updated this revision to Diff 496650. Febbe added a comment. Added priority to the sorting algorithm. This prevents unwanted splits and weird resorts of groups with the same priority, but with different and overlapping (other groups) SortPriority. The new system can now be understood as Pri

[PATCH] D143691: Fix clang-formats IncludeCategory to match the documentation

Febbe added a comment. I think I am done, and you can review it now. With the latest changes, SortPriority is no longer required to match Priority, it can always be 0, since Priority is now used in the sorting algorithm. This is what the documentation tends to depict: "and #includes are sorted

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

cpsauer added a comment. @kadircet, friendly check in, since I got reminded of this: How would you like to proceed from here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138546/new/ https://reviews.llvm.org/D138546 ___ cfe-commits mailing

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

0xdc03 created this revision. Herald added a subscriber: jeroen.dobbelaere. Herald added a project: All. 0xdc03 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When an alias or ifunc attribute refers to a function name that is mangled, a di

[PATCH] D137309: [clang] Added Swift support for RISCV

jrtc27 added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10557 private: + DefaultABIInfo defaultInfo; // Size of the integer ('x') registers in bits. Huh? This is unused. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10601

[PATCH] D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

ChuanqiXu added a comment. In D139168#4119190 , @vvereschaka wrote: > @ChuanqiXu, > > would you provide a complete rollback for the changes and fix the > `C1689.cppm` test failures on the builders > > - > https://lab.llvm.org/buildbot/#/builders/119/bu

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

0xdc03 added a comment. Note that as it stands currently, this patch cannot be committed because the test `clang/test/SemaCXX/externc-ifunc-resolver.cpp` fails to run. The contents of the test are as follows: // RUN: %clang_cc1 -emit-llvm-only -triple x86_64-linux-gnu -verify %s extern "

[PATCH] D137527: [C++20] [Modules] [ClangScanDeps] Add ClangScanDeps support for C++20 Named Modules in P1689 format (2/4)

ChuanqiXu added a comment. In D137527#4117675 , @uabelho wrote: > Hi, > > There seems to be something funny going on with the > > ClangScanDeps/P1689.cppm > > testcase added in this patch. > > It fails randomly for me on top of tree (4ad8f7a189570 >

[PATCH] D137309: [clang] Added Swift support for RISCV

craig.topper added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10555 namespace { -class RISCVABIInfo : public DefaultABIInfo { +class RISCVABIInfo : public SwiftABIInfo { private: SwiftABIInfo doesn't inherit from ABIInfo and hasn't since Augu

[PATCH] D143657: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis

craig.topper added inline comments. Comment at: clang/lib/Sema/Sema.cpp:2052 + Diag(Loc, diag::err_riscv_type_requires_extension, FD) + << Ty << "experimental-zvfh"; +} experimental- is an internal naming scheme. "experimental-" is not used in

[PATCH] D143665: [Clang][RISCV] Guard vector int64, float32, float64 with semantic analysis

craig.topper added inline comments. Comment at: clang/lib/Sema/Sema.cpp:2049 -if (Ty->isVectorFloat16Type() && -!Context.getTargetInfo().hasVectorFloat16Support()) { +if ((Ty->isVectorInt64Type() && + !Context.getTargetInfo().hasVectorInt64Support()) ||

[PATCH] D143418: [libclang] Add API to set preferred temp dir path

vedgy added a comment. In D143418#4118905 , @aaron.ballman wrote: > I don't think "tries hard" is a good enough guarantee for where files are > placed. I'm not comfortable with the security posture of that approach as it > could potentially leak sensit

[PATCH] D143806: [Clang][Test] Add llvm-lto, llvm-lto2 and llvm-profdata to the tool substitutions list

SixWeining created this revision. SixWeining added reviewers: dblaikie, jansvoboda11. Herald added a subscriber: inglorion. Herald added a project: All. SixWeining requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Similar to issue fixed in D1

[PATCH] D143587: [Docs] Multilib design

MaskRay added inline comments. Comment at: clang/docs/Multilib.rst:41 + +The available libraries can be hard-coded in clang. Typically this is done +using the ``MultilibBuilder`` interface. There are many examples of this in `s/clang/Clang/` Co

[PATCH] D142932: [NFC] Multilib YAML parsing

MaskRay added a comment. Adding new APIs is usually not considered `NFC`. Just remove the tag. Comment at: clang/lib/Driver/Multilib.cpp:115 +if (!StringRef(M.Regex).starts_with("^")) { + RegexString.insert(RegexString.begin(), '^'); +} https://llv

[clang] d0e24f0 - [clang] Mark CWG2165 as N/A

Author: Vlad Serebrennikov Date: 2023-02-11T09:46:18+03:00 New Revision: d0e24f0c97ecf4f4e72604adcae5cd4c6b02cb48 URL: https://github.com/llvm/llvm-project/commit/d0e24f0c97ecf4f4e72604adcae5cd4c6b02cb48 DIFF: https://github.com/llvm/llvm-project/commit/d0e24f0c97ecf4f4e72604adcae5cd4c6b02cb48.

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:167 + std::vector ArgsFlags = TC.getMultiSelectionFlags(Args); + + if (!Result.Multilibs.parse(*MB.get())) { delete blank line Comment at: clang/lib/Driver/T

[PATCH] D142717: [clang] Mark CWG2165 as N/A

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd0e24f0c97ec: [clang] Mark CWG2165 as N/A (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[clang] 5eaaf8f - Revert "[clang] Mark CWG2165 as N/A"

Author: Vlad Serebrennikov Date: 2023-02-11T09:48:40+03:00 New Revision: 5eaaf8f18093740200ffed76b32884ad9cfec12e URL: https://github.com/llvm/llvm-project/commit/5eaaf8f18093740200ffed76b32884ad9cfec12e DIFF: https://github.com/llvm/llvm-project/commit/5eaaf8f18093740200ffed76b32884ad9cfec12e.

[PATCH] D142893: [NFC] Class for building MultilibSet

MaskRay added inline comments. Comment at: clang/include/clang/Driver/MultilibBuilder.h:117 + /// Add an optional Multilib segment + MultilibSetBuilder &Maybe(const MultilibBuilder &M); + Use `camelCase` for new function names. Repository: rG LLVM Github Mo

[clang] 89ba737 - [clang] Mark CWG2165 as N/A

Author: Vlad Serebrennikov Date: 2023-02-11T09:50:25+03:00 New Revision: 89ba737bcf3444a6afe2f4ed75ce957029380267 URL: https://github.com/llvm/llvm-project/commit/89ba737bcf3444a6afe2f4ed75ce957029380267 DIFF: https://github.com/llvm/llvm-project/commit/89ba737bcf3444a6afe2f4ed75ce957029380267.

[PATCH] D142905: Change multilib selection algorithm

MaskRay added a comment. Use `[Driver] ` for pure driver patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/ https://reviews.llvm.org/D142905 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D142905: Change multilib selection algorithm

MaskRay added inline comments. Comment at: clang/lib/Driver/Multilib.cpp:53 + for (StringRef Flag : PrintArgs) { +OS << "@" << Flag.substr(1); } remove braces Comment at: clang/lib/Driver/Multilib.cpp:99 + multilib_list Result = select

[PATCH] D142905: Change multilib selection algorithm

MaskRay added a comment. Mention `MultilibSet::select` in the summary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/ https://reviews.llvm.org/D142905 ___ cfe-commits mailing list cfe-commits@

[PATCH] D142933: Add -print-multi-selection-flags argument

MaskRay added a comment. > Add -print-multi-selection-flags argument "option" is a better term. Since the option doesn't take an argument, "flag" applies as well. `[Driver] Add -print-multi-selection-flags` The summary is empty. Is that intended? We need some description what the new option d

[PATCH] D143763: [Clang] Add clangMinimumVersion to multilib.yaml

MaskRay added a comment. I think this patch can be merged into a previous one that introduces `variants` and `flagMap` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143763/new/ https://reviews.llvm.org/D143763

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

MaskRay added inline comments. Comment at: clang/test/Driver/baremetal-multilib.cpp:19 +// CHECK-NEXT: "{{[^"]*}}ld{{(\.(lld|bfd|gold))?}}{{(\.exe)?}}" "{{.*}}.o" "-Bstatic" +// CHECK-SAME: "-L{{.*}}/baremetal_multilib/bin/../lib/clang-runtimes/arm-none-eabi/thumb/v8-m.main/fp/

[clang] 22fb66e - [clang][NFC] Add another example to CWG952 test

Author: Vlad Serebrennikov Date: 2023-02-11T10:25:59+03:00 New Revision: 22fb66eb94b643c858c2beecbcfac438a7fa29ed URL: https://github.com/llvm/llvm-project/commit/22fb66eb94b643c858c2beecbcfac438a7fa29ed DIFF: https://github.com/llvm/llvm-project/commit/22fb66eb94b643c858c2beecbcfac438a7fa29ed.

[PATCH] D143745: Make section attribute and -ffunction-sections play nicely

MaskRay added a comment. If one TU has more than one section of the same name, there is no guarantee they are adjacent after linking. Linker scripts and `--shuffle-sections` can adjust them. I don't mind a behavior change if GCC is willing to do the same. But without, it's safer to use an optio

[clang] 5fc73b7 - [clang] Add test for CWG1111

Author: Vlad Serebrennikov Date: 2023-02-11T10:53:08+03:00 New Revision: 5fc73b7502fbbb46faa57a558c8661822b2b5215 URL: https://github.com/llvm/llvm-project/commit/5fc73b7502fbbb46faa57a558c8661822b2b5215 DIFF: https://github.com/llvm/llvm-project/commit/5fc73b7502fbbb46faa57a558c8661822b2b5215.

[PATCH] D142315: [clang] Add test for CWG1111

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5fc73b7502fb: [clang] Add test for CWG (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

<    1   2