[PATCH] D129951: adds `__disable_adl` attribute

cjdb added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4132 +def DisableADL : InheritableAttr { + let Spellings = [Keyword<"__disable_adl">]; + let Subjects = SubjectList<[Function]>; rsmith wrote: > Has this syntax been discussed already? If

[PATCH] D143128: [-Wunsafe-buffer-usage][WIP] Fix-Its transforming `&DRE[any]` to `DRE.data() + any`

NoQ added a comment. Why do we prefer `DRE.data() + any` to `&DRE.data()[any]`? It could be much less intrusive this way, and the safety guarantees are the same. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143128/new/ https://reviews.llvm.org/D143128

[PATCH] D143410: [Serialization] Add support for (de)serializing #pragma pack

DHowett-MSFT updated this revision to Diff 495314. DHowett-MSFT added a comment. - Use .copy() like the other nearby code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143410/new/ https://reviews.llvm.org/D143410 Files: clang/include/clang/Sema/

[PATCH] D143300: [randstruct] Don't allow implicit forward decl to stop struct randomization

haowei added a comment. FYI, this patch looks like was pushed into a new "Main" branch instead of the actual "main" branch. It causes git checkout failures on Windows, see error message: warning: encountered old-style '/ssl/certs/ca-bundle.crt' that should be '%(prefix)//ssl/certs/ca-bundle.c

[PATCH] D143128: [-Wunsafe-buffer-usage][WIP] Fix-Its transforming `&DRE[any]` to `DRE.data() + any`

ziqingluo-90 added a comment. In D143128#4108375 , @NoQ wrote: > Why do we prefer `DRE.data() + any` to `&DRE.data()[any]`? It could be much > less intrusive this way, and the safety guarantees are the same. It is actually `(DRE.data() + any)` versus `&

[PATCH] D143446: [clang][deps] Ensure module invocation can be serialized

benlangmuir created this revision. benlangmuir added reviewers: jansvoboda11, Bigcheese. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When reseting modular options, propagate the values from certa

[PATCH] D143128: [-Wunsafe-buffer-usage][WIP] Fix-Its transforming `&DRE[any]` to `(DRE.data() + any)`

ziqingluo-90 updated this revision to Diff 495325. ziqingluo-90 retitled this revision from "[-Wunsafe-buffer-usage][WIP] Fix-Its transforming `&DRE[any]` to `DRE.data() + any`" to "[-Wunsafe-buffer-usage][WIP] Fix-Its transforming `&DRE[any]` to `(DRE.data() + any)`". ziqingluo-90 added a comme

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

stella.stamenova added a comment. In D135128#4107816 , @jansvoboda11 wrote: > @stella.stamenova ping Thanks for the reminder! I spent some time looking for a combination of VS + Win 10 SDK that would work with the new flag, and I believe I've found (a

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

jansvoboda11 added a comment. In D135128#4108588 , @stella.stamenova wrote: > In D135128#4107816 , @jansvoboda11 > wrote: > >> @stella.stamenova ping > > Thanks for the reminder! > > I spent some time looking fo

[PATCH] D143414: [clang] refactor FileManager::GetUniqueIDMapping

jansvoboda11 added inline comments. Comment at: clang/include/clang/Basic/FileManager.h:316 + void getSeenFileEntries( + SmallVectorImpl &Entries) + const; rmaz wrote: > jansvoboda11 wrote: > > Since we're already modifying the two only users of this f

[PATCH] D143414: [clang] refactor FileManager::GetUniqueIDMapping

jansvoboda11 added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:624 + // file entry. + if (Value->V.dyn_cast()) +Entries.push_back(FileEntryRef(Entry)); Nit: I think `dyn_cast()` could be replaced by `is()`. Repository: rG LL

[PATCH] D143410: [Serialization] Add support for (de)serializing #pragma pack

DHowett-MSFT added a comment. Test failures seem related to recent driver changes. There's a commit 6a8a423c1864ced060a7041bf6ada7574f35ad4d that purports to fix them. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D143128: [-Wunsafe-buffer-usage][WIP] Fix-Its transforming `&DRE[any]` to `(DRE.data() + any)`

jkorous added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:162 + InnerMatcher)), + unless(callee(functionDecl(hasAttr(attr::UnsafeBufferUsage); + auto CastOperandMatcher = ziqingluo-90 wrote: > jkorous

[PATCH] D131230: [RISCV] Allow mismatched SmallDataLimit and use Min for conflicting values

dyung added a comment. @joshua-arch1 and @hiraditya this change is causing a test failure on many bots. Can you take a look and revert if you need time to investigate? Failing bots: - https://lab.llvm.org/buildbot/#/builders/183/builds/10688 - https://lab.llvm.org/buildbot/#/builders/249/builds

[PATCH] D143142: [clang][lex] Enable Lexer to grow its buffer

shafik added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:1203 if (L && !L->isLexingRawMode()) - L->Diag(CP-2, diag::trigraph_ignored); + L->Diag(CP - 2 - L->getBuffer().data(), diag::trigraph_ignored); return 0; I wonder do we really

[PATCH] D143142: [clang][lex] Enable Lexer to grow its buffer

shafik added reviewers: aaron.ballman, cor3ntin, tahonermann. shafik added a comment. WG21 is meeting all this week, so a bunch of folks who should take a look at this may not get around to it right away. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang] 3df16e6 - Revert "[RISCV] Allow mismatched SmallDataLimit and use Min for conflicting values"

Author: wangpc Date: 2023-02-07T11:00:25+08:00 New Revision: 3df16e6f6e4d933f3839003e29b8a4b70e4c7ec8 URL: https://github.com/llvm/llvm-project/commit/3df16e6f6e4d933f3839003e29b8a4b70e4c7ec8 DIFF: https://github.com/llvm/llvm-project/commit/3df16e6f6e4d933f3839003e29b8a4b70e4c7ec8.diff LOG: R

[PATCH] D137113: [Clang] refactor CodeGenFunction::EmitAsmStmt NFC

shafik added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2405 + QualType Ty = + CGF.getContext().getIntTypeForBitwidth(Size, /*Signed*/ false); + if (Ty.isNull()) { To be consistent with [bugprone-argument-comment](https://clang.

[PATCH] D131230: [RISCV] Allow mismatched SmallDataLimit and use Min for conflicting values

pcwang-thead added a comment. I have reverted it in 3df16e6f6e4d933f3839003e29b8a4b70e4c7ec8 . Please update `CodeGen/RISCV/rvv-intrinsics-handcrafted/vlenb.c` and reland this patch again. Repository: rG LLVM Github Monorep

[PATCH] D140270: MIPS: fix build from IR files, nan2008 and FpAbi

wzssyqa added a comment. @MaskRay can you help to submit this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140270/new/ https://reviews.llvm.org/D140270 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

ahatanak added a comment. @efriedma do you have any comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142584/new/ https://reviews.llvm.org/D142584 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] b4b95de - MIPS: fix build from IR files, nan2008 and FpAbi

Author: YunQiang Su Date: 2023-02-06T20:36:11-08:00 New Revision: b4b95dee3140e7302d6889173386083978611a12 URL: https://github.com/llvm/llvm-project/commit/b4b95dee3140e7302d6889173386083978611a12 DIFF: https://github.com/llvm/llvm-project/commit/b4b95dee3140e7302d6889173386083978611a12.diff L

[PATCH] D140270: MIPS: fix build from IR files, nan2008 and FpAbi

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4b95dee3140: MIPS: fix build from IR files, nan2008 and FpAbi (authored by wzssyqa, committed by MaskRay). Repository: rG LLVM Github Monorepo C

[PATCH] D142867: [Clang] Add machinery to catch overflow in unary minus outside of a constant expression context

shafik added a comment. In D142867#4108079 , @eaeltsin wrote: > The warning now fires even if overflow is prevented with `if constexpr`: > > if constexpr (width <= 64) { > if constexpr (width == 64) { > return 1; > } > return -static_c

[PATCH] D131230: [RISCV] Allow mismatched SmallDataLimit and use Min for conflicting values

hiraditya added a comment. thanks for reverting it. i'll take care of the test failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131230/new/ https://reviews.llvm.org/D131230 ___ cfe-commits mailing

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

vedgy added a comment. The added, then reverted release note was lost when this revision landed the second time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140756/new/ https://reviews.llvm.org/D140756 __

[PATCH] D143418: [libclang] Add API to set preferred temp dir path

vedgy updated this revision to Diff 495372. vedgy edited the summary of this revision. vedgy added a comment. Address an old inline review comment https://reviews.llvm.org/D139774#inline-1360634 and add a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta updated this revision to Diff 495375. xgupta added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142609/new/ https://reviews.llvm.org/D142609 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaExpr.cpp

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta marked 5 inline comments as done. xgupta added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:13635 + if (ECDHS && ECDHS->getInitVal() != 0 && ECDHS->getInitVal() != 1) +EnumConstantInBoolContext = true; +} nickdesaulniers wrote:

[PATCH] D143461: [ClangScanDeps] Fix data race in `clang-scan-deps` tool

akyrtzi created this revision. Herald added a project: All. akyrtzi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Found using TSan. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D143461 Files: clang/tools/clang-scan

[clang] 84bf4ab - [C++20] [Modules] Allow ADL in dependent context for modules

Author: Chuanqi Xu Date: 2023-02-07T14:09:46+08:00 New Revision: 84bf4ab087b105e0c72da9ec26ad45e9468fa7be URL: https://github.com/llvm/llvm-project/commit/84bf4ab087b105e0c72da9ec26ad45e9468fa7be DIFF: https://github.com/llvm/llvm-project/commit/84bf4ab087b105e0c72da9ec26ad45e9468fa7be.diff LO

[PATCH] D143300: [randstruct] Don't allow implicit forward decl to stop struct randomization

void added a comment. In D143300#4108500 , @haowei wrote: > FYI, this patch looks like was pushed into a new "Main" branch instead of the > actual "main" branch.: > > commit f85a9a6452e8f49f9768d66a86434a88a5891614 (origin/Main) > Author: Bill Wendli

[PATCH] D141785: [Clang][LoongArch] Implement patchable function entry

xen0n added inline comments. Comment at: llvm/lib/Target/LoongArch/LoongArchMCInstLower.cpp:150 + .getAsInteger(10, Num)) +return false; + AP.emitNops(Num); SixWeining wrote: > Seems should return `true`? Consider when verifier is disabl

[PATCH] D143466: [clang][Interp] Fix initializing base class members

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For the given test case, we were trying to initia

[PATCH] D142592: [clang-tidy][libc] Add an inline function checker for the libc project.

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM, thanks for the contribution! Please wait a few days for other reviewers to have a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

qiucf created this revision. qiucf added reviewers: nemanjai, sfertile, amyk, shchenz, lkail, PowerPC. Herald added a subscriber: kbarton. Herald added a project: All. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang has mechanis

<    1   2   3