[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

nickdesaulniers added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:13583 +// bitwise one. +void Sema::diagnoseLogicalInsteadOfBitwise(ExprResult &LHS, ExprResult &RHS, SourceLocation Loc, Instead of `LHS` an

[PATCH] D143414: [clang] refactor FileManager::GetUniqueIDMapping

rmaz created this revision. Herald added a subscriber: mgrang. Herald added a project: All. rmaz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Refactor `FileManager::GetUniqueIDMapping` to populate an array of `OptionalFileEntryRefDegrad

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

kadircet updated this revision to Diff 495159. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142890/new/ https://reviews.llvm.org/D142890 Files: clang-tools-

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

kadircet marked 5 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/ConfigCompileTests.cpp:555 + EXPECT_TRUE(compileAndApply()); + // Defaults to Strict. + EXPECT_EQ(Conf.Diagnostics.Mode, Config::DiagnosticsMode::Fast); --

[PATCH] D142780: [clang] NFCI: Use FileEntryRef in FileManager's UID mapping

rmaz added a comment. In D142780#4087273 , @jansvoboda11 wrote: > Sounds like the easies way out is serializing all `FileEntryRef` objects we > know in deterministic order. How about something like https://reviews.llvm.org/D143414 ? Repository: rG

[PATCH] D143205: [clang] add __has_extension(gnu_asm_goto_with_outputs_full)

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143205/new/ https://reviews.llvm.org/D143205 ___

[PATCH] D143318: [Support] Move ItaniumManglingCanonicalizer and SymbolRemappingReader from Support to ProfileData

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143318/new/ https://reviews.llvm.org/D143318

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

l' attribute. IdentifierInfo *Ident_language, *Ident_defined_in, - *Ident_generated_declaration; + *Ident_generated_declaration, *Ident_USR; /// C++11 contextual keywords. mutable IdentifierInfo *Ident_final; Index: clang/include/clang/Basic/DiagnosticParseKinds.td =

[PATCH] D137113: [Clang] refactor CodeGenFunction::EmitAsmStmt NFC

nickdesaulniers updated this revision to Diff 495174. nickdesaulniers added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137113/new/ https://reviews.llvm.org/D137113 Files: clang/lib/CodeGen/CGStmt.cpp Index: clang/lib/Code

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers updated this revision to Diff 495175. nickdesaulniers added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136497/new/ https://reviews.llvm.org/D136497 Files: clang/docs/LanguageExtensions.rst clang/docs/Rele

[PATCH] D140508: [clang] fix -Wuninitialized for asm goto outputs on indirect edges.

nickdesaulniers updated this revision to Diff 495176. nickdesaulniers added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140508/new/ https://reviews.llvm.org/D140508 Files: clang/lib/Analysis/UninitializedValues.cpp clang/

[PATCH] D143205: [clang] add __has_extension(gnu_asm_goto_with_outputs_full)

nickdesaulniers updated this revision to Diff 495178. nickdesaulniers added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143205/new/ https://reviews.llvm.org/D143205 Files: clang/docs/LanguageExtensions.rst clang/include/c

[PATCH] D143415: LibclangTest: remove libclang-test-* tmp dir reliably

vedgy created this revision. Herald added a project: All. vedgy requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Temporary directories created by two LibclangReparseTest tests - ReparseWithModule and clang_parseTranslationUnit2FullArgv - rem

[PATCH] D142905: Change multilib selection algorithm

peter.smith added a comment. A couple of small stylisitic suggestions. Comment at: clang/include/clang/Driver/Multilib.h:31 public: - using flags_list = std::vector; + using flags_list = std::set; + using arg_list = std::vector; would flags_set be a better

[PATCH] D143093: [clangd] #undef macros inside preamble patch

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:721 + // re-definition warnings. + if (TD.Directive == tok::pp_define) +Patch << "#undef " << TD.MacroName << '\n'; i know we've discussed emitting all the `#undef

[PATCH] D143093: [clangd] #undef macros inside preamble patch

kadircet updated this revision to Diff 495185. kadircet added a comment. - Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143093/new/ https://reviews.llvm.org/D143093 Files: clang-tools-extra/clangd/Preamble.cpp clang-tools-extra/c

[PATCH] D143241: [Clang] Reset FP options before function instantiations

efriedma added a comment. Using the FPOptions from the beginning of the file doesn't seem much better than the FPOptions at the end of the file. Don't we want to use the FPOptions from the point of definition of the template? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143418: [libclang] Add API to set preferred temp dir path

vedgy created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. vedgy requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added projects: clang, clang-tools-extra. TempPCHFile::create() calls llvm::sys::fs::createT

[PATCH] D143414: [clang] refactor FileManager::GetUniqueIDMapping

rmaz updated this revision to Diff 495191. rmaz added a comment. Sort by UIDs, then Name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143414/new/ https://reviews.llvm.org/D143414 Files: clang/include/clang/Basic/FileManager.h clang/lib/Basic/

[PATCH] D143300: [randstruct] Don't allow implicit forward decl to stop struct randomization

void added a comment. In D143300#4107132 , @nickdesaulniers wrote: > In D143300#4104469 , @MaskRay wrote: > >> `clang/test/CodeGen/init-randomized-struct-fwd-decl.c` passes without this >> patch. Is it correct?

[PATCH] D139774: [libclang] Add API to set temporary directory location

vedgy abandoned this revision. vedgy added a comment. D143418 implements my latest idea described in the previous comment. Let us continue the discussion there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139774

[PATCH] D143300: [randstruct] Don't allow implicit forward decl to stop struct randomization

void updated this revision to Diff 495194. void added a comment. Fix test and add check for EnumDecl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143300/new/ https://reviews.llvm.org/D143300 Files: clang/lib/Sema/SemaDecl.cpp clang/test/Code

[PATCH] D143300: [randstruct] Don't allow implicit forward decl to stop struct randomization

void added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:18891 +// incomplete definition. +if (const auto *RD = dyn_cast(D)) + return !RD->isCompleteDefinition(); nickdesaulniers wrote: > what about `EnumDecl`s? I suspect the s

[PATCH] D143021: [OpenMP 5.2] Deprecate 'destroy' clause without argument for 'depobj' construct

mdfazlay updated this revision to Diff 495196. mdfazlay added a comment. @ABataev, I have addressed your last two comments and updated the diff. Please take a look at your convenient time :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143021/new/ https://reviews.llvm.org/D143021 Fil

[PATCH] D143300: [randstruct] Don't allow implicit forward decl to stop struct randomization

nickdesaulniers added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:18891 +// incomplete definition. +if (const auto *RD = dyn_cast(D)) + return !RD->isCompleteDefinition(); void wrote: > nickdesaulniers wrote: > > what about `

[PATCH] D143300: [randstruct] Don't allow implicit forward decl to stop struct randomization

nickdesaulniers added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:18891 +// incomplete definition. +if (const auto *RD = dyn_cast(D)) + return !RD->isCompleteDefinition(); nickdesaulniers wrote: > void wrote: > > nickdesaulni

[PATCH] D143414: [clang] refactor FileManager::GetUniqueIDMapping

jansvoboda11 added inline comments. Comment at: clang/include/clang/Basic/FileManager.h:316 + void getSeenFileEntries( + SmallVectorImpl &Entries) + const; Since we're already modifying the two only users of this function, maybe we could use `Optional

[PATCH] D143410: [Serialization] Add support for (de)serializing #pragma pack

DHowett-MSFT created this revision. Herald added a project: All. DHowett-MSFT updated this revision to Diff 495195. DHowett-MSFT added a comment. DHowett-MSFT published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Add a test DHowett-MSFT adde

[PATCH] D143287: [Clang][x86] Change x86 cast intrinsics to use __builtin_nondeterministic_value

ManuelJBrito added a comment. In D143287#4103597 , @craig.topper wrote: > We have a couple bugs that show (freeze (poison)) doesn't work past > SelectionDAG. Is that a concern here? The most recent > https://github.com/llvm/llvm-project/issues/60429 I

[clang] 2155195 - [Coverage] Map regions from system headers

Author: Gulfem Savrun Yeniceri Date: 2023-02-06T18:12:01Z New Revision: 2155195131a57f2f01e7cfabb85bb027518c2dc6 URL: https://github.com/llvm/llvm-project/commit/2155195131a57f2f01e7cfabb85bb027518c2dc6 DIFF: https://github.com/llvm/llvm-project/commit/2155195131a57f2f01e7cfabb85bb027518c2dc6.d

[PATCH] D143304: [Coverage] Map regions from system headers

This revision was automatically updated to reflect the committed changes. Closed by commit rG2155195131a5: [Coverage] Map regions from system headers (authored by gulfem). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143304/new/ https://reviews.llv

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis marked an inline comment as done. TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1342-1382 +/// Create a constant string location from the MLIR Location information. +static llvm::Constant * +createSourceLoc

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

wift", "module", generated_declaration))); // expected-error {{expected 'language', 'defined_in', 'generated_declaration', or 'USR'}} void f17(void) -__attribute__((external_source_symbol(language="Swift", "generated_declaration")));

[PATCH] D143300: [randstruct] Don't allow implicit forward decl to stop struct randomization

void updated this revision to Diff 495204. void marked an inline comment as done. void added a comment. Use TagDecl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143300/new/ https://reviews.llvm.org/D143300 Files: clang/lib/Sema/SemaDecl.cpp

[PATCH] D143287: [Clang][x86] Change x86 cast intrinsics to use __builtin_nondeterministic_value

ManuelJBrito added a comment. In D143287#4104056 , @RKSimon wrote: > What do we gain from using __builtin_nondeterministic_value instead of just > setzero? https://godbolt.org/z/zrb6858Mr __builtin_nondeterministic_value is lowered to freeze(poison) Th

[PATCH] D143414: [clang] refactor FileManager::GetUniqueIDMapping

jansvoboda11 added a comment. In general, I think this approach makes sense. Comment at: clang/lib/Serialization/ASTWriter.cpp:1925 - for (unsigned UID = 0, LastUID = FilesByUID.size(); UID != LastUID; ++UID) { -const FileEntry *File = FilesByUID[UID]; -if (!File) -

[PATCH] D143300: [randstruct] Don't allow implicit forward decl to stop struct randomization

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGen/init-randomized-struct-fwd-decl.c:23 + +// CHECK-LABEL: define {{.*}}@t1 +// CHECK-NOT: getelementptr inbounds %struct.foo, ptr %3, i32 0

[PATCH] D143205: [clang] add __has_extension(gnu_asm_goto_with_outputs_full)

void accepted this revision. void added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143205/new/ https://reviews.llvm.org/D143205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D129951: adds `__disable_adl` attribute

cjdb added a comment. Ping @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129951/new/ https://reviews.llvm.org/D129951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D143021: [OpenMP 5.2] Deprecate 'destroy' clause without argument for 'depobj' construct

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143021/new/ https://reviews.llvm.org/D143021 ___ cfe-commits mailing list cfe-commits@l

[clang] 3f33e6b - [LinkerWrapper] Output a temp file with the wrapper bitcode

Author: Joseph Huber Date: 2023-02-06T12:34:00-06:00 New Revision: 3f33e6b1f4d08dd3e4dec91ae4d8e4cf292f0acc URL: https://github.com/llvm/llvm-project/commit/3f33e6b1f4d08dd3e4dec91ae4d8e4cf292f0acc DIFF: https://github.com/llvm/llvm-project/commit/3f33e6b1f4d08dd3e4dec91ae4d8e4cf292f0acc.diff

[PATCH] D143414: [clang] refactor FileManager::GetUniqueIDMapping

rmaz added inline comments. Comment at: clang/include/clang/Basic/FileManager.h:316 + void getSeenFileEntries( + SmallVectorImpl &Entries) + const; jansvoboda11 wrote: > Since we're already modifying the two only users of this function, maybe we > cou

[PATCH] D143300: [randstruct] Don't allow implicit forward decl to stop struct randomization

nickdesaulniers added inline comments. Comment at: clang/test/CodeGen/init-randomized-struct-fwd-decl.c:2 +// RUN: %clang_cc1 -triple=x86_64-unknown-linux -emit-llvm -frandomize-layout-seed=1234567890abcdef < %s | FileCheck %s +// RUN: %clang_cc1 -triple=x86_64-unknown-linux -em

[clang] 630266a - [Fuchsia] Simplified the stage2 build setup

Author: Haowei Wu Date: 2023-02-06T10:46:31-08:00 New Revision: 630266aed342797d6413a69b8792567fc6263501 URL: https://github.com/llvm/llvm-project/commit/630266aed342797d6413a69b8792567fc6263501 DIFF: https://github.com/llvm/llvm-project/commit/630266aed342797d6413a69b8792567fc6263501.diff LOG

[PATCH] D143410: [Serialization] Add support for (de)serializing #pragma pack

mikerice added inline comments. Comment at: clang/test/PCH/delayed-template-with-pragma-pack.cpp:14 +int func() { +#pragma pack(push, 1) + struct s { short a; T b; }; Your test should include testing of the slot string too, so we are sure all fields are seriali

[PATCH] D143288: [Fuchsia] Simplified the stage2 build setup

This revision was automatically updated to reflect the committed changes. Closed by commit rG630266aed342: [Fuchsia] Simplified the stage2 build setup (authored by haowei). Changed prior to commit: https://reviews.llvm.org/D143288?vs=494694&id=495216#toc Repository: rG LLVM Github Monorepo

[PATCH] D143414: [clang] refactor FileManager::GetUniqueIDMapping

jansvoboda11 added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:625-627 +Entries.push_back( +FileEntryRef(*reinterpret_cast( +Value->V.get(; rmaz wrote: > jansvoboda11 wrote: > > Why is this necessary? IIUC,

[PATCH] D143025: [Clang] Add llvm-mt and llvm-rc to Clang bootstrap dependency

haowei updated this revision to Diff 495221. haowei marked an inline comment as done. haowei retitled this revision from "[Fuchsia] Add llvm-mt and llvm-rc to clang bootstrap dependency" to "[Clang] Add llvm-mt and llvm-rc to Clang bootstrap dependency". haowei edited the summary of this revision

[PATCH] D143300: [randstruct] Don't allow implicit forward decl to stop struct randomization

void added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:18891 +// incomplete definition. +if (const auto *RD = dyn_cast(D)) + return !RD->isCompleteDefinition(); nickdesaulniers wrote: > nickdesaulniers wrote: > > void wrote:

[clang] dc1c891 - [Clang] Add llvm-mt and llvm-rc to Clang bootstrap dependency

Author: Haowei Wu Date: 2023-02-06T11:36:27-08:00 New Revision: dc1c8917afd3f2b306797890a56be66087feb832 URL: https://github.com/llvm/llvm-project/commit/dc1c8917afd3f2b306797890a56be66087feb832 DIFF: https://github.com/llvm/llvm-project/commit/dc1c8917afd3f2b306797890a56be66087feb832.diff LOG

[PATCH] D143025: [Clang] Add llvm-mt and llvm-rc to Clang bootstrap dependency

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdc1c8917afd3: [Clang] Add llvm-mt and llvm-rc to Clang bootstrap dependency (authored by haowei). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D143427: [clang] NFC: Remove GCC 5.1 workaround in FileEntry

jansvoboda11 created this revision. jansvoboda11 added a reviewer: benlangmuir. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We no longer support GCC 5.1 (D12

[PATCH] D143428: [clang][deps] Fix race condition

jansvoboda11 created this revision. jansvoboda11 added a reviewer: steven_wu. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D140176

[PATCH] D142933: Add -print-multi-selection-flags argument

peter.smith added inline comments. Comment at: clang/include/clang/Driver/Options.td:4162 def print_multi_lib : Flag<["-", "--"], "print-multi-lib">; +def print_multi_selection_flags : Flag<["-", "--"], "print-multi-selection-flags-experimental">, + HelpText<"Print the flags u

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

jansvoboda11 added a comment. @stella.stamenova ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135128/new/ https://reviews.llvm.org/D135128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D143430: [C2x] Implement the `unreachable` macro for WG14 N2826

aaron.ballman created this revision. aaron.ballman added reviewers: jyknight, clang-language-wg, efriedma. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. This exposes `__builtin_unreachable` as the expansion for the `unreachable` macro

[clang] d1d93da - [Clang] Fix __ptr32 arguments passed to builtins

Author: Ariel Burton Date: 2023-02-06T19:53:13Z New Revision: d1d93da701b1609bdd992e57be60bb58c6d080cc URL: https://github.com/llvm/llvm-project/commit/d1d93da701b1609bdd992e57be60bb58c6d080cc DIFF: https://github.com/llvm/llvm-project/commit/d1d93da701b1609bdd992e57be60bb58c6d080cc.diff LOG:

[PATCH] D142048: [Phabricator] Fix __ptr32 arguments passed to builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rGd1d93da701b1: [Clang] Fix __ptr32 arguments passed to builtins (authored by Ariel-Burton, committed by Kai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[PATCH] D143300: [randstruct] Don't allow implicit forward decl to stop struct randomization

MaskRay added inline comments. Comment at: clang/test/CodeGen/init-randomized-struct-fwd-decl.c:2 +// RUN: %clang_cc1 -triple=x86_64-unknown-linux -emit-llvm -frandomize-layout-seed=1234567890abcdef < %s | FileCheck %s +// RUN: %clang_cc1 -triple=x86_64-unknown-linux -emit-llvm

[PATCH] D143410: [Serialization] Add support for (de)serializing #pragma pack

DHowett-MSFT added a comment. While this fixes the assertion failure and the immediate issue of whether packing _works_ inside delay-parsed templates in a PCH, it does reveal a follow-on issue that I can't quite trace out. c++ template void foo() { #pragma pack(push, 1) #pragma pack(

[PATCH] D143128: [-Wunsafe-buffer-usage][WIP] Fix-Its transforming `&DRE[any]` to `DRE.data() + any`

jkorous added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:162 + InnerMatcher)), + unless(callee(functionDecl(hasAttr(attr::UnsafeBufferUsage); + auto CastOperandMatcher = I am just wondering how does

[PATCH] D143300: [randstruct] Don't allow implicit forward decl to stop struct randomization

void updated this revision to Diff 495237. void added a comment. Remove extra line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143300/new/ https://reviews.llvm.org/D143300 Files: clang/lib/Sema/SemaDecl.cpp clang/test/CodeGen/init-randomize

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

ziqingluo-90 updated this revision to Diff 495250. ziqingluo-90 added a comment. Fixed a bug in manipulating source locations: Using `SourceLocation::getLocWithOffset` to get a new source location `L` with a relative offset is convenient. But it requires extra care to make sure that `L` has the

[PATCH] D143300: [randstruct] Don't allow implicit forward decl to stop struct randomization

nickdesaulniers accepted this revision. nickdesaulniers added a comment. Thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143300/new/ https://reviews.llvm.org/D143300 ___ cfe-commits m

[clang] 6ab9f1e - [Driver] Fix -fsanitize-address-stack-use-after-scope after D142606

Author: Fangrui Song Date: 2023-02-06T12:54:34-08:00 New Revision: 6ab9f1e59371fe96ca3fda1a26a28ae0b7caf637 URL: https://github.com/llvm/llvm-project/commit/6ab9f1e59371fe96ca3fda1a26a28ae0b7caf637 DIFF: https://github.com/llvm/llvm-project/commit/6ab9f1e59371fe96ca3fda1a26a28ae0b7caf637.diff

[PATCH] D143318: [Support] Move ItaniumManglingCanonicalizer and SymbolRemappingReader from Support to ProfileData

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6c8fe9658236: [Support] Move ItaniumManglingCanonicalizer and SymbolRemappingReader from… (authored by RKSimon). Changed prior to commit: https://

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

MaskRay added a comment. (The first line of 0ffaffcaac97de31e1b0e7e80c4f7cab724eda20 should have mentioned `Lazyly initialize uncommon toolchain detector`. You can add `Reland` prefix or add the message in the body of the com

[PATCH] D143414: [clang] refactor FileManager::GetUniqueIDMapping

rmaz updated this revision to Diff 495259. rmaz added a comment. Don't return virtual file entries Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143414/new/ https://reviews.llvm.org/D143414 Files: clang/include/clang/Basic/FileManager.h clang/

[PATCH] D137756: [z/OS][pg] Throw error when using -pg on z/OS

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/test/Driver/zos-profiling-error.c:1 +// Check failed cases + Delete this comment. It does not help reading the test. ==

[clang] 4f01266 - [HIP] Update test hip-header.hip

Author: Yaxun (Sam) Liu Date: 2023-02-06T16:30:47-05:00 New Revision: 4f01266954b12395add2a6a87ef589126cb147fa URL: https://github.com/llvm/llvm-project/commit/4f01266954b12395add2a6a87ef589126cb147fa DIFF: https://github.com/llvm/llvm-project/commit/4f01266954b12395add2a6a87ef589126cb147fa.dif

[PATCH] D143412: [HIP] Update test hip-header.hip

This revision was automatically updated to reflect the committed changes. Closed by commit rG4f01266954b1: [HIP] Update test hip-header.hip (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143412/new/

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

ziqingluo-90 updated this revision to Diff 495263. ziqingluo-90 added a comment. To avoid emitting incorrect fix-its for array subscripts on `span` objects: - For unsafe operations of the form `s[e]` where `s` is being transformed to be a `span`, we only emit fix-its for `s[e]` when `e` is a no

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:703 + case Strategy::Kind::Span: +return FixItList{}; + case Strategy::Kind::Wontfix: jkorous wrote: > jkorous wrote: > > jkorous wrote: > > > I am afraid I

[PATCH] D142592: [clang-tidy][libc] Add an inline function checker for the libc project.

sivachandra updated this revision to Diff 495265. sivachandra marked 14 inline comments as done. sivachandra added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142592/new/ https://reviews.llvm.org/D142592 Files: cla

[PATCH] D143410: [Serialization] Add support for (de)serializing #pragma pack

mikerice added a comment. In D143410#4107862 , @DHowett-MSFT wrote: > While this fixes the assertion failure and the immediate issue of whether > packing _works_ inside delay-parsed templates in a PCH, it does reveal a > follow-on issue that I can't qu

[PATCH] D137756: [z/OS][pg] Throw error when using -pg on z/OS

francii updated this revision to Diff 495267. francii added a comment. Rebase and test case update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137756/new/ https://reviews.llvm.org/D137756 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/te

[PATCH] D142867: [Clang] Add machinery to catch overflow in unary minus outside of a constant expression context

eaeltsin added a comment. The warning now fires even if it is prevent with `if constexpr`: if constexpr (width <= 64) { if constexpr (width == 64) { return 1; } return -static_cast(uint64_t{1} << (width - 1)); } https://godbolt.org/z/M3xdcKd3M Repository: rG LLVM Github

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta updated this revision to Diff 495268. tkuchta added a comment. Please find the patch for strsep only attached Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141389/new/ https://reviews.llvm.org/D141389 Files: compiler-rt/lib/dfsan/dfsan_cus

[PATCH] D141098: [clang-format][NFC] Set LineEnding to LF in config files

owenpan added a comment. Why don't we fix the buildbot instead? Why does it use a pre-16 version to test 16 source? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141098/new/ https://reviews.llvm.org/D141098 ___

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

jkorous accepted this revision. jkorous added a comment. LGTM Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139737/new/ https://reviews.llvm.org/D139737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] f85a9a6 - [randstruct] Don't allow implicit forward decl to stop struct randomization

Author: Bill Wendling Date: 2023-02-06T14:26:32-08:00 New Revision: f85a9a6452e8f49f9768d66a86434a88a5891614 URL: https://github.com/llvm/llvm-project/commit/f85a9a6452e8f49f9768d66a86434a88a5891614 DIFF: https://github.com/llvm/llvm-project/commit/f85a9a6452e8f49f9768d66a86434a88a5891614.diff

[PATCH] D143300: [randstruct] Don't allow implicit forward decl to stop struct randomization

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf85a9a6452e8: [randstruct] Don't allow implicit forward decl to stop struct randomization (authored by void). Repository: rG LLVM Github Monorepo

[PATCH] D143287: [Clang][x86] Change x86 cast intrinsics to use __builtin_nondeterministic_value

craig.topper added a comment. In D143287#4107439 , @ManuelJBrito wrote: > In D143287#4103597 , @craig.topper > wrote: > >> We have a couple bugs that show (freeze (poison)) doesn't work past >> SelectionDAG. Is

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

clayborg added a comment. Changes look fine to me. I would like someone that specializes in the expression parser to give the final ok though. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangASTImporter.cpp:551 const LayoutI

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: sammccall, ilya-biryukov. DmitryPolukhin added projects: clang, clang-tools-extra. Herald added subscribers: s.egerton, kadircet, arphaman, simoncook. Herald added a project: All. DmitryPolukhin requested review of this revision.

[PATCH] D129951: adds `__disable_adl` attribute

rsmith added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4132 +def DisableADL : InheritableAttr { + let Spellings = [Keyword<"__disable_adl">]; + let Subjects = SubjectList<[Function]>; Has this syntax been discussed already? If not, why did

[clang] f9ff498 - [Fuchsia] Simplify Fuchsia stage2 toolchain setup

Author: Haowei Wu Date: 2023-02-06T14:58:53-08:00 New Revision: f9ff49882a65ab26ab347f4df8f2a58368d37185 URL: https://github.com/llvm/llvm-project/commit/f9ff49882a65ab26ab347f4df8f2a58368d37185 DIFF: https://github.com/llvm/llvm-project/commit/f9ff49882a65ab26ab347f4df8f2a58368d37185.diff LOG

[clang] 5fcdab0 - [Fuchsia] Build windows runtimes using cross compilation on Linux

Author: Haowei Wu Date: 2023-02-06T14:58:53-08:00 New Revision: 5fcdab04c25039b5acb988568e08da9fc65c40fc URL: https://github.com/llvm/llvm-project/commit/5fcdab04c25039b5acb988568e08da9fc65c40fc DIFF: https://github.com/llvm/llvm-project/commit/5fcdab04c25039b5acb988568e08da9fc65c40fc.diff LOG

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rG5fcdab04c250: [Fuchsia] Build windows runtimes using cross compilation on Linux (authored by haowei). Changed prior to commit: https://reviews.llvm.org/D141738?vs=493766&id=495281#toc Repository: rG

[clang] 14ca2e6 - Revert "[Fuchsia] Simplify Fuchsia stage2 toolchain setup"

Author: Haowei Wu Date: 2023-02-06T15:00:59-08:00 New Revision: 14ca2e68ff4c8cb03bd8f937ef792a2b638d0258 URL: https://github.com/llvm/llvm-project/commit/14ca2e68ff4c8cb03bd8f937ef792a2b638d0258 DIFF: https://github.com/llvm/llvm-project/commit/14ca2e68ff4c8cb03bd8f937ef792a2b638d0258.diff LOG

[PATCH] D143128: [-Wunsafe-buffer-usage][WIP] Fix-Its transforming `&DRE[any]` to `DRE.data() + any`

ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:508 + hasUnaryOperand(arraySubscriptExpr( + hasBase(ignoringParenImpCasts(declRefExpr()) +.bind(UPCAddressofArraySubscriptTag

[PATCH] D143410: [Serialization] Add support for (de)serializing #pragma pack

DHowett-MSFT updated this revision to Diff 495285. DHowett-MSFT added a comment. @mikerice Alright, it turns out that PragmaPackAlignStorage isn't suitable for this (actually, I'm not sure what it _is_ suitable for) because it's deleted by the time the template gets parsed again. The `push, slot

[PATCH] D143410: [Serialization] Add support for (de)serializing #pragma pack

DHowett-MSFT marked 2 inline comments as done. DHowett-MSFT added a comment. The new test checks how tightly things were packed across a stack of packs, pushed and popped. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143410/new/ https://review

[PATCH] D143128: [-Wunsafe-buffer-usage][WIP] Fix-Its transforming `&DRE[any]` to `DRE.data() + any`

ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:162 + InnerMatcher)), + unless(callee(functionDecl(hasAttr(attr::UnsafeBufferUsage); + auto CastOperandMatcher = jkorous wrote: > I am ju

[PATCH] D143439: [RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension

craig.topper added a comment. Description says "XTHeadBs" instead of "XTHeadBb" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143439/new/ https://reviews.llvm.org/D143439 ___ cfe-commits mailing list cfe

[PATCH] D141098: [clang-format][NFC] Set LineEnding to LF in config files

sunho added a comment. I think buildbot is "formatting" the patch using clang-format-15. The tests of clang-format would be done with latest code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141098/new/ https://reviews.llvm.org/D141098

[PATCH] D143439: [RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension

philipp.tomsich added a comment. Thanks for spotting this. Fixed in our local git-tree as well, so it doesn't sneak back in during the merge. I am blind to the difference between Ba, Bb, and Bs by now -- with Ba and Bs being too close to each other on the keyboard for comfort!. Repository:

[clang] 28bd84f - [RISCV] Allow mismatched SmallDataLimit and use Min for conflicting values

Author: AdityaK Date: 2023-02-06T15:32:45-08:00 New Revision: 28bd84f55fc087d4aefd3fe5360f8648d1d50980 URL: https://github.com/llvm/llvm-project/commit/28bd84f55fc087d4aefd3fe5360f8648d1d50980 DIFF: https://github.com/llvm/llvm-project/commit/28bd84f55fc087d4aefd3fe5360f8648d1d50980.diff LOG:

[PATCH] D131230: [RISCV] Allow mismatched SmallDataLimit and use Min for conflicting values

This revision was automatically updated to reflect the committed changes. Closed by commit rG28bd84f55fc0: [RISCV] Allow mismatched SmallDataLimit and use Min for conflicting values (authored by AdityaK <1894981+hiradi...@users.noreply.github.com>). Herald added a project: clang. Herald added a s

[PATCH] D142473: [UTC] Add --version argument

bogner added a comment. Multiple people had concerns with the added complexity of having to maintain historical versions of behaviour here (a concern which I share), and absolutely none of them accepted the revision or commented after the comment that you don’t think it’ll be too bad in practic

<    1   2   3   >