[PATCH] D143160: [include-mapping] Introduce a human-edit CXXSymbolMapping file

kadircet added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/CXXSymbolMap.inc:12 +SYMBOL(consume_header, std::, ) // declared +SYMBOL(consume_header, std::, ) // defined +SYMBOL(generate_header, std::, ) i feel like cppreference is wrong he

[PATCH] D142871: [clangd] Semantic highlighting for constrained-parameter

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/FindTarget.cpp:1047 + bool TraverseTypeConstraint(const TypeConstraint *TC) { +Out(ReferenceLoc{TC->getNestedNameSpecifier

[PATCH] D142871: [clangd] Semantic highlighting for constrained-parameter

nridge updated this revision to Diff 495015. nridge added a comment. address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142871/new/ https://reviews.llvm.org/D142871 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-e

[PATCH] D140915: [clangd] Fix getQueryScopes for using-directive with inline namespace

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang-tools-extra/clangd/CodeComplete.cpp:675 +std::vector EnclosingAtFront; +if (EnclosingNamespace.has_value()) { + EnclosingAtFr

[clang-tools-extra] 6c46913 - [clangd] Semantic highlighting for constrained-parameter

Author: Nathan Ridge Date: 2023-02-06T03:44:36-05:00 New Revision: 6c4691391419814d0fd8fcd92c99026813c35b47 URL: https://github.com/llvm/llvm-project/commit/6c4691391419814d0fd8fcd92c99026813c35b47 DIFF: https://github.com/llvm/llvm-project/commit/6c4691391419814d0fd8fcd92c99026813c35b47.diff

[PATCH] D142871: [clangd] Semantic highlighting for constrained-parameter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6c4691391419: [clangd] Semantic highlighting for constrained-parameter (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D143160: [include-mapping] Introduce a human-edit CXXSymbolMapping file

kadircet added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/CXXSymbolMap.inc:1 +//===-- CXXSymbolMap.inc *- C++ -*-===// +// also maybe rename this to, `AlternativeHeaderMap.inc` ?

[PATCH] D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM, thanks for the fix! Might be good to wait a few days for other reviewers to have a look or give suggestions on how to improve the issue of having to do one parameter at a t

[clang] 7c97c57 - [Modules] Recreate file manager for ftime-trace when compiling a module

Author: Chuanqi Xu Date: 2023-02-06T17:17:09+08:00 New Revision: 7c97c574cc795705737cd0b73daf6867406fe624 URL: https://github.com/llvm/llvm-project/commit/7c97c574cc795705737cd0b73daf6867406fe624 DIFF: https://github.com/llvm/llvm-project/commit/7c97c574cc795705737cd0b73daf6867406fe624.diff LO

[PATCH] D143274: [clangd] Remove the direct use of StdSymbolMapping.inc usage.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/CanonicalIncludes.cpp:736 void CanonicalIncludes::addSystemHeadersMapping(const LangOptions &Language) { if (Language.CPlusPlus) { +static const auto *Symbols = []() { what about g

[PATCH] D143160: [include-mapping] Introduce a human-edit CXXSymbolMapping file

hokein updated this revision to Diff 495032. hokein marked an inline comment as done. hokein edited the summary of this revision. hokein added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143160/new/ https://revi

[PATCH] D143160: [include-mapping] Introduce a human-edit CXXSymbolMapping file

hokein added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/CXXSymbolMap.inc:1 +//===-- CXXSymbolMap.inc *- C++ -*-===// +// kadircet wrote: > also maybe rename this to, `AlternativeHeaderMap.inc` ? Re

[PATCH] D143280: [include-mapping] Better #includes support for std input/output symbols

kadircet added inline comments. Comment at: clang/tools/include-mapping/gen_std.py:160 + headers = [sym_header] + if symbol.name in iosfwd_symbols: +headers.append("") i think putting `iostream` before `iosfwd` in the alternative list makes more sense. WDY

[PATCH] D107290: [RISCV] Add support for the vscale_range attribute

frasercrmck abandoned this revision. frasercrmck added a comment. Herald added a subscriber: luke. Superseded by D139873 amongst others Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107290/new/ https://reviews.llv

[PATCH] D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr

njames93 requested changes to this revision. njames93 added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringCStrCheck.cpp:186-187 + traverse(TK_AsIs, + callExpr(anyOf(callee(fu

[PATCH] D143214: [include-mapping] Add C-compatibility symbol entries.

kadircet added inline comments. Comment at: clang/tools/include-mapping/gen_std.py:107-108 symbols = cppreference_parser.GetSymbols(parse_pages) - + # C++ form of the C standard headers. + c_style_headers = { +"", Comment at: clang/

[PATCH] D143274: [clangd] Remove the direct use of StdSymbolMapping.inc usage.

hokein updated this revision to Diff 495036. hokein marked an inline comment as done. hokein added a comment. address review comment: remove StdSymbolMapping in the CanonicalIncluedes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143274/new/ https

[PATCH] D143274: [clangd] Remove the direct use of StdSymbolMapping.inc usage.

hokein added inline comments. Comment at: clang-tools-extra/clangd/index/CanonicalIncludes.cpp:736 void CanonicalIncludes::addSystemHeadersMapping(const LangOptions &Language) { if (Language.CPlusPlus) { +static const auto *Symbols = []() { kadircet wrote

[PATCH] D143375: clang-tidy: Count template constructors in modernize-use-default-member-init

MarcoFalke created this revision. MarcoFalke added a project: clang-tools-extra. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. MarcoFalke requested review of this revision. Herald added a subscriber: cfe-commits. The check should bomb out

[PATCH] D143194: [clang][analyzer] Make messages of StdCLibraryFunctionsChecker user-friendly

balazske updated this revision to Diff 495042. balazske added a comment. Replaced "of function" with "to" in checker messages. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143194/new/ https://reviews.llvm.org/D143194 Files: clang/lib/StaticAnal

[PATCH] D143160: [include-mapping] Introduce a human-edit CXXSymbolMapping file

kadircet added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/StdAlternativeHeaderMap.inc:3 +// +// This is a hand-curated list for C++ symbols (e.g. provided by multiple +// headers), to address the short comings of cppreference or automated

[PATCH] D143280: [include-mapping] Better #includes support for std input/output symbols

hokein updated this revision to Diff 495047. hokein marked 2 inline comments as done. hokein added a comment. address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143280/new/ https://reviews.llvm.org/D143280 Files: clang/includ

[PATCH] D143280: [include-mapping] Better #includes support for std input/output symbols

hokein added inline comments. Comment at: clang/tools/include-mapping/gen_std.py:160 + headers = [sym_header] + if symbol.name in iosfwd_symbols: +headers.append("") kadircet wrote: > i think putting `iostream` before `iosfwd` in the alternative list makes

[PATCH] D143274: [clangd] Remove the direct use of StdSymbolMapping.inc usage.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/CanonicalIncludes.cpp:711 +return ""; + // There are multiple headers for size_t, pick one. + if (QName == "std::size_t") i think the comment is misleading. as if we had some alterna

[PATCH] D143214: [include-mapping] Add C-compatibility symbol entries.

hokein updated this revision to Diff 495056. hokein marked 2 inline comments as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143214/new/ https://reviews.llvm.org/D143214 Files: clang/include/clang/

[PATCH] D142014: [clangd] fix wrong CalleeArgInfo in the hover

v1nh1shungry added a comment. Thanks for the review! @kadircet Would you mind having a look at if there're any concerns about the current code change, @nridge, @tom-anders, and @adamcz? Thanks a lot! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D141472: [clang][Interp] Add function pointers

tbaeder added a comment. > Member pointers (for functions or for data) are weird in that they're not the > typical pointer width. They're actually a pointer and between one-to-three > other fields in a trenchcoat, depending on the circumstances. You generally > need the function pointer, but yo

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6fa2abf90886: Lazyly initialize uncommon toolchain detector (autho

[clang] 6fa2abf - Lazyly initialize uncommon toolchain detector

Author: serge-sans-paille Date: 2023-02-06T12:03:00+01:00 New Revision: 6fa2abf90886f18472c87bc9bffbcdf4f73c465e URL: https://github.com/llvm/llvm-project/commit/6fa2abf90886f18472c87bc9bffbcdf4f73c465e DIFF: https://github.com/llvm/llvm-project/commit/6fa2abf90886f18472c87bc9bffbcdf4f73c465e.d

[PATCH] D143144: [clang][lex] Add TryGrowLexerBuffer/SourceFileGrower

sunho created this revision. Herald added a project: All. sunho retitled this revision from "asdfasdf" to "[clang][lex] Add TryExpandBuffer callback". sunho edited the summary of this revision. sunho updated this revision to Diff 494978. sunho added a comment. sunho updated this revision to Diff 4

[PATCH] D143148: [clang-repl] Add basic multiline input support

sunho created this revision. Herald added a project: All. sunho retitled this revision from "Add multiline support in clang-repl" to "[clang-repl] Add basic multiline support". sunho edited the summary of this revision. sunho updated this revision to Diff 494983. sunho added a comment. sunho updat

[PATCH] D142630: [clang][Interp] Implement virtual function calls

tbaeder updated this revision to Diff 495059. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142630/new/ https://reviews.llvm.org/D142630 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Context.cpp clang/lib/AST/Interp/Context.h clang/lib/AST/Interp/Function.h

[PATCH] D143274: [clangd] Remove the direct use of StdSymbolMapping.inc usage.

hokein updated this revision to Diff 495065. hokein marked 2 inline comments as done. hokein added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143274/new/ https://reviews.llvm.org/D143274 Files: clang-tools-e

[PATCH] D143274: [clangd] Remove the direct use of StdSymbolMapping.inc usage.

hokein updated this revision to Diff 495066. hokein added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143274/new/ https://reviews.llvm.org/D143274 Files: clang-tools-extra/clangd/index/CanonicalIncludes.cpp clang-tools-extr

[PATCH] D141098: [clang-format][NFC] Set LineEnding to LF in config files

sunho added a comment. This seems to be causing builtbot lint script error: https://buildkite.com/llvm-project/premerge-checks/builds/134501#01862630-8fa9-487c-99b1-9addbe6257d0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141098/new/ https://rev

[PATCH] D142878: Add testing for Fuchsia multilib

michaelplatings abandoned this revision. michaelplatings added a comment. > A more scalable approach would be to check only the minimal set of > combination necessary to achieve full coverage. In that case the testing you've already got in place in `clang/test/Driver/fuchsia.cpp` is adequate. T

[clang] 9166842 - [clang][NFC] Fix a documentation typo

Author: Timm Bäder Date: 2023-02-06T12:37:36+01:00 New Revision: 9166842bc6fbd9c9b45134aa09a44b68ad1d7f02 URL: https://github.com/llvm/llvm-project/commit/9166842bc6fbd9c9b45134aa09a44b68ad1d7f02 DIFF: https://github.com/llvm/llvm-project/commit/9166842bc6fbd9c9b45134aa09a44b68ad1d7f02.diff LO

[PATCH] D142905: Change multilib selection algorithm

michaelplatings updated this revision to Diff 495070. michaelplatings added a comment. Set both fexceptions and fno-exceptions flags for Fuchsia multilib. Previously that tweak had slipped into D142878 , which is now abandoned. Repository: rG LLVM Github Mon

[PATCH] D143059: [NFC] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 495072. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h clang/include

[PATCH] D142617: [clang][Interp] Check This pointer without creating InterpFrame

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142617/new/ https://reviews.llvm.org/D142617 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D141098: [clang-format][NFC] Set LineEnding to LF in config files

MyDeveloperDay added a comment. I guess we'll need to revert this until the buildbots are updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141098/new/ https://reviews.llvm.org/D141098 ___ cfe-commi

[PATCH] D143178: Add new clang-format alignment option

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. Please add the unit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143178/new/ https://reviews.llvm.org/D143178

[PATCH] D143178: Add new clang-format alignment option

MyDeveloperDay added a comment. Can you please do a full context diff see (https://llvm.org/docs/Contributing.html) Comment at: clang/include/clang/Format/Format.h:225 bool AlignCompound; +// TODO +bool AcrossParameterDeclarations; Ok you have to

[PATCH] D143178: Add new clang-format alignment option

MyDeveloperDay added a comment. please point to a github issue which outlines what you are fixing and why Comment at: clang/lib/Format/Format.cpp:35 #include "clang/Basic/SourceManager.h" +#include "clang/Format/Format.h" #include "clang/Lex/Lexer.h" why movi

[PATCH] D143178: Add new clang-format alignment option

MyDeveloperDay added a comment. " just to get feedback whether this option would get accepted or not." Honestly I can't tell from the code what problem you are trying to fix. The github issue and unit tests are vital for us to understand what you are trying to achieve (and to ensure you are not

[PATCH] D140415: [flang] stack arrays pass

tblah updated this revision to Diff 495073. tblah added a comment. Changes: inline mlir::blockIsInLoop Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140415/new/ https://reviews.llvm.org/D140415 Files: clang/docs/tools/clang-formatted-files.txt

[clang] c24cdd5 - [clang-format] PackConstructorInitializers support PCIS_OnlyNextLine

Author: Backl1ght Date: 2023-02-06T19:39:05+08:00 New Revision: c24cdd58a1445e9741d89137f18f1ec9c89ecead URL: https://github.com/llvm/llvm-project/commit/c24cdd58a1445e9741d89137f18f1ec9c89ecead DIFF: https://github.com/llvm/llvm-project/commit/c24cdd58a1445e9741d89137f18f1ec9c89ecead.diff LOG

[PATCH] D143091: [clang-format] PackConstructorInitializers support PCIS_NextLineOnly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc24cdd58a144: [clang-format] PackConstructorInitializers support PCIS_OnlyNextLine (authored by Backl1ght). Repository: rG LLVM Github Monorepo C

[PATCH] D143160: [include-mapping] Introduce a human-edit CXXSymbolMapping file

hokein added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/StdAlternativeHeaderMap.inc:3 +// +// This is a hand-curated list for C++ symbols (e.g. provided by multiple +// headers), to address the short comings of cppreference or automated k

[PATCH] D143214: [include-mapping] Add C-compatibility symbol entries.

kadircet added inline comments. Comment at: clang/tools/include-mapping/gen_std.py:123 +c_header = "<" + header[2:-1] + ".h>" +if not any(re.fullmatch(x, symbol.name) for x in exception_symbols): + if symbol.namespace != None: nit: early exits ```

[PATCH] D143386: Add function pointer alignment to DataLayout

gchatelet created this revision. gchatelet added a reviewer: efriedma. Herald added subscribers: luke, kosarev, mattd, gchakrabarti, pmatos, asb, asavonic, frasercrmck, kerbowa, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, atanasy

[clang] 8323d2a - [CodeGen] Remove some not needed includes in BackendUtil.cpp

Author: Bjorn Pettersson Date: 2023-02-06T13:38:57+01:00 New Revision: 8323d2a66575ef5f891ec917f163c1737ade4187 URL: https://github.com/llvm/llvm-project/commit/8323d2a66575ef5f891ec917f163c1737ade4187 DIFF: https://github.com/llvm/llvm-project/commit/8323d2a66575ef5f891ec917f163c1737ade4187.di

[PATCH] D143214: [include-mapping] Add C-compatibility symbol entries.

hokein updated this revision to Diff 495089. hokein marked 3 inline comments as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143214/new/ https://reviews.llvm.org/D143214 Files: clang/include/clang/

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

kiranchandramohan added a comment. Please add more description to the summary regarding the scope of this patch. If it is only able to lower specific llvm-dialect types, please call out that. Please also explain the split in work between mlir::Translation and OpenMPIRbuilder. You can also consi

[PATCH] D143274: [clangd] Remove the direct use of StdSymbolMapping.inc usage.

kadircet added a comment. thanks a lot. since this is the last (and only) upstream user of the raw mappings. can you also move them into `clang/lib/Tooling/Inclusions/Stdlib/` as part of this patch? Comment at: clang-tools-extra/clangd/index/CanonicalIncludes.h:43 + /// Retu

[PATCH] D143280: [include-mapping] Better #includes support for std input/output symbols

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! as discussed offline, let's first move the raw header mappings to a private location first though and make sure all users are going through stdlib apis to ensure we don't see

[PATCH] D143160: [include-mapping] Introduce a human-edit CXXSymbolMapping file

kadircet added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/StdAlternativeHeaderMap.inc:3 +// +// This is a hand-curated list for C++ symbols (e.g. provided by multiple +// headers), to address the short comings of cppreference or automated

[PATCH] D143274: [clangd] Remove the direct use of StdSymbolMapping.inc usage.

hokein marked an inline comment as done. hokein added a comment. In D143274#4106449 , @kadircet wrote: > thanks a lot. since this is the last (and only) upstream user of the raw > mappings. can you also move them into `clang/lib/Tooling/Inclusions/Stdlib

[PATCH] D143274: [clangd] Remove the direct use of StdSymbolMapping.inc usage.

hokein updated this revision to Diff 495096. hokein marked an inline comment as done. hokein added a comment. refined the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143274/new/ https://reviews.llvm.org/D143274 Files: clang-tools-extr

[PATCH] D143274: [clangd] Remove the direct use of StdSymbolMapping.inc usage.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/CanonicalIncludes.h:43 + /// Returns the overridden include for a qualified symbol with, or "". + /// \p Scope and \p Name concatenation forms the full qualified name. + /// \p Scope is the qualifier wi

[PATCH] D143318: [Support] Move ItaniumManglingCanonicalizer and SymbolRemappingReader from Support to ProfileData

nhaehnle added a comment. This (moving to ProfileData) seems like a simple and pragmatic solution for a (perhaps not gigantic but) real problem. It feels fine to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143318/new/ https://reviews.llvm.or

[clang] de31b5c - Update status of WG21 DR1042

Author: Aaron Ballman Date: 2023-02-06T08:34:31-05:00 New Revision: de31b5cf0ae6b22ea7f71b4cbe1c21e543726020 URL: https://github.com/llvm/llvm-project/commit/de31b5cf0ae6b22ea7f71b4cbe1c21e543726020 DIFF: https://github.com/llvm/llvm-project/commit/de31b5cf0ae6b22ea7f71b4cbe1c21e543726020.diff

[clang-tools-extra] 58927e9 - [clangd] Remove the direct use of StdSymbolMapping.inc usage.

Author: Haojian Wu Date: 2023-02-06T14:41:52+01:00 New Revision: 58927e9931219387895b4ef67ebb50eafa2d9056 URL: https://github.com/llvm/llvm-project/commit/58927e9931219387895b4ef67ebb50eafa2d9056 DIFF: https://github.com/llvm/llvm-project/commit/58927e9931219387895b4ef67ebb50eafa2d9056.diff LO

[PATCH] D143274: [clangd] Remove the direct use of StdSymbolMapping.inc usage.

This revision was automatically updated to reflect the committed changes. hokein marked 2 inline comments as done. Closed by commit rG58927e993121: [clangd] Remove the direct use of StdSymbolMapping.inc usage. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D143274?vs=49

[PATCH] D143160: [include-mapping] Introduce a human-edit CXXSymbolMapping file

hokein updated this revision to Diff 495100. hokein added a comment. Rename the file name for more general purposes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143160/new/ https://reviews.llvm.org/D143160 Files: clang/include/clang/Tooling/In

[PATCH] D143160: [include-mapping] Introduce a human-edit CXXSymbolMapping file

hokein added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/StdAlternativeHeaderMap.inc:3 +// +// This is a hand-curated list for C++ symbols (e.g. provided by multiple +// headers), to address the short comings of cppreference or automated k

[PATCH] D143160: [include-mapping] Introduce a human-edit CXXSymbolMapping file

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143160/new/ https://reviews.llvm.org/D143160 __

[PATCH] D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr

mikecrowe added a comment. > The limitation about only transforming the first argument can be alleviated > by using the forEachArgumentWithParam matcher I shall try to make that work. My initial attempts were not successful, but there's still more to try. If I can't make it work I'll ask for mo

[PATCH] D143343: Broken link to SourceWeb (aka CxxCodeBrowser) project in "External Clang Examples" #60142

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! I'll land this on your behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143343/new/ https://reviews.llvm.org

[clang] d041833 - Fix broken link to CxxCodeBrowser in External Clang Examples

Author: Pratik Sharma Date: 2023-02-06T09:12:58-05:00 New Revision: d041833f55d91321670f2ccfc22d66a85c279905 URL: https://github.com/llvm/llvm-project/commit/d041833f55d91321670f2ccfc22d66a85c279905 DIFF: https://github.com/llvm/llvm-project/commit/d041833f55d91321670f2ccfc22d66a85c279905.diff

[PATCH] D143343: Broken link to SourceWeb (aka CxxCodeBrowser) project in "External Clang Examples" #60142

This revision was automatically updated to reflect the committed changes. Closed by commit rGd041833f55d9: Fix broken link to CxxCodeBrowser in External Clang Examples (authored by s-pratik, committed by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D143054: [include-mapping] Regenerate the mappings from the 20220730 html book.

hokein added a comment. Thanks, it looks good. One remaining suggestion is to merge the `StdRemovedSymbolMap.inc` to the `StdSymbolMap.inc` (it doesn't seem to add much value to maintain a separate file for zoombie symbols), I will address it and land the patch for you. Repository: rG LLVM

[PATCH] D138453: [clang] Add serialization for loop hint annotation tokens

aaron.ballman added a comment. In D138453#4105211 , @DHowett-MSFT wrote: > In D138453#4105209 , @shafik wrote: > >> It looks like https://github.com/llvm/llvm-project/issues/60543 is hitting >> your added `llvm_

[clang] b5ee4f7 - Revert "Lazyly initialize uncommon toolchain detector"

Author: Jonas Hahnfeld Date: 2023-02-06T15:39:33+01:00 New Revision: b5ee4f755fcff56243f6ff0cea9e7a722259304a URL: https://github.com/llvm/llvm-project/commit/b5ee4f755fcff56243f6ff0cea9e7a722259304a DIFF: https://github.com/llvm/llvm-project/commit/b5ee4f755fcff56243f6ff0cea9e7a722259304a.diff

[PATCH] D143054: [include-mapping] Regenerate the mappings from the 20220730 html book.

hokein updated this revision to Diff 495108. hokein added a comment. merge zoombie names to StdSymboMap.inc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143054/new/ https://reviews.llvm.org/D143054 Files: clang/include/clang/Tooling/Inclusions/

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

TWeaver added a comment. Hello all, sorry to be a bother, but I believe this patch has caused a failure in this buildbot (and potentially others). https://lab.llvm.org/buildbot/#/builders/109/builds/57277 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

Hahnfeld reopened this revision. Hahnfeld added a comment. This broke `clang/test/Driver/rocm-detect.hip` on a number of platforms (including the pre-merge checks on this PR), I've reverted for now in b5ee4f755fcff56243f6ff0cea9e7a722259304a

[PATCH] D141240: [SVE][Builtins] Add metadata to intrinsic calls for builtins that don't define the result of inactive lanes.

paulwalker-arm abandoned this revision. paulwalker-arm added a comment. D141939 turned out to be the better approach. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141240/new/ https://reviews.llvm.org/D141240 ___

[clang] 77910ac - [clang] Reorder output of rocm-detect.hip test

Author: serge-sans-paille Date: 2023-02-06T16:03:58+01:00 New Revision: 77910ac374656319ff114ef251fda358d4aa166a URL: https://github.com/llvm/llvm-project/commit/77910ac374656319ff114ef251fda358d4aa166a DIFF: https://github.com/llvm/llvm-project/commit/77910ac374656319ff114ef251fda358d4aa166a.d

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta updated this revision to Diff 495116. xgupta added a comment. use function to avoid code duplication Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142609/new/ https://reviews.llvm.org/D142609 Files: clang/include/clang/Sema/Sema.h clang

[PATCH] D143399: [Tooling/Inclusion] Move the generated mapping .inc file to private places.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. The .inc files are private now, clients should tooling::stdlib APIs instead. Repository: rG LLVM Github Monorepo https://revie

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta updated this revision to Diff 495122. xgupta added a comment. remove old code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142609/new/ https://reviews.llvm.org/D142609 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaExpr.cpp

[PATCH] D142277: [clang][Interp] Clear metadata when destroying locals

tbaeder abandoned this revision. tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/EvalEmitter.cpp:260-261 +// local variable is used after being destroyed. +InlineDescriptor &ID = *reinterpret_cast(B->rawData()); +

[clang] 993bce9 - [HIP] Support ASAN with malloc/free

Author: Yaxun (Sam) Liu Date: 2023-02-06T10:18:02-05:00 New Revision: 993bce9680c6a8f403a4a753fcbcb13ac7cddca3 URL: https://github.com/llvm/llvm-project/commit/993bce9680c6a8f403a4a753fcbcb13ac7cddca3 DIFF: https://github.com/llvm/llvm-project/commit/993bce9680c6a8f403a4a753fcbcb13ac7cddca3.dif

[PATCH] D143111: [HIP] Support ASAN with malloc/free

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG993bce9680c6: [HIP] Support ASAN with malloc/free (authored by yaxunl). Herald added a project: clang. Repo

[PATCH] D136751: [clang][Interp] This pointers are writable in constructors

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/Interp.cpp:264-270 + const Function *Func = S.Current->getFunction(); + if (Func && Func->isConstructor()) { +// The This pointer is writable in constructors, even if +// isConst() returns true. +

[clang] 0ffaffc - Reapply 6fa2abf90886f18472c87bc9bffbcdf4f73c465e

Author: serge-sans-paille Date: 2023-02-06T16:44:11+01:00 New Revision: 0ffaffcaac97de31e1b0e7e80c4f7cab724eda20 URL: https://github.com/llvm/llvm-project/commit/0ffaffcaac97de31e1b0e7e80c4f7cab724eda20 DIFF: https://github.com/llvm/llvm-project/commit/0ffaffcaac97de31e1b0e7e80c4f7cab724eda20.d

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG0ffaffcaac97: Reapply 6fa2abf90886f18472c87bc9bffbcdf4f73c465e (authored by serge-sans-paille). Repository: rG LLVM Git

[PATCH] D141472: [clang][Interp] Add function pointers

aaron.ballman added a comment. In D141472#4106091 , @tbaeder wrote: >> Member pointers (for functions or for data) are weird in that they're not >> the typical pointer width. They're actually a pointer and between >> one-to-three other fields in a trenc

[PATCH] D136751: [clang][Interp] This pointers are writable in constructors

tbaeder updated this revision to Diff 495147. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136751/new/ https://reviews.llvm.org/D136751 Files: clang/lib/AST/Interp/Function.h clang/lib/AST/Interp/Interp.cpp clang/lib/AST/Interp/Pointer.h

[PATCH] D136751: [clang][Interp] This pointers are writable in constructors

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.cpp:264-270 + const Function *Func = S.Current->getFunction(); + if (Func && Func->isConstructor()) { +// The This pointer is writable in constructors, even if +// isConst() returns true. +if (Pt

[clang] d2b0b26 - [Coroutines] Pass size parameter for deallocation function when qualified

Author: Chuanqi Xu Date: 2023-02-07T00:22:22+08:00 New Revision: d2b0b26132ce5d3d9022edbf274f01e9de764673 URL: https://github.com/llvm/llvm-project/commit/d2b0b26132ce5d3d9022edbf274f01e9de764673 DIFF: https://github.com/llvm/llvm-project/commit/d2b0b26132ce5d3d9022edbf274f01e9de764673.diff LO

[PATCH] D143348: [Clang][Doc][OpenCL] Release 16 notes

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143348/new/ https://reviews.llvm.org/D143348 ___ cfe-commits mailing list cfe-comm

[PATCH] D138453: [clang] Add serialization for loop hint annotation tokens

mikerice added a comment. In D138453#410 , @aaron.ballman wrote: > In D138453#4105211 , @DHowett-MSFT > wrote: > >> >> I believe it's expected that we hit this assertion - it's clearer than the >> origi

[PATCH] D143411: [NFC][clang] Fix static analyzer concern about uninitialized variable

Fznamznon created this revision. Fznamznon added reviewers: NoQ, xazax.hun, gribozavr, ymandel, sgatev. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, rnkovacs, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision.

[PATCH] D143412: [HIP] Update test hip-header.hip

yaxunl created this revision. yaxunl added reviewers: tra, arsenm. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: wdng. remove -no-opaque-pointers https://reviews.llvm.org/D143412 Files: clang/test/Headers/hip-header.hip Index: clang/test/H

[PATCH] D143300: [randstruct] Don't allow implicit forward decl to stop struct randomization

nickdesaulniers added a comment. In D143300#4104469 , @MaskRay wrote: > `clang/test/CodeGen/init-randomized-struct-fwd-decl.c` passes without this > patch. Is it correct? Perhaps related to my comment about RecordDecl vs EnumDecl... or the tests might

[PATCH] D143348: [Clang][Doc][OpenCL] Release 16 notes

svenvh added inline comments. Comment at: clang/docs/ReleaseNotes.rst:840 + * Fixed conditional definition of the depth image and read_write image3d builtins. + * Added ``nounwind`` attribute to all builtin functions. + It's slightly more than that: clang adds

[PATCH] D143386: Add function pointer alignment to DataLayout

efriedma added a comment. Almost all the specifications you're specifying are wrong. Very few targets should be using "i". Off the top of my head, 32-bit ARM, MIPS targets with MicroMIPS, and certain PowerPC targets should, but most common targets shouldn't. ("i" means that either the target

[PATCH] D142893: [NFC] Class for building MultilibSet

peter.smith added a comment. Looks good so far. Some stylistic suggestions. Comment at: clang/include/clang/Driver/Multilib.h:25 namespace driver { /// This corresponds to a single GCC Multilib, or a segment of one controlled It took a bit of reading to wor

  1   2   3   >