[PATCH] D143123: [NFC] Add split-file as runtime test dependency

yozhu updated this revision to Diff 494156. yozhu added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add `split-file` as compiler-rt test dependency under clang/runtime Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

erikdesjardins added a comment. In D142862#4089860 , @serge-sans-paille wrote: > Can you take a shot against https://llvm-compile-time-tracker.com/ so that > we get an hint of the practical speedup? I ran rustc perf tests using a patched LLVM in http

[PATCH] D143053: [C++20] [Modules] Pop Expression Evaluation Context when we skip its body during parsing

ChuanqiXu added a reviewer: cor3ntin. ChuanqiXu added inline comments. Comment at: clang/lib/Parse/Parser.cpp:1415 +// +// FIXME: It looks not easy to balance PushExpressionEvaluationContext() +// and PopExpressionEvaluationContext(). cor3ntin wrote:

[clang] 0e2400a - [clang] Fix warning about unused variable [NFC]

Author: Mikael Holmen Date: 2023-02-02T08:02:11+01:00 New Revision: 0e2400ae025d33dd3dbe9f9da52ab2da776e92fd URL: https://github.com/llvm/llvm-project/commit/0e2400ae025d33dd3dbe9f9da52ab2da776e92fd DIFF: https://github.com/llvm/llvm-project/commit/0e2400ae025d33dd3dbe9f9da52ab2da776e92fd.diff

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

carlosgalvezp added a comment. @Sockke ping, can you land this or should we do it for you? If so, please let us know what name and email we should use for attribution. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138655/new/ https://reviews.llvm.org/D138655 __

[clang-tools-extra] 8a8f77c - [clang-tidy] Implement CppCoreGuideline F.54

Author: Chris Cotter Date: 2023-02-02T07:20:59Z New Revision: 8a8f77c1b849ff59ef0db457bd74f4adb1de7cfa URL: https://github.com/llvm/llvm-project/commit/8a8f77c1b849ff59ef0db457bd74f4adb1de7cfa DIFF: https://github.com/llvm/llvm-project/commit/8a8f77c1b849ff59ef0db457bd74f4adb1de7cfa.diff LOG:

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a8f77c1b849: [clang-tidy] Implement CppCoreGuideline F.54 (authored by ccotter, committed by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp marked an inline comment as done. carlosgalvezp added a comment. All comments have been addressed, I intend to land the patch by February 9th unless more feedback is received. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141144/new/

[PATCH] D142871: [clangd] Semantic highlighting for constrained-parameter

nridge updated this revision to Diff 494172. nridge added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142871/new/ https://reviews.llvm.org/D142871 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-e

[PATCH] D142871: [clangd] Semantic highlighting for constrained-parameter

nridge added a comment. Also filed https://github.com/llvm/llvm-project/issues/60469 for the seemingly missing RecursiveASTVisitor methods Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142871/new/ https://reviews.llvm.org/D142871

[PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

serge-sans-paille added a comment. https://llvm-compile-time-tracker.com/compare.php?from=1a17739d3aa78599c32f6106e05dcfa7f3f9e823&to=9c1adc5fcca177d6628bdb22c72e7546c7b691aa&stat=instructions:u looks good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D142384: [C++20] Fix a crash with modules.

usaxena95 added a comment. In D142384#4096935 , @ilya-biryukov wrote: > @usaxena95 could you give an example of the code that fails the assertion? Is > it some of the tests? `assert(getDefinition())` fails about 3.6k tests. `assert(!isa(this) || getDef

[PATCH] D143109: [Sema] Push a LambdaScopeInfo before calling SubstDefaultArgument

cor3ntin added a comment. In D143109#4097850 , @ahatanak wrote: > Doesn't `Sema::FunctionScopeRAII` pop the lambda scope when it goes out of > scope? No, sadly lambdas are handled differently > https://github.com/llvm/llvm-project/blob/main/clang/inclu

[PATCH] D143099: [clang][lex] Expose findBeginningOfLine()

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM except the duplicated comment Comment at: clang/lib/Lex/Lexer.cpp:493-494 /// Returns the pointer that points to the beginning of line that contains /// the give

[PATCH] D142717: [clang] Mark CWG2165 as N/A

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142717/new/ https://reviews.llvm.org/D142717 ___

<    1   2   3