[PATCH] D143050: [Driver][Fuchsia] Remove relative vtable multilib

phosek created this revision. phosek added a reviewer: leonardchan. Herald added a subscriber: abrachet. Herald added a project: All. phosek requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. We have made relative vtable the default fo

[PATCH] D143051: [Clang][RISCV] Bump rvv intrinsics version to v0.11

eopXD created this revision. eopXD added reviewers: craig.topper, kito-cheng, asb, rogfer01, frasercrmck. Herald added subscribers: luke, VincentWu, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zz

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

hokein added a comment. As discussed offline, we decided to stop spending effort on improving the cppreference_parser.py, instead, we allow human edits in the generated `StdSymbolMap.inc` and `CSymbolMap.inc`, it gives us more flexibility: sort the headers for multi-header symbol in a humn-desi

[PATCH] D142992: [include-mapping] Implement language separation in stdlib recognizer library

VitaNuo updated this revision to Diff 493863. VitaNuo added a comment. Minor improvements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142992/new/ https://reviews.llvm.org/D142992 Files: clang/include/clang/Tooling/Inclusions/StandardLibrary.h

[clang] 60ea6f3 - [ARM] Allow selecting hard-float ABI in integer-only MVE.

Author: Simon Tatham Date: 2023-02-01T09:05:12Z New Revision: 60ea6f35a270d11c91770a2fc366888e7d3859f4 URL: https://github.com/llvm/llvm-project/commit/60ea6f35a270d11c91770a2fc366888e7d3859f4 DIFF: https://github.com/llvm/llvm-project/commit/60ea6f35a270d11c91770a2fc366888e7d3859f4.diff LOG:

[PATCH] D142703: [ARM] Allow selecting hard-float ABI in integer-only MVE.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG60ea6f35a270: [ARM] Allow selecting hard-float ABI in integer-only MVE. (authored by simon_tatham). Changed prior to commit: https://reviews.llvm.

[PATCH] D143053: [C++20] [Modules] Pop Expression Evaluation Context when we skip its body during parsing

ChuanqiXu created this revision. ChuanqiXu added reviewers: erichkeane, royjacobson, shafik, clang-language-wg. ChuanqiXu added a project: clang. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. Close https://github.com/llvm/llvm-pro

[PATCH] D140915: [clangd] Fix getQueryScopes for using-directive with inline namespace

kadircet added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1709 + +// The enclosing namespace must be first, it gets a quality boost. +if (auto Enclosing = SpecifiedScopes.EnclosingNamespace) { i was actually suggesting to put t

[clang] f559e78 - [AArch64] Handle negative architecture features

Author: David Green Date: 2023-02-01T09:21:07Z New Revision: f559e781b2bd918d8cac8a878639870a8f26196d URL: https://github.com/llvm/llvm-project/commit/f559e781b2bd918d8cac8a878639870a8f26196d DIFF: https://github.com/llvm/llvm-project/commit/f559e781b2bd918d8cac8a878639870a8f26196d.diff LOG: [

[PATCH] D142963: [AArch64] Handle negative architecture features

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf559e781b2bd: [AArch64] Handle negative architecture features (authored by dmgreen). Herald added a project: clang. Herald added a subscriber: cfe-co

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 493869. VitaNuo marked an inline comment as done. VitaNuo added a comment. Add comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/include/clang/T

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 493870. VitaNuo added a comment. Revert all changes to generator. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/lib/Tooling/Inclusions/Stdlib/Standar

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 493871. VitaNuo added a comment. Revert more. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/lib/Tooling/Inclusions/Stdlib/StandardLibrary.cpp Index

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo added a comment. Reverted everything apart from library support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 ___ cfe-commits mailing list cfe-commit

[PATCH] D143054: [include-mapping] Regenerate the mappings from the 20220730 html book.

VitaNuo created this revision. Herald added a project: All. VitaNuo requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D143054 Files:

[PATCH] D142822: [clang] ASTImporter: Fix importing of va_list types and declarations

DavidSpickett added a comment. On AArch64 we have the following failures: Failed Tests (15): Clang :: CXX/basic/basic.stc/basic.stc.dynamic/p2-nodef.cpp Clang :: CodeCompletion/ordinary-name-cxx11.cpp Clang :: CodeCompletion/ordinary-name.cpp Clang :: CodeGenCXX/cxx20-module-std

[PATCH] D140959: RFC: Multilib prototype

Joe added a comment. FWIW I tried this patch out with RISC-V multilibs, and it works a treat. It solves the multilib reuse problem and relaxes the order of non-standard extensions. I did have to copy some of the logic from BareMetal.cpp to Gnu.cpp as was using a GCC installation. The `args` fi

[PATCH] D143025: [Fuchsia] Add llvm-mt and llvm-rc to clang bootstrap dependency

phosek added inline comments. Comment at: clang/cmake/caches/Fuchsia.cmake:42-52 +foreach(variableName ${_FUCHSIA_BOOTSTRAP_PASSTHROUGH_STRINGS}) + if(DEFINED ${variableName}) +set(BOOTSTRAP_${variableName} "${${variableName}}" CACHE STRING "") + endif() +endforeach() + +fo

[PATCH] D142014: [clangd] fix wrong CalleeArgInfo in the hover

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142014/new/ https://reviews.llvm.org/D142014

[PATCH] D142992: [include-mapping] Implement language separation in stdlib recognizer library

hokein added a comment. Can you add some tests in `StandardLibraryTest.cpp`? Comment at: clang/lib/Tooling/Inclusions/Stdlib/StandardLibrary.cpp:31 + +static llvm::DenseMap LanguageMappings; + using a map here seems like an overkill, we have just 2 elements, I'

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon added inline comments. Comment at: clang/test/Driver/x-args.c:12 +// RUN: not %clang_cl /TC /WX /clang:-xc /clang:-E /clang:-dM %s 2>&1 | FileCheck -check-prefix=CL %s +// CL-NOT: '-x c' after last input file has no effect +// CL: error: unsupported option '-x c'; did

[PATCH] D140959: RFC: Multilib prototype

michaelplatings abandoned this revision. michaelplatings added a comment. I've created a new stack of changes taking into account the feedback. Unlike this change which was strictly a prototype, the new changes should be suitable for detailed review and hopefully approval. - https://reviews.llv

[PATCH] D142992: [include-mapping] Implement language separation in stdlib recognizer library

VitaNuo updated this revision to Diff 493886. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142992/new/ https://reviews.llvm.org/D142992 Files: clang/include/clang/Tooling/Inclusions/StandardLibr

[PATCH] D142992: [include-mapping] Implement language separation in stdlib recognizer library

VitaNuo added a comment. Thanks for the comments! Comment at: clang/lib/Tooling/Inclusions/Stdlib/StandardLibrary.cpp:31 + +static llvm::DenseMap LanguageMappings; + hokein wrote: > using a map here seems like an overkill, we have just 2 elements, I'd just > u

[PATCH] D143059: [NFC] Enable selecting multiple multilibs

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added subscribers: luke, abrachet, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, atanasyan, edward-jones, zzheng, jrtc27, niosHD,

[PATCH] D142963: [AArch64] Handle negative architecture features

tmatheson added a comment. In D142963#4094545 , @andrewrk wrote: > Speaking as the one who filed the motivating bug report, all of the above > behaviors are fine. The motivating use case is explicitly specifying a //full > set// of enabled/disabled feat

[PATCH] D141939: [SVE][Builtins] Lower X forms of binop arithmetic builtins to dedicated intrinsics.

paulwalker-arm added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141939/new/ https://reviews.llvm.org/D141939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D141939: [SVE][Builtins] Lower X forms of binop arithmetic builtins to dedicated intrinsics.

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM. Feel free to ignore the nit if you think the explicit `x_intrinsic` is better. Comment at: clang/include/clang/Basic/arm_sve.td:762 -multiclass SInstZPZZ flags

[PATCH] D143051: [Clang][RISCV] Bump rvv intrinsics version to v0.11

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM, it's great to having a version number to distinguish different interface version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

ManuelJBrito updated this revision to Diff 493904. ManuelJBrito retitled this revision from "[clang] Add builtin_nondet" to "[clang] Add builtin_nondeterministic_value". ManuelJBrito edited the summary of this revision. ManuelJBrito added a comment. Herald added a subscriber: mgrang. - Change nam

[PATCH] D142985: [LinkerWrapper] Fix memory issues due to unguarded accesses to global state

jhuber6 added a comment. In D142985#4095701 , @uabelho wrote: > I wrote > https://github.com/llvm/llvm-project/issues/60437 Great, I'll land it once the patch is accepted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D142932: Multilib YAML parsing

miyuki added inline comments. Comment at: clang/lib/Driver/Multilib.cpp:82 + for (const Matcher &M : Matchers) { +const std::regex Regex(M.Regex); +if (std::find_if(InFlags.begin(), InFlags.end(), Please use the LLVM regular expression engine (llvm/Suppo

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos marked 11 inline comments as done. pmatos added inline comments. Comment at: clang/lib/Basic/Targets/DirectX.h:45 3, // hlsl_groupshared +// Wasm address space values for this map are dummy +20, // wasm_funcref erichkeane wrote: > pmatos wrote

[PATCH] D140897: [clang][dataflow] Fix handling of `DeclRefExpr`s to `BindingDecl`s.

ymandel added a comment. In D140897#4094945 , @xazax.hun wrote: > I hope we will be able to get rid of this `SkipPast` thing at some point by > looking at the value categories of the AST instead. Thanks! Agreed: filed issue #60444. Repository: rG LL

[PATCH] D142932: Multilib YAML parsing

miyuki added inline comments. Comment at: clang/lib/Driver/Multilib.cpp:83 +const std::regex Regex(M.Regex); +if (std::find_if(InFlags.begin(), InFlags.end(), + [&Regex](const std::string &F) { Please use `llvm::find_if(InFlags, ...)`

[PATCH] D142710: [clang][dataflow] Relax validity assumptions in `UncheckedOptionalAccessModel`.

ymandel added a comment. In D142710#4094934 , @xazax.hun wrote: > This change looks good to me. I wonder, however, whether the behavior should > be parameterized in the future. E.g., whether the user of the analysis should > be able to make a decision w

[clang] 0256280 - [clang][dataflow] Fix handling of `DeclRefExpr`s to `BindingDecl`s.

Author: Yitzhak Mandelbaum Date: 2023-02-01T13:23:23Z New Revision: 02562804d074a4d6e041e00572483fe25932186e URL: https://github.com/llvm/llvm-project/commit/02562804d074a4d6e041e00572483fe25932186e DIFF: https://github.com/llvm/llvm-project/commit/02562804d074a4d6e041e00572483fe25932186e.diff

[PATCH] D140897: [clang][dataflow] Fix handling of `DeclRefExpr`s to `BindingDecl`s.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG02562804d074: [clang][dataflow] Fix handling of `DeclRefExpr`s to `BindingDecl`s. (authored by ymandel). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thank you! Btw, if you change: `Fix https://github.com/llvm/llvm-project/issues/58375` into: `Fixes #58375` in the commit message, it will automatically close the github issue and associate it with this commit. Repo

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ConfigFragment.h:243 +/// - Strict +std::optional> Mode; + I think "Diagnostics.Mode" is too vague a name. I expect this to be a rollout flag that we remove in the medium term (either

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

nikic added a comment. @aaron.ballman It works with the URL as well. The URL is preferred, because that way people don't have to reconstruct it when seeing the issue reference on phabricator, where it does not get auto-linked. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos marked an inline comment as done. pmatos added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4129 + let Documentation = [WebAssemblyExportNameDocs]; + let Subjects = SubjectList<[TypedefName], ErrorDiag>; +} aaron.ballman wrote: > erichk

[PATCH] D142992: [include-mapping] Implement language separation in stdlib recognizer library

VitaNuo updated this revision to Diff 493918. VitaNuo added a comment. Add a couple more test cases to StandardLibraryTest.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142992/new/ https://reviews.llvm.org/D142992 Files: clang/include/clang

[PATCH] D142992: [include-mapping] Implement language separation in stdlib recognizer library

VitaNuo added a comment. Added a couple of test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142992/new/ https://reviews.llvm.org/D142992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 493919. pmatos marked an inline comment as done. pmatos added a comment. Address some of the pending comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm.org/D128440 Files:

[PATCH] D142985: [LinkerWrapper] Fix memory issues due to unguarded accesses to global state

uabelho resigned from this revision. uabelho added a comment. In D142985#4096297 , @jhuber6 wrote: > In D142985#4095701 , @uabelho wrote: > >> I wrote >> https://github.com/llvm/llvm-project/issues/60437 > > Grea

[PATCH] D142822: [clang] ASTImporter: Fix importing of va_list types and declarations

donat.nagy added inline comments. Comment at: clang/test/AST/ast-dump-overloaded-operators.cpp:27 // CHECK-NEXT: | `-ParmVarDecl {{.*}} col:19{{( imported)?}} 'E' -// CHECK-NEXT: `-FunctionDecl {{.*}} line:14:6{{( imported)?}} test 'void ()' +// CHECK-NEXT: -FunctionDecl {{.

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

aaron.ballman added a comment. In D142826#4096355 , @nikic wrote: > @aaron.ballman It works with the URL as well. The URL is preferred, because > that way people don't have to reconstruct it when seeing the issue reference > on phabricator, where it doe

[clang] 95668c0 - [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

Author: Shivam Gupta Date: 2023-02-01T19:29:16+05:30 New Revision: 95668c0d97e6184729f3a3e9621a58d9edffb6b0 URL: https://github.com/llvm/llvm-project/commit/95668c0d97e6184729f3a3e9621a58d9edffb6b0 DIFF: https://github.com/llvm/llvm-project/commit/95668c0d97e6184729f3a3e9621a58d9edffb6b0.diff

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG95668c0d97e6: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility (authored by xgupta). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

xgupta added a comment. In D142826#4096348 , @aaron.ballman wrote: > LGTM, thank you! Thank you for reviewing and helping it to commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142826/new/ https://r

[PATCH] D142384: [C++20] Fix a crash with modules.

usaxena95 updated this revision to Diff 493926. usaxena95 added a comment. Moved to RecordDecl::field_begin. Assertion is no more valid in RecordDecl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142384/new/ https://reviews.llvm.org/D142384 Files

[PATCH] D142985: [LinkerWrapper] Fix memory issues due to unguarded accesses to global state

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142985/new/ https://reviews.llvm.org/D142985 _

[PATCH] D142985: [LinkerWrapper] Fix memory issues due to unguarded accesses to global state

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9c4591d7f3ac: [LinkerWrapper] Fix memory issues due to unguarded accesses to global state (authored by jhuber6). Repository: rG LLVM Github Monore

[clang] 9c4591d - [LinkerWrapper] Fix memory issues due to unguarded accesses to global state

Author: Joseph Huber Date: 2023-02-01T08:12:10-06:00 New Revision: 9c4591d7f3acaa00318900bdba4b4ba26c99c666 URL: https://github.com/llvm/llvm-project/commit/9c4591d7f3acaa00318900bdba4b4ba26c99c666 DIFF: https://github.com/llvm/llvm-project/commit/9c4591d7f3acaa00318900bdba4b4ba26c99c666.diff

[PATCH] D142872: Honor the fwrapv option when generating the inbounds GEP .

nikic added a comment. I've found another bug in LLVM, fixed with https://github.com/llvm/llvm-project/commit/78f88082de3627ea04501c83a08f52cf1e60b4f7. After that change, the test case from https://github.com/llvm/llvm-project/issues/59580 appears to be handled correctly, it contains this in t

[PATCH] D143053: [C++20] [Modules] Pop Expression Evaluation Context when we skip its body during parsing

erichkeane added a subscriber: cor3ntin. erichkeane added a comment. @cor3ntin did a bunch of work here lately, so he's probably a better reviewer than I am. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143053/new/ https://reviews.llvm.org/D14305

[PATCH] D143021: [OpenMP 5.2] Deprecate 'destroy' clause without argument for 'depobj' construct

ABataev added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:496 +def err_destroy_clause_without_argument +: Error<"'destroy' clause without argument on '#pragma omp depobj' " 1. Usually we name them err_omp_... Also, move to

[PATCH] D142401: [Clang] Fix a crash when recursively callig a default member initializer.

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. In D142401#4082356 , @cor3ntin wrote: > In D142401#4074959 , @shafik wrote: > >> I could not find any tests that test for this warning. >

[PATCH] D142244: [flang][driver] Add support for -embed-offload-object flag in flang -fc1

clementval added a comment. The new test embed.f90 and embed-error.f90 are failing on my side. Do they assume a specific configuration? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142244/new/ https://reviews.llvm.org/D142244 ___

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

erichkeane added a comment. That part is Ok now, thanks. However, this still needs a release note, plus a test for spelling versions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324 ___ cfe-commits

[PATCH] D142401: [Clang] Fix a crash when recursively callig a default member initializer.

erichkeane added a comment. In D142401#4096478 , @aaron.ballman wrote: > In D142401#4082356 , @cor3ntin > wrote: > >> In D142401#4074959 , @shafik wrote: >> >>> I could

[PATCH] D142244: [flang][driver] Add support for -embed-offload-object flag in flang -fc1

jsjodin added a comment. In D142244#4096492 , @clementval wrote: > The new test embed.f90 and embed-error.f90 are failing on my side. Do they > assume a specific configuration? No, it should work for any configuration as far as I know. How are you runn

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3070 + +if(Ty->isStructTy()){ + Address StructAddr = ReturnValue.getValue(); This gets REALLY complicated, you can't just create a store, this might end up hitting conversion

[PATCH] D139774: [libclang] Add API to set temporary directory location

aaron.ballman added a comment. In D139774#4095522 , @vedgy wrote: > In D139774#4094619 , @aaron.ballman > wrote: > >> Is there a middle ground where, instead of #2 for general temporary storage, >> we went with

[PATCH] D142401: [Clang] Fix a crash when recursively callig a default member initializer.

aaron.ballman added a comment. In D142401#4096498 , @erichkeane wrote: > In D142401#4096478 , @aaron.ballman > wrote: > >> In D142401#4082356 , @cor3ntin >> wrote: >> >

[PATCH] D142401: [Clang] Fix a crash when recursively callig a default member initializer.

erichkeane added a comment. Huh TIL! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142401/new/ https://reviews.llvm.org/D142401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D142244: [flang][driver] Add support for -embed-offload-object flag in flang -fc1

clementval added a comment. In D142244#4096512 , @jsjodin wrote: > No, it should work for any configuration as far as I know. How are you > running the test? Just with `check-flang` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D142244: [flang][driver] Add support for -embed-offload-object flag in flang -fc1

jsjodin added a comment. In D142244#4096538 , @clementval wrote: > In D142244#4096512 , @jsjodin wrote: > >> No, it should work for any configuration as far as I know. How are you >> running the test? > > Just w

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

aaron.ballman added a comment. In D133289#4036529 , @aaron.ballman wrote: > I spoke with @to268 during office hours about the current status of the NB > comments for this feature in the C committee. For the moment, he's going to > pause work on this pa

[PATCH] D142244: [flang][driver] Add support for -embed-offload-object flag in flang -fc1

clementval added a comment. In D142244#4096546 , @jsjodin wrote: > In D142244#4096538 , @clementval > wrote: > >> In D142244#4096512 , @jsjodin >> wrote: >> >>> No, it s

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

aaron.ballman added a comment. In D133289#4037180 , @tschuett wrote: > It surprised me that there are no type inference messages? The type of this > auto is double. I only found warnings of misuse of auto and codegen tests. Can you give a code example o

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

tschuett added a comment. In D133289#4096588 , @aaron.ballman wrote: > In D133289#4037180 , @tschuett > wrote: > >> It surprised me that there are no type inference messages? The type of this >> auto is double.

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

ManuelJBrito added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3070 + +if(Ty->isStructTy()){ + Address StructAddr = ReturnValue.getValue(); erichkeane wrote: > This gets REALLY complicated, you can't just create a store, this might end

[PATCH] D143070: [clang-format] Enable FormatTokenSource to insert tokens.

klimek created this revision. klimek added a reviewer: sammccall. Herald added a project: All. klimek requested review of this revision. Herald added a project: clang. In preparation for configured macro replacements in formatting, add the ability to insert tokens to FormatTokenSource, and impleme

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3070 + +if(Ty->isStructTy()){ + Address StructAddr = ReturnValue.getValue(); ManuelJBrito wrote: > erichkeane wrote: > > This gets REALLY complicated, you can't just create a s

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3070 + +if(Ty->isStructTy()){ + Address StructAddr = ReturnValue.getValue(); erichkeane wrote: > ManuelJBrito wrote: > > erichkeane wrote: > > > This gets REALLY complicated

[PATCH] D139774: [libclang] Add API to set temporary directory location

vedgy added a comment. In D139774#4096527 , @aaron.ballman wrote: > That sounds like a good plan to me. I wonder if we want to name it something > like `clang_createIndexWithOptions` (or something generic like that), and > give it a versioned structure

[PATCH] D142244: [flang][driver] Add support for -embed-offload-object flag in flang -fc1

jsjodin added a comment. In D142244#4096579 , @clementval wrote: > In D142244#4096546 , @jsjodin wrote: > >> In D142244#4096538 , @clementval >> wrote: >> >>> In D142244

[PATCH] D143072: [NFC][clang] Fix static code analyzer complains

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Initializ

[clang] ecb3cd0 - [Driver] Move PS4/PS5 header search path management to the driver

Author: Paul Robinson Date: 2023-02-01T07:40:30-08:00 New Revision: ecb3cd0946a47c419efda7b92cd6f6fcc30b6be9 URL: https://github.com/llvm/llvm-project/commit/ecb3cd0946a47c419efda7b92cd6f6fcc30b6be9 DIFF: https://github.com/llvm/llvm-project/commit/ecb3cd0946a47c419efda7b92cd6f6fcc30b6be9.diff

[PATCH] D139774: [libclang] Add API to set temporary directory location

aaron.ballman added a comment. In D139774#4096638 , @vedgy wrote: > In D139774#4096527 , @aaron.ballman > wrote: > >> That sounds like a good plan to me. I wonder if we want to name it something >> like `clang_c

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added a subscriber: abidh. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This enables layering ba

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

xbolva00 added a comment. Please add a release note. Thanks for this new builtin, as I was working on something very very similar - the implementation looks fine to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142388/new/ https://reviews.llv

[PATCH] D139774: [libclang] Add API to set temporary directory location

vedgy added a comment. In D139774#4096695 , @aaron.ballman wrote: > There's three scenarios when a field is added to the structure: 1) library > and app are matching versions, 2) library is newer than app, 3) app is newer > than library. #1 is the happ

[clang] d4fb829 - [clang][dataflow] Relax validity assumptions in `UncheckedOptionalAccessModel`.

Author: Yitzhak Mandelbaum Date: 2023-02-01T15:57:09Z New Revision: d4fb829b718059eb044843aea7b03d5b65556351 URL: https://github.com/llvm/llvm-project/commit/d4fb829b718059eb044843aea7b03d5b65556351 DIFF: https://github.com/llvm/llvm-project/commit/d4fb829b718059eb044843aea7b03d5b65556351.diff

[PATCH] D142710: [clang][dataflow] Relax validity assumptions in `UncheckedOptionalAccessModel`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd4fb829b7180: [clang][dataflow] Relax validity assumptions in `UncheckedOptionalAccessModel`. (authored by ymandel). Repository: rG LLVM Github Mo

[PATCH] D139774: [libclang] Add API to set temporary directory location

vedgy added a comment. Perhaps the struct should contain the value of `CINDEX_VERSION_MINOR` instead of the `sizeof`? This way, libclang can change the meaning of a struct member without changing the size of the struct. For example, replace `PreambleStoragePath` with `TemporaryDirectoryPath`. S

[PATCH] D142244: [flang][driver] Add support for -embed-offload-object flag in flang -fc1

clementval added a comment. In D142244#4096648 , @jsjodin wrote: > In D142244#4096579 , @clementval > wrote: > >> In D142244#4096546 , @jsjodin >> wrote: >> >>> In D1422

[PATCH] D142639: [clang] Warn by default that implicit capture of 'this' is deprecated in C++20 and later.

tahonermann updated this revision to Diff 493955. tahonermann added a comment. Rebased. This now targets Clang 17. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142639/new/ https://reviews.llvm.org/D142639 Files: clang/docs/ReleaseNotes.rst cl

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis marked 2 inline comments as done. TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1342-1382 +/// Create a constant string location from the MLIR Location information. +static llvm::Constant * +createSourceLoc

[PATCH] D142932: Multilib YAML parsing

michaelplatings updated this revision to Diff 493968. michaelplatings added a comment. Incorporated changes requested by @miyuki Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.org/D142932 Files: clang/include/clan

[PATCH] D142991: [clang-tidy] Add --fix-mode and --nolint-prefix options

KyleFromKitware updated this revision to Diff 493969. KyleFromKitware added a comment. Added tests and fixed assertion error in release build. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142991/new/ https://reviews.llvm.org/D142991 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp

[PATCH] D142384: [C++20] Fix a crash with modules.

ilya-biryukov added a comment. I don't see any issues with this, so happy to LGTM. @rsmith any concerns on your side? @usaxena95 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142384/new/ https://reviews.llvm.org/D142384 _

[PATCH] D142244: [flang][driver] Add support for -embed-offload-object flag in flang -fc1

jsjodin added a comment. In D142244#4096777 , @clementval wrote: > In D142244#4096648 , @jsjodin wrote: > >> In D142244#4096579 , @clementval >> wrote: >> >>> In D142244

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

tianshilei1992 updated this revision to Diff 493978. tianshilei1992 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/ https://reviews.llvm.org/D142569 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp llvm/include

[PATCH] D142710: [clang][dataflow] Relax validity assumptions in `UncheckedOptionalAccessModel`.

xazax.hun added a comment. In D142710#4096325 , @ymandel wrote: > In D142710#4094934 , @xazax.hun > wrote: > >> This change looks good to me. I wonder, however, whether the behavior should >> be parameterized in

[PATCH] D142933: Add -print-multi-selection-flags argument

Joe added a comment. So again, I took these patches for a spin with RISC-V. As I mentioned before, I was using a GCC installation, so the multilib selection happens inside Gnu.cpp (findRISCVBareMetalMultilibs). The main trouble I had was at that point we don't have a reference to the ToolChain,

[PATCH] D143053: [C++20] [Modules] Pop Expression Evaluation Context when we skip its body during parsing

shafik added inline comments. Comment at: clang/lib/Parse/Parser.cpp:1415 +// +// FIXME: It looks not easy to balance PushExpressionEvaluationContext() +// and PopExpressionEvaluationContext(). It does seem a bit ad-hoc Repository: rG LLVM Github

[PATCH] D142878: Add testing for Fuchsia multilib

phosek added a comment. Thanks, some of these are no longer needed which could simplify this change so I sent out D143050 to clean up the Fuchsia driver first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142878

  1   2   3   >