[PATCH] D142947: [hexagon] add a -mcabac flag

2023-01-31 Thread Brian Cain via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd97675e0236: [hexagon] add a -mcabac flag (authored by androm3da). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[clang] cd97675 - [hexagon] add a -mcabac flag

2023-01-31 Thread Brian Cain via cfe-commits
Author: Brian Cain Date: 2023-01-31T16:30:35-08:00 New Revision: cd97675e02368f31d56bd8f143c5987649d162d8 URL: https://github.com/llvm/llvm-project/commit/cd97675e02368f31d56bd8f143c5987649d162d8 DIFF: https://github.com/llvm/llvm-project/commit/cd97675e02368f31d56bd8f143c5987649d162d8.diff LO

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

2023-01-31 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. @erichkeane ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

2023-01-31 Thread Steven Wu via Phabricator via cfe-commits
steven_wu added a comment. > Sorry, I'm still not really following - OK, sounds like you're saying this > test does fail at HEAD/without this patch in reverse iteration mode, and is a > bit larger than would be minimally necessary to achieve that, but also might > fail at HEAD without reverse i

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

2023-01-31 Thread Bill Wendling via Phabricator via cfe-commits
void accepted this revision. void added a comment. This revision is now accepted and ready to land. One small comment about the documentation but L:GTM. Comment at: clang/docs/LanguageExtensions.rst:1584 +Outputs may be used along any branches from the ``asm goto`` whether the

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

2023-01-31 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:694 +// Return text representation of an `Expr`. In case unable to get the text +// representatiion of `E`, return `Default`. +static StringRef getExprTextOr(const Expr *E, const SourceManager &SM, -

[PATCH] D142861: [Clang] avoid relying on StringMap iteration order when roundtripping -analyzer-config

2023-01-31 Thread Erik Desjardins via Phabricator via cfe-commits
erikdesjardins added a comment. I don't have commit access, please commit this on my behalf: `Erik Desjardins ` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142861/new/ https://reviews.llvm.org/D142861 ___

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

2023-01-31 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. In D141451#4064298 , @dblaikie wrote: > Right - I was thinking more, as above, about directly using the existing > metadata generation (if it's too expensive to enable by default, then > possibly under an off-by-default

[PATCH] D142688: [Clang][Driver] Handle LoongArch multiarch tuples

2023-01-31 Thread WÁNG Xuěruì via Phabricator via cfe-commits
xen0n updated this revision to Diff 493796. xen0n added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142688/new/ https://reviews.llvm.org/D142688 Files: clang/lib/Driver/ToolChains/Arch/LoongArch.cpp clang/lib/Driver/ToolCha

[PATCH] D143040: [Clang][DependencyScanner] Remove secondary actions from -cc1

2023-01-31 Thread Michael Spencer via Phabricator via cfe-commits
Bigcheese created this revision. Bigcheese added a reviewer: jansvoboda11. Bigcheese added a project: clang. Herald added a subscriber: ributzka. Herald added a project: All. Bigcheese requested review of this revision. The -arcmt-action= and -objcmt-migrate* actions were being passed to module bu

[PATCH] D142704: [C++20][Modules] Handle template declarations in header units.

2023-01-31 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142704/new/ https://reviews.llvm.org/D142704

[PATCH] D142968: [NFC] Extract `CodeGenInstAlias` into its own *.h/*.cpp

2023-01-31 Thread Sergei Barannikov via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa7fbca40805c: [NFC] Extract `CodeGenInstAlias` into its own *.h/*.cpp (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SIN

[clang] a7fbca4 - [NFC] Extract `CodeGenInstAlias` into its own *.h/*.cpp

2023-01-31 Thread Sergei Barannikov via cfe-commits
Author: Sergei Barannikov Date: 2023-02-01T05:23:43+03:00 New Revision: a7fbca40805ca414a9dc37b91075e89e6a3b75d5 URL: https://github.com/llvm/llvm-project/commit/a7fbca40805ca414a9dc37b91075e89e6a3b75d5 DIFF: https://github.com/llvm/llvm-project/commit/a7fbca40805ca414a9dc37b91075e89e6a3b75d5.d

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

2023-01-31 Thread Shivam Gupta via Phabricator via cfe-commits
xgupta updated this revision to Diff 493810. xgupta added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142826/new/ https://reviews.llvm.org/D142826 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Diagno

[PATCH] D142688: [Clang][Driver] Handle LoongArch multiarch tuples

2023-01-31 Thread WÁNG Xuěruì via Phabricator via cfe-commits
xen0n added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:41 /// so we provide a rough mapping here. std::string Linux::getMultiarchTriple(const Driver &D, const llvm::Triple &TargetTriple, SixWeining

[PATCH] D142872: Honor the fwrapv option when generating the inbounds GEP .

2023-01-31 Thread Umesh Kalappa via Phabricator via cfe-commits
umesh.kalappa0 added a comment. @nikic ,is that changes are ok ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142872/new/ https://reviews.llvm.org/D142872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D139774: [libclang] Add API to set temporary directory location

2023-01-31 Thread Igor Kushnir via Phabricator via cfe-commits
vedgy added a comment. In D139774#4094619 , @aaron.ballman wrote: > Is there a middle ground where, instead of #2 for general temporary storage, > we went with #2 but with compiler-specific directories instead of system > directories. e.g., don't let t

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

2023-01-31 Thread Brandon Wu via Phabricator via cfe-commits
4vtomat updated this revision to Diff 493826. 4vtomat added a comment. NFC, some indentation fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141672/new/ https://reviews.llvm.org/D141672 Files: clang/test/Preprocessor/riscv-target-features.c

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

2023-01-31 Thread Petr Hosek via Phabricator via cfe-commits
phosek added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:95 +# and remove these libpath flags. +-libpath:"${LLVM_WINSYSROOT}/VC/Tools/MSVC/14.34.31933/lib/x64" +-libpath:"${LLVM_WINSYSROOT}/VC/Tools/MSVC/14.34.31933/atlmfc/lib/x64"

[PATCH] D142985: [LinkerWrapper] Fix memory issues due to unguarded accesses to global state

2023-01-31 Thread Mikael Holmén via Phabricator via cfe-commits
uabelho added a comment. @jhuber6 I really have no idea about the fix, but I've run the linker-wrapper.c testcase with asan built binaries with this fix 500 times now without seeing any failures. Without the fix it fails in like 1 out of 10 runs so it surely looks like the fix does something g

[PATCH] D142985: [LinkerWrapper] Fix memory issues due to unguarded accesses to global state

2023-01-31 Thread Mikael Holmén via Phabricator via cfe-commits
uabelho added a comment. In D142985#4093783 , @jhuber6 wrote: > If this fixes the issues on your side, please open a bug so it can be > backported. I wrote https://github.com/llvm/llvm-project/issues/60437 Repository: rG LLVM Github Monorepo CHANG

<    1   2   3