[PATCH] D140270: MIPS: fix build from IR files, nan2008 and FpAbi

wzssyqa added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140270/new/ https://reviews.llvm.org/D140270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

serge-sans-paille added a comment. Can you take a shot against https://llvm-compile-time-tracker.com/ so that we get an hint of the practical speedup? Looks like xxhash.h is missing from the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

serge-sans-paille added a comment. Do you intend to (optionnaly) provide XXH3 as described in https://github.com/Cyan4973/xxHash ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142862/new/ https://reviews.llvm.org/D142862

[PATCH] D142871: [clangd] Semantic highlighting for constrained-parameter

nridge created this revision. nridge added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LL

[PATCH] D142871: [clangd] Semantic highlighting for constrained-parameter

nridge added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:720 + // Pick up the name via VisitNamedDecl + Base::VisitTemplateTypeParmDecl(D); +} Am I using the API correctly here? It's a bit weird that `ConstDeclVisitor` woul

[PATCH] D139926: [clangd] Add semantic token for angle brackets

nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp:1026 +concept $Concept_decl[[C2]] = true; +template $Bracket[[<]]C2$Bracket[[<]]int$Bracket[[>]] $TemplateParameter_def[[A]]$Bracket[[>]] +class $C

[PATCH] D142872: Honor the fwrapv option when generating the inbounds GEP .

umesh.kalappa0 created this revision. umesh.kalappa0 added a reviewer: nikic. umesh.kalappa0 added a project: LLVM. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. umesh.kalappa0 requested review of this revision. Herald added a project: clang. Herald added subscribers

[PATCH] D139926: [clangd] Add semantic token for angle brackets

nridge added a comment. In D139926#4084846 , @nridge wrote: > template > class A { > template void foo(U a) { } > template<> void foo(int a) { } // <-- > }; > > This one is `ClassScopeFunctionSpecializationDecl::getTemplateArgsAsWritten

[PATCH] D139926: [clangd] Add semantic token for angle brackets

nridge added a comment. I did find one other edge case (last one, I promise!) template void foo(T); template class A { friend void foo<>(T); // <-- }; This one is `FunctionDecl::getDependentSpecializationInfo()->getLAngleLoc()` Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 5375b63 - [UTC] Add --version argument

Author: Nikita Popov Date: 2023-01-30T09:57:26+01:00 New Revision: 5375b638be874b5438e98bd8a435e198af3ef2d0 URL: https://github.com/llvm/llvm-project/commit/5375b638be874b5438e98bd8a435e198af3ef2d0 DIFF: https://github.com/llvm/llvm-project/commit/5375b638be874b5438e98bd8a435e198af3ef2d0.diff

[PATCH] D142473: [UTC] Add --version argument

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5375b638be87: [UTC] Add --version argument (authored by nikic). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 493226. pmatos added a comment. Rebase on main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST

[clang] e31ee64 - [clang][ASTImporter] Handle UsingType in friend declarations.

Author: Balázs Kéri Date: 2023-01-30T10:06:11+01:00 New Revision: e31ee6417c33a6e2f0e8440b1a86d5365279ad68 URL: https://github.com/llvm/llvm-project/commit/e31ee6417c33a6e2f0e8440b1a86d5365279ad68 DIFF: https://github.com/llvm/llvm-project/commit/e31ee6417c33a6e2f0e8440b1a86d5365279ad68.diff L

[PATCH] D142607: [clang][ASTImporter] Handle UsingType in friend declarations.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe31ee6417c33: [clang][ASTImporter] Handle UsingType in friend declarations. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D142006: [mlir][bufferization] Fix getAliasingOpOperand/OpResult for non-bufferizable ops

This revision was automatically updated to reflect the committed changes. Closed by commit rGf3483c23ce2c: [mlir][bufferization] Fix getAliasingOpOperand/OpResult for non-bufferizable ops (authored by springerm). Changed prior to commit: https://reviews.llvm.org/D142006?vs=492765&id=493228#toc

[PATCH] D142878: Add testing for Fuchsia multilib

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The plan is to change

[PATCH] D142804: [clang-format] Support clang-format on/off line comments as prefixes

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142804/new/ https://reviews.llvm.org/D142804 ___ cfe-commits mailing li

[PATCH] D142878: Add testing for Fuchsia multilib

michaelplatings updated this revision to Diff 493244. michaelplatings added a comment. Update commit message and run arc with clang-format on the PATH Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142878/new/ https://reviews.llvm.org/D142878 Files

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler updated this revision to Diff 493247. ckandeler added a comment. Support more cases as per review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139926/new/ https://reviews.llvm.org/D139926 Files: clang-tools-extra/clangd/Sema

[PATCH] D142816: [clang-tidy] Add --list-unique-checks command

carlosgalvezp added a comment. This is not as trivial as one might think. Check aliases aren't necessarily identical, as they can differ based on configuration settings, becoming essentially different checks. I have a WIP patch to allow users to avoid running

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 493251. pmatos added a comment. Rebase on main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm.org/D128440 Files: clang/include/clang/AST/DeclBase.h clang/include/clang/AST/T

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidCaptureDefaultWhenCapturingThisCheck.cpp:81 + Lambda->getCaptureDefaultLoc(), + "lambdas that capture 'this' should not specify a capture default"); + -

[PATCH] D142757: [clang][driver] Do not warn about position of `/clang:-xc` in cl mode

Fznamznon updated this revision to Diff 493256. Fznamznon added a comment. Emit an error if `/clang:-x` passed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142757/new/ https://reviews.llvm.org/D142757 Files: clang/lib/Driver/Driver.cpp clang

[PATCH] D142228: [clangd] Disable tests that are incompatible with Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG2493a7016416: [clangd] Disable tests that are incompatible with Windows (authored by andrewng). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142228/new/ ht

[clang-tools-extra] 2493a70 - [clangd] Disable tests that are incompatible with Windows

Author: Andrew Ng Date: 2023-01-30T10:44:32Z New Revision: 2493a7016416c90038be5c816e12a7ad07cee054 URL: https://github.com/llvm/llvm-project/commit/2493a7016416c90038be5c816e12a7ad07cee054 DIFF: https://github.com/llvm/llvm-project/commit/2493a7016416c90038be5c816e12a7ad07cee054.diff LOG: [cl

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon marked an inline comment as done. Fznamznon added inline comments. Comment at: clang/lib/Driver/Driver.cpp:2571 // No driver mode exposes -x and /TC or /TP; we don't support mixing them. assert(!Args.hasArg(options::OPT_x) && "-x and /TC or /TP is not allowed"

[PATCH] D141449: clang/OpenCL: Fix not setting convergent on block invoke kernels

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141449/new/ https://reviews.llvm.org/D141449 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D141620: clang/OpenCL: Apply default attributes to enqueued blocks

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141620/new/ https://reviews.llvm.org/D141620 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D141447: clang/OpenCL: Don't use a Function for the block type

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141447/new/ https://reviews.llvm.org/D141447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D142872: Honor the fwrapv option when generating the inbounds GEP .

nikic requested changes to this revision. nikic added a comment. This revision now requires changes to proceed. CreateConstArrayGEP currently always creates an inbounds GEP. You need to modify it make inbounds option / use a different method, not supress it in the constant folding infrastructure

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 493264. pmatos added a comment. Rebase on main and fix a test diagnostic expectation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 Files: clang/include/clang/AST/

[PATCH] D142804: [clang-format] Support clang-format on/off line comments as prefixes

owenpan added inline comments. Comment at: clang/lib/Format/Format.cpp:3893 +bool isClangFormatOn(StringRef Comment) { + if (Comment == "/* clang-format on */") alexolog wrote: > owenpan wrote: > > alexolog wrote: > > > alexolog wrote: > > > > Here's my attemp

[PATCH] D142872: Honor the fwrapv option when generating the inbounds GEP .

nikic added a comment. You also shouldn't need to introduce any new handling for the fwrapv option. I'm not sure how exactly it is currently threaded through, but there must be existing handling for it already. For example, there is isSignedOverflowDefined() on LangOptions. Repository: rG L

[PATCH] D135405: fix handling of braced-init temporaries for modernize-use-emplace

BigPeet added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135405/new/ https://reviews.llvm.org/D135405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

aaron.ballman added a reviewer: clang-vendors. aaron.ballman added a comment. Heh, I literally started working on this on Friday afternoon. :-D There's a failing CI case that needs to be addressed: Sema/tautological-constant-compare.c -- IIRC, fixing that should suffice for test coverage. This

[PATCH] D142872: Honor the fwrapv option when generating the inbounds GEP .

umesh.kalappa0 updated this revision to Diff 493282. umesh.kalappa0 edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142872/new/ https://reviews.llvm.org/D142872 Files: clang/lib/CodeGen/CGExpr.cpp clang/test/CodeGen/inbounds.c llvm/include/llvm/IR

[PATCH] D142872: Honor the fwrapv option when generating the inbounds GEP .

umesh.kalappa0 added a comment. In D142872#4090317 , @nikic wrote: > You also shouldn't need to introduce any new handling for the fwrapv option. > I'm not sure how exactly it is currently threaded through, but there must be > existing handling for it a

[PATCH] D142872: Honor the fwrapv option when generating the inbounds GEP .

umesh.kalappa0 added a comment. In D142872#4090304 , @nikic wrote: > CreateConstArrayGEP currently always creates an inbounds GEP. You need to > modify it make inbounds optional or use a different method, not suppress it > in the constant folding infras

[PATCH] D141447: clang/OpenCL: Don't use a Function for the block type

yaxunl added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:12477-12480 + F->setCallingConv(llvm::CallingConv::AMDGPU_KERNEL); + + // FIXME: Apply default attributes + F->addFnAttr(llvm::Attribute::NoUnwind); need a test CHANGES SINCE LAST ACT

[PATCH] D141447: clang/OpenCL: Don't use a Function for the block type

arsenm added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:12477-12480 + F->setCallingConv(llvm::CallingConv::AMDGPU_KERNEL); + + // FIXME: Apply default attributes + F->addFnAttr(llvm::Attribute::NoUnwind); yaxunl wrote: > need a test It's alr

[PATCH] D141620: clang/OpenCL: Apply default attributes to enqueued blocks

yaxunl added inline comments. Comment at: clang/test/CodeGenOpenCL/amdgpu-enqueue-kernel.cl:381 +// GFX900-LABEL: define {{[^@]+}}@callee +// GFX900-SAME: (i64 noundef [[ID:%.*]], ptr addrspace(1) noundef [[OUT:%.*]]) #[[ATTR1:[0-9]+]] { +// GFX900-NEXT: entry:

[PATCH] D141447: clang/OpenCL: Don't use a Function for the block type

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141447/new/ https://reviews.llvm.org/D141447 ___ cfe-commits mailing list cfe-

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

ccotter marked 2 inline comments as done. ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidCaptureDefaultWhenCapturingThisCheck.cpp:81 + Lambda->getCaptureDefaultLoc(), + "lambdas that capture 'this' should not spec

[PATCH] D142799: [Clang] Fix unconditional access to Attr pointer when checking if _Nullable is applicable to a type

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Thank you for the fix! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142799/new/ https://reviews.llvm.org/D142799 ___ cfe-commits

[PATCH] D141449: clang/OpenCL: Fix not setting convergent on block invoke kernels

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141449/new/ https://reviews.llvm.org/D141449 ___ cfe-commits mailing list cfe-c

[PATCH] D142799: [Clang] Fix unconditional access to Attr pointer when checking if _Nullable is applicable to a type

erichkeane accepted this revision. erichkeane added a comment. Needs a release note, otherwise LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142799/new/ https://reviews.llvm.org/D142799 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

erichkeane added a comment. In D136886#4087953 , @vabridgers wrote: > @mizvekov, will you be picking this change up and finishing this, or do you > mind if I have a go at finishing this patch? Thanks @mizvekov has been away from the community for a whi

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

kadircet created this revision. kadircet added reviewers: hokein, sammccall. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repos

[PATCH] D142891: [clang-format] Recognize Verilog non-blocking assignment

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://

[PATCH] D142892: [clangd] Publish diagnostics from stale preambles

kadircet created this revision. kadircet added reviewers: sammccall, hokein. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Diagn

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

whisperity added a comment. In D91000#4020891 , @futogergely wrote: > What we could do is: > > 1. add a new checker option to decide if we suggest replacements from AnnexK. > We could avoid registering matchers this way, but I don't really like this, > h

[PATCH] D142893: Class for building MultilibSet

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The functionality in

[PATCH] D142872: Honor the fwrapv option when generating the inbounds GEP .

nikic added a comment. @umesh.kalappa0 I see. That part is actually a bug in LLVM. I'm working on a fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142872/new/ https://reviews.llvm.org/D142872 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

whisperity added a comment. Tentative **LGTM**, will still need to run the "usual test projects" in the CI for confirmation. What's missing from this patch are the `.rst` files for the CERT-specific aliases of the check, but those are trivial and we can "add them in post" anyway. CHANGES SINC

[PATCH] D139182: AArch64: add CodeGen support for FEAT_XS DSB instructions

t.p.northover updated this revision to Diff 493305. t.p.northover added a comment. Thanks for the warning. Now that's settled down a bit I've updated the patch to the new regime. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139182/new/ https://reviews.llvm.org/D139182 Files: clang/

[PATCH] D142800: [Clang][Diagnostic] Add `-Wcomparison-op-parentheses` to warn on chained comparisons

erichkeane added a subscriber: tahonermann. erichkeane added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:15539 +/// Emit a diagnostic together with a fixit hint that wraps the inner comparison +/// expression in parentheses. +static void EmitDiagnosticForCompOpInCom

[PATCH] D142800: [Clang][Diagnostic] Add `-Wcomparison-op-parentheses` to warn on chained comparisons

erichkeane added inline comments. Comment at: clang/test/Sema/comparison-op-parentheses.c:1 +// RUN: %clang_cc1 -fsyntax-only -verify %s -DSILENCE +// RUN: %clang_cc1 -fsyntax-only -verify %s -Wcomparison-op-parentheses don't use macros to control conditional dia

[PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

erikdesjardins added a subscriber: nikic. erikdesjardins added a comment. In D142862#4089860 , @serge-sans-paille wrote: > Can you take a shot against https://llvm-compile-time-tracker.com/ so that > we get an hint of the practical speedup? I don't th

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1293 Actions.PushLambdaScope(); + Actions.ActOnLambdaIntroducer(Intro, getCurScope()); cor3ntin wrote: > aaron.ballman wrote: > > Typically, we call an `ActOn` method after ha

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from these minor nits and the naming concerns, I think this LGTM. Comment at: clang/docs/ReleaseNotes.rst:747-748 - Implemented "Permitting static conste

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

david-arm added a comment. Hi @bryanpkc, this is looking a lot better now and thanks for addressing the comments! I've not reviewed all of the patch yet, but I do have a few more comments. The most important ones are about performing immediate range checks for the builtins and not declaring the

[PATCH] D139182: AArch64: add CodeGen support for FEAT_XS DSB instructions

lenary added a comment. I'm not sure I agree with "map naturally", when `CRm` is a 4-bit field, and both bit 7 and bit 5 are different in the `dsb ` vs `dsb nXS` instructions. Are you willing to put this through review for the ACLE ?

[PATCH] D141620: clang/OpenCL: Apply default attributes to enqueued blocks

arsenm added inline comments. Comment at: clang/test/CodeGenOpenCL/amdgpu-enqueue-kernel.cl:381 +// GFX900-LABEL: define {{[^@]+}}@callee +// GFX900-SAME: (i64 noundef [[ID:%.*]], ptr addrspace(1) noundef [[OUT:%.*]]) #[[ATTR1:[0-9]+]] { +// GFX900-NEXT: entry:

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

carlosgalvezp accepted this revision. carlosgalvezp added a comment. Thanks for updating the comment! Since I marked it as approved last time, I will land this in the next couple of days if no more comments come up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

dmgreen added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:1477 + + OS << "#if !defined(__ARM_FEATURE_SME)\n"; + OS << "#error \"SME support not enabled\"\n"; We have been changing how the existing SVE and NEON instrinsics work a little. Th

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

aaron.ballman added a comment. This seems reasonable to me. I was a bit worried about the behavior being rather strange, but given that these are "escape hatch" command line options to skip the clang-cl driver, and there are existing clang-cl options that cover this functionality, it makes more

[clang] 8f6c623 - [AArch64] Replace AEK_CRYPTO with relevant features in cpu definitions

Author: David Green Date: 2023-01-30T16:05:25Z New Revision: 8f6c623e874624c1f247f93bf457d5196a84cec6 URL: https://github.com/llvm/llvm-project/commit/8f6c623e874624c1f247f93bf457d5196a84cec6 DIFF: https://github.com/llvm/llvm-project/commit/8f6c623e874624c1f247f93bf457d5196a84cec6.diff LOG: [

[PATCH] D142548: [AArch64] Replace AEK_CRYPTO with relevant features in cpu definitions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f6c623e8746: [AArch64] Replace AEK_CRYPTO with relevant features in cpu definitions (authored by dmgreen). Herald added a project: clang. Herald add

[PATCH] D142692: [clang] Store the template param list of an explicit variable template specialization

shafik added subscribers: clang-language-wg, shafik. shafik added a comment. Adding `clang-language-wg` for more visibility. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142692/new/ https://reviews.llvm.org/D142692 ___

[PATCH] D142692: [clang] Store the template param list of an explicit variable template specialization

erichkeane added a comment. We have a good amount of AST-dump tests around that are likely the right place to put them perhaps? What is the reproducer that caused you to discover this issue? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142692/ne

[PATCH] D141192: [Clang] Fix warnings on bad shifts.

aaron.ballman added a comment. Sorry for the delay in reviewing, I was out for standards meetings last week and couldn't get to this one. For future patches, can you be sure to upload them with more diff context (`-U` is what I usually use). You should also add a release note for the fix.

[PATCH] D142316: [clang] Add test for CWG2396

shafik added inline comments. Comment at: clang/test/CXX/drs/dr23xx.cpp:202 + // void g2(A a) { a.operator B decltype(B())::*(); } + // void h(A a) { a.operator identity::type B::*(); } + // void h2(A a) { a.operator B identity::type::*(); } Endill wrote: >

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon updated this revision to Diff 493326. Fznamznon added a comment. Add a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142757/new/ https://reviews.llvm.org/D142757 Files: clang/docs/ReleaseNotes.rst clang/lib/Driver/Drive

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

cor3ntin updated this revision to Diff 493328. cor3ntin added a comment. - rebase - rename ActOnLambdaIntroducer - Fix a crash in `transformedLocalDecl` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124351/new/ https://reviews.llvm.org/D124351 Fil

[PATCH] D141620: clang/OpenCL: Apply default attributes to enqueued blocks

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141620/new/ https://reviews.llvm.org/D141620 ___ cfe-commits mailing list cfe-c

[PATCH] D142905: Change multilib selection algorithm

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added subscribers: abrachet, mgrang. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The new algori

[PATCH] D142816: [clang-tidy] Add --list-unique-checks command

ClockMan abandoned this revision. ClockMan added a comment. Ok, I agree that solution taken in D114317 with explicit marking of checks via misc::PrimaryCheck or conversion of type to string on preprocesor level is better. Repository: rG LLVM Github Monorepo

[PATCH] D142861: [Clang] avoid relying on StringMap iteration order when roundtripping -analyzer-config

jansvoboda11 added a comment. Thanks for the patch. Left a couple of small suggestions. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:881 + // Sort options by key to avoid relying on StringMap iteration order. + SmallVector, 4> SortedConfigOpts; for (const auto &C

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

aaron.ballman added a comment. Thank you for working on this, it is really shaping up nicely! In D142578#4088769 , @royjacobson wrote: > In D142578#4088011 , @tschuett > wrote: > >> IDK. Clang 16 is fully is a

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

arsenm created this revision. arsenm added reviewers: scanon, spatel, cameron.mcinally, andrew.w.kaylor, tra, jlebar, Anastasia, yaxunl, efriedma, jcranmer-intel, kpn, sepavloff. Herald added subscribers: kosarev, foad, StephenFan, wenlei, jdoerfert, kerbowa, pengfei, hiraditya, jvesely. Herald a

[PATCH] D142861: [Clang] avoid relying on StringMap iteration order when roundtripping -analyzer-config

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:886 + llvm::sort(SortedConfigOpts, [](const auto &A, const auto &B) { +return std::get<0>(A) < std::get<0>(B); + }); If you use `pair` inste

[PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

MaskRay added a comment. To enable smooth hash function migration in the future, we can explore the idea of adding `#ifdef EXPENSIVE_CHECKS\nshuffle` (see https://github.com/llvm/llvm-project/issues/34483). That means we should fix these tests properly to be non-dependent on the iteration order

[PATCH] D142595: [Driver][AVR] Don't emit default '-Tdata' when '-T' is specified

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. In D142595#4089391 , @benshi001 wrote: > In D142595#4089124 , @MaskRay wrote: > >> OK. If this do

[PATCH] D142799: [Clang] Fix unconditional access to Attr pointer when checking if _Nullable is applicable to a type

shafik updated this revision to Diff 493351. shafik added a comment. - Add release note CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142799/new/ https://reviews.llvm.org/D142799 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/TreeTransform.h clang/test/SemaCXX/nullability.cpp

[PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

goldstein.w.n added a comment. FWIW, if the only use if hashtables `xxhash` has a slight perf bug in `XXH3_len_129to240_128b` and `XXH3_len_129to240_64b` where it will repeat the last the block if length is a factor of `32`/`16` respectively. `XXH3_len_129to240_128b`: - https://github.com/Cyan4

[PATCH] D142384: [C++20] Fix a crash with modules.

rsmith added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:6233 + assert(RD->hasDefinition()); + RD->getDefinition(); if (RD->getNumVBases()) { I think it would make sense to use the definition of the class as `RD` here, since we're going to b

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis created this revision. TIFitis added reviewers: kiranchandramohan, clementval, jdoerfert. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, awarzynski, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb,

[PATCH] D140270: MIPS: fix build from IR files, nan2008 and FpAbi

MaskRay added a comment. In D140270#4089857 , @wzssyqa wrote: > ping I don't know how to test this, so this will be up to @nathanchance ... (Thanks for improving the mips port, though) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142861: [Clang] avoid relying on StringMap iteration order when roundtripping -analyzer-config

dblaikie added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:881 + // Sort options by key to avoid relying on StringMap iteration order. + SmallVector, 4> SortedConfigOpts; for (const auto &C : Opts.Config) { jansvoboda11 wrote: > ja

[PATCH] D142861: [Clang] avoid relying on StringMap iteration order when roundtripping -analyzer-config

dblaikie added a comment. (heh, don't mind my feedback being duplicate - didn't refresh before submitting - glad other folks got to it before me! :) ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142861/new/ https://reviews.llvm.org/D142861

[PATCH] D142917: [Fuchsia] Re-enable HWASan for globals in runtimes

phosek created this revision. phosek added a reviewer: leonardchan. Herald added a subscriber: abrachet. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is now supported. Repository: rG LLVM Gith

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

srj added a comment. In D141861#4060100 , @jhuber6 wrote: > In D141861#4060028 , @srj wrote: > >> This change appears to have broken the build when crosscompiling to x86-32 >> on a Linux x86-64 system; on the Hal

[clang] 52c28d7 - clang/OpenCL: Don't use a Function for the block type

Author: Matt Arsenault Date: 2023-01-30T15:03:14-04:00 New Revision: 52c28d7cf9018f3558268217f6cf91271eb4ac39 URL: https://github.com/llvm/llvm-project/commit/52c28d7cf9018f3558268217f6cf91271eb4ac39 DIFF: https://github.com/llvm/llvm-project/commit/52c28d7cf9018f3558268217f6cf91271eb4ac39.diff

[clang] 00f6a7f - clang/OpenCL: Fix not setting convergent on block invoke kernels

Author: Matt Arsenault Date: 2023-01-30T15:03:14-04:00 New Revision: 00f6a7f02f9c8d542ce8ff1c9c037d9fdb421b88 URL: https://github.com/llvm/llvm-project/commit/00f6a7f02f9c8d542ce8ff1c9c037d9fdb421b88 DIFF: https://github.com/llvm/llvm-project/commit/00f6a7f02f9c8d542ce8ff1c9c037d9fdb421b88.diff

[clang] d12ee4b - clang/OpenCL: Extend tests for enqueued block attributes

Author: Matt Arsenault Date: 2023-01-30T15:03:15-04:00 New Revision: d12ee4bf7c14a00b14890fc3042edd659dde7fb2 URL: https://github.com/llvm/llvm-project/commit/d12ee4bf7c14a00b14890fc3042edd659dde7fb2 DIFF: https://github.com/llvm/llvm-project/commit/d12ee4bf7c14a00b14890fc3042edd659dde7fb2.diff

[PATCH] D141447: clang/OpenCL: Don't use a Function for the block type

arsenm closed this revision. arsenm added a comment. 52c28d7cf9018f3558268217f6cf91271eb4ac39 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141447/new/ https://reviews.llvm.org/D141447 __

[PATCH] D141449: clang/OpenCL: Fix not setting convergent on block invoke kernels

arsenm closed this revision. arsenm added a comment. 00f6a7f02f9c8d542ce8ff1c9c037d9fdb421b88 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141449/new/ https://reviews.llvm.org/D141449 __

[PATCH] D140270: MIPS: fix build from IR files, nan2008 and FpAbi

nathanchance added a comment. I tested this against the kernel and left my feedback above (no issues) so this can be merged. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140270/new/ https://reviews.llvm.org/D140270 __

[PATCH] D142799: [Clang] Fix unconditional access to Attr pointer when checking if _Nullable is applicable to a type

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/docs/ReleaseNotes.rst:60 `Issue 59446 `_. +- Fix crash when diagnosing incorrect usage of _Nullable involing alias + templates. This fixes

[PATCH] D141620: clang/OpenCL: Apply default attributes to enqueued blocks

arsenm closed this revision. arsenm added a comment. 647925648a0fde06b5b44086843f0d8f164a71df CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141620/new/ https://reviews.llvm.org/D141620 __

  1   2   >