[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492295. craig.topper added a comment. Add CSZN format as named in the spec. Reuse CLoad_ri/CStore_rri classes instead of creating new ones that were almost the same. Use CS_ALU class for c.mul. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D129951: adds `__disable_adl` attribute

cjdb updated this revision to Diff 492296. cjdb marked 6 inline comments as done. cjdb added a comment. responds to feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129951/new/ https://reviews.llvm.org/D129951 Files: clang/include/clang/AS

[PATCH] D129951: adds `__disable_adl` attribute

cjdb added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:542 If a statement is marked ``nomerge`` and contains call expressions, those call -expressions inside the statement will not be merged during optimization. This +expressions inside the statement will

[PATCH] D140059: [APSInt] Fix bug in APSInt mentioned in https://github.com/llvm/llvm-project/issues/59515

vabridgers added a comment. Hello, it appears this patch causes a crash when I analyze this reproducer, with Z3 enabled. In the case shown here, the analyzer finds that 'f' to the call a(f) is uninitialized, and then is attempted to be refuted through SMTConv, leading to the assertion. If I mo

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492298. craig.topper added a comment. Update for rename CS_ALU to CA_ALU Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: clang/test/Preprocessor/riscv-t

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

jdoerfert added inline comments. Comment at: openmp/libomptarget/DeviceRTL/src/Configuration.cpp:57 + return !__omp_rtl_assume_no_nested_parallelism || + state::getKernelEnvironment().Configuration.MayUseNestedParallelism; } This looks wrong. We want ei

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

tianshilei1992 added inline comments. Comment at: openmp/libomptarget/DeviceRTL/src/Configuration.cpp:57 + return !__omp_rtl_assume_no_nested_parallelism || + state::getKernelEnvironment().Configuration.MayUseNestedParallelism; } jdoerfert wrote: > This

[PATCH] D142592: [clang-tidy][libc] Add an inline function checker for the libc project.

sivachandra created this revision. sivachandra added a reviewer: aaron.ballman. Herald added subscribers: ChuanqiXu, carlosgalvezp, ecnelises, tschuett, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. sivachandra requested review of this revision. Herald added a project:

[PATCH] D142595: [Driver][AVR] Don't emit default '-Tdata' when a linker script is specified

benshi001 created this revision. benshi001 added reviewers: MaskRay, aykevl, Miss_Grape. Herald added subscribers: Jim, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Fixes htt

[PATCH] D141826: [clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Michael137 updated this revision to Diff 492306. Michael137 added a comment. - Remove redundant constructor call change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141826/new/ https://reviews.llvm.org/D141826 Files: clang/include/clang/AST/Pro

[PATCH] D142596: [RISCV] Bump Zca version to 1.0.

craig.topper created this revision. craig.topper added reviewers: VincentWu, asb, luismarques, reames, jrtc27. Herald added subscribers: luke, vkmr, frasercrmck, jdoerfert, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, e

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492310. craig.topper added a comment. Merge uimm32_zc into uimm2. Add RISCVOp::OPERAND_TYPE_UIMM2_LSB0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: c

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492311. craig.topper added a comment. Fix typo in RISCVBaseInfo.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: clang/test/Preprocessor/riscv-target-f

[PATCH] D142592: [clang-tidy][libc] Add an inline function checker for the libc project.

Eugene.Zelenko added a comment. Please add entry in Release Notes. Comment at: clang-tools-extra/clang-tidy/llvmlibc/InlineFunctionDeclCheck.cpp:29 + + auto SrcBegin = FuncDecl->getSourceRange().getBegin(); + // Consider functions only in header files. Please

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to control trailing underscore added to external names

madanial updated this revision to Diff 492312. madanial retitled this revision from "[Flang] Add user option -funderscoring/-fnounderscoring to enable/disable ExternalNameConversionPass" to "[Flang] Add user option -funderscoring/-fnounderscoring to control trailing underscore added to external

[PATCH] D142354: [analyzer] Create a stub for an std::variant checker

NoQ added a comment. In D142354#4079643 , @Szelethus wrote: >> In the latter case, have you explored the possibility of force-inlining the >> class instead, like I suggested in the thread? > > I have done some tests then, and figured that the analyzer ca

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492315. craig.topper added a comment. Fix RUN line that was duplicate testing riscv64 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: clang/test/Preproc

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

rjmccall added a comment. In D142584#4081345 , @efriedma wrote: > I'm having a little trouble following what the meaning of an "Address" is > with this patch. The `Pointer` member refers to an encoded value, and > calling getPointer() emits IR to decod

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

tianshilei1992 updated this revision to Diff 492316. tianshilei1992 added a comment. rebase, fix comments, added more code. features are finished now. time to move to tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/ https://reviews

[PATCH] D129008: [Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument

rjmccall added a comment. Right. C structs can require more than just `memcpy` to copy in several different situations (all involving language extensions), but it doesn't require Sema to be involved: it doesn't introduce uses of user declarations, and the compiler can figure out the work it nee

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

VincentWu updated this revision to Diff 492318. VincentWu added a comment. rebase to upstream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: clang/test/Preprocessor/riscv-target-features.c llv

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

VincentWu updated this revision to Diff 492319. VincentWu added a comment. reset HEAD back to Diff 492315 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D1311

[PATCH] D140059: [APSInt] Fix bug in APSInt mentioned in https://github.com/llvm/llvm-project/issues/59515

Peter added a comment. In D140059#4081549 , @vabridgers wrote: > Hello, it appears this patch causes a crash when I analyze this reproducer, > with Z3 enabled. In the case shown here, the analyzer finds that 'f' to the > call a(f) is uninitialized, and

cfe-commits@lists.llvm.org

dkt01 added a comment. David Turner Good to know it worked as expected on your project as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141959/new/ https://reviews.llvm.org/D141959 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

tianshilei1992 updated this revision to Diff 492322. tianshilei1992 added a comment. fix bugs and add plugin support Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/ https://reviews.llvm.org/D142569 Files: clang/lib/CodeGen/CGOpenMPRunt

[clang] a5cd202 - Use llvm::Log2_32 and llvm::Log2_64 instead of llvm::findLastSet (NFC)

Author: Kazu Hirata Date: 2023-01-25T21:34:09-08:00 New Revision: a5cd202e21e52c1e00963ad5bdfeb83b4fec820e URL: https://github.com/llvm/llvm-project/commit/a5cd202e21e52c1e00963ad5bdfeb83b4fec820e DIFF: https://github.com/llvm/llvm-project/commit/a5cd202e21e52c1e00963ad5bdfeb83b4fec820e.diff L

[clang-tools-extra] a5cd202 - Use llvm::Log2_32 and llvm::Log2_64 instead of llvm::findLastSet (NFC)

Author: Kazu Hirata Date: 2023-01-25T21:34:09-08:00 New Revision: a5cd202e21e52c1e00963ad5bdfeb83b4fec820e URL: https://github.com/llvm/llvm-project/commit/a5cd202e21e52c1e00963ad5bdfeb83b4fec820e DIFF: https://github.com/llvm/llvm-project/commit/a5cd202e21e52c1e00963ad5bdfeb83b4fec820e.diff L

[clang] d2ea8ae - [clang][Interp] Implement logical and/or operators

Author: Timm Bäder Date: 2023-01-26T06:52:35+01:00 New Revision: d2ea8ae5d43e05791a201e7ca233d3f637254597 URL: https://github.com/llvm/llvm-project/commit/d2ea8ae5d43e05791a201e7ca233d3f637254597 DIFF: https://github.com/llvm/llvm-project/commit/d2ea8ae5d43e05791a201e7ca233d3f637254597.diff LO

[PATCH] D140809: [clang][Interp] Implement logical and/or operators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd2ea8ae5d43e: [clang][Interp] Implement logical and/or operators (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D140809?

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper added a comment. @VincentWu are you ok with the changes I made? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 ___ cfe-commits mailing list cfe-co

[PATCH] D142592: [clang-tidy][libc] Add an inline function checker for the libc project.

sivachandra updated this revision to Diff 492324. sivachandra added a comment. Use explicit type instead of auto. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142592/new/ https://reviews.llvm.org/D142592 Files: clang-tools-extra/clang-tidy/llvm

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492325. craig.topper added a comment. Update RISCVUsage.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: clang/test/Preprocessor/riscv-target-feature

[clang] 00e967f - [clang][Interp] Fix left-/right-shifting more than sizeof(unsigned)

Author: Timm Bäder Date: 2023-01-26T07:07:17+01:00 New Revision: 00e967f6c2d626d1913f5af5763beab7946978ce URL: https://github.com/llvm/llvm-project/commit/00e967f6c2d626d1913f5af5763beab7946978ce DIFF: https://github.com/llvm/llvm-project/commit/00e967f6c2d626d1913f5af5763beab7946978ce.diff LO

[PATCH] D140845: [clang][Interp] Fix left-/right-shifting more than sizeof(unsigned)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG00e967f6c2d6: [clang][Interp] Fix left-/right-shifting more than sizeof(unsigned) (authored by tbaeder). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D142596: [RISCV] Bump Zca version to 1.0.

craig.topper updated this revision to Diff 492331. craig.topper added a comment. Add Zcf and Zcd too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142596/new/ https://reviews.llvm.org/D142596 Files: clang/test/Driver/riscv-arch.c llvm/docs/RIS

[PATCH] D137706: [clang][Interp] Implement IntegralToPointer casts

tbaeder added a comment. Note that according to https://clang.llvm.org/docs/ConstantInterpreter.html#pointers, such pointers had their own pointer type (`TargetPointer`), so I'm not sure if the approach here is the right one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137706/new/

[PATCH] D141472: [clang][Interp] Add function pointers

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:138-139 case CK_IntegralToPointer: { if (isa(SubExpr)) return this->visit(SubExpr); aaron.ballman wrote: > Can we still

[PATCH] D142596: [RISCV] Bump Zca, Zcd, Zcf version to 1.0.

craig.topper updated this revision to Diff 492337. craig.topper added a comment. Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142596/new/ https://reviews.llvm.org/D142596 Files: clang/test/Driver/riscv-arch.c clang/test/Preproces

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

jdoerfert added a comment. Drive by: There should be a lang ref component to this. Also, changing branch weight metadata might impact downstream users, an RFC seems in order (assuming I didn't miss one). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D141472: [clang][Interp] Add function pointers

tbaeder updated this revision to Diff 492338. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141472/new/ https://reviews.llvm.org/D141472 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Context.cpp clang/lib/AST/Interp/D

[PATCH] D142604: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

shafik created this revision. shafik added reviewers: aaron.ballman, erichkeane, hubert.reinterpretcast. Herald added a project: All. shafik requested review of this revision. Currently the implementation of `__VA_OPT__` will treat the concatenation of a non-placemaker token and placemaker token

[clang] 5bf56a5 - [clang][Interp][NFCI] Don't crash on void builtin functions

Author: Timm Bäder Date: 2023-01-26T07:32:33+01:00 New Revision: 5bf56a58775cb235b7ed9e9fcc6895b797e9721b URL: https://github.com/llvm/llvm-project/commit/5bf56a58775cb235b7ed9e9fcc6895b797e9721b DIFF: https://github.com/llvm/llvm-project/commit/5bf56a58775cb235b7ed9e9fcc6895b797e9721b.diff LO

[clang] 136c7ef - Revert "[clang][Interp] Fix left-/right-shifting more than sizeof(unsigned)"

Author: Timm Bäder Date: 2023-01-26T07:49:10+01:00 New Revision: 136c7ef5d10fca0af101821b05084b428830e670 URL: https://github.com/llvm/llvm-project/commit/136c7ef5d10fca0af101821b05084b428830e670 DIFF: https://github.com/llvm/llvm-project/commit/136c7ef5d10fca0af101821b05084b428830e670.diff LO

[PATCH] D139774: [libclang] Add API to set temporary directory location

vedgy added a comment. 3 out of 4 alternatives remain: > 1. Add an option to store the preamble-*.pch files in RAM instead of /tmp and > add a corresponding option in KDevelop configuration UI. This would work > perfectly for me, provided I don't change my mind and decide to turn this > option

[clang] 7e629e4 - [AST] Use llvm::bit_width (NFC)

Author: Kazu Hirata Date: 2023-01-25T22:59:51-08:00 New Revision: 7e629e4e888262abd8f076512b252208acd72d62 URL: https://github.com/llvm/llvm-project/commit/7e629e4e888262abd8f076512b252208acd72d62 DIFF: https://github.com/llvm/llvm-project/commit/7e629e4e888262abd8f076512b252208acd72d62.diff L

[clang] 7f48154 - Re-apply "[clang][Interp] Fix left-/right-shifting more than sizeof(unsigned)"

Author: Timm Bäder Date: 2023-01-26T08:02:27+01:00 New Revision: 7f48154ca11fee6579fe29a51ab2a329424d31c4 URL: https://github.com/llvm/llvm-project/commit/7f48154ca11fee6579fe29a51ab2a329424d31c4 DIFF: https://github.com/llvm/llvm-project/commit/7f48154ca11fee6579fe29a51ab2a329424d31c4.diff LO

[PATCH] D142564: [clang-doc] Reduce duplicate code with template

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142564/new/ https://reviews.llvm.org/D142564 ___

<    1   2   3