[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman added a comment. @erichkeane I've added more test coverage with different USR values, C++ decls and some dependent C++ decls too. How does it look now? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324 _

[PATCH] D142028: [clang] remove SUBMODULE_TOPHEADER

akyrtzi added a comment. This is useful for functionality, like in an IDE, to show the top headers of a module import for navigational purposes. Is it reasonable to at least have an alternative implementation for it (e.g. from the module headers find the headers that were not included from other

[PATCH] D140628: [flang] Add driver install directory to AIX toolchain program paths list

pscoro added a comment. I have added a couple more reviewers based on revision history of the file being modified. If anybody is aware of anybody else who should be aware of this revision that would be appreciated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

python3kgae added a comment. In D136031#4062756 , @beanz wrote: > @python3kgae, this change introduced a bunch of warning spew because it is > using an API that was deprecated shortly before the change merged. Can you > please address this? Sure. I'll

[PATCH] D141831: [clang][Interp] Fix double-printing in InterpFrame::describe()

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141831/new/ https://reviews.llvm.org/D141831 _

[PATCH] D141772: [clang][Interp] Fix record initialization via CallExpr subclasses

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. > I think the patch itself is mostly obvious, but I was wondering if it is the > right time to add such RUN lines to existing test cases like I do here for > test/SemaCXX/constex

[clang] ecade80 - [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

Author: Caleb Zulawski Date: 2023-01-18T18:20:59Z New Revision: ecade80d93960ad01d8665db02c23841e055a80f URL: https://github.com/llvm/llvm-project/commit/ecade80d93960ad01d8665db02c23841e055a80f DIFF: https://github.com/llvm/llvm-project/commit/ecade80d93960ad01d8665db02c23841e055a80f.diff LOG

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

This revision was automatically updated to reflect the committed changes. Closed by commit rGecade80d9396: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified (authored by calebzulawski, committed by jryans). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D140803: [clang][Interp] Implement C++ Range-for loops

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeStmtGen.cpp:404-409 + if (Cond) { +if (!this->visitBool(Cond)) + return false; +if (!this->jumpFalse(EndLabel)) + return false; + } Under what circumstances is there

[PATCH] D141800: [clangd] Fix qualifier not being dropped for using declaration referring to scoped enum

tom-anders added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1993 Builder.emplace(Recorder ? &Recorder->CCSema->getASTContext() : nullptr, -Item, SemaCCS, QueryScopes, *Inserter, FileName, +Recor

[PATCH] D141800: [clangd] Fix qualifier not being dropped for using declaration referring to scoped enum

tom-anders added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1993 Builder.emplace(Recorder ? &Recorder->CCSema->getASTContext() : nullptr, -Item, SemaCCS, QueryScopes, *Inserter, FileName, +Recor

[PATCH] D137113: [Clang] refactor CodeGenFunction::EmitAsmStmt NFC

nickdesaulniers updated this revision to Diff 490245. nickdesaulniers added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137113/new/ https://reviews.llvm.org/D137113 Files: clang/lib/CodeGen/CGStmt.cpp Index: clang/lib/Code

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers updated this revision to Diff 490246. nickdesaulniers added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136497/new/ https://reviews.llvm.org/D136497 Files: clang/docs/LanguageExtensions.rst clang/docs/Rele

[PATCH] D140508: [clang] fix -Wuninitialized for asm goto outputs on indirect edges.

nickdesaulniers updated this revision to Diff 490247. nickdesaulniers added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140508/new/ https://reviews.llvm.org/D140508 Files: clang/lib/Analysis/UninitializedValues.cpp clang/

[PATCH] D141636: [libTooling] Rename `getRangeForEdit` as `getFileRangeForEdit`

li.zhe.hua updated this revision to Diff 490248. li.zhe.hua added a comment. Update test name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141636/new/ https://reviews.llvm.org/D141636 Files: clang/include/clang/Tooling/Transformer/SourceCode.h

[clang] 2307029 - [libTooling] Rename `getRangeForEdit` as `getFileRangeForEdit`

Author: Eric Li Date: 2023-01-18T13:58:26-05:00 New Revision: 2307029b1a43a86aa6614c33aa198addf82d486b URL: https://github.com/llvm/llvm-project/commit/2307029b1a43a86aa6614c33aa198addf82d486b DIFF: https://github.com/llvm/llvm-project/commit/2307029b1a43a86aa6614c33aa198addf82d486b.diff LOG:

[PATCH] D141636: [libTooling] Rename `getRangeForEdit` as `getFileRangeForEdit`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2307029b1a43: [libTooling] Rename `getRangeForEdit` as `getFileRangeForEdit` (authored by li.zhe.hua). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D142046: [BPF][clang] Ignore stack protector options for BPF target

eddyz87 created this revision. Herald added a project: All. eddyz87 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Stack protector builtin functions are not implemented for BPF target, thus compiling programs with one of the follow

[PATCH] D141744: [Clang] Add lifetimebound attribute to std::move/std::forward

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. The code changes LGTM, but should we update the documentation in `LanguageExtensions.rst` and add a release note for the changes? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D142048: [Phabricator] Fix __ptr32 arguments passed to builtins

Ariel-Burton created this revision. Herald added subscribers: arichardson, Anastasia. Herald added a project: All. Ariel-Burton requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently when clang deals with a call to a builtin function tha

[PATCH] D139774: [libclang] Add API to set temporary directory location

vedgy added a comment. After a discussion under the corresponding KDevelop merge request, I can see 4-6 alternative ways to address the temporary directory issue: 1. Add an option to store the //preamble-*.pch// files in RAM instead of /tmp and add a corresponding option in KDevelop configurati

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

tahonermann added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:377-380 + SubstitutedExpression = ImplicitCastExpr::Create( + S.Context, SubstitutedExpression.get()->getType(), + CK_LValueToRValue, SubstitutedExpression.get(), +

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

nickdesaulniers added a comment. In D141451#4045658 , @efriedma wrote: > clang has a "LocTrackingOnly" setting for debug info, which emits DILocation > info into the IR, but emits a marker into the DICompileUnit to skip emitting > the .debug_info in the

[PATCH] D142046: [BPF][clang] Ignore stack protector options for BPF target

eddyz87 added a comment. Slightly above my edit there is a similar logic for NVPTX target: static void RenderSSPOptions(const Driver &D, const ToolChain &TC, const ArgList &Args, ArgStringList &CmdArgs, bool KernelOrKext) { const

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

francii updated this revision to Diff 490261. francii added a comment. Remove codegen option approach Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files: clang/include/clang/Driver/Options.td clang

[PATCH] D140489: Add builtin_elementwise_log

bob80905 added a comment. Herald added a subscriber: luke. Ping, can someone please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140489/new/ https://reviews.llvm.org/D140489 ___ cfe-commits

[PATCH] D141310: [clang] add -Wcompare-function-pointers

dblaikie added a comment. In D141310#4062776 , @adriandole wrote: > @dblaikie, we would use this warning in Chrome OS. Ah, good to know! > We use `icf=all` and have encountered bugs caused by function pointer > comparisons. & the savings are worth it

[PATCH] D142028: [clang] remove SUBMODULE_TOPHEADER

rmaz added a comment. In D142028#4062798 , @akyrtzi wrote: > Is it reasonable to at least have an alternative implementation for it (e.g. > from the module headers find the headers that were not included from other > headers), not sure if it'd be straig

[PATCH] D140158: [CUDA] Allow targeting NVPTX directly without a host toolchain

tra added a comment. LGTM overall, with few nits. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:448-450 + // If we are invoking `nvlink` internally we need to output a `.cubin` file. + // Checking if the output is a temporary is the cleanest way to determine + // this. Pu

[PATCH] D141785: [Clang][LoongArch] Implement patchable function entry

aaron.ballman added a comment. The Clang bits LGTM, though you should add a release note about the new functionality so users know about it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141785/new/ https://reviews.llvm.org/D141785 __

[PATCH] D140158: [CUDA] Allow targeting NVPTX directly without a host toolchain

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:448-450 + // If we are invoking `nvlink` internally we need to output a `.cubin` file. + // Checking if the output is a temporary is the cleanest way to determine + // this. Putting this logic in `

[PATCH] D140158: [CUDA] Allow targeting NVPTX directly without a host toolchain

jhuber6 marked an inline comment as done. jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.h:196-197 + + void AddCudaIncludeArgs(const llvm::opt::ArgList &DriverArgs, llvm::opt::ArgStringList &CC1Args) const override; ---

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

erichkeane added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1755 + String that specifies a unified symbol resolution (USR) value for this + declaration. USR string uniquely identifies this particular declaration, and + is typically used when constructin

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1764 + the ``external_source_symbol`` attribute with + ``__has_attribute(external_source_symbol_with_usr)``. + erichkeane wrote: > I don't think we can do this. __has_attrib

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

dblaikie added a comment. In D141451#4063151 , @nickdesaulniers wrote: > In D141451#4045658 , @efriedma > wrote: > >> clang has a "LocTrackingOnly" setting for debug info, which emits DILocation >> info into th

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:377-380 + SubstitutedExpression = ImplicitCastExpr::Create( + S.Context, SubstitutedExpression.get()->getType(), + CK_LValueToRValue, SubstitutedExpression.get(), +

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1764 + the ``external_source_symbol`` attribute with + ``__has_attribute(external_source_symbol_with_usr)``. + aaron.ballman wrote: > erichkeane wrote: > > I don't think we can do

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

erichkeane added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1764 + the ``external_source_symbol`` attribute with + ``__has_attribute(external_source_symbol_with_usr)``. + arphaman wrote: > aaron.ballman wrote: > > erichkeane wrote: > > >

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1764 + the ``external_source_symbol`` attribute with + ``__has_attribute(external_source_symbol_with_usr)``. + erichkeane wrote: > arphaman wrote: > > aaron.ballman wrote: >

[PATCH] D141441: [clang] Add ElaboratedType sugaring for types on implicit special members

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. This makes sense to me, and it looks like the memory impact from the extra type nodes should be relatively small. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D136913: [HLSL] support RWByteAddressBuffer.

python3kgae updated this revision to Diff 490274. python3kgae added a comment. Rebase and update test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136913/new/ https://reviews.llvm.org/D136913 Files: clang/include/clang/Sema/HLSLExternalSemaSou

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

doru1004 updated this revision to Diff 490277. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141871/new/ https://reviews.llvm.org/D141871 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/Basic/DiagnosticParseKinds.td clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

doru1004 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1166-1168 +return llvm::any_of(Top->IteratorVarDecls, [VD](const VarDecl *IteratorVD) { + return IteratorVD == VD->getCanonicalDecl(); +}); ABataev wrote: > doru1004 wrote: >

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1166-1168 +return llvm::any_of(Top->IteratorVarDecls, [VD](const VarDecl *IteratorVD) { + return IteratorVD == VD->getCanonicalDecl(); +}); doru1004 wrote: > ABataev wrote: > >

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

erichkeane updated this revision to Diff 490278. erichkeane added a comment. Added tests suggested by Tom, also moved the cast creation after checking of the return type, so that we end up not hitting hte assert that Tom came up with. Added 2 tests that show the two conditions (that DID repro a

[PATCH] D141868: [Clang] [Sema] Removed a fix-it for system headers

NoQ added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:10923-10927 +for (std::vector::iterator HI = Cand->Fix.Hints.begin(), + HE = Cand->Fix.Hints.end(); + HI != HE; ++HI) +FDiag << *HI; + } --

[clang-tools-extra] d3da906 - [CMake] Allow setting the location of host tools with LLVM_NATIVE_TOOL_DIR

Author: Martin Storsjö Date: 2023-01-18T23:56:15+02:00 New Revision: d3da9067d143f3d4ce59b6d9ab4606a8ef1dc937 URL: https://github.com/llvm/llvm-project/commit/d3da9067d143f3d4ce59b6d9ab4606a8ef1dc937 DIFF: https://github.com/llvm/llvm-project/commit/d3da9067d143f3d4ce59b6d9ab4606a8ef1dc937.diff

[PATCH] D131052: [CMake] Allow setting the location of host tools with LLVM_NATIVE_TOOL_DIR

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd3da9067d143: [CMake] Allow setting the location of host tools with LLVM_NATIVE_TOOL_DIR (authored by mstorsjo). Repository: rG LLVM Github Monore

[PATCH] D140875: [clangd] prototype: Implement unused include warnings with include-cleaner library.

hokein updated this revision to Diff 490287. hokein added a comment. update the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140875/new/ https://reviews.llvm.org/D140875 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

nickdesaulniers added a comment. In D141451#4063335 , @dblaikie wrote: > In D141451#4063151 , > @nickdesaulniers wrote: > >> In D141451#4045658 , @efriedma >> wrote: >>

[PATCH] D141424: [clang][Sema] Fix uninitialized `SourceLocation` for types with multiple attributes and macros.

vsapsai added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141424/new/ https://reviews.llvm.org/D141424 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] 304d730 - [clang][Sema] Fix uninitialized `SourceLocation` for types with multiple attributes and macros.

Author: Volodymyr Sapsai Date: 2023-01-18T16:15:53-06:00 New Revision: 304d7307aee15b6eb88d198ae94b595f4e09f485 URL: https://github.com/llvm/llvm-project/commit/304d7307aee15b6eb88d198ae94b595f4e09f485 DIFF: https://github.com/llvm/llvm-project/commit/304d7307aee15b6eb88d198ae94b595f4e09f485.di

[PATCH] D141424: [clang][Sema] Fix uninitialized `SourceLocation` for types with multiple attributes and macros.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG304d7307aee1: [clang][Sema] Fix uninitialized `SourceLocation` for types with multiple… (authored by vsapsai). Repository: rG LLVM Github Monorepo

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

dblaikie added a comment. In D141451#4063504 , @nickdesaulniers wrote: > In D141451#4063335 , @dblaikie > wrote: > >> In D141451#4063151 , >> @nickdesaulniers wrote: >>

[clang] 39a63fc - [-Wunsafe-buffer-usage] Use relevant source locations for warnings

Author: Jan Korous Date: 2023-01-18T14:18:54-08:00 New Revision: 39a63fc7fe9824313764a9da8565a705d3024b1a URL: https://github.com/llvm/llvm-project/commit/39a63fc7fe9824313764a9da8565a705d3024b1a DIFF: https://github.com/llvm/llvm-project/commit/39a63fc7fe9824313764a9da8565a705d3024b1a.diff LO

[PATCH] D141340: [-Wunsafe-buffer-usage] Use relevant source locations for warnings

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG39a63fc7fe98: [-Wunsafe-buffer-usage] Use relevant source locations for warnings (authored by jkorous). Herald added a project: clang. Herald added a

[clang] a033dbb - [Clang] Give Clang the ability to use a shared stat cache

Author: Fred Riss Date: 2023-01-18T14:31:27-08:00 New Revision: a033dbbe5c43247b60869b008e67ed86ed230eaa URL: https://github.com/llvm/llvm-project/commit/a033dbbe5c43247b60869b008e67ed86ed230eaa DIFF: https://github.com/llvm/llvm-project/commit/a033dbbe5c43247b60869b008e67ed86ed230eaa.diff LOG

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa033dbbe5c43: [Clang] Give Clang the ability to use a shared stat cache (authored by friss). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

tahonermann added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:377-380 + SubstitutedExpression = ImplicitCastExpr::Create( + S.Context, SubstitutedExpression.get()->getType(), + CK_LValueToRValue, SubstitutedExpression.get(), +

Re: [clang] a033dbb - [Clang] Give Clang the ability to use a shared stat cache

Looks like my comments on the review got completely ignored and not even acknowledged. On Thu, Jan 19, 2023 at 1:35 AM Fred Riss via cfe-commits wrote: > > > Author: Fred Riss > Date: 2023-01-18T14:31:27-08:00 > New Revision: a033dbbe5c43247b60869b008e67ed86ed230eaa > > URL: > https://github.com

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

nickdesaulniers added a comment. In D141451#4063519 , @dblaikie wrote: > In D141451#4063504 , > @nickdesaulniers wrote: > >> In D141451#4063335 , @dblaikie >> wrote: >>

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss added a subscriber: lebedev.ri. friss added a comment. In D136651#4060071 , @lebedev.ri wrote: > Docs still missing. Sorry @lebedev.ri I missed your earlier comment about this. What format of doc would you like to see? A more elaborate comment in

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

doru1004 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1166-1168 +return llvm::any_of(Top->IteratorVarDecls, [VD](const VarDecl *IteratorVD) { + return IteratorVD == VD->getCanonicalDecl(); +}); ABataev wrote: > doru1004 wrote: >

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

lebedev.ri added a comment. In D136651#4063597 , @friss wrote: > In D136651#4060071 , @lebedev.ri > wrote: > >> Docs still missing. > > Sorry @lebedev.ri I missed your earlier comment about this. What format of

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1764 + the ``external_source_symbol`` attribute with + ``__has_attribute(external_source_symbol_with_usr)``. + aaron.ballman wrote: > erichkeane wrote: > > arphaman wrote: > > > a

[clang] 237ca43 - [-Wunsafe-buffer-usage] Group diagnostics by variable

Author: Jan Korous Date: 2023-01-18T15:00:22-08:00 New Revision: 237ca436adf48c72821afd9fa6e031ec1d4a0420 URL: https://github.com/llvm/llvm-project/commit/237ca436adf48c72821afd9fa6e031ec1d4a0420 DIFF: https://github.com/llvm/llvm-project/commit/237ca436adf48c72821afd9fa6e031ec1d4a0420.diff LO

[PATCH] D141356: [-Wunsafe-buffer-usage] Group diagnostics by variable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG237ca436adf4: [-Wunsafe-buffer-usage] Group diagnostics by variable (authored by jkorous). Herald added a project: clang. Herald added a subscriber:

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1166-1168 +return llvm::any_of(Top->IteratorVarDecls, [VD](const VarDecl *IteratorVD) { + return IteratorVD == VD->getCanonicalDecl(); +}); doru1004 wrote: > ABataev wrote: > >

[PATCH] D141744: [Clang] Add lifetimebound attribute to std::move/std::forward

alexander-shaposhnikov updated this revision to Diff 490313. alexander-shaposhnikov added a comment. @aaron.ballman - thanks for the review, I've updated the release notes. Regarding LanguageExtensions.rst - somehow I don't see any appropriate sections in LanguageExtensions.rst (either about o

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

doru1004 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1166-1168 +return llvm::any_of(Top->IteratorVarDecls, [VD](const VarDecl *IteratorVD) { + return IteratorVD == VD->getCanonicalDecl(); +}); doru1004 wrote: > ABataev wrote: >

[clang] debfa43 - [Clang][NFC] Clang-format CUDA toolchain file

Author: Joseph Huber Date: 2023-01-18T17:15:03-06:00 New Revision: debfa43117f458cd75e3d0a7b37f7622c7c67d40 URL: https://github.com/llvm/llvm-project/commit/debfa43117f458cd75e3d0a7b37f7622c7c67d40 DIFF: https://github.com/llvm/llvm-project/commit/debfa43117f458cd75e3d0a7b37f7622c7c67d40.diff

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

doru1004 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1166-1168 +return llvm::any_of(Top->IteratorVarDecls, [VD](const VarDecl *IteratorVD) { + return IteratorVD == VD->getCanonicalDecl(); +}); ABataev wrote: > doru1004 wrote: >

[PATCH] D140158: [CUDA] Allow targeting NVPTX directly without a host toolchain

jhuber6 updated this revision to Diff 490317. jhuber6 added a comment. Addressing some comments. I don't know if there's a cleaner way to mess around with the `.cubin` nonsense. I liked symbolic links but that doesn't work on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

doru1004 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1166-1168 +return llvm::any_of(Top->IteratorVarDecls, [VD](const VarDecl *IteratorVD) { + return IteratorVD == VD->getCanonicalDecl(); +}); doru1004 wrote: > ABataev wrote: >

[PATCH] D140158: [CUDA] Allow targeting NVPTX directly without a host toolchain

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM with few minor nits and questions. In D140158#4063689 , @jhuber6 wrote: > Addressing some comments. I don't know if there's a cleaner way to mess > ar

[PATCH] D140158: [CUDA] Allow targeting NVPTX directly without a host toolchain

jhuber6 marked 3 inline comments as done. jhuber6 added a comment. In D140158#4063720 , @tra wrote: > LGTM with few minor nits and questions. > > In D140158#4063689 , @jhuber6 wrote: > >> Addressing some comments.

[PATCH] D141968: [NFC] Consolidate llvm::CodeGenOpt::Level handling

scott.linder updated this revision to Diff 490321. scott.linder marked 2 inline comments as done. scott.linder added a comment. - Fix return type of `getID` - Fix mistakenly updated option help text - Add back in missing `assert`s Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

paulkirth updated this revision to Diff 490323. paulkirth added a comment. Herald added a subscriber: luke. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135488 Files: clang/docs/ReleaseNotes.rst cl

[PATCH] D137113: [Clang] refactor CodeGenFunction::EmitAsmStmt NFC

void accepted this revision. void added a comment. Still LGTM :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137113/new/ https://reviews.llvm.org/D137113 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D141968: [NFC] Consolidate llvm::CodeGenOpt::Level handling

scott.linder added inline comments. Comment at: llvm/include/llvm/Support/CodeGen.h:57 + /// Code generation optimization level. + enum Level : IDType { +None = 0, ///< -O0 barannikov88 wrote: > arsenm wrote: > > scott.linder wrote: > > > This is ABI b

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

void added inline comments. Comment at: clang/docs/ReleaseNotes.rst:199 + guaranteed (and necessary to support outputs along indirect edges, which is + now supported as of this release). + Is it worth it to mention that this change makes Clang's behavior with r

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss added a comment. In D136651#4063632 , @lebedev.ri wrote: > In D136651#4063597 , @friss wrote: > >> In D136651#4060071 , @lebedev.ri >> wrote: >> >>> Docs still mis

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

lebedev.ri added a comment. In D136651#4063818 , @friss wrote: > In D136651#4063632 , @lebedev.ri > wrote: > >> In D136651#4063597 , @friss wrote: >> >>> In D136651#40600

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

doru1004 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1166-1168 +return llvm::any_of(Top->IteratorVarDecls, [VD](const VarDecl *IteratorVD) { + return IteratorVD == VD->getCanonicalDecl(); +}); doru1004 wrote: > doru1004 wrote: >

[clang] 0660397 - [CUDA] Allow targeting NVPTX directly without a host toolchain

Author: Joseph Huber Date: 2023-01-18T18:18:25-06:00 New Revision: 0660397e68096a64279b19f913e7de2c283e524f URL: https://github.com/llvm/llvm-project/commit/0660397e68096a64279b19f913e7de2c283e524f DIFF: https://github.com/llvm/llvm-project/commit/0660397e68096a64279b19f913e7de2c283e524f.diff

[PATCH] D140158: [CUDA] Allow targeting NVPTX directly without a host toolchain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jhuber6 marked 3 inline comments as done. Closed by commit rG0660397e6809: [CUDA] Allow targeting NVPTX directly without a host toolchain (authored by jhuber6). Change

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

doru1004 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:22399-22412 bool Sema::isOpenMPDeclareMapperVarDeclAllowed(const VarDecl *VD) const { assert(LangOpts.OpenMP && "Expected OpenMP mode."); const Expr *Ref = DSAStack->getDeclareMapperVarRef(); if (

[PATCH] D141968: [NFC] Consolidate llvm::CodeGenOpt::Level handling

barannikov88 added inline comments. Comment at: llvm/include/llvm/Support/CodeGen.h:57 + /// Code generation optimization level. + enum Level : IDType { +None = 0, ///< -O0 scott.linder wrote: > barannikov88 wrote: > > arsenm wrote: > > > scott.linder

[PATCH] D142065: [SVE] Fix incorrect lowering of predicate permute builtins.

paulwalker-arm created this revision. Herald added subscribers: psnobl, hiraditya, tschuett. Herald added a reviewer: efriedma. Herald added a project: All. paulwalker-arm requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Wh

[PATCH] D142065: [SVE] Fix incorrect lowering of predicate permute builtins.

paulwalker-arm added reviewers: david-arm, CarolineConcatto, peterwaller-arm. paulwalker-arm added a comment. This is bug fix based on something spotted when reviewing D141469 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D140179: [WIP][-Wunsafe-buffer-usage] Add unsafe buffer checking opt-out pragmas

NoQ added inline comments. Comment at: clang/include/clang/Basic/Diagnostic.h:1040-1043 + // An ordered sequence of "-Wunsafe-buffer-usage" opt-out regions in one + // translation unit. Each region is represented by a pair of start and end + // locations. + SmallVector, 8> S

[clang] 557a5bc - [codegen] Add StackFrameLayoutAnalysisPass

Author: Paul Kirth Date: 2023-01-19T01:51:14Z New Revision: 557a5bc336ffb9b03c53d4d13fd8f0bc9418ec96 URL: https://github.com/llvm/llvm-project/commit/557a5bc336ffb9b03c53d4d13fd8f0bc9418ec96 DIFF: https://github.com/llvm/llvm-project/commit/557a5bc336ffb9b03c53d4d13fd8f0bc9418ec96.diff LOG: [c

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG557a5bc336ff: [codegen] Add StackFrameLayoutAnalysisPass (authored by paulkirth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c79635c - [NFC] [Serialization] Add static assert for the size of the decls to

Author: Chuanqi Xu Date: 2023-01-19T10:20:29+08:00 New Revision: c79635cce845d66897970cd7f8d7c77b0a3c0286 URL: https://github.com/llvm/llvm-project/commit/c79635cce845d66897970cd7f8d7c77b0a3c0286 DIFF: https://github.com/llvm/llvm-project/commit/c79635cce845d66897970cd7f8d7c77b0a3c0286.diff LO

[PATCH] D141992: [NFC] [Serialization] Add static assert for the size of the decls to mention developers to remember to touch the serializer after them modified the field of decls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc79635cce845: [NFC] [Serialization] Add static assert for the size of the decls to (authored by ChuanqiXu). Herald added a project: clang. Herald add

[PATCH] D141798: Remove ZeroBehavior of countLeadingZeros and the like (NFC)

kazu updated this revision to Diff 490348. kazu added a comment. Updated the patch to leave findFirstSet and findLastSet untouched. Added a comment about the behavior on 0/max input. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141798/new/ https:

[PATCH] D141798: Remove ZeroBehavior of countLeadingZeros and the like (NFC)

kazu marked an inline comment as done. kazu added a comment. In D141798#4055050 , @barannikov88 wrote: > It would be nice to have comments reflecting the new behavior in the case of > 0 / max value. I've added comments to all four functions -- count{L

[PATCH] D141798: Drop the ZeroBehavior parameter from countLeadingZeros and the like (NFC)

kazu marked an inline comment as done. kazu added a comment. Please take a look. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141798/new/ https://reviews.llvm.org/D141798 ___ cfe-commits mailin

[PATCH] D141992: [NFC] [Serialization] Add static assert for the size of the decls to mention developers to remember to touch the serializer after them modified the field of decls

thakis added inline comments. Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:2313 void ASTDeclWriter::VisitOMPDeclareMapperDecl(OMPDeclareMapperDecl *D) { + static_assert(sizeof(OMPDeclareMapperDecl) == 120, +"You need to update the serializer after you c

[PATCH] D71734: [ODRHash] Hash `RecordDecl` and diagnose discovered mismatches.

vsapsai updated this revision to Diff 490354. vsapsai added a comment. `setODRHash(0)` for consistency, mention the change in Potentially Breaking Changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71734/new/ https://reviews.llvm.org/D71734 F

<    1   2   3   >