[PATCH] D141670: [include-cleaner] FindHeaders respects IWYU export pragma for standard headers.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/include-cleaner/lib/Record.cpp:192 int HashLine = SM.getLineNumber(HashFID, SM.getFileOffset(HashLoc)); -checkForExport(Has

[PATCH] D140693: [Driver][RISCV] Adjust the priority between -mcpu, -mtune and -march

kito-cheng marked 6 inline comments as done. kito-cheng added inline comments. Comment at: clang/test/Driver/riscv-cpus.c:86 +// MCPU-ABI-SIFIVE-S21: "-target-feature" "+c" +// MCPU-ABI-SIFIVE-S21: "-target-feature" "+64bit" // MCPU-ABI-SIFIVE-S21: "-target-abi" "lp64" -

[clang] f601039 - [Driver][RISCV] Adjust the priority between -mcpu, -mtune and -march

Author: Kito Cheng Date: 2023-01-13T23:58:31+08:00 New Revision: f601039e8165cb2a49c783ccf4aafd1f7b326a63 URL: https://github.com/llvm/llvm-project/commit/f601039e8165cb2a49c783ccf4aafd1f7b326a63 DIFF: https://github.com/llvm/llvm-project/commit/f601039e8165cb2a49c783ccf4aafd1f7b326a63.diff LO

[PATCH] D140693: [Driver][RISCV] Adjust the priority between -mcpu, -mtune and -march

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. kito-cheng marked 2 inline comments as done. Closed by commit rGf601039e8165: [Driver][RISCV] Adjust the priority between -mcpu, -mtune and -march (authored by kito-che

[libunwind] 226798f - [libunwind] Fixed an upcoming clang -Wsign-conversion warning

Author: Fahad Nayyar Date: 2023-01-13T16:01:37Z New Revision: 226798f3aa2f8467a29d909f0b18dbc4dfb398f7 URL: https://github.com/llvm/llvm-project/commit/226798f3aa2f8467a29d909f0b18dbc4dfb398f7 DIFF: https://github.com/llvm/llvm-project/commit/226798f3aa2f8467a29d909f0b18dbc4dfb398f7.diff LOG:

[PATCH] D138792: [AArch64] Improve TargetParser API

danielkiss added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:532 getTargetDefinesARMV81A(Opts, Builder); -break; - case llvm::AArch64::ArchKind::ARMV8_2A: + if (*ArchInfo == llvm::AArch64::ARMV8_2A) getTargetDefinesARMV82A(Opts, Builder);

[PATCH] D141591: [clang][Interp] Properly identify not-yet-defined functions

tbaeder updated this revision to Diff 489020. tbaeder added a comment. Just get the information whether the `Function` has a body directly from the `FunctionDecl`. This fixes referencing member functions that are defined later. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141591/new/

[clang] 4c37671 - [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

Author: Fahad Nayyar Date: 2023-01-13T16:04:42Z New Revision: 4c37671a7c946ac246b52fa44a6a649b89d6310b URL: https://github.com/llvm/llvm-project/commit/4c37671a7c946ac246b52fa44a6a649b89d6310b DIFF: https://github.com/llvm/llvm-project/commit/4c37671a7c946ac246b52fa44a6a649b89d6310b.diff LOG:

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4c37671a7c94: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment… (authored by fahadnayyar). Repository: rG LLVM Github Mono

[PATCH] D92733: Fix PR25627 - false positive diagnostics involving implicit-captures in dependent lambda expressions.

shafik added a comment. In D92733#4051123 , @faisalv wrote: > I'll try and look into it this weekend and have some sort of updated news > for you by monday? > Faisal Vali Awesome, feel free to add me as a reviewer. If we can get this fixed that would awe

[PATCH] D140724: [clang][Interp] Add back Run() call

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/AST/Interp/Interp.h:1301 assert(S.Current->getFunction()->hasRVO()); + if (S.checkingPotentialConstantExpression()) +return false;

[PATCH] D133574: [C2x] reject type definitions in offsetof

bkramer added a comment. GitHub finds around 1.9k instances of this pattern to compute `alignof`. There's a lot of duplicates and `#ifdefs` so the real number is going to be smaller, but it seems to be quite common. The annoying part is that there is no `_Alignof` in C99 so for many of those pr

[PATCH] D131052: [CMake] Allow setting the location of host tools with LLVM_NATIVE_TOOL_DIR

beanz added inline comments. Comment at: llvm/cmake/modules/AddLLVM.cmake:2401 + +macro(setup_host_tool tool_name setting_name exe_var_name target_var_name) + cmake_parse_arguments(ARG "" "SCOPE" "" ${ARGN}) Please make this a `function` instead of a `macro`. In

[PATCH] D141698: doc: Rewrite opening paragraph of CFI Design Doc

1c3t3a created this revision. Herald added a project: All. 1c3t3a requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D141698 Files: clang/docs/ControlFlowIntegrityDesign.rst

[PATCH] D141423: Trigger the Clang/libc++ CI pipeline even when libc++ has been modified

Mordante added a comment. Should this also fix the issue where the scheduled build sometimes picks the "clang build"? For example https://buildkite.com/llvm-project/libcxx-ci/builds/17300 but I noticed to at other times too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D138792: [AArch64] Improve TargetParser API

tmatheson added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:532 getTargetDefinesARMV81A(Opts, Builder); -break; - case llvm::AArch64::ArchKind::ARMV8_2A: + if (*ArchInfo == llvm::AArch64::ARMV8_2A) getTargetDefinesARMV82A(Opts, Builder); -

[PATCH] D141700: AMDGPU: Move enqueued block handling into clang

arsenm created this revision. arsenm added reviewers: yaxunl, t-tye, b-sumner, rampitec, AMDGPU, Anastasia, JonChesterfield, jhuber6. Herald added subscribers: kosarev, foad, kerbowa, hiraditya, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. arsenm requested review of this revisi

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

jyu2 added a comment. That part of code is original add for is_device_address, so I just wonder, if the change could break is_device_address? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141627/new/ https://reviews.llvm.org/D141627 _

[PATCH] D141580: [clang] Don't consider a nullptr returned from ActOnTag() as a valid result in ParseClassSpecifier.

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:2069-2078 +if (auto *TagDecl = Actions.ActOnTag( +getCurScope(), TagType, TUK, StartLoc, SS, Name, NameLoc, attrs, AS, +DS.getModulePrivateSpecLoc(), TParams, Owned, IsD

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 489031. pmatos marked 2 inline comments as done. pmatos added a comment. Address a few comments, add new test for funcref keyword diagnostic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://rev

[PATCH] D138802: [clang][Interp] Implement DecompositionDecls

shafik added inline comments. Comment at: clang/test/AST/Interp/cxx17.cpp:7 + +struct F { int a; int b;}; +constexpr F getF() { tbaeder wrote: > shafik wrote: > > It would also be good to test references, bit-fields, volatile and > > tuple-like types if possible

[PATCH] D131052: [CMake] Allow setting the location of host tools with LLVM_NATIVE_TOOL_DIR

mstorsjo added inline comments. Comment at: llvm/cmake/modules/AddLLVM.cmake:2401 + +macro(setup_host_tool tool_name setting_name exe_var_name target_var_name) + cmake_parse_arguments(ARG "" "SCOPE" "" ${ARGN}) beanz wrote: > Please make this a `function` instea

[PATCH] D133574: [C2x] reject type definitions in offsetof

aaron.ballman reopened this revision. aaron.ballman added reviewers: clang-vendors, mgorny, thesamesam. aaron.ballman added a comment. This revision is now accepted and ready to land. In D133574#4051782 , @bkramer wrote: > GitHub finds around 1.9k instanc

[PATCH] D133574: [C2x] reject type definitions in offsetof

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Marking this as needing changes so it doesn't look accepted to the new reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D140668: [clang][Interp] Implement remaining bits for MaterializeTemporaryExprs

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140668/new/ https://reviews.llvm.org/D140668 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D141528: [Clang][OpenMP] Fix loop directive nested inside a parallel

doru1004 updated this revision to Diff 489035. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141528/new/ https://reviews.llvm.org/D141528 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/test/OpenMP/nested_loop_codegen.cpp Index: clang/test/OpenMP/nested_loop_codegen.cpp

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

paulkirth updated this revision to Diff 489036. paulkirth added a comment. Fix test for Windows. I had missed one of the file paths in YAML. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135488 Files: clang/

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM @aaron.ballman are you happy with this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135750/new/ https://reviews.llvm.org/D135750 _

[PATCH] D131052: [CMake] Allow setting the location of host tools with LLVM_NATIVE_TOOL_DIR

beanz added a comment. The convention that `find_program` uses is to cache the variables, which causes them to be defined at global scope. That also avoids needing to recompute filesystem lookups in incremental builds, which is desirable. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D141681: [clang][Interp] Fix parameter map when re-visiting function

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:57 +ParamDescriptors.insert({ParamOffset, {Ty, Desc}}); +Params.insert({PD, ParamOffset}); +ParamOffset

[PATCH] D133574: [C2x] reject type definitions in offsetof

tlively added a comment. FWIW I had to patch the musl used by Emscripten to work around this: https://github.com/emscripten-core/emscripten/pull/18510 The fix was simple and I don't have a strong opinion about the right way forward, but this change was slightly disruptive and I imagine other pr

[PATCH] D133574: [C2x] reject type definitions in offsetof

philnik added a comment. In D133574#4051899 , @aaron.ballman wrote: > In D133574#4051782 , @bkramer wrote: > >> GitHub finds around 1.9k instances of this pattern to compute `alignof`. >> There's a lot of duplic

[PATCH] D131858: [clang] Track the templated entity in type substitution.

v.g.vassilev added a comment. Thanks a lot @rsmith for providing a fix and thanks a lot @aaron.ballman and @erichkeane for the efforts saving @mizvekov work over the summer. I believe he has sporadic access to internet and soon he will be back to normal. Great example of team work here!! Repo

[PATCH] D131858: [clang] Track the templated entity in type substitution.

erichkeane added a comment. In D131858#4052026 , @v.g.vassilev wrote: > Thanks a lot @rsmith for providing a fix and thanks a lot @aaron.ballman and > @erichkeane for the efforts saving @mizvekov work over the summer. I believe > he has sporadic access

[PATCH] D141644: [clang] Report the on-disk paths for inputs to module compiles

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. Please add a comment to each place you're doing this since it's non-obvious why the filename would be different to people not familiar with the mapping code. Otherwise LGTM Reposi

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

tianshilei1992 added a comment. In D141627#4051851 , @jyu2 wrote: > That part of code is original add for is_device_address, so I just wonder, if > the change could break is_device_address? Now I kinda think it is not right to mix `is_device_address` an

[PATCH] D141705: [HLSL] [Dirver] add dxv as a VerifyDebug Job

python3kgae created this revision. python3kgae added reviewers: beanz, pow2clk, bogner, bob80905. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. New opt

[PATCH] D140226: [NVPTX] Introduce attribute to mark kernels without a language mode

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. Precommit CI found failures that look relevant to the patch. > We may want to be able to mark certain regions as kernels even without being > in an accepted CUDA or OpenCL language mode. Can you explain this a bit more?

[PATCH] D131052: [CMake] Allow setting the location of host tools with LLVM_NATIVE_TOOL_DIR

mstorsjo added a comment. In D131052#4051948 , @beanz wrote: > The convention that `find_program` uses is to cache the variables, which > causes them to be defined at global scope. Right, I guess that could work too. It would be less of a pure refactori

[PATCH] D139949: [clang-scan-deps] Migrate to OptTable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0c60ec699fc1: [clang-scan-deps] Migrate to OptTable (authored by abrachet). Herald added a project: clang. Herald added a subscriber: cfe-commits. C

[PATCH] D139949: [clang-scan-deps] Migrate to OptTable

abrachet marked 2 inline comments as done. abrachet added inline comments. Comment at: utils/bazel/llvm-project-overlay/clang/BUILD.bazel:2207 ":frontend", +":ScanDepsTableGen", ":tooling", GMNGeoffrey wrote: > MaskRay wrote: > > Move th

[PATCH] D140226: [NVPTX] Introduce attribute to mark kernels without a language mode

jhuber6 added a comment. In D140226#4052105 , @aaron.ballman wrote: > Precommit CI found failures that look relevant to the patch. > >> We may want to be able to mark certain regions as kernels even without being >> in an accepted CUDA or OpenCL languag

[PATCH] D141690: [clang] fix consteval ctor code generation assert

luken-google updated this revision to Diff 489057. luken-google added a comment. Adds test and release note, refactors to avoid possible null pointer deref. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141690/new/ https://reviews.llvm.org/D141690

[PATCH] D141690: [clang] fix consteval ctor code generation assert

luken-google updated this revision to Diff 489058. luken-google added a comment. Add newline at end of test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141690/new/ https://reviews.llvm.org/D141690 Files: clang/docs/ReleaseNotes.rst cla

[PATCH] D141690: [clang] fix consteval ctor code generation assert

luken-google added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1338 + llvm::StructType *STy = dyn_cast(Val->getType()); + if (STy && STy->isLayoutIdentical(cast(Dest.getElementType( { for (unsigned i = 0, e = STy->getNumElements(); i != e; ++i) { ---

[PATCH] D141310: [clang] add -Wcompare-function-pointers

adriandole added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:565 +def CompareFunctionPointers : DiagGroup<"compare-function-pointers">; def OrderedCompareFunctionPointers : DiagGroup<"ordered-compare-function-pointers">; def PackedNonPod : DiagGr

[PATCH] D141708: [OpenMP] Make `-fopenmp-target=` use the `nvptx-arch` tool

jhuber6 created this revision. jhuber6 added reviewers: tianshilei1992, jdoerfert, tra. Herald added subscribers: kosarev, mattd, gchakrabarti, asavonic, guansong, tpr, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1,

[PATCH] D141709: [clang][dataflow] Fix bug in joining bool values.

ymandel created this revision. ymandel added reviewers: sgatev, xazax.hun, gribozavr2. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Currently, the code assumes that

[PATCH] D141450: [Clang][cc1] Add -fno-modules-local-submodule-visibility to override the default

jansvoboda11 added a comment. In D141450#4049049 , @dblaikie wrote: > Perhaps I've got things confused, but my understanding of LSV was that it > prevented other headers in the same modulemap from leaking into the > use/inclusion of one header in a modu

[PATCH] D141644: [clang] Report the on-disk paths for inputs to module compiles

jansvoboda11 updated this revision to Diff 489072. jansvoboda11 added a comment. Fix test on Windows(?), add comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141644/new/ https://reviews.llvm.org/D141644 Files: clang/lib/Frontend/DependencyF

[PATCH] D141620: clang/OpenCL: Apply default attributes to enqueued blocks

yaxunl added inline comments. Comment at: clang/test/CodeGenOpenCL/amdgpu-enqueue-kernel.cl:53-57 -__attribute__((target("s-memtime-inst"))) -void test_target_features_func(global int *i) { - queue_t default_queue; - unsigned flags = 0; - ndrange_t ndrange; wh

[PATCH] D140423: [WIP][clang] Add PrintingPolicy callback for identifying default template arguments

dblaikie added a comment. In D140423#4051262 , @aaron.ballman wrote: >> Add something like a bool IsDefaulted somewhere in Clang, e.g., in >> TemplateArgument and consult it from the TypePrinter. This would be much >> simpler but requires adding a fiel

[PATCH] D141620: clang/OpenCL: Apply default attributes to enqueued blocks

arsenm added inline comments. Comment at: clang/test/CodeGenOpenCL/amdgpu-enqueue-kernel.cl:53-57 -__attribute__((target("s-memtime-inst"))) -void test_target_features_func(global int *i) { - queue_t default_queue; - unsigned flags = 0; - ndrange_t ndrange; ya

[PATCH] D141450: [Clang][cc1] Add -fno-modules-local-submodule-visibility to override the default

dblaikie added a comment. In D141450#4052210 , @jansvoboda11 wrote: > In D141450#4049049 , @dblaikie > wrote: > >> Perhaps I've got things confused, but my understanding of LSV was that it >> prevented other he

[PATCH] D133574: [C2x] reject type definitions in offsetof

efriedma added a comment. Given the extension appears to have real-world usage, I don't see any reason to break that usage. All known implementations parse this the way the user expects, there isn't any chance the user meant to write something else, and there isn't any chance it will mean some

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

paulkirth added a comment. @nickdesaulniers @thegameg Are we happy w/ the ReleaseNotes and the documentation changes? If so, I'll land this, but I wasn't sure either of you saw those changes ... or if using `isFunctionInPrintList` for now is a good choice until we can implement filtering for re

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

abhinavgaba added subscribers: dreachem, kkwli0. abhinavgaba added a comment. > In target data we already put a and b in use_device_addr. That indicates all > use of a and b will be the corresponding device addresses. Therefore, in > target directive, we should use is_device_address instead of h

[PATCH] D133574: [C2x] reject type definitions in offsetof

aaron.ballman added a comment. In D133574#4052293 , @efriedma wrote: > Given the extension appears to have real-world usage, I don't see any reason > to break that usage. All known implementations parse this the way the user > expects, there isn't any

[PATCH] D141538: [cmake] Fix path to LLVMConfig.cmake for multi-config builds

nhat-nguyen added a comment. In D141538#4050784 , @sebastian-ne wrote: > The debian pre-checkin test is unfortunately quite unstable. I see the same > failures in D141469 for example. > This looks good to go. Would yo

[PATCH] D141714: Fix ast print of variables with attributes

giulianobelinassi created this revision. Herald added a project: All. giulianobelinassi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously clang AST prints the following declaration: int fun_var_unused() { int x __attribute__((u

[PATCH] D141206: [clang] [MinGW] Avoid adding /include and /lib when cross compiling

mati865 added a comment. I cannot speak much about LLVM tests but the code looks good for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141206/new/ https://reviews.llvm.org/D141206 ___ cfe-commits ma

[clang] a3b632a - Remove brittle test introduced in D140547.

Author: Utkarsh Saxena Date: 2023-01-13T20:26:38+01:00 New Revision: a3b632ab8772237ae23638f702bdceda028b2016 URL: https://github.com/llvm/llvm-project/commit/a3b632ab8772237ae23638f702bdceda028b2016 DIFF: https://github.com/llvm/llvm-project/commit/a3b632ab8772237ae23638f702bdceda028b2016.diff

[PATCH] D140838: [clang] fix crash on generic lambda with lambda in decltype

shafik added a comment. Makes sense to me as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140838/new/ https://reviews.llvm.org/D140838 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

tianshilei1992 added a comment. In D141627#4052323 , @abhinavgaba wrote: >> In target data we already put a and b in use_device_addr. That indicates all >> use of a and b will be the corresponding device addresses. Therefore, in >> target directive, we

[PATCH] D141716: [clang][dataflow] Add (initial) debug printing for `Value` and `Environment`.

ymandel created this revision. ymandel added reviewers: sgatev, xazax.hun, gribozavr2. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Also adds uses of the new printin

[clang] eb4aa6c - [cmake] Fix path to LLVMConfig.cmake for multi-config builds

Author: Nhat Nguyen Date: 2023-01-13T20:32:59+01:00 New Revision: eb4aa6c7a5f22583e319e3f6ee73cbc5464a URL: https://github.com/llvm/llvm-project/commit/eb4aa6c7a5f22583e319e3f6ee73cbc5464a DIFF: https://github.com/llvm/llvm-project/commit/eb4aa6c7a5f22583e319e3f6ee73cbc5464a.diff L

[PATCH] D141538: [cmake] Fix path to LLVMConfig.cmake for multi-config builds

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb4aa6c7a5f2: [cmake] Fix path to LLVMConfig.cmake for multi-config builds (authored by nhat-nguyen, committed by sebastian-ne). Repository: rG LL

[PATCH] D141717: [Clang] Only emit textual LLVM-IR in device only mode

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, tra, yaxunl, JonChesterfield. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project: clang. Currently, we embed dev

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

seanptmaher updated this revision to Diff 489084. seanptmaher added a comment. Fix bug in -j implementation where proper waiting wasn't happening Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141230/new/ https://reviews.llvm.org/D141230 Files: c

[PATCH] D141193: [clang][Interp] Implement __builtin_assume

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM; I verified that constant expression evaluation ignores failed assumptions: http://eel.is/c++draft/expr.const#5.8 so this is in line with the C++2b feature. Repository:

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

seanptmaher added a comment. It's slightly hard to test this because it involves making a huge diff of a git repo. If you're willing to jump through the hoops of cloning chromium (honestly, this is a pain in the ass. It's too much hard drive space and you've got to install depot_tools. If you d

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

seanptmaher updated this revision to Diff 489086. seanptmaher added a comment. No need to include os anymore, I'm not checking number of cores Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141230/new/ https://reviews.llvm.org/D141230 Files: clan

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

seanptmaher added a comment. Thanks a lot for the review, by the way. I realize the patch wasn't up to snuff initially, but glad to get it in order with your help. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141230/new/ https://reviews.llvm.org

[PATCH] D140423: [WIP][clang] Add PrintingPolicy callback for identifying default template arguments

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a subscriber: erichkeane. aaron.ballman added a comment. In D140423#4052271 , @dblaikie wrote: > In D140423#4051262 , @aaron.ballman > wrote: > >>>

[PATCH] D140547: Perform access checking to private members in simple requirement.

usaxena95 marked 4 inline comments as done. usaxena95 added a comment. I have deleted the test in https://github.com/llvm/llvm-project/commit/a3b632ab8772237ae23638f702bdceda028b2016. It is safe to delete as this is a brittle test trying to generate an invalid requirement using very deep templat

[PATCH] D139185: [clang][Interp] Use placement new to construct opcode args into vector

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139185/new/ https://reviews.llvm.org/D139185 ___ cfe-commits mailing lis

[PATCH] D141681: [clang][Interp] Fix parameter map when re-visiting function

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:57 +ParamDescriptors.insert({ParamOffset, {Ty, Desc}}); +Params.insert({PD, ParamOffset}); +ParamOffset += align(primSize(Ty)); shafik wrote: > Where is `Params` used?

[PATCH] D141580: [clang] Don't consider a nullptr returned from ActOnTag() as a valid result in ParseClassSpecifier.

sammccall added a comment. To offer the opposing argument: if DeclResult is just a bad idea, then using it consistently/right might be worse than using it as little as possible. FWIW, I find every piece of code that produces/consumes the `*Result` to be extremely confusing (the semantics of the

[PATCH] D141654: [clang-format] Replace DeriveLineEnding and UseCRLF with LineEnding

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. In D141654#4050852 , @rymiel wrote: > (This needs to run the updated dump script from D138446 > ) > > I'm not sure what the strict //benefit/

[PATCH] D141717: [Clang] Only emit textual LLVM-IR in device only mode

tra added a comment. Textual output for "-S -emit-llvm" is the canonical behavior, so I would prefer it working that way in as many cases as possible and only override it when necessary. Would it be possible to enforce binary IR generation in cases you need it? Or to prove that this is equival

[PATCH] D141694: [clang-format] SortUsingDeclarations support lexicographic order

HazardyKnusperkeks added reviewers: owenpan, HazardyKnusperkeks. HazardyKnusperkeks added a comment. Looks ok for me. Comment at: clang/include/clang/Format/Format.h:3500 +/// \code +///using std::c; +///using std::b; You should use the same

[clang] ed01de6 - [OpenMP][OMPIRBuilder] Move SIMD alignment calculation to LLVM Frontend

Author: Dominik Adamski Date: 2023-01-13T14:07:29-06:00 New Revision: ed01de67433174d3157e9d239d59dd465d52c6a5 URL: https://github.com/llvm/llvm-project/commit/ed01de67433174d3157e9d239d59dd465d52c6a5 DIFF: https://github.com/llvm/llvm-project/commit/ed01de67433174d3157e9d239d59dd465d52c6a5.dif

[PATCH] D138496: [OpenMP][OMPContext] Move SIMD alignment calculation to LLVM Frontend

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed01de674331: [OpenMP][OMPIRBuilder] Move SIMD alignment calculation to LLVM Frontend (authored by domada). Herald added projects: clang, LLDB. Heral

[PATCH] D140423: [WIP][clang] Add PrintingPolicy callback for identifying default template arguments

erichkeane added a comment. A Class template instantiation SHOULD have its link back to the class template, and should be able to calculate whether the template argument is defaulted, right? At least if it is the SAME as the default (that is, I'm not sure how well we can tell the difference be

[PATCH] D131052: [CMake] Allow setting the location of host tools with LLVM_NATIVE_TOOL_DIR

mstorsjo updated this revision to Diff 489098. mstorsjo added a comment. Switched the macro to a function and changed the variables to cache variables, to allow setting them in the grandparent scope without being a macro. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D141717: [Clang] Only emit textual LLVM-IR in device only mode

jhuber6 added a comment. In D141717#4052514 , @tra wrote: > Textual output for "-S -emit-llvm" is the canonical behavior, so I would > prefer it working that way in as many cases as possible and only override it > when necessary. > > Would it be possibl

[clang] 6809af1 - Revert "[OpenMP][OMPIRBuilder] Move SIMD alignment calculation to LLVM Frontend"

Author: Dominik Adamski Date: 2023-01-13T14:38:17-06:00 New Revision: 6809af1a232bc5ac71358e4b874759ddaae056a1 URL: https://github.com/llvm/llvm-project/commit/6809af1a232bc5ac71358e4b874759ddaae056a1 DIFF: https://github.com/llvm/llvm-project/commit/6809af1a232bc5ac71358e4b874759ddaae056a1.dif

Re: [clang] 6809af1 - Revert "[OpenMP][OMPIRBuilder] Move SIMD alignment calculation to LLVM Frontend"

Reminder to please always mention the reason for the revert/recommit in the commit message. On Fri, Jan 13, 2023 at 11:40 PM Dominik Adamski via cfe-commits wrote: > > > Author: Dominik Adamski > Date: 2023-01-13T14:38:17-06:00 > New Revision: 6809af1a232bc5ac71358e4b874759ddaae056a1 > > URL: >

[PATCH] D141528: [Clang][OpenMP] Fix loop directive nested inside a parallel

doru1004 updated this revision to Diff 489105. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141528/new/ https://reviews.llvm.org/D141528 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/test/OpenMP/nested_loop_codegen.cpp Index: clang/test/OpenMP/nested_loop_codegen.cpp

[clang] 0a652c5 - [codegen] Add StackFrameLayoutAnalysisPass

Author: Paul Kirth Date: 2023-01-13T20:52:48Z New Revision: 0a652c540556a118bbd9386ed3ab7fd9e60a9754 URL: https://github.com/llvm/llvm-project/commit/0a652c540556a118bbd9386ed3ab7fd9e60a9754 DIFF: https://github.com/llvm/llvm-project/commit/0a652c540556a118bbd9386ed3ab7fd9e60a9754.diff LOG: [c

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a652c540556: [codegen] Add StackFrameLayoutAnalysisPass (authored by paulkirth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 2e2aa8b - [clang-format] Fix a bug in DerivePointerAlignment fallback

Author: Owen Pan Date: 2023-01-13T12:58:33-08:00 New Revision: 2e2aa8bb6dea365e972528ad330f575b6b6e254b URL: https://github.com/llvm/llvm-project/commit/2e2aa8bb6dea365e972528ad330f575b6b6e254b DIFF: https://github.com/llvm/llvm-project/commit/2e2aa8bb6dea365e972528ad330f575b6b6e254b.diff LOG:

[PATCH] D141563: [clang-format] Fix a bug in DerivePointerAlignment fallback

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e2aa8bb6dea: [clang-format] Fix a bug in DerivePointerAlignment fallback (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D141310: [clang] add -Wcompare-function-pointers

adriandole updated this revision to Diff 489109. adriandole added a comment. - More helpful diagnostic message. - Check variable and type names are printed in tests. - Enable `-Wordered-function-pointer-comparison` when this warning is enabled. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D141723: [Clang] Remove `CLANG_OPENMP_NVPTX_DEFAULT_ARCH` CMake option.

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tra, yaxunl, JonChesterfield, MaskRay, mgorny, tstellar. Herald added subscribers: mattd, gchakrabarti, asavonic, guansong. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: llvm-comm

[PATCH] D141723: [Clang] Remove `CLANG_OPENMP_NVPTX_DEFAULT_ARCH` CMake option.

tschuett added a comment. Up right you will find `Edit Related Revisions...`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141723/new/ https://reviews.llvm.org/D141723 ___ cfe-commits mailing list cfe-c

[PATCH] D141723: [Clang] Remove `CLANG_OPENMP_NVPTX_DEFAULT_ARCH` CMake option.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Removing a `CMAKE_*_DEFAULT_*` makes me happy:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141723/new/ https://reviews.llvm.org/D141723 __

[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

akyrtzi accepted this revision. akyrtzi added a comment. This revision is now accepted and ready to land. Is it impractical to add a test for this? Otherwise LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141625/new/ https://reviews.llvm.org/D

[PATCH] D141717: [Clang] Only emit textual LLVM-IR in device only mode

tra added a comment. In D141717#4052587 , @jhuber6 wrote: > Well you'll get textual output for the host output, but the device code > embedded in the host module will be bitcode instead. So the final output from > the compiler is still textual IR. It ju

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

tejohnson added a comment. In D131306#4037037 , @paulkirth wrote: > @tejohnson @xur I kind of dropped the ball on these patches, but what are > your thoughts on this approach over the old(more invasive) change to the > profdata format I had prototyped b

<    1   2   3   >