[PATCH] D140895: [1/7][Clang][RISCV] Remove default tail-undisturbed for vector reduction intrinsics

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2091 MaskedPolicyScheme = HasPassthruOperand, -IsPrototypeDefaultTU = true, +IsPrototypeDefaultTU = false, HasMaskPolicy = false in { Can we remove the lin

[PATCH] D134268: [Clang][OpenMP] Codegen generation for has_device_addr claues.

tianshilei1992 added a comment. Hi there, I'm trying to fix https://github.com/llvm/llvm-project/issues/59160. The faulty case is basically like following: cpp void xoo() { short a[10], b[10]; a[1] = 111; b[1] = 111; #pragma omp target data map(to : a[0 : 2], b[0 : 2]) use_devi

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

njames93 added a comment. It'd be interesting to see how this handles variadic templates, I have a feeling if it isn't done correctly, there will be a lot of false positives. Can test be added to demonstrate the behaviour. What happens with code like this void foo(bar&& B) { std::move(B);

[PATCH] D140941: [4/7][Clang][RISCV] Remove default tail-undisturbed for multiply-add intrinsics

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140941/new/ https://reviews.llvm.org/D140941 ___

[PATCH] D140942: [5/7][Clang][RISCV] Remove default tail-undisturbed for vcompress intrinsics

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140942/new/ https://reviews.llvm.org/D140942 ___

[PATCH] D140947: [6/7][Clang][RISCV] Remove default tail-undisturbed for vmv_s_x and vfmv_s_f intrinsics

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140947/new/ https://reviews.llvm.org/D140947 ___

[PATCH] D140954: [7/7][Clang][RISCV][NFC] Remove attribute `IsPrototypeDefaultTU`

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140954/new/ https://reviews.llvm.org/D140954 ___

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

nickdesaulniers added a comment. It would be really nice if we could limit this to a specific function somehow. Quick feedback from giving Diff 488727 a spin on the Linux kernel: via `ARCH=arm make LLVM=1 -j128 -s allyesconfig all` I found: CC drivers/net/ethernet/mellanox/mlx5/core/en

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. Just 2 more `CHECK-FIXES` lines need updating. FWIW the reason its good to be explicit is because FileCheck will start searching from the line where the previous CHECK-FIXES had and stop wh

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

nickdesaulniers added inline comments. Comment at: llvm/lib/CodeGen/StackFrameLayoutAnalysisPass.cpp:44 + +const char *PassName = "stack-frame-layout"; + Consider replacing uses of `PassName` with `DEBUG_TYPE` since they have the same value. C

[PATCH] D141555: [CUDA] added cmath wrappers to unbreak CUDA compilation after D79555

tra created this revision. Herald added subscribers: mattd, bixia, yaxunl. Herald added a project: All. tra updated this revision to Diff 488733. tra added a comment. tra updated this revision to Diff 488734. tra published this revision for review. tra added reviewers: jlebar, philnik. Herald added

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

tianshilei1992 created this revision. tianshilei1992 added reviewers: ABataev, jdoerfert, abhinavgaba, jyu2. Herald added subscribers: guansong, yaxunl. Herald added a project: All. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a pro

[PATCH] D134268: [Clang][OpenMP] Codegen generation for has_device_addr claues.

tianshilei1992 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9098 + CombinedInfo.Types.push_back( + (Cap->capturesVariable() ? OMP_MAP_TO : OMP_MAP_LITERAL) | + OMP_MAP_TARGET_PARAM); tianshilei1992 wrote: > The v

[PATCH] D141555: [CUDA] added cmath wrappers to unbreak CUDA compilation after D79555

tra updated this revision to Diff 488736. tra added a comment. Reformatted the code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141555/new/ https://reviews.llvm.org/D141555 Files: clang/lib/Headers/CMakeLists.txt clang/lib/Headers/cuda_wrapp

[clang] 97156ba - clang/AMDGPU: Update clang test for llvm change

Author: Matt Arsenault Date: 2023-01-12T15:22:18-05:00 New Revision: 97156ba7bcc91b1449925df95128c36680549a4d URL: https://github.com/llvm/llvm-project/commit/97156ba7bcc91b1449925df95128c36680549a4d DIFF: https://github.com/llvm/llvm-project/commit/97156ba7bcc91b1449925df95128c36680549a4d.diff

[PATCH] D141051: [CUDA][HIP] Add support for `--offload-arch=native` to CUDA and refactor

srj added a comment. For reasons that aren't yet clear to me, this change is failing to compile when using gcc-7 and targeting 32-bit targets; the error is of the form AMDGPU.cpp:773:10: error: could not convert ‘GPUArchs’ from ‘llvm::SmallVector, 1>’ to ‘llvm::Expected > >’ return GPUA

[PATCH] D141051: [CUDA][HIP] Add support for `--offload-arch=native` to CUDA and refactor

jhuber6 added a comment. In D141051#4048456 , @srj wrote: > For reasons that aren't yet clear to me, this change is failing to compile > when using gcc-7 and targeting 32-bit targets; the error is of the form > > AMDGPU.cpp:773:10: error: could not con

[PATCH] D141463: [clang-tidy] Improve rename_check.py

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/rename_check.py:75 print("Renaming '%s' -> '%s'..." % (fileName, newFileName)) - os.rename(fileName, newFileName) + subprocess.check_call(["git", "mv", fileName, newFileName]) return newFileName

[clang] d34fbf2 - [clang][dataflow] In optional model, implement `widen` and make `compare` sound.

Author: Yitzhak Mandelbaum Date: 2023-01-12T20:36:37Z New Revision: d34fbf2d9bf4d372d25087d2ded9573b17ce7632 URL: https://github.com/llvm/llvm-project/commit/d34fbf2d9bf4d372d25087d2ded9573b17ce7632 DIFF: https://github.com/llvm/llvm-project/commit/d34fbf2d9bf4d372d25087d2ded9573b17ce7632.diff

[PATCH] D140344: [clang][dataflow] In optional model, implement `widen` and make `compare` sound.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd34fbf2d9bf4: [clang][dataflow] In optional model, implement `widen` and make `compare` sound. (authored by ymandel). Repository: rG LLVM Github M

[clang] 26d6267 - [Clang] Explicitly move returned values converted to expected

Author: Joseph Huber Date: 2023-01-12T14:38:03-06:00 New Revision: 26d62674cf5013249f99323d15b6044586e6b3a8 URL: https://github.com/llvm/llvm-project/commit/26d62674cf5013249f99323d15b6044586e6b3a8 DIFF: https://github.com/llvm/llvm-project/commit/26d62674cf5013249f99323d15b6044586e6b3a8.diff

[PATCH] D141051: [CUDA][HIP] Add support for `--offload-arch=native` to CUDA and refactor

jhuber6 added a comment. In D141051#4048456 , @srj wrote: > For reasons that aren't yet clear to me, this change is failing to compile > when using gcc-7 and targeting 32-bit targets; the error is of the form > > AMDGPU.cpp:773:10: error: could not con

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

nickdesaulniers added inline comments. Comment at: clang/test/Frontend/stack-layout-remark.c:8 +// RUN: mkdir -p %t +// RUN: %clang_cc1 %s -emit-codegen-only -triple x86_64-unknown-linux-gnu -target-cpu corei7 -Rpass-analysis=stack-frame-layout -o /dev/null -O0 2>&1 | FileChe

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

abhinavgaba added a comment. In D134268#4048357 , @tianshilei1992 wrote: > Hi there, I'm trying to fix > https://github.com/llvm/llvm-project/issues/59160. The faulty case is > basically like the following: > > void xoo() { > short a[10], b[10];

[PATCH] D140668: [clang][Interp] Implement remaining bits for MaterializeTemporaryExprs

shafik added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:761 if (std::optional LocalIndex = allocateLocalPrimitive(SubExpr, *SubExprT, true, true)) { if (!this->visitInitializer(SubExpr)) Comm

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

tianshilei1992 added a comment. I agree that b is not right here, but that doesn’t matter because I stepped into the runtime library and it crashed when processing a. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141627/new/ https://reviews.llvm.o

[PATCH] D140693: [Driver][RISCV] Adjust the priority between -mcpu, -mtune and -march

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:47 + Features, [&Args](const Twine &Str) { return Args.MakeArgString(Str); }, + true); return true; craig.topper wrote: > `true` -> `/*AddAllExtensions*/true` The c

[PATCH] D141206: [clang] [MinGW] Avoid adding /include and /lib when cross compiling

mstorsjo added inline comments. Comment at: clang/test/Driver/mingw-sysroot.cpp:25-38 // RUN: env "PATH=%T/testroot-gcc/bin:%PATH%" %clang -target x86_64-w64-mingw32 -rtlib=platform -stdlib=libstdc++ --sysroot="" -c -### %s 2>&1 | FileCheck -check-prefix=CHECK_TESTROOT_GCC %s

[PATCH] D141206: [clang] [MinGW] Avoid adding /include and /lib when cross compiling

mstorsjo updated this revision to Diff 488752. mstorsjo added a comment. Switch the negative test to `--implicit-check-not`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141206/new/ https://reviews.llvm.org/D141206 Files: clang/lib/Driver/ToolC

[clang] 3432f4b - [test] Split out Annotations from `TestingSupport`

Author: Jordan Rupprecht Date: 2023-01-12T13:40:47-08:00 New Revision: 3432f4bf86e7c77666ae9dede1610ae843dde648 URL: https://github.com/llvm/llvm-project/commit/3432f4bf86e7c77666ae9dede1610ae843dde648 DIFF: https://github.com/llvm/llvm-project/commit/3432f4bf86e7c77666ae9dede1610ae843dde648.di

[PATCH] D141175: [test] Split out Annotations from `TestingSupport`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3432f4bf86e7: [test] Split out Annotations from `TestingSupport` (authored by rupprecht). Changed prior to commit: https://reviews.llvm.org/D14117

[PATCH] D127855: [OpenMP] Basic parse and sema support for modifiers in order clause

jyu2 added a comment. In D127855#3956014 , @sandeepkosuri wrote: > As I do not have commit access, can someone commit this patch, now that it > passes the pre-merge tests ? I see some tests failed after this patch. Failed only with -fopenmp-vesion=51

[PATCH] D140724: [clang][Interp] Add back Run() call

shafik added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1301 assert(S.Current->getFunction()->hasRVO()); + if (S.checkingPotentialConstantExpression()) +return false; Why did you add these checks calling `checkingPotentialConstantExpressio

[PATCH] D141632: [Module] Respect `-fno-pch-timestamps` when building modules

steven_wu created this revision. steven_wu added reviewers: benlangmuir, akyrtzi, jansvoboda11. Herald added a subscriber: ributzka. Herald added a project: All. steven_wu requested review of this revision. Herald added a project: clang. Always respect the FrontendOption to not include timestamps

[PATCH] D141558: [MemProf] Collect access density statistics during profiling

tejohnson updated this revision to Diff 488766. tejohnson added a comment. Address comments (version change necessitated updating the tests) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141558/new/ https://reviews.llvm.org/D141558 Files: clang/

[PATCH] D141580: [clang] Don't consider a nullptr returned from ActOnTag() as a valid result in ParseClassSpecifier.

hokein added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:2069-2078 +if (auto *TagDecl = Actions.ActOnTag( +getCurScope(), TagType, TUK, StartLoc, SS, Name, NameLoc, attrs, AS, +DS.getModulePrivateSpecLoc(), TParams, Owned, IsDependen

[PATCH] D141558: [MemProf] Collect access density statistics during profiling

snehasish accepted this revision. snehasish added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141558/new/ https://reviews.llvm.org/D141558 _

[PATCH] D141634: [libTooling] Add `getFileRange` as an alternative to `getRangeForEdit`

li.zhe.hua created this revision. li.zhe.hua added a reviewer: ymandel. Herald added a project: All. li.zhe.hua requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a `getFileRange` function alongside the existing `getRangeForEdit` as a way

[PATCH] D141634: [libTooling] Add `getFileRange` as an alternative to `getRangeForEdit`

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Can you add a test? probably valuable even if its nearly identical to the test for `getRangeForEdit`. Comment at: clang/include/clang/Tooling/Transformer/SourceCode.h:120-

[PATCH] D141636: [libTooling] Rename `getRangeForEdit` as `getFileRangeForEdit`

li.zhe.hua created this revision. li.zhe.hua added a reviewer: ymandel. Herald added a project: All. li.zhe.hua requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With the addition of `getFileRange`, we rename `getRangeForEdit` as `getFileRang

[PATCH] D141634: [libTooling] Add `getFileRange` as an alternative to `getRangeForEdit`

li.zhe.hua updated this revision to Diff 488778. li.zhe.hua added a comment. Fix description. Remove default argument. Fix copy/paste error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141634/new/ https://reviews.llvm.org/D141634 Files: clang/

[PATCH] D141620: clang/OpenCL: Make enqueued blocks inherit the parent attributes

yaxunl added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:12488 + // FIXME: The invoke isn't applying the right attributes either + llvm::AttrBuilder KernelAttrs(C, CGF.CurFn->getAttributes().getFnAttrs()); + KernelAttrs.addAttribute("enqueued-block"); ---

[PATCH] D141634: [libTooling] Add `getFileRange` as an alternative to `getRangeForEdit`

li.zhe.hua updated this revision to Diff 488779. li.zhe.hua added a comment. Upload correct commit this time... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141634/new/ https://reviews.llvm.org/D141634 Files: clang/include/clang/Tooling/Transfo

[PATCH] D141634: [libTooling] Add `getFileRange` as an alternative to `getRangeForEdit`

li.zhe.hua updated this revision to Diff 488780. li.zhe.hua added a comment. Try this again... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141634/new/ https://reviews.llvm.org/D141634 Files: clang/include/clang/Tooling/Transformer/SourceCode.h

[PATCH] D141620: clang/OpenCL: Make enqueued blocks inherit the parent attributes

arsenm added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:12488 + // FIXME: The invoke isn't applying the right attributes either + llvm::AttrBuilder KernelAttrs(C, CGF.CurFn->getAttributes().getFnAttrs()); + KernelAttrs.addAttribute("enqueued-block"); ---

[clang] 439ba4c - [LinkerWrapper] Improve -save-temps behaviour

Author: Joseph Huber Date: 2023-01-12T16:43:30-06:00 New Revision: 439ba4c9026db6ab4c0a06737638ac42ebc445fd URL: https://github.com/llvm/llvm-project/commit/439ba4c9026db6ab4c0a06737638ac42ebc445fd DIFF: https://github.com/llvm/llvm-project/commit/439ba4c9026db6ab4c0a06737638ac42ebc445fd.diff

[clang] 7d0cdbf - [libTooling] Add `getFileRange` as an alternative to `getRangeForEdit`

Author: Eric Li Date: 2023-01-12T17:44:29-05:00 New Revision: 7d0cdbf69edf5b14101d9c11fe9ca4cf5228e81d URL: https://github.com/llvm/llvm-project/commit/7d0cdbf69edf5b14101d9c11fe9ca4cf5228e81d DIFF: https://github.com/llvm/llvm-project/commit/7d0cdbf69edf5b14101d9c11fe9ca4cf5228e81d.diff LOG:

[PATCH] D141634: [libTooling] Add `getFileRange` as an alternative to `getRangeForEdit`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d0cdbf69edf: [libTooling] Add `getFileRange` as an alternative to `getRangeForEdit` (authored by li.zhe.hua). Repository: rG LLVM Github Monorepo

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

abhinavgaba added a comment. In D141627#4048584 , @tianshilei1992 wrote: > I agree that b is not right here, but that doesn’t matter because I stepped > into the runtime library and it crashed when processing a. > > And why are they treated as to? Trea

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth updated this revision to Diff 488784. paulkirth marked 21 inline comments as done. paulkirth added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135488 Files: clang/test

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth added inline comments. Comment at: llvm/lib/CodeGen/StackFrameLayoutAnalysisPass.cpp:44 + +const char *PassName = "stack-frame-layout"; + nickdesaulniers wrote: > Consider replacing uses of `PassName` with `DEBUG_TYPE` since they have the > same value.

[PATCH] D141555: [CUDA] added cmath wrappers to unbreak CUDA compilation after D79555

jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. LGTM. Do we need changes to the test-suite to cover this too? (test-suite being in a separate repo, so it would be a separate patch.) Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth added a comment. In D135488#4048380 , @nickdesaulniers wrote: > It would be really nice if we could limit this to a specific function somehow. I think you can do that, right ? see: https://llvm.org/docs/Remarks.html#cmdoption-pass-remarks-fil

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth added inline comments. Comment at: clang/test/Frontend/stack-layout-remark.c:8 +// RUN: mkdir -p %t +// RUN: %clang_cc1 %s -emit-codegen-only -triple x86_64-unknown-linux-gnu -target-cpu corei7 -Rpass-analysis=stack-frame-layout -o /dev/null -O0 2>&1 | FileCheck %s

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

thegameg added a comment. In D135488#4048854 , @paulkirth wrote: > In D135488#4048380 , > @nickdesaulniers wrote: > >> It would be really nice if we could limit this to a specific function >> somehow. > > I thin

[PATCH] D141555: [CUDA] added cmath wrappers to unbreak CUDA compilation after D79555

tra added a comment. In D141555#4048843 , @jlebar wrote: > LGTM. Do we need changes to the test-suite to cover this too? (test-suite > being in a separate repo, so it would be a separate patch.) test-suite on CUDA bots already covering this and the

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth added inline comments. Comment at: llvm/test/CodeGen/AArch64/O0-pipeline.ll:76-77 ; CHECK-NEXT: Insert CFI remember/restore state instructions +; CHECK-NEXT: Lazy Machine Block Frequency Analysis +; CHECK-NEXT: Machine Optimization Remark Emitter +; C

[clang] 1ad5f6a - [CUDA] added cmath wrappers to unbreak CUDA compilation after D79555

Author: Artem Belevich Date: 2023-01-12T15:37:50-08:00 New Revision: 1ad5f6af816a439a84f7d8fe3dff87dd1f8a39ba URL: https://github.com/llvm/llvm-project/commit/1ad5f6af816a439a84f7d8fe3dff87dd1f8a39ba DIFF: https://github.com/llvm/llvm-project/commit/1ad5f6af816a439a84f7d8fe3dff87dd1f8a39ba.diff

[PATCH] D141555: [CUDA] added cmath wrappers to unbreak CUDA compilation after D79555

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1ad5f6af816a: [CUDA] added cmath wrappers to unbreak CUDA compilation after D79555 (authored by tra). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D135495: [clang-tidy] handle pointers in `ExceptionAnalyzer`

isuckatcs added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:60 +// Checks if T1 is convertible to T2. +static bool isMultiLevelConvertiblePointer(QualType P1, QualType P2, + unsigned CurrentLevel

[PATCH] D141617: OpenMP: Use inbounds in EmitOMPAggregateAssign

arsenm closed this revision. arsenm added a comment. 8efb8f776abf1cb66107c42b47e6a127828c4db0 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141617/new/ https://reviews.llvm.org/D141617 __

[PATCH] D141450: [Clang][cc1] Add -fno-modules-local-submodule-visibility to override the default

Bigcheese added a comment. In D141450#4044680 , @dblaikie wrote: >> This is a problem because some existing ObjectiveC code is not compatible >> with LSV > > Hmm, how is that true? Does this code only build with Clang Header Modules > enabled, and can't

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth added a comment. In D135488#4048869 , @thegameg wrote: > In D135488#4048854 , @paulkirth > wrote: > >> In D135488#4048380 , >> @nickdesaulniers wrote: >> >>> I

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth added a comment. Actually if we add if (!isFunctionInPrintList(MF.getName())) return false; we can filter by name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135488 _

[PATCH] D140693: [Driver][RISCV] Adjust the priority between -mcpu, -mtune and -march

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/test/Driver/riscv-march-mcpu-mtune.c:30 +// MARCH-RV32IMAFDC: "-target-feature" "+c" +// MARCH-RV32IMAFDC-NOT: "-target-cpu" + This NOT pattern isn't useful as `-target-cpu` has occu

[PATCH] D141450: [Clang][cc1] Add -fno-modules-local-submodule-visibility to override the default

dblaikie added a comment. In D141450#4049026 , @Bigcheese wrote: > In D141450#4044680 , @dblaikie > wrote: > >>> This is a problem because some existing ObjectiveC code is not compatible >>> with LSV >> >> Hmm,

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

nickdesaulniers accepted this revision. nickdesaulniers added a comment. In D135488#4049035 , @paulkirth wrote: > Actually if we add > > if (!isFunctionInPrintList(MF.getName())) >return false; > > we can filter by name Does name mangling compl

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

nickdesaulniers added a comment. Sorry, mind adding the documentation, too? Comment at: clang/test/Frontend/stack-layout-remark.c:8 +// RUN: mkdir -p %t +// RUN: %clang_cc1 %s -emit-codegen-only -triple x86_64-unknown-linux-gnu -target-cpu corei7 -Rpass-analysis=stack-frame-la

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

thegameg added a comment. In D135488#4049050 , @nickdesaulniers wrote: > In D135488#4049035 , @paulkirth > wrote: > >> Actually if we add >> >> if (!isFunctionInPrintList(MF.getName())) >>return false;

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

tianshilei1992 added a comment. FWIW, I think `has_device_addr(b[0])` is not trying to take the value of `b[0]` in this case. Instead, it's just to take the address of the first element of `b`. Only pointer arithmetic will be involved. It's not necessarily illegal to do it in that way. Reposi

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

nickdesaulniers added a comment. In D135488#4049075 , @thegameg wrote: > You can easily... I'll just note that v1 of this patch IIRC was a note on the single individual instance of the `-Wframe-larger-than=` diagnostic. No additional flags for optimiz

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

nickdesaulniers added a comment. @paulkirth please don't forget to update the commit description with that flag so that I don't have to read the contents of the commit to find this flag again. If you're using `arc diff` to upload the patch, the `--verbatim` flag will update the phab descriptio

[PATCH] D50852: [clang-tidy] abseil-auto-make-unique

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added subscribers: StephenFan, mgehre. Herald added a reviewer: njames93. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relev

[PATCH] D63929: [clang-tidy] - Introduce abseil-prefixed-thread-annotations check.

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Herald added subscribers: carlosgalvezp, StephenFan, mgehre. Herald added a reviewer: njames93. Herald added projects: clang-tools-extra, All. This review seems to be stuck/dead, co

[PATCH] D58811: [clang] Fix misuses of char width to char align

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rC Clang CHANGES SIN

[PATCH] D59859: [clang-tidy] FIXIT for implicit bool conversion now obeys upper case suffixes if enforced.

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added subscribers: carlosgalvezp, StephenFan. Herald added a reviewer: njames93. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longe

[PATCH] D63089: [clang] Warn on implicit boolean casts in more contexts (PR34180)

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monore

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added subscribers: carlosgalvezp, StephenFan. Herald added a reviewer: njames93. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Mon

[PATCH] D72239: [clang-tidy] new opencl recursion not supported check

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added subscribers: Naghasan, StephenFan. Herald added a reviewer: njames93. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer rel

[PATCH] D76229: [clang-tidy] Added PlacementNewStorageCheck

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added subscribers: carlosgalvezp, StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM

[PATCH] D141644: [clang] Report the on-disk paths for inputs to module compiles

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, bnbarham. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since D135636

[PATCH] D92001: [ubsan] Fix crash on __builtin_assume_aligned

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. CHANGES SINCE LAST ACTION https:/

[PATCH] D99565: [X86] Support replacing aligned vector moves with unaligned moves when avx is enabled.

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monore

[PATCH] D96223: [clang-tidy] Simplify static assert check

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Herald added subscribers: carlosgalvezp, StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG L

[PATCH] D99565: [X86] Support replacing aligned vector moves with unaligned moves when avx is enabled.

LuoYuanke commandeered this revision. LuoYuanke edited reviewers, added: LiuChen3; removed: LuoYuanke. LuoYuanke added a subscriber: lebedev.ri. LuoYuanke added a comment. In D99565#4049330 , @lebedev.ri wrote: > This review seems to be stuck/dead, conside

[PATCH] D115848: tidy-llvm

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added a subscriber: StephenFan. Herald added a reviewer: njames93. Herald added a project: All. This review may be stuck/dead, consider abandoning if no longer relevant. Removin

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

h-vetinari added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5639-5640 + + // If we're emitting a module output with the speicifed option + // `-fmodule-output`. + if (!AtTopLevel && isa(JA) && Comment at: clang/lib/Driver/Driv

[PATCH] D119271: clang: emit allocalign to LLVM for alloc_align attributes

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. This review may be stuck/dead, consider abandoning if no longer relevant. Removing myself as reviewer in attempt to clean dashboard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D135658: demangle OptFunction trace names

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Herald added a subscriber: StephenFan. This review may be stuck/dead, consider abandoning if no longer relevant. Removing myself as reviewer in attempt to clean dashboard. Reposit

[PATCH] D125272: [clang] Add -fcheck-new support

lebedev.ri resigned from this revision. lebedev.ri added a comment. This review may be stuck/dead, consider abandoning if no longer relevant. Removing myself as reviewer in attempt to clean dashboard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth updated this revision to Diff 488815. paulkirth added a comment. Address comments - Take a stab a ReleaseNotes - Update -Wframe-larger-than documentation to reference this pass - Enable filtering output from this pass by function name Repository: rG LLVM Github Monorepo CHANGES SIN

[clang-tools-extra] 7910ee7 - [clang-tidy] don't warn when returning the result for bugprone-standalone-empty

Author: v1nh1shungry Date: 2023-01-13T01:14:51Z New Revision: 7910ee7d8c6dcb679200ba171fba5d8d5f237007 URL: https://github.com/llvm/llvm-project/commit/7910ee7d8c6dcb679200ba171fba5d8d5f237007 DIFF: https://github.com/llvm/llvm-project/commit/7910ee7d8c6dcb679200ba171fba5d8d5f237007.diff LOG:

[PATCH] D141107: [clang-tidy] don't warn when returning the result for bugprone-standalone-empty

This revision was automatically updated to reflect the committed changes. Closed by commit rG7910ee7d8c6d: [clang-tidy] don't warn when returning the result for bugprone-standalone-empty (authored by v1nh1shungry, committed by cjdb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D78028: move shebangs from python2 to python3

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added subscribers: cfe-commits, llvm-commits, Moerafaat, zero9178, Enna1, bzcheeseman, sdasgup3, carlosgalvezp, wenzhicui, wrengr, cota, StephenFan, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, stephenne

[PATCH] D79636: [LangRef] Clarify the semantics of the `byval` attribute

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D85097: [Sema] add warning for comparisons like 'x<=y<=z'

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D79113: Revert "Remove false positive in AvoidNonConstGlobalVariables."

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added subscribers: carlosgalvezp, StephenFan. Herald added a reviewer: njames93. Herald added projects: clang-tools-extra, All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository:

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D105497: [clang] Serialize source locations as 64-bit in PCH.

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D105495: [clang] Make negative getLocWithOffset widening-safe.

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added subscribers: steakhal, StephenFan. Herald added a reviewer: NoQ. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monorepo CHA

<    1   2   3   4   >