[clang] fe29a16 - This is to fix runtime problem for member data used in target region.

Author: Jennifer Yu Date: 2023-01-10T16:59:49-08:00 New Revision: fe29a1695a6c69eb6616db01a559a3804d55fde8 URL: https://github.com/llvm/llvm-project/commit/fe29a1695a6c69eb6616db01a559a3804d55fde8 DIFF: https://github.com/llvm/llvm-project/commit/fe29a1695a6c69eb6616db01a559a3804d55fde8.diff L

[PATCH] D141350: Fix runtime problem for base class member data used in target region.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe29a1695a6c: This is to fix runtime problem for member data used in target region. (authored by jyu2). Changed prior to commit: https://reviews.l

[PATCH] D141450: [Clang][cc1] Add -fno-modules-local-submodule-visibility to override the default

Bigcheese created this revision. Bigcheese added reviewers: jansvoboda11, dblaikie, iains, ChuanqiXu. Bigcheese added projects: clang-modules, clang. Herald added a subscriber: ributzka. Herald added a project: All. Bigcheese requested review of this revision. Currently there is no way to have Obj

[clang] f9559b1 - clang: Convert test to generated checks and opaque pointers

Author: Matt Arsenault Date: 2023-01-10T20:35:49-05:00 New Revision: f9559b1e300ec636b15b350a981eebec65d3419a URL: https://github.com/llvm/llvm-project/commit/f9559b1e300ec636b15b350a981eebec65d3419a DIFF: https://github.com/llvm/llvm-project/commit/f9559b1e300ec636b15b350a981eebec65d3419a.diff

[PATCH] D141338: [WIP][-Wunsafe-buffer-usage] Filter out conflicting fix-its

NoQ added a comment. Looks awesome! I'm worried that the test is going to rapidly become stale as you develop fixits for `DeclStmt` further. It might make sense to write some //unittests// for this class directly, to put into `clang/unittest/Analysis/...`. Then you can create some fixits defin

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

nickdesaulniers created this revision. Herald added subscribers: jdoerfert, hiraditya. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Due to inlining, descovering which specifi

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

NoQ added a comment. In D139737#4037455 , @ziqingluo-90 wrote: > Since we do not have any `FixableGadget` to trigger fix-its at this point, I > let fix-its of local variable declarations always be emitted for the purpose > of testing. It sounds to me

[PATCH] D141450: [Clang][cc1] Add -fno-modules-local-submodule-visibility to override the default

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141450/new/ https://reviews.llvm.org/D141450

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

browneee requested changes to this revision. browneee added a comment. This revision now requires changes to proceed. Hello! Thank you for the patch. I think your changes for `__dfsw_strsep` are conflating the taint value of a pointer with the taint value of the value(s) it points to. This is su

[PATCH] D141198: [Clang][RISCV][NFC] Reorganize test case for rvv intrinsics

eopXD updated this revision to Diff 488055. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141198/new/ https://reviews.llvm.org/D141198 Files: clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/no

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

ChuanqiXu updated this revision to Diff 488057. ChuanqiXu added a comment. Address comments: merge the conditions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137058/new/ https://reviews.llvm.org/D137058 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clan

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

ChuanqiXu marked an inline comment as done. ChuanqiXu added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5736 + C.getArgs().hasArg(options::OPT_fmodule_output) && + C.getArgs().hasArg(options::OPT_o)) { +SmallString<128> OutputPath; dbla

[PATCH] D141198: [Clang][RISCV][NFC] Reorganize test case for rvv intrinsics

eopXD updated this revision to Diff 488061. eopXD added a comment. Recover mis-deleted handcrafted test case for vmulh, vmulhu, and vmulhsu on e8 ~ e64 with zve32x. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141198/new/ https://reviews.llvm.org

[PATCH] D141198: [Clang][RISCV][NFC] Reorganize test case for rvv intrinsics

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM as far as I'm able to review in phabricator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141198/new/ https://reviews.llvm.org/

[PATCH] D141449: clang/OpenCL: Fix not setting convergent on block invoke kernels

yaxunl added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:12428 F->addFnAttr(llvm::Attribute::NoUnwind); + F->addFnAttr(llvm::Attribute::Convergent); How about using CGF.CGM.addDefaultFunctionDefinitionAttributes? same as below CHANGES SI

[PATCH] D140867: [C++20] [Modules] Don't generate global ctors/dtors for variables which are available externally

ChuanqiXu added a comment. In D140867#4040590 , @Jake-Egan wrote: > In D140867#4038388 , @ChuanqiXu > wrote: > >> In D140867#4036239 , @Jake-Egan >> wrote: >> >>> Hi, th

[PATCH] D141447: clang/OpenCL: Don't use a Function for the block type

yaxunl added a comment. need a test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141447/new/ https://reviews.llvm.org/D141447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 51ba660 - [clang-format] Inherit RightAlign options across scopes

Author: Emilia Dreamer Date: 2023-01-11T05:59:45+02:00 New Revision: 51ba660a0700e659e1a97f3ca5879b8617ec5c26 URL: https://github.com/llvm/llvm-project/commit/51ba660a0700e659e1a97f3ca5879b8617ec5c26 DIFF: https://github.com/llvm/llvm-project/commit/51ba660a0700e659e1a97f3ca5879b8617ec5c26.diff

[clang] 0904e0b - [clang-format] Properly handle the C11 _Generic keyword.

Author: Emilia Dreamer Date: 2023-01-11T06:00:16+02:00 New Revision: 0904e0bac8314249ee7c1b0658f1a1cc92ccd050 URL: https://github.com/llvm/llvm-project/commit/0904e0bac8314249ee7c1b0658f1a1cc92ccd050 DIFF: https://github.com/llvm/llvm-project/commit/0904e0bac8314249ee7c1b0658f1a1cc92ccd050.diff

[PATCH] D139211: [clang-format] Properly handle the C11 _Generic keyword.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0904e0bac831: [clang-format] Properly handle the C11 _Generic keyword. (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D141288: [clang-format] Inherit RightAlign options across scopes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG51ba660a0700: [clang-format] Inherit RightAlign options across scopes (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang-tools-extra] e4e0f93 - Remove the ThreadLocal template from LLVM.

Author: Owen Anderson Date: 2023-01-10T21:07:52-07:00 New Revision: e4e0f933079859c12983f955e7ee66ba4fb39932 URL: https://github.com/llvm/llvm-project/commit/e4e0f933079859c12983f955e7ee66ba4fb39932 DIFF: https://github.com/llvm/llvm-project/commit/e4e0f933079859c12983f955e7ee66ba4fb39932.diff

[PATCH] D141349: Remove the ThreadLocal template from LLVM.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe4e0f9330798: Remove the ThreadLocal template from LLVM. (authored by resistor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140867: [C++20] [Modules] Don't generate global ctors/dtors for variables which are available externally

Jake-Egan added a comment. > Would you like to take a double look? Yes, it still fails on the bot and on my local machine. I've added an XFAIL to the test for now just to get the AIX bot green. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140867/

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

MaskRay added inline comments. Comment at: libunwind/src/AddressSpace.hpp:249 const uint8_t *pend = (uint8_t *)end; - int64_t result = 0; + uint64_t result = 0; int bit = 0; Thanks. LGTM for this file. You can just fix libunwind in a separate commit so t

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

MaskRay added inline comments. Comment at: clang/docs/ReleaseNotes.rst:354 ^^^ +- Clang now supports implicit conversion warnings (-Wsign-conversion, + Wshorten-64-to-32, etc) for compound assignment operators (like +=, >=, etc)

[PATCH] D140867: [C++20] [Modules] Don't generate global ctors/dtors for variables which are available externally

ChuanqiXu added a comment. In D140867#4042351 , @Jake-Egan wrote: >> Would you like to take a double look? > > Yes, it still fails on the bot and on my local machine. I've added an XFAIL > to the test for now just to get the AIX bot green. Weird. Maybe

[PATCH] D141459: [RISCV] Use Zvl*b as a lower bound for VScaleRange.

craig.topper created this revision. craig.topper added reviewers: reames, frasercrmck, rogfer01, kito-cheng. Herald added subscribers: sunshaoce, VincentWu, ctetreau, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

v1nh1shungry updated this revision to Diff 488081. v1nh1shungry added a comment. implement `VarTemplateSpecializationDecl::getSourceRange()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139705/new/ https://reviews.llvm.org/D139705 Files: clang/

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

v1nh1shungry added inline comments. Comment at: clang/test/FixIt/fixit-const-var-init.cpp:24 + +template <> constexpr float d; // expected-error {{must be initialized by a constant expression}} +// CHECK: fix-it:"{{.*}}":{24:42-24:42}:" = 0.0" aaron.ballman wrot

[PATCH] D141105: [OpenMP] Add support for '--offload-arch=native' to OpenMP offloading

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Looks reasonable to me. See comments though Comment at: clang/include/clang/Driver/Driver.h:488 + Action::OffloadKind Kind, const ToolChain *TC, +

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

ccotter updated this revision to Diff 488084. ccotter added a comment. - clang-format - Show whether 'this' is implicitly captured - fix docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141133/new/ https://reviews.llvm.org/D141133 Files: clan

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

ccotter updated this revision to Diff 488085. ccotter added a comment. - Rename test to match check name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141133/new/ https://reviews.llvm.org/D141133 Files: clang-tools-extra/clang-tidy/cppcoreguide

[PATCH] D141198: [Clang][RISCV][NFC] Reorganize test case for rvv intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb9f75827fedb: [Clang][RISCV][NFC] Reorganize test case for rvv intrinsics (authored by eopXD). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D141440: [OpenMP] Adjust phases for AMDGPU offloading for OpenMP in save-temps mode

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. If i'm reading this right, the change means we emit the same save-temps files as hip with the same naming convention. That sounds great, makes life easier for backend devs lo

[PATCH] D129570: [clang-tidy] Add new clang-tidy check to find implicit conversions from enum to integer.

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EnumToIntCheck.cpp:31 + const auto *MatchedExpr = Result.Nodes.getNodeAs("x"); + diag(MatchedExpr->getBeginLoc(), "enum is implictly converted to an integral") + << MatchedExpr->getSour

[PATCH] D141463: [clang-tidy] Improve rename_check.py

ccotter created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. ccotter requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. rename_check.py now find

[PATCH] D139608: [Clang][NFC] Add default `getBFloat16Mangling` impl

Pierre-vh abandoned this revision. Pierre-vh added a comment. Makes sense to abandon this given that D136919 exists Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139608/new/ https://reviews.llvm.org/D139608

[PATCH] D141463: [clang-tidy] Improve rename_check.py

ccotter added a comment. I tested with https://reviews.llvm.org/D141133 where I renamed my new check, but noticed rename_tool.py did not rename or update the check name in the test file. The result of running the updated script against my tool is on github: https://github.com/ccotter/llvm-proje

[PATCH] D141463: [clang-tidy] Improve rename_check.py

carlosgalvezp added a comment. Thanks for the fix! Some minor comments/questions. Comment at: clang-tools-extra/clang-tidy/rename_check.py:75 print("Renaming '%s' -> '%s'..." % (fileName, newFileName)) - os.rename(fileName, newFileName) + subprocess.check_call(["git", "mv"

<    1   2   3