[clang] faa29ee - [Clang] Fix warning on unused varaible

2023-01-06 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-01-06T21:14:31-06:00 New Revision: faa29ee0f9c941b193161ad48a46713a04a81163 URL: https://github.com/llvm/llvm-project/commit/faa29ee0f9c941b193161ad48a46713a04a81163 DIFF: https://github.com/llvm/llvm-project/commit/faa29ee0f9c941b193161ad48a46713a04a81163.diff

[PATCH] D141050: [standalone-build] outsource, simplify and unify repetitive CMake code

2023-01-06 Thread Petr Hosek via Phabricator via cfe-commits
phosek added inline comments. Comment at: clang/CMakeLists.txt:35 + include(StandaloneBuildHelpers) + get_llvm_utility_binary_path("llvm-tblgen" "LLVM_TABLEGEN_EXE") It's somewhat unusual to quote output variable names in our CMake files, I'd prefer to follo

[PATCH] D140073: [ODRHash] Hash `ObjCInterfaceDecl` and diagnose discovered mismatches.

2023-01-06 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai updated this revision to Diff 487043. vsapsai added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140073/new/ https://reviews.llvm.org/D140073 Files: clang/include/clang/AST/DeclObjC.h clang/include/clang/AST/ODRDiag

[PATCH] D141107: [clang-tidy] don't warn when returning the result for bugprone-standalone-empty

2023-01-06 Thread Vincent Hong via Phabricator via cfe-commits
v1nh1shungry updated this revision to Diff 487044. v1nh1shungry added a comment. add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141107/new/ https://reviews.llvm.org/D141107 Files: clang-tools-extra/clang-tidy/bugprone/StandaloneEmp

[PATCH] D141107: [clang-tidy] don't warn when returning the result for bugprone-standalone-empty

2023-01-06 Thread Vincent Hong via Phabricator via cfe-commits
v1nh1shungry marked an inline comment as done. v1nh1shungry added a comment. Thank you for reviewing and giving suggestions! @cjdb Hope there are enough test cases now, and not too many tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141107/ne

[PATCH] D140073: [ODRHash] Hash `ObjCInterfaceDecl` and diagnose discovered mismatches.

2023-01-06 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai updated this revision to Diff 487045. vsapsai added a comment. Serialize/deserialize `ObjCInterfaceTypeLoc::NameEndLoc` as it is used in diagnostic about a mismatching superclass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140073/new/ h

[PATCH] D140073: [ODRHash] Hash `ObjCInterfaceDecl` and diagnose discovered mismatches.

2023-01-06 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140073/new/ https://reviews.llvm.org/D140073 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D140970: [BPF] preserve btf_decl_tag for parameters of extern functions

2023-01-06 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song accepted this revision. yonghong-song added a comment. This revision is now accepted and ready to land. LGTM. I will add `// REQUIRES: bpf-registered-target` in the test to ensure it only executed with bpf target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 58bdf8f - [BPF] preserve btf_decl_tag for parameters of extern functions

2023-01-06 Thread Yonghong Song via cfe-commits
Author: Eduard Zingerman Date: 2023-01-06T22:48:52-08:00 New Revision: 58bdf8f9a8c3331c6c4d5f631395fb6f786d1e9c URL: https://github.com/llvm/llvm-project/commit/58bdf8f9a8c3331c6c4d5f631395fb6f786d1e9c DIFF: https://github.com/llvm/llvm-project/commit/58bdf8f9a8c3331c6c4d5f631395fb6f786d1e9c.di

[PATCH] D140970: [BPF] preserve btf_decl_tag for parameters of extern functions

2023-01-06 Thread Yonghong Song via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG58bdf8f9a8c3: [BPF] preserve btf_decl_tag for parameters of extern functions (authored by eddyz87, committed by yonghong-song). Changed prior to commit: https://reviews.llvm.org/D140970?vs=486295&id=487

[PATCH] D141182: [mips][clang] Do not define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros for MIPS-I

2023-01-06 Thread Brad Smith via Phabricator via cfe-commits
brad created this revision. brad added a reviewer: atanasyan. brad added a project: clang. Herald added subscribers: jrtc27, arichardson, sdardis. Herald added a project: All. brad requested review of this revision. Do not define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros for MIPS-I Repository: r

<    1   2