[PATCH] D140868: [C] Make (c ? e1 : e2) noreturn only if both e1 and e2 are noreturn

rjmccall added a comment. Isn't the C feature not technically part of the type? I thought Clang was fairly unique in modeling `noreturn` the way we do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140868/new/ https://reviews.llvm.org/D140868 __

[PATCH] D140868: [C] Make (c ? e1 : e2) noreturn only if both e1 and e2 are noreturn

aaron.ballman added a comment. In D140868#4024087 , @rjmccall wrote: > Isn't the C feature not technically part of the type? I thought Clang was > fairly unique in modeling `noreturn` the way we do. That's true, I just verified I didn't change that as

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary 1 or 5)

jmciver added a comment. The Discourse proposal is available: RFC Load Instruction: Uninitialized Memory Semantics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D108265: .clang-tidy: Push variable related readability-identifier-naming options down to projects

MaskRay added a comment. I'll wait a bit and land this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108265/new/ https://reviews.llvm.org/D108265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D138329: [-Wunsafe-buffer-usage] Add a new recursive matcher to replace `forEachDescendant` in unsafe buffer check

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Ok LGTM! I hope we'll get a chance to implement a reusable solution later🤞 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138329/new/ https://reviews.llvm.org/D138329 __

[PATCH] D139233: [-Wunsafe-buffer-usage] Add an unsafe gadget for pointer-arithmetic operations

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:383 + // FIXME: pointer adding zero should be fine + //FIXME: this gadge will need a fix-it +}; It's p

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

python3kgae updated this revision to Diff 486070. python3kgae added a comment. Use llvm::TypeSize and uint32_t instead of unsigned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136031/new/ https://reviews.llvm.org/D136031 Files: llvm/lib/Target

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4)

ben.boeckel added a comment. In D137534#4024022 , @jansvoboda11 wrote: > While I was not suggesting using compilation database instead of the approach > taken by this patch, I appreciate your explanation. But it still leaves me > wondering whether gene

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4)

tschuett added a comment. I believe you are arguing for a JSON file. The complexity of flags that want to pass to clang-scan-deps is too high. You even get some benefit of caching if you create a JSON file with several targets. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137534/new/

[clang] 0086a35 - [clang][dataflow] Fix bug in optional-checker's handling of nullopt constructor.

Author: Yitzhak Mandelbaum Date: 2023-01-03T21:57:39Z New Revision: 0086a3555ac6cd76bb637252a0ba17c06c9b869b URL: https://github.com/llvm/llvm-project/commit/0086a3555ac6cd76bb637252a0ba17c06c9b869b DIFF: https://github.com/llvm/llvm-project/commit/0086a3555ac6cd76bb637252a0ba17c06c9b869b.diff

[PATCH] D140921: [clang][dataflow] Fix bug in optional-checker's handling of nullopt constructor.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0086a3555ac6: [clang][dataflow] Fix bug in optional-checker's handling of nullopt constructor. (authored by ymandel). Changed prior to commit: htt

[PATCH] D140250: Define NULL in its own header

iana planned changes to this revision. iana added a comment. This needs a bit more work, it looks like it's not enough to just add a header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140250/new/ https://reviews.llvm.org/D140250 ___

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4)

jansvoboda11 added a comment. In D137534#4024178 , @ben.boeckel wrote: > In D137534#4024022 , @jansvoboda11 > wrote: > >> While I was not suggesting using compilation database instead of the >> approach taken b

[PATCH] D139564: clang: Don't emit "frame-pointer"="none"

rjmccall added a comment. Seems fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139564/new/ https://reviews.llvm.org/D139564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D140925: [CMake] Use Clang to infer the target triple

phosek created this revision. phosek added reviewers: smeenai, ldionne, mstorsjo, mgorny. Herald added subscribers: Enna1, abrachet. Herald added a project: All. phosek requested review of this revision. Herald added projects: clang, Sanitizers, libc++, libc++abi. Herald added subscribers: libcxx-c

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth added a comment. @thegameg Maybe? It seems straightforward, but I'll need take a look. If it's easy(which I think it willbe), I'll try to update this patch, if it's more complex, I'll probably do a separate patch to add that feature. Comment at: llvm/lib/CodeGen/Sta

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

hctim updated this revision to Diff 486093. hctim added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133392/new/ https://reviews.llvm.org/D133392 Files: clang/test/CodeGen/memtag-globals-asm.cpp llvm/lib/CodeGen/GlobalMerge

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth updated this revision to Diff 486094. paulkirth added a comment. Remove unnecesary null pointer check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135488 Files: clang/test/Frontend/stack-layout-r

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth updated this revision to Diff 486095. paulkirth added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135488 Files: clang/test/Frontend/stack-layout-remark.c llvm/include/llvm/Cod

[PATCH] D140250: Define NULL in its own header

iana updated this revision to Diff 486100. iana added a comment. Herald added subscribers: llvm-commits, Sanitizers, Enna1, kadircet, arphaman. Herald added projects: Sanitizers, LLVM, clang-tools-extra. Add a module for __stddef_null.h and give it the same special treatment as __stddef_max_align

[PATCH] D140250: Define NULL in its own header

iana planned changes to this revision. iana added a comment. I think this should be all we need, but I'm still running tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140250/new/ https://reviews.llvm.org/D140250 __

[PATCH] D140868: [C] Make (c ? e1 : e2) noreturn only if both e1 and e2 are noreturn

ArsenArsen added a comment. noreturn is a bit special among the attributes, perhaps it'd be worthwhile altering the standard to say that a composite is noreturn only of all of it's types are. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140868/ne

[PATCH] D131594: WORK IN PROGRESS Add Clang UEFI target to support "x86_64-unknown-uefi" triple

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/UEFI.cpp:41-45 +bool UEFI::IsUnwindTablesDefault(const ArgList &Args) const { + // TODO(prabhukr):: What about x86_32? + return getArch() == llvm::Triple::x86_64 || getArch() == llvm::Triple::arm || +

[PATCH] D140927: [C++20][Modules] Fix named module import diagnostics.

iains created this revision. Herald added a subscriber: ChuanqiXu. Herald added a project: All. iains added reviewers: ChuanqiXu, dblaikie. iains added a subscriber: clang-modules. iains published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. We h

[PATCH] D140584: [Clang] Refactor "Designators" into a unified implementation [NFC]

void added a comment. Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140584/new/ https://reviews.llvm.org/D140584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D140664: [Sema] Don't mark deleted special member functions as non-trivial

royjacobson updated this revision to Diff 486105. royjacobson edited the summary of this revision. royjacobson added a comment. Rebase + remove extra class Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140664/new/ https://reviews.llvm.org/D140664

[PATCH] D140868: [C] Make (c ? e1 : e2) noreturn only if both e1 and e2 are noreturn

ArsenArsen added a comment. It'd appear that GCC merges them here: https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=gcc/c/c-typeck.cc;h=e06f052eb46a72d3d50835330c5af975e7c52084;hb=HEAD#l708 /* For function types do not merge const qualifiers, but drop them if used inconsistently. The middle-e

[PATCH] D140925: [CMake] Use Clang to infer the target triple

tamas added inline comments. Comment at: runtimes/CMakeLists.txt:168 +if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE) + set(CXX_TARGET_TRIPLE ${CMAKE_CXX_COMPILER} --target=${LLVM_RUNTIME_TRIPLE} -print-target-triple) + execute_process(COMMAND ${CXX_TARGET_TRIPLE} ---

[PATCH] D140433: [Clang] Add `nvptx-arch` tool to query installed NVIDIA GPUs

tra added inline comments. Comment at: clang/tools/nvptx-arch/CMakeLists.txt:19 +if (NOT CUDA_FOUND OR NOT cuda-library) + message(STATUS "Not building nvptx-arch: cuda runtime not found") + return() Nit: libcuda.so is part of the NVIDIA driver which provides N

[PATCH] D140896: [WIP] Move from llvm::makeArrayRef to ArrayRef deduction guides

MaskRay accepted this revision. MaskRay added a comment. LGTM if `makeArrayRef` is kept in this patch. Do we foresee compiler bugs (for supported compilers) in this area? If there may be a risk, consider migrate a part of the code base first. CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D139458: [clangd] Full support for #import insertions

dgoldman updated this revision to Diff 486111. dgoldman marked 7 inline comments as done. dgoldman added a comment. Minor fixes for review, moving stuff around Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139458/new/ https://reviews.llvm.org/D1394

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth updated this revision to Diff 486112. paulkirth added a comment. Identify the stack protector in output Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135488 Files: clang/test/Frontend/stack-layout-

[PATCH] D140433: [Clang] Add `nvptx-arch` tool to query installed NVIDIA GPUs

jhuber6 added inline comments. Comment at: clang/tools/nvptx-arch/CMakeLists.txt:19 +if (NOT CUDA_FOUND OR NOT cuda-library) + message(STATUS "Not building nvptx-arch: cuda runtime not found") + return() tra wrote: > Nit: libcuda.so is part of the NVIDIA driver

[PATCH] D140929: [BPF] Support for "btf_decl_tag" annotations for arguments of extern functions

eddyz87 created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. eddyz87 retitled this revision from "This series of patches adds support for "btf_decl_tag" annotations for arguments of extern functions. Patch descriptions follow. [BPF] Triple::isBPF() utility met

[clang] ce6ae0b - clang: Don't emit "frame-pointer"="none"

Author: Matt Arsenault Date: 2023-01-03T19:42:46-05:00 New Revision: ce6ae0b2a26b1ec2f770b2b9474cc4486d60c586 URL: https://github.com/llvm/llvm-project/commit/ce6ae0b2a26b1ec2f770b2b9474cc4486d60c586 DIFF: https://github.com/llvm/llvm-project/commit/ce6ae0b2a26b1ec2f770b2b9474cc4486d60c586.diff

[PATCH] D139564: clang: Don't emit "frame-pointer"="none"

arsenm closed this revision. arsenm added a comment. ce6ae0b2a26b1ec2f770b2b9474cc4486d60c586 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139564/new/ https://reviews.llvm.org/D139564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

thegameg added inline comments. Comment at: llvm/lib/CodeGen/StackFrameLayoutAnalysisPass.cpp:92 + &MF.front()) + << "FunctionName: " << ore::NV("FunctionName", MF.getName()); +}); Why are we emitting

[PATCH] D140433: [Clang] Add `nvptx-arch` tool to query installed NVIDIA GPUs

tra added inline comments. Comment at: clang/tools/nvptx-arch/NVPTXArch.cpp:34 + const char *ErrStr = nullptr; + CUresult Result = cuGetErrorString(Err, &ErrStr); + if (Result != CUDA_SUCCESS) jhuber6 wrote: > tra wrote: > > One problem with this approach is t

[PATCH] D140584: [Clang] Refactor "Designators" into a unified implementation [NFC]

rsmith added inline comments. Comment at: clang/include/clang/AST/Designator.h:87-92 +/// Refers to the index expression. +Expr *IndexExpr; + +/// Location of the first index expression within the designated +/// initializer expression's list of subexpressions. +

[PATCH] D136554: Implement CWG2631

rupprecht accepted this revision. rupprecht added a comment. I still see one behavior change (actually it was there before, but I missed it in the test results), but as far as I can tell, it's a good one? If I reduce it too much, I get the warning with the baseline toolchain, so it's not erroneo

[PATCH] D140927: [C++20][Modules] Fix named module import diagnostics.

ChuanqiXu added a comment. [module.import]p1 says: > In a module unit, all module-import-declarations and export-declarations > exporting module-import-declarations shall appear before all other > declarations in the declaration-seq of the translation-unit and of the > private-module-fragment

[PATCH] D140936: [WIP][2/6][RISCV][Clang] Remove default tail-undisturbed for vslideup intrinsics

eopXD created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sab

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth added a comment. @arsenm @thegameg @nickdesaulniers @dblaikie @phosek Can we reach a consensus here on how to output this kind of information? I feel like I've been told to move towards remarks as the output method, but that the current diagnostic that tries to lay out the stack visua

[PATCH] D136554: Implement CWG2631

rupprecht added a comment. In D136554#4024628 , @rupprecht wrote: > I still see one behavior change (actually it was there before, but I missed > it in the test results), but as far as I can tell, it's a good one? If I > reduce it too much, I get the wa

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

ChuanqiXu updated this revision to Diff 486132. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137058/new/ https://reviews.llvm.org/D137058 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver/Options.td

[PATCH] D140937: [WIP][3/6][Clang][RISCV] Remove default tail-undisturbed for vslidedown intrinsics

eopXD created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sab

[PATCH] D140937: [WIP][3/6][Clang][RISCV] Remove default tail-undisturbed for vslidedown intrinsics

eopXD updated this revision to Diff 486137. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140937/new/ https://reviews.llvm.org/D140937 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/rv

[PATCH] D140941: [WIP][4/6][Clang][RISCV] Remove default tail-undisturbed for multiply-add intrinsics

eopXD created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sab

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

thegameg added a comment. In D135488#4024713 , @paulkirth wrote: > @arsenm @thegameg @nickdesaulniers @dblaikie @phosek Can we reach a consensus > here on how to output this kind of information? I feel like I've been told to > move towards remarks as th

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

Lounarok added a comment. > (//data member// is a variable inside a struct/class, but not a > "freestanding" one) Thanks for pointing that out. I misunderstood what //data member// is... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118743/new/ h

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4)

ChuanqiXu added a comment. > I'm getting confused by the semantics of --p1689-targeted-output=. In D137527 > , it's used to populate > CompilerCommand::Output which is supposed to be the main compiler output (.o > file). Is that correct? If that's not the case

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

pcwang-thead added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:568 -def : ProcessorModel<"generic-rv32", NoSchedModel, [Feature32Bit]>; -def : ProcessorModel<"generic-rv64", NoSchedModel, [Feature64Bit]>; +class RISCVProcessorModelPROCRISCVProcessorModel? RISCVP

[PATCH] D139458: [clangd] Full support for #import insertions

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.h:88 /// (These should be const, but RecursiveASTVisitor requires Decl*). - ArrayRef getLocalTopLevelDecls(); + ArrayRef getLocalTopLevelDecls() const; kadircet wrote: > can you

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

ravi-ramaseshan requested changes to this revision. ravi-ramaseshan added inline comments. Comment at: clang/tools/clang-stat-cache/clang-stat-cache.cpp:28 +#include +#include + Some of these includes may not be available on a platform like Windows. Can you pl

[PATCH] D140950: [X86] Support -march=emeraldrapids

FreddyYe created this revision. Herald added subscribers: Enna1, pengfei, hiraditya. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. Repository: rG LLVM Githu

[PATCH] D140950: [X86] Support -march=emeraldrapids

craig.topper added inline comments. Comment at: clang/docs/ReleaseNotes.rst:810 - Support intrinsics of ``_mm(256)_reduce_(max|min)_ep[i|u]8/16``. +- ``-march=emeraldrapids`` is now supported. Can this be on the same link as the other CPUs above? ===

[clang] 63d4686 - [LoongArch] Add intrinsics for MOVFCSR2GR and MOVGR2FCSR instructions

Author: Xiaodong Liu Date: 2023-01-04T14:11:30+08:00 New Revision: 63d46869ea5769693f7895be066f042929512e06 URL: https://github.com/llvm/llvm-project/commit/63d46869ea5769693f7895be066f042929512e06 DIFF: https://github.com/llvm/llvm-project/commit/63d46869ea5769693f7895be066f042929512e06.diff

[PATCH] D140685: [LoongArch] Add intrinsics for MOVFCSR2GR and MOVGR2FCSR instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG63d46869ea57: [LoongArch] Add intrinsics for MOVFCSR2GR and MOVGR2FCSR instructions (authored by XiaodongLoong). Repository: rG LLVM Github Monore

[PATCH] D140950: [X86] Support -march=emeraldrapids

FreddyYe updated this revision to Diff 486163. FreddyYe marked 4 inline comments as done. FreddyYe added a comment. Address comments. Thanks for review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140950/new/ https://reviews.llvm.org/D140950 Fil

[PATCH] D140954: [WIP][7/7][Clang][RISCV][NFC] Remove attribute `IsPrototypeDefaultTU`

eopXD created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sab

[PATCH] D138807: [RISCV] Support vector crypto extension ISA string and assembly

4vtomat updated this revision to Diff 486169. 4vtomat added a comment. Address Eric's comments! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138807/new/ https://reviews.llvm.org/D138807 Files: clang/test/Preprocessor/riscv-target-features.c l

[PATCH] D140954: [WIP][7/7][Clang][RISCV][NFC] Remove attribute `IsPrototypeDefaultTU`

eopXD updated this revision to Diff 486170. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140954/new/ https://reviews.llvm.org/D140954 Files: clang/include/clang/Basic/riscv_vector.td clang/include/clang/Support

[PATCH] D140896: [WIP] Move from llvm::makeArrayRef to ArrayRef deduction guides

serge-sans-paille updated this revision to Diff 486172. serge-sans-paille added a comment. Split the original patch in pieces: first just introduce the deduction guide. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140896/new/ https://reviews.llvm.org/D140896 Files: llvm/include/llvm

[PATCH] D140896: [WIP] Move from llvm::makeArrayRef to ArrayRef deduction guides

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3677ee65d192: Move from llvm::makeArrayRef to ArrayRef deduction g

[PATCH] D140954: [WIP][7/7][Clang][RISCV][NFC] Remove attribute `IsPrototypeDefaultTU`

eopXD updated this revision to Diff 486174. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140954/new/ https://reviews.llvm.org/D140954 Files: clang/include/clang/Basic/riscv_vector.td clang/include/clang/Support

[PATCH] D140929: [BPF] Support for "btf_decl_tag" annotations for arguments of extern functions

yonghong-song added a comment. Please separate the patch to clang and llvm part. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4218 + // DISubprogram's retainedNodes in the subsequent finalizeSubprogram call. + if (IsDeclForCallSite && CGM.getTarget().getTriple().isBPF()) { +

[PATCH] D139458: [clangd] Full support for #import insertions

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/AST.h:122 +/// Returns the Include Directive which should be used for include insertions +/// for the given main file.

[PATCH] D140929: [BPF] Support for "btf_decl_tag" annotations for arguments of extern functions

yonghong-song added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4218 + // DISubprogram's retainedNodes in the subsequent finalizeSubprogram call. + if (IsDeclForCallSite && CGM.getTarget().getTriple().isBPF()) { +if (auto *FD = dyn_cast(D)) {

<    1   2